X-Git-Url: https://code.grnet.gr/git/ganeti-local/blobdiff_plain/ae8419a2903cb27e79d7bbb5117d90352f3375a8..300e545069334c1e952c445700e60c51299976cc:/lib/ssh.py diff --git a/lib/ssh.py b/lib/ssh.py index 84ae692..4c4a18c 100644 --- a/lib/ssh.py +++ b/lib/ssh.py @@ -1,7 +1,7 @@ # # -# Copyright (C) 2006, 2007, 2010 Google Inc. +# Copyright (C) 2006, 2007, 2010, 2011 Google Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -32,6 +32,8 @@ from ganeti import utils from ganeti import errors from ganeti import constants from ganeti import netutils +from ganeti import pathutils +from ganeti import vcluster def FormatParamikoFingerprint(fingerprint): @@ -106,13 +108,13 @@ class SshRunner: @param quiet: whether to enable -q to ssh @rtype: list - @return: the list of options ready to use in L{utils.RunCmd} + @return: the list of options ready to use in L{utils.process.RunCmd} """ options = [ "-oEscapeChar=none", "-oHashKnownHosts=no", - "-oGlobalKnownHostsFile=%s" % constants.SSH_KNOWN_HOSTS_FILE, + "-oGlobalKnownHostsFile=%s" % pathutils.SSH_KNOWN_HOSTS_FILE, "-oUserKnownHostsFile=/dev/null", "-oCheckHostIp=no", ] @@ -183,7 +185,17 @@ class SshRunner: quiet=quiet)) if tty: argv.extend(["-t", "-t"]) - argv.extend(["%s@%s" % (user, hostname), command]) + + argv.append("%s@%s" % (user, hostname)) + + # Insert variables for virtual nodes + argv.extend("export %s=%s;" % + (utils.ShellQuote(name), utils.ShellQuote(value)) + for (name, value) in + vcluster.EnvironmentForHost(hostname).items()) + + argv.append(command) + return argv def Run(self, *args, **kwargs): @@ -194,8 +206,8 @@ class SshRunner: Args: see SshRunner.BuildCmd. - @rtype: L{utils.RunResult} - @return: the result as from L{utils.RunCmd()} + @rtype: L{utils.process.RunResult} + @return: the result as from L{utils.process.RunCmd()} """ return utils.RunCmd(self.BuildCmd(*args, **kwargs)) @@ -224,13 +236,13 @@ class SshRunner: if netutils.IP6Address.IsValid(node): node = netutils.FormatAddress((node, None)) - command.append("%s:%s" % (node, filename)) + command.append("%s:%s" % (node, vcluster.ExchangeNodeRoot(node, filename))) result = utils.RunCmd(command) if result.failed: - logging.error("Copy to node %s failed (%s) error %s," - " command was %s", + logging.error("Copy to node %s failed (%s) error '%s'," + " command was '%s'", node, result.fail_reason, result.output, result.cmd) return not result.failed @@ -254,7 +266,12 @@ class SshRunner: - detail: string with details """ - retval = self.Run(node, 'root', 'hostname --fqdn') + cmd = ("if test -z \"$GANETI_HOSTNAME\"; then" + " hostname --fqdn;" + "else" + " echo \"$GANETI_HOSTNAME\";" + "fi") + retval = self.Run(node, constants.SSH_LOGIN_USER, cmd, quiet=False) if retval.failed: msg = "ssh problem"