X-Git-Url: https://code.grnet.gr/git/ganeti-local/blobdiff_plain/d5114fa1a053e23f5f7658dfd633dd6f6001f78c..30f2802f21df7989e00aa82a37daecb3c7c3ecff:/Makefile.am diff --git a/Makefile.am b/Makefile.am index 719c14f..c0d8129 100644 --- a/Makefile.am +++ b/Makefile.am @@ -9,6 +9,11 @@ abs_top_builddir = @abs_top_builddir@ abs_top_srcdir = @abs_top_srcdir@ +# Helper values for calling builtin functions +empty := +space := $(empty) $(empty) +comma := , + # Use bash in order to be able to use pipefail SHELL=/bin/bash @@ -16,12 +21,16 @@ ACLOCAL_AMFLAGS = -I autotools BUILD_BASH_COMPLETION = $(top_srcdir)/autotools/build-bash-completion RUN_IN_TEMPDIR = $(top_srcdir)/autotools/run-in-tempdir CHECK_PYTHON_CODE = $(top_srcdir)/autotools/check-python-code -CHECK_MAN = $(top_srcdir)/autotools/check-man +CHECK_HEADER = $(top_srcdir)/autotools/check-header +CHECK_MAN_DASHES = $(top_srcdir)/autotools/check-man-dashes +CHECK_MAN_WARNINGS = $(top_srcdir)/autotools/check-man-warnings CHECK_VERSION = $(top_srcdir)/autotools/check-version CHECK_NEWS = $(top_srcdir)/autotools/check-news +CHECK_IMPORTS = $(top_srcdir)/autotools/check-imports DOCPP = $(top_srcdir)/autotools/docpp REPLACE_VARS_SED = autotools/replace_vars.sed CONVERT_CONSTANTS = $(top_srcdir)/autotools/convert-constants +BUILD_RPC = $(top_srcdir)/autotools/build-rpc # Note: these are automake-specific variables, and must be named after # the directory + 'dir' suffix @@ -39,6 +48,7 @@ toolsdir = $(pkglibdir)/tools iallocatorsdir = $(pkglibdir)/iallocators pytoolsdir = $(pkgpythondir)/tools docdir = $(datadir)/doc/$(PACKAGE) +myexeclibdir = $(pkglibdir) # Delete output file if an error occurred while building it .DELETE_ON_ERROR: @@ -46,6 +56,7 @@ docdir = $(datadir)/doc/$(PACKAGE) HTOOLS_DIRS = \ htools \ htools/Ganeti \ + htools/Ganeti/Confd \ htools/Ganeti/HTools \ htools/Ganeti/HTools/Program @@ -75,6 +86,10 @@ DIRS = \ qa \ test \ test/data \ + test/data/htools \ + test/data/htools/rapi \ + test/data/ovfdata \ + test/data/ovfdata/other \ tools BUILDTIME_DIR_AUTOCREATE = \ @@ -82,7 +97,9 @@ BUILDTIME_DIR_AUTOCREATE = \ $(APIDOC_DIR) \ $(APIDOC_PY_DIR) \ $(APIDOC_HS_DIR) \ - $(APIDOC_HS_DIR)/Ganeti $(APIDOC_HS_DIR)/Ganeti/HTools \ + $(APIDOC_HS_DIR)/Ganeti \ + $(APIDOC_HS_DIR)/Ganeti/Confd \ + $(APIDOC_HS_DIR)/Ganeti/HTools \ $(APIDOC_HS_DIR)/Ganeti/HTools/Program \ $(COVERAGE_DIR) \ $(COVERAGE_PY_DIR) \ @@ -130,35 +147,54 @@ CLEANFILES = \ daemons/daemon-util \ daemons/ganeti-cleaner \ devel/upload \ + $(BUILT_EXAMPLES) \ doc/examples/bash_completion \ - doc/examples/ganeti.initd \ - doc/examples/ganeti-kvm-poweroff.initd \ - doc/examples/ganeti.cron \ - doc/examples/gnt-config-backup \ - doc/examples/hooks/ipsec \ + lib/_generated_rpc.py \ $(man_MANS) \ $(manhtml) \ tools/kvm-ifup \ stamp-srclinks \ $(nodist_pkgpython_PYTHON) \ $(HS_ALL_PROGS) $(HS_BUILT_SRCS) \ + $(HS_BUILT_TEST_HELPERS) \ .hpc/*.mix htools/*.tix \ doc/hs-lint.html # BUILT_SOURCES should only be used as a dependency on phony targets. Otherwise # it'll cause the target to rebuild every time. BUILT_SOURCES = \ + $(built_base_sources) \ + $(BUILT_PYTHON_SOURCES) \ + $(PYTHON_BOOTSTRAP) + +built_base_sources = \ ganeti \ stamp-srclinks \ - lib/_autoconf.py \ - lib/_vcsversion.py \ - $(all_dirfiles) \ - $(PYTHON_BOOTSTRAP) + $(all_dirfiles) -nodist_pkgpython_PYTHON = \ +built_python_base_sources = \ lib/_autoconf.py \ lib/_vcsversion.py +BUILT_PYTHON_SOURCES = \ + $(built_python_base_sources) \ + lib/_generated_rpc.py + +# Generating the RPC wrappers depends on many things, so make sure it's built at +# the end of the built sources +lib/_generated_rpc.py: | $(built_base_sources) $(built_python_base_sources) + +# these are all built from the underlying %.in sources +BUILT_EXAMPLES = \ + doc/examples/ganeti-kvm-poweroff.initd \ + doc/examples/ganeti.cron \ + doc/examples/ganeti.initd \ + doc/examples/gnt-config-backup \ + doc/examples/hooks/ipsec + +nodist_pkgpython_PYTHON = \ + $(BUILT_PYTHON_SOURCES) + noinst_PYTHON = \ lib/build/__init__.py \ lib/build/sphinx_ext.py @@ -185,9 +221,11 @@ pkgpython_PYTHON = \ lib/netutils.py \ lib/objects.py \ lib/opcodes.py \ + lib/ovf.py \ lib/qlang.py \ lib/query.py \ lib/rpc.py \ + lib/rpc_defs.py \ lib/runtime.py \ lib/serializer.py \ lib/ssconf.py \ @@ -222,7 +260,8 @@ rapi_PYTHON = \ lib/rapi/client.py \ lib/rapi/client_utils.py \ lib/rapi/connector.py \ - lib/rapi/rlib2.py + lib/rapi/rlib2.py \ + lib/rapi/testutils.py http_PYTHON = \ lib/http/__init__.py \ @@ -294,8 +333,12 @@ docrst = \ doc/design-multi-reloc.rst \ doc/design-network.rst \ doc/design-chained-jobs.rst \ + doc/design-ovf-support.rst \ + doc/design-resource-model.rst \ doc/cluster-merge.rst \ doc/design-shared-storage.rst \ + doc/design-node-state-cache.rst \ + doc/design-virtual-clusters.rst \ doc/devnotes.rst \ doc/glossary.rst \ doc/hooks.rst \ @@ -312,17 +355,24 @@ docrst = \ doc/walkthrough.rst HS_PROGS = htools/htools -HS_BIN_ROLES = hbal hscan hspace +HS_BIN_ROLES = hbal hscan hspace hinfo -HS_ALL_PROGS = $(HS_PROGS) htools/test +HS_ALL_PROGS = $(HS_PROGS) htools/test htools/hpc-htools htools/hconfd HS_PROG_SRCS = $(patsubst %,%.hs,$(HS_ALL_PROGS)) +HS_BUILT_TEST_HELPERS = $(HS_BIN_ROLES:%=test/%) test/hail + # we don't add -Werror by default HFLAGS = -O -Wall -fwarn-monomorphism-restriction -fwarn-tabs -ihtools # extra flags that can be overriden on the command line HEXTRA = +# internal extra flags (used for htools/test mainly) +HEXTRA_INT = # exclude options for coverage reports -HPCEXCL = --exclude Main --exclude Ganeti.HTools.QC \ +HPCEXCL = --exclude Main \ --exclude Ganeti.Constants \ + --exclude Ganeti.THH \ + --exclude Ganeti.HTools.QC \ + --exclude Ganeti.HTools.QCHelper \ --exclude Ganeti.HTools.Version HS_LIB_SRCS = \ @@ -334,23 +384,38 @@ HS_LIB_SRCS = \ htools/Ganeti/HTools/Group.hs \ htools/Ganeti/HTools/IAlloc.hs \ htools/Ganeti/HTools/Instance.hs \ + htools/Ganeti/HTools/JSON.hs \ htools/Ganeti/HTools/Loader.hs \ htools/Ganeti/HTools/Luxi.hs \ htools/Ganeti/HTools/Node.hs \ htools/Ganeti/HTools/PeerMap.hs \ htools/Ganeti/HTools/QC.hs \ + htools/Ganeti/HTools/QCHelper.hs \ htools/Ganeti/HTools/Rapi.hs \ htools/Ganeti/HTools/Simu.hs \ htools/Ganeti/HTools/Text.hs \ htools/Ganeti/HTools/Types.hs \ htools/Ganeti/HTools/Utils.hs \ + htools/Ganeti/HTools/Program.hs \ htools/Ganeti/HTools/Program/Hail.hs \ htools/Ganeti/HTools/Program/Hbal.hs \ + htools/Ganeti/HTools/Program/Hinfo.hs \ htools/Ganeti/HTools/Program/Hscan.hs \ htools/Ganeti/HTools/Program/Hspace.hs \ + htools/Ganeti/BasicTypes.hs \ + htools/Ganeti/Confd.hs \ + htools/Ganeti/Confd/Server.hs \ + htools/Ganeti/Config.hs \ + htools/Ganeti/Daemon.hs \ + htools/Ganeti/Hash.hs \ htools/Ganeti/Jobs.hs \ + htools/Ganeti/Logging.hs \ htools/Ganeti/Luxi.hs \ - htools/Ganeti/OpCodes.hs + htools/Ganeti/Objects.hs \ + htools/Ganeti/OpCodes.hs \ + htools/Ganeti/Runtime.hs \ + htools/Ganeti/Ssconf.hs \ + htools/Ganeti/THH.hs HS_BUILT_SRCS = htools/Ganeti/HTools/Version.hs htools/Ganeti/Constants.hs HS_BUILT_SRCS_IN = $(patsubst %,%.in,$(HS_BUILT_SRCS)) @@ -364,7 +429,7 @@ $(RUN_IN_TEMPDIR): | $(all_dirfiles) # it changes doc/html/index.html: $(docrst) $(docpng) doc/conf.py configure.ac \ $(RUN_IN_TEMPDIR) lib/build/sphinx_ext.py lib/opcodes.py lib/ht.py \ - | lib/_autoconf.py lib/_vcsversion.py + | $(BUILT_PYTHON_SOURCES) @test -n "$(SPHINX)" || \ { echo 'sphinx-build' not found during configure; exit 1; } @mkdir_p@ $(dir $@) @@ -402,12 +467,8 @@ docpng = $(patsubst %.dot,%.png,$(docdot)) noinst_DATA = \ devel/upload \ doc/html \ + $(BUILT_EXAMPLES) \ doc/examples/bash_completion \ - doc/examples/ganeti.cron \ - doc/examples/ganeti.initd \ - doc/examples/ganeti-kvm-poweroff.initd \ - doc/examples/gnt-config-backup \ - doc/examples/hooks/ipsec \ $(manhtml) gnt_scripts = \ @@ -421,19 +482,15 @@ gnt_scripts = \ scripts/gnt-os PYTHON_BOOTSTRAP_SBIN = \ - daemons/ganeti-confd \ daemons/ganeti-masterd \ daemons/ganeti-noded \ daemons/ganeti-watcher \ daemons/ganeti-rapi \ - scripts/gnt-backup \ - scripts/gnt-cluster \ - scripts/gnt-debug \ - scripts/gnt-group \ - scripts/gnt-instance \ - scripts/gnt-job \ - scripts/gnt-node \ - scripts/gnt-os + $(gnt_scripts) + +if PY_CONFD +PYTHON_BOOTSTRAP_SBIN += daemons/ganeti-confd +endif PYTHON_BOOTSTRAP = \ $(PYTHON_BOOTSTRAP_SBIN) \ @@ -446,6 +503,7 @@ qa_scripts = \ qa/qa_daemon.py \ qa/qa_env.py \ qa/qa_error.py \ + qa/qa_group.py \ qa/qa_instance.py \ qa/qa_node.py \ qa/qa_os.py \ @@ -465,6 +523,9 @@ install-exec-hook: $(LN_S) -f htools \ $(DESTDIR)$(bindir)/$$role ; \ done +if HS_CONFD + mv $(DESTDIR)$(sbindir)/hconfd $(DESTDIR)$(sbindir)/ganeti-confd +endif endif $(HS_ALL_PROGS): %: %.hs $(HS_LIB_SRCS) $(HS_BUILT_SRCS) Makefile @@ -477,16 +538,37 @@ $(HS_ALL_PROGS): %: %.hs $(HS_LIB_SRCS) $(HS_BUILT_SRCS) Makefile echo "Error: cannot run unittests without the QuickCheck library (see devnotes.rst)" 1>&2; \ exit 1; \ fi + rm -f $(@:htools/%=%).tix BINARY=$(@:htools/%=%); $(GHC) --make \ - $(HFLAGS) $(HEXTRA) \ + $(HFLAGS) \ $(HTOOLS_NOCURL) $(HTOOLS_PARALLEL3) \ - -osuf $$BINARY.o -hisuf $$BINARY.hi $@ - + -osuf $$BINARY.o -hisuf $$BINARY.hi \ + $(HEXTRA) $(HEXTRA_INT) $@ # for the htools/test binary, we need to enable profiling/coverage -htools/test: HEXTRA=-fhpc -Wwarn -fno-warn-missing-signatures \ +htools/test: HEXTRA_INT=-fhpc -Wwarn -fno-warn-missing-signatures \ -fno-warn-monomorphism-restriction -fno-warn-orphans \ -fno-warn-missing-methods -fno-warn-unused-imports +# we compile the hpc-htools binary with the program coverage +htools/hpc-htools: HEXTRA_INT=-fhpc + +# test dependency +htools/offline-tests.sh: htools/hpc-htools + +# rules for building profiling-enabled versions of the haskell +# programs: hs-prof does the full two-step build, whereas +# hs-prof-quick does only the final rebuild (hs-prof must have been +# run before) +.PHONY: hs-prof hs-prof-quick +hs-prof: + $(MAKE) clean + $(MAKE) $(HS_ALL_PROGS) HEXTRA="-osuf .o" + rm -f $(HS_ALL_PROGS) + $(MAKE) hs-prof-quick + +hs-prof-quick: + $(MAKE) $(HS_ALL_PROGS) HEXTRA="-osuf .prof_o -prof -auto-all" + dist_sbin_SCRIPTS = \ tools/ganeti-listrunner @@ -494,21 +576,29 @@ nodist_sbin_SCRIPTS = \ $(PYTHON_BOOTSTRAP_SBIN) \ daemons/ganeti-cleaner -dist_tools_PYTHON = \ +if HS_CONFD +nodist_sbin_SCRIPTS += htools/hconfd +endif + +python_scripts = \ tools/burnin \ tools/cfgshell \ tools/cfgupgrade \ tools/cfgupgrade12 \ tools/cluster-merge \ + tools/confd-client \ + tools/fmtjson \ tools/lvmstrap \ tools/move-instance \ + tools/ovfconverter \ tools/setup-ssh \ tools/sanitize-config dist_tools_SCRIPTS = \ - $(dist_tools_PYTHON) \ + $(python_scripts) \ tools/kvm-console-wrapper \ - tools/xm-console-wrapper + tools/xm-console-wrapper \ + tools/master-ip-setup pkglib_python_scripts = \ daemons/import-export \ @@ -517,12 +607,12 @@ pkglib_python_scripts = \ nodist_pkglib_python_scripts = \ tools/ensure-dirs -pkglib_SCRIPTS = \ +myexeclib_SCRIPTS = \ daemons/daemon-util \ tools/kvm-ifup \ $(pkglib_python_scripts) -nodist_pkglib_SCRIPTS = \ +nodist_myexeclib_SCRIPTS = \ $(nodist_pkglib_python_scripts) EXTRA_DIST = \ @@ -531,8 +621,12 @@ EXTRA_DIST = \ epydoc.conf.in \ pylintrc \ autotools/build-bash-completion \ + autotools/build-rpc \ + autotools/check-header \ autotools/check-python-code \ - autotools/check-man \ + autotools/check-imports \ + autotools/check-man-dashes \ + autotools/check-man-warnings \ autotools/check-news \ autotools/check-tar \ autotools/check-version \ @@ -551,17 +645,14 @@ EXTRA_DIST = \ $(docrst) \ doc/conf.py \ doc/html \ - doc/examples/ganeti.initd.in \ - doc/examples/ganeti-kvm-poweroff.initd.in \ - doc/examples/ganeti.cron.in \ - doc/examples/gnt-config-backup.in \ + $(BUILT_EXAMPLES:%=%.in) \ doc/examples/ganeti.default \ doc/examples/ganeti.default-debug \ doc/examples/hooks/ethers \ - doc/examples/hooks/ipsec.in \ doc/examples/gnt-debug/README \ doc/examples/gnt-debug/delay0.json \ doc/examples/gnt-debug/delay50.json \ + test/lockperf.py \ test/testutils.py \ test/mocks.py \ $(dist_TESTS) \ @@ -572,7 +663,10 @@ EXTRA_DIST = \ qa/qa-sample.json \ $(qa_scripts) \ $(HS_LIB_SRCS) $(HS_BUILT_SRCS_IN) \ - $(HS_PROG_SRCS) + $(HS_PROG_SRCS) \ + htools/lint-hints.hs \ + htools/cli-tests-defs.sh \ + htools/offline-test.sh man_MANS = \ man/ganeti.7 \ @@ -594,6 +688,7 @@ man_MANS = \ man/gnt-os.8 \ man/hail.1 \ man/hbal.1 \ + man/hinfo.1 \ man/hscan.1 \ man/hspace.1 \ man/htools.1 @@ -613,11 +708,80 @@ TEST_FILES = \ test/data/bdev-drbd-net-ip4.txt \ test/data/bdev-drbd-net-ip6.txt \ test/data/cert1.pem \ + test/data/ip-addr-show-dummy0.txt \ + test/data/ip-addr-show-lo-ipv4.txt \ + test/data/ip-addr-show-lo-ipv6.txt \ + test/data/ip-addr-show-lo-oneline-ipv4.txt \ + test/data/ip-addr-show-lo-oneline-ipv6.txt \ + test/data/ip-addr-show-lo-oneline.txt \ + test/data/ip-addr-show-lo.txt \ test/data/proc_drbd8.txt \ test/data/proc_drbd80-emptyline.txt \ test/data/proc_drbd83.txt \ + test/data/proc_drbd83_sync.txt \ + test/data/proc_drbd83_sync_krnl2.6.39.txt \ + test/data/kvm_1.0_help.txt \ + test/data/kvm_0.15.90_help.txt \ + test/data/kvm_0.12.5_help.txt \ + test/data/kvm_0.9.1_help.txt \ test/data/sys_drbd_usermode_helper.txt \ - test/import-export_unittest-helper + test/data/htools/hail-alloc-drbd.json \ + test/data/htools/hail-change-group.json \ + test/data/htools/hail-invalid-reloc.json \ + test/data/htools/hail-node-evac.json \ + test/data/htools/hail-reloc-drbd.json \ + test/data/htools/common-suffix.data \ + test/data/htools/invalid-node.data \ + test/data/htools/missing-resources.data \ + test/data/htools/rapi/groups.json \ + test/data/htools/rapi/info.json \ + test/data/htools/rapi/instances.json \ + test/data/htools/rapi/nodes.json \ + test/data/ovfdata/compr_disk.vmdk.gz \ + test/data/ovfdata/config.ini \ + test/data/ovfdata/corrupted_resources.ovf \ + test/data/ovfdata/empty.ini \ + test/data/ovfdata/empty.ovf \ + test/data/ovfdata/ganeti.mf \ + test/data/ovfdata/ganeti.ovf \ + test/data/ovfdata/gzip_disk.ovf \ + test/data/ovfdata/new_disk.vmdk \ + test/data/ovfdata/no_disk.ini \ + test/data/ovfdata/no_disk_in_ref.ovf \ + test/data/ovfdata/no_os.ini \ + test/data/ovfdata/no_ovf.ova \ + test/data/ovfdata/ova.ova \ + test/data/ovfdata/second_disk.vmdk \ + test/data/ovfdata/rawdisk.raw \ + test/data/ovfdata/unsafe_path.ini \ + test/data/ovfdata/virtualbox.ovf \ + test/data/ovfdata/wrong_extension.ovd \ + test/data/ovfdata/wrong_config.ini \ + test/data/ovfdata/wrong_manifest.mf \ + test/data/ovfdata/wrong_manifest.ovf \ + test/data/ovfdata/wrong_ova.ova \ + test/data/ovfdata/wrong_xml.ovf \ + test/data/ovfdata/other/rawdisk.raw \ + test/data/vgreduce-removemissing-2.02.02.txt \ + test/data/vgreduce-removemissing-2.02.66-fail.txt \ + test/data/vgreduce-removemissing-2.02.66-ok.txt \ + test/data/vgs-missing-pvs-2.02.02.txt \ + test/data/vgs-missing-pvs-2.02.66.txt \ + test/import-export_unittest-helper \ + test/gnt-cli.test \ + test/ganeti-cli.test \ + test/htools-balancing.test \ + test/htools-basic.test \ + test/htools-dynutil.test \ + test/htools-excl.test \ + test/htools-hail.test \ + test/htools-hspace.test \ + test/htools-invalid.test \ + test/htools-multi-group.test \ + test/htools-no-backend.test \ + test/htools-rapi.test \ + test/htools-single-group.test \ + test/htools-text-backend.test python_tests = \ test/ganeti.asyncnotifier_unittest.py \ @@ -651,16 +815,19 @@ python_tests = \ test/ganeti.netutils_unittest.py \ test/ganeti.objects_unittest.py \ test/ganeti.opcodes_unittest.py \ + test/ganeti.ovf_unittest.py \ test/ganeti.qlang_unittest.py \ test/ganeti.query_unittest.py \ test/ganeti.rapi.baserlib_unittest.py \ test/ganeti.rapi.client_unittest.py \ test/ganeti.rapi.resources_unittest.py \ test/ganeti.rapi.rlib2_unittest.py \ + test/ganeti.rapi.testutils_unittest.py \ test/ganeti.rpc_unittest.py \ test/ganeti.runtime_unittest.py \ test/ganeti.serializer_unittest.py \ test/ganeti.ssh_unittest.py \ + test/ganeti.storage_unittest.py \ test/ganeti.tools.ensure_dirs_unittest.py \ test/ganeti.uidpool_unittest.py \ test/ganeti.utils.algo_unittest.py \ @@ -679,7 +846,11 @@ python_tests = \ test/ganeti.workerpool_unittest.py \ test/cfgupgrade_unittest.py \ test/docs_unittest.py \ + test/pycurl_reset_unittest.py \ test/tempfile_fork_unittest.py +if HAS_FAKEROOT +python_tests += test/ganeti.utils.io_unittest-runasroot.py +endif haskell_tests = htools/test @@ -688,18 +859,26 @@ dist_TESTS = \ test/daemon-util_unittest.bash \ test/ganeti-cleaner_unittest.bash \ test/import-export_unittest.bash \ + test/cli-test.bash \ $(python_tests) nodist_TESTS = +check_SCRIPTS = + if WANT_HTOOLSTESTS nodist_TESTS += $(haskell_tests) +dist_TESTS += htools/offline-test.sh +check_SCRIPTS += htools/hpc-htools $(HS_BUILT_TEST_HELPERS) endif TESTS = $(dist_TESTS) $(nodist_TESTS) # Environment for all tests PLAIN_TESTS_ENVIRONMENT = \ - PYTHONPATH=. TOP_SRCDIR=$(abs_top_srcdir) PYTHON=$(PYTHON) $(RUN_IN_TEMPDIR) + PYTHONPATH=. \ + TOP_SRCDIR=$(abs_top_srcdir) TOP_BUILDDIR=$(abs_top_builddir) \ + PYTHON=$(PYTHON) FAKEROOT=$(FAKEROOT_PATH) \ + $(RUN_IN_TEMPDIR) # Environment for tests run by automake TESTS_ENVIRONMENT = \ @@ -707,7 +886,7 @@ TESTS_ENVIRONMENT = \ all_python_code = \ $(dist_sbin_SCRIPTS) \ - $(dist_tools_PYTHON) \ + $(python_scripts) \ $(pkglib_python_scripts) \ $(nodist_pkglib_python_scripts) \ $(python_tests) \ @@ -732,11 +911,16 @@ srclink_files = \ test/daemon-util_unittest.bash \ test/ganeti-cleaner_unittest.bash \ test/import-export_unittest.bash \ + test/cli-test.bash \ + htools/offline-test.sh \ + htools/cli-tests-defs.sh \ $(all_python_code) \ $(HS_LIB_SRCS) $(HS_PROG_SRCS) check_python_code = \ $(BUILD_BASH_COMPLETION) \ + $(CHECK_IMPORTS) \ + $(CHECK_HEADER) \ $(DOCPP) \ $(all_python_code) @@ -744,12 +928,30 @@ lint_python_code = \ ganeti \ ganeti/http/server.py \ $(dist_sbin_SCRIPTS) \ - $(dist_tools_PYTHON) \ + $(python_scripts) \ $(pkglib_python_scripts) \ $(BUILD_BASH_COMPLETION) \ + $(CHECK_IMPORTS) \ + $(CHECK_HEADER) \ $(DOCPP) \ $(PYTHON_BOOTSTRAP) +standalone_python_modules = \ + lib/rapi/client.py \ + tools/ganeti-listrunner + +pep8_python_code = \ + ganeti \ + ganeti/http/server.py \ + $(dist_sbin_SCRIPTS) \ + $(python_scripts) \ + $(pkglib_python_scripts) \ + $(BUILD_BASH_COMPLETION) \ + $(CHECK_HEADER) \ + $(DOCPP) \ + $(PYTHON_BOOTSTRAP) \ + qa + test/daemon-util_unittest.bash: daemons/daemon-util test/ganeti-cleaner_unittest.bash: daemons/ganeti-cleaner @@ -797,9 +999,13 @@ man/%.7.in man/%.8.in man/%.1.in: man/%.gen man/footer.man @test -n "$(PANDOC)" || \ { echo 'pandoc' not found during configure; exit 1; } set -o pipefail ; \ + trap 'echo auto-removing $@; rm $@' EXIT; \ $(PANDOC) -s -f rst -t man -A man/footer.man $< | \ - sed -e 's/\\@/@/g' > $@ - if test -n "$(MAN_HAS_WARNINGS)"; then $(CHECK_MAN) $@; fi + sed -e 's/\\@/@/g' > $@; \ + if test -n "$(MAN_HAS_WARNINGS)"; then $(CHECK_MAN_WARNINGS) $@; fi; \ + $(CHECK_MAN_DASHES) $@; \ + trap - EXIT + man/%.html.in: man/%.gen man/footer.html @test -n "$(PANDOC)" || \ @@ -845,7 +1051,8 @@ htools/Ganeti/HTools/Version.hs: htools/Ganeti/HTools/Version.hs.in vcs-version sed -e "s/%ver%/$$VCSVER/" < $< > $@ htools/Ganeti/Constants.hs: htools/Ganeti/Constants.hs.in \ - lib/constants.py lib/_autoconf.py $(CONVERT_CONSTANTS) + lib/constants.py lib/_autoconf.py $(CONVERT_CONSTANTS) \ + | lib/_vcsversion.py set -e; \ { cat $< ; PYTHONPATH=. $(CONVERT_CONSTANTS); } > $@ @@ -862,7 +1069,7 @@ lib/_autoconf.py: Makefile | lib/.dir echo ''; \ echo '"""'; \ echo ''; \ - echo '# pylint: disable-msg=C0301,C0324'; \ + echo '# pylint: disable=C0301,C0324'; \ echo '# because this is autogenerated, we do not want'; \ echo '# style warnings' ; \ echo ''; \ @@ -886,6 +1093,7 @@ lib/_autoconf.py: Makefile | lib/.dir echo "ENABLE_SHARED_FILE_STORAGE = $(ENABLE_SHARED_FILE_STORAGE)"; \ echo "IALLOCATOR_SEARCH_PATH = [$(IALLOCATOR_SEARCH_PATH)]"; \ echo "KVM_PATH = '$(KVM_PATH)'"; \ + echo "IP_PATH = '$(IP_PATH)'"; \ echo "SOCAT_PATH = '$(SOCAT)'"; \ echo "SOCAT_USE_ESCAPE = $(SOCAT_USE_ESCAPE)"; \ echo "SOCAT_USE_COMPRESS = $(SOCAT_USE_COMPRESS)"; \ @@ -893,7 +1101,8 @@ lib/_autoconf.py: Makefile | lib/.dir echo "TOOLSDIR = '$(toolsdir)'"; \ echo "GNT_SCRIPTS = [$(foreach i,$(notdir $(gnt_scripts)),'$(i)',)]"; \ echo "PKGLIBDIR = '$(pkglibdir)'"; \ - echo "DRBD_BARRIERS = $(DRBD_BARRIERS)"; \ + echo "DRBD_BARRIERS = '$(DRBD_BARRIERS)'"; \ + echo "DRBD_NO_META_FLUSH = $(DRBD_NO_META_FLUSH)"; \ echo "SYSLOG_USAGE = '$(SYSLOG_USAGE)'"; \ echo "DAEMONS_GROUP = '$(DAEMONS_GROUP)'"; \ echo "ADMIN_GROUP = '$(ADMIN_GROUP)'"; \ @@ -906,11 +1115,15 @@ lib/_autoconf.py: Makefile | lib/.dir echo "NODED_USER = '$(NODED_USER)'"; \ echo "NODED_GROUP = '$(NODED_GROUP)'"; \ echo "DISK_SEPARATOR = '$(DISK_SEPARATOR)'"; \ + echo "QEMUIMG_PATH = '$(QEMUIMG_PATH)'"; \ if [ "$(HTOOLS)" ]; then \ echo "HTOOLS = True"; \ else \ echo "HTOOLS = False"; \ fi; \ + echo "ENABLE_CONFD = $(ENABLE_CONFD)"; \ + echo "PY_CONFD = $(PY_CONFD)"; \ + echo "HS_CONFD = $(HS_CONFD)"; \ } > $@ lib/_vcsversion.py: Makefile vcs-version | lib/.dir @@ -927,13 +1140,16 @@ lib/_vcsversion.py: Makefile vcs-version | lib/.dir echo ''; \ echo '"""'; \ echo ''; \ - echo '# pylint: disable-msg=C0301,C0324'; \ + echo '# pylint: disable=C0301,C0324'; \ echo '# because this is autogenerated, we do not want'; \ echo '# style warnings' ; \ echo ''; \ echo "VCS_VERSION = '$$VCSVER'"; \ } > $@ +lib/_generated_rpc.py: lib/rpc_defs.py $(BUILD_RPC) + PYTHONPATH=. $(RUN_IN_TEMPDIR) $(CURDIR)/$(BUILD_RPC) lib/rpc_defs.py > $@ + $(REPLACE_VARS_SED): Makefile set -e; \ { echo 's#@PREFIX@#$(prefix)#g'; \ @@ -959,6 +1175,7 @@ $(REPLACE_VARS_SED): Makefile echo 's#@GNTCONFDGROUP@#$(CONFD_GROUP)#g'; \ echo 's#@GNTMASTERDGROUP@#$(MASTERD_GROUP)#g'; \ echo 's#@GNTDAEMONSGROUP@#$(DAEMONS_GROUP)#g'; \ + echo 's#@CUSTOM_ENABLE_CONFD@#$(ENABLE_CONFD)#g'; \ } > $@ # Using deferred evaluation @@ -966,6 +1183,7 @@ daemons/ganeti-%: MODULE = ganeti.server.$(patsubst ganeti-%,%,$(notdir $@)) daemons/ganeti-watcher: MODULE = ganeti.watcher scripts/%: MODULE = ganeti.client.$(subst -,_,$(notdir $@)) tools/ensure-dirs: MODULE = ganeti.tools.ensure_dirs +$(HS_BUILT_TEST_HELPERS): TESTROLE = $(patsubst test/%,%,$@) $(PYTHON_BOOTSTRAP): Makefile | $(all_dirfiles) test -n "$(MODULE)" || { echo Missing module; exit 1; } @@ -976,7 +1194,7 @@ $(PYTHON_BOOTSTRAP): Makefile | $(all_dirfiles) echo; \ echo '"""Bootstrap script for L{$(MODULE)}"""'; \ echo; \ - echo '# pylint: disable-msg=C0103'; \ + echo '# pylint: disable=C0103'; \ echo '# C0103: Invalid name'; \ echo; \ echo 'import sys'; \ @@ -985,15 +1203,26 @@ $(PYTHON_BOOTSTRAP): Makefile | $(all_dirfiles) echo '# Temporarily alias commands until bash completion'; \ echo '# generator is changed'; \ echo 'if hasattr(main, "commands"):'; \ - echo ' commands = main.commands # pylint: disable-msg=E1101'; \ + echo ' commands = main.commands # pylint: disable=E1101'; \ echo 'if hasattr(main, "aliases"):'; \ - echo ' aliases = main.aliases # pylint: disable-msg=E1101'; \ + echo ' aliases = main.aliases # pylint: disable=E1101'; \ echo; \ echo 'if __name__ == "__main__":'; \ echo ' sys.exit(main.Main())'; \ } > $@ chmod u+x $@ +$(HS_BUILT_TEST_HELPERS): Makefile + @test -n "$(TESTROLE)" || { echo Missing TESTROLE; exit 1; } + set -e; \ + { echo '#!/bin/sh'; \ + echo '# This file is automatically generated, do not edit!'; \ + echo "# Edit Makefile.am instead."; \ + echo; \ + echo "HTOOLS=$(TESTROLE) exec ./htools/hpc-htools \"\$$@\""; \ + } > $@ + chmod u+x $@ + # We need to create symlinks because "make distcheck" will not install Python # files when building. stamp-srclinks: Makefile | $(all_dirfiles) @@ -1032,10 +1261,13 @@ check-dirs: $(BUILT_SOURCES) if test -n "$$error"; then exit 1; else exit 0; fi; \ } -check-local: check-dirs +.PHONY: check-local +check-local: check-dirs $(BUILT_SOURCES) $(CHECK_PYTHON_CODE) $(check_python_code) + PYTHONPATH=. $(CHECK_HEADER) $(check_python_code) $(CHECK_VERSION) $(VERSION) $(top_srcdir)/NEWS $(CHECK_NEWS) < $(top_srcdir)/NEWS + PYTHONPATH=. $(RUN_IN_TEMPDIR) $(CURDIR)/$(CHECK_IMPORTS) . $(standalone_python_modules) expver=$(VERSION_MAJOR).$(VERSION_MINOR); \ if test "`head -n 1 $(top_srcdir)/README`" != "Ganeti $$expver"; then \ echo "Incorrect version in README, expected $$expver"; \ @@ -1043,29 +1275,51 @@ check-local: check-dirs fi; \ for file in doc/iallocator.rst doc/hooks.rst; do \ if test "`sed -ne '4 p' $(top_srcdir)/$$file`" != \ - "Documents Ganeti version $$expver"; then \ + "Documents Ganeti version $$expver"; then \ echo "Incorrect version in $$file, expected $$expver"; \ exit 1; \ fi; \ done .PHONY: hs-check -hs-check: htools/test +hs-check: htools/test htools/hpc-htools $(HS_BUILT_TEST_HELPERS) @rm -f test.tix ./htools/test + HBINARY="./htools/hpc-htools" ./htools/offline-test.sh + +# E111: indentation is not a multiple of four +# E261: at least two spaces before inline comment +# E501: line too long (80 characters) +PEP8_IGNORE = E111,E261,E501 + +# For excluding pep8 expects filenames only, not whole paths +PEP8_EXCLUDE = $(subst $(space),$(comma),$(strip $(notdir $(BUILT_PYTHON_SOURCES)))) .PHONY: lint lint: $(BUILT_SOURCES) @test -n "$(PYLINT)" || { echo 'pylint' not found during configure; exit 1; } + if test -z "$(PEP8)"; then \ + echo '"pep8" not found during configure' >&2; \ + else \ + $(PEP8) --repeat --ignore='$(PEP8_IGNORE)' --exclude='$(PEP8_EXCLUDE)' \ + $(pep8_python_code); \ + fi $(PYLINT) $(LINT_OPTS) $(lint_python_code) cd $(top_srcdir)/qa && \ PYTHONPATH=$(abs_top_srcdir) $(PYLINT) $(LINT_OPTS) \ --rcfile ../pylintrc $(patsubst qa/%.py,%,$(qa_scripts)) .PHONY: hlint -hlint: $(HS_BUILT_SRCS) +hlint: $(HS_BUILT_SRCS) htools/lint-hints.hs if tty -s; then C="-c"; else C=""; fi; \ - hlint --report=doc/hs-lint.html $$C htools + hlint --report=doc/hs-lint.html --cross $$C \ + --ignore "Use first" \ + --ignore "Use comparing" \ + --ignore "Use on" \ + --ignore "Use Control.Exception.catch" \ + --ignore "Reduce duplication" \ + --hint htools/lint-hints \ + $(filter-out htools/Ganeti/THH.hs,$(HS_LIB_SRCS)) # a dist hook rule for updating the vcs-version file; this is # hardcoded due to where it needs to build the file... @@ -1146,8 +1400,10 @@ hs-apidoc: $(HS_BUILT_SRCS) { echo 'haddock' not found during configure; exit 1; } rm -rf $(APIDOC_HS_DIR)/* @mkdir_p@ $(APIDOC_HS_DIR)/Ganeti/HTools/Program + @mkdir_p@ $(APIDOC_HS_DIR)/Ganeti/Confd $(HSCOLOUR) -print-css > $(APIDOC_HS_DIR)/Ganeti/hscolour.css - ln -s ../hscolour.css $(APIDOC_HS_DIR)/Ganeti/HTools/hscolour.css + $(LN_S) ../hscolour.css $(APIDOC_HS_DIR)/Ganeti/HTools/hscolour.css + $(LN_S) ../hscolour.css $(APIDOC_HS_DIR)/Ganeti/Confd/hscolour.css set -e ; \ cd htools; \ if [ "$(HTOOLS_NOCURL)" ]; \ @@ -1194,12 +1450,13 @@ py-coverage: $(BUILT_SOURCES) $(python_tests) $(python_tests) .PHONY: hs-coverage -hs-coverage: $(haskell_tests) - cd htools && rm -f *.tix *.mix && ./test +hs-coverage: $(haskell_tests) htools/hpc-htools + rm -f *.tix && $(MAKE) hs-check @mkdir_p@ $(COVERAGE_HS_DIR) - hpc markup --destdir=$(COVERAGE_HS_DIR) htools/test $(HPCEXCL) - hpc report htools/test $(HPCEXCL) - ln -sf hpc_index.html $(COVERAGE_HS_DIR)/index.html + hpc combine $(HPCEXCL) test.tix hpc-htools.tix > coverage-htools.tix + hpc markup --destdir=$(COVERAGE_HS_DIR) coverage-htools.tix + hpc report coverage-htools.tix + $(LN_S) -f hpc_index.html $(COVERAGE_HS_DIR)/index.html # Special "kind-of-QA" target for htools, needs special setup (all # tools compiled with -fhpc) @@ -1207,7 +1464,7 @@ hs-coverage: $(haskell_tests) live-test: all set -e ; \ cd htools; \ - rm -f .hpc; ln -s ../.hpc .hpc; \ + rm -f .hpc; $(LN_S) ../.hpc .hpc; \ rm -f *.tix *.mix; \ ./live-test.sh; \ hpc sum --union $(HPCEXCL) $(addsuffix .tix,$(HS_PROGS:htools/%=%)) \