X-Git-Url: https://code.grnet.gr/git/ganeti-local/blobdiff_plain/d85f01e740047c985061fe7b91b1305ac5ab6727..30f2802f21df7989e00aa82a37daecb3c7c3ecff:/Makefile.am diff --git a/Makefile.am b/Makefile.am index 9cc5b80..c0d8129 100644 --- a/Makefile.am +++ b/Makefile.am @@ -21,13 +21,16 @@ ACLOCAL_AMFLAGS = -I autotools BUILD_BASH_COMPLETION = $(top_srcdir)/autotools/build-bash-completion RUN_IN_TEMPDIR = $(top_srcdir)/autotools/run-in-tempdir CHECK_PYTHON_CODE = $(top_srcdir)/autotools/check-python-code -CHECK_MAN = $(top_srcdir)/autotools/check-man +CHECK_HEADER = $(top_srcdir)/autotools/check-header +CHECK_MAN_DASHES = $(top_srcdir)/autotools/check-man-dashes +CHECK_MAN_WARNINGS = $(top_srcdir)/autotools/check-man-warnings CHECK_VERSION = $(top_srcdir)/autotools/check-version CHECK_NEWS = $(top_srcdir)/autotools/check-news CHECK_IMPORTS = $(top_srcdir)/autotools/check-imports DOCPP = $(top_srcdir)/autotools/docpp REPLACE_VARS_SED = autotools/replace_vars.sed CONVERT_CONSTANTS = $(top_srcdir)/autotools/convert-constants +BUILD_RPC = $(top_srcdir)/autotools/build-rpc # Note: these are automake-specific variables, and must be named after # the directory + 'dir' suffix @@ -45,6 +48,7 @@ toolsdir = $(pkglibdir)/tools iallocatorsdir = $(pkglibdir)/iallocators pytoolsdir = $(pkgpythondir)/tools docdir = $(datadir)/doc/$(PACKAGE) +myexeclibdir = $(pkglibdir) # Delete output file if an error occurred while building it .DELETE_ON_ERROR: @@ -52,6 +56,7 @@ docdir = $(datadir)/doc/$(PACKAGE) HTOOLS_DIRS = \ htools \ htools/Ganeti \ + htools/Ganeti/Confd \ htools/Ganeti/HTools \ htools/Ganeti/HTools/Program @@ -81,6 +86,8 @@ DIRS = \ qa \ test \ test/data \ + test/data/htools \ + test/data/htools/rapi \ test/data/ovfdata \ test/data/ovfdata/other \ tools @@ -90,7 +97,9 @@ BUILDTIME_DIR_AUTOCREATE = \ $(APIDOC_DIR) \ $(APIDOC_PY_DIR) \ $(APIDOC_HS_DIR) \ - $(APIDOC_HS_DIR)/Ganeti $(APIDOC_HS_DIR)/Ganeti/HTools \ + $(APIDOC_HS_DIR)/Ganeti \ + $(APIDOC_HS_DIR)/Ganeti/Confd \ + $(APIDOC_HS_DIR)/Ganeti/HTools \ $(APIDOC_HS_DIR)/Ganeti/HTools/Program \ $(COVERAGE_DIR) \ $(COVERAGE_PY_DIR) \ @@ -138,34 +147,51 @@ CLEANFILES = \ daemons/daemon-util \ daemons/ganeti-cleaner \ devel/upload \ + $(BUILT_EXAMPLES) \ doc/examples/bash_completion \ - doc/examples/ganeti.initd \ - doc/examples/ganeti-kvm-poweroff.initd \ - doc/examples/ganeti.cron \ - doc/examples/gnt-config-backup \ - doc/examples/hooks/ipsec \ + lib/_generated_rpc.py \ $(man_MANS) \ $(manhtml) \ tools/kvm-ifup \ stamp-srclinks \ $(nodist_pkgpython_PYTHON) \ $(HS_ALL_PROGS) $(HS_BUILT_SRCS) \ + $(HS_BUILT_TEST_HELPERS) \ .hpc/*.mix htools/*.tix \ doc/hs-lint.html # BUILT_SOURCES should only be used as a dependency on phony targets. Otherwise # it'll cause the target to rebuild every time. BUILT_SOURCES = \ + $(built_base_sources) \ + $(BUILT_PYTHON_SOURCES) \ + $(PYTHON_BOOTSTRAP) + +built_base_sources = \ ganeti \ stamp-srclinks \ - $(all_dirfiles) \ - $(PYTHON_BOOTSTRAP) \ - $(BUILT_PYTHON_SOURCES) + $(all_dirfiles) -BUILT_PYTHON_SOURCES = \ +built_python_base_sources = \ lib/_autoconf.py \ lib/_vcsversion.py +BUILT_PYTHON_SOURCES = \ + $(built_python_base_sources) \ + lib/_generated_rpc.py + +# Generating the RPC wrappers depends on many things, so make sure it's built at +# the end of the built sources +lib/_generated_rpc.py: | $(built_base_sources) $(built_python_base_sources) + +# these are all built from the underlying %.in sources +BUILT_EXAMPLES = \ + doc/examples/ganeti-kvm-poweroff.initd \ + doc/examples/ganeti.cron \ + doc/examples/ganeti.initd \ + doc/examples/gnt-config-backup \ + doc/examples/hooks/ipsec + nodist_pkgpython_PYTHON = \ $(BUILT_PYTHON_SOURCES) @@ -199,6 +225,7 @@ pkgpython_PYTHON = \ lib/qlang.py \ lib/query.py \ lib/rpc.py \ + lib/rpc_defs.py \ lib/runtime.py \ lib/serializer.py \ lib/ssconf.py \ @@ -233,7 +260,8 @@ rapi_PYTHON = \ lib/rapi/client.py \ lib/rapi/client_utils.py \ lib/rapi/connector.py \ - lib/rapi/rlib2.py + lib/rapi/rlib2.py \ + lib/rapi/testutils.py http_PYTHON = \ lib/http/__init__.py \ @@ -310,6 +338,7 @@ docrst = \ doc/cluster-merge.rst \ doc/design-shared-storage.rst \ doc/design-node-state-cache.rst \ + doc/design-virtual-clusters.rst \ doc/devnotes.rst \ doc/glossary.rst \ doc/hooks.rst \ @@ -326,14 +355,18 @@ docrst = \ doc/walkthrough.rst HS_PROGS = htools/htools -HS_BIN_ROLES = hbal hscan hspace +HS_BIN_ROLES = hbal hscan hspace hinfo -HS_ALL_PROGS = $(HS_PROGS) htools/test +HS_ALL_PROGS = $(HS_PROGS) htools/test htools/hpc-htools htools/hconfd HS_PROG_SRCS = $(patsubst %,%.hs,$(HS_ALL_PROGS)) +HS_BUILT_TEST_HELPERS = $(HS_BIN_ROLES:%=test/%) test/hail + # we don't add -Werror by default HFLAGS = -O -Wall -fwarn-monomorphism-restriction -fwarn-tabs -ihtools # extra flags that can be overriden on the command line HEXTRA = +# internal extra flags (used for htools/test mainly) +HEXTRA_INT = # exclude options for coverage reports HPCEXCL = --exclude Main \ --exclude Ganeti.Constants \ @@ -363,13 +396,25 @@ HS_LIB_SRCS = \ htools/Ganeti/HTools/Text.hs \ htools/Ganeti/HTools/Types.hs \ htools/Ganeti/HTools/Utils.hs \ + htools/Ganeti/HTools/Program.hs \ htools/Ganeti/HTools/Program/Hail.hs \ htools/Ganeti/HTools/Program/Hbal.hs \ + htools/Ganeti/HTools/Program/Hinfo.hs \ htools/Ganeti/HTools/Program/Hscan.hs \ htools/Ganeti/HTools/Program/Hspace.hs \ + htools/Ganeti/BasicTypes.hs \ + htools/Ganeti/Confd.hs \ + htools/Ganeti/Confd/Server.hs \ + htools/Ganeti/Config.hs \ + htools/Ganeti/Daemon.hs \ + htools/Ganeti/Hash.hs \ htools/Ganeti/Jobs.hs \ + htools/Ganeti/Logging.hs \ htools/Ganeti/Luxi.hs \ + htools/Ganeti/Objects.hs \ htools/Ganeti/OpCodes.hs \ + htools/Ganeti/Runtime.hs \ + htools/Ganeti/Ssconf.hs \ htools/Ganeti/THH.hs HS_BUILT_SRCS = htools/Ganeti/HTools/Version.hs htools/Ganeti/Constants.hs @@ -422,12 +467,8 @@ docpng = $(patsubst %.dot,%.png,$(docdot)) noinst_DATA = \ devel/upload \ doc/html \ + $(BUILT_EXAMPLES) \ doc/examples/bash_completion \ - doc/examples/ganeti.cron \ - doc/examples/ganeti.initd \ - doc/examples/ganeti-kvm-poweroff.initd \ - doc/examples/gnt-config-backup \ - doc/examples/hooks/ipsec \ $(manhtml) gnt_scripts = \ @@ -441,19 +482,15 @@ gnt_scripts = \ scripts/gnt-os PYTHON_BOOTSTRAP_SBIN = \ - daemons/ganeti-confd \ daemons/ganeti-masterd \ daemons/ganeti-noded \ daemons/ganeti-watcher \ daemons/ganeti-rapi \ - scripts/gnt-backup \ - scripts/gnt-cluster \ - scripts/gnt-debug \ - scripts/gnt-group \ - scripts/gnt-instance \ - scripts/gnt-job \ - scripts/gnt-node \ - scripts/gnt-os + $(gnt_scripts) + +if PY_CONFD +PYTHON_BOOTSTRAP_SBIN += daemons/ganeti-confd +endif PYTHON_BOOTSTRAP = \ $(PYTHON_BOOTSTRAP_SBIN) \ @@ -486,6 +523,9 @@ install-exec-hook: $(LN_S) -f htools \ $(DESTDIR)$(bindir)/$$role ; \ done +if HS_CONFD + mv $(DESTDIR)$(sbindir)/hconfd $(DESTDIR)$(sbindir)/ganeti-confd +endif endif $(HS_ALL_PROGS): %: %.hs $(HS_LIB_SRCS) $(HS_BUILT_SRCS) Makefile @@ -498,16 +538,37 @@ $(HS_ALL_PROGS): %: %.hs $(HS_LIB_SRCS) $(HS_BUILT_SRCS) Makefile echo "Error: cannot run unittests without the QuickCheck library (see devnotes.rst)" 1>&2; \ exit 1; \ fi + rm -f $(@:htools/%=%).tix BINARY=$(@:htools/%=%); $(GHC) --make \ - $(HFLAGS) $(HEXTRA) \ + $(HFLAGS) \ $(HTOOLS_NOCURL) $(HTOOLS_PARALLEL3) \ - -osuf $$BINARY.o -hisuf $$BINARY.hi $@ - + -osuf $$BINARY.o -hisuf $$BINARY.hi \ + $(HEXTRA) $(HEXTRA_INT) $@ # for the htools/test binary, we need to enable profiling/coverage -htools/test: HEXTRA=-fhpc -Wwarn -fno-warn-missing-signatures \ +htools/test: HEXTRA_INT=-fhpc -Wwarn -fno-warn-missing-signatures \ -fno-warn-monomorphism-restriction -fno-warn-orphans \ -fno-warn-missing-methods -fno-warn-unused-imports +# we compile the hpc-htools binary with the program coverage +htools/hpc-htools: HEXTRA_INT=-fhpc + +# test dependency +htools/offline-tests.sh: htools/hpc-htools + +# rules for building profiling-enabled versions of the haskell +# programs: hs-prof does the full two-step build, whereas +# hs-prof-quick does only the final rebuild (hs-prof must have been +# run before) +.PHONY: hs-prof hs-prof-quick +hs-prof: + $(MAKE) clean + $(MAKE) $(HS_ALL_PROGS) HEXTRA="-osuf .o" + rm -f $(HS_ALL_PROGS) + $(MAKE) hs-prof-quick + +hs-prof-quick: + $(MAKE) $(HS_ALL_PROGS) HEXTRA="-osuf .prof_o -prof -auto-all" + dist_sbin_SCRIPTS = \ tools/ganeti-listrunner @@ -515,12 +576,18 @@ nodist_sbin_SCRIPTS = \ $(PYTHON_BOOTSTRAP_SBIN) \ daemons/ganeti-cleaner -dist_tools_PYTHON = \ +if HS_CONFD +nodist_sbin_SCRIPTS += htools/hconfd +endif + +python_scripts = \ tools/burnin \ tools/cfgshell \ tools/cfgupgrade \ tools/cfgupgrade12 \ tools/cluster-merge \ + tools/confd-client \ + tools/fmtjson \ tools/lvmstrap \ tools/move-instance \ tools/ovfconverter \ @@ -528,9 +595,10 @@ dist_tools_PYTHON = \ tools/sanitize-config dist_tools_SCRIPTS = \ - $(dist_tools_PYTHON) \ + $(python_scripts) \ tools/kvm-console-wrapper \ - tools/xm-console-wrapper + tools/xm-console-wrapper \ + tools/master-ip-setup pkglib_python_scripts = \ daemons/import-export \ @@ -539,12 +607,12 @@ pkglib_python_scripts = \ nodist_pkglib_python_scripts = \ tools/ensure-dirs -pkglib_SCRIPTS = \ +myexeclib_SCRIPTS = \ daemons/daemon-util \ tools/kvm-ifup \ $(pkglib_python_scripts) -nodist_pkglib_SCRIPTS = \ +nodist_myexeclib_SCRIPTS = \ $(nodist_pkglib_python_scripts) EXTRA_DIST = \ @@ -553,9 +621,12 @@ EXTRA_DIST = \ epydoc.conf.in \ pylintrc \ autotools/build-bash-completion \ + autotools/build-rpc \ + autotools/check-header \ autotools/check-python-code \ autotools/check-imports \ - autotools/check-man \ + autotools/check-man-dashes \ + autotools/check-man-warnings \ autotools/check-news \ autotools/check-tar \ autotools/check-version \ @@ -574,17 +645,14 @@ EXTRA_DIST = \ $(docrst) \ doc/conf.py \ doc/html \ - doc/examples/ganeti.initd.in \ - doc/examples/ganeti-kvm-poweroff.initd.in \ - doc/examples/ganeti.cron.in \ - doc/examples/gnt-config-backup.in \ + $(BUILT_EXAMPLES:%=%.in) \ doc/examples/ganeti.default \ doc/examples/ganeti.default-debug \ doc/examples/hooks/ethers \ - doc/examples/hooks/ipsec.in \ doc/examples/gnt-debug/README \ doc/examples/gnt-debug/delay0.json \ doc/examples/gnt-debug/delay50.json \ + test/lockperf.py \ test/testutils.py \ test/mocks.py \ $(dist_TESTS) \ @@ -595,7 +663,10 @@ EXTRA_DIST = \ qa/qa-sample.json \ $(qa_scripts) \ $(HS_LIB_SRCS) $(HS_BUILT_SRCS_IN) \ - $(HS_PROG_SRCS) + $(HS_PROG_SRCS) \ + htools/lint-hints.hs \ + htools/cli-tests-defs.sh \ + htools/offline-test.sh man_MANS = \ man/ganeti.7 \ @@ -617,6 +688,7 @@ man_MANS = \ man/gnt-os.8 \ man/hail.1 \ man/hbal.1 \ + man/hinfo.1 \ man/hscan.1 \ man/hspace.1 \ man/htools.1 @@ -648,7 +720,23 @@ TEST_FILES = \ test/data/proc_drbd83.txt \ test/data/proc_drbd83_sync.txt \ test/data/proc_drbd83_sync_krnl2.6.39.txt \ + test/data/kvm_1.0_help.txt \ + test/data/kvm_0.15.90_help.txt \ + test/data/kvm_0.12.5_help.txt \ + test/data/kvm_0.9.1_help.txt \ test/data/sys_drbd_usermode_helper.txt \ + test/data/htools/hail-alloc-drbd.json \ + test/data/htools/hail-change-group.json \ + test/data/htools/hail-invalid-reloc.json \ + test/data/htools/hail-node-evac.json \ + test/data/htools/hail-reloc-drbd.json \ + test/data/htools/common-suffix.data \ + test/data/htools/invalid-node.data \ + test/data/htools/missing-resources.data \ + test/data/htools/rapi/groups.json \ + test/data/htools/rapi/info.json \ + test/data/htools/rapi/instances.json \ + test/data/htools/rapi/nodes.json \ test/data/ovfdata/compr_disk.vmdk.gz \ test/data/ovfdata/config.ini \ test/data/ovfdata/corrupted_resources.ovf \ @@ -674,7 +762,26 @@ TEST_FILES = \ test/data/ovfdata/wrong_ova.ova \ test/data/ovfdata/wrong_xml.ovf \ test/data/ovfdata/other/rawdisk.raw \ - test/import-export_unittest-helper + test/data/vgreduce-removemissing-2.02.02.txt \ + test/data/vgreduce-removemissing-2.02.66-fail.txt \ + test/data/vgreduce-removemissing-2.02.66-ok.txt \ + test/data/vgs-missing-pvs-2.02.02.txt \ + test/data/vgs-missing-pvs-2.02.66.txt \ + test/import-export_unittest-helper \ + test/gnt-cli.test \ + test/ganeti-cli.test \ + test/htools-balancing.test \ + test/htools-basic.test \ + test/htools-dynutil.test \ + test/htools-excl.test \ + test/htools-hail.test \ + test/htools-hspace.test \ + test/htools-invalid.test \ + test/htools-multi-group.test \ + test/htools-no-backend.test \ + test/htools-rapi.test \ + test/htools-single-group.test \ + test/htools-text-backend.test python_tests = \ test/ganeti.asyncnotifier_unittest.py \ @@ -715,10 +822,12 @@ python_tests = \ test/ganeti.rapi.client_unittest.py \ test/ganeti.rapi.resources_unittest.py \ test/ganeti.rapi.rlib2_unittest.py \ + test/ganeti.rapi.testutils_unittest.py \ test/ganeti.rpc_unittest.py \ test/ganeti.runtime_unittest.py \ test/ganeti.serializer_unittest.py \ test/ganeti.ssh_unittest.py \ + test/ganeti.storage_unittest.py \ test/ganeti.tools.ensure_dirs_unittest.py \ test/ganeti.uidpool_unittest.py \ test/ganeti.utils.algo_unittest.py \ @@ -737,7 +846,11 @@ python_tests = \ test/ganeti.workerpool_unittest.py \ test/cfgupgrade_unittest.py \ test/docs_unittest.py \ + test/pycurl_reset_unittest.py \ test/tempfile_fork_unittest.py +if HAS_FAKEROOT +python_tests += test/ganeti.utils.io_unittest-runasroot.py +endif haskell_tests = htools/test @@ -746,18 +859,26 @@ dist_TESTS = \ test/daemon-util_unittest.bash \ test/ganeti-cleaner_unittest.bash \ test/import-export_unittest.bash \ + test/cli-test.bash \ $(python_tests) nodist_TESTS = +check_SCRIPTS = + if WANT_HTOOLSTESTS nodist_TESTS += $(haskell_tests) +dist_TESTS += htools/offline-test.sh +check_SCRIPTS += htools/hpc-htools $(HS_BUILT_TEST_HELPERS) endif TESTS = $(dist_TESTS) $(nodist_TESTS) # Environment for all tests PLAIN_TESTS_ENVIRONMENT = \ - PYTHONPATH=. TOP_SRCDIR=$(abs_top_srcdir) PYTHON=$(PYTHON) $(RUN_IN_TEMPDIR) + PYTHONPATH=. \ + TOP_SRCDIR=$(abs_top_srcdir) TOP_BUILDDIR=$(abs_top_builddir) \ + PYTHON=$(PYTHON) FAKEROOT=$(FAKEROOT_PATH) \ + $(RUN_IN_TEMPDIR) # Environment for tests run by automake TESTS_ENVIRONMENT = \ @@ -765,7 +886,7 @@ TESTS_ENVIRONMENT = \ all_python_code = \ $(dist_sbin_SCRIPTS) \ - $(dist_tools_PYTHON) \ + $(python_scripts) \ $(pkglib_python_scripts) \ $(nodist_pkglib_python_scripts) \ $(python_tests) \ @@ -790,12 +911,16 @@ srclink_files = \ test/daemon-util_unittest.bash \ test/ganeti-cleaner_unittest.bash \ test/import-export_unittest.bash \ + test/cli-test.bash \ + htools/offline-test.sh \ + htools/cli-tests-defs.sh \ $(all_python_code) \ $(HS_LIB_SRCS) $(HS_PROG_SRCS) check_python_code = \ $(BUILD_BASH_COMPLETION) \ $(CHECK_IMPORTS) \ + $(CHECK_HEADER) \ $(DOCPP) \ $(all_python_code) @@ -803,10 +928,11 @@ lint_python_code = \ ganeti \ ganeti/http/server.py \ $(dist_sbin_SCRIPTS) \ - $(dist_tools_PYTHON) \ + $(python_scripts) \ $(pkglib_python_scripts) \ $(BUILD_BASH_COMPLETION) \ $(CHECK_IMPORTS) \ + $(CHECK_HEADER) \ $(DOCPP) \ $(PYTHON_BOOTSTRAP) @@ -818,9 +944,10 @@ pep8_python_code = \ ganeti \ ganeti/http/server.py \ $(dist_sbin_SCRIPTS) \ - $(dist_tools_PYTHON) \ + $(python_scripts) \ $(pkglib_python_scripts) \ $(BUILD_BASH_COMPLETION) \ + $(CHECK_HEADER) \ $(DOCPP) \ $(PYTHON_BOOTSTRAP) \ qa @@ -872,9 +999,13 @@ man/%.7.in man/%.8.in man/%.1.in: man/%.gen man/footer.man @test -n "$(PANDOC)" || \ { echo 'pandoc' not found during configure; exit 1; } set -o pipefail ; \ + trap 'echo auto-removing $@; rm $@' EXIT; \ $(PANDOC) -s -f rst -t man -A man/footer.man $< | \ - sed -e 's/\\@/@/g' > $@ - if test -n "$(MAN_HAS_WARNINGS)"; then $(CHECK_MAN) $@; fi + sed -e 's/\\@/@/g' > $@; \ + if test -n "$(MAN_HAS_WARNINGS)"; then $(CHECK_MAN_WARNINGS) $@; fi; \ + $(CHECK_MAN_DASHES) $@; \ + trap - EXIT + man/%.html.in: man/%.gen man/footer.html @test -n "$(PANDOC)" || \ @@ -920,7 +1051,8 @@ htools/Ganeti/HTools/Version.hs: htools/Ganeti/HTools/Version.hs.in vcs-version sed -e "s/%ver%/$$VCSVER/" < $< > $@ htools/Ganeti/Constants.hs: htools/Ganeti/Constants.hs.in \ - lib/constants.py lib/_autoconf.py $(CONVERT_CONSTANTS) + lib/constants.py lib/_autoconf.py $(CONVERT_CONSTANTS) \ + | lib/_vcsversion.py set -e; \ { cat $< ; PYTHONPATH=. $(CONVERT_CONSTANTS); } > $@ @@ -969,7 +1101,8 @@ lib/_autoconf.py: Makefile | lib/.dir echo "TOOLSDIR = '$(toolsdir)'"; \ echo "GNT_SCRIPTS = [$(foreach i,$(notdir $(gnt_scripts)),'$(i)',)]"; \ echo "PKGLIBDIR = '$(pkglibdir)'"; \ - echo "DRBD_BARRIERS = $(DRBD_BARRIERS)"; \ + echo "DRBD_BARRIERS = '$(DRBD_BARRIERS)'"; \ + echo "DRBD_NO_META_FLUSH = $(DRBD_NO_META_FLUSH)"; \ echo "SYSLOG_USAGE = '$(SYSLOG_USAGE)'"; \ echo "DAEMONS_GROUP = '$(DAEMONS_GROUP)'"; \ echo "ADMIN_GROUP = '$(ADMIN_GROUP)'"; \ @@ -982,11 +1115,15 @@ lib/_autoconf.py: Makefile | lib/.dir echo "NODED_USER = '$(NODED_USER)'"; \ echo "NODED_GROUP = '$(NODED_GROUP)'"; \ echo "DISK_SEPARATOR = '$(DISK_SEPARATOR)'"; \ + echo "QEMUIMG_PATH = '$(QEMUIMG_PATH)'"; \ if [ "$(HTOOLS)" ]; then \ echo "HTOOLS = True"; \ else \ echo "HTOOLS = False"; \ fi; \ + echo "ENABLE_CONFD = $(ENABLE_CONFD)"; \ + echo "PY_CONFD = $(PY_CONFD)"; \ + echo "HS_CONFD = $(HS_CONFD)"; \ } > $@ lib/_vcsversion.py: Makefile vcs-version | lib/.dir @@ -1010,6 +1147,9 @@ lib/_vcsversion.py: Makefile vcs-version | lib/.dir echo "VCS_VERSION = '$$VCSVER'"; \ } > $@ +lib/_generated_rpc.py: lib/rpc_defs.py $(BUILD_RPC) + PYTHONPATH=. $(RUN_IN_TEMPDIR) $(CURDIR)/$(BUILD_RPC) lib/rpc_defs.py > $@ + $(REPLACE_VARS_SED): Makefile set -e; \ { echo 's#@PREFIX@#$(prefix)#g'; \ @@ -1035,6 +1175,7 @@ $(REPLACE_VARS_SED): Makefile echo 's#@GNTCONFDGROUP@#$(CONFD_GROUP)#g'; \ echo 's#@GNTMASTERDGROUP@#$(MASTERD_GROUP)#g'; \ echo 's#@GNTDAEMONSGROUP@#$(DAEMONS_GROUP)#g'; \ + echo 's#@CUSTOM_ENABLE_CONFD@#$(ENABLE_CONFD)#g'; \ } > $@ # Using deferred evaluation @@ -1042,6 +1183,7 @@ daemons/ganeti-%: MODULE = ganeti.server.$(patsubst ganeti-%,%,$(notdir $@)) daemons/ganeti-watcher: MODULE = ganeti.watcher scripts/%: MODULE = ganeti.client.$(subst -,_,$(notdir $@)) tools/ensure-dirs: MODULE = ganeti.tools.ensure_dirs +$(HS_BUILT_TEST_HELPERS): TESTROLE = $(patsubst test/%,%,$@) $(PYTHON_BOOTSTRAP): Makefile | $(all_dirfiles) test -n "$(MODULE)" || { echo Missing module; exit 1; } @@ -1070,6 +1212,17 @@ $(PYTHON_BOOTSTRAP): Makefile | $(all_dirfiles) } > $@ chmod u+x $@ +$(HS_BUILT_TEST_HELPERS): Makefile + @test -n "$(TESTROLE)" || { echo Missing TESTROLE; exit 1; } + set -e; \ + { echo '#!/bin/sh'; \ + echo '# This file is automatically generated, do not edit!'; \ + echo "# Edit Makefile.am instead."; \ + echo; \ + echo "HTOOLS=$(TESTROLE) exec ./htools/hpc-htools \"\$$@\""; \ + } > $@ + chmod u+x $@ + # We need to create symlinks because "make distcheck" will not install Python # files when building. stamp-srclinks: Makefile | $(all_dirfiles) @@ -1111,6 +1264,7 @@ check-dirs: $(BUILT_SOURCES) .PHONY: check-local check-local: check-dirs $(BUILT_SOURCES) $(CHECK_PYTHON_CODE) $(check_python_code) + PYTHONPATH=. $(CHECK_HEADER) $(check_python_code) $(CHECK_VERSION) $(VERSION) $(top_srcdir)/NEWS $(CHECK_NEWS) < $(top_srcdir)/NEWS PYTHONPATH=. $(RUN_IN_TEMPDIR) $(CURDIR)/$(CHECK_IMPORTS) . $(standalone_python_modules) @@ -1128,9 +1282,10 @@ check-local: check-dirs $(BUILT_SOURCES) done .PHONY: hs-check -hs-check: htools/test +hs-check: htools/test htools/hpc-htools $(HS_BUILT_TEST_HELPERS) @rm -f test.tix ./htools/test + HBINARY="./htools/hpc-htools" ./htools/offline-test.sh # E111: indentation is not a multiple of four # E261: at least two spaces before inline comment @@ -1155,9 +1310,16 @@ lint: $(BUILT_SOURCES) --rcfile ../pylintrc $(patsubst qa/%.py,%,$(qa_scripts)) .PHONY: hlint -hlint: $(HS_BUILT_SRCS) +hlint: $(HS_BUILT_SRCS) htools/lint-hints.hs if tty -s; then C="-c"; else C=""; fi; \ - hlint --report=doc/hs-lint.html $$C htools + hlint --report=doc/hs-lint.html --cross $$C \ + --ignore "Use first" \ + --ignore "Use comparing" \ + --ignore "Use on" \ + --ignore "Use Control.Exception.catch" \ + --ignore "Reduce duplication" \ + --hint htools/lint-hints \ + $(filter-out htools/Ganeti/THH.hs,$(HS_LIB_SRCS)) # a dist hook rule for updating the vcs-version file; this is # hardcoded due to where it needs to build the file... @@ -1238,8 +1400,10 @@ hs-apidoc: $(HS_BUILT_SRCS) { echo 'haddock' not found during configure; exit 1; } rm -rf $(APIDOC_HS_DIR)/* @mkdir_p@ $(APIDOC_HS_DIR)/Ganeti/HTools/Program + @mkdir_p@ $(APIDOC_HS_DIR)/Ganeti/Confd $(HSCOLOUR) -print-css > $(APIDOC_HS_DIR)/Ganeti/hscolour.css $(LN_S) ../hscolour.css $(APIDOC_HS_DIR)/Ganeti/HTools/hscolour.css + $(LN_S) ../hscolour.css $(APIDOC_HS_DIR)/Ganeti/Confd/hscolour.css set -e ; \ cd htools; \ if [ "$(HTOOLS_NOCURL)" ]; \ @@ -1286,11 +1450,12 @@ py-coverage: $(BUILT_SOURCES) $(python_tests) $(python_tests) .PHONY: hs-coverage -hs-coverage: $(haskell_tests) - cd htools && rm -f *.tix *.mix && ./test +hs-coverage: $(haskell_tests) htools/hpc-htools + rm -f *.tix && $(MAKE) hs-check @mkdir_p@ $(COVERAGE_HS_DIR) - hpc markup --destdir=$(COVERAGE_HS_DIR) htools/test $(HPCEXCL) - hpc report htools/test $(HPCEXCL) + hpc combine $(HPCEXCL) test.tix hpc-htools.tix > coverage-htools.tix + hpc markup --destdir=$(COVERAGE_HS_DIR) coverage-htools.tix + hpc report coverage-htools.tix $(LN_S) -f hpc_index.html $(COVERAGE_HS_DIR)/index.html # Special "kind-of-QA" target for htools, needs special setup (all