X-Git-Url: https://code.grnet.gr/git/ganeti-local/blobdiff_plain/f2f57b6e73ee4d2af3d23cab6952ff6c8ef61144..dc2cc657c8c6154b35731ac8166fcf25b9a4f244:/lib/bdev.py?ds=sidebyside diff --git a/lib/bdev.py b/lib/bdev.py index 030d195..1d85867 100644 --- a/lib/bdev.py +++ b/lib/bdev.py @@ -1,7 +1,7 @@ # # -# Copyright (C) 2006, 2007, 2010, 2011 Google Inc. +# Copyright (C) 2006, 2007, 2010, 2011, 2012 Google Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -228,12 +228,15 @@ class BlockDev(object): @param params: dictionary of LD level disk parameters related to the synchronization. + @rtype: list + @return: a list of error messages, emitted both by the current node and by + children. An empty list means no errors. """ - result = True + result = [] if self._children: for child in self._children: - result = result and child.SetSyncParams(params) + result.extend(child.SetSyncParams(params)) return result def PauseResumeSync(self, pause): @@ -615,8 +618,8 @@ class LogicalVolume(BlockDev): return False status, major, minor, pe_size, stripes = out - if len(status) != 6: - logging.error("lvs lv_attr is not 6 characters (%s)", status) + if len(status) < 6: + logging.error("lvs lv_attr is not at least 6 characters (%s)", status) return False try: @@ -1055,7 +1058,7 @@ class BaseDRBD(BlockDev): # pylint: disable=W0223 def _CheckMetaSize(meta_device): """Check if the given meta device looks like a valid one. - This currently only check the size, which must be around + This currently only checks the size, which must be around 128MiB. """ @@ -1095,10 +1098,10 @@ class DRBD8(BaseDRBD): doesn't do anything to the supposed peer. If you need a fully connected DRBD pair, you need to use this class on both hosts. - The unique_id for the drbd device is the (local_ip, local_port, - remote_ip, remote_port) tuple, and it must have two children: the - data device and the meta_device. The meta device is checked for - valid size and is zeroed on create. + The unique_id for the drbd device is a (local_ip, local_port, + remote_ip, remote_port, local_minor, secret) tuple, and it must have + two children: the data device and the meta_device. The meta device + is checked for valid size and is zeroed on create. """ _MAX_MINORS = 255 @@ -1194,7 +1197,7 @@ class DRBD8(BaseDRBD): def _GetShowParser(cls): """Return a parser for `drbd show` output. - This will either create or return an already-create parser for the + This will either create or return an already-created parser for the output of the command `drbd show`. """ @@ -1215,10 +1218,10 @@ class DRBD8(BaseDRBD): defa = pyp.Literal("_is_default").suppress() dbl_quote = pyp.Literal('"').suppress() - keyword = pyp.Word(pyp.alphanums + '-') + keyword = pyp.Word(pyp.alphanums + "-") # value types - value = pyp.Word(pyp.alphanums + '_-/.:') + value = pyp.Word(pyp.alphanums + "_-/.:") quoted = dbl_quote + pyp.CharsNotIn('"') + dbl_quote ipv4_addr = (pyp.Optional(pyp.Literal("ipv4")).suppress() + pyp.Word(pyp.nums + ".") + colon + number) @@ -1475,7 +1478,10 @@ class DRBD8(BaseDRBD): # sync speed only after setting up both sides can race with DRBD # connecting, hence we set it here before telling DRBD anything # about its peer. - self._SetMinorSyncParams(minor, self.params) + sync_errors = self._SetMinorSyncParams(minor, self.params) + if sync_errors: + _ThrowError("drbd%d: can't set the synchronization parameters: %s" % + (minor, utils.CommaJoin(sync_errors))) if netutils.IP6Address.IsValid(lhost): if not netutils.IP6Address.IsValid(rhost): @@ -1584,8 +1590,8 @@ class DRBD8(BaseDRBD): @param minor: the drbd minor whose settings we change @type params: dict @param params: LD level disk parameters related to the synchronization - @rtype: boolean - @return: the success of the operation + @rtype: list + @return: a list of error messages """ @@ -1598,13 +1604,25 @@ class DRBD8(BaseDRBD): # By definition we are using 8.x, so just check the rest of the version # number if vmin != 3 or vrel < 9: - logging.error("The current DRBD version (8.%d.%d) does not support the" - " dynamic resync speed controller", vmin, vrel) - return False + msg = ("The current DRBD version (8.%d.%d) does not support the " + "dynamic resync speed controller" % (vmin, vrel)) + logging.error(msg) + return [msg] + + if params[constants.LDP_PLAN_AHEAD] == 0: + msg = ("A value of 0 for c-plan-ahead disables the dynamic sync speed" + " controller at DRBD level. If you want to disable it, please" + " set the dynamic-resync disk parameter to False.") + logging.error(msg) + return [msg] # add the c-* parameters to args - # TODO(spadaccio) use the actual parameters - args.extend(["--c-plan-ahead", "20"]) + args.extend(["--c-plan-ahead", params[constants.LDP_PLAN_AHEAD], + "--c-fill-target", params[constants.LDP_FILL_TARGET], + "--c-delay-target", params[constants.LDP_DELAY_TARGET], + "--c-max-rate", params[constants.LDP_MAX_RATE], + "--c-min-rate", params[constants.LDP_MIN_RATE], + ]) else: args.extend(["-r", "%d" % params[constants.LDP_RESYNC_RATE]]) @@ -1612,24 +1630,31 @@ class DRBD8(BaseDRBD): args.append("--create-device") result = utils.RunCmd(args) if result.failed: - logging.error("Can't change syncer rate: %s - %s", - result.fail_reason, result.output) - return not result.failed + msg = ("Can't change syncer rate: %s - %s" % + (result.fail_reason, result.output)) + logging.error(msg) + return [msg] + + return [] def SetSyncParams(self, params): """Set the synchronization parameters of the DRBD syncer. @type params: dict @param params: LD level disk parameters related to the synchronization - @rtype: boolean - @return: the success of the operation + @rtype: list + @return: a list of error messages, emitted both by the current node and by + children. An empty list means no errors """ if self.minor is None: - logging.info("Not attached during SetSyncParams") - return False + err = "Not attached during SetSyncParams" + logging.info(err) + return [err] + children_result = super(DRBD8, self).SetSyncParams(params) - return self._SetMinorSyncParams(self.minor, params) and children_result + children_result.extend(self._SetMinorSyncParams(self.minor, params)) + return children_result def PauseResumeSync(self, pause): """Pauses or resumes the sync of a DRBD device. @@ -1866,7 +1891,10 @@ class DRBD8(BaseDRBD): # the device self._SlowAssemble() - self.SetSyncParams(self.params) + sync_errors = self.SetSyncParams(self.params) + if sync_errors: + _ThrowError("drbd%d: can't set the synchronization parameters: %s" % + (self.minor, utils.CommaJoin(sync_errors))) def _SlowAssemble(self): """Assembles the DRBD device from a (partially) configured device. @@ -2318,10 +2346,302 @@ class PersistentBlockDevice(BlockDev): _ThrowError("Grow is not supported for PersistentBlockDev storage") +class RADOSBlockDevice(BlockDev): + """A RADOS Block Device (rbd). + + This class implements the RADOS Block Device for the backend. You need + the rbd kernel driver, the RADOS Tools and a working RADOS cluster for + this to be functional. + + """ + def __init__(self, unique_id, children, size, params): + """Attaches to an rbd device. + + """ + super(RADOSBlockDevice, self).__init__(unique_id, children, size, params) + if not isinstance(unique_id, (tuple, list)) or len(unique_id) != 2: + raise ValueError("Invalid configuration data %s" % str(unique_id)) + + self.driver, self.rbd_name = unique_id + + self.major = self.minor = None + self.Attach() + + @classmethod + def Create(cls, unique_id, children, size, params): + """Create a new rbd device. + + Provision a new rbd volume inside a RADOS pool. + + """ + if not isinstance(unique_id, (tuple, list)) or len(unique_id) != 2: + raise errors.ProgrammerError("Invalid configuration data %s" % + str(unique_id)) + rbd_pool = params[constants.LDP_POOL] + rbd_name = unique_id[1] + + # Provision a new rbd volume (Image) inside the RADOS cluster. + cmd = [constants.RBD_CMD, "create", "-p", rbd_pool, + rbd_name, "--size", "%s" % size] + result = utils.RunCmd(cmd) + if result.failed: + _ThrowError("rbd creation failed (%s): %s", + result.fail_reason, result.output) + + return RADOSBlockDevice(unique_id, children, size, params) + + def Remove(self): + """Remove the rbd device. + + """ + rbd_pool = self.params[constants.LDP_POOL] + rbd_name = self.unique_id[1] + + if not self.minor and not self.Attach(): + # The rbd device doesn't exist. + return + + # First shutdown the device (remove mappings). + self.Shutdown() + + # Remove the actual Volume (Image) from the RADOS cluster. + cmd = [constants.RBD_CMD, "rm", "-p", rbd_pool, rbd_name] + result = utils.RunCmd(cmd) + if result.failed: + _ThrowError("Can't remove Volume from cluster with rbd rm: %s - %s", + result.fail_reason, result.output) + + def Rename(self, new_id): + """Rename this device. + + """ + pass + + def Attach(self): + """Attach to an existing rbd device. + + This method maps the rbd volume that matches our name with + an rbd device and then attaches to this device. + + """ + self.attached = False + + # Map the rbd volume to a block device under /dev + self.dev_path = self._MapVolumeToBlockdev(self.unique_id) + + try: + st = os.stat(self.dev_path) + except OSError, err: + logging.error("Error stat()'ing %s: %s", self.dev_path, str(err)) + return False + + if not stat.S_ISBLK(st.st_mode): + logging.error("%s is not a block device", self.dev_path) + return False + + self.major = os.major(st.st_rdev) + self.minor = os.minor(st.st_rdev) + self.attached = True + + return True + + def _MapVolumeToBlockdev(self, unique_id): + """Maps existing rbd volumes to block devices. + + This method should be idempotent if the mapping already exists. + + @rtype: string + @return: the block device path that corresponds to the volume + + """ + pool = self.params[constants.LDP_POOL] + name = unique_id[1] + + # Check if the mapping already exists. + showmap_cmd = [constants.RBD_CMD, "showmapped", "-p", pool] + result = utils.RunCmd(showmap_cmd) + if result.failed: + _ThrowError("rbd showmapped failed (%s): %s", + result.fail_reason, result.output) + + rbd_dev = self._ParseRbdShowmappedOutput(result.output, name) + + if rbd_dev: + # The mapping exists. Return it. + return rbd_dev + + # The mapping doesn't exist. Create it. + map_cmd = [constants.RBD_CMD, "map", "-p", pool, name] + result = utils.RunCmd(map_cmd) + if result.failed: + _ThrowError("rbd map failed (%s): %s", + result.fail_reason, result.output) + + # Find the corresponding rbd device. + showmap_cmd = [constants.RBD_CMD, "showmapped", "-p", pool] + result = utils.RunCmd(showmap_cmd) + if result.failed: + _ThrowError("rbd map succeeded, but showmapped failed (%s): %s", + result.fail_reason, result.output) + + rbd_dev = self._ParseRbdShowmappedOutput(result.output, name) + + if not rbd_dev: + _ThrowError("rbd map succeeded, but could not find the rbd block" + " device in output of showmapped, for volume: %s", name) + + # The device was successfully mapped. Return it. + return rbd_dev + + @staticmethod + def _ParseRbdShowmappedOutput(output, volume_name): + """Parse the output of `rbd showmapped'. + + This method parses the output of `rbd showmapped' and returns + the rbd block device path (e.g. /dev/rbd0) that matches the + given rbd volume. + + @type output: string + @param output: the whole output of `rbd showmapped' + @type volume_name: string + @param volume_name: the name of the volume whose device we search for + @rtype: string or None + @return: block device path if the volume is mapped, else None + + """ + allfields = 5 + volumefield = 2 + devicefield = 4 + + field_sep = "\t" + + lines = output.splitlines() + splitted_lines = map(lambda l: l.split(field_sep), lines) + + # Check empty output. + if not splitted_lines: + _ThrowError("rbd showmapped returned empty output") + + # Check showmapped header line, to determine number of fields. + field_cnt = len(splitted_lines[0]) + if field_cnt != allfields: + _ThrowError("Cannot parse rbd showmapped output because its format" + " seems to have changed; expected %s fields, found %s", + allfields, field_cnt) + + matched_lines = \ + filter(lambda l: len(l) == allfields and l[volumefield] == volume_name, + splitted_lines) + + if len(matched_lines) > 1: + _ThrowError("The rbd volume %s is mapped more than once." + " This shouldn't happen, try to unmap the extra" + " devices manually.", volume_name) + + if matched_lines: + # rbd block device found. Return it. + rbd_dev = matched_lines[0][devicefield] + return rbd_dev + + # The given volume is not mapped. + return None + + def Assemble(self): + """Assemble the device. + + """ + pass + + def Shutdown(self): + """Shutdown the device. + + """ + if not self.minor and not self.Attach(): + # The rbd device doesn't exist. + return + + # Unmap the block device from the Volume. + self._UnmapVolumeFromBlockdev(self.unique_id) + + self.minor = None + self.dev_path = None + + def _UnmapVolumeFromBlockdev(self, unique_id): + """Unmaps the rbd device from the Volume it is mapped. + + Unmaps the rbd device from the Volume it was previously mapped to. + This method should be idempotent if the Volume isn't mapped. + + """ + pool = self.params[constants.LDP_POOL] + name = unique_id[1] + + # Check if the mapping already exists. + showmap_cmd = [constants.RBD_CMD, "showmapped", "-p", pool] + result = utils.RunCmd(showmap_cmd) + if result.failed: + _ThrowError("rbd showmapped failed [during unmap](%s): %s", + result.fail_reason, result.output) + + rbd_dev = self._ParseRbdShowmappedOutput(result.output, name) + + if rbd_dev: + # The mapping exists. Unmap the rbd device. + unmap_cmd = [constants.RBD_CMD, "unmap", "%s" % rbd_dev] + result = utils.RunCmd(unmap_cmd) + if result.failed: + _ThrowError("rbd unmap failed (%s): %s", + result.fail_reason, result.output) + + def Open(self, force=False): + """Make the device ready for I/O. + + """ + pass + + def Close(self): + """Notifies that the device will no longer be used for I/O. + + """ + pass + + def Grow(self, amount, dryrun): + """Grow the Volume. + + @type amount: integer + @param amount: the amount (in mebibytes) to grow with + @type dryrun: boolean + @param dryrun: whether to execute the operation in simulation mode + only, without actually increasing the size + + """ + if not self.Attach(): + _ThrowError("Can't attach to rbd device during Grow()") + + if dryrun: + # the rbd tool does not support dry runs of resize operations. + # Since rbd volumes are thinly provisioned, we assume + # there is always enough free space for the operation. + return + + rbd_pool = self.params[constants.LDP_POOL] + rbd_name = self.unique_id[1] + new_size = self.size + amount + + # Resize the rbd volume (Image) inside the RADOS cluster. + cmd = [constants.RBD_CMD, "resize", "-p", rbd_pool, + rbd_name, "--size", "%s" % new_size] + result = utils.RunCmd(cmd) + if result.failed: + _ThrowError("rbd resize failed (%s): %s", + result.fail_reason, result.output) + + DEV_MAP = { constants.LD_LV: LogicalVolume, constants.LD_DRBD8: DRBD8, constants.LD_BLOCKDEV: PersistentBlockDevice, + constants.LD_RBD: RADOSBlockDevice, } if constants.ENABLE_FILE_STORAGE or constants.ENABLE_SHARED_FILE_STORAGE: @@ -2333,6 +2653,16 @@ def _VerifyDiskType(dev_type): raise errors.ProgrammerError("Invalid block device type '%s'" % dev_type) +def _VerifyDiskParams(disk): + """Verifies if all disk parameters are set. + + """ + missing = set(constants.DISK_LD_DEFAULTS[disk.dev_type]) - set(disk.params) + if missing: + raise errors.ProgrammerError("Block device is missing disk parameters: %s" % + missing) + + def FindDevice(disk, children): """Search for an existing, assembled device. @@ -2347,10 +2677,8 @@ def FindDevice(disk, children): """ _VerifyDiskType(disk.dev_type) - dev_params = objects.FillDict(constants.DISK_LD_DEFAULTS[disk.dev_type], - disk.params) device = DEV_MAP[disk.dev_type](disk.physical_id, children, disk.size, - dev_params) + disk.params) if not device.attached: return None return device @@ -2370,10 +2698,9 @@ def Assemble(disk, children): """ _VerifyDiskType(disk.dev_type) - dev_params = objects.FillDict(constants.DISK_LD_DEFAULTS[disk.dev_type], - disk.params) + _VerifyDiskParams(disk) device = DEV_MAP[disk.dev_type](disk.physical_id, children, disk.size, - dev_params) + disk.params) device.Assemble() return device @@ -2389,8 +2716,7 @@ def Create(disk, children): """ _VerifyDiskType(disk.dev_type) - dev_params = objects.FillDict(constants.DISK_LD_DEFAULTS[disk.dev_type], - disk.params) + _VerifyDiskParams(disk) device = DEV_MAP[disk.dev_type].Create(disk.physical_id, children, disk.size, - dev_params) + disk.params) return device