From: Iustin Pop <iustin@google.com>
Date: Sun, 30 Aug 2009 15:55:49 +0000 (+0200)
Subject: Split the balancing algorithm in two parts
X-Git-Tag: htools-v0.1.7~9
X-Git-Url: https://code.grnet.gr/git/ganeti-local/commitdiff_plain/f25e5aacbbbb661d69612cdf4b1dbde4a9c2235f

Split the balancing algorithm in two parts

Currently the computation, recursing part and the IO part (progress
updates) of the balancing main function (iterateDepth) are all in the
same function, which makes it hard to test. This patch moves the
decision/computation part (whether to proceed one more round, whether we
got a good result, etc.) into Cluster.hs, and leaves only the iteration
and screen update in hbal.hs.
---

diff --git a/Ganeti/HTools/Cluster.hs b/Ganeti/HTools/Cluster.hs
index f582c7f..7562f21 100644
--- a/Ganeti/HTools/Cluster.hs
+++ b/Ganeti/HTools/Cluster.hs
@@ -46,6 +46,7 @@ module Ganeti.HTools.Cluster
     , printNodes
     -- * Balacing functions
     , checkMove
+    , tryBalance
     , compCV
     , printStats
     -- * IAllocator functions
@@ -442,6 +443,31 @@ checkMove nodes_idx disk_moves ini_tbl victims =
       else
           best_tbl
 
+-- | Run a balance move
+
+tryBalance :: Table       -- ^ The starting table
+           -> Int         -- ^ Remaining length
+           -> Bool        -- ^ Allow disk moves
+           -> Score       -- ^ Score at which to stop
+           -> Maybe Table -- ^ The resulting table and commands
+tryBalance ini_tbl max_rounds disk_moves min_score =
+    let Table ini_nl ini_il ini_cv ini_plc = ini_tbl
+        ini_plc_len = length ini_plc
+        allowed_next = (max_rounds < 0 || ini_plc_len < max_rounds) &&
+                       ini_cv > min_score
+    in
+      if allowed_next
+      then let all_inst = Container.elems ini_il
+               node_idx = map Node.idx . filter (not . Node.offline) $
+                          Container.elems ini_nl
+               fin_tbl = checkMove node_idx disk_moves ini_tbl all_inst
+               (Table _ _ fin_cv _) = fin_tbl
+           in
+             if fin_cv < ini_cv
+             then Just fin_tbl -- this round made success, try deeper
+             else Nothing
+      else Nothing
+
 -- * Allocation functions
 
 -- | Build failure stats out of a list of failures
diff --git a/hbal.hs b/hbal.hs
index f29f73b..dbee000 100644
--- a/hbal.hs
+++ b/hbal.hs
@@ -80,32 +80,24 @@ iterateDepth :: Cluster.Table    -- ^ The starting table
                                                -- commands
 iterateDepth ini_tbl max_rounds disk_moves nmlen imlen
              cmd_strs oneline min_score =
-    let Cluster.Table ini_nl ini_il ini_cv ini_plc = ini_tbl
-        all_inst = Container.elems ini_il
-        node_idx = map Node.idx . filter (not . Node.offline) $
-                   Container.elems ini_nl
-        fin_tbl = Cluster.checkMove node_idx disk_moves ini_tbl all_inst
-        (Cluster.Table _ _ fin_cv fin_plc) = fin_tbl
-        ini_plc_len = length ini_plc
-        fin_plc_len = length fin_plc
-        allowed_next = (max_rounds < 0 || length fin_plc < max_rounds)
+    let Cluster.Table ini_nl ini_il _ _ = ini_tbl
+        m_fin_tbl = Cluster.tryBalance ini_tbl max_rounds disk_moves min_score
     in
-      do
-        let
-            (sol_line, cmds) = Cluster.printSolutionLine ini_nl ini_il
-                               nmlen imlen (head fin_plc) fin_plc_len
-            upd_cmd_strs = cmds:cmd_strs
-        unless (oneline || fin_plc_len == ini_plc_len) $ do
-          putStrLn sol_line
-          hFlush stdout
-        (if fin_cv < ini_cv then -- this round made success, try deeper
-             if allowed_next && fin_cv > min_score
-             then iterateDepth fin_tbl max_rounds disk_moves
-                  nmlen imlen upd_cmd_strs oneline min_score
-             -- don't go deeper, but return the better solution
-             else return (fin_tbl, upd_cmd_strs)
-         else
-             return (ini_tbl, cmd_strs))
+      case m_fin_tbl of
+        Just fin_tbl ->
+            do
+              let
+                  (Cluster.Table _ _ _ fin_plc) = fin_tbl
+                  fin_plc_len = length fin_plc
+                  (sol_line, cmds) = Cluster.printSolutionLine ini_nl ini_il
+                                     nmlen imlen (head fin_plc) fin_plc_len
+                  upd_cmd_strs = cmds:cmd_strs
+              unless oneline $ do
+                       putStrLn sol_line
+                       hFlush stdout
+              iterateDepth fin_tbl max_rounds disk_moves
+                           nmlen imlen upd_cmd_strs oneline min_score
+        Nothing -> return (ini_tbl, cmd_strs)
 
 -- | Formats the solution for the oneline display
 formatOneline :: Double -> Int -> Double -> String