From 34ad1d7c954814c6795acdf50c2296588804d546 Mon Sep 17 00:00:00 2001 From: Klaus Aehlig Date: Thu, 27 Jun 2013 15:59:15 +0200 Subject: [PATCH] Remove obsolete TODO Originally, hroller started as a tool for offline maintenance only. There it made sense to warn about instances still running. By now, default planning is to migrate instance off the nodes to be rebooted, with options for other behavior (like pretending that all instances will be shut down before the actual reboots start). In that scenario instances running is the normal situation, not something to be warned about. Signed-off-by: Klaus Aehlig Reviewed-by: Michele Tartara --- src/Ganeti/HTools/Program/Hroller.hs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Ganeti/HTools/Program/Hroller.hs b/src/Ganeti/HTools/Program/Hroller.hs index e0f56b0..44411bc 100644 --- a/src/Ganeti/HTools/Program/Hroller.hs +++ b/src/Ganeti/HTools/Program/Hroller.hs @@ -239,8 +239,6 @@ main opts args = do then Node.mkNodeGraph else Node.mkRebootNodeGraph nlf - -- TODO: fail if instances are running (with option to warn only) - nodeGraph <- case mkGraph nodes ilf of Nothing -> exitErr "Cannot create node graph" Just g -> return g -- 1.7.10.4