From cf632f3ea2a35d7a67b46f7193e5b13405bb8752 Mon Sep 17 00:00:00 2001 From: Bernardo Dal Seno Date: Mon, 28 Jan 2013 16:46:23 +0100 Subject: [PATCH] QA: Better initialization of a global dictionary The global 'cfg' variable is initialized to an empty dictionary, so there is no more need to disable some pylint checks. Signed-off-by: Bernardo Dal Seno Reviewed-by: Michael Hanselmann --- qa/qa_config.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qa/qa_config.py b/qa/qa_config.py index df716bc..25870ba 100644 --- a/qa/qa_config.py +++ b/qa/qa_config.py @@ -37,7 +37,7 @@ _INSTANCE_CHECK_KEY = "instance-check" _ENABLED_HV_KEY = "enabled-hypervisors" -cfg = None +cfg = {} options = None @@ -80,7 +80,7 @@ def Validate(): def get(name, default=None): - return cfg.get(name, default) # pylint: disable=E1103 + return cfg.get(name, default) class Either: @@ -149,7 +149,7 @@ def TestEnabled(tests, _cfg=None): _cfg = cfg # Get settings for all tests - cfg_tests = _cfg.get("tests", {}) # pylint: disable=E1103 + cfg_tests = _cfg.get("tests", {}) # Get default setting default = cfg_tests.get("default", True) @@ -162,7 +162,7 @@ def GetInstanceCheckScript(): """Returns path to instance check script or C{None}. """ - return cfg.get(_INSTANCE_CHECK_KEY, None) # pylint: disable=E1103 + return cfg.get(_INSTANCE_CHECK_KEY, None) def GetEnabledHypervisors(): -- 1.7.10.4