From fbd554349825752a36c59c1598a512936a22d013 Mon Sep 17 00:00:00 2001 From: Michael Hanselmann Date: Wed, 30 Nov 2011 12:49:09 +0100 Subject: [PATCH] Fix race condition in test for *FileID functions MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit In this test the “file ID” of a temporary file is compared against the file ID gathered via an open file descriptor to the same file. For reasons unknown to me utime(2) is called in-between to update the inode's a- and mtime. Depending on the file system's timestamp resolution this can lead to a different file ID. Found by chance during QA and reproduced by adding a delay before the call to utime(2). Signed-off-by: Michael Hanselmann Reviewed-by: Iustin Pop --- test/ganeti.utils.io_unittest.py | 1 - 1 file changed, 1 deletion(-) diff --git a/test/ganeti.utils.io_unittest.py b/test/ganeti.utils.io_unittest.py index 503ae18..a383203 100755 --- a/test/ganeti.utils.io_unittest.py +++ b/test/ganeti.utils.io_unittest.py @@ -383,7 +383,6 @@ class TestFileID(testutils.GanetiTestCase): def testUpdate(self): name = self._CreateTempFile() oldi = utils.GetFileID(path=name) - os.utime(name, None) fd = os.open(name, os.O_RDWR) try: newi = utils.GetFileID(fd=fd) -- 1.7.10.4