From: Christos Stathis Date: Fri, 27 Jan 2012 14:40:22 +0000 (+0200) Subject: Fixed various warnings X-Git-Tag: v0.1~31 X-Git-Url: https://code.grnet.gr/git/pithos-web-client/commitdiff_plain/ebead1b508364bfa1154e40773c659bc61dc87cf Fixed various warnings --- diff --git a/src/gr/grnet/pithos/web/client/AbstractPropertiesDialog.java b/src/gr/grnet/pithos/web/client/AbstractPropertiesDialog.java index 150e92e..82237d4 100644 --- a/src/gr/grnet/pithos/web/client/AbstractPropertiesDialog.java +++ b/src/gr/grnet/pithos/web/client/AbstractPropertiesDialog.java @@ -38,9 +38,6 @@ import com.google.gwt.dom.client.NativeEvent; import com.google.gwt.event.dom.client.KeyCodes; import com.google.gwt.user.client.Event.NativePreviewEvent; import com.google.gwt.user.client.ui.DialogBox; -import com.google.gwt.user.client.ui.FlowPanel; -import com.google.gwt.user.client.ui.TabPanel; -import com.google.gwt.user.client.ui.TextBox; import com.google.gwt.user.client.ui.VerticalPanel; /** diff --git a/src/gr/grnet/pithos/web/client/ConfirmationDialog.java b/src/gr/grnet/pithos/web/client/ConfirmationDialog.java index 8160371..c2c72b7 100644 --- a/src/gr/grnet/pithos/web/client/ConfirmationDialog.java +++ b/src/gr/grnet/pithos/web/client/ConfirmationDialog.java @@ -45,7 +45,6 @@ import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.DialogBox; import com.google.gwt.user.client.ui.HTML; import com.google.gwt.user.client.ui.HasHorizontalAlignment; -import com.google.gwt.user.client.ui.HorizontalPanel; import com.google.gwt.user.client.ui.VerticalPanel; @@ -94,7 +93,7 @@ public abstract class ConfirmationDialog extends DialogBox { Button ok = new Button(buttonLabel, new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { confirm(); hide(); } diff --git a/src/gr/grnet/pithos/web/client/CredentialsDialog.java b/src/gr/grnet/pithos/web/client/CredentialsDialog.java index 20c3bbe..faef866 100644 --- a/src/gr/grnet/pithos/web/client/CredentialsDialog.java +++ b/src/gr/grnet/pithos/web/client/CredentialsDialog.java @@ -61,7 +61,7 @@ public class CredentialsDialog extends DialogBox { /** * The widget constructor. */ - public CredentialsDialog(final Pithos app, final MessagePanel.Images images) { + public CredentialsDialog(final Pithos app) { Anchor close = new Anchor(); close.addStyleName("close"); close.addClickHandler(new ClickHandler() { diff --git a/src/gr/grnet/pithos/web/client/DeleteFileDialog.java b/src/gr/grnet/pithos/web/client/DeleteFileDialog.java index aee2d28..d00dca0 100644 --- a/src/gr/grnet/pithos/web/client/DeleteFileDialog.java +++ b/src/gr/grnet/pithos/web/client/DeleteFileDialog.java @@ -34,7 +34,6 @@ */ package gr.grnet.pithos.web.client; -import com.google.gwt.core.client.Scheduler; import gr.grnet.pithos.web.client.MessagePanel.Images; import gr.grnet.pithos.web.client.foldertree.File; import gr.grnet.pithos.web.client.foldertree.Resource; @@ -45,6 +44,7 @@ import java.util.Iterator; import java.util.List; import com.google.gwt.core.client.GWT; +import com.google.gwt.core.client.Scheduler; import com.google.gwt.dom.client.NativeEvent; import com.google.gwt.event.dom.client.ClickEvent; import com.google.gwt.event.dom.client.ClickHandler; @@ -58,7 +58,6 @@ import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.DialogBox; import com.google.gwt.user.client.ui.HTML; import com.google.gwt.user.client.ui.HasHorizontalAlignment; -import com.google.gwt.user.client.ui.HorizontalPanel; import com.google.gwt.user.client.ui.VerticalPanel; /** @@ -111,7 +110,7 @@ public class DeleteFileDialog extends DialogBox { // when the button is clicked and deletes the file. Button ok = new Button("Delete", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { deleteFiles(); hide(); } @@ -138,7 +137,7 @@ public class DeleteFileDialog extends DialogBox { String path = f.getUri(); DeleteRequest deleteFile = new DeleteRequest(app.getApiPath(), f.getOwner(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { deleteFile(iter); } diff --git a/src/gr/grnet/pithos/web/client/DeleteFolderDialog.java b/src/gr/grnet/pithos/web/client/DeleteFolderDialog.java index ae6af28..596dd2f 100644 --- a/src/gr/grnet/pithos/web/client/DeleteFolderDialog.java +++ b/src/gr/grnet/pithos/web/client/DeleteFolderDialog.java @@ -34,7 +34,6 @@ */ package gr.grnet.pithos.web.client; -import com.google.gwt.event.dom.client.KeyDownEvent; import gr.grnet.pithos.web.client.MessagePanel.Images; import gr.grnet.pithos.web.client.foldertree.Folder; @@ -42,6 +41,7 @@ import com.google.gwt.dom.client.NativeEvent; import com.google.gwt.event.dom.client.ClickEvent; import com.google.gwt.event.dom.client.ClickHandler; import com.google.gwt.event.dom.client.KeyCodes; +import com.google.gwt.event.dom.client.KeyDownEvent; import com.google.gwt.user.client.Event.NativePreviewEvent; import com.google.gwt.user.client.ui.AbstractImagePrototype; import com.google.gwt.user.client.ui.Anchor; @@ -49,7 +49,6 @@ import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.DialogBox; import com.google.gwt.user.client.ui.HTML; import com.google.gwt.user.client.ui.HasHorizontalAlignment; -import com.google.gwt.user.client.ui.HorizontalPanel; import com.google.gwt.user.client.ui.VerticalPanel; /** @@ -101,7 +100,7 @@ public class DeleteFolderDialog extends DialogBox { // when the button is clicked and deletes the folder. Button ok = new Button("Delete", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { app.deleteFolder(folder); hide(); } diff --git a/src/gr/grnet/pithos/web/client/FileContextMenu.java b/src/gr/grnet/pithos/web/client/FileContextMenu.java index 33702a3..03abed3 100644 --- a/src/gr/grnet/pithos/web/client/FileContextMenu.java +++ b/src/gr/grnet/pithos/web/client/FileContextMenu.java @@ -203,7 +203,6 @@ public class FileContextMenu extends PopupPanel { if (selectedFolder != null) { if (!selectedFolder.isInTrash()) { if (canWrite && app.getClipboard().hasFiles()) { - List files = (List) app.getClipboard().getItem(); pasteItem = new MenuItem("" + AbstractImagePrototype.create(images.paste()).getHTML() + " Paste", true, new PasteCommand(app, this, selectedFolder)); contextMenu.addItem(pasteItem); } diff --git a/src/gr/grnet/pithos/web/client/FileList.java b/src/gr/grnet/pithos/web/client/FileList.java index 82dc6d7..f019c2f 100644 --- a/src/gr/grnet/pithos/web/client/FileList.java +++ b/src/gr/grnet/pithos/web/client/FileList.java @@ -55,7 +55,6 @@ import com.google.gwt.event.dom.client.ContextMenuHandler; import com.google.gwt.i18n.client.DateTimeFormat; import com.google.gwt.resources.client.ImageResource; import com.google.gwt.safehtml.client.SafeHtmlTemplates; -import com.google.gwt.safehtml.client.SafeHtmlTemplates.Template; import com.google.gwt.safehtml.shared.SafeHtml; import com.google.gwt.safehtml.shared.SafeHtmlBuilder; import com.google.gwt.user.cellview.client.CellTable; @@ -386,7 +385,7 @@ public class FileList extends Composite { /** * Update the display of the file list. */ - void update(@SuppressWarnings("unused") boolean sort) { + void update() { showCellTable(); } @@ -553,7 +552,7 @@ public class FileList extends Composite { this.header=header; } @Override - public void update(@SuppressWarnings("unused") String value) { + public void update(String value) { header.setSorted(true); header.toggleReverseSort(); @@ -565,7 +564,7 @@ public class FileList extends Composite { } celltable.redrawHeaders(); sortFiles(property, header.getReverseSort()); - FileList.this.update(true); + FileList.this.update(); } } diff --git a/src/gr/grnet/pithos/web/client/FilePermissionsDialog.java b/src/gr/grnet/pithos/web/client/FilePermissionsDialog.java index eb993fd..662a363 100644 --- a/src/gr/grnet/pithos/web/client/FilePermissionsDialog.java +++ b/src/gr/grnet/pithos/web/client/FilePermissionsDialog.java @@ -52,7 +52,6 @@ import com.google.gwt.user.client.Window; import com.google.gwt.user.client.ui.Anchor; import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.CheckBox; -import com.google.gwt.user.client.ui.DecoratedTabPanel; import com.google.gwt.user.client.ui.FocusPanel; import com.google.gwt.user.client.ui.HasHorizontalAlignment; import com.google.gwt.user.client.ui.HorizontalPanel; @@ -101,7 +100,7 @@ public class FilePermissionsDialog extends AbstractPropertiesDialog { close.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { hide(); } }); @@ -127,7 +126,7 @@ public class FilePermissionsDialog extends AbstractPropertiesDialog { // when the button is clicked. final Button ok = new Button("OK", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { accept(); closeDialog(); } @@ -151,7 +150,7 @@ public class FilePermissionsDialog extends AbstractPropertiesDialog { HorizontalPanel permButtons = new HorizontalPanel(); Button add = new Button("Add Group", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { PermissionsAddDialog dlg = new PermissionsAddDialog(app, app.getAccount().getGroups(), permList, false); dlg.center(); permList.updatePermissionTable(); @@ -163,7 +162,7 @@ public class FilePermissionsDialog extends AbstractPropertiesDialog { final Button addUser = new Button("Add User", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { PermissionsAddDialog dlg = new PermissionsAddDialog(app, app.getAccount().getGroups(), permList, true); dlg.center(); permList.updatePermissionTable(); @@ -188,7 +187,7 @@ public class FilePermissionsDialog extends AbstractPropertiesDialog { readForAll.setValue(file.isPublished()); readForAll.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { readForAllNote.setVisible(readForAll.getValue()); } }); @@ -255,7 +254,7 @@ public class FilePermissionsDialog extends AbstractPropertiesDialog { if (published != null || newPermissions != null) { PostRequest updateFile = new PostRequest(api, owner, path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { app.updateFolder(file.getParent(), true, new Command() { @Override @@ -273,7 +272,7 @@ public class FilePermissionsDialog extends AbstractPropertiesDialog { } @Override - protected void onUnauthorized(@SuppressWarnings("unused") Response response) { + protected void onUnauthorized(Response response) { app.sessionExpired(); } }; diff --git a/src/gr/grnet/pithos/web/client/FilePropertiesDialog.java b/src/gr/grnet/pithos/web/client/FilePropertiesDialog.java index af5f4ba..ba89a65 100644 --- a/src/gr/grnet/pithos/web/client/FilePropertiesDialog.java +++ b/src/gr/grnet/pithos/web/client/FilePropertiesDialog.java @@ -52,9 +52,7 @@ import com.google.gwt.i18n.client.DateTimeFormat; import com.google.gwt.user.client.Command; import com.google.gwt.user.client.ui.Anchor; import com.google.gwt.user.client.ui.Button; -import com.google.gwt.user.client.ui.DecoratedTabPanel; import com.google.gwt.user.client.ui.FlexTable; -import com.google.gwt.user.client.ui.FocusPanel; import com.google.gwt.user.client.ui.HasHorizontalAlignment; import com.google.gwt.user.client.ui.HorizontalPanel; import com.google.gwt.user.client.ui.Image; @@ -88,7 +86,7 @@ public class FilePropertiesDialog extends AbstractPropertiesDialog { close.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { hide(); } }); @@ -113,7 +111,7 @@ public class FilePropertiesDialog extends AbstractPropertiesDialog { // when the button is clicked. final Button ok = new Button("OK", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { accept(); closeDialog(); } @@ -187,7 +185,7 @@ public class FilePropertiesDialog extends AbstractPropertiesDialog { plus.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { addFormLine(metaTable, metaTable.getRowCount(), "", ""); } }); @@ -247,7 +245,7 @@ public class FilePropertiesDialog extends AbstractPropertiesDialog { final String path = file.getParent().getUri() + "/" + newFilename; PutRequest updateFile = new PutRequest(app.getApiPath(), app.getUsername(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { updateMetaData(app.getApiPath(), file.getOwner(), path + "?update=", newMeta); } @@ -259,7 +257,7 @@ public class FilePropertiesDialog extends AbstractPropertiesDialog { } @Override - protected void onUnauthorized(@SuppressWarnings("unused") Response response) { + protected void onUnauthorized(Response response) { app.sessionExpired(); } }; @@ -304,7 +302,7 @@ public class FilePropertiesDialog extends AbstractPropertiesDialog { if (newMeta != null) { PostRequest updateFile = new PostRequest(api, owner, path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { app.updateFolder(file.getParent(), true, new Command() { @Override @@ -322,7 +320,7 @@ public class FilePropertiesDialog extends AbstractPropertiesDialog { } @Override - protected void onUnauthorized(@SuppressWarnings("unused") Response response) { + protected void onUnauthorized(Response response) { app.sessionExpired(); } }; diff --git a/src/gr/grnet/pithos/web/client/FileUploadDialog.java b/src/gr/grnet/pithos/web/client/FileUploadDialog.java index c7f1259..b80c71b 100644 --- a/src/gr/grnet/pithos/web/client/FileUploadDialog.java +++ b/src/gr/grnet/pithos/web/client/FileUploadDialog.java @@ -45,7 +45,7 @@ import com.google.gwt.event.dom.client.KeyCodes; import com.google.gwt.user.client.Command; import com.google.gwt.user.client.Cookies; import com.google.gwt.user.client.Event.NativePreviewEvent; -import com.google.gwt.user.client.Window; +import com.google.gwt.user.client.ui.Anchor; import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.DialogBox; import com.google.gwt.user.client.ui.FileUpload; @@ -54,7 +54,6 @@ import com.google.gwt.user.client.ui.FormPanel.SubmitCompleteEvent; import com.google.gwt.user.client.ui.FormPanel.SubmitCompleteHandler; import com.google.gwt.user.client.ui.FormPanel.SubmitEvent; import com.google.gwt.user.client.ui.FormPanel.SubmitHandler; -import com.google.gwt.user.client.ui.Anchor; import com.google.gwt.user.client.ui.Grid; import com.google.gwt.user.client.ui.HasHorizontalAlignment; import com.google.gwt.user.client.ui.Hidden; @@ -143,7 +142,7 @@ public class FileUploadDialog extends DialogBox { // form. submit = new Button("Upload", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { prepareAndSubmit(); } }); @@ -154,7 +153,7 @@ public class FileUploadDialog extends DialogBox { form.addSubmitHandler(new SubmitHandler() { @Override - public void onSubmit(@SuppressWarnings("unused") SubmitEvent event) { + public void onSubmit(SubmitEvent event) { auth.setValue(app.getToken()); //This is done here because the app object is not available in the constructor Cookies.setCookie("X-Auth-Token", app.getToken(), null, "", "/", false); } diff --git a/src/gr/grnet/pithos/web/client/FileVersionsDialog.java b/src/gr/grnet/pithos/web/client/FileVersionsDialog.java index 1c3f40c..97b0c24 100644 --- a/src/gr/grnet/pithos/web/client/FileVersionsDialog.java +++ b/src/gr/grnet/pithos/web/client/FileVersionsDialog.java @@ -36,32 +36,24 @@ package gr.grnet.pithos.web.client; import gr.grnet.pithos.web.client.foldertree.File; import gr.grnet.pithos.web.client.foldertree.FileVersions; -import gr.grnet.pithos.web.client.foldertree.Resource; import gr.grnet.pithos.web.client.foldertree.Version; import gr.grnet.pithos.web.client.rest.GetRequest; -import gr.grnet.pithos.web.client.rest.PostRequest; -import gr.grnet.pithos.web.client.rest.PutRequest; import gr.grnet.pithos.web.client.rest.RestException; -import java.util.HashMap; import java.util.List; -import java.util.Map; import com.google.gwt.core.client.GWT; import com.google.gwt.core.client.Scheduler; import com.google.gwt.event.dom.client.ClickEvent; import com.google.gwt.event.dom.client.ClickHandler; import com.google.gwt.http.client.Response; -import com.google.gwt.http.client.URL; import com.google.gwt.resources.client.ImageResource; import com.google.gwt.user.client.Command; import com.google.gwt.user.client.ui.Anchor; import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.CheckBox; -import com.google.gwt.user.client.ui.DecoratedTabPanel; import com.google.gwt.user.client.ui.FocusPanel; import com.google.gwt.user.client.ui.HasHorizontalAlignment; -import com.google.gwt.user.client.ui.TextBox; import com.google.gwt.user.client.ui.VerticalPanel; /** @@ -111,7 +103,7 @@ public class FileVersionsDialog extends AbstractPropertiesDialog { close.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { hide(); } }); @@ -137,7 +129,7 @@ public class FileVersionsDialog extends AbstractPropertiesDialog { // when the button is clicked. final Button ok = new Button("OK", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { accept(); closeDialog(); } @@ -172,7 +164,7 @@ public class FileVersionsDialog extends AbstractPropertiesDialog { } @Override - protected void onUnauthorized(@SuppressWarnings("unused") Response response) { + protected void onUnauthorized(Response response) { app.sessionExpired(); } }; @@ -193,10 +185,6 @@ public class FileVersionsDialog extends AbstractPropertiesDialog { */ @Override protected void accept() { - updateMetaData(app.getApiPath(), app.getUsername(), file.getUri() + "?update="); - } - - protected void updateMetaData(String api, String owner, String path) { app.updateFolder(file.getParent(), true, new Command() { @Override @@ -205,5 +193,5 @@ public class FileVersionsDialog extends AbstractPropertiesDialog { app.updateMySharedRoot(); } }); - } + } } diff --git a/src/gr/grnet/pithos/web/client/FilesPropertiesDialog.java b/src/gr/grnet/pithos/web/client/FilesPropertiesDialog.java index db99434..e3fcb93 100644 --- a/src/gr/grnet/pithos/web/client/FilesPropertiesDialog.java +++ b/src/gr/grnet/pithos/web/client/FilesPropertiesDialog.java @@ -42,10 +42,7 @@ import java.util.List; import com.google.gwt.event.dom.client.ClickEvent; import com.google.gwt.event.dom.client.ClickHandler; import com.google.gwt.user.client.ui.Button; -import com.google.gwt.user.client.ui.DecoratedTabPanel; -import com.google.gwt.user.client.ui.DisclosurePanel; import com.google.gwt.user.client.ui.FlexTable; -import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.FocusPanel; import com.google.gwt.user.client.ui.HasHorizontalAlignment; import com.google.gwt.user.client.ui.HorizontalPanel; @@ -87,7 +84,7 @@ public class FilesPropertiesDialog extends AbstractPropertiesDialog { // when the button is clicked. final Button ok = new Button("OK", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { accept(); closeDialog(); } @@ -98,7 +95,7 @@ public class FilesPropertiesDialog extends AbstractPropertiesDialog { // dialog when the button is clicked. final Button cancel = new Button("Cancel", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { closeDialog(); } }); diff --git a/src/gr/grnet/pithos/web/client/FolderContextMenu.java b/src/gr/grnet/pithos/web/client/FolderContextMenu.java index 17ded09..f128d08 100644 --- a/src/gr/grnet/pithos/web/client/FolderContextMenu.java +++ b/src/gr/grnet/pithos/web/client/FolderContextMenu.java @@ -44,11 +44,8 @@ import gr.grnet.pithos.web.client.commands.PropertiesCommand; import gr.grnet.pithos.web.client.commands.RefreshCommand; import gr.grnet.pithos.web.client.commands.RestoreTrashCommand; import gr.grnet.pithos.web.client.commands.ToTrashCommand; -import gr.grnet.pithos.web.client.foldertree.File; import gr.grnet.pithos.web.client.foldertree.Folder; -import java.util.List; - import com.google.gwt.user.client.ui.AbstractImagePrototype; import com.google.gwt.user.client.ui.MenuBar; import com.google.gwt.user.client.ui.MenuItem; diff --git a/src/gr/grnet/pithos/web/client/FolderPermissionsDialog.java b/src/gr/grnet/pithos/web/client/FolderPermissionsDialog.java index 6b172e6..7c45fea 100644 --- a/src/gr/grnet/pithos/web/client/FolderPermissionsDialog.java +++ b/src/gr/grnet/pithos/web/client/FolderPermissionsDialog.java @@ -91,7 +91,7 @@ public class FolderPermissionsDialog extends DialogBox { close.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { hide(); } }); @@ -127,7 +127,7 @@ public class FolderPermissionsDialog extends DialogBox { HorizontalPanel permButtons = new HorizontalPanel(); Button add = new Button("Add Group", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { PermissionsAddDialog dlg = new PermissionsAddDialog(app, app.getAccount().getGroups(), permList, false); dlg.center(); } @@ -138,7 +138,7 @@ public class FolderPermissionsDialog extends DialogBox { Button addUser = new Button("Add User", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { PermissionsAddDialog dlg = new PermissionsAddDialog(app, app.getAccount().getGroups(), permList, true); dlg.center(); } @@ -159,7 +159,7 @@ public class FolderPermissionsDialog extends DialogBox { String okLabel = "Update"; final Button ok = new Button(okLabel, new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { updateFolder(); closeDialog(); } @@ -207,7 +207,7 @@ public class FolderPermissionsDialog extends DialogBox { final String path = folder.getParent().getUri() + "/" + newName; PutRequest newFolder = new PutRequest(app.getApiPath(), folder.getParent().getOwner(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { Iterator iter = folder.getFiles().iterator(); app.copyFiles(iter, folder.getParent().getOwner(), folder.getParent().getUri() + "/" + newName, new Command() { @Override @@ -236,7 +236,7 @@ public class FolderPermissionsDialog extends DialogBox { } @Override - protected void onUnauthorized(@SuppressWarnings("unused") Response response) { + protected void onUnauthorized(Response response) { app.sessionExpired(); } }; @@ -254,7 +254,7 @@ public class FolderPermissionsDialog extends DialogBox { if (newPermissions != null) { PostRequest updateFolder = new PostRequest(app.getApiPath(), folder.getOwner(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { app.updateFolder(folder.getParent(), false, new Command() { @Override @@ -273,7 +273,7 @@ public class FolderPermissionsDialog extends DialogBox { final String path1 = folder.getUri(); PutRequest newFolder = new PutRequest(app.getApiPath(), folder.getOwner(), path1) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { updateMetadata(path, newPermissions); } @@ -289,7 +289,7 @@ public class FolderPermissionsDialog extends DialogBox { } @Override - protected void onUnauthorized(@SuppressWarnings("unused") Response response) { + protected void onUnauthorized(Response response) { app.sessionExpired(); } }; @@ -310,7 +310,7 @@ public class FolderPermissionsDialog extends DialogBox { } @Override - protected void onUnauthorized(@SuppressWarnings("unused") Response response) { + protected void onUnauthorized(Response response) { app.sessionExpired(); } }; diff --git a/src/gr/grnet/pithos/web/client/FolderPropertiesDialog.java b/src/gr/grnet/pithos/web/client/FolderPropertiesDialog.java index 045a517..acb6d55 100644 --- a/src/gr/grnet/pithos/web/client/FolderPropertiesDialog.java +++ b/src/gr/grnet/pithos/web/client/FolderPropertiesDialog.java @@ -96,7 +96,7 @@ public class FolderPropertiesDialog extends DialogBox { close.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { hide(); } }); @@ -172,7 +172,7 @@ public class FolderPropertiesDialog extends DialogBox { okLabel = "Update"; final Button ok = new Button(okLabel, new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { createOrUpdateFolder(); closeDialog(); } @@ -184,7 +184,7 @@ public class FolderPropertiesDialog extends DialogBox { folderName.addChangeHandler(new ChangeHandler() { @Override - public void onChange(@SuppressWarnings("unused") ChangeEvent event) { + public void onChange(ChangeEvent event) { if(folderName.getText().contains("/")) { folderNameNote.setVisible(true); ok.setEnabled(false); @@ -242,7 +242,7 @@ public class FolderPropertiesDialog extends DialogBox { String path = folder.getUri() + "/" + name; PutRequest createFolder = new PutRequest(app.getApiPath(), folder.getOwner(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { app.updateFolder(folder, true, new Command() { @Override @@ -264,7 +264,7 @@ public class FolderPropertiesDialog extends DialogBox { } @Override - protected void onUnauthorized(@SuppressWarnings("unused") Response response) { + protected void onUnauthorized(Response response) { app.sessionExpired(); } }; @@ -294,7 +294,7 @@ public class FolderPropertiesDialog extends DialogBox { final String path = folder.getParent().getUri() + "/" + newName; PutRequest newFolder = new PutRequest(app.getApiPath(), folder.getParent().getOwner(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { Iterator iter = folder.getFiles().iterator(); app.copyFiles(iter, folder.getParent().getOwner(), folder.getParent().getUri() + "/" + newName, new Command() { @Override @@ -329,7 +329,7 @@ public class FolderPropertiesDialog extends DialogBox { } @Override - protected void onUnauthorized(@SuppressWarnings("unused") Response response) { + protected void onUnauthorized(Response response) { app.sessionExpired(); } }; diff --git a/src/gr/grnet/pithos/web/client/InvitationsDialog.java b/src/gr/grnet/pithos/web/client/InvitationsDialog.java index 9d58d81..d1c0d33 100644 --- a/src/gr/grnet/pithos/web/client/InvitationsDialog.java +++ b/src/gr/grnet/pithos/web/client/InvitationsDialog.java @@ -39,12 +39,9 @@ import gr.grnet.pithos.web.client.rest.PostRequest; import com.google.gwt.core.client.GWT; import com.google.gwt.core.client.Scheduler; -import com.google.gwt.dom.client.NativeEvent; import com.google.gwt.event.dom.client.ClickEvent; import com.google.gwt.event.dom.client.ClickHandler; -import com.google.gwt.event.dom.client.KeyCodes; import com.google.gwt.http.client.Response; -import com.google.gwt.user.client.Event.NativePreviewEvent; import com.google.gwt.user.client.ui.Anchor; import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.DialogBox; @@ -55,7 +52,6 @@ import com.google.gwt.user.client.ui.HorizontalPanel; import com.google.gwt.user.client.ui.Image; import com.google.gwt.user.client.ui.TextBox; import com.google.gwt.user.client.ui.VerticalPanel; -import com.google.gwt.user.client.ui.Widget; /** @@ -228,7 +224,7 @@ public class InvitationsDialog extends DialogBox { setWidget(outer); } - private void addFormLine(final FlexTable table) { + void addFormLine(final FlexTable table) { table.setWidget(rows, 0, new TextBox()); table.getFlexCellFormatter().setStyleName(1, 0, "props-values"); diff --git a/src/gr/grnet/pithos/web/client/MessagePanel.java b/src/gr/grnet/pithos/web/client/MessagePanel.java index 81aa361..0ae053f 100644 --- a/src/gr/grnet/pithos/web/client/MessagePanel.java +++ b/src/gr/grnet/pithos/web/client/MessagePanel.java @@ -112,7 +112,7 @@ public class MessagePanel extends Composite { message.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { FadeOut anim = new FadeOut(simplePanel){ @Override @@ -136,7 +136,7 @@ public class MessagePanel extends Composite { clearMessageLink.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { FadeOut anim = new FadeOut(simplePanel){ @Override protected void onComplete() { @@ -153,7 +153,7 @@ public class MessagePanel extends Composite { feedbackLink.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { new FeedbackDialog(app, app.getErrorData()).center(); } }); diff --git a/src/gr/grnet/pithos/web/client/PermissionsAddDialog.java b/src/gr/grnet/pithos/web/client/PermissionsAddDialog.java index 96f3a80..c2fa97c 100644 --- a/src/gr/grnet/pithos/web/client/PermissionsAddDialog.java +++ b/src/gr/grnet/pithos/web/client/PermissionsAddDialog.java @@ -34,8 +34,6 @@ */ package gr.grnet.pithos.web.client; -import com.google.gwt.user.client.ui.TextBox; - import gr.grnet.pithos.web.client.grouptree.Group; import java.util.List; @@ -51,8 +49,8 @@ import com.google.gwt.user.client.ui.CheckBox; import com.google.gwt.user.client.ui.DialogBox; import com.google.gwt.user.client.ui.FlexTable; import com.google.gwt.user.client.ui.HasHorizontalAlignment; -import com.google.gwt.user.client.ui.HorizontalPanel; import com.google.gwt.user.client.ui.ListBox; +import com.google.gwt.user.client.ui.TextBox; import com.google.gwt.user.client.ui.VerticalPanel; public class PermissionsAddDialog extends DialogBox { @@ -121,7 +119,7 @@ public class PermissionsAddDialog extends DialogBox { final Button ok = new Button("OK", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { addPermission(); hide(); } diff --git a/src/gr/grnet/pithos/web/client/PermissionsList.java b/src/gr/grnet/pithos/web/client/PermissionsList.java index 3ce05a5..c2e5e30 100644 --- a/src/gr/grnet/pithos/web/client/PermissionsList.java +++ b/src/gr/grnet/pithos/web/client/PermissionsList.java @@ -154,7 +154,7 @@ public class PermissionsList extends Composite { }); PushButton removeButton = new PushButton(AbstractImagePrototype.create(images.delete()).createImage(), new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { permissions.remove(user); updatePermissionTable(); hasChanges = true; diff --git a/src/gr/grnet/pithos/web/client/Pithos.java b/src/gr/grnet/pithos/web/client/Pithos.java index 64358db..fc3d955 100644 --- a/src/gr/grnet/pithos/web/client/Pithos.java +++ b/src/gr/grnet/pithos/web/client/Pithos.java @@ -56,11 +56,8 @@ import gr.grnet.pithos.web.client.rest.HeadRequest; import gr.grnet.pithos.web.client.rest.PutRequest; import gr.grnet.pithos.web.client.rest.RestException; import gr.grnet.pithos.web.client.tagtree.Tag; -import gr.grnet.pithos.web.client.tagtree.TagTreeView; -import gr.grnet.pithos.web.client.tagtree.TagTreeViewModel; import java.util.ArrayList; -import java.util.Date; import java.util.HashMap; import java.util.Iterator; import java.util.List; @@ -100,12 +97,10 @@ import com.google.gwt.user.client.ui.Button; import com.google.gwt.user.client.ui.Composite; import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.HTML; -import com.google.gwt.user.client.ui.HTMLPanel; import com.google.gwt.user.client.ui.HasHorizontalAlignment; import com.google.gwt.user.client.ui.HasVerticalAlignment; import com.google.gwt.user.client.ui.HorizontalPanel; import com.google.gwt.user.client.ui.HorizontalSplitPanel; -import com.google.gwt.user.client.ui.Image; import com.google.gwt.user.client.ui.RootPanel; import com.google.gwt.user.client.ui.VerticalPanel; import com.google.gwt.view.client.SelectionChangeEvent; @@ -310,7 +305,7 @@ public class Pithos implements EntryPoint, ResizeHandler { header.addStyleName("pithos-header-noframe"); upload = new Button("Upload File", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { new UploadFileCommand(Pithos.this, null, getSelection()).execute(); } }); @@ -335,7 +330,7 @@ public class Pithos implements EntryPoint, ResizeHandler { newFolderButton.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { Folder folder = getSelectedTree().getSelection(); if (folder != null) { Boolean[] permissions = folder.getPermissions().get(getUsername()); @@ -354,7 +349,7 @@ public class Pithos implements EntryPoint, ResizeHandler { shareFolderButton.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { Folder folder = getSelectedTree().getSelection(); if (folder != null) { Boolean[] permissions = folder.getPermissions().get(getUsername()); @@ -374,7 +369,7 @@ public class Pithos implements EntryPoint, ResizeHandler { refreshButton.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { boolean isFolderTreeSelected = selectedTree.equals(getFolderTreeView()); boolean otherSharedTreeSelected = selectedTree.equals(getOtherSharedTreeView()); Folder folder = getSelectedTree().getSelection(); @@ -410,7 +405,6 @@ public class Pithos implements EntryPoint, ResizeHandler { header.add(toolbar); header.setCellHorizontalAlignment(toolbar, HasHorizontalAlignment.ALIGN_CENTER); header.setCellVerticalAlignment(toolbar, HasVerticalAlignment.ALIGN_MIDDLE); -// header.setCellWidth(toolbar, "40px"); HorizontalPanel folderStatistics = new HorizontalPanel(); folderStatistics.addStyleName("pithos-folderStatistics"); @@ -433,7 +427,7 @@ public class Pithos implements EntryPoint, ResizeHandler { folderTreeSelectionModel = new SingleSelectionModel(); folderTreeSelectionModel.addSelectionChangeHandler(new SelectionChangeEvent.Handler() { @Override - public void onSelectionChange(@SuppressWarnings("unused") SelectionChangeEvent event) { + public void onSelectionChange(SelectionChangeEvent event) { if (folderTreeSelectionModel.getSelectedObject() != null) { deselectOthers(folderTreeView, folderTreeSelectionModel); applyPermissions(folderTreeSelectionModel.getSelectedObject()); @@ -614,7 +608,7 @@ public class Pithos implements EntryPoint, ResizeHandler { String path = file.getUri() + "?format=json"; GetRequest getFile = new GetRequest(File.class, getApiPath(), username, path, file) { @Override - public void onSuccess(@SuppressWarnings("unused") File _result) { + public void onSuccess(File _result) { fetchFile(iter, files); } @@ -714,7 +708,7 @@ public class Pithos implements EntryPoint, ResizeHandler { HeadRequest headAccount = new HeadRequest(AccountResource.class, getApiPath(), username, "", account) { @Override - public void onSuccess(@SuppressWarnings("unused") AccountResource _result) { + public void onSuccess(AccountResource _result) { showStatistics(); } @@ -748,7 +742,7 @@ public class Pithos implements EntryPoint, ResizeHandler { String path = "/" + Pithos.HOME_CONTAINER; PutRequest createPithos = new PutRequest(getApiPath(), getUsername(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { if (!_account.hasTrashContainer()) createTrashContainer(callback); else @@ -778,7 +772,7 @@ public class Pithos implements EntryPoint, ResizeHandler { String path = "/" + Pithos.TRASH_CONTAINER; PutRequest createPithos = new PutRequest(getApiPath(), getUsername(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { fetchAccount(callback); } @@ -932,7 +926,7 @@ public class Pithos implements EntryPoint, ResizeHandler { try { builder.sendRequest("", new RequestCallback() { @Override - public void onResponseReceived(@SuppressWarnings("unused") Request request, Response response) { + public void onResponseReceived(Request request, Response response) { if (response.getStatusCode() == Response.SC_OK) { JSONValue json = JSONParser.parseStrict(response.getText()); JSONArray array = json.isArray(); @@ -944,7 +938,7 @@ public class Pithos implements EntryPoint, ResizeHandler { } @Override - public void onError(@SuppressWarnings("unused") Request request, Throwable exception) { + public void onError(Request request, Throwable exception) { setError(exception); displayError("System error unable to delete folder: " + exception.getMessage()); } @@ -962,7 +956,7 @@ public class Pithos implements EntryPoint, ResizeHandler { String path = "/" + folder.getContainer() + "/" + name.stringValue(); DeleteRequest delete = new DeleteRequest(getApiPath(), folder.getOwner(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { deleteObject(folder, i + 1, array); } @@ -990,7 +984,7 @@ public class Pithos implements EntryPoint, ResizeHandler { try { builder.sendRequest("", new RequestCallback() { @Override - public void onResponseReceived(@SuppressWarnings("unused") Request request, Response response) { + public void onResponseReceived(Request request, Response response) { if (response.getStatusCode() == Response.SC_OK) { JSONValue json = JSONParser.parseStrict(response.getText()); JSONArray array2 = json.isArray(); @@ -1005,7 +999,7 @@ public class Pithos implements EntryPoint, ResizeHandler { } @Override - public void onError(@SuppressWarnings("unused") Request request, Throwable exception) { + public void onError(Request request, Throwable exception) { setError(exception); displayError("System error unable to delete folder: " + exception.getMessage()); } @@ -1019,7 +1013,7 @@ public class Pithos implements EntryPoint, ResizeHandler { String path = folder.getUri(); DeleteRequest deleteFolder = new DeleteRequest(getApiPath(), getUsername(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { updateFolder(folder.getParent(), true, new Command() { @Override @@ -1063,7 +1057,7 @@ public class Pithos implements EntryPoint, ResizeHandler { String path = targetUri + "/" + file.getName(); PutRequest copyFile = new PutRequest(getApiPath(), targetUsername, path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { copyFiles(iter, targetUsername, targetUri, callback); } @@ -1115,7 +1109,7 @@ public class Pithos implements EntryPoint, ResizeHandler { String path = targetUri + "/" + f.getName(); PutRequest createFolder = new PutRequest(getApiPath(), targetUsername, path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { GetRequest getFolder = new GetRequest(Folder.class, getApiPath(), f.getOwner(), "/" + f.getContainer() + "?format=json&delimiter=/&prefix=" + URL.encodeQueryString(f.getPrefix()), f) { @Override @@ -1228,7 +1222,7 @@ public class Pithos implements EntryPoint, ResizeHandler { mysharedTreeSelectionModel = new SingleSelectionModel(); mysharedTreeSelectionModel.addSelectionChangeHandler(new Handler() { @Override - public void onSelectionChange(@SuppressWarnings("unused") SelectionChangeEvent event) { + public void onSelectionChange(SelectionChangeEvent event) { if (mysharedTreeSelectionModel.getSelectedObject() != null) { deselectOthers(mysharedTreeView, mysharedTreeSelectionModel); upload.setEnabled(false); @@ -1254,7 +1248,7 @@ public class Pithos implements EntryPoint, ResizeHandler { otherSharedTreeSelectionModel = new SingleSelectionModel(); otherSharedTreeSelectionModel.addSelectionChangeHandler(new Handler() { @Override - public void onSelectionChange(@SuppressWarnings("unused") SelectionChangeEvent event) { + public void onSelectionChange(SelectionChangeEvent event) { if (otherSharedTreeSelectionModel.getSelectedObject() != null) { deselectOthers(otherSharedTreeView, otherSharedTreeSelectionModel); otherSharedTreeView.addStyleName("cellTreeWidget-selectedTree"); diff --git a/src/gr/grnet/pithos/web/client/PithosSelectionEventManager.java b/src/gr/grnet/pithos/web/client/PithosSelectionEventManager.java index 3879ea7..9604e64 100644 --- a/src/gr/grnet/pithos/web/client/PithosSelectionEventManager.java +++ b/src/gr/grnet/pithos/web/client/PithosSelectionEventManager.java @@ -96,7 +96,7 @@ public class PithosSelectionEventManager implements } @Override - public boolean clearCurrentSelection(@SuppressWarnings("unused") CellPreviewEvent event) { + public boolean clearCurrentSelection(CellPreviewEvent event) { return false; } diff --git a/src/gr/grnet/pithos/web/client/SessionExpiredDialog.java b/src/gr/grnet/pithos/web/client/SessionExpiredDialog.java index 6eb7c7b..b637e20 100644 --- a/src/gr/grnet/pithos/web/client/SessionExpiredDialog.java +++ b/src/gr/grnet/pithos/web/client/SessionExpiredDialog.java @@ -73,7 +73,7 @@ public class SessionExpiredDialog extends DialogBox { // when the button is clicked. Button confirm = new Button("Proceed", new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { app.authenticateUser(); hide(); } diff --git a/src/gr/grnet/pithos/web/client/SortableHeader.java b/src/gr/grnet/pithos/web/client/SortableHeader.java index c55cef5..87af108 100644 --- a/src/gr/grnet/pithos/web/client/SortableHeader.java +++ b/src/gr/grnet/pithos/web/client/SortableHeader.java @@ -109,7 +109,7 @@ public class SortableHeader extends Header { } @Override - public void render(@SuppressWarnings("unused") Context context, SafeHtmlBuilder sb) { + public void render(Context context, SafeHtmlBuilder sb) { if (sorted) { sb.append(template.sorted(IMAGE_WIDTH, reverseSort ? DOWN_ARROW : UP_ARROW, text)); } else { diff --git a/src/gr/grnet/pithos/web/client/ToolsMenu.java b/src/gr/grnet/pithos/web/client/ToolsMenu.java index 4e530cc..b45baf7 100644 --- a/src/gr/grnet/pithos/web/client/ToolsMenu.java +++ b/src/gr/grnet/pithos/web/client/ToolsMenu.java @@ -41,10 +41,8 @@ import gr.grnet.pithos.web.client.commands.CutCommand; import gr.grnet.pithos.web.client.commands.DeleteCommand; import gr.grnet.pithos.web.client.commands.DeleteGroupCommand; import gr.grnet.pithos.web.client.commands.EmptyTrashCommand; -import gr.grnet.pithos.web.client.commands.NewFolderCommand; import gr.grnet.pithos.web.client.commands.PasteCommand; import gr.grnet.pithos.web.client.commands.PropertiesCommand; -import gr.grnet.pithos.web.client.commands.RefreshCommand; import gr.grnet.pithos.web.client.commands.RemoveUserCommand; import gr.grnet.pithos.web.client.commands.RestoreTrashCommand; import gr.grnet.pithos.web.client.commands.ToTrashCommand; @@ -56,8 +54,6 @@ import gr.grnet.pithos.web.client.grouptree.User; import java.util.List; -import com.google.gwt.resources.client.ImageResource; -import com.google.gwt.resources.client.ClientBundle.Source; import com.google.gwt.user.client.Command; import com.google.gwt.user.client.Window; import com.google.gwt.user.client.ui.AbstractImagePrototype; @@ -133,7 +129,8 @@ public class ToolsMenu extends PopupPanel { Object item = app.getClipboard().getItem(); boolean showPaste = false; if (item instanceof List) { - List _files = (List) item; + @SuppressWarnings("unchecked") + List _files = (List) item; if (_files.get(0).getOwner().equals(folder.getOwner())) showPaste = true; } @@ -184,7 +181,7 @@ public class ToolsMenu extends PopupPanel { @Override public void execute() { for (File f: files) - Window.open(app.getApiPath() + files.get(0).getOwner() + files.get(0).getUri() + "?X-Auth-Token=" + app.getToken(), "_blank", ""); + Window.open(app.getApiPath() + f.getOwner() + f.getUri() + "?X-Auth-Token=" + app.getToken(), "_blank", ""); } })); } diff --git a/src/gr/grnet/pithos/web/client/TopPanel.java b/src/gr/grnet/pithos/web/client/TopPanel.java index 3c89d60..d94920e 100644 --- a/src/gr/grnet/pithos/web/client/TopPanel.java +++ b/src/gr/grnet/pithos/web/client/TopPanel.java @@ -34,7 +34,6 @@ */ package gr.grnet.pithos.web.client; -import gr.grnet.pithos.web.client.foldertree.Resource; import gr.grnet.pithos.web.client.rest.GetRequest; import gr.grnet.pithos.web.client.rest.RestException; @@ -42,18 +41,13 @@ import com.google.gwt.core.client.GWT; import com.google.gwt.core.client.Scheduler; import com.google.gwt.http.client.Response; import com.google.gwt.resources.client.ImageResource; -import com.google.gwt.safehtml.shared.SafeHtml; -import com.google.gwt.safehtml.shared.SafeHtmlBuilder; -import com.google.gwt.safehtml.shared.SafeHtmlUtils; import com.google.gwt.user.client.Command; -import com.google.gwt.user.client.Cookies; import com.google.gwt.user.client.ui.AbstractImagePrototype; import com.google.gwt.user.client.ui.Composite; import com.google.gwt.user.client.ui.HTML; import com.google.gwt.user.client.ui.HasHorizontalAlignment; import com.google.gwt.user.client.ui.HasVerticalAlignment; import com.google.gwt.user.client.ui.HorizontalPanel; -import com.google.gwt.user.client.ui.Image; import com.google.gwt.user.client.ui.MenuBar; import com.google.gwt.user.client.ui.MenuItem; @@ -148,7 +142,7 @@ public class TopPanel extends Composite { @Override public void execute() { - new CredentialsDialog(app, images).center(); + new CredentialsDialog(app).center(); } })); userItemMenu.addItem(new MenuItem("logout", new Command() { diff --git a/src/gr/grnet/pithos/web/client/VersionsList.java b/src/gr/grnet/pithos/web/client/VersionsList.java index 7f6b6a9..bff34cf 100644 --- a/src/gr/grnet/pithos/web/client/VersionsList.java +++ b/src/gr/grnet/pithos/web/client/VersionsList.java @@ -102,7 +102,7 @@ public class VersionsList extends Composite { HTML restoreVersion = new HTML("" + AbstractImagePrototype.create(images.restore()).getHTML() + "
Restore this Version
"); restoreVersion.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { restoreVersion(v.getVersion()); } }); @@ -115,7 +115,7 @@ public class VersionsList extends Composite { HTML downloadHtml = new HTML("" + AbstractImagePrototype.create(images.download()).getHTML()+"
View this Version
"); downloadHtml.addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { String fileUrl = app.getApiPath() + file.getOwner() + file.getUri() + "?X-Auth-Token=" + app.getToken() + "&version=" + v.getVersion(); Window.open(fileUrl, "_BLANK", ""); } @@ -135,7 +135,7 @@ public class VersionsList extends Composite { PostRequest restoreVersion = new PostRequest(app.getApiPath(), file.getOwner(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { container.hide(); } diff --git a/src/gr/grnet/pithos/web/client/commands/AddUserCommand.java b/src/gr/grnet/pithos/web/client/commands/AddUserCommand.java index be0e0f9..489453e 100644 --- a/src/gr/grnet/pithos/web/client/commands/AddUserCommand.java +++ b/src/gr/grnet/pithos/web/client/commands/AddUserCommand.java @@ -79,7 +79,7 @@ public class AddUserCommand implements Command { PostRequest updateGroup = new PostRequest(app.getApiPath(), app.getUsername(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { app.updateGroupNode(group); } diff --git a/src/gr/grnet/pithos/web/client/commands/DeleteGroupCommand.java b/src/gr/grnet/pithos/web/client/commands/DeleteGroupCommand.java index 8daf2d2..7f05f2f 100644 --- a/src/gr/grnet/pithos/web/client/commands/DeleteGroupCommand.java +++ b/src/gr/grnet/pithos/web/client/commands/DeleteGroupCommand.java @@ -78,7 +78,7 @@ public class DeleteGroupCommand implements Command { PostRequest updateGroup = new PostRequest(app.getApiPath(), app.getUsername(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { app.removeGroup(group); } diff --git a/src/gr/grnet/pithos/web/client/commands/EmptyTrashCommand.java b/src/gr/grnet/pithos/web/client/commands/EmptyTrashCommand.java index ce836e8..f5f7db7 100644 --- a/src/gr/grnet/pithos/web/client/commands/EmptyTrashCommand.java +++ b/src/gr/grnet/pithos/web/client/commands/EmptyTrashCommand.java @@ -34,8 +34,6 @@ */ package gr.grnet.pithos.web.client.commands; -import java.util.Iterator; - import gr.grnet.pithos.web.client.Pithos; import gr.grnet.pithos.web.client.foldertree.File; import gr.grnet.pithos.web.client.foldertree.Folder; @@ -44,6 +42,8 @@ import gr.grnet.pithos.web.client.rest.DeleteRequest; import gr.grnet.pithos.web.client.rest.GetRequest; import gr.grnet.pithos.web.client.rest.RestException; +import java.util.Iterator; + import com.google.gwt.core.client.GWT; import com.google.gwt.core.client.Scheduler; import com.google.gwt.http.client.Response; @@ -117,7 +117,7 @@ public class EmptyTrashCommand implements Command{ DeleteRequest deleteF = new DeleteRequest(app.getApiPath(), _f.getOwner(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource _result) { deleteSubfolder(iter2, callback); } @@ -177,7 +177,7 @@ public class EmptyTrashCommand implements Command{ DeleteRequest deleteF = new DeleteRequest(app.getApiPath(), f.getOwner(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { deleteFile(iter, callback); } diff --git a/src/gr/grnet/pithos/web/client/commands/NewFolderCommand.java b/src/gr/grnet/pithos/web/client/commands/NewFolderCommand.java index af0e3b6..4555b34 100644 --- a/src/gr/grnet/pithos/web/client/commands/NewFolderCommand.java +++ b/src/gr/grnet/pithos/web/client/commands/NewFolderCommand.java @@ -34,7 +34,6 @@ */ package gr.grnet.pithos.web.client.commands; -import gr.grnet.pithos.web.client.FileContextMenu.Images; import gr.grnet.pithos.web.client.FolderPropertiesDialog; import gr.grnet.pithos.web.client.Pithos; import gr.grnet.pithos.web.client.foldertree.Folder; @@ -55,7 +54,6 @@ public class NewFolderCommand implements Command{ /** * @param aContainerPanel - * @param newImages the images of the new folder dialog */ public NewFolderCommand(Pithos _app, PopupPanel aContainerPanel, Folder folder){ app = _app; diff --git a/src/gr/grnet/pithos/web/client/commands/PasteCommand.java b/src/gr/grnet/pithos/web/client/commands/PasteCommand.java index 639050b..998669d 100644 --- a/src/gr/grnet/pithos/web/client/commands/PasteCommand.java +++ b/src/gr/grnet/pithos/web/client/commands/PasteCommand.java @@ -138,7 +138,7 @@ public class PasteCommand implements Command { String path = folder.getUri() + "/" + file.getName(); PutRequest copyFile = new PutRequest(app.getApiPath(), folder.getOwner(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { moveFiles(iter, callback); } diff --git a/src/gr/grnet/pithos/web/client/commands/RemoveUserCommand.java b/src/gr/grnet/pithos/web/client/commands/RemoveUserCommand.java index 3bce1df..cb56f01 100644 --- a/src/gr/grnet/pithos/web/client/commands/RemoveUserCommand.java +++ b/src/gr/grnet/pithos/web/client/commands/RemoveUserCommand.java @@ -78,7 +78,7 @@ public class RemoveUserCommand implements Command { PostRequest updateGroup = new PostRequest(app.getApiPath(), app.getUsername(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { app.updateGroupNode(group); } diff --git a/src/gr/grnet/pithos/web/client/commands/RestoreTrashCommand.java b/src/gr/grnet/pithos/web/client/commands/RestoreTrashCommand.java index 54a994b..b058359 100644 --- a/src/gr/grnet/pithos/web/client/commands/RestoreTrashCommand.java +++ b/src/gr/grnet/pithos/web/client/commands/RestoreTrashCommand.java @@ -113,7 +113,7 @@ public class RestoreTrashCommand implements Command { String path = "/" + Pithos.HOME_CONTAINER + "/" + f.getPrefix(); PutRequest createFolder = new PutRequest(app.getApiPath(), app.getUsername(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { GetRequest getFolder = new GetRequest(Folder.class, app.getApiPath(), f.getOwner(), "/" + f.getContainer() + "?format=json&delimiter=/&prefix=" + URL.encodeQueryString(f.getPrefix()), f) { @Override @@ -130,7 +130,7 @@ public class RestoreTrashCommand implements Command { DeleteRequest deleteFolder = new DeleteRequest(app.getApiPath(), _f.getOwner(), _f.getUri()) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource _result) { + public void onSuccess(Resource _result) { app.updateRootFolder(callback); } @@ -210,7 +210,7 @@ public class RestoreTrashCommand implements Command { String path = "/" + Pithos.HOME_CONTAINER + "/" + file.getPath(); PutRequest untrashFile = new PutRequest(app.getApiPath(), app.getUsername(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { untrashFiles(iter, callback); } diff --git a/src/gr/grnet/pithos/web/client/commands/ToTrashCommand.java b/src/gr/grnet/pithos/web/client/commands/ToTrashCommand.java index b0232d9..61e4f48 100644 --- a/src/gr/grnet/pithos/web/client/commands/ToTrashCommand.java +++ b/src/gr/grnet/pithos/web/client/commands/ToTrashCommand.java @@ -113,7 +113,7 @@ public class ToTrashCommand implements Command{ String path = "/" + Pithos.TRASH_CONTAINER + "/" + f.getPrefix(); PutRequest createFolder = new PutRequest(app.getApiPath(), app.getUsername(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { GetRequest getFolder = new GetRequest(Folder.class, app.getApiPath(), f.getOwner(), "/" + f.getContainer() + "?format=json&delimiter=/&prefix=" + URL.encodeQueryString(f.getPrefix()), f) { @Override @@ -130,7 +130,7 @@ public class ToTrashCommand implements Command{ DeleteRequest deleteFolder = new DeleteRequest(app.getApiPath(), _f.getOwner(), _f.getUri()) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource _result) { + public void onSuccess(Resource _result) { if (callback != null) callback.execute(); } @@ -213,7 +213,7 @@ public class ToTrashCommand implements Command{ String path = "/" + Pithos.TRASH_CONTAINER + "/" + file.getPath(); PutRequest trashFile = new PutRequest(app.getApiPath(), app.getUsername(), path) { @Override - public void onSuccess(@SuppressWarnings("unused") Resource result) { + public void onSuccess(Resource result) { trashFiles(iter, callback); } diff --git a/src/gr/grnet/pithos/web/client/components/TristateCheckBox.java b/src/gr/grnet/pithos/web/client/components/TristateCheckBox.java index 65af3b6..aa72431 100644 --- a/src/gr/grnet/pithos/web/client/components/TristateCheckBox.java +++ b/src/gr/grnet/pithos/web/client/components/TristateCheckBox.java @@ -73,7 +73,7 @@ public class TristateCheckBox extends FocusWidget implements HasValue { addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { final String img = DOM.getElementAttribute(buttonElement, "src"); String newImg; if (img.endsWith(UNCHECKED_IMG)) @@ -138,7 +138,7 @@ public class TristateCheckBox extends FocusWidget implements HasValue { protected void ensureDomEventHandlers() { addClickHandler(new ClickHandler() { @Override - public void onClick(@SuppressWarnings("unused") ClickEvent event) { + public void onClick(ClickEvent event) { ValueChangeEvent.fire(TristateCheckBox.this, getValue()); } }); diff --git a/src/gr/grnet/pithos/web/client/foldertree/File.java b/src/gr/grnet/pithos/web/client/foldertree/File.java index 3859366..ca581f6 100644 --- a/src/gr/grnet/pithos/web/client/foldertree/File.java +++ b/src/gr/grnet/pithos/web/client/foldertree/File.java @@ -37,9 +37,7 @@ package gr.grnet.pithos.web.client.foldertree; import java.util.Date; import java.util.HashMap; -import java.util.HashSet; import java.util.Map; -import java.util.Set; import com.google.gwt.http.client.Header; import com.google.gwt.http.client.Response; diff --git a/src/gr/grnet/pithos/web/client/foldertree/FolderTreeView.java b/src/gr/grnet/pithos/web/client/foldertree/FolderTreeView.java index e7c4eb8..8f05c9a 100644 --- a/src/gr/grnet/pithos/web/client/foldertree/FolderTreeView.java +++ b/src/gr/grnet/pithos/web/client/foldertree/FolderTreeView.java @@ -62,12 +62,10 @@ public class FolderTreeView extends Composite implements TreeView { if (folder.equals(node.getChildValue(i))) { return node.isChildOpen(i); } - else { - if (node.isChildOpen(i)) { - TreeNode n = node.setChildOpen(i, true); - return isFolderOpen(n, folder); - } - } + if (node.isChildOpen(i)) { + TreeNode n = node.setChildOpen(i, true); + return isFolderOpen(n, folder); + } } return false; } @@ -84,13 +82,11 @@ public class FolderTreeView extends Composite implements TreeView { node.setChildOpen(i, true, true); break; } - else { - if (node.isChildOpen(i)) { - TreeNode n = node.setChildOpen(i, true); - openFolder(n, folder); - break; - } - } + if (node.isChildOpen(i)) { + TreeNode n = node.setChildOpen(i, true); + openFolder(n, folder); + break; + } } } diff --git a/src/gr/grnet/pithos/web/client/foldertree/FolderTreeViewModel.java b/src/gr/grnet/pithos/web/client/foldertree/FolderTreeViewModel.java index 0fb166b..19cd69e 100644 --- a/src/gr/grnet/pithos/web/client/foldertree/FolderTreeViewModel.java +++ b/src/gr/grnet/pithos/web/client/foldertree/FolderTreeViewModel.java @@ -41,9 +41,7 @@ import gr.grnet.pithos.web.client.foldertree.FolderTreeView.Templates; import gr.grnet.pithos.web.client.rest.GetRequest; import gr.grnet.pithos.web.client.rest.RestException; -import java.util.ArrayList; import java.util.HashMap; -import java.util.HashSet; import java.util.Iterator; import java.util.Map; @@ -58,10 +56,6 @@ import com.google.gwt.safehtml.shared.SafeHtml; import com.google.gwt.safehtml.shared.SafeHtmlBuilder; import com.google.gwt.user.client.Command; import com.google.gwt.user.client.ui.AbstractImagePrototype; -import com.google.gwt.user.client.ui.HTML; -import com.google.gwt.user.client.ui.UIObject; -import com.google.gwt.view.client.AsyncDataProvider; -import com.google.gwt.view.client.HasData; import com.google.gwt.view.client.ListDataProvider; import com.google.gwt.view.client.SingleSelectionModel; import com.google.gwt.view.client.TreeViewModel; @@ -73,7 +67,7 @@ public class FolderTreeViewModel implements TreeViewModel { private Cell folderCell = new AbstractCell(ContextMenuEvent.getType().getName()) { @Override - public void render(@SuppressWarnings("unused") Context context, Folder folder, SafeHtmlBuilder safeHtmlBuilder) { + public void render(Context context, Folder folder, SafeHtmlBuilder safeHtmlBuilder) { String html; SafeHtml name; if (folder.isHome()) { @@ -93,7 +87,7 @@ public class FolderTreeViewModel implements TreeViewModel { } @Override - public void onBrowserEvent(@SuppressWarnings("unused") Cell.Context context, @SuppressWarnings("unused") com.google.gwt.dom.client.Element parent, Folder folder, com.google.gwt.dom.client.NativeEvent event, @SuppressWarnings("unused") com.google.gwt.cell.client.ValueUpdater valueUpdater) { + public void onBrowserEvent(Cell.Context context, com.google.gwt.dom.client.Element parent, Folder folder, com.google.gwt.dom.client.NativeEvent event, com.google.gwt.cell.client.ValueUpdater valueUpdater) { if (event.getType().equals(ContextMenuEvent.getType().getName())) { FolderTreeViewModel.this.selectionModel.setSelected(folder, true); FolderContextMenu menu = new FolderContextMenu(app, FolderTreeView.images, app.getSelectedTree(), folder); @@ -149,7 +143,7 @@ public class FolderTreeViewModel implements TreeViewModel { String path = "/" + f.getContainer() + "?format=json&delimiter=/&prefix=" + URL.encodeQueryString(f.getPrefix()); GetRequest getFolder = new GetRequest(Folder.class, app.getApiPath(), f.getOwner(), path, f) { @Override - public void onSuccess(@SuppressWarnings("unused") Folder _result) { + public void onSuccess(Folder _result) { fetchFolder(iter, callback); } diff --git a/src/gr/grnet/pithos/web/client/grouptree/GroupTreeViewModel.java b/src/gr/grnet/pithos/web/client/grouptree/GroupTreeViewModel.java index bf70121..8c45bb4 100644 --- a/src/gr/grnet/pithos/web/client/grouptree/GroupTreeViewModel.java +++ b/src/gr/grnet/pithos/web/client/grouptree/GroupTreeViewModel.java @@ -63,14 +63,14 @@ public class GroupTreeViewModel implements TreeViewModel { private Cell rootCell = new AbstractCell(ContextMenuEvent.getType().getName()) { @Override - public void render(@SuppressWarnings("unused") Context context, String value, SafeHtmlBuilder sb) { + public void render(Context context, String value, SafeHtmlBuilder sb) { String html = AbstractImagePrototype.create(GroupTreeView.images.groups()).getHTML(); sb.appendHtmlConstant(html).appendHtmlConstant(" "); sb.append(Templates.INSTANCE.nameSpan(value)); } @Override - public void onBrowserEvent(@SuppressWarnings("unused") Cell.Context context, @SuppressWarnings("unused") com.google.gwt.dom.client.Element parent, String s, com.google.gwt.dom.client.NativeEvent event, @SuppressWarnings("unused") com.google.gwt.cell.client.ValueUpdater valueUpdater) { + public void onBrowserEvent(Cell.Context context, com.google.gwt.dom.client.Element parent, String s, com.google.gwt.dom.client.NativeEvent event, com.google.gwt.cell.client.ValueUpdater valueUpdater) { GroupTreeViewModel.this.rootSelectionModel.setSelected(s, true); if (event.getType().equals(ContextMenuEvent.getType().getName())) { GroupContextMenu menu = new GroupContextMenu(app, GroupTreeView.images, null); @@ -83,14 +83,14 @@ public class GroupTreeViewModel implements TreeViewModel { private Cell groupCell = new AbstractCell(ContextMenuEvent.getType().getName()) { @Override - public void render(@SuppressWarnings("unused") Context context, Group value, SafeHtmlBuilder sb) { + public void render(Context context, Group value, SafeHtmlBuilder sb) { String html = AbstractImagePrototype.create(GroupTreeView.images.group()).getHTML(); sb.appendHtmlConstant(html).appendHtmlConstant(" "); sb.append(Templates.INSTANCE.nameSpan(value.getName())); } @Override - public void onBrowserEvent(@SuppressWarnings("unused") Cell.Context context, @SuppressWarnings("unused") com.google.gwt.dom.client.Element parent, Group group, com.google.gwt.dom.client.NativeEvent event, @SuppressWarnings("unused") com.google.gwt.cell.client.ValueUpdater valueUpdater) { + public void onBrowserEvent(Cell.Context context, com.google.gwt.dom.client.Element parent, Group group, com.google.gwt.dom.client.NativeEvent event, com.google.gwt.cell.client.ValueUpdater valueUpdater) { GroupTreeViewModel.this.groupSelectionModel.setSelected(group, true); if (event.getType().equals(ContextMenuEvent.getType().getName())) { GroupContextMenu menu = new GroupContextMenu(app, GroupTreeView.images, group); @@ -103,14 +103,14 @@ public class GroupTreeViewModel implements TreeViewModel { private Cell userCell = new AbstractCell(ContextMenuEvent.getType().getName()) { @Override - public void render(@SuppressWarnings("unused") Context context, User value, SafeHtmlBuilder sb) { + public void render(Context context, User value, SafeHtmlBuilder sb) { String html = AbstractImagePrototype.create(GroupTreeView.images.user()).getHTML(); sb.appendHtmlConstant(html).appendHtmlConstant(" "); sb.append(Templates.INSTANCE.nameSpan(value.getName())); } @Override - public void onBrowserEvent(@SuppressWarnings("unused") Cell.Context context, @SuppressWarnings("unused") com.google.gwt.dom.client.Element parent, User user, com.google.gwt.dom.client.NativeEvent event, @SuppressWarnings("unused") com.google.gwt.cell.client.ValueUpdater valueUpdater) { + public void onBrowserEvent(Cell.Context context, com.google.gwt.dom.client.Element parent, User user, com.google.gwt.dom.client.NativeEvent event, com.google.gwt.cell.client.ValueUpdater valueUpdater) { GroupTreeViewModel.this.userSelectionModel.setSelected(user, true); if (event.getType().equals(ContextMenuEvent.getType().getName())) { UserContextMenu menu = new UserContextMenu(app, GroupTreeView.images, user); diff --git a/src/gr/grnet/pithos/web/client/mysharedtree/MysharedTreeViewModel.java b/src/gr/grnet/pithos/web/client/mysharedtree/MysharedTreeViewModel.java index 59020c8..8e8c6ac 100644 --- a/src/gr/grnet/pithos/web/client/mysharedtree/MysharedTreeViewModel.java +++ b/src/gr/grnet/pithos/web/client/mysharedtree/MysharedTreeViewModel.java @@ -77,14 +77,14 @@ public class MysharedTreeViewModel implements TreeViewModel { private Cell folderCell = new AbstractCell() { @Override - public void render(@SuppressWarnings("unused") Context context, Folder folder, SafeHtmlBuilder safeHtmlBuilder) { + public void render(Context context, Folder folder, SafeHtmlBuilder safeHtmlBuilder) { String html = AbstractImagePrototype.create(MysharedTreeView.images.folderYellow()).getHTML(); safeHtmlBuilder.appendHtmlConstant(html).appendHtmlConstant(" "); safeHtmlBuilder.append(Templates.INSTANCE.nameSpan(folder.getName())); } @Override - public void onBrowserEvent(@SuppressWarnings("unused") Context context, @SuppressWarnings("unused") com.google.gwt.dom.client.Element parent, Folder folder, com.google.gwt.dom.client.NativeEvent event, @SuppressWarnings("unused") ValueUpdater valueUpdater) { + public void onBrowserEvent(Context context, com.google.gwt.dom.client.Element parent, Folder folder, com.google.gwt.dom.client.NativeEvent event, ValueUpdater valueUpdater) { if (event.getType().equals(ContextMenuEvent.getType().getName())) { MysharedTreeViewModel.this.selectionModel.setSelected(folder, true); FolderContextMenu menu = new FolderContextMenu(app, MysharedTreeView.images, app.getSelectedTree(), folder); @@ -116,7 +116,7 @@ public class MysharedTreeViewModel implements TreeViewModel { selectionModel2.addSelectionChangeHandler(new Handler() { @Override - public void onSelectionChange(@SuppressWarnings("unused") SelectionChangeEvent event) { + public void onSelectionChange(SelectionChangeEvent event) { if (selectionModel2.getSelectedObject() != null) { app.deselectOthers(app.getMySharedTreeView(), selectionModel2); app.applyPermissions(null); diff --git a/src/gr/grnet/pithos/web/client/othersharedtree/OtherSharedTreeViewModel.java b/src/gr/grnet/pithos/web/client/othersharedtree/OtherSharedTreeViewModel.java index 9509b56..77a568f 100644 --- a/src/gr/grnet/pithos/web/client/othersharedtree/OtherSharedTreeViewModel.java +++ b/src/gr/grnet/pithos/web/client/othersharedtree/OtherSharedTreeViewModel.java @@ -79,14 +79,14 @@ public class OtherSharedTreeViewModel implements TreeViewModel { private Cell folderCell = new AbstractCell(ContextMenuEvent.getType().getName()) { @Override - public void render(@SuppressWarnings("unused") Context context, Folder folder, SafeHtmlBuilder safeHtmlBuilder) { + public void render(Context context, Folder folder, SafeHtmlBuilder safeHtmlBuilder) { String html = AbstractImagePrototype.create(OtherSharedTreeView.images.folderYellow()).getHTML(); safeHtmlBuilder.appendHtmlConstant(html).appendHtmlConstant(" "); safeHtmlBuilder.append(Templates.INSTANCE.nameSpan(folder.getName())); } @Override - public void onBrowserEvent(@SuppressWarnings("unused") Context context, @SuppressWarnings("unused") com.google.gwt.dom.client.Element parent, Folder folder, com.google.gwt.dom.client.NativeEvent event, @SuppressWarnings("unused") ValueUpdater valueUpdater) { + public void onBrowserEvent(Context context, com.google.gwt.dom.client.Element parent, Folder folder, com.google.gwt.dom.client.NativeEvent event, ValueUpdater valueUpdater) { if (event.getType().equals(ContextMenuEvent.getType().getName())) { OtherSharedTreeViewModel.this.selectionModel.setSelected(folder, true); FolderContextMenu menu = new FolderContextMenu(app, OtherSharedTreeView.images, app.getSelectedTree(), folder); @@ -119,7 +119,7 @@ public class OtherSharedTreeViewModel implements TreeViewModel { selectionModel2.addSelectionChangeHandler(new Handler() { @Override - public void onSelectionChange(@SuppressWarnings("unused") SelectionChangeEvent event) { + public void onSelectionChange(SelectionChangeEvent event) { if (selectionModel2.getSelectedObject() != null) { app.deselectOthers(app.getOtherSharedTreeView(), selectionModel2); app.applyPermissions(null); @@ -151,7 +151,7 @@ public class OtherSharedTreeViewModel implements TreeViewModel { selectionModel3.addSelectionChangeHandler(new Handler() { @Override - public void onSelectionChange(@SuppressWarnings("unused") SelectionChangeEvent event) { + public void onSelectionChange(SelectionChangeEvent event) { if (selectionModel3.getSelectedObject() != null) { app.deselectOthers(app.getOtherSharedTreeView(), selectionModel3); app.applyPermissions(null); diff --git a/src/gr/grnet/pithos/web/client/rest/DeleteRequest.java b/src/gr/grnet/pithos/web/client/rest/DeleteRequest.java index 168ca5b..c95b581 100644 --- a/src/gr/grnet/pithos/web/client/rest/DeleteRequest.java +++ b/src/gr/grnet/pithos/web/client/rest/DeleteRequest.java @@ -35,16 +35,16 @@ package gr.grnet.pithos.web.client.rest; +import gr.grnet.pithos.web.client.foldertree.Resource; + +import java.util.HashMap; +import java.util.Map; + import com.google.gwt.core.client.Scheduler.ScheduledCommand; import com.google.gwt.http.client.Request; import com.google.gwt.http.client.RequestBuilder; import com.google.gwt.http.client.RequestException; import com.google.gwt.http.client.Response; -import com.google.gwt.http.client.URL; - -import gr.grnet.pithos.web.client.foldertree.Resource; -import java.util.HashMap; -import java.util.Map; /** * Created by IntelliJ IDEA. User: chstath Date: 7/5/11 Time: 5:29 PM To change this template use File | Settings | File @@ -88,7 +88,7 @@ public abstract class DeleteRequest implements ScheduledCommand { } @Override - public void onError(@SuppressWarnings("unused") Request request, Throwable throwable) { + public void onError(Request request, Throwable throwable) { DeleteRequest.this.onError(throwable); } diff --git a/src/gr/grnet/pithos/web/client/rest/GetRequest.java b/src/gr/grnet/pithos/web/client/rest/GetRequest.java index 990d781..e146d59 100644 --- a/src/gr/grnet/pithos/web/client/rest/GetRequest.java +++ b/src/gr/grnet/pithos/web/client/rest/GetRequest.java @@ -46,9 +46,6 @@ import com.google.gwt.http.client.Request; import com.google.gwt.http.client.RequestBuilder; import com.google.gwt.http.client.RequestException; import com.google.gwt.http.client.Response; -import com.google.gwt.http.client.URL; -import com.google.gwt.i18n.client.DateTimeFormat; -import com.google.gwt.i18n.client.DateTimeFormat.PredefinedFormat; public abstract class GetRequest implements ScheduledCommand { @@ -110,7 +107,7 @@ public abstract class GetRequest implements ScheduledCommand } @Override - public void onError(@SuppressWarnings("unused") Request request, Throwable throwable) { + public void onError(Request request, Throwable throwable) { if (throwable instanceof RestException) { if (((RestException) throwable).getHttpStatusCode() == 304 && result != null){ GWT.log("Using cache: " + result.toString(), null); diff --git a/src/gr/grnet/pithos/web/client/rest/HeadRequest.java b/src/gr/grnet/pithos/web/client/rest/HeadRequest.java index 0a04cf7..ddbab44 100644 --- a/src/gr/grnet/pithos/web/client/rest/HeadRequest.java +++ b/src/gr/grnet/pithos/web/client/rest/HeadRequest.java @@ -46,7 +46,6 @@ import com.google.gwt.http.client.Request; import com.google.gwt.http.client.RequestBuilder; import com.google.gwt.http.client.RequestException; import com.google.gwt.http.client.Response; -import com.google.gwt.http.client.URL; public abstract class HeadRequest implements ScheduledCommand { @@ -110,7 +109,7 @@ public abstract class HeadRequest implements ScheduledComman } @Override - public void onError(@SuppressWarnings("unused") Request request, Throwable throwable) { + public void onError(Request request, Throwable throwable) { if (throwable instanceof RestException) { if (((RestException) throwable).getHttpStatusCode() == 304 && cached != null){ GWT.log("Using cache: " + cached.toString(), null); diff --git a/src/gr/grnet/pithos/web/client/rest/PostRequest.java b/src/gr/grnet/pithos/web/client/rest/PostRequest.java index a9b6ae7..6c96f35 100644 --- a/src/gr/grnet/pithos/web/client/rest/PostRequest.java +++ b/src/gr/grnet/pithos/web/client/rest/PostRequest.java @@ -35,17 +35,17 @@ package gr.grnet.pithos.web.client.rest; +import gr.grnet.pithos.web.client.foldertree.Resource; + +import java.util.HashMap; +import java.util.Map; + import com.google.gwt.core.client.GWT; import com.google.gwt.core.client.Scheduler.ScheduledCommand; import com.google.gwt.http.client.Request; import com.google.gwt.http.client.RequestBuilder; import com.google.gwt.http.client.RequestException; import com.google.gwt.http.client.Response; -import com.google.gwt.http.client.URL; - -import gr.grnet.pithos.web.client.foldertree.Resource; -import java.util.HashMap; -import java.util.Map; public abstract class PostRequest implements ScheduledCommand { @@ -95,7 +95,7 @@ public abstract class PostRequest implements ScheduledCommand { } @Override - public void onError(@SuppressWarnings("unused") Request request, Throwable throwable) { + public void onError(Request request, Throwable throwable) { PostRequest.this.onError(throwable); } diff --git a/src/gr/grnet/pithos/web/client/rest/PutRequest.java b/src/gr/grnet/pithos/web/client/rest/PutRequest.java index 79924c5..abae148 100644 --- a/src/gr/grnet/pithos/web/client/rest/PutRequest.java +++ b/src/gr/grnet/pithos/web/client/rest/PutRequest.java @@ -70,16 +70,16 @@ package gr.grnet.pithos.web.client.rest; +import gr.grnet.pithos.web.client.foldertree.Resource; + +import java.util.HashMap; +import java.util.Map; + import com.google.gwt.core.client.Scheduler.ScheduledCommand; import com.google.gwt.http.client.Request; import com.google.gwt.http.client.RequestBuilder; import com.google.gwt.http.client.RequestException; import com.google.gwt.http.client.Response; -import com.google.gwt.http.client.URL; - -import gr.grnet.pithos.web.client.foldertree.Resource; -import java.util.HashMap; -import java.util.Map; public abstract class PutRequest implements ScheduledCommand { @@ -120,7 +120,7 @@ public abstract class PutRequest implements ScheduledCommand { } @Override - public void onError(@SuppressWarnings("unused") Request request, Throwable throwable) { + public void onError(Request request, Throwable throwable) { PutRequest.this.onError(throwable); } diff --git a/src/gr/grnet/pithos/web/client/tagtree/TagTreeViewModel.java b/src/gr/grnet/pithos/web/client/tagtree/TagTreeViewModel.java index ff5778f..03e290c 100644 --- a/src/gr/grnet/pithos/web/client/tagtree/TagTreeViewModel.java +++ b/src/gr/grnet/pithos/web/client/tagtree/TagTreeViewModel.java @@ -68,14 +68,14 @@ public class TagTreeViewModel implements TreeViewModel { private Cell tagCell = new AbstractCell(ContextMenuEvent.getType().getName()) { @Override - public void render(@SuppressWarnings("unused") Context context, Tag tag, SafeHtmlBuilder safeHtmlBuilder) { + public void render(Context context, Tag tag, SafeHtmlBuilder safeHtmlBuilder) { String html = AbstractImagePrototype.create(TagTreeView.images.tag()).getHTML(); safeHtmlBuilder.appendHtmlConstant(html); safeHtmlBuilder.append(Templates.INSTANCE.nameSpan(tag.getName())); } @Override - public void onBrowserEvent(@SuppressWarnings("unused") Context context, @SuppressWarnings("unused") com.google.gwt.dom.client.Element parent, Tag tag, com.google.gwt.dom.client.NativeEvent event, @SuppressWarnings("unused") com.google.gwt.cell.client.ValueUpdater valueUpdater) { + public void onBrowserEvent(Context context, com.google.gwt.dom.client.Element parent, Tag tag, com.google.gwt.dom.client.NativeEvent event, com.google.gwt.cell.client.ValueUpdater valueUpdater) { if (event.getType().equals(com.google.gwt.event.dom.client.ContextMenuEvent.getType().getName())) { TagTreeViewModel.this.selectionModel.setSelected(tag, true); }