From a43ef959d44a31363d531edda3d7094c257659f5 Mon Sep 17 00:00:00 2001 From: Christos KK Loverdos Date: Thu, 18 Jul 2013 16:45:12 +0300 Subject: [PATCH] Remove one constructor of PithosDisclosurePanel ... to make semantics clearer. Refs #4140 --- .../grnet/pithos/web/client/PithosDisclosurePanel.java | 4 ---- .../pithos/web/client/foldertree/FolderTreeView.java | 2 +- .../pithos/web/client/grouptree/GroupTreeView.java | 15 +++++---------- .../web/client/mysharedtree/MysharedTreeView.java | 12 +++++------- 4 files changed, 11 insertions(+), 22 deletions(-) diff --git a/src/gr/grnet/pithos/web/client/PithosDisclosurePanel.java b/src/gr/grnet/pithos/web/client/PithosDisclosurePanel.java index 5ce2f1d..e3294b0 100644 --- a/src/gr/grnet/pithos/web/client/PithosDisclosurePanel.java +++ b/src/gr/grnet/pithos/web/client/PithosDisclosurePanel.java @@ -77,10 +77,6 @@ public class PithosDisclosurePanel extends Composite { private final Resources resources; private final String title; - public PithosDisclosurePanel(final Resources _resources, final String title, boolean open) { - this(_resources, title, false, open); - } - public PithosDisclosurePanel(final Resources _resources, final String title, boolean ajaxLoader, boolean open) { this.title = title; diff --git a/src/gr/grnet/pithos/web/client/foldertree/FolderTreeView.java b/src/gr/grnet/pithos/web/client/foldertree/FolderTreeView.java index f0f63f9..55c40d2 100644 --- a/src/gr/grnet/pithos/web/client/foldertree/FolderTreeView.java +++ b/src/gr/grnet/pithos/web/client/foldertree/FolderTreeView.java @@ -176,7 +176,7 @@ public class FolderTreeView extends Composite implements TreeView { public FolderTreeView(FolderTreeViewModel viewModel) { this.model = viewModel; - PithosDisclosurePanel panel = new PithosDisclosurePanel((Resources) GWT.create(Resources.class), "My Files", true); + PithosDisclosurePanel panel = new PithosDisclosurePanel((Resources) GWT.create(Resources.class), "My Files", false, true); VerticalPanel content = new VerticalPanel(); diff --git a/src/gr/grnet/pithos/web/client/grouptree/GroupTreeView.java b/src/gr/grnet/pithos/web/client/grouptree/GroupTreeView.java index cfcd6e1..c0d8708 100644 --- a/src/gr/grnet/pithos/web/client/grouptree/GroupTreeView.java +++ b/src/gr/grnet/pithos/web/client/grouptree/GroupTreeView.java @@ -35,15 +35,8 @@ package gr.grnet.pithos.web.client.grouptree; -import gr.grnet.pithos.web.client.FolderContextMenu; -import gr.grnet.pithos.web.client.PithosDisclosurePanel; -import gr.grnet.pithos.web.client.TreeView; -import gr.grnet.pithos.web.client.PithosDisclosurePanel.Style; -import gr.grnet.pithos.web.client.foldertree.Folder; - import com.google.gwt.core.client.GWT; import com.google.gwt.resources.client.ImageResource; -import com.google.gwt.resources.client.ClientBundle.Source; import com.google.gwt.resources.client.ImageResource.ImageOptions; import com.google.gwt.resources.client.ImageResource.RepeatStyle; import com.google.gwt.safehtml.client.SafeHtmlTemplates; @@ -52,9 +45,11 @@ import com.google.gwt.user.cellview.client.CellTree; import com.google.gwt.user.cellview.client.HasKeyboardSelectionPolicy.KeyboardSelectionPolicy; import com.google.gwt.user.cellview.client.TreeNode; import com.google.gwt.user.client.ui.Composite; -import com.google.gwt.user.client.ui.DisclosurePanel; -import com.google.gwt.user.client.ui.HTML; import com.google.gwt.user.client.ui.Tree; +import gr.grnet.pithos.web.client.FolderContextMenu; +import gr.grnet.pithos.web.client.PithosDisclosurePanel; +import gr.grnet.pithos.web.client.TreeView; +import gr.grnet.pithos.web.client.foldertree.Folder; public class GroupTreeView extends Composite implements TreeView { @@ -152,7 +147,7 @@ public class GroupTreeView extends Composite implements TreeView { public GroupTreeView(GroupTreeViewModel viewModel) { this.model = viewModel; - PithosDisclosurePanel panel = new PithosDisclosurePanel((Resources) GWT.create(Resources.class), "Groups", false); + PithosDisclosurePanel panel = new PithosDisclosurePanel((Resources) GWT.create(Resources.class), "Groups", false, false); /* * Create the tree using the model. We use null as the default * value of the root node. The default value will be passed to diff --git a/src/gr/grnet/pithos/web/client/mysharedtree/MysharedTreeView.java b/src/gr/grnet/pithos/web/client/mysharedtree/MysharedTreeView.java index 14cb63e..9c7da6f 100644 --- a/src/gr/grnet/pithos/web/client/mysharedtree/MysharedTreeView.java +++ b/src/gr/grnet/pithos/web/client/mysharedtree/MysharedTreeView.java @@ -35,14 +35,8 @@ package gr.grnet.pithos.web.client.mysharedtree; -import gr.grnet.pithos.web.client.FolderContextMenu; -import gr.grnet.pithos.web.client.PithosDisclosurePanel; -import gr.grnet.pithos.web.client.TreeView; -import gr.grnet.pithos.web.client.foldertree.Folder; - import com.google.gwt.core.client.GWT; import com.google.gwt.resources.client.ImageResource; -import com.google.gwt.resources.client.ClientBundle.Source; import com.google.gwt.resources.client.ImageResource.ImageOptions; import com.google.gwt.resources.client.ImageResource.RepeatStyle; import com.google.gwt.safehtml.client.SafeHtmlTemplates; @@ -53,6 +47,10 @@ import com.google.gwt.user.cellview.client.TreeNode; import com.google.gwt.user.client.Command; import com.google.gwt.user.client.ui.Composite; import com.google.gwt.user.client.ui.Tree; +import gr.grnet.pithos.web.client.FolderContextMenu; +import gr.grnet.pithos.web.client.PithosDisclosurePanel; +import gr.grnet.pithos.web.client.TreeView; +import gr.grnet.pithos.web.client.foldertree.Folder; public class MysharedTreeView extends Composite implements TreeView { @@ -158,7 +156,7 @@ public class MysharedTreeView extends Composite implements TreeView { public MysharedTreeView(MysharedTreeViewModel viewModel) { this.model = viewModel; - panel = new PithosDisclosurePanel((Resources) GWT.create(Resources.class), "Shared by me", false); + panel = new PithosDisclosurePanel((Resources) GWT.create(Resources.class), "Shared by me", false, false); createTree(); initWidget(panel); -- 1.7.10.4