From c1638c183f0dd9d98634238127edbd037c850889 Mon Sep 17 00:00:00 2001 From: Christos Stathis Date: Mon, 30 Apr 2012 15:10:04 +0300 Subject: [PATCH] Added validation to permissions form (issue #2349) --- src/gr/grnet/pithos/web/client/PermissionsAddDialog.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gr/grnet/pithos/web/client/PermissionsAddDialog.java b/src/gr/grnet/pithos/web/client/PermissionsAddDialog.java index 5c733ba..3a27989 100644 --- a/src/gr/grnet/pithos/web/client/PermissionsAddDialog.java +++ b/src/gr/grnet/pithos/web/client/PermissionsAddDialog.java @@ -140,13 +140,17 @@ public class PermissionsAddDialog extends DialogBox { String selected = null; if (userAdd) { selected = userBox.getText(); - } else { + } else if (groupBox.getSelectedIndex() > -1) { String groupName = groupBox.getValue(groupBox.getSelectedIndex()); - selected = app.getUsername() + ":" + groupName; + selected = app.getUsername() + ":" + groupName; } if (permList.getPermissions().get(selected) != null) { return; } + if (selected == null || selected.length() == 0 || selected.equals(app.getUsername() + ":")) { + app.displayError("You have to select o username or group"); + return; + } boolean readValue = read.getValue(); boolean writeValue = write.getValue(); -- 1.7.10.4