Windows OSs."""
from image_creator.os_type import OSBase, sysprep, add_sysprep_param
-from image_creator.util import FatalError, check_guestfs_version, \
- get_kvm_binary
+from image_creator.util import FatalError, get_kvm_binary
from image_creator.winexe import WinEXE, WinexeTimeout
import hivex
def __init__(self, image, **kargs):
super(Windows, self).__init__(image, **kargs)
+ # The commit with the following message was added in
+ # libguestfs 1.17.18 and was backported in version 1.16.11:
+ #
+ # When a Windows guest doesn't have a HKLM\SYSTEM\MountedDevices node,
+ # inspection fails. However inspection should not completely fail just
+ # because we cannot get the drive letter mapping from a guest.
+ #
+ # Since Microsoft Sysprep removes the aforementioned key, image
+ # creation for windows can only be supported if the installed guestfs
+ # version is 1.17.18 or higher
+ if self.image.check_guestfs_version(1, 17, 18) < 0 and \
+ (self.image.check_guestfs_version(1, 17, 0) >= 0 or
+ self.image.check_guestfs_version(1, 16, 11) < 0):
+ raise FatalError(
+ 'For windows support libguestfs 1.16.11 or above is required')
+
device = self.image.g.part_to_dev(self.root)
self.last_part_num = self.image.g.part_list(device)[-1]['part_num']
self.last_drive = None
self.system_drive = None
- for drive, partition in self.image.g.inspect_get_drive_mappings(self.root):
- if partition == "%s%d" % (device, self.last_part_num):
+ for drive, part in self.image.g.inspect_get_drive_mappings(self.root):
+ if part == "%s%d" % (device, self.last_part_num):
self.last_drive = drive
- if partition == self.root:
+ if part == self.root:
self.system_drive = drive
assert self.system_drive
"""Install the appropriate KMS client setup key to the image to convert
it to a KMS client. Computers that are running volume licensing
editions of Windows 8, Windows Server 2012, Windows 7, Windows Server
- 2008 R2, Windows Vista, and Windows Server 2008 are, by default, KMS
+ 2008 R2, Windows Vista, and Windows Server 2008 are by default KMS
clients with no additional configuration needed.
"""
try:
r'IF NOT !ERRORLEVEL! EQU 0 EXIT /B 1 & ' +
r'DEL /Q %SCRIPT%"')
- stdout, stderr, rc = self._guest_exec(cmd)
+ stdout, stderr, rc = self._guest_exec(cmd, False)
+ if rc != 0:
+ FatalError("Shrinking failed. Please make sure the media is "
+ "defraged with a command like this: "
+ "`Defrag.exe /U /X /W'")
for line in stdout.splitlines():
if line.find('shrunk') >= 0:
self.out.output(line)
txt = "System preparation parameter: `%s' is needed but missing!"
for name, param in self.needed_sysprep_params.items():
if name not in self.sysprep_params:
- raise FatalError(txt % param)
+ raise FatalError(txt % name)
self.mount(readonly=False)
try:
finally:
self.umount()
- self.out.output("Shutting down helper VM ...", False)
- self.image.g.sync()
- # guestfs_shutdown which is the prefered way to shutdown the backend
- # process was introduced in version 1.19.16
- if check_guestfs_version(self.g, 1, 19, 16) >= 0:
- self.image.g.shutdown()
- else:
- self.image.g.kill_subprocess()
-
- self.out.success('done')
+ self.image.disable_guestfs()
vm = None
monitor = None
vm.destroy()
self.out.success("done")
finally:
- self.out.output("Relaunching helper VM (may take a while) ...",
- False)
- self.image.g.launch()
- self.out.success('done')
+ self.image.enable_guestfs()
self.mount(readonly=False)
try:
# Use ganeti's VNC port range for a random vnc port
self.display = random.randint(11000, 14999) - 5900
- kvm = get_kvm_binary()
+ kvm, needed_args = get_kvm_binary()
if kvm is None:
FatalError("Can't find the kvm binary")
- args = [
- kvm, '-smp', '1', '-m', '1024', '-drive',
+ args = [kvm]
+ args.extend(needed_args)
+
+ args.extend([
+ '-smp', '1', '-m', '1024', '-drive',
'file=%s,format=raw,cache=unsafe,if=virtio' % self.disk,
'-netdev', 'type=user,hostfwd=tcp::445-:445,id=netdev0',
'-device', 'virtio-net-pci,mac=%s,netdev=netdev0' % random_mac(),
'-vnc', ':%d' % self.display, '-serial', 'file:%s' % self.serial,
- '-monitor', 'stdio']
+ '-monitor', 'stdio'])
self.process = subprocess.Popen(args, stdin=subprocess.PIPE,
stdout=subprocess.PIPE)