Check if remote files exist before uploading
[snf-image-creator] / image_creator / main.py
index 497fedf..99a35e3 100644 (file)
@@ -38,7 +38,6 @@ from image_creator.disk import Disk
 from image_creator.util import FatalError, MD5
 from image_creator.output.cli import SilentOutput, SimpleOutput, \
     OutputWthProgress
-from image_creator.os_type import os_cls
 from image_creator.kamaki_wrapper import Kamaki, ClientError
 import sys
 import os
@@ -182,8 +181,8 @@ def image_creator():
         for extension in ('', '.meta', '.md5sum'):
             filename = "%s%s" % (options.outfile, extension)
             if os.path.exists(filename):
-                raise FatalError("Output file %s exists "
-                                 "(use --force to overwrite it)" % filename)
+                raise FatalError("Output file `%s' exists "
+                                 "(use --force to overwrite it)." % filename)
 
     # Check if the authentication token is valid. The earlier the better
     if options.token is not None:
@@ -192,9 +191,24 @@ def image_creator():
             if account is None:
                 raise FatalError("The authentication token you provided is not"
                                  " valid!")
+            else:
+                kamaki = Kamaki(account, out)
         except ClientError as e:
             raise FatalError("Astakos client: %d %s" % (e.status, e.message))
 
+    if options.upload and not options.force:
+        if kamaki.object_exists(options.upload):
+            raise FatalError("Remote pithos object `%s' exists "
+                             "(use --force to overwrite it)." % options.upload)
+        if kamaki.object_exists("%s.md5sum" % options.upload):
+            raise FatalError("Remote pithos object `%s.md5sum' exists "
+                             "(use --force to overwrite it)." % options.upload)
+
+    if options.register and not options.force:
+        if kamaki.object_exists("%s.meta" % options.upload):
+            raise FatalError("Remote pithos object `%s.meta' exists "
+                             "(use --force to overwrite it)." % options.upload)
+
     disk = Disk(options.source, out, options.tmp)
 
     def signal_handler(signum, frame):
@@ -205,51 +219,54 @@ def image_creator():
     try:
         snapshot = disk.snapshot()
 
-        dev = disk.get_device(snapshot)
+        image = disk.get_image(snapshot)
 
-        # If no customization is to be applied, the image should be mounted ro
-        readonly = (not (options.sysprep or options.shrink) or
-                    options.print_sysprep)
-        dev.mount(readonly)
-
-        cls = os_cls(dev.distro, dev.ostype)
-        image_os = cls(dev.root, dev.g, out)
-        out.output()
-
-        for sysprep in options.disabled_syspreps:
-            image_os.disable_sysprep(image_os.get_sysprep_by_name(sysprep))
+        # If no customization is to be done, the image should be mounted ro
+        ro = (not (options.sysprep or options.shrink) or options.print_sysprep)
+        image.mount(ro)
+        try:
+            for sysprep in options.disabled_syspreps:
+                image.os.disable_sysprep(image.os.get_sysprep_by_name(sysprep))
 
-        for sysprep in options.enabled_syspreps:
-            image_os.enable_sysprep(image_os.get_sysprep_by_name(sysprep))
+            for sysprep in options.enabled_syspreps:
+                image.os.enable_sysprep(image.os.get_sysprep_by_name(sysprep))
 
-        if options.print_sysprep:
-            image_os.print_syspreps()
-            out.output()
+            if options.print_sysprep:
+                image.os.print_syspreps()
+                out.output()
 
-        if options.outfile is None and not options.upload:
-            return 0
+            if options.outfile is None and not options.upload:
+                return 0
 
-        if options.sysprep:
-            image_os.do_sysprep()
+            if options.sysprep:
+                err_msg = "Unable to perform the system preparation tasks. " \
+                    "Couldn't mount the media%s. Use --no-sysprep if you " \
+                    "don't won't to perform any system preparation task."
+                if not image.mounted:
+                    raise FatalError(err_msg % "")
+                elif image.mounted_ro:
+                    raise FatalError(err_msg % " read-write")
+                image.os.do_sysprep()
 
-        metadata = image_os.meta
-        dev.umount()
+            metadata = image.os.meta
+        finally:
+            image.umount()
 
-        size = options.shrink and dev.shrink() or dev.size
-        metadata.update(dev.meta)
+        size = options.shrink and image.shrink() or image.size
+        metadata.update(image.meta)
 
         # Add command line metadata to the collected ones...
         metadata.update(options.metadata)
 
         md5 = MD5(out)
-        checksum = md5.compute(snapshot, size)
+        checksum = md5.compute(image.device, size)
 
         metastring = '\n'.join(
             ['%s=%s' % (key, value) for (key, value) in metadata.items()])
         metastring += '\n'
 
         if options.outfile is not None:
-            dev.dump(options.outfile)
+            image.dump(options.outfile)
 
             out.output('Dumping metadata file ...', False)
             with open('%s.%s' % (options.outfile, 'meta'), 'w') as f:
@@ -262,27 +279,20 @@ def image_creator():
                                      os.path.basename(options.outfile)))
             out.success('done')
 
-        # Destroy the device. We only need the snapshot from now on
-        disk.destroy_device(dev)
+        # Destroy the image instance. We only need the snapshot from now on
+        disk.destroy_image(image)
 
         out.output()
         try:
             uploaded_obj = ""
             if options.upload:
                 out.output("Uploading image to pithos:")
-                kamaki = Kamaki(account, out)
                 with open(snapshot, 'rb') as f:
                     uploaded_obj = kamaki.upload(
                         f, size, options.upload,
-                        "(1/4)  Calculating block hashes",
-                        "(2/4)  Uploading missing blocks")
-
-                out.output("(3/4)  Uploading metadata file ...", False)
-                kamaki.upload(StringIO.StringIO(metastring),
-                              size=len(metastring),
-                              remote_path="%s.%s" % (options.upload, 'meta'))
-                out.success('done')
-                out.output("(4/4)  Uploading md5sum file ...", False)
+                        "(1/3)  Calculating block hashes",
+                        "(2/3)  Uploading missing blocks")
+                out.output("(3/3)  Uploading md5sum file ...", False)
                 md5sumstr = '%s %s\n' % (checksum,
                                          os.path.basename(options.upload))
                 kamaki.upload(StringIO.StringIO(md5sumstr),
@@ -298,6 +308,11 @@ def image_creator():
                 kamaki.register(options.register, uploaded_obj, metadata,
                                 options.public)
                 out.success('done')
+                out.output("Uploading metadata file ...", False)
+                kamaki.upload(StringIO.StringIO(metastring),
+                              size=len(metastring),
+                              remote_path="%s.%s" % (options.upload, 'meta'))
+                out.success('done')
                 out.output()
         except ClientError as e:
             raise FatalError("Pithos client: %d %s" % (e.status, e.message))