Bug #2096

Do not use dates to decide what to do about common files

Added by Panagiotis Kanavos almost 9 years ago. Updated over 8 years ago.

Status:Closed Start date:02/23/2012
Priority:Medium Due date:
Assignee:Panagiotis Kanavos % Done:


Category:Core Spent time: -
Target version:PreAlpha


We do not need to check dates when a server change is detected for a file that already exists on the client.
We know that there is a remote change and have to decide whether we need to download it or mark a conflict.

We can compare the local tophash with the current and previous server tophash.
  • If the previous tophash matches the local tophash, the file was only changed on the server.
  • If the file tophash does NOT match the previous tophash, there was a local changed that has not been propagated to the server. We have a conflict.

There should be no problems for the first poll, when we have no previous server tophash to compare. During the first poll, all differences are marked as conflict.

Associated revisions

Revision f8c471f7
Added by Panagiotis Kanavos almost 9 years ago

Removed old code that used MD5 for small files
Closes 2096


#1 Updated by Panagiotis Kanavos almost 9 years ago

  • Status changed from New to Resolved

#2 Updated by Panagiotis Kanavos over 8 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF