Feature #3575
Refactor the view of the Sharing procedure
Status: | Closed | Start date: | 04/10/2013 | |
---|---|---|---|---|
Priority: | High | Due date: | ||
Assignee: | Christos KK Loverdos | % Done: | 100% |
|
Category: | - | Spent time: | - | |
Target version: | - |
Description
Currently, when right clicking on a File one has two options wrt sharing:
1. Publish
2. Sharing
With "Publish" Pithos creates a public link for the file. Then anybody who has this link can access the file without signing-in. Public files do NOT appear under Pithos users' "Shared with me" section.
With "Sharing" one can add a list of users or groups and grant them access to the file. Then this file will appear under the "Shared with me" section of all the users that share it. Furthermore, a link will be created for this file. To access the file using this link, one must sign-in and already have the file as shared.
The functionality will stay the same, but we will change how it is presented to the user for simplicity and uniformity:
When right clicking on a File one has only one option:
1. Share
Clicking "Share" opens an overlay with two sections each section clearly separated and with a checkbox:
1.1 [checkbox] Private sharing (Subtitle: "Only people explicitly granted permission can access. Sign-in required.")
1.2 [checkbox] Public on the Internet (Subtitle: "Anyone who has the public link can access. No sign-in required.")
Checking on the first (1.1) the section expands and we have the menu currently on the old "Sharing" overlay.
Furthermore, we need a "Add everybody" button that will add all Pithos users to the list.
Also we need the notice over the list of users: All users in the list will find the shared file under "Shared with me"
Checking on the second (1.2) the section expands and produces the public link (the menu currently on the old "Publish" overlay).
Related issues
Associated revisions
Rename constructor params
Refs #3575
Update permission table after adding user/group
Refs #3575
Change wording: Sharing -> Share in the folder context menu
Refs #3575
In Share Dialog, remove the header line when the permission list is empty.
Refs #3575
New button "Add everybody" to file Share dialog
Refs #3575
In File/Share, disable "Add Group" if user has no groups
Also set the button title to "You do not have any groups".
Refs #3575
Fix the disabled "Add group" button style
Previously some annoying button movement was taking place on mouse hover.
Refs #3575
Visually separate "Private" & "Public" sharing in File/Share
Refs #3575
Revert "Fix the disabled "Add group" button style"
This reverts commit 5e2c128046985d9adb0459040b9b82931235e422.
Due to a regression with the Group/Delete dialog (it had bad/no styling)
Refs #3575
Visually separate "Private" & "Public" sharing in File/Share
More lightweight than the previous approach.
Refs #3575
In File/Share do not show "Add group" if user has no groups
Refs #3575
Better headers in permissions dialog
If it is about user permissions, show "Add user" and "User".
If it is about group permissions, show "Add group" and "Group".
Refs #3575
Bring Folder/Share dialog onpar with File/Share dialog
Refs #3575
In File/Share dialog show "Public/Private Link" instead of just "Link"
Refs #3575
Provide RightClick/CopyToClipboard functionality for "Public/Private Link" in File/Share dialog
It does not work. I think there is no standard way to do it.
Which browser versions do we support anyway?
I am committing the work, since it has been done but the intention
is to revert it immediately
Refs #3575
Revert "Provide RightClick/CopyToClipboard functionality for "Public/Private Link" in File/Share dialog"
This reverts commit ddbf705922a5abb92c92205ebc98cc97fbd89aeb.
I explained the reason in the commit message of the above commit
Refs #3575
Fix a typo in File/Share/Add Group dialog
The column header for groups should be "Group" not "User"
Refs #3575
Merge branch 'issue_3575' into develop
Refs #3575
History
#1 Updated by Christos KK Loverdos almost 8 years ago
- Status changed from New to Assigned
- % Done changed from 0 to 70
Check dev84. Implemented in File->Share for now. Will also do it for Folder->Share.
#2 Updated by Christos KK Loverdos almost 8 years ago
- Status changed from Assigned to Feedback
- Assignee changed from Christos KK Loverdos to Constantinos Venetsanopoulos
I see that currently, there is no "Publish" functionality for Folders. So, I am leaving it as it is.
The unified Public/Private Sharing dialog is for Files only.
#3 Updated by Constantinos Venetsanopoulos almost 8 years ago
- Status changed from Feedback to Assigned
- Assignee changed from Constantinos Venetsanopoulos to Christos KK Loverdos
OK, we are leaving Folders as is without "Publish" for now.
One comment: Remove the headers line: "Users/Groups Read Only Read/Write" when the list is empty.
Also separate the two top level options with a horizontal line or something to keep thigns clear.
#4 Updated by Christos KK Loverdos almost 8 years ago
- % Done changed from 70 to 80
#5 Updated by Christos KK Loverdos almost 8 years ago
- % Done changed from 80 to 90
#6 Updated by Christos KK Loverdos over 7 years ago
- Status changed from Assigned to Closed
- % Done changed from 90 to 100