Synnefo » snf-ganeti » Ganeti ExtStorage providers

- Fix _is_vdisk_defined (see FIXME comment there)

- Code duplication (subprocess wrappers, anything else?)

- Config file opts 'parsing' (too complex? )

- Consistent use of datatypes (int for VOL_SIZE, port, host_id, string

  for everything else). Related to the above.

- Make consistent use of exceptions / consistent error handling

- What are the semantics of the verify op?

- Refactoring:

    *) _get_params / _read_config are not 'consistent' (set attrs and

       return some opts for SVC connection)

    *) make the interface more clear (how do we init the provider,

       SVC connection, how to we issue the ops, do we need oop /

       classes

- Check code taken from the original cinder driver (driver_assert,

  paramiko code, svc cmds)

- Verify multipath / dmsetup / scsi rescan cmds work as intended

  (and that they work ok with udev, when certain rules are disabled)

- Lots of rtts to the SVC for no reason (is_vdisk_defined, get_attrs

  etc). Maybe have a separate volume class (overkill) or private attrs

  for volume specific stuff?

- Unittests probably need rewriting from scratch

- We currently rely on rescan-scsi-bus etc for scanning. Check which

  package provides it (probably scsi-tools). Fallback to manual

  scanning (via sysfs files) if not available?

- Fix vdisk attribute getting (wrapper fun to return SVCError on key

  error / malformed vdiks attrs