Activity

From 07/26/2008 to 08/24/2008

08/19/2008

03:17 pm Revision 0043d734: Add vim modeline to qa-sample.json
Vim doesn't recognize the format automatically.
Reviewed-by: ultrotter
Michael Hanselmann

08/18/2008

03:51 pm Revision 35705d8f: Parallelize LUQueryNodes
As for LUQueryInstances the first version just acquires a shared lock on all
nodes. In the future further optimizatio...
Guido Trotter
03:51 pm Revision 7eb9d8f7: Parallelize LUQueryInstances
This first version acquires a shared lock on all requested instances and
their nodes. In the future it can be improve...
Guido Trotter
03:51 pm Revision d4f6a91c: A few more locking unit tests
A few more tests written while bug-hunting. One of them shows a real
issue, at last. :)
Reviewed-by: imsnah
Guido Trotter
03:50 pm Revision 90c942d1: Add lock-all-through-GLM unit test
I was hunting for a bug in my code and thought the culprit was in the
locking library, so I added a test to check. Un...
Guido Trotter
03:50 pm Revision 34ca3914: LockSet: allow lists with duplicate values
If a list with a duplicate value is passed to a lockset what the code
now does is to try to acquire the lock twice, g...
Guido Trotter
03:49 pm Revision 8a2941c4: Processor: lock all levels even if one is missing
If a locking level wasn't specified locking used to stop. This means
that if one, for example, didn't specify anythin...
Guido Trotter
03:44 pm Revision 0fcc5db3: LURebootInstance: move arg check in ExpandNames
The check for the reboot type can be done without any locks held, so
we'll move it to ExpandNames. Plus, we note in a...
Guido Trotter
02:37 pm Revision 8c4a9a74: QA: Convert configuration from YAML to JSON
We no longer use YAML in Ganeti at all. This patch converts the QA
configuration from YAML to JSON. JSON doesn't supp...
Michael Hanselmann
02:37 pm Revision 34290825: LUVerifyCluster: Return boolean indication success
Reviewed-by: schreiberal Michael Hanselmann
02:12 pm Revision 9894ece7: Use Linux-specific way to name master socket
By using this Linux-specific way we don't have to care about removing the
socket file when quitting or starting (afte...
Michael Hanselmann
01:51 pm Revision fc28c086: QA: Try to run more scripts with --version
This patch also sorts the list.
Reviewed-by: schreiberal
Michael Hanselmann
01:17 pm Revision 28a90aff: QA: Always accept added node's SSH key
Reviewed-by: ultrotter Michael Hanselmann
12:59 pm Revision a39ec11a: QA: Do not upload known_hosts file anymore
The cluster no longer keeps individual host's SSH key, but rather
aliases all of them to the cluster name.
Reviewed-...
Michael Hanselmann
12:58 pm Revision eaef8a05: Copy qa_utils.AssertIn from 1.2 branch
Apparently it was forgotten when import the remote API QA tests.
Reviewed-by: schreiberal
Michael Hanselmann

08/15/2008

11:55 am Revision c4b6c29c: gnt-node: Add option to always accept peer's SSH key
This option will be used to add nodes to the cluster without
asking the user to confirm the key. Together with key ba...
Michael Hanselmann
11:47 am Revision 652d6694: SshRunner: Add parameter to always accept peer's SSH key
This will be used to add nodes without user interaction, specifically
in QA tests.
Reviewed-by: ultrotter
Michael Hanselmann
11:44 am Revision f6d9f4c3: Move SSH option building into a function
I'm going to add another option and it would make maintaining
them in constants even more complicated.
Reviewed-by: ...
Michael Hanselmann
11:44 am Revision 54ab6aec: SshRunner.Run: Pass all arguments to BuildCmd
This patch changes SshRunner.Run to pass all arguments to
SshRunner.BuildCmd. They had the same arguments before
and ...
Michael Hanselmann
11:43 am Revision c85d3b64: Whitespace fixes for remote API QA checks
Reviewed-by: ultrotter Michael Hanselmann
11:43 am Revision ed54b47e: Remove QA hook functionality
To my knowledge they're used nowhere and it's at least slightly
confusing to people adding new QA checks.
Reviewed-b...
Michael Hanselmann

08/14/2008

01:27 pm Revision 4f0afaf5: Pass hypervisor type to the OS scripts
It's handy to make the os scripts know which hypervisor the instance is
going to run under. In order not to change th...
Guido Trotter
01:26 pm Revision 2557ff82: RunCmd: add optional environment overriding
If the user passes an env dict to RunCmd we'll override the environment
passed to the to-be-executed command with the...
Guido Trotter

08/13/2008

07:41 pm Revision d47d3d38: KVM Hypervisor Cleanup
- Remove a few experiemental code lines left as comments
- Rework first disks' boot=on addition, which was calculated...
Guido Trotter
05:25 pm Revision 7a151789: Allow kvm hypervisor in gnt-cluster init
Reviewed-by: imsnah Guido Trotter
05:25 pm Revision eb58f9b1: Add KVM hypervisor code
ht_kvm.py contains the code for ganeti to work under kvm.
This patch also modifies Makefile.am to ship that file, and...
Guido Trotter
05:25 pm Revision 550e49b9: constants: add HT_KVM
Add a new hypervisor type, HT_KVM, to constants, and register it in the
HYPER_TYPES set.
Reviewed-by: imsnah
Guido Trotter
05:24 pm Revision 7e2c5b9e: Add --with-kvm-path configure option
This allows to configure a different path to the kvm binary. By default
/usr/bin/kvm is used, which is the one found ...
Guido Trotter
05:24 pm Revision a5f723a2: FakeHypervisor: fix a function signature
StartInstance takes 'block_devices', not 'force' as its third argument.
Even if this is not used in the fake hypervis...
Guido Trotter
05:23 pm Revision e326d4e5: Convert RunCmd to an epydoc docstring
Reviewed-by: imsnah Guido Trotter
03:55 pm Revision 51144e33: Fix adding pristine nodes
If a node hasn't been part of the cluster before being added it'll not
have the cluster's SSH key. This patch makes s...
Michael Hanselmann

08/12/2008

08:00 pm Revision f56377a3: Fix race locking issue in noded
Noded didn't release the job queue lock after initialising it. This
patch makes sure to unlock once the work is done....
Michael Hanselmann

08/11/2008

07:28 pm Revision 853e7f3d: cli: Use new RPC call instead of polling
This means commands will not take at least one second anymore.
Reviewed-by: ultrotter
Michael Hanselmann
07:27 pm Revision dfe57c22: Add RPC call to wait for job changes
This way clients can react faster to status or message changes and
don't have to poll anymore.
Reviewed-by: ultrotter
Michael Hanselmann
07:27 pm Revision d5e317ba: jqueue: Change log message time format
See the comment in the patch.
Reviewed-by: ultrotter
Michael Hanselmann
07:26 pm Revision 739be818: Add functions to split time into tuple and merge it back
These will be used for job logs.
Reviewed-by: ultrotter
Michael Hanselmann

08/08/2008

02:29 pm Revision 8bb66978: Use new query function for exports in gnt-backup
Reviewed-by: iustinp Michael Hanselmann
02:29 pm Revision 32f93223: Add query function for exports
Reviewed-by: iustinp Michael Hanselmann
02:23 pm Revision 24fc781f: Don't always remove queue lock when queue is purged
The lock should only be removed if ganeti-noded is going to quit.
Otherwise it needs to be kept to prevent another pr...
Michael Hanselmann
02:22 pm Revision 76ab5558: backend: Add optional exclusion list to _CleanDirectory
The code cleaning the queue will make use of it.
Reviewed-by: iustinp
Michael Hanselmann
02:21 pm Revision abc1f2ce: jqueue: Move archived jobs on all nodes
Otherwise one might have archived jobs back in the list after a master
failover.
Reviewed-by: iustinp
Michael Hanselmann
02:21 pm Revision af5ebcb1: noded: Add RPC function to rename job queue files
This will be used to archive jobs.
Reviewed-by: iustinp
Michael Hanselmann
02:21 pm Revision dc31eae3: backend: Add function to check whether file is in queue dir
Another function will need to check whether its parameters
are job queue files.
Reviewed-by: iustinp
Michael Hanselmann
02:20 pm Revision 7f30777b: noded: Add decorator for job queue lock
The lock will also be needed by another function.
Reviewed-by: iustinp
Michael Hanselmann
02:19 pm Revision 0a7bed64: Two small style fixes
Reviewed-by: iustinp Michael Hanselmann
01:03 pm Revision 25d6d12a: Implement queue locking in node daemon
Reviewed-by: iustinp Michael Hanselmann
01:03 pm Revision 5d6fb8eb: jstore: Change to not always require a lock
This way we can do locking when both noded and masterd are running
on the same machine, the latter holding an exclusi...
Michael Hanselmann
01:02 pm Revision aa9075c5: More logging for errors during noded RPC calls
Reviewed-by: iustinp Michael Hanselmann
01:02 pm Revision aa65ed72: Log only unexpected errors in utils.FileLock
Otherwise users might be confused by errors in log files.
Reviewed-by: iustinp
Michael Hanselmann
01:02 pm Revision 553f1c1d: Disallow uploading job queue files through upload_file
The job queue is now updated through its own RPC functions.
Reviewed-by: iustinp
Michael Hanselmann
01:01 pm Revision 9f774ee8: jqueue: Use new job queue RPC functions
Reviewed-by: iustinp Michael Hanselmann
01:01 pm Revision ca52cdeb: Add job queue RPC functions
jobqueue_update: Uploads a job queue file's content to a node. The
most common operation is to upload something that ...
Michael Hanselmann
01:00 pm Revision 3956cee1: Move function cleaning directory to module level
JobQueuePurge() will be used by an RPC function.
Reviewed-by: iustinp
Michael Hanselmann

08/07/2008

04:03 pm Revision e125c67c: Use API instead of command line utilities in watcher
Reviewed-by: iustinp Michael Hanselmann
12:07 pm Revision 281606c1: Fix cli.PollJob
feedback_fn wasn't passed to it.
Reviewed-by: iustinp
Michael Hanselmann

08/06/2008

05:56 pm Revision c36176cc: Notify job queue about added/removed nodes
The job queue maintains its own node list and must be notified
when nodes are added/removed.
Reviewed-by: iustinp
Michael Hanselmann
05:56 pm Revision d8470559: Implement {Add,Readd,Remove}Node in GanetiContext
By doing this we've a central place which coordinates what needs to be
done when adding or removing nodes. Another pa...
Michael Hanselmann
04:36 pm Revision d2e03a33: jqueue: Implement {Add,Remove}Node
These functions will be used to notify the queue about newly added
or removed nodes.
Reviewed-by: iustinp
Michael Hanselmann
04:35 pm Revision 4c848b18: jqueue: Don't pass the list of nodes to SubmitJob anymore
The job queue now maintains its own list and is updated when
nodes are added or removed from the cluster.
Reviewed-b...
Michael Hanselmann
04:35 pm Revision 8e00939c: Maintain node list in job queue
The code makes sure not to include the master in the list.
Reviewed-by: iustinp
Michael Hanselmann
04:35 pm Revision 9113300d: masterd: Move job queue into context object
The job queue must be called from cmdlib when adding or removing
nodes to the cluster. Moving it to the context objec...
Michael Hanselmann
02:27 pm Revision f78346f5: Clean job queue directories when leaving cluster
Old job files shouldn't be left on nodes removed from a cluster.
Reviewed-by: iustinp
Michael Hanselmann
11:28 am Revision c54784d9: Use new RPC call in “gnt-node list”
Reviewed-by: iustinp Michael Hanselmann
11:26 am Revision 02f7fe54: Implement query for nodes
Reviewed-by: iustinp Michael Hanselmann
11:25 am Revision 1f05af2b: Use new query RPC call in “gnt-instance list”
Reviewed-by: iustinp Michael Hanselmann
11:25 am Revision ee6c7b94: Implement query for instances
Queries don't create jobs and are more efficient. Log messages
are not yet stored anywhere.
Reviewed-by: iustinp
Michael Hanselmann

08/05/2008

01:33 pm Revision 23752136: jqueue: Replicate jobs to all nodes
Newly added nodes are not yet taken care of. Queue locking on
non-master nodes is not yet correct.
Reviewed-by: iustinp
Michael Hanselmann

08/04/2008

03:27 pm Revision 04ab05ce: jqueue: Use new jstore module
Reviewed-by: iustinp Michael Hanselmann
03:27 pm Revision 8b537bb0: jstore: Add queue helper functions
This will be used to move common code out of jqueue.
Reviewed-by: iustinp
Michael Hanselmann
12:47 pm Revision 94428652: Implement job submission for scripts
This patch adds the infrastructure for executing a job in background,
instead of foreground, via a new “--submit” opt...
Iustin Pop
12:14 pm Revision 17dc2da0: Another typo in the install doc
Reviewed-by: imsnah Iustin Pop
12:14 pm Revision e7d2d69b: Update the module build section of install doc
Reviewed-by: imsnah Iustin Pop

07/31/2008

06:03 pm Revision db37da70: jqueue: Move assert into decorator
This reduces code duplication. A later patch will modify the job queue
a bit more and will need a change of this asse...
Michael Hanselmann
05:52 pm Revision 0a1e74d9: Split cli.SubmitOpCode in two parts
The current SubmitOpCode function is not flexible enough to be used for
submitters that don't want to wait for the jo...
Iustin Pop
05:42 pm Revision afee8008: Allow job queue files to be uploaded through ganeti-noded
This is needed for job queue replication.
Reviewed-by: iustinp
Michael Hanselmann
05:33 pm Revision a87b4824: Add FileLock utility class
This class is a wrapper around fcntl.flock and abstracts opening and
closing the lockfile. It'll used for the job que...
Michael Hanselmann
05:33 pm Revision 5bdce580: jqueue: Store context in job queue instead of worker pool
The job queue will need to access to configuration, which is provided
through the context object, to get a list of no...
Michael Hanselmann
03:58 pm Revision 15fd9fd5: RAPI Implement DELETE for tags
Reviewed-by: imsnah Oleksiy Mishchenko
12:06 pm Revision 441e7cfd: First write operation (add tag) for Ganeti RAPI
Add instance tag handling, improved error logging.
...oh, yes adopt instance listing for RAPI2!
Reviewed-by: iustinp
Oleksiy Mishchenko

07/30/2008

06:58 pm Revision 140aa4a8: Fix cluster destroy
With the recent startup/shutdown changes (and with the master daemon in
place), the cluster destroy needs some fixing...
Iustin Pop
06:49 pm Revision 97efde45: Xen: remove two end-of-line semicolons
It's python, isn't it?
Reviewed-by: iustinp
Guido Trotter
06:17 pm Revision b3f1cf6f: Fix cluster init
With the recent changes, I forgot the extra parameter to this rpc call.
Also the rpc call needs to be done after we s...
Iustin Pop
06:06 pm Revision b33e986b: Make gnt-* commands fail nicely on non-masters
This patch adds a check that we are on the master after failing to
connect to the socket, and log nicely the master n...
Iustin Pop
06:04 pm Revision c9e5c064: Parallelize LUFailoverInstance
Reviewed-by: iustinp Guido Trotter
06:04 pm Revision 64381ad7: ChainOpCode is still BGL-only
Prevent mistakes with an assert.
Reviewed-by: iustinp
Guido Trotter
06:00 pm Revision 8161a646: Fix a misuse of exc_info in logging.info
This is my fault, sorry.
Reviewed-by: imsnah
Iustin Pop
05:04 pm Revision 38206f3c: Fix pylint-detected issues
This is mostly:
- whitespace fix (space at EOL in some files, not all, broken
indentation, etc)
- variable na...
Iustin Pop
04:27 pm Revision 3b9e6a30: Fix some errors detected by pylint
Reviewed-by: imsnah Iustin Pop
03:32 pm Revision 59f187eb: Unify SetupDaemon/SetupLogging
The 'old-style' info, error, debug logs do not make much sense. This
patch unifies the SetupLogging and SetupDaemon f...
Iustin Pop
03:29 pm Revision 9936bd63: Simplify the log constants and add another one
The patch changes the log constants by moving the slash to the end of
the log dir instead of at the beginning of *eac...
Iustin Pop
03:27 pm Revision ce7151ae: Fix gnt-cluster getmaster
This is special in the sense that it can run on any node. As such, we
just instantiate ssconf and read the data from ...
Iustin Pop
02:31 pm Revision e873317a: Parallelize {Startup,Shutdown,Reboot}Instance
Reviewed-by: iustinp Guido Trotter
02:30 pm Revision 4e0b4d2d: Parallelize LUReinstallInstance
self.recalculate_locks[locking.LEVEL_NODE] could have any value and
everything would work anyway. We'll use the strin...
Guido Trotter
02:30 pm Revision c4a2fee1: LogicalUnit._LockInstancesNodes helper function
This function is used to lock instances' primary and secondary nodes
after locking instances themselves.
Reviewed-by...
Guido Trotter
02:30 pm Revision 3977a4c1: Make sharing locks possible
LUs can declare which locks they need by populating the
self.needed_locks dictionary, but those locks are always acqu...
Guido Trotter
02:29 pm Revision fb8dcb62: Add LogicalUnit.DeclareLocks
This additional LogicalUnit function is optional to implement, but lets
you change your locking needs for one level j...
Guido Trotter
02:29 pm Revision 74b5913f: LURenameInstance, add/remove relevant locks
LURenameInstance forgot to remove the old lock name and add the new one,
making it impossible for parallel LUs to act...
Guido Trotter
01:02 pm Revision 85f03e0d: Rewrite job queue
We found several issues in the old job queue implementation. It had race
conditions, deadlocks and other deficiencies...
Michael Hanselmann
11:56 am Revision c0a8eb9e: workerpool: Log when waiting for a thread
Reviewed-by: iustinp Michael Hanselmann
11:43 am Revision b1b6ea87: Rework master startup/shutdown/failover
This (big) patch reworks the master startup/shutdown and the fixes the
master failover.
What does the patch do?
For...
Iustin Pop
11:34 am Revision 53beffbb: Expose utils.DaemonPidFileName
Since we need to compute this from outside utils.py, we change this to a
public function.
Reviewed-by: ultrotter
Iustin Pop
11:33 am Revision 5675cd1f: Implement checking for the master role in rapi
This patch moves the CheckMaster function from ganeti-masterd to ssconf
(most logical place, it cannot go in utils si...
Iustin Pop
11:32 am Revision 1c65840b: Add a new parameter to backend.(Start|Stop)Master
This patch adds a new, unused for now, parameter to the start and stop
master operations in backend. The idea behind ...
Iustin Pop

07/29/2008

05:07 pm Revision 6aff91f6: Log thread name when debug output is enabled
Reviewed-by: iustinp Michael Hanselmann
05:07 pm Revision 8090e19f: jqueue: Fix error logging
The passed parameters were not correct.
Reviewed-by: iustinp, ultrotter
Michael Hanselmann
01:42 pm Revision bff2ddc5: Fix constants typo
Reviewed-by: imsnah Iustin Pop
12:06 pm Revision 99e88451: Use constants for the pid file stems
Reviewed-by: imsnah Iustin Pop
11:49 am Revision b2a1f511: Add a KillProcess function
We cannot depend on all environments to have a start-stop-daemon or
similar tool. We instead implement a KillProcess ...
Iustin Pop
11:49 am Revision d9f311d7: Change IsPidFileAlive into ReadPidFile
We already have a function to test if a PID is alive, so it makes more
sense to use function composition that force c...
Iustin Pop
11:48 am Revision f71245a0: Make the rapi daemon create a pidfile
This is needed for controlling it cleanly with start-stop daemon.
Reviewed-by: ultrotter
Iustin Pop

07/28/2008

01:35 pm Revision 6760471c: Fix unittests for ganeti-rapi
The RESTHTTPServer module went the way of the dodo.
Reviewed-by: iustinp
Michael Hanselmann
01:17 pm Revision cfe3c70f: Implement signal handling in ganeti-rapi
Reviewed-by: iustinp Michael Hanselmann
01:17 pm Revision 3cd62121: Move ganeti-rapi core code to daemon
All other daemons have their main code in themselves and not in a module.
This patch does the same to ganeti-rapi by ...
Michael Hanselmann
01:16 pm Revision e2ae9123: Replace httperror module with ganeti.http
The generic HTTP server doesn't know about httperror based exceptions
and would treat them as unknown exceptions, the...
Michael Hanselmann
01:13 pm Revision d2b92ffc: Implement “gnt-job cancel”
Reviewed-by: ultrotter Michael Hanselmann
01:13 pm Revision 188c5e0a: Implement job canceling on server side
Locking is not completeley right due to a deadlock when the job calls
UpdateJob after changing its status.
Reviewed-...
Michael Hanselmann
12:16 pm Revision 533bb4b1: Fix exception class name in utils.WritePidFile
Reviewed-by: iustinp Michael Hanselmann
12:16 pm Revision 4cb1d919: Add “canceled” status for opcodes
Reviewed-by: ultrotter Michael Hanselmann
12:16 pm Revision 17621a25: Make “gnt-debug delay” work again
The old API is no longer working.
Reviewed-by: ultrotter
Michael Hanselmann
« Previous
Next »
 

Also available in: Atom