Activity
From 10/12/2008 to 11/10/2008
11/10/2008
- 02:38 pm Revision b14f759e: ganeti.http: Move SSL socket creation into base class
- The same code will be used by the HTTP client.
Reviewed-by: iustinp - 02:37 pm Revision b14b975f: ganeti.daemon: Make Mainloop more flexible
- While working on the HTTP client class, I wanted to use Mainloop
before deciding to use threads instead.
- Add docst... - 12:14 pm Revision d7bace1b: ganeti.http: Add constant for "Unexpected EOF"
- This is an expected error message and will be used in two places.
Reviewed-by: iustinp
11/07/2008
- 01:32 pm Revision 00dd8326: Fix gnt-cluster init without cluster parameters
- Reviewed-by: imsnah
11/06/2008
- 01:25 pm Revision 8a0b06d2: Add new HTTP client class
- It is based on the WorkerPool class which is already used for the job
queue and master daemon. Each request must be e... - 01:24 pm Revision 64357ed8: ganeti.http: Use 411 Length Required in server code
- Reviewed-by: iustinp
11/05/2008
- 06:37 pm Revision cd4d138f: Update LUGrowDisk _WaitForSync call
- The _WaitForSync call changed in r1794 but the GrowDisk call wasn't updated
then. This makes GrowDisk work in trunk.
... - 04:04 pm Revision 8a9f9060: ganeti.http: Add more constants
- As a preparation for the new HTTP client class, add more constants
to ganeti.http.
Reviewed-by: iustinp
10/28/2008
- 01:21 am Revision 116db7c7: Small documentation updates for workerpool.py
- Reviewed-by: imsnah
- 01:21 am Revision ea03467c: Documentation updates for jqueue.py
- Reviewed-by: imsnah
- 01:20 am Revision 63712a09: Yet another bug found while reviewing docs
- The newer_than variable can be either None or an int, and we normalize
it to an integer previously and save it in the... - 01:20 am Revision 58885d79: Documentation updates for utils.py
- Reviewed-by: imsnah
- 01:20 am Revision 6099bfcf: Documentation updates for gnt-debug and gnt-os
- Reviewed-by: imsnah
- 01:19 am Revision 917b4e56: Documentation updates for gnt-job
- Reviewed-by: imsnah
- 01:19 am Revision 48de3413: Documentation updates for gnt-backup
- Reviewed-by: imsnah
- 01:19 am Revision d70b3058: Change exit code of gnt-backup list
- Currently gnt-backup list exits with the same error code even if can't
contact som nodes for backup information.
The... - 01:18 am Revision ebf366ee: Documentation updates for gnt-node
- The patch also adds a 'return 0' to a function that was missing it.
Reviewed-by: imsnah - 01:18 am Revision 469ee405: Documentation updates for gnt-cluster
- Reviewed-by: imsnah
- 01:18 am Revision 7232c04c: Documentation updates for gnt-instance
- Reviewed-by: imsnah
10/25/2008
- 03:37 am Revision 10c2650b: Update backend.py docstrings
- This patch converts all of backend.py to epydoc formatting.
Reviewed-by: imsnah - 03:37 am Revision 3f5bd234: Fix another error handling case
- The return from this error path is a dict, but the actual return value
(on the non-error handling) is a list of dicts...
10/24/2008
- 07:14 pm Revision 0a70a72a: Fix an error handling case
- Found while reviewing documentation.
Reviewed-by: ultrotter - 06:23 pm Revision 2e3d1946: OSFromDisk remove superfluous empty line
- Reviewed-by: iustinp
- 06:23 pm Revision ef79eb82: design-2.0-os-interface: update import/export
- In the end we ended up taking a slightly different approach for
import/export than the one discussed in the design do... - 05:44 pm Revision b1206984: Some documentation updates
- This fixes a few doc issues and converts a few docstrings to epydoc.
Reviewed-by: imsnah - 05:43 pm Revision 36117c2b: Modify utils.RunCmd to write output to file
- Currently we launch processes via the shell in a few places only to
redirect standard output and error to a log file ... - 02:49 pm Revision f2a6fc9e: ganeti.http: Implement SSL certificates
- Reviewed-by: killerfoxi
- 02:31 pm Revision 23e46494: Document HttpServer.__init__
- At the same time, simplify the interface a bit by not using a tuple.
Reviewed-by: killerfoxi, ultrotter
10/23/2008
- 07:41 pm Revision 18fb5e1d: Update gnt-cluster man page, sections modify and queue.
- Document the new options for gnt-cluster modify and the new queue
command.
Reviewed-by: imsnah - 06:13 pm Revision 19ae0895: Update gnt-cluster man page with current options.
- This patch updates the gnt-cluster man page to reflect the current
changes to gnt-cluster.
Reviewed-by: imsnah - 06:01 pm Revision 1f9611b1: Fix use of ToStderr in gnt-cluster
- Reviewed-by: imsnah
- 05:19 pm Revision d8353c3a: Fix gnt-* command with --submit
- Currently we don't catch the JobSubmittedException (although the code to
format it nicely is there). The patch adds t... - 05:19 pm Revision 74c47259: Export the disk index in the import/export scripts
- We want to export the disk index as some OSes will only want to export
the first disk (or the second one, etc.), even... - 05:18 pm Revision 64272529: Fix leftover of hypervisor attribute rename
- Reviewed-by: imsnah
- 02:58 pm Revision 66348f29: convert remaining print statements to ToStderr in gnt-cluster
- Reviewed-by: imsnah
- 02:58 pm Revision 6526ddcd: http library: Always fork before reading request
- It turned out that clients not sending a full request will stop
us from responding to further requests. This patch le... - 02:58 pm Revision 54cf6599: daemon.py: Don't wake up every second
- We don't have timers yet, hence waking up is not needed at all.
Reviewed-by: ultrotter - 01:41 am Revision 1a05d855: RAPI: Export beparams as dict. The patch also enables LUQueryInstances to acce...
- Reviewed-by: iustinp
10/22/2008
- 11:54 pm Revision 212fa3a7: RAPI: Forgoten in r1923 instance add change.
- Reviewed-by: iustinp
- 05:09 pm Revision 09acf207: LUCreateInstance: import multiple disks
- Previously we used to handle only one disk. Now we'll import all the
ones present in the export, in order, on the ins... - 05:09 pm Revision 6c0af70e: Convert ImportOSIntoInstance to OS API 10
- - Change ImportOSIntoInstance not to get any "os_disk" and "swap_disk"
arguments but to accept multiple target imag... - 05:09 pm Revision 0607699d: Convert ExportSnapshot to OS API 10
- We pass the data via the environment rather than on the command line, as
API 10 says. All the rest remains the same, ... - 05:08 pm Revision 19d7f90a: LUExportInstance: snapshot all disks
- Rather than just snapshotting the "sda" disk, we'll snapshot all of the
instance disks. If we can't snapshot a disk f... - 05:08 pm Revision e9e9263d: Convert SnapshotBlockDevice's docstring to epydoc
- Reviewed-by: iustinp
10/21/2008
- 11:32 pm Revision 7a8f64da: Pass request headers in to RAPI handlers.
- Reviewed-by: iustinp
- 08:54 pm Revision 86d9d3bb: Move some LU logging to use proc.Log*
- We change some messages which are obviously intended for the user to use
the proc.Log* functions instead of (only) th... - 06:45 pm Revision c0088fb9: Improve the mcpu.Processor logging routines
- As discussed previously, many of the routinges in cmdlib.py are using
logging functions as a carry-over from 1.2 (whe... - 04:02 pm Revision 16653425: Fix whitespace-at-EOL
- Please configure your editors to strip it, or enable your git hooks...
Reviewed-by: ultrotter
10/20/2008
- 09:01 pm Revision 149a5439: Generalize the reading of test file data
- Currently we have two methods in ganeti.bdev_unittest.py of computing
the test data file name - and, of course, they ... - 07:38 pm Revision 02691904: Set default hypervisor at cluster init
- During cluster init, set the default hypervisor to be used for instances.
Ensure that the default hypervisor belongs ... - 05:47 pm Revision 99aabbed: Convert the job queue rpcs to address-based
- The two main multi-node job queue RPC calls (jobqueue_update,
jobqueue_rename) are converted to address-based calls, ... - 05:47 pm Revision 6b294c53: Convert rpc.call_upload_file to use addresses
- This patch allows rpc.call_upload_file to use addresses (if passed), and
also converts the ConfigWriter._DistributeCo... - 05:47 pm Revision 25348212: Convert non-static rpc calls to use addresses
- This patch converts all non-staticmethods rpc calls to pass addresses to
the Client calls.
This is done via two new ... - 05:46 pm Revision bdf7d8c0: Add infrastructure for using addresses in rpc.py
- The patch adds support for passing node addresses to NodeController
objects, which should speed up the connect sequen... - 05:46 pm Revision 3ef3c771: Improve conformance with the style guide for rpc.py
- This patch renames some internal function to camel case, for compliance
with the style guide.
It also fixes the modu... - 04:44 pm Revision 6fde8221: Use constants.VALUE_AUTO for ip comparison too
- Forward-port-of: r1889, Reviewed-by: imsnah
Reviewed-by: imsnah - 04:44 pm Revision 8cd7cb4c: Document mac option for gnt-backup import
- Forward-port-of: (r1888, r1891), Reviewed-by: (iustinp, imsnah)
Reviewed-by: imsnah - 04:44 pm Revision bc89efc3: LUCreateInstance: reuse mac address on import
- When importing an instance with the same name as the exported one if the
mac address is "auto" we try to reuse the pr... - 04:44 pm Revision c78995f0: LUCreateInstance: accept mac = VALUE_GENERATE
- VALUE_GENERATE is handled exactly the same as VALUE_AUTO and the mac
address is generated randomly.
Forward-port-of:... - 04:43 pm Revision 3c8886a9: Add mac option to gnt-backup import
- Before 'auto' was the only allowed possibility
Forward-port-of: r1885, Reviewed-by: iustinp
Reviewed-by: imsnah - 04:43 pm Revision 4c566ede: Add VALUE_AUTO and VALUE_GENERATE constants
- 'auto' is used in multiple place in the code with a meaning similar to
'default', 'generate' will be used to force ge... - 03:50 pm Revision 82d9caef: Remove the logger.py module
- Since now we use only one function from the logger module
(SetupLogging), we move it to utils.py (which is already im... - 03:50 pm Revision 263ab7cf: Convert http.py to use the logging module
- Reviewed-by: imsnah
- 03:50 pm Revision 9a4f63d1: Convert cmdlib.py to use the logging module
- Note that many uses of logger.Error were used in 1.2 for their
side-effect of logging to stderr, where the user will ... - 03:50 pm Revision b48909c8: Convert hv_xen.py to use the logging module
- Reviewed-by: imsnah
- 03:50 pm Revision a5eb7789: Convert mcpu.py to use the logging module
- Reviewed-by: imsnah
- 03:50 pm Revision 23828f1c: Convert ssh.py to use the logging module
- Reviewed-by: imsnah
- 03:49 pm Revision 58b311ca: Convert rpc.py to use the logging module
- Reviewed-by: imsnah
- 03:33 pm Revision 2f79bd34: Fix some pylint-detected issues on the scripts
- Some names were wrong, and similar stuff detected by pylint.
gnt-debug.GenericOpCode is still broken.
Reviewed-by: i... - 03:33 pm Revision 3a24c527: Convert the gnt scripts to ToStdout/err
- Currently the gnt-* scripts are using a mix of print, logger.ToStd* and
sys.stderr.write. We convert them all to usin... - 03:33 pm Revision 46fbdd04: Convert cli.py to logging
- We also add two function for printing messages, so that scripts won't
have to import logger to get these. They are a ... - 03:16 pm Revision 61be6ba4: Fix gnt-instance modify with beparams
- The gnt-instance modify didn't work correctly w.r.t the be parameters.
There was also a typo in the corresponding LU.... - 02:09 pm Revision dcd7cbaf: Update gnt-cluster man page for removal of --hypervisor-type.
- We no longer use a single, cluster-wide hypervisor, but configure the
actual to be used hypervisor on the instance le... - 02:04 pm Revision fa10bdc5: Remove old HTTP server code
- All users of this code have been migrated to the new and shiny HttpServer
class.
It also fixes a typo in the ApacheL... - 01:47 pm Revision 4342e89b: Remove --hypervisor-type from gnt-cluster.
- We no longer use a single, cluster-wide hypervisor, but configure the
actual to be used hypervisor on the instance le...
10/19/2008
- 01:27 am Revision ea3a925f: Fix gnt-cluster init to set cluster defaults.
- Reviewed-by: iustinp
- 01:26 am Revision 7888a614: Add constants for cluster defaults
- Reviewed-by: iustinp
10/17/2008
- 05:37 pm Revision d15a9ad3: Cleanup os_add/rename rpc for OS API 10
- - remove now unused osdev and swapdev arguments from backend, noded,
rpc, cmdlib
- convert docstrings to epydoc
Re... - 05:36 pm Revision d324e3fc: Temporarily explicitely break import/export
- Since they're not converted to API 10 yet, we temporarily disable the
import/export functions.
Reviewed-by: iustinp - 05:36 pm Revision 58f6e5ca: AddOSToInstance: convert to api10
- Reviewed-by: iustinp
- 05:36 pm Revision ff38b6c0: RunRenameInstance: convert to api10
- Reviewed-by: iustinp
- 05:36 pm Revision 2266edb2: Add new OSEnvironment function
- This function calculates the basic environment for OS scripts in API
version 10.
Reviewed-by: iustinp - 05:35 pm Revision 4dd69592: Bump up the OS API version
- Reviewed-by: iustinp
- 05:35 pm Revision 62dbbe7e: OSFromDisk: use script names from constants
- Reviewed-by: iustinp
- 05:35 pm Revision 8ee4dc80: Change OSFromDisk's docstring to epydoc
- Plus update it with the real variable name
Reviewed-by: iustinp - 05:35 pm Revision 464736ae: Add LDS_BLOCK for block device backed dev types
- Reviewed-by: iustinp
- 05:35 pm Revision ded1c679: Create constants to replace os scripts names
- Reviewed-by: iustinp
- 04:06 pm Revision 713faea6: ETag passing support.
- Reviewed-by: imsnah
- 02:08 pm Revision a570e2a8: Mainloop: handle sigterm
- This fixes removals of the pid files and clean exit in the init script
Reviewed-by: iustinp - 02:07 pm Revision 07fc5289: Mainloop: init sigchld_handler as None
- There is no point in initializing sigchld_handler as an empty dict, when
it will be overwritten by an instance of uti... - 12:47 pm Revision 5d8d232c: Fix remote API unittest
- I broke it with rev 1864. This patch also removes whitespace at
line endings.
Reviewed-by: amishchenko
10/16/2008
- 11:39 pm Revision 779c15bb: Enable gnt-cluster modify to hv/beparams
- This patch enables the cluster modify to change:
- enabled hypervisor list
- hvparams (per hypervisor)
- bepara... - 07:54 pm Revision 16a8967d: rapi: Convert to new HTTP server class
- Requests are no longer logged to a separate file.
Reviewed-by: amishchenko - 07:38 pm Revision c5e2d3b9: design-2.0-cluster-parameters: escape final _
- In rst a final _ is used for linking. Escaping it prevents an error at
compile time on design-2.0-cluster-parameters.... - 07:26 pm Revision 469f88e1: Show the cluster parametrs in gnt-cluster info
- This is just a raw update without any special formatting.
Reviewed-by: imsnah - 05:40 pm Revision 2f7635f4: RAPI: Instance add/delete implementation.
- Reviewed-by: iustinp
- 04:35 pm Revision 29fc6636: OS Design: invert new and old name
- Internally in ganeti we already have renamed the instance, so it's
better to pass the new name in INSTANCE_NAME and t... - 04:05 pm Revision 09352fa4: Really fix with the zombie test (hopefully)
- So, instead of any timeouts for synchronization, we move to actual
events. We still have one (huge) timeout for patho... - 03:08 pm Revision 94ed59a5: Fix job queue behaviour when loading jobs
- Currently, if loading a job fails, the job queue code raises an
exception and prevents the proper processing of the j... - 02:36 pm Revision d5927e48: Prevent master failover if we have wrong data
- If we don't actually know the current master (as determined via voting),
we prevent the failover.
The patch also cha... - 02:36 pm Revision d7cdb55d: Improvements to the master startup checks
- In order to account for future improvements to master failover, we move
the actual data gathering capabilities from g... - 11:37 am Revision 10799c59: Provide example for backend parameters
- Update the design about cluster parameters and provide
some example of backend parameters. By now this includes
all s... - 11:37 am Revision 3ccafd0e: Add an interface for the drain flag changes/query
- This adds the set/reset in the jqueue and luxi modules, and a way to
query it in OpQueryConfigValues, and also the co...
10/15/2008
- 04:38 pm Revision 0d0e9090: Adding batch-create to gnt-instance
- This change is part of the integration of tools/batcher from
Ganeti 1.2 into Ganeti 2.0 core code. It has a compatibl... - 04:13 pm Revision 5d672980: Add a rpc call for changing the drain flag
- A new multi-node call is added that sets/resets the drain flag.
Reviewed-by: imsnah - 01:52 pm Revision 686d7433: Implement the job queue drain flag
- We add a (per-node) queue drain flag that blocks new job submission.
There is not yet an interface to add/remove the ... - 01:51 pm Revision 6797ec29: Implement transport of ganeti errors across luxi
- This patch adds a generic method to identify the ganeti error given its
class name, and implements this across the lu... - 01:51 pm Revision d11bda8d: Change the JobQueueError parent class
- Currently this is not derived from GenericError, but there's no reason
for it to be so.
Reviewed-by: imsnah - 01:13 pm Revision 966405b7: rapi: Don't throw class as an exception
- Reviewed-by: ultrotter
- 11:22 am Revision a2f92677: rapi: Whitespace fixes
- Reviewed-by: ultrotter
10/14/2008
- 07:34 pm Revision b03efa30: gnt-backup: update for cluster parameters
- - add backend and hypervisor parameters
- fix beparams validation/passing
- pass hypervisor and hvparams
- remove dep... - 07:33 pm Revision 7399cd55: gnt-instance fix ValidateBeParams call
- ValidateBeParams does not return, but its return value is assigned to a
variable which is never used. Avoid this assi... - 07:33 pm Revision 7ac1fc45: gnt-instance remove deprecated flags
- kernel, initrd, hvm_boot_order and vnc_bind_address are now hypervisor
parameters and should not have their own flag.... - 07:23 pm Revision 6605411d: grow-disk: wait until resync is completed
- The patch adds a new ‘--no-wait-for-sync’ parameter to grow-disk similar
to the one in instance add, and changes the ... - 07:22 pm Revision 659712c8: Burnin OpGrowDisk
- With this patch both the os and the swap disk are grown during
burnin. You can pass an increase size of 0 to skip thi... - 05:47 pm Revision 6b5605e8: Convert the KVM hypervisor to hvparams
- I'm not sure which parameters it should use, I took all I saw in the
code. Update: ultrotter says the list is OK for ... - 05:42 pm Revision c0f2b229: Some fixes related to auto_balance
- Change the constant name to match the value (autobalance ->
auto_balance).
Also add the auto_balance header so that ... - 05:42 pm Revision 647a5d80: Fix auto_balance and memory modification
- The secondary nodes should not be checked for free memory in case of non
auto-balanced instances.
This is a forward-... - 05:42 pm Revision 3924700f: Use the auto_balance in cluster verify
- This patch changes the cluster verify in two ways:
- do not use instances marked with auto_balance=False in N+1 mem... - 05:42 pm Revision c1f1cbb2: Fix ordering of instance/nodes
- After the locking changes, and the partial locking of nodes, the
instance/node list is not ordered anymore. Reorder s... - 02:30 pm Revision bf766476: Remove old instance attributes
- Reviewed-by: ultrotter
- 02:29 pm Revision 338e51e8: Change over to beparams
- This big patch changes the master code to use the beparams. Errors might
have crept in, but it passes a small burnin.... - 02:29 pm Revision 51de46bf: Change the backend to use the beparams
- The backend.FinalizeExport function is changed to use the beparams
instead of the instance attributes. Future enhance... - 02:29 pm Revision 8b3fd458: Change hypervisors to use the beparams
- This patch changes the hypervisor functions to use the beparams dict
instead of the instance attributes.
Reviewed-by... - 02:29 pm Revision 5b442704: Correctly fill the beparams too over RPC
- As for the hvparams, we need to replace the sent instance beparams.
Reviewed-by: ultrotter - 02:29 pm Revision a604f165: Add cli function for beparams validation
- This is used to validate the parameters in both “gnt-instance add” and
“gnt-backup import”.
Reviewed-by: ultrotter - 02:29 pm Revision cd3ab26e: Modify the beparams constants
- Memory is renamed for easier use.
Reviewed-by: ultrotter - 01:21 pm Revision 8705eb96: Fix a bug with instance creation and hvparameters
- When creating an instance, we need to check not the opcode hvparams, but
the final, filled hvparams against validity.... - 01:21 pm Revision 57821cac: Allow instance info to only query the config file
- This patch adds a new '-s' parameter to ‘gnt-instance info’ that makes
it return only 'static' information. This is m... - 01:21 pm Revision 24838135: Convert gnt-instance info to the hvparams model
- Some informations are not printed nicely (e.g. “virtual CDROM: False”),
but this is the first step.
Reviewed-by: imsnah - 01:20 pm Revision 74409b12: Change gnt-instance modify to the hvparams model
- Reviewed-by: imsnah
- 01:20 pm Revision 5018a335: Change gnt-instance list to the hvparams model
- This is just a change of the various hvm_ and pvm parameters to the hv
model. Parameters are queried via hv/$name or ... - 01:20 pm Revision 6785674e: Switch instance hypervisor parameters to hvparams
- This big patch changes instance create to the new hvparams structure.
Old parameters are removed, so old jobs or old ... - 01:20 pm Revision f23b5ae8: Temporary fix for dual hvm/pvm instances
- We have a problem with the current model of combining instance lists
from multiple hypervisors: we don't allow duplic... - 01:20 pm Revision 26ba2bd8: Implement FillHV for instance-related rpc calls
- We fill the instance hvparams with cluster defaults, and send a modified
dict over the wire to the node methods - the... - 01:19 pm Revision 6217e295: Export the hypervisor.ValidateParameters over RPC
- The newly-added node-specific ValidateParams hypervisor method is
exported over RPC, using the semi-standard (success... - 01:19 pm Revision f48148c3: Implement the new hypervisor API in base/xen
- This patch adds the new methods CheckParameterSyntax and the
ValidateParameters in the base and xen hypervisors. It a... - 11:24 am Revision 937e4814: Get rid of httperror module
- This was a leftover from the early days of the remote API in Ganeti 1.2.
Reviewed-by: ultrotter - 09:38 am Revision fcd62d84: Implement parameter removal in SplitKeyVal
- This patch adds paramter removal in SplitKeyVal, by prefixing a
value-less key with "-"; this is needed in resetting ... - 09:36 am Revision 5bf7b5cf: Add the hv/be params object attributes
- This patch adds the instance and cluster be/hvparams attributes, and the
Fill* methods on the cluster object. Nothing... - 09:36 am Revision e64b8beb: Add constants for the HV/BE parameter names
- Since we don't want the string values of the parameters (e.g.
“kernel_path”) spread over the code, we introduce const...
10/13/2008
- 04:49 pm Revision 16ad1a83: Fix a few rpc-related errors
- This fixes:
- whitespace change, double lines between methods
- duplication of call_upload_file, introduced by mi... - 03:17 pm Revision a8469393: Add two new options types for CLI usage
- For the new 2.0-style command line options, we need to parse strings of
the type:
ident:key=val[,...]
and
key=val... - 03:15 pm Revision 2d8ed1fe: Some small typos on design docs
- Reviewed-by: imsnah
- 12:19 pm Revision ca8ac26a: Update the cluster parameters design doc
- As discussed, we update the design doc with the three classes of
parameters and other changes.
Reviewed-by: imsnah
10/12/2008
- 11:40 pm Revision caad16e2: Abstract checking own address into a function
- Currently, we check if we have a given ip address (i.e. it's alive on
one of our interfaces) but manually calling Tcp...
Also available in: Atom