Activity
From 03/31/2011 to 04/29/2011
04/29/2011
- 05:15 pm Revision 52f33103: cmdlib: Factorize lock releasing
- There will be more lock releasing with upcoming changes, so this will
centralize the logic behind it (what locks to k... - 04:01 pm Revision 3de8301d: Merge branch 'devel-2.4'
- * devel-2.4:
TLReplaceDisks: Use implicit loop for dictionary
Release unneeded locks while replacing disks
lock... - 03:56 pm Revision 29b8eaee: TLReplaceDisks: Use implicit loop for dictionary
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:55 pm Revision 1bee66f3: Release unneeded locks while replacing disks
- If an iallocator is used, “gnt-instance replace-disks” would acquire the
locks of all nodes (only the allocator will ... - 03:41 pm Revision 07cba1bc: locking: Export “list_owned” from lock manager
- This is analog to “is_owned” and will be used for assertions.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
... - 03:41 pm Revision d8d838cb: gnt-instance: Fix typo in error message
- The iallocator parameter is “-I”, not “-i”.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iusti... - 03:38 pm Revision 580c971e: Merge branch 'devel-2.4'
- * devel-2.4: (24 commits)
mlock: fail gracefully if libc.so.6 cannot be loaded
Allow creating the DRBD metadev in... - 03:05 pm Revision adc523ab: mlock: fail gracefully if libc.so.6 cannot be loaded
- This allows noded to continue instead of blowing up if the libc major
number changes.
Signed-off-by: Iustin Pop <ius... - 02:48 pm Revision 661515f6: cmdlib: Drop SSH runner from LU base class
- It is no longer used.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
04/28/2011
- 07:02 pm Revision 0b606e54: cmdlib.py: fix indentation in _VerifyNode
- Signed-off-by: Adeodato Simo <dato@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 05:26 pm Revision c6627031: TLMigrateInstance: Fix confusing text
- Commit d5cafd31 changed this error message, swapping the
text parts in the process.
Signed-off-by: Michael Hanselman... - 05:25 pm Revision a2e885ee: LUInstanceRename: Amend comment about lock
- Also add an assertion.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.... - 05:25 pm Revision 342f9172: iallocator: Relocation nodes must be in same group
- Quoting from iallocator.rst: “[…] ``relocate`` request is used when an
existing instance needs to be moved within its... - 03:24 pm Revision 55f67cc9: Fix 'unused import' lint error
- Sorry!
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 01:06 pm Revision 8f9a87c5: SetEtcHostsEntry: maintain existing ordering
- Currently RemoveEtcHostsEntry keeps the ordering, but SetEtcHostsEntry
not, as it will always write the new entry at ... - 01:06 pm Revision 24c855a7: Convert utils.nodesetup to utils.WriteFile(data=…)
- It makes no sense to iteratively write the new etc/hosts file, as we
can pre-compute the desired contents (neither th... - 01:03 pm Revision 87001920: Allow creating the DRBD metadev in a different VG
- This is a simple change to allow specifying a different VG for the
meta device during the creation of instances and a... - 01:03 pm Revision c260fa25: Make _GenerateDRBD8Branch accept different VG names
- This is a small change to make this function take a list of VG names,
instead of a single one.
Signed-off-by: Iustin... - 01:02 pm Revision 1d39e245: Fix WriteFile with unicode data
- Unicode is fun, indeed:
>>> len(buffer("abc"))
3
>>> len(buffer(u"abc"))
12
So we can't pass unicode data to buffer...
04/27/2011
- 06:26 pm Revision 88aa7f66: Fix for multiple VGs - PlainToDrbd and replace-disks
- Converting an instance from 'plain' to 'drbd'. The old code would
create the drbd volumes in the default VG and then... - 06:26 pm Revision fd09d178: Replace disks: keep the meta device in the same VG
- This patch enhances the multi-VG support in replace disks, by keeping
the meta device in the same VG, as opposed to m... - 06:26 pm Revision d833acc6: Prevent readding of the master node
- This breaks Ganeti in multiple ways. If we don't make the check in
gnt-node itself, then bootstrap.SetupNodeDaemon wi... - 06:26 pm Revision cce6f357: Fix punctuation in an error message
- IIRC we don't use punctuation at the end of error messages.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-b... - 06:26 pm Revision 2db04578: Improve error messages in cluster verify/OS
- A few issues in the clarity of the error messages are fixed:
- "ERROR: node node3: OS API version lenny-image": no p... - 06:26 pm Revision 437c3e77: Fix potential data-loss in utils.WriteFile
- os.write can do incomplete writes, as long as at least some bytes have
been written (like write(2)):
>>> os.write(fd...
04/21/2011
- 04:08 pm Revision fe508a9d: QA: Add tests for node group tags
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:08 pm Revision 414ebaf1: RAPI: Add support for tagging node groups
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:08 pm Revision 1ffd2673: masterd: Add support for tagging node groups
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:08 pm Revision 819cbfe5: gnt-group: Add commands for tagging groups
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:41 pm Revision dadf6b7d: cli: Fix wrong argument kind for groups
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:41 pm Revision b5a418aa: Quote filename in gnt-instance.8
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:53 pm Revision 24fed61e: QA: Adding a config option to disable cluster epo
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
04/20/2011
- 04:54 pm Revision 0f7098f3: TLMigrateInstance: remove 10s sleeps
- TLMigrateInstance._ExecMigration contains two 10-second sleeps between
individual migration steps.
Apart from prolon... - 03:37 pm Revision 97b40f39: Fix typo in LUGroupAssignNodes
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:54 pm Revision 5c097318: gnt-instance info: automatically request locking
- Commit dae661a4 added support for controlling the locking, but it
didn't modify the gnt-instance info code, which lea... - 01:35 pm Revision bee8c465: Document the dependency on OOB for gnt-node power
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
04/19/2011
- 07:41 pm Revision 675e2bf5: Fix master IP activation in failover with no-voting
- Thanks to net.for.hub@gmail.com for reporting this. The logic in
masterd.CheckMasterd did an early return in case of ... - 06:41 pm Revision 6e7f0cd9: disk wiping: fix bug in chunk size computation
- The current wipe_chunk_size computation is doing min(int_value,
float_value). For small disks (below 10GiB), the actu... - 04:11 pm Revision 9ff4f2c0: Update manpages and other documents with editor settings
- No rewrapping is done in this patch, just updates to the settings.
Signed-off-by: Michael Hanselmann <hansmi@google.... - 03:56 pm Revision 1b1a08e8: gnt-group list: Query filter support
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:56 pm Revision 2afd577f: gnt-node list: Query filter support
- Update manpage, quote field names.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iu... - 03:54 pm Revision 87e87959: gnt-instance list: Query filter support
- Update manpage, quote field names.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iu... - 03:38 pm Revision a0aa6b49: Fix bug in watcher
- If “utils.RunParts” were to raise an exception, a log message was
written and the code continued to run. Due to the e...
04/18/2011
- 06:55 pm Revision b107fe05: opcodes: Change parameter type definition for query filter
- The old definition wouldn't accept integers.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iust... - 06:55 pm Revision 442587bf: cli: Add option to force names to be treated as filter
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 06:55 pm Revision 2928de47: cli: Add support for parsing query filters
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 06:55 pm Revision 3f2f55bb: qlang: Add function to distinguish filters from names
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 06:55 pm Revision cb1e6c3c: cli: Error reporting for query filter parsing
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 06:55 pm Revision 7578ab0a: qlang: Add parser for query filter language
- With this parser, command line utilities will be able to provide filters
through query2 in a simplistic language. Exa... - 06:55 pm Revision 3802f3cf: Update ganeti.7 manpage for query filter language
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:58 pm Revision 6a062ff9: htools: make some error messages more explicit
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 11:56 am Revision 7c670076: Add instance query field for OS parameters
- These were not available as a query field before. Update unittests
and description text for the other “..params” fiel...
04/14/2011
- 07:35 pm Revision 65a884ef: QA: also run gnt-cluster repair-disk-sizes
- So that we don't happen again to break this forever without realising
it.
The patch also replaces one ' with ".
Sig... - 01:33 pm Revision 4a2c0db0: Release locks before wiping disks during instance creation
- Ganeti 2.3 introduced an optional feature to overwrite an instance's
disks on creation. Unfortunately the code kept a... - 11:37 am Revision e8f472d1: Fix shared_file_storage_dir on upgrades
- If the cluster was upgraded from 2.4 or earlier, this key won't exist
(it's only set to a correct value on cluster in... - 11:37 am Revision 3e8b5a9c: QA: run the redist-conf command
- This was (AFAICS) completely missing from the QA suite.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: G... - 11:36 am Revision 2afc9238: Prevent ssconf values from having non-string values
- For whatever reason, my test cluster managed to acquire
shared_file_storage_dir with a None value, instead of empty
s... - 11:35 am Revision 9cbc1edb: Add some tests for the auto_balance attribute
- It tests node add/remove secondary, rather than cluster-level N+1
checks, but it's better than nothing.
Signed-off-b... - 11:35 am Revision 929b60d8: Node operations: take into account auto_balance
- This patch changes the add to secondary/remove from secondary code to
not deduct/add the instance's memory if the ins... - 11:35 am Revision bc782180: Read/write auto_balance via Text
- This also means _another_ change in the text format; we really should
move to json…
The unittests are also update fo... - 11:34 am Revision a041ebb5: Read auto_balance via Rapi
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Adeodato Simo <dato@google.com> - 11:34 am Revision 6880526c: Read auto_balance via Luxi
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Adeodato Simo <dato@google.com> - 11:33 am Revision 93439b1c: Show the auto_balance flag in the instance listing
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Adeodato Simo <dato@google.com>
04/13/2011
- 02:22 pm Revision ccfa86ba: cli: Replace hardcoded strings with constants
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 01:01 pm Revision a9d68e40: utils.WriteFile: Close file before renaming
- Issue 154 (http://code.google.com/p/ganeti/issues/detail?id=154)
reported an “Operation not supported” error when wri... - 01:01 pm Revision 154d7ba5: Fix distcheck
- README is not copied to the build tree.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Po... - 01:01 pm Revision accbf5e3: Nicer formatting for group query error
- Before this patc the message would look like “Some groups do not exist:
[u'foo', u'bar']”, now it's “Some groups do n... - 01:00 pm Revision 69d1b79d: gnt-instance.8: Fix wrongly formatted title
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
04/12/2011
- 11:55 am Revision 49e11c49: Some more changes to Makefile.am for htools
- I duplicate the BINARY= rule in the ghc invocation in order to be able
to silence the if, which was confusing.
Addit... - 11:55 am Revision c352b0a9: Add a new attribute to Instance.Instance
- This will mirror Ganeti's be/auto_balance one, which we need to use to
properly match N+1 computations.
Signed-off-b...
04/08/2011
- 01:41 pm Revision 9488fd1d: Update version in README
- Also add a check to Makefile's check-local target.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by...
04/07/2011
- 01:56 pm Revision 10028866: htools: Make opcode naming consistent with Ganeti codebase
- This patch just cleans up the htools codebase to make it more consistent
with the naming of the Ganeti codebase.
Sig... - 01:24 pm Revision af7b6689: Merge branch 'devel-2.4'
- * devel-2.4:
LUInstanceQueryData: Don't acquire locks unless requested
Increase the lock timeouts before we block... - 12:46 pm Revision 76ae1d65: Merge branch 'stable-2.4' into devel-2.4
- * stable-2.4:
Add error checking and merging for cluster params
Clarify --force-join parameter message
Treat em... - 12:36 pm Revision 9470b6ee: OpCodes.hs: make allow_failover optional
- And default to False, like in the Python codebase.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René N... - 12:36 pm Revision a810ad21: htools: add an utility function for JSON parsing
- This allows extracting values from a JSON object that might miss, but
have a well-defined default value.
Signed-off-... - 12:36 pm Revision 16a6192d: Two small Makefile fixes related to htools
- First, fix hs-coverage on non-pristine tree, where the index.html file
already existed, and second, disallow compilat...
04/06/2011
- 08:01 pm Revision 8d66f58a: htools: Use OpMigrateInstance with allow_failover option
- Before hbal decided on the fly if an instance is migratable or not. As
we implemented failover fallback in commit d5c... - 07:47 pm Revision dae661a4: LUInstanceQueryData: Don't acquire locks unless requested
- Until now LUInstanceQueryData always acquired locks for the instance(s)
and nodes involved. In combination with long-... - 04:03 pm Revision e9c487be: gnt-instance migrate: Adding --allow-failover option
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:03 pm Revision d5cafd31: TLMigrateInstance: Merge failover code, allow fallback
- As the code for failover for checking is almost identical it's an easy
task to switch it over to the TLMigrateInstanc... - 03:49 pm Revision d385a174: Increase the lock timeouts before we block-acquire
- This has been observed to cause problems on real clusters via the
following mechanism:
- a long job (e.g. a replace-... - 02:05 pm Revision bbfed756: utils: Add function generating regex for DNS name globbing
- The intent of this function is to be able to provide a globbing operator
or query filters. One should be able to say,... - 01:37 pm Revision aef59ae7: Verify file consistency using centrally computed list
- Until now “gnt-cluster verify” (LUClusterVerify) would compute its own
list of files to check for consistency. This l... - 01:37 pm Revision 5643d67e: cmdlib: Factorize computation of ancillary files
- … and change the logic in _RedistributeAncillaryFiles. The virtually
same list of files will be used to verify the fi...
04/05/2011
- 03:20 pm Revision bc385fa0: qlang: Remove OP_GLOB operator
- It'll be implemented using OP_REGEXP by the parser.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-b... - 03:20 pm Revision 23d0a608: query: Add implementation of regex match operator
- So far this operator was not implemented. This patch adds an additional
value preparation function to the function ta...
04/04/2011
- 07:30 pm Revision a7761c12: cmdlib: Fix mistake made in commit 75c7520f0
- Commit 75c7520f0 used the wrong constant. I double-checked all other
changes made in the commit.
Signed-off-by: Mich... - 05:59 pm Revision 75c7520f: cmdlib: Replace hardcoded values with constants
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:47 pm Revision fe295df3: daemon.py: move startup log message before prep_fn
- Before this, the output in the rapi daemon log was:
2011-04-04 03:09:51,026: ganeti-rapi pid=17447 INFO Reading users... - 02:47 pm Revision 0942620b: Display the actual memory values in N+1 failures
- This changes the display from:
Mon Apr 4 02:29:46 2011 * Verifying N+1 Memory redundancy
Mon Apr 4 02:29:46 2011 ... - 02:41 pm Revision 6d267b81: Update iallocator.rst for multi-reloc mode
- Signed-off-by: Adeodato Simo <dato@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
04/01/2011
- 04:42 pm Revision 7fa310f6: RAPI: Convert instance shutdown to the new FillOpCode
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 12:12 pm Revision 713a79e7: Fix QA breakage caused by 3fd7f6524
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
03/31/2011
- 07:47 pm Revision ebcd61bb: ssh.VerifyNodeHostname: remove the quiet flag
- This is not needed for this function, and can interfere with debugging
of ssh failures.
Signed-off-by: Iustin Pop <i... - 07:24 pm Revision c7d3a832: Add a simple wrapper over utils.Retry
- The new wrapper makes moving legacy code to utils.Retry or adding
retries in existing code simpler.
Signed-off-by: I... - 04:53 pm Revision e5395072: Expose whether htools was enabled to Python code
- This exports whether htools was enabled at configure-time, and adds a
constant for our reference iallocator.
Signed-... - 04:53 pm Revision d1e9c98d: Automatically enable hail if enabled and found
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 12:44 pm Revision d6491981: test.ganeti.process_unittest: Fix race condition
- There was a race condition on heavily loaded testsystem causing randomly
to fail the timeout unittests as the signal ... - 12:02 pm Revision 1ebe6dbd: Improve references to htools in the documentation
- Was not sure about the bit in admin.rst, hope it's fine.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: ...
Also available in: Atom