Activity
From 04/15/2011 to 05/14/2011
05/13/2011
- 06:33 pm Revision 73cdf9a3: cmdlib.IAllocator: Fewer temporary variables
- Reduce the number of temporary variables and generate dictionaries in
one go.
Signed-off-by: Michael Hanselmann <han... - 05:23 pm Revision dcfb969a: TLMigrateInstance: do not migrate to self
- Check that the instance is not being migrated to its current primary node
during CheckPrereq. Otherwise migration is ... - 03:57 pm Revision 3dbe3ddf: SharedLock: Implement downgrade from exclusive to shared mode
- If a job needs to modify a resource and then wait for a result, it must
acquire the resource lock in exclusive mode. ...
05/12/2011
- 07:38 pm Revision 9133387e: gnt-debug: Use constants for iallocator direction
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 07:38 pm Revision 63fb7526: Use disk mode constants in iallocator documentation
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 07:38 pm Revision fdbe29ee: gnt-debug, opcodes: Use constants for iallocator
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 07:37 pm Revision 2a9bc156: cmdlib.IAllocator: Use lookup table for mode-specific data
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 06:46 pm Revision ccce780c: Bump version for the 2.4.2 release
- I think we should stop finding bugs and instead release this :)
Signed-off-by: Iustin Pop <iustin@google.com>
Review... - 03:40 pm Revision f01738fc: Preload the string-escape code in noded
- This encoding, part of the standard Python installation, is used by
the pickle module (in turn used by subprocess whe... - 03:40 pm Revision 4b9e8c93: Abstract ignore_consistency opcode parameter
- Two opcodes already use it and we need it for a third, time to add a
constant for it.
Signed-off-by: Iustin Pop <ius... - 03:40 pm Revision bb851c63: Fix a bug in LUInstanceMove
- The opcode parameter ignore_consistency was used in the LU, but not
actually declared in the OpCode. The patch adds i...
05/11/2011
- 07:16 pm Revision f8afb7e6: Fix error in iallocator documentation reg. disk mode
- The code uses the disk object's “mode” attribute, which uses the
constants DISK_RDONLY (“ro”) and DISK_RDWR (“rw”).
... - 07:14 pm Revision b92a2f3e: Try to prevent instance memory changes N+1 failures
- There are multiple bugs with the code checking for N+1 failures in the
instance memory changes which needs significan... - 07:14 pm Revision 1bbf0c40: Update NEWS file for the 2.4.2 release
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 06:41 pm Revision d9f99d88: Remove references to acquired_locks
- These sneaked in from 2.4 during the merge, but this attribute is
actually gone in the master branch.
Signed-off-by:... - 05:14 pm Revision 93384b8c: Merge branch 'devel-2.4'
- * devel-2.4:
Use floppy disk and a second CDROM on KVM
Document the selection of instance kernels
Make root_pat...
05/10/2011
- 07:51 pm Revision 9626f028: iallocator: Specify result of “multi-relocate” request
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 07:40 pm Revision fba7f911: Use floppy disk and a second CDROM on KVM
- Hi all,
this patch will add 3 new KVM parameters and a new option.
New Parameters:
- floppy_image_path = "" -> Spec... - 06:58 pm Revision fc3914e6: Document the selection of instance kernels
- A simple doc patch to document how to configure the kernels for the
instances.
Signed-off-by: Iustin Pop <iustin@goo... - 06:32 pm Revision 0aeeb6e3: jqueue: Update worker thread name to include opcode summary
- With this patch, the worker thread name is updated to include a short
summary of the opcode (basically its OP_ID). Th... - 05:37 pm Revision ff8ab07e: Use the new dry-run mode in cmdlib
- This will hopefully detect potential LVM (or any other storage, when
they implement it) issues before committing chan... - 05:37 pm Revision a59faf4b: Implement grow dry-run at RPC level
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 05:37 pm Revision 7fe23d47: Implement dryrun mode for BlockDev.Grow()
- This is always called with False from backend for now.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Gu... - 05:35 pm Revision 04df3c7c: cmdlib: Sort nodes for OOB commands
- Also reorder the methods to match all other LUs.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: ... - 05:34 pm Revision 7ee045a0: cmdlib: Use helper for expanding nodes for OOB commands
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:34 pm Revision 1d789a97: cmdlib: Expand instances using helper for repairing disks
- Also change the way “share_locks” is filled.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iust... - 03:20 pm Revision e730f372: Fix bug introduced in commit 0d5a0b96
- When removing “acquired_locks” in commit 0d5a0b96, I didn't remember
that it does not contain the Big Ganeti Lock.
S... - 02:12 pm Revision 5ed4c956: Fix lock release in TLMigrateInstance
- Commit 52f33103 introduced lock release factorization, replacing manual
lock release using utility functions. However... - 02:03 pm Revision 2d91e6ae: Re-indent test/mocks.py using two spaces
- No idea where those four spaces came from, but they must've been there
for a while.
Signed-off-by: Michael Hanselman... - 02:03 pm Revision 0d5a0b96: cmdlib: Remove acquired_locks attribute from LUs
- The “acquired_locks” attribute in LUs is used to keep a list of acquired
locks at each lock level. This information i... - 02:02 pm Revision 0db3d0b5: cmdlib: Use local alias for lock manager
- Saves some typing and we'll use it more often in the future.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
R... - 11:48 am Revision 7adf7814: Make root_path an optional hypervisor parameter
- This will allow us an easy migration to pv-grub, because a set root_path
confused pv-grub.
Signed-off-by: René Nussb...
05/09/2011
- 06:49 pm Revision 3ce9a5e7: opcodes: Add function for compact summary
- Depending on the opcode and its parameters, the existing “Summary”
function can give a rater long summary. For displa... - 06:34 pm Revision c307ee34: Show locksets in lock monitor
- When all locks contained in a set are acquired, the lockset's internal
lock is acquired with the same mode. With this... - 06:33 pm Revision 83f2d5f6: locking: Make parameter to condition's wait() positional
- It is always used in the locking code. Unittests are updated.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
... - 06:33 pm Revision 113359fe: SharedLock: Avoid acquires from sneaking in while notifying
- In some rare cases new shared acquires could sneak in through the
condition cached in “__pending_shared” while the co... - 03:26 pm Revision 0a68e0ff: Some man page updates
- This adds documentation for both the short and long form of many
options (which was inconsistent before: in some case... - 02:22 pm Revision 519719fd: Add 2 new variables to the OS scripts environment
- Add INSTANCE_PRIMARY_NODE and INSTANCE_SECONDARY_NODES. These new
values are useful for OS scripts that needs to know... - 02:22 pm Revision 456798ab: Add --no-wait-for-sync when converting to drbd
- Currently, when converting an instance from plain to DRBD, the
instance is blocked during the entire resync period. T... - 12:18 pm Revision c8a96ae7: Recreate instance disks: allow changing nodes
- This patch introduces the option of changing an instance's nodes when
doing the disk recreation. The rationale is tha...
05/06/2011
- 06:47 pm Revision e3303a4e: Fix instance failover/migration w.r.t TLMigrateInstance
- Commit 1c6e5787 removed the iallocator and target_node keyword
parameters from TLMigrateInstance, but I didn't update... - 05:35 pm Revision 931413f6: Rename instance: only show new name when different
- It makes not sense to show messages like:
Fri May 6 02:04:01 2011 - INFO: Resolved given name 'instance18' to
'inst... - 01:46 pm Revision 9d5b1371: Fix race condition in LUGroupAssignNodes
- The original code would get all node information and their groups
without before acquiring the necessary locks. With ...
05/05/2011
- 02:25 pm Revision 1c6e5787: Fix DTS_EXT_MIRROR migration
- Commit faaabe3c fixed failover behaviour for DTS_INT_MIRROR instances, however
it broke migration for DTS_EXT_MIRROR ... - 02:09 pm Revision 8b0273a5: Use node group locking for replacing disks
- This is one of the first opcodes to make use of node group locking. To
get an instance's node groups, the instance's ... - 02:09 pm Revision 2674690b: config: Add function to determine instance's groups
- This will be used for locking only the necessary node group(s)
for per-instance operations.
Signed-off-by: Michael H... - 12:41 pm Revision 54bd7d76: TLMigrateInstance: Fix live migration breakage
- Commit 77fcff4 unintentionally incorporated code from
TLMigrateInstance.CheckPrereq into TLMigrateInstance._RunAlloca...
05/04/2011
- 05:19 pm Revision 46c936d6: cmdlib: Update error messages, remove some punctuation
- - Clarify some error messages
- Remove unnecessary punctuation
- Merge two if conditions in one place
Signed-off-by:... - 03:13 pm Revision 9d0671ba: Re-wrap and fix formatting issues in gnt-instance.rst
- This is mostly rewrapping plus fixing a few small issues in
gnt-instance.rst.
Signed-off-by: Iustin Pop <iustin@goog... - 12:25 pm Revision 81dd9bd1: Documentation for the new parameters for KVM
- Options added/updated are: cdrom2_image_path, floppy_image_path,
cdrom_disk_type and boot_order.
Signed-off-by: Iust...
05/03/2011
- 06:53 pm Revision 958d01f8: cmdlib: Fix typo, s/nick/NIC/
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:25 pm Revision 8dddc5bc: A small optimisation in cluster verify
- This removes (count of instances + count of nodes) lock
acquires/releases.
Signed-off-by: Iustin Pop <iustin@google....
05/02/2011
- 04:08 pm Revision 72740756: A few docstring fixes
- At least one generates an epydoc error :)
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselm... - 03:41 pm Revision d143f2c6: luxi: do not handle KeyboardInterrupt
- With the current code, it's possible to mistake a ^C for a protocol
error:
node1# gnt-job info 221691
[press ^C]
Unh... - 03:41 pm Revision 225e2544: Handle EPIPE errors while writing to the terminal
- This handles EPIPE errors in two places: ToStream (to catch logging
done in GenericMain itself) and in GenericMain (t... - 03:41 pm Revision 20d317d4: Cluster verify: check for missing bridges
- Currently cluster verify doesn't check for bridge information; the
only checks are done at instance create and failov... - 12:16 pm Revision cc130cc7: Use floppy disk and a second CDROM on KVM
- Hi all,
this patch will add 3 new KVM parameters and a new option.
New Parameters:
- floppy_image_path = "" -> Spec...
04/29/2011
- 05:15 pm Revision 52f33103: cmdlib: Factorize lock releasing
- There will be more lock releasing with upcoming changes, so this will
centralize the logic behind it (what locks to k... - 04:01 pm Revision 3de8301d: Merge branch 'devel-2.4'
- * devel-2.4:
TLReplaceDisks: Use implicit loop for dictionary
Release unneeded locks while replacing disks
lock... - 03:56 pm Revision 29b8eaee: TLReplaceDisks: Use implicit loop for dictionary
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:55 pm Revision 1bee66f3: Release unneeded locks while replacing disks
- If an iallocator is used, “gnt-instance replace-disks” would acquire the
locks of all nodes (only the allocator will ... - 03:41 pm Revision 07cba1bc: locking: Export “list_owned” from lock manager
- This is analog to “is_owned” and will be used for assertions.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
... - 03:41 pm Revision d8d838cb: gnt-instance: Fix typo in error message
- The iallocator parameter is “-I”, not “-i”.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iusti... - 03:38 pm Revision 580c971e: Merge branch 'devel-2.4'
- * devel-2.4: (24 commits)
mlock: fail gracefully if libc.so.6 cannot be loaded
Allow creating the DRBD metadev in... - 03:05 pm Revision adc523ab: mlock: fail gracefully if libc.so.6 cannot be loaded
- This allows noded to continue instead of blowing up if the libc major
number changes.
Signed-off-by: Iustin Pop <ius... - 02:48 pm Revision 661515f6: cmdlib: Drop SSH runner from LU base class
- It is no longer used.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
04/28/2011
- 07:02 pm Revision 0b606e54: cmdlib.py: fix indentation in _VerifyNode
- Signed-off-by: Adeodato Simo <dato@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 05:26 pm Revision c6627031: TLMigrateInstance: Fix confusing text
- Commit d5cafd31 changed this error message, swapping the
text parts in the process.
Signed-off-by: Michael Hanselman... - 05:25 pm Revision a2e885ee: LUInstanceRename: Amend comment about lock
- Also add an assertion.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.... - 05:25 pm Revision 342f9172: iallocator: Relocation nodes must be in same group
- Quoting from iallocator.rst: “[…] ``relocate`` request is used when an
existing instance needs to be moved within its... - 03:24 pm Revision 55f67cc9: Fix 'unused import' lint error
- Sorry!
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 01:06 pm Revision 8f9a87c5: SetEtcHostsEntry: maintain existing ordering
- Currently RemoveEtcHostsEntry keeps the ordering, but SetEtcHostsEntry
not, as it will always write the new entry at ... - 01:06 pm Revision 24c855a7: Convert utils.nodesetup to utils.WriteFile(data=…)
- It makes no sense to iteratively write the new etc/hosts file, as we
can pre-compute the desired contents (neither th... - 01:03 pm Revision 87001920: Allow creating the DRBD metadev in a different VG
- This is a simple change to allow specifying a different VG for the
meta device during the creation of instances and a... - 01:03 pm Revision c260fa25: Make _GenerateDRBD8Branch accept different VG names
- This is a small change to make this function take a list of VG names,
instead of a single one.
Signed-off-by: Iustin... - 01:02 pm Revision 1d39e245: Fix WriteFile with unicode data
- Unicode is fun, indeed:
>>> len(buffer("abc"))
3
>>> len(buffer(u"abc"))
12
So we can't pass unicode data to buffer...
04/27/2011
- 06:26 pm Revision 88aa7f66: Fix for multiple VGs - PlainToDrbd and replace-disks
- Converting an instance from 'plain' to 'drbd'. The old code would
create the drbd volumes in the default VG and then... - 06:26 pm Revision fd09d178: Replace disks: keep the meta device in the same VG
- This patch enhances the multi-VG support in replace disks, by keeping
the meta device in the same VG, as opposed to m... - 06:26 pm Revision d833acc6: Prevent readding of the master node
- This breaks Ganeti in multiple ways. If we don't make the check in
gnt-node itself, then bootstrap.SetupNodeDaemon wi... - 06:26 pm Revision cce6f357: Fix punctuation in an error message
- IIRC we don't use punctuation at the end of error messages.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-b... - 06:26 pm Revision 2db04578: Improve error messages in cluster verify/OS
- A few issues in the clarity of the error messages are fixed:
- "ERROR: node node3: OS API version lenny-image": no p... - 06:26 pm Revision 437c3e77: Fix potential data-loss in utils.WriteFile
- os.write can do incomplete writes, as long as at least some bytes have
been written (like write(2)):
>>> os.write(fd...
04/21/2011
- 04:08 pm Revision fe508a9d: QA: Add tests for node group tags
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:08 pm Revision 414ebaf1: RAPI: Add support for tagging node groups
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:08 pm Revision 1ffd2673: masterd: Add support for tagging node groups
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:08 pm Revision 819cbfe5: gnt-group: Add commands for tagging groups
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:41 pm Revision dadf6b7d: cli: Fix wrong argument kind for groups
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:41 pm Revision b5a418aa: Quote filename in gnt-instance.8
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:53 pm Revision 24fed61e: QA: Adding a config option to disable cluster epo
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
04/20/2011
- 04:54 pm Revision 0f7098f3: TLMigrateInstance: remove 10s sleeps
- TLMigrateInstance._ExecMigration contains two 10-second sleeps between
individual migration steps.
Apart from prolon... - 03:37 pm Revision 97b40f39: Fix typo in LUGroupAssignNodes
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:54 pm Revision 5c097318: gnt-instance info: automatically request locking
- Commit dae661a4 added support for controlling the locking, but it
didn't modify the gnt-instance info code, which lea... - 01:35 pm Revision bee8c465: Document the dependency on OOB for gnt-node power
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
04/19/2011
- 07:41 pm Revision 675e2bf5: Fix master IP activation in failover with no-voting
- Thanks to net.for.hub@gmail.com for reporting this. The logic in
masterd.CheckMasterd did an early return in case of ... - 06:41 pm Revision 6e7f0cd9: disk wiping: fix bug in chunk size computation
- The current wipe_chunk_size computation is doing min(int_value,
float_value). For small disks (below 10GiB), the actu... - 04:11 pm Revision 9ff4f2c0: Update manpages and other documents with editor settings
- No rewrapping is done in this patch, just updates to the settings.
Signed-off-by: Michael Hanselmann <hansmi@google.... - 03:56 pm Revision 1b1a08e8: gnt-group list: Query filter support
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:56 pm Revision 2afd577f: gnt-node list: Query filter support
- Update manpage, quote field names.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iu... - 03:54 pm Revision 87e87959: gnt-instance list: Query filter support
- Update manpage, quote field names.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iu... - 03:38 pm Revision a0aa6b49: Fix bug in watcher
- If “utils.RunParts” were to raise an exception, a log message was
written and the code continued to run. Due to the e...
04/18/2011
- 06:55 pm Revision b107fe05: opcodes: Change parameter type definition for query filter
- The old definition wouldn't accept integers.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iust... - 06:55 pm Revision 442587bf: cli: Add option to force names to be treated as filter
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 06:55 pm Revision 2928de47: cli: Add support for parsing query filters
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 06:55 pm Revision 3f2f55bb: qlang: Add function to distinguish filters from names
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 06:55 pm Revision cb1e6c3c: cli: Error reporting for query filter parsing
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 06:55 pm Revision 7578ab0a: qlang: Add parser for query filter language
- With this parser, command line utilities will be able to provide filters
through query2 in a simplistic language. Exa... - 06:55 pm Revision 3802f3cf: Update ganeti.7 manpage for query filter language
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:58 pm Revision 6a062ff9: htools: make some error messages more explicit
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 11:56 am Revision 7c670076: Add instance query field for OS parameters
- These were not available as a query field before. Update unittests
and description text for the other “..params” fiel...
Also available in: Atom