Activity
From 07/13/2011 to 08/11/2011
08/11/2011
- 03:50 pm Revision e50d8412: Use resource kind as OpQuery*'s description
- This gives a hint as to what's queried. “QUERY(instance)” or
“QUERY(node)” are way better than just “QUERY”.
Signed-... - 03:18 pm Revision 37531236: Added helper functions in netutils and related constants
- Added the following functions to netutils:
- IsValidInterface
- GetInterfaceIpAddresses
- _GetIpAddressesFromIpOutput... - 03:11 pm Revision 140ff718: Fix epydoc error in rlib2.py
- I blindly assumed epydoc would use normal reST, but turns out it uses
its own “epytext” in our configuration. Since t...
08/10/2011
- 06:32 pm Revision d91a933f: Fix typo in rlib2's docstring
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Benjamin Lipton <benlipton@google.com>
Reviewed-by... - 06:26 pm Revision f3c1a70c: Documentation fixes and clarification
- - In README, refer to “install.rst”, not “install.html”
- In rapi.rst, wrap line longer than 72 characters
- In rlib2... - 06:23 pm Revision c20efaa8: gnt-instance: Rename _SHUTDOWN_* to _EXPAND_*
- Once upon a time these constants were only used for stopping instances,
but pretty soon they became more useful. Let'... - 02:47 pm Revision 682e2375: List returned fields in RAPI documentation
- Also replace console types with constants.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin... - 02:47 pm Revision bd7b2070: rlib2: Exclude oplog/opresult from bulk job list
- These fields can get rather large. Excluding them from the big bulk list
reduces the amount of data. They are still a...
08/09/2011
- 03:33 pm Revision f4e86448: rlib: Expose node group tags
- Commit 1ffd26739d3 added support for tagging node groups. Also add a
check for exposed fields.
Signed-off-by: Michae... - 03:33 pm Revision e987f166: rapi: Bulk support for jobs
- This was requested in issue 181.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer ... - 03:32 pm Revision d7e4a2b1: Fixed an error in the documentation of _GetKVMVersion
- Fixed an epydoc compilation error that I introduced with last commit.
Signed-off-by: Andrea Spadaccini <spadaccio@go... - 03:32 pm Revision 037c7b95: Mention globbing filters in ganeti(7) manpage
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 02:29 pm Revision 440351f8: Removed code duplication for calls to _GetKVMVersion
- Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
08/08/2011
- 07:18 pm Revision 0b0ca0c0: Fix epydoc breakage caused by f8638e288c7a
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 06:50 pm Revision e2d14329: Changed NET_PORT_CHECK to REQ_NET_PORT_CHECK, to improve consistency
- I originally made this change because I needed the OPT_NET_PORT_CHECK,
and I am committing it even if I don't need an... - 06:49 pm Revision c4dfb0b6: Added check for the ip command at configure time
- Also, corrected a few places where the ip command was hardcoded.
Signed-off-by: Andrea Spadaccini <spadaccio@google.... - 06:42 pm Revision f8638e28: Detect globbing patterns as query arguments
- Short: this patch enables the use of “gnt-instance list '*.site'”.
Detailed description: This patch changes the comm... - 03:22 pm Revision bb074298: cluster-merge: consider file storage enable state
- There's no point in checking whether the file storage dir in the two
clusters is the same if file storage is not even... - 03:22 pm Revision 1fcd3b81: cluster-merge: implement params delta mercifulness
- Sometimes it's good to tell the user about parameter differences but
then proceed anyway. Strictness is still enforce... - 01:30 pm Revision e3a19474: Allow fixing of split instances via relocate
- Currently, the IAllocator code requests strictly that the (set of) groups of
the nodes we're relocating from is equal... - 12:29 pm Revision 88df1fa9: Revert deprecation of evacuate mode in hail
- As discussed offline, the new node-change mode could be used for
evacuation, but it's not directly useful as it retur... - 12:12 pm Revision f5fab862: Further cleanup after multi-evacuate removal
- Commit f0edfcf6 removed the parsing of multi-evacuate result, but the
code went from:
if mode in (multi-evac, relo... - 12:11 pm Revision 2f41ea77: Fix bug in IAllocator parsing of Evacuate result
- Commit 342f9172 added stricter checks for the iallocator result in
evacuate mode, but it does this irrespective of th...
08/05/2011
- 05:16 pm Revision 16629d10: Implement globbing operator for filters
- The operators “=*” and “!*” do globbing in filters, e.g.:
$ gnt-instance list --no-headers -o name 'name =* "*.site"... - 04:57 pm Revision 18e4dee6: Zero DRBD metadata before creation
- The docstring of the DRBD8 class says:
… The meta device is checked for valid size and is zeroed on create.
which... - 04:48 pm Revision f0edfcf6: Remove iallocator's “multi-evacuate” mode
- It is no longer used and has been deprecated in 2.5.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-... - 04:41 pm Revision 58aa30d7: confd.querylib: Remove long-deprecated query mode
- This was never used by a stable version.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin P... - 04:40 pm Revision ce4cd929: Add docstring to cmdlib.TLReplaceDisks._FindFaultyDisks
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:40 pm Revision 6f9e71bb: watcher: Fix breakage caused by 9bb69bb52fb9
- The first argument to str.split is the separator, not the maximum number
of splits.
Signed-off-by: Michael Hanselman... - 04:39 pm Revision ba98a8d1: Fix typo in NEWS
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 04:39 pm Revision 96514751: doc/admin: s/grub/GRUB/
- “GRUB” is an acronym for GRand Unified Bootloader.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by... - 02:58 pm Revision cb386168: LUGroupVerifyDisks: Use _CheckInstanceNodeGroups' result
- … instead of getting the list of instances once again from the
configuration.
Signed-off-by: Michael Hanselmann <han... - 02:58 pm Revision b9ff3e15: cmdlib: Factorize checking node groups' instances
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:11 pm Revision d5114fa1: Include hooks.rst in version check
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:11 pm Revision 9f604ab8: Bump version to 2.5.0~beta1
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:06 pm Revision 0e5084ee: utils.ReadFile: Add pre-read callback
- This will be used by the watcher to store the file's fstat(2). It must
be done from the filehandle.
Signed-off-by: M... - 02:06 pm Revision 9bb69bb5: watcher: Write per-group instance status, merge into global one
- Each per-group watcher process writes its own instance status file. Once
that's done it tries to acquire an exclusive... - 02:06 pm Revision 6890cf2e: cleaner: Remove watcher's instance status file after 21 days
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:48 pm Revision 2f1fe558: Merge branch 'stable-2.4'
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:02 am Revision 2f994ece: Bumping version to 2.4.3
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
08/04/2011
- 05:56 pm Revision eee68d57: Fixed a typo in utils/process.py
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: I... - 05:26 pm Revision e8906f7d: Fix unittest failure after list_owned changes
- We just need an object that has a list_owned method.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guid... - 05:01 pm Revision 12126847: Remove 15-second sleep from LUInstanceCreate
- Remove 15 second sleep when wait_for_sync is not set. LUInstanceCreate already
calls _WaitForSync with oneshot=True, ... - 05:01 pm Revision af993a2c: Add a readability alias
- lu.glm.list_owned becomes lu.owned_locks, which is clearer for the
reader.
Also rename three variables (which were b... - 04:19 pm Revision ce523de1: Fix broken object references in docstrings
- The module is called “objects”, not “object”.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Ius... - 04:18 pm Revision bd2a5569: Add “gnt-instance change-group” command
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:18 pm Revision 1aef3df8: Add opcode to change instance's group
- This is quite similar to evacuating a group, but the locking
is different.
Signed-off-by: Michael Hanselmann <hansmi... - 04:18 pm Revision eafa26af: Factorize checking instance's node groups
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:41 pm Revision e20832af: Update the NEWS file for 2.4.3
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 01:28 pm Revision 7b642c49: ganeti-cleaner: Remove old watcher state files
- Watcher state files can stay around if node groups are removed. With
this patch they're removed after 21 days.
Signe... - 01:28 pm Revision 173dbf05: Remove WATCHER_STATEFILE constant
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 01:28 pm Revision a292020f: cfgupgrade: Remove old watcher state file
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 01:28 pm Revision 16e0b9c9: ganeti-watcher: Split for node groups
- This patch brings a huge change to ganeti-watcher to make it aware of
node groups. Each node group is processed in it... - 01:27 pm Revision de9c12f7: Lock potential target nodes for group evacuation
- All potential target nodes should be locked while calculating
a group evacuation.
Signed-off-by: Michael Hanselmann ... - 01:27 pm Revision 6e80da8b: Small changes in group evacuation
- - Use OpPrereqError in CheckPrereq
- Clarify command synopsis
Signed-off-by: Michael Hanselmann <hansmi@google.com>
... - 01:26 pm Revision a14065ac: cmdlib: Factorize getting iallocator
- The same logic will be used for changing an instance's group.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
... - 01:26 pm Revision d774ce92: Add design document for Ganeti 2.5
- Including the designs which were actually implemented.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewe...
08/03/2011
- 07:35 pm Revision 41e1e79e: Pause DRBD sync for OS install if not wait_for_sync
- When wait_for_sync is set to False in LUInstanceCreate, Ganeti lets DRBD sync
in the background while performing the ... - 07:21 pm Revision a6a3efe4: Fix documentation of gnt-instance failover
- Explain that we only start the instance on the new node if it was
originally running.
Signed-off-by: Iustin Pop <ius... - 06:28 pm Revision 78623223: Small doc patch for gnt-node evacuate
- Just explain a bit the relation between node evacuate and instance
commands.
Signed-off-by: Iustin Pop <iustin@googl... - 06:27 pm Revision d5fca545: Fix small typo in docstring
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 06:03 pm Revision b5ea70bf: Fix typo in NEWS
- “--dry-run” starts with two dashes.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <i... - 05:42 pm Revision 6aa7a354: Change the backend.InstanceLogName signature
- This uses now the component for the transfer (if available), otherwise
(e.g. in installs/renames) nothing.
Signed-of... - 05:42 pm Revision 6613661a: Instance transfer: export component name to backend
- This modifies the RPC layer to export the component name too to the
backend, so that it can be used in log files and ... - 05:42 pm Revision 5e26c4d9: Instance transfer: add argument for the 'component'
- Currently, transfer data is done mainly with just the instance name,
but when we have instances with multiple disks t... - 05:41 pm Revision a4338da2: Fix lint errors
- It turns out that the only use of the operator module was for
itemgetter, so patch eb62069e should have removed that ... - 05:41 pm Revision f5eaa3c1: Optimise use of repeated/looping GetNodeInfo
- This adds a new ConfigWriter.GetMultiNodeInfo function and replaces
multiple/looping calls to GetNodeInfo with it.
S... - 05:41 pm Revision 71333cb9: Optimise use of repeated/looping GetInstanceInfo
- Similar to the previous patch, this adds a helper function to
eliminate repeated calls info ConfigWriter.
Signed-off... - 05:17 pm Revision 71ed8d22: gnt-node.rst: Fix a typo
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 01:37 pm Revision eb62069e: Add two more compat functions
- operator.itemgetter(0) → fst
operator.itemgetter(1) → snd
snd is not used yet, but it makes sense to add both.
Sign... - 11:50 am Revision d0ffa390: Add a flag to burnin to allow specifying VCPU count.
- Signed-off-by: Pedro Macedo <pmacedo@google.com>
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Iustin Po...
08/02/2011
- 04:12 pm Revision 7c070961: Fix types passed to IAllocator
- Iallocator mode reloc, parameter reloc_from takes a list; half of the
code already forced this parameter to list, we ... - 04:12 pm Revision 7fa52acd: htools: change absolute to relative symlinks
- Currently we use absolute symlinks, but this doesn't work when we
install remotely (due to install first to local tem... - 12:56 pm Revision dfc8824a: jqueue: Add short delay before detecting job changes
- By sleeping for 100ms after receiving a notification for a changed job
file the job is given some additional time to ... - 12:08 pm Revision fab9573b: Add primary/second nodes' group as query fields
- These will be very useful for ganeti-watcher as it needs to retrieve
instances by group.
Signed-off-by: Michael Hans... - 11:20 am Revision d66bbe9f: Fix doclint failures
- Commit 54ca6e4b2 renamed some arguments, but didn't also renames them
in the docstrings.
Signed-off-by: Iustin Pop <...
07/29/2011
- 06:02 pm Revision 8f07dc0d: watcher: Separate function for writing instance status file
- For now this will do another query to the master daemon, but with the
split for node groups this issue will go away.
... - 06:02 pm Revision d7c42723: watcher: Make RAPI error messages less technical
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 06:02 pm Revision 54ca6e4b: watcher.state: Use strings, not objects
- Until now the state class would receive instances as objects
(ganeti.watcher.Instance), but this is not necessary. By... - 06:02 pm Revision 013ce4ae: watcher: Raise error on unknown hook status
- Also, remove punctuation from one error message.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: ... - 06:01 pm Revision 0cc9e018: watcher: Reformat constants
- Make them match with style guide.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <ius... - 06:01 pm Revision 9d7b1e53: Add new watcher constants
- WATCHER_STATEFILE will be removed at the end of this
patch series.
Signed-off-by: Michael Hanselmann <hansmi@google.... - 04:19 pm Revision 21daa4a8: Fix formatting of frozensets
- Signed-off-by: Stephen Shirley <diamond@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:04 pm Revision 21ee2318: cli: Add constant for node group option
- ganeti-watcher will use this constant to pass the option to itself for
processing all node groups.
Signed-off-by: Mi... - 03:36 pm Revision 194e8648: Replace %r with '%s' in masterd/instance.py
- I still don't know why Michael is a fan of %r, but in the meantime
this patch changes:
WARNING: import u'import-2011... - 01:59 pm Revision 990ade2d: Add "reboot_behavior" hypervisor flag
- During instance installations, you do not want the instance to reboot
and start again with the same parameters, as th... - 12:20 pm Revision 7548d53c: Removed non-existing -t option from the gnt-cluster man page
- Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 11:49 am Revision 896a03f6: Clear the OS scripts environment
- The OS scripts currently run with the whole noded environment; this is
different from the hooks which run with a clea... - 11:48 am Revision adf6301e: watcher: Split state class into separate module
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:21 am Revision bcf0450d: Rename watcher's constant for instance status file
- “upfile” is a bad name.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@... - 11:02 am Revision 84d7362b: Fixed a typo in the installation tutorial
- Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Iu...
07/28/2011
- 04:27 pm Revision 9ca87fb3: watcher: Split node maintenance into separate module
- The node maintenance class is standalone.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin ... - 02:26 pm Revision 44275c2d: Fixed doc compilation under Sphinx 1.0.7
- Sphinx 1.0.7 complains if an indented block in .warning starts with :option.
This fixes it.
Signed-off-by: Andrea Sp... - 02:17 pm Revision db0647dc: Merge branch 'devel-2.4'
- * devel-2.4:
Add support for cluster/OS parameters in QA
Add OS search path to gnt-cluster info
Signed-off-by: I... - 02:08 pm Revision 35007011: Remove requirement for variants on OS API v15+
- This removes:
- the check in backend that such OSes have a variants file or if it
exists that is non-empty; in ord... - 01:21 pm Revision 5abecc1c: Add support for cluster/OS parameters in QA
- Currently there is no way to QA with (for example) an initrd because
the QA only inits the cluster with the default p... - 11:19 am Revision 4474f112: Revert "cli.JobExecutor: Feedback function for info output"
- This reverts commit 7421df8e5f2cf31022085b332d1300640ba5854b.
The feedback_fn argument to JobExecutor is used for Po... - 11:18 am Revision 75932bcf: Extend the ovf-support design with format translation
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: I... - 11:16 am Revision c2a0947d: Add a QA constant for cluster verify command
- This seems to be used and reused multiple times, let's abstract it…
Signed-off-by: Iustin Pop <iustin@google.com>
Re... - 11:16 am Revision f39b695a: Fix group verification of offline nodes
- Commit aef59ae7 reworked the file verification, but forgot to take
into account offline nodes.
The fact that this wa...
07/27/2011
- 03:50 pm Revision 6ba2bdc2: Disallow variants for OSes that don't support them
- Otherwise we get no variant checks at all, but the variant is still
recorded.
Signed-off-by: Iustin Pop <iustin@goog... - 02:27 pm Revision 732052c1: Fix QA OS API failure
- The patch changing the OS api in QA to 20 was not complete, sorry.
Signed-off-by: Iustin Pop <iustin@google.com>
Rev... - 11:38 am Revision e3f9ae2b: QA: test using OS API v20
- v20 is (mostly) a superset of the other versions, so testing with it
should be better than with V10. This detects pro... - 11:38 am Revision 6ae1fade: Fix OS queries for API v20 w/parameters
- OS parameters is a list of tuples, so we can't pass it directly to
utils.NiceSort, hence we use a sort key.
This was...
07/26/2011
- 02:22 pm Revision 9f039737: Add helper for declaring all locks shared
- This patch adds a function for abstracting
“dict.fromkeys(locking.LEVELS, 1)”. It also removes a duplicate
assignment... - 02:19 pm Revision 1ce03fb1: Add ht-based result checks to opcodes
- This adds the infrastructure necessary to check opcode results using
ht-based functions. Checks are added for two opc... - 01:53 pm Revision ae1a845c: Change OpClusterVerifyDisks to per-group opcodes
- Until now verifying disks, which is also used by the watcher,
would lock all nodes and instances. With this patch the... - 01:53 pm Revision c4ff2275: cmdlib: Give instance name in error message on group evacuation
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 01:53 pm Revision 3ddd94f9: cmdlib: Factorize mapping instance LVs to node/volume
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 01:53 pm Revision 7421df8e: cli.JobExecutor: Feedback function for info output
- This will be used in the watcher where we don't want to
pollute stdout unless in debug mode.
Signed-off-by: Michael ... - 01:12 pm Revision f36c3e2d: Add OS search path to gnt-cluster info
- Otherwise, it's pretty hard to figure it out from the command line.
Signed-off-by: Ben Lipton <benlipton@google.com>... - 11:55 am Revision 2be7c4cc: cluster-merge: remove a hardcoded constant
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:38 am Revision 620a9c62: cluster-merge: add instance restart strategy opt
- Right now we always restart all instances, which is not right if some
instances were already down for other reasons. ... - 11:38 am Revision d2b17e37: cluster-merge: remove option list from usage
- It doesn't make sense to have to keep them up to date twice, and --help
already lists all of them with help strings.
... - 11:31 am Revision 13aeae6a: Fix recompilation of htools on regen-vcs-version
- Currently, most htools code depends on Constants.hs which is generated
from constants.py and also depends on _autocon... - 11:31 am Revision a3ac3243: Add another name for the --yes-do-it option
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
07/25/2011
- 04:55 pm Revision d0c8c01d: Most boring patch ever
- s/'/"/ in (hopefully) the right places.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselman... - 04:06 pm Revision 0fa044e7: Merge branch 'devel-2.4'
- * devel-2.4:
Reopen daemon's stdio on SIGHUP
Reopen log file only once after SIGHUP
Don't leak file descriptors... - 04:01 pm Revision 110f49ef: Reopen daemon's stdio on SIGHUP
- Before this patch daemons would continue to refer to an old logfile for
their standard I/O if they had been asked to ... - 04:01 pm Revision ad88650c: Reopen log file only once after SIGHUP
- Commit b6fa9a44 added a re-openable log handler. The log file is
reopened when a daemon is sent a HUP signal. Due to ... - 04:01 pm Revision 638ac34b: Don't leak file descriptors when setting up daemon output
- When a daemon's output is configured using “utils.SetupDaemonFDs”, the
function must use dup2(2). Unfortunately the c...
07/22/2011
- 02:33 pm Revision 97da6b71: htools: rework the algorithm for ChangeAll mode
- I think I've identified the problem with the current ChangeAll
mode. The current algorithm works as follows:
- ident... - 02:32 pm Revision f965260c: gnt-instance info: Return static info if node offline
- Before this patch “gnt-instance info” would fail with the error message
“Error checking node $node: Node is marked of... - 02:30 pm Revision 3b61ee44: Ignore offline primary when failing over
- When the source node for a failover is marked offline, there's no need
to require the user to specify “--ignore-consi... - 01:53 pm Revision 77ecfa82: htools: replace two hardcoded uses of pri+sec nodes
- These two cases use explicit uses of primary and secondary nodes with
Instance.allNodes, which means the code is more... - 01:53 pm Revision bbe9758d: htools: add target_node member to migrate opcode
- … and failover too. Not many changes otherwise except for
serialisation and unittests.
Signed-off-by: Iustin Pop <iu... - 01:53 pm Revision 10f055ac: htools: do not change node disk for non-local storage
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 01:53 pm Revision 8353b5e1: htools: add more functions for local disk storage
- These will be used in Node.hs for proper add/remove instance
code. Furthermore, we restrict the movable status to the... - 01:48 pm Revision b3e3813e: Initial design doc for OVF support
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
[iustin@google.com: fixed formatting issues]
Signed-off-by:... - 01:31 pm Revision 3f42b4f6: Fix aliases in bash completion
- Ever since commit 2d48a3a2 aliases were not included in the bash
completion script. This patch also replaces one tab ... - 01:29 pm Revision d6f46b6a: gnt-instance console: Use query instead of opcode
- This means opening the console no longer requires the instance lock,
allowing it to be used during long-running opera... - 12:07 pm Revision dbfde874: Merge branch 'devel-2.4'
- * devel-2.4:
gnt-node volumes: Fix instance names
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-b... - 12:03 pm Revision 018ae30b: Add opcode attribute for comments
- This attribute allows programmatic submitters of jobs (e.g. iallocator)
to add a comment to each opcode, describing i... - 12:00 pm Revision 4b413e49: gnt-node volumes: Fix instance names
- Commit 84d7e26b changed “objects.Instance.MapLVsByN” to not just return
the LV name, but to include the volume group ...
07/21/2011
- 07:00 pm Revision 240c769f: Fixed one option name and a typo in the docs
- The -g vg-name option was deprecated in commit
04367e70ad71eea3f0f19e7889dc68fb9783c98a.
Signed-off-by: Andrea Spada... - 04:25 pm Revision 463f75a5: Fix instance failover (missing argument)
- More fallout from commit 323f9095b49d.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop... - 04:25 pm Revision c0a146a1: Implement instance failover via RAPI
- No idea why this was missed before.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <i... - 02:55 pm Revision 44b4eddc: Make lock monitor more versatile
- With this change it'll be possible to register other lock information
providers. One usecase for this are job depende... - 02:55 pm Revision 4c03b2b5: locking.GLM: Allow adding locks to monitor
- This will be used for exporting job dependencies through
the lock monitor.
Signed-off-by: Michael Hanselmann <hansmi... - 02:55 pm Revision fcb21ad7: Export job dependencies through lock monitor
- This makes them visible to the user. Example:
$ gnt-debug locks -o name,pending
Name Pending
job/890 job:891,892
... - 02:52 pm Revision ee041788: Update documentation regarding Haskell dependencies
- These were forgot when the supported library versions were changed.
Signed-off-by: Iustin Pop <iustin@google.com>
Re... - 02:52 pm Revision 0047d4e2: htools: add two more small unittests
- This adds tests for the opToResult and eitherToResult functions from
Types.hs, and changes two other tests for the sa... - 02:52 pm Revision 5b53ca79: htools: update hail man page with the new modes
- Also mark the deprecated modes we no longer support.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Mich... - 02:51 pm Revision 1b0a6356: htools: a few more hlint fixes
- Tested only on GHC 7.x, will test on 6.1x too before commit.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-... - 02:50 pm Revision 179c0828: htools: further docstring fixes
- This adds parameter documentation for Cluster.iMoveToJob (I think it
was not clear if the new or old node list is nee... - 02:50 pm Revision 9f8b97ce: htools: add JSON instance for EvacMode
- This abstracts the JSON parsing of the type EvacMode near its
definition, and simplifies its conversion in IAlloc.par... - 02:49 pm Revision 375969eb: htools: add human-readable output to hspace
- Currently, hspace can only output a machine-readable format that
(while detailed) is hard to parse quickly by people.... - 02:38 pm Revision 6a5e7dbe: Fix job constants use in htools
- Commit 56c094b4 added use of job constants, but I didn't pay
attention and ended up mixing things: job constants were... - 02:20 pm Revision 67a315ba: Add error state to LUGroupEvacuate's exceptions
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:20 pm Revision 47099cd1: Rename *_STATUS_WAITLOCK to …_WAITING
- This patch renames the {JOB,OP}_STATUS_WAITLOCK constants to
{JOB,OP}_STATUS_WAITING, as per design document for chai... - 12:39 pm Revision f6eb380d: gnt-group: Add command to evacuate whole group
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:39 pm Revision 08f8c82c: Add new opcode for evacuating group
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:58 am Revision 75d81fc8: Fix locking issue with job dependencies
- When jobs waiting for a dependency are notified, they're re-added to the
queue. This would require owning the queue l... - 11:56 am Revision f8a4adfa: jqueue: Read-only jobs don't need processor lock
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 08:38 am Revision 4f580fef: Add support for KVM keymaps
- Signed-off-by: Sébastien Bocahu <zecrazytux@zecrazytux.net>
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Rev... - 08:33 am Revision c2d22fed: gnt-debug: Add tests for job dependencies
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 08:33 am Revision b247c6fc: jqueue: Implement submitting multiple jobs with dependencies
- With this change users of the “SubmitManyJobs” interface can use
relative job dependencies. Relative job IDs in depen... - 08:33 am Revision 7bb60c2d: Fix node evacuation
- - Adjust for new iallocator result format
- Split some code into helper functions
Signed-off-by: Michael Hanselmann ...
07/20/2011
- 05:44 pm Revision 4938fa30: Do proper name lookup for the -O option
- hspace and hbal treat -O differently, and use aliases for short names
(although hbal succeeds in that, and hspace doe... - 03:11 pm Revision c0f6d0d8: jqueue: Add “writable” flag to memory objects
- Basically only one instance of the job, the one being processed,
should be serialized to disk and replicated to other... - 03:11 pm Revision b95479a5: Implement chained jobs
- An overview is available in the design document for this change,
doc/design-chained-jobs.rst.
When a job enters the ... - 03:09 pm Revision 2915335f: Add implementation details to design for chained jobs
- As requested by Iustin.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google... - 02:41 pm Revision 42143c5b: Add support for GPT by using parted for disks bigger than 2TB.
- Signed-off-by: Pedro Macedo <pmacedo@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 09:31 am Revision 475242f6: Remove constants for iallocator multi-relocate
- They're no longer necessary.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@g...
07/19/2011
- 06:17 pm Revision 519edd9f: htools: add a machine-readable CLI flag
- This will be used in hspace to toggle between "human" readable
and machine readable output formats.
Signed-off-by: I... - 06:06 pm Revision d7731f51: htools: move the '-p' option to htools.rst
- Since this is a common option and has a big description.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: ... - 05:54 pm Revision 1494a4cc: htools: switch hspace to the generic binary
- This is the last patch of the binaries conversion.
As information, we now have a single binary that is approx. 5.4Mi... - 05:54 pm Revision 756df409: htools: move tiered spec map helper to Hspace.hs
- This is used just in hspace, so let's help in making Cluster.hs
smaller. We also split the function in two, as comput... - 05:54 pm Revision 33b9d92d: htools: import the program modules in QC.hs
- This adds the binaries code to the coverage, and thus the coverage
finally shows the real coverage over all logic cod... - 05:54 pm Revision 7b695a0d: htools: switch hscan to the generic binary
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 05:54 pm Revision 201b6c34: htools: switch hbal to the generic binary
- In addition, the patch adds a separate Makefile variable for holding
the binary roles to make it more clear what we s... - 05:54 pm Revision 458a286a: htools: switch hail to the generic binary
- This converts the first binary to the generic 'htools' binary.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewe... - 05:14 pm Revision d26d808a: htools: add a generic binary
- This is the start of a series of patches that will unify all the
binaries currently in use in a single one, which can... - 05:12 pm Revision 1adec4be: htools: add a compatibility module
- When compiling with the parallel-3.x library, we get a deprecation
warning, which makes understanding any other error... - 05:12 pm Revision a5f248ac: htools: remove no-longer-needed tryMG* functionality
- … which was deprecated by the previous patch.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trott... - 05:12 pm Revision fbe5fcf6: htools: remove ialloc/relocate and multi-evacuate
- Since the new node-evacuate mode does both their work and also
supports better multi-group clusters (including handli... - 05:12 pm Revision a86fbf36: htools: fix potential bug in ialloc/change-group
- Currently, the ChangeAll mode of nodeEvac computes the primary group
of the instance and then uses the resulting grou...
07/18/2011
- 06:33 pm Revision 96a12113: htools: run IAllocator input through checkData
- As the IAllocator backend is using a different data path than the
others, it doesn't get the full functionality that ... - 06:28 pm Revision 8cd36391: htools: abstract a function for displaying warnings
- This will make it possible to reuse this in IAllocator too.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-b... - 06:28 pm Revision 15329af5: htools: use maybePrintNodes in hail.hs
- This eliminates duplication of codes (and was forgotten back when
maybePrintNodes was added).
Signed-off-by: Iustin ... - 06:27 pm Revision 4162995d: htools: add cluster state saving support to hail
- This add support for saving the cluster state (both pre- and
post-iallocator run) to a text file such that it can be ... - 06:27 pm Revision f9283686: htools: return the final instance map in ialloc
- Similar to the previous patch, this returns the final instance map
from the iallocator run, which will allow saving t... - 10:30 am Revision ce6a0b53: htools: implement post-alloc cluster status display
- This patch changes the IAllocator result formatting workflow to return
the final node list, which can be then used to...
07/15/2011
- 08:13 pm Revision fda24caf: Update node group iallocator design to use job dependencies
- While working on a function to submit jobsets, I realized that we
actually don't need them anymore. With the new job ... - 08:13 pm Revision 45df0793: Fix assertion error on unclean master shutdown
- Commit 66bd7445 added an assertion to ensure a finalized job has its
“end_timestamp” attribute set. Unfortunately it ... - 08:12 pm Revision fdfe88b1: Make SharedLock._is_owned public
- This will be useful for assertions. GanetiLockManager._is_owned is
exported, too.
Signed-off-by: Michael Hanselmann ... - 06:56 pm Revision 4036f63a: htools: return new state from new IAllocator modes
- The old modes already return the node list (as part of AllocSolution),
this patch makes the new modes provide this ne... - 06:56 pm Revision 5440c877: htools: update the node-evac/change-group result
- … per the new design changes. This also requires changes to
updateEvacSolution, as passing in the original instance i... - 04:29 pm Revision d254d6ce: htools: add function for getting all nodes of an instance
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 04:25 pm Revision 20b376ff: htools: add change-group IAllocator mode
- This builds a lot upon the node-evacuation mode, and its
implementation is therefore quite easy (once node-evac was a... - 04:24 pm Revision d72ff6c3: htools: add group restrictions to findBestAllocGroup
- While a normal multi-group allocation doesn't need to restrict the
list of target groups beyond the unallocable statu... - 04:13 pm Revision c9a9b853: htools: generalise and rename availableLocalNodes
- Currently this function works in the context of an instance, computing
its local group nodes. We can use generalise i... - 04:12 pm Revision 57f07ff2: htools: add ChangeGroup to IAllocator types/loader
- This patch updates the types and functions in IAllocator.hs and
Loader.hs to the new design changes (elimination of m... - 04:10 pm Revision 8fd09137: htools: split tryMGAlloc in two
- Currently, this function does both identify the best group for an
instance, and format the results (partially). The f... - 04:10 pm Revision d52d41de: htools: add node-evacuation of DRBD all nodes
- This is much more complicated than either change primary (which is
trivial) and change secondary (which is also simpl... - 04:00 pm Revision b4bae394: htools: small optimisation in Cluster.collapseFailures
- This makes fewer temporary data structures, and thus brings a bit of
improvement in total runtime.
Signed-off-by: Iu... - 03:59 pm Revision 8f48f67d: htools: add optional limit to allocation count
- Currently, the tieredAlloc/iterateAlloc functions will not return
until the allocation fails; this means unit-testing... - 03:33 pm Revision db56cfc4: htools: add node-evacuation of DRBD secondaries
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 03:32 pm Revision 9bb5721c: htools: rework compCV so that we can use [Node] too
- In some cases, we have a [Node.Node] list, instead of a Node.List
structure. Instead of converting [Node.Node] to the... - 12:27 pm Revision 61631293: Adding a wrapper around "xm console"
- The wrapper will connect to the console, and check in the background if
the instance is paused, unpausing it as neces... - 12:27 pm Revision 2f4c951e: Adding a wrapper around connecting to kvm console
- The wrapper will connect to the console, and check in the background if
the instance is paused, unpausing it as neces...
07/14/2011
- 10:52 pm Revision 3aa8ed2b: Add opcode attribute for chained jobs
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 10:51 pm Revision 6c3d18e0: Design for chained jobs
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:32 pm Revision f815aa89: htools: fix a doc bug in the hbal man page
- Similar to the previous hspace fix.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <h... - 02:48 pm Revision b7448942: Mark htools/README as obsolete
- And point to the main INSTALL file for up-to-date information.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewe... - 01:14 pm Revision 3158250d: Fix htool unittest failure due to invalid prereqs
- Currently, the test prop_Node_rMem does some reserved memory checks on
nodes, and for the test to work correctly (can... - 12:05 pm Revision 8dda364e: hspace: also display the starting tiered specs
- These are useful for checking what instance specifications we start
with (as they are not necessarily the first entry... - 12:05 pm Revision 247f77b7: hspace: add support for units in the options
- This patch converts hspace to allow units in all disk and memory
specifications, and updates the man page accordingly... - 12:05 pm Revision 1cb92fac: htools: add parseUnit function
- This is similar, but not identical, to Utils.ParseUnit. The biggest
difference is that we don't round up/down; as we ... - 12:05 pm Revision 1f4ae205: htools: abstract and simplify a multigroup function
- In the future, this 'split/associated instance idx list' functionality
will be used by other code, so let's move it t... - 12:05 pm Revision 97936d51: htools: rename an internal constant
- 'emptySolution' is fine while we have only one Solution type
(AllocSolution), but in the future we'll introduce anoth... - 12:05 pm Revision 63a78055: htools: add a function for computing evacuated nodes
- The new IAllocator interface is based on instances, not nodes, so we
need to backtrack and compute on which nodes we ... - 12:05 pm Revision a30b473c: htools: add two monad-conversion utility functions
- For monadic operations, these function will make it easier to convert
other monads (or monad-like structure) to our '... - 12:05 pm Revision 47eed3f4: htools: add more IAlloc data types and functions
- These move the 'not supported' message deeper into the workflow;
assuming that the workflow as added by this patch is... - 12:05 pm Revision bef83fd1: htools: add node-evacuate of DRBD8 primaries
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
07/13/2011
- 07:45 pm Revision 22fac87d: htools: simplify select tests
- Rather than running all possible tests in one go, split them out in
three cases: "normal", undefined default value, u... - 07:07 pm Revision 82bc21e2: Set startup_paused to False when restarting
- This fixes the lint error:
E1120:1220:InstanceReboot: No value passed for parameter
'startup_paused' in function cal... - 05:09 pm Revision 424ec11d: htools: lookup instance names in select/exclude
- Currently we just match the passed name with fqdns. With this change we
do a proper search for either the fqdn or the... - 04:52 pm Revision efe98965: htools: infrastructure for looking up names
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 04:52 pm Revision bfe6c954: htools: Add if' and select as functions
- if' is just a functional version of the if-then-else construct. Using it
we can manipulate ifs as functions, and also... - 01:46 pm Revision 043a3929: htools: remove obsolete option INodes
- hspace no longer uses it, hence it can be removed.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michae... - 01:45 pm Revision 1cc97b7f: hspace: also report the disk template
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 01:45 pm Revision 9ef605a6: hspace: ask for the disk_template not number of nodes
- This makes more sense, as the disk template is more meaningful than
the number of nodes.
Signed-off-by: Iustin Pop <... - 01:45 pm Revision a10a476a: htools: add an utility function for disk templates
- In the future we'll use this instead of requiring the number of nodes
from the user.
Signed-off-by: Iustin Pop <iust... - 01:44 pm Revision c4bb977b: htools: define the --disk-template option
- Also sorts the export list correctly.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann ... - 01:40 pm Revision 6429e8d8: htools: read/save the disk template in Text backend
- This requires that we change the signature of loadInst in order to
properly annotate the error messages, which in tur... - 01:38 pm Revision b3c5e8de: htools: read the disk_template in the Luxi backend
- We need to request the disk template in the Luxi query and then use it
when parsing the response.
Signed-off-by: Ius... - 01:37 pm Revision 5a4a3b7f: htools: read the disk template in Luxi and Rapi
- Both these backends already have the data, we just need to use it.
Signed-off-by: Iustin Pop <iustin@google.com>
Rev... - 01:37 pm Revision d25643d1: htools: add DiskTemplate to instance definition
- Currently always fixed to DRBD8, as that is what we assume already.
Signed-off-by: Iustin Pop <iustin@google.com>
Re... - 01:37 pm Revision 3c002a13: htools: add some unittests for Types.hs
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 01:36 pm Revision cc25e437: htools: add a DiskTemplate type
- This will be used later in the Instance type.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trott... - 01:15 pm Revision ca848e2a: htools: small simplification to parseUtilisation
- We eliminate the local variable as it's used only once.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: G... - 01:14 pm Revision 0e09422b: htools: rename Instance.auto_balance
- … to autoBalance, per the recommended style.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotte... - 01:13 pm Revision 34c5a24a: htools: simplify some JSON-related code
- Instead of manually encoding the JSValue(s), we can use showJSON as
long as we use data types that can be auto-conver... - 01:13 pm Revision 7c14b50a: htools: allow different result types
- This patch extends the previous patch changes to allow that each
Cluster function returns a different result type, as... - 01:09 pm Revision d6cf394e: htools: start reorganising the IAllocator workflow
- Currently, all IAllocator requests return the same result type: a list
of strings (usually nodes, but can also be ins... - 01:08 pm Revision 00152519: htools: split more code from hail/main
- The logic of request processing is not separated into its own
function, and (beside CLI interaction, e.g. verbosity h... - 01:05 pm Revision cabce2f4: htools: move code from hail.hs to IAllocator.hs
- This will make it easier to unittest the code, and keeps all login in a
single module.
Signed-off-by: Iustin Pop <iu... - 01:03 pm Revision 4e84ca27: htools: add parsing of input node-evac messages
- This is a lot of duplication with modeMreloc, which will get sorted
out once we convert mreloc to change-group.
Sign... - 01:03 pm Revision 3667467d: htools: remove pre-2.4 compatibility from RAPI
- This was potentially hiding issues in the group query, so let's remove
it since we're now bound to the current Ganeti... - 01:02 pm Revision 1fe412bb: htools: introduce new data type for node-evac
- The evac-mode goes into the Types.hs module since it needs to be
available to Cluster.hs too.
Signed-off-by: Iustin ... - 01:01 pm Revision 525bfb36: htools: docstring fixes and improvements
- No code changes (except one definition being moved around in QC.hs)
are contained in this patch.
Signed-off-by: Iust... - 01:00 pm Revision 606e71d3: Fix some issues in htools apidoc generation
- First, auto-generated files were not processed if HsColour thus the
'source' link in Haddock documentation was dangli... - 01:00 pm Revision 48f12e73: Replace an mkdir -p with @mkdir_p@ in Makefile.am
- Oops, this shouldn't have gone in in the first place…
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Mic... - 01:00 pm Revision 98b33d0e: Exclude auto-generated Haskell code from coverage
- Especially for Ganeti.Constants, which has many declarations, it
doesn't make sense to check for coverage.
Signed-of...
Also available in: Atom