Activity
From 10/20/2011 to 11/18/2011
11/18/2011
- 07:20 pm Revision 7345b69b: htools: adjust imports for newer compilers
- While testing with ghc 7.2, I saw that some imports we are using are
very old (from ghc 6.8 time), even though curren... - 01:48 pm Revision 0e82dcf9: Merge branch 'devel-2.5'
- * devel-2.5: (24 commits)
LUInstanceCreate: Release unused node locks
htools: rework message display construction... - 12:41 pm Revision 0c1441eb: Merge branch 'stable-2.5' into devel-2.5
- * stable-2.5:
htools: rework message display construction
hbal: handle empty node groups
Document OpNodeMigrate... - 12:05 pm Revision 05c2e624: Merge branch 'devel-2.4' into devel-2.5
- * devel-2.4:
Ensure unused ports return to the free port pool
Re-wrap a paragraph to eliminate a sphinx warning
...
11/17/2011
- 05:24 pm Revision bafb5067: Man page update: online/offline state of instance
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 05:24 pm Revision 754cc530: Backwards compatibity - added admin_up to query
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 05:24 pm Revision 555d5304: NEWS update - offline instance state
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:24 pm Revision edc282ad: admin.rst update regarding offline state of the instance
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:49 pm Revision cd8b0072: Add toggle for enabling/disabling confd
- Doesn't do anything yet.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@googl... - 03:49 pm Revision b99d1638: Fix unittest bug related to offline instances
- Currently, the code in Node.hs is overly strict: once a node's free
memory reaches 0, it will refuse to add any insta... - 03:49 pm Revision db3780f9: Prevent runnning of confd tests in burnin
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 03:49 pm Revision aa224134: Adapt watcher for ENABLE_CONFD
- If confd is disabled, do not automatically restart it. Furthermore, we
can't run maintenance actions if it is disable... - 03:49 pm Revision c4e5d11e: Adapt daemon-util to ENABLE_CONFD
- We still allow explicit shutdown of confd, but we prevent manual
or automatic start-up.
Signed-off-by: Iustin Pop <i... - 03:49 pm Revision 10d3f678: Add small node in admin.rst about confd disabling
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 03:49 pm Revision d29036c1: Warn if we enable maintain-node-health without confd
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 03:49 pm Revision 9fc18384: htools: finish re-indenting Cluster.hs
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 03:49 pm Revision ebf38064: htools: reindent the rest of the files
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 03:49 pm Revision d5dfae0a: htools: re-indent QC.hs
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 03:49 pm Revision cd08cfa4: htools: reindent CLI.hs
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 03:49 pm Revision 2ba17362: htools: reindent hbal
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 03:49 pm Revision 3c3690aa: htools: reindent hspace
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 03:49 pm Revision 00dd69a2: htools: re-indent IAlloc.hs
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 03:49 pm Revision fd7a7c73: htools: re-indent Node.hs
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 03:39 pm Revision e8a701f6: masterd: Don't pass mainloop to server class
- It is not used.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:39 pm Revision 27caa993: workerpool: Allow processing of new tasks to be stopped
- This is different from “Quiesce” in the sense that this function just
changes an internal flag and doesn't wait for t... - 03:39 pm Revision 2db05c94: workerpool: Use loop to ignore spurious notifications
- This saves us from returning to the worker code when there is no
task to be processed.
Signed-off-by: Michael Hansel... - 03:39 pm Revision c8d0be94: jqueue: Factorize code checking for drained queue
- This is in preparation for a clean(er) shutdown of masterd.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Re... - 03:31 pm Revision ac2c8bc0: LUInstanceCreate: Release unused node locks
- After iallocator ran we can release any unused node locks. Since they
must be in exclusive mode this should improve p... - 01:04 pm Revision 69f0340a: cmdlib.TLReplaceDisks: Use itertools.count
- … instead of a variable which needs to be incremented for every step.
Signed-off-by: Michael Hanselmann <hansmi@goog...
11/16/2011
- 04:01 pm Revision bdd8c739: htools: rework message display construction
- While diagnosing some (unrelated) memory usage in htools, I've
stumbled upon some very bad behaviour in checkData: ma... - 04:01 pm Revision 2072221f: hbal: handle empty node groups
- This patch changes an internal assert (which can only be triggered
when a node group is empty) into properly handling... - 03:59 pm Revision f23f21c3: Start converting the indentation to 2-chars
- … also do some other small style cleanups.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter ... - 03:16 pm Revision e1bf27bb: htools: Nicer arbitrary instantiation
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:16 pm Revision 61bbbed7: htools: change behaviour for offline instances
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:16 pm Revision 8a8ed513: htools: remove 'running' from instance options
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:15 pm Revision 7dd14211: htools: change runSt type to InstanceStatus
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:15 pm Revision 3771d104: htools: create InstanceStatus ADT
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:15 pm Revision 57de31c0: Transition into and out of offline instance state
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:15 pm Revision 2e04d454: Introduce admin_state as 3-values data type
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:15 pm Revision 9ca8a7c5: Rename admin_up to admin_state
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:15 pm Revision 34598551: Fixed typo in _VerifyResultRow
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 10:41 am Revision 9c709b31: algo: Make a dict from an flat list
- This is in preparation to take deeper dict constructs from the command
line. You can feed the optionslist directly co...
11/15/2011
- 03:50 pm Revision ee2b99e3: locking: Make some aliased methods public
- Some methods, such as “_is_owned” and “list_owned”, have been aliased to
make them public for a while now. This patch... - 03:00 pm Revision 63e6a7f6: cmdlib._ReleaseLock: Do nothing if no locks are owned
- The locking library doesn't like it when “release()” is called on
a lockset or lock which isn't held by the current t... - 11:52 am Revision 4d4eae2a: Use resource lock when setting node parameters
- Also acquire instance and resource locks in shared mode (see comment).
Signed-off-by: Michael Hanselmann <hansmi@goo... - 11:52 am Revision 42828156: Use node resource lock for replacing instance disks
- If early-release is not used, the resource lock is kept while waiting
for disks to sync.
Signed-off-by: Michael Hans... - 11:52 am Revision 63742d78: Hold node resource locks while setting instance parameters
- Important for when disks are converted. Release locks once they're not
needed anymore. Make liberal use of assertions... - 11:52 am Revision c57add7e: Hold node resource lock while moving instance
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:51 am Revision d3986702: Acquire node resource lock when removing instance
- Removing an instance affects available disk space and memory.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
... - 11:51 am Revision 6a752efc: Use node resource lock when recreating instance disks
- Recreating disks conflicts with other disk operations, therefore the
node resource lock must be acquired.
Signed-off... - 11:51 am Revision a4e588b7: LUClusterRepairDiskSizes: Use node resource locks
- Since this doesn't really touch the node, but it conflicts with e.g.
growing a disk, the resource lock must be acquir... - 11:51 am Revision 0c3c965a: LUInstanceGrowDisk: Use node resource lock
- Also add one more feedback line. Downgrade instance lock to shared mode
while we're only waiting for disks to sync. T... - 11:51 am Revision eaee9e3b: LUInstanceCreate: Hold node resource lock
- The node resource lock is released once the disks are in sync (that is,
after wiping).
Signed-off-by: Michael Hansel... - 11:19 am Revision d9d9e0d9: LUNodeQueryvols: Acquire all locks in shared mode
- Nothing is being written to.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@g... - 11:19 am Revision efcb184e: LUNodeQueryStorage: Acquire all locks in shared mode
- Nothing is written to.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.... - 11:19 am Revision aefb66c0: cmdlib: Share lock in LUInstanceConsole
- No writes are being done.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@goog... - 08:13 am Revision 65c9591c: Document OpNodeMigrate's result for RAPI
- - Commit b7a1c8161 changed the LU to generate jobs
- Mention documented results in NEWS
Signed-off-by: Michael Hanse... - 08:13 am Revision d1ad741e: LUNodeQuery: Call implementation's DeclareLocks function
- Just in case we ever add locks for querying nodes. Currently
_NodeQuery's DeclareLocks is a no-op function.
Signed-o...
11/14/2011
- 05:18 pm Revision 702eff21: Use master IP address setup script in backend
- Replace the code in backend.ActivateMasterIp and
backend.DeactivateMasterIp with the master IP address setup script,
... - 05:18 pm Revision 57c7bc57: Change master IP address RPCs for external script
- Change the master IP address RPC call chain to accept the
use_external_master_ip_script parameter. Introduces an unus... - 05:18 pm Revision 17b0b812: Update cluster verify to check IP address scripts
- Update cluster-verify to check the integrity of the default master IP
address setup script and the presence and execu... - 05:18 pm Revision bf689b7a: Add --use-external-mip-script flag
- - add a command line flag to gnt-cluster init and modify to change the
value of the cluster parameter use_external_... - 05:17 pm Revision 33be7576: Add use_external_mip_script cluster parameter
- Add the use_external_mip_script cluster parameter, that represents
whether the master IP address turnup/turndown proc... - 05:17 pm Revision d9eefcfa: Add the default master-ip-setup script
- Add a shell script that will be the default replacement for the body of
backend.ActivateMasterIp and backend.Deactiva... - 11:03 am Revision f396ad8c: Ensure unused ports return to the free port pool
- Ensure ports previously allocated by calling ConfigWriter's AllocatePort() are
returned to the pool of free ports whe... - 11:03 am Revision ca8f5622: Re-wrap a paragraph to eliminate a sphinx warning
- This just makes sure that the paragraph doesn't contains lines that
start with :, which make Sphinx (1.0.7) complain.... - 08:23 am Revision db859c7d: check-python-code: Detect old-style pylint disable-msg lines
- Commit b459a848d was supposed to replace all, but one was missed. Add a
check to autotools/check-python-code.
Signed...
11/10/2011
- 03:50 pm Revision 1dd64393: Fix newer pylint's E0611 error in compat.py
- These are triggered by our "stay-compatible" approach.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-... - 12:23 pm Revision 5b49ed09: Adding basic elements for the new node params
- This patch adds the new fields to the objects.py as well as defines the
constants used in the dicts and their type.
...
11/08/2011
- 07:31 pm Revision 82cce526: rpc: Fix another result processor
- I forgot to change this in commit d9da5065c0.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Ius... - 05:44 pm Revision f68cc544: rpc: Fix issue with “test_delay”'s timeout
- I passed the timeout calculation function in the wrong field of the
definition. A small change is also needed in “bui... - 05:44 pm Revision d9da5065: rpc: Call result processor once for each node result
- … instead of calling it with the whole results dictionary. This
fixes an issue when replacing disks (and all other ca... - 04:06 pm Revision d755483c: Fail if node/group evacuation can't evacuate instances
- If an instance can't be evacuated, only a message would be printed. With
this change the operation always aborts. New...
11/07/2011
- 07:32 pm Revision cc19798f: LUNodeSetParams: Lock affected instances only
- Until now LUNodeSetParams would lock all instances if a node's
secondary IP address was to be changed and would then ... - 07:32 pm Revision 212a7fcd: Check BGL when adding/removing node
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 07:15 pm Revision f7d9b3aa: RPC/test_delay: Use callable for timeout calculation
- This avoids having to override the function in the RPC runner.
Signed-off-by: Michael Hanselmann <hansmi@google.com>... - 07:15 pm Revision 26d502d0: rpc: Move post-processor functions into definitions file
- This way the generated code no longer contains arbitrary code.
Post-processing functions are used by reference.
Sign... - 07:14 pm Revision 702abcf9: rpc: Use definitions directly instead of via generated code
- Until now “autotools/build-rpc” would read the definition of all RPCs
and write them to a new file, “lib/_generated_r... - 07:01 pm Revision a09f9847: Convert RPC definitions to dictionaries
- This is in preparation to reducing the amount of generated code.
Signed-off-by: Michael Hanselmann <hansmi@google.co... - 07:01 pm Revision 320e34df: query: Use new SequenceToDict utility
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 04:32 pm Revision 9e6014b9: Improve error handling in netmask change
- - check if the master IP with the old netmask is up before attempting to
change the netmask (to avoid a failed chan...
11/04/2011
- 06:07 pm Revision 0007f3ab: Add master_netmask to Cluster.UpgradeConfig
- And also suppress pylint R0902 error about an object instance having
more than 20 attributes.
Signed-off-by: Andrea ... - 05:06 pm Revision 45e22998: Update init script description
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Andrea Spadaccini <spadaccio@google.com> - 04:22 pm Revision 186c03b3: Fix cluster start failure due to missing netmask
- If the cluster version is upgraded from a version before commit
5a8648eb609f7e3a8d7ad7f82e93cfdd467a8fb5 to a version... - 02:21 pm Revision d24303b3: ganeti(7): Adding documentation about env variables
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 11:19 am Revision fb2865ae: LUInstanceRename: Compare name with name
- … instead of object with name.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <r... - 08:09 am Revision 6d0accae: utils.algo: Add utility to convert sequence to dictionary
- Useful for converting list of query fields to a dictionary and to
convert RPC definitions. Includes duplicate detecti... - 08:09 am Revision 5a85b99e: Add QA test for “gnt-debug delay”
- This would have caught a bug introduced with the recent RPC changes.
Signed-off-by: Michael Hanselmann <hansmi@googl... - 08:09 am Revision 52808305: rpc: Make “test_delay” RPC actually work
- Until now it would just call itself, eventually failing.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Revie... - 08:08 am Revision cdde200a: LUClusterRepairDiskSizes: Acquire instance locks in exclusive mode
- Instances are modified if their disk size doesn't match.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Revie...
11/03/2011
- 06:47 pm Revision 620fb907: QA: Add test for setting node's secondary IP address
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Andrea Spadaccini <spadaccio@google.com> - 06:39 pm Revision 1986b21f: cmdlib: Allow specifying lock level when calculating node locks
- This is needed to lock node resources.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trot... - 06:30 pm Revision b2acdbdc: Show RPC calls from config in lock monitor
- With this patch all RPC calls at runtime of masterd will show up in the
lock monitor. There is a chicken-and-egg issu... - 06:23 pm Revision eb5ac108: Update synopsis for “gnt-cluster repair-disk-sizes”
- Mention that instances can be passed on the CLI when “--help” is used.
Signed-off-by: Michael Hanselmann <hansmi@goo... - 04:39 pm Revision 3ccd3243: Derive IP hooks env variables from RPC parameter
- Let the environment variables of the master IP turnup/turndown be
derived from the parameter of the RPC itself (that ... - 04:39 pm Revision c79198a0: Pass MasterNetworkParameters instances in RPCs
- Pass instances of objects.MasterNetworkParameters when calling RPCs for
activation and deactivation of master IP.
Si... - 04:39 pm Revision f9d20654: Use MasterNetworkParameters attributes for RPC
- Instead of manually unpacking the return values of
cfg.GetMasterNetworkParameters, let it return an instance of
objec... - 04:39 pm Revision 061af273: Add object representing the master network params
- Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 04:39 pm Revision 91ae95fd: Uniform master IP activation and deactivation
- Add the master IP family parameter to the master IP deactivation RPCs,
so that the activation and deactivation interf...
11/02/2011
- 05:28 pm Revision ef9fa5b9: Make it possible to pass in flags using ENV variables
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 05:28 pm Revision d60946d9: utils.algo: Add a function to insert a list into a list
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 04:36 pm Revision 3f006be3: Fix pylint deprecated directive in check-header
- Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 03:36 pm Revision 95a39a77: Fix overriding of ActivateMasterIp params
- In the process of reworking the patches for master, I forgot to remove a
call to GetMasterInfo() that overrides the p... - 03:18 pm Revision 3a3e4f1e: Add netmask and IP version to master IP hooks env
- Add the master netmask and master IP version parameters to the hooks and
document them. In this way, the hook environ... - 03:03 pm Revision 8da2bd43: Explicitly pass params to activate_master_ip
- To remove the usage of ssconf in the backend, the master needs to push
the parameters of activate_master_ip to the ba... - 03:03 pm Revision 41e079ce: Explicitly pass params to change_master_netmask
- Make the master explicitly pass the parameters to the
change_master_netmask RPC, and change all the call flow to use ... - 03:03 pm Revision 96e0d5cc: Explicitly pass params to deactivate_master_ip
- Make the master explicitly pass the parameters to the
deactivate_master_ip RPC, and change all the call flow to use t... - 03:03 pm Revision 7c74bbe0: Change the semantics of stop_master RPC
- To avoid polluting the stop_master RPC interface with network
parameters, this patch removes the deactivation of the ... - 02:54 pm Revision 5d7a899e: locking: Make level names consistent, add check
- - Change all lock level names to their singular form
- Add assertion checking consistency between level names and loc... - 02:54 pm Revision 4e070776: Add new lock level for node resource modifications
- This is in preparation for implementing a new resource model.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
... - 02:22 pm Revision 5d3c30df: Add tool to check Python file headers
- Ensures licence and copyright headers are correct.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by... - 12:46 pm Revision fe5ca2bb: Move hooks PATH environment variable to constants
- Move the contents of the PATH environment variable for hooks to
constants, and use its value in the code and in the h...
11/01/2011
- 09:21 pm Revision 2a6de57a: Check the results of master IP RPCs
- A failed gnt-cluster (de)activate-master-ip would not produce any output
to the user. This patch adds code that check... - 09:09 pm Revision 3738b8d6: Add documentation for the master IP hooks
- Reviewed-by: Michael Hanselmann <hansmi@google.com>
Signed-off-by: Andrea Spadaccini <spadaccio@google.com> - 09:09 pm Revision 28aedbc1: Add master IP turnup and turndown hooks
- Reviewed-by: Michael Hanselmann <hansmi@google.com>
Signed-off-by: Andrea Spadaccini <spadaccio@google.com> - 09:09 pm Revision 20d38e8a: Add RunLocalHooks decorator
- Add the RunLocalHooks decorator, that allows the execution of hooks
locally. Also, add a RunLocalHooks method to Hook... - 09:07 pm Revision da124e89: Generalize HooksMaster
- - remove any dependence on Logical Units from the HooksMaster;
- add a new function parameter to the constructor, a f... - 08:37 pm Revision 769582be: Add documentation for the master IP hooks
- Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 08:37 pm Revision 2d88fdd3: Add master IP turnup and turndown hooks
- Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 08:37 pm Revision 0fa481f5: Add RunLocalHooks decorator
- Add the RunLocalHooks decorator, that allows the execution of hooks
locally. Also, add a RunLocalHooks method to Hook... - 08:37 pm Revision 949dcb1d: Generalize HooksMaster
- - remove any dependence on Logical Units from the HooksMaster;
- add a new function parameter to the constructor, a f... - 06:01 pm Revision 8e709b21: RAPI: Fix issue when replacing disks
- This is another fallout from a suboptimal merge.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: ... - 05:17 pm Revision cd40dc53: rpc: Improve argument definitions
- Instead of in-place code now each argument has an (optional) kind
assigned. The RPC client will then take care of enc... - 05:17 pm Revision b8c160c1: rpc: Change {import,export}_start to take source/dest in single argument
- This simplifies the RPC argument encoding code.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: R... - 05:17 pm Revision 6648cb36: Rename lib/build/rpc_definitions.py to lib/rpc_defs.py
- It will also be used at runtime, not just for building.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Review... - 03:19 pm Revision 0f03d8d4: Clean up incorrect merge 7dcf333d
- The unittests weren't corrected for the master branch.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewe...
10/31/2011
- 05:54 pm Revision 7dcf333d: Merge branch 'devel-2.5'
- * devel-2.5:
Fix wrong headers and licences
Update NEWS and increase to 2.4.5
Fix parameters of RpcResult in ho... - 04:36 pm Revision fd7b69c0: Fix wrong headers and licences
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Stephen Shirley <diamond@google.com>
10/28/2011
- 05:34 pm Revision e3ac8406: Add missing get_migration_status RPC definition
- Add the instance_get_migration_status RPC definition and the needed
helper.
Signed-off-by: Andrea Spadaccini <spadac... - 05:34 pm Revision 7e5a72a0: cmdlib: Fix issue when marking node as online
- When a node is marked as online (“gnt-node modify -O no …”), an RPC is
made to the node to check whether the node dae... - 12:34 pm Revision c9f4b8e6: Add shortcut for network-related cluster params
- Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 12:34 pm Revision 714ff97c: Use GetClassFromIpFamily in ActivateMasterIp
- Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
10/27/2011
- 09:52 pm Revision 0d1e78dd: rpc: Remove leftovers from timeout table
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 09:52 pm Revision ee14d800: config: Add unlocked function to get all node objects
- This will be used for resolving node names.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iusti... - 07:03 pm Revision 95440548: Update NEWS for 2.5.0~rc4
- I forgot this in the previous patch.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Andrea Spada... - 04:52 pm Revision 7b612b95: Bump version to 2.5.0~rc4
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 04:47 pm Revision dd228197: Merge branch 'stable-2.4' into stable-2.5
- * stable-2.4:
Update NEWS and increase to 2.4.5
Conflicts:
configure.ac: Trivial
Signed-off-by: Michael Hanselma... - 04:33 pm Revision 0f51bc8d: Merge branch 'devel-2.4' into devel-2.5
- Conflicts:
configure.ac (trivial)
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <h... - 04:26 pm Revision 719f8fba: jqueue: Allow zero jobs to be submitted at once
- If cmdlib.LUNodeMigrate was called for a node without primary instances
it would try to submit an empty list of jobs.... - 04:05 pm Revision 7b790a6a: Update NEWS and increase to 2.4.5
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 12:31 pm Revision 3fc210de: Fix parameters of RpcResult in hooks unit tests
- In FakeHooksRpcSuccess, the data parameter of the RpcResult constructor
was not enclosed in a tuple. While this does ...
10/26/2011
- 06:13 pm Revision 5c3ee7b2: Fix RPC unittest
- Add missing “read_timeout” value.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <ius... - 05:35 pm Revision 5f828ce4: Generalize the generation of ADT from raw types
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:35 pm Revision 260d0bda: Luxi support for Query status in htools
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:59 pm Revision 07abe80a: hail: don't select the primary as new secondary
- This just adds the primary node of the instance as 'non-allocable'
during the choosing of the new secondary.
Signed-... - 12:59 pm Revision e0baa26f: hail: add an extra safety check in relocate
- If we select the primary as new secondary, better to fail than return
wrong data to Ganeti.
Signed-off-by: Iustin Po... - 12:06 pm Revision b355affb: Fix a too long line.
- That's what you get for not running make lint :(
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin ... - 11:53 am Revision 4fbe3851: rpc: Remove _Static* and other unused functions
- These are no longer needed.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@go... - 11:53 am Revision 415a7304: rpc: Convert last two calls to generated code
- These two calls, “upload_file” and “write_ssconf_files” are treated
separated as they're used by the configuration, w... - 11:53 am Revision 68959ca5: rpc: Convert call for HV parameter validation
- Instead of filling the parameters in the RPC layer, that is now done
before the wrapper is called, thereby simplifyin... - 11:53 am Revision c4de9b7a: rpc: Convert two more instance-specific calls
- Interface changes were necessary as these took more parameters than were
actually passed over the wire. Those paramet... - 11:53 am Revision db04ce5d: Move bootstrap-related RPC to generated wrappers
- With this patch, only 6 RPC are left as old-style code.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Review... - 11:53 am Revision fb1ffbca: Convert job queue's RPC to generated code
- With these changes job queue RPC will finally show up on the lock
monitor. See below for an example. A job queue-spec... - 11:53 am Revision 46c293f0: rpc: Convert wrappers for starting import/export daemons
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:53 am Revision f69b367e: rpc: Convert storage-related calls
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:53 am Revision e437117f: rpc: Convert blockdev-related calls
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:53 am Revision 2effde8d: rpc: Convert instance-related calls
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:53 am Revision 0436da49: rpc: Convert misc calls
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:53 am Revision 83816869: rpc: Convert file-storage-related calls
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:53 am Revision d6cf4107: rpc: Convert node-related calls
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:53 am Revision 4522a96d: rpc: Convert OS-related calls
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:53 am Revision 54498047: rpc: Convert X509 calls
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:52 am Revision 9834e2bc: rpc: Convert import/export functions
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:51 am Revision efc71a02: rpc: Add helpers
- These will be used by the generated RPC wrappers.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by:... - 11:51 am Revision 200de241: rpc: Add support for generated RPC wrappers
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 11:51 am Revision 033684dd: Add RPC definitions
- These will be used for replacing the tons and tons of boilerplate code
in rpc.py.
Signed-off-by: Michael Hanselmann ... - 11:51 am Revision d565f83f: rpc_definitions: Add helpers
- These helpers will be used to convert incoming parameters to
JSON-compatible types.
Signed-off-by: Michael Hanselman... - 11:51 am Revision 83e7af18: rpc: Disable timeout check
- This is in preparation for the definition-based RPC model, where
the timeout will be stored within the definition.
S... - 11:51 am Revision d5a2a550: Add script to generate RPC wrappers
- A new script, “autotools/build-rpc”, will be used to generate code for
RPC client wrappers. This is done because “lib... - 11:42 am Revision 9c2b3a70: Move RenameFile to the new functions
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 11:42 am Revision b81b3c96: ensure_dirs: Move some useful functions into utils.
- With this change we can easily reuse this functionality where it makes
sense on other parts of Ganeti.
Signed-off-by... - 10:24 am Revision 0469fd96: Small resource model design update re console
- Starting with Ganeti 2.5 the console uses a query and no longer acquires
locks. See commit d6f46b6a94.
Signed-off-by... - 10:19 am Revision f39d39b6: Bump version to 2.5.0~rc3
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 10:06 am Revision 59da826f: cmdlib: Use constant for DRBD meta device size
- … instead of a hardcoded value.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iusti...
10/25/2011
- 05:05 pm Revision af5af644: Use JoinDisjointDicts in mcpu
- Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 05:05 pm Revision cdf71b12: Add the JoinDisjointDicts function to utils.algo
- Add a function that joins two dictionaries, enforcing the constraint
that the two key sets should be disjoint. Also, ...
10/24/2011
- 08:02 pm Revision 8a31717c: Fix parameters to RPC "blockdev_rename"
- Before this patch it would take a variable number of arguments, which
isn't very good for a definition-based approach... - 08:02 pm Revision c5a8b0eb: Fix parameters to RPC "os_validate"
- All other RPC wrappers take the node name(s) as the first parameter.
Signed-off-by: Michael Hanselmann <hansmi@googl... - 03:50 pm Revision 5fe4a65b: Un-revert comments in utils.mlock
- These updates and clarifications are still useful.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by... - 03:50 pm Revision ee8fd7b7: Remove “node_tcp_ping” RPC
- It is not used anywhere.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@googl... - 03:49 pm Revision dce20078: utils.ShellWriter: Don't indent empty lines
- Empty lines shouldn't get indented. Unittest included.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewe...
10/21/2011
- 04:16 pm Revision 97298dc9: Merge branch 'stable-2.5' into devel-2.5
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 04:00 pm Revision 833391a0: Merge branch 'devel-2.4' into stable-2.5
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 01:58 pm Revision bac6ea51: http.client: Remove use of PycURL's “reset” function
- We don't re-use cURL objects anymore, so there's no need to reset them.
PycURL 7.19.0 has a reference counting bug le... - 01:58 pm Revision 4fd2660d: Add unittest for PycURL 7.19.0's reset issue
- While we won't use this function in Ganeti (yet), users should be aware
of the potential crashes caused by this funct...
10/20/2011
- 06:21 pm Revision e68949b0: ovfconverter: use qemu-img path from constants
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 04:30 pm Revision 73ebb9ff: Merge branch 'devel-2.5'
- * devel-2.5:
Allow per-hypervisor optional files
Add hypervisors ancillary files list
xen: abstract a few hardc... - 03:43 pm Revision 8e5a705d: Fix queue archive creation with wrong permissions
- On a master failover some of the archive dirs might have wrong
permissions in the non-root model. This is due to the ... - 03:14 pm Revision 487895ed: Fix for buildbot pylint failure
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:04 pm Revision 0ad1ea40: Allow per-hypervisor optional files
- Rather than just allowing files for all nodes to be optional, we allow
optional files to be per-category. The way thi... - 03:04 pm Revision 69ab2e12: Add hypervisors ancillary files list
- These lists will be used to declare some of the files not necessarily
needed on all nodes. The files selected are fil... - 03:04 pm Revision 22d568c2: xen: abstract a few hardcoded strings as constants
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:25 pm Revision a002ed79: Check for qemu-img in configure and Makefile
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
Reviewed-b... - 01:14 pm Revision b3ed0d9a: configure: fix for two version of QuickCheck present
- Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:32 pm Revision da4fd3b0: Upload spice files in redist-conf
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:22 pm Revision 8dc76d54: Revert "Rename utils.mlock to utils.cfunc"
- The rename is not needed either, since we're not adding more code as of
now.
This reverts commit 57ca011e1cd268194896... - 12:22 pm Revision 142c1ad0: Revert "utils.cfunc: Cleanup, more flexibility"
- We discussed that this is not needed right now, and it breaks existing
functionality and unittests.
This reverts com... - 11:58 am Revision d6f8db24: Fix unittest failures with python 2.7
- In python 2.7 the ovf unittests fail because OVFReader expects
ElementTree.parse() of an erroneous document to throw ...
Also available in: Atom