Activity

From 11/01/2011 to 11/30/2011

11/30/2011

03:52 pm Revision ff3be305: Fix “node_info” RPC result
Commit 78519c106 broke everything. Here's the fix.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by...
Michael Hanselmann
03:18 pm Revision fbd55434: Fix race condition in test for *FileID functions
In this test the “file ID” of a temporary file is compared against the
file ID gathered via an open file descriptor t...
Michael Hanselmann
01:57 pm Revision 54ac87c0: query: Add fields for node's disk/hv state
These fields just return the node attribute's contents. They will be
used by the watcher to detect out of date node s...
Michael Hanselmann
01:57 pm Revision 16ca6243: hv_xen: Report memory used by hypervisor
- Report memory used by hypervisor (“mem_hv” as per resource model
design document, “xmem” in htools)
- Also report...
Michael Hanselmann
01:57 pm Revision 1d60fec6: hv_xen: Export number of CPUs for Dom0
This will be stored in the node object and used for calculations.
Signed-off-by: Michael Hanselmann <hansmi@google.c...
Michael Hanselmann
01:57 pm Revision 5f06ce5e: Add objects for disk/hv state
- Data objects
- Serialization/deserialization
- Unittests
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Rev...
Michael Hanselmann
12:28 pm Revision 634d30f4: objects.Node: Add static hv/disk state
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Michael Hanselmann
12:28 pm Revision 18bf85b1: hv_xen: Use constant for “Domain-0” name
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Michael Hanselmann
12:26 pm Revision 78519c10: Change “node_info” RPC to accept multiple VGs/hypervisors
Keeping the node state up to date will require information from multiple
VGs and hypervisors. Instead of requiring mu...
Michael Hanselmann
12:16 pm Revision c6a622cf: locking: Allow checking if lock is owned in certain mode
With this patch the “LockSet” and “GanetiLockManager” classes have a new
function to check if a single or a group of ...
Michael Hanselmann
12:11 pm Revision b39d17b1: Add UnescapeAndSplit unittest for multi-escapes
This would have caught the bug in the first place. Argh,
hand-generated test cases!
Signed-off-by: Iustin Pop <iusti...
Iustin Pop
11:37 am Revision 997f690f: Fix a bug in command line option parsing code
Fix bug affecting command line options of "keyval" type. Although
escaping commands with \ is supported, it is is not...
Nikos Skalkotos

11/24/2011

04:11 pm Revision c1ef933c: Merge branch 'devel-2.5'
* devel-2.5:
ConfigWriter: Fix epydoc error
ConfigWriter: Fix epydoc error
Signed-off-by: Michael Hanselmann <ha...
Michael Hanselmann
03:59 pm Revision 53f75d02: Merge branch 'devel-2.4' into devel-2.5
* devel-2.4:
ConfigWriter: Fix epydoc error
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Ren...
Michael Hanselmann
02:22 pm Revision 1df43aa3: Merge branch 'stable-2.5' into devel-2.5
* stable-2.5:
ConfigWriter: Fix epydoc error
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: An...
Michael Hanselmann
02:11 pm Revision 1d4930b9: ConfigWriter: Fix epydoc error
The parameter is called “mods”, not “modes”.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Andr...
Michael Hanselmann
02:07 pm Revision 1730d4a1: ConfigWriter: Fix epydoc error
The parameter is called “mods”, not “modes”.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Andr...
Michael Hanselmann
12:31 pm Revision 75191077: Merge branch 'devel-2.5'
* devel-2.5:
LUGroupAssignNodes: Fix node membership corruption
LUGroupAssignNodes: Fix node membership corruptio...
Michael Hanselmann
11:50 am Revision a0d39c8f: Merge branch 'devel-2.4' into devel-2.5
* devel-2.4:
LUGroupAssignNodes: Fix node membership corruption
Signed-off-by: Michael Hanselmann <hansmi@google.c...
Michael Hanselmann
11:04 am Revision 2b9245ff: Merge branch 'stable-2.5' into devel-2.5
* stable-2.5:
LUGroupAssignNodes: Fix node membership corruption
Fix pylint warning on unreachable code
LUNodeE...
Michael Hanselmann
10:39 am Revision 54c31fd3: LUGroupAssignNodes: Fix node membership corruption
Note: This bug only manifests itself in Ganeti 2.5, but since the
problematic code also exists in 2.4, I decided to f...
Michael Hanselmann
10:32 am Revision 218f4c3d: LUGroupAssignNodes: Fix node membership corruption
Note: This bug only manifests itself in Ganeti 2.5, but since the
problematic code also exists in 2.4, I decided to f...
Michael Hanselmann
10:32 am Revision 9c4f4dd6: Fix pylint warning on unreachable code
Commit c50452c3186 added an exception when all instances should be
evacuated off a node, but did so in a way which ma...
Michael Hanselmann

11/23/2011

03:25 pm Revision c50452c3: LUNodeEvacuate: Disallow migrating all instances at once
There is a design issue in the iallocator interface which prevents us
from doing this.
Signed-off-by: Michael Hansel...
Michael Hanselmann
03:03 pm Revision cb92e7a1: Separate OpNodeEvacuate.mode from iallocator
Until now the iallocator constants for node evacuation
(IALLOCATOR_NEVAC_*) were also used for the opcode. However, i...
Michael Hanselmann
03:03 pm Revision 50722bfd: LUNodeEvacuate: Locking fixes
When evacuating a node, only an assertion without informative text was
used to check if the necessary node locks had ...
Michael Hanselmann
11:51 am Revision d05326fc: Fix error when removing node
ConfigWriter.GetAllInstancesInfo returns a dictionary, not a list.
Removing a node would fail with “too many values t...
Michael Hanselmann

11/22/2011

07:55 pm Revision 8ccbbe4b: qa: use maximum and minimum memory
test modification of either parameter, but also both at once.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Re...
Guido Trotter
07:55 pm Revision 63c55458: cmdlib: use MAXMEM for all operations
Since for now we can only start instances at their maximum memory, we
modify all checks to use that value. When we'll...
Guido Trotter
07:55 pm Revision 861610e9: unittests: use max/min memory
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Guido Trotter
07:55 pm Revision 37036867: burnin: use mem_size as max and min
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Guido Trotter
07:55 pm Revision b2e233a5: Remove BE_MEMORY from beparams but keep compatibility
Queries are already compatible (be/memory is an alias for be/maxmem) and
import/exports work. This patch patch fixes ...
Guido Trotter
07:55 pm Revision 2e1a6024: constants: reindent a few dicts
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Guido Trotter
07:55 pm Revision 90bb3fe1: manpages: update beparams explanations
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Guido Trotter
04:53 pm Revision f5a4b9ce: hypervisors: use maximum memory for all operations
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Guido Trotter
04:53 pm Revision 1db993d5: ImportExport: use max and min memory params
Import uses the old "memory" parameter to populate the two new ones, if
they're not overridden already.
FinalizeExpo...
Guido Trotter
04:52 pm Revision 31d1791a: Query: allow query on maximum and minimum memory
be/memory is kept as an alias.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@g...
Guido Trotter
04:52 pm Revision b5ef2316: ShowInstanceConfig: show max and min memory
The old "memory" value is kept as maxmem, for now, for
retrocompatibility.
Signed-off-by: Guido Trotter <ultrotter@g...
Guido Trotter
04:52 pm Revision 3fa222b4: instance hooks: pass maximum and minimum memory
Also pass the "memory" value for retrocompatibility, for now.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Re...
Guido Trotter
04:52 pm Revision 8c72ab2b: beparams: add min/max memory values
For now the new "memory" parameter stays there, but it will be removed
later. The new values are just taken from the ...
Guido Trotter

11/21/2011

12:54 pm Revision 5d40c988: design-resource-model: update disk params section
Simplify design by moving all the parameters to disk template level,
explaining why this is sub-optimal. Add notes ab...
Andrea Spadaccini
12:04 pm Revision d529599f: Set DRBD sync speed in DRBD8.Assemble
Instead of relying on clients of the class for setting the device speed
(and, in general, the DRBD parameters), move ...
Andrea Spadaccini
11:59 am Revision 99cafe0f: build-rpc: Fail if call is defined more than once
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
11:52 am Revision edea391e: Reapply commit 2a6de57 after merge
In the last merge I erroneously discarded the changes introduced by
commit 2a6de57 "Check the results of master IP RP...
Andrea Spadaccini
10:45 am Revision f73e5568: Fix QA breakage caused by merge 0e82dcf9
Patch tested and confirmed to work by Andrea Spadaccini
<spadaccio@google.com>.
Signed-off-by: Michael Hanselmann <h...
Michael Hanselmann
09:36 am Revision 2d6b5414: daemon: Support clean daemon shutdown
Instead of aborting the main loop as soon as a fatal signal (SIGTERM or
SIGINT) is received, additional logic allows ...
Michael Hanselmann
09:36 am Revision cb4d3314: masterd: Initialize job queue only after RPC client
Otherwise jobs started after an unclean master shutdown will fail as
they depend on the RPC client.
Signed-off-by: M...
Michael Hanselmann
09:36 am Revision 5483fd73: masterd: Shutdown only once running jobs have been processed
Until now, if masterd received a fatal signal, it would start shutting
down immediately. In the meantime it would han...
Michael Hanselmann
09:36 am Revision e0545ee9: daemon: Use counter instead of boolean for mainloop abortion
Also log a message when a fatal signal was received and use dict.items.
Signed-off-by: Michael Hanselmann <hansmi@go...
Michael Hanselmann
09:36 am Revision ef52306a: workerpool: Export function to check for running tasks
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
09:36 am Revision 6d5ea385: jqueue: Add code to prepare for queue shutdown
Doing so will prevent job submissions (similar to a drained queue),
but won't affect currently running jobs. No furth...
Michael Hanselmann
09:36 am Revision f5acf5d9: daemon: Allow custom maximum timeout for scheduler
This is needed in case the scheduler user (daemon.Mainloop in this case)
has other timeouts at the same time. Needed ...
Michael Hanselmann

11/18/2011

07:20 pm Revision 7345b69b: htools: adjust imports for newer compilers
While testing with ghc 7.2, I saw that some imports we are using are
very old (from ghc 6.8 time), even though curren...
Iustin Pop
01:48 pm Revision 0e82dcf9: Merge branch 'devel-2.5'
* devel-2.5: (24 commits)
LUInstanceCreate: Release unused node locks
htools: rework message display construction...
Andrea Spadaccini
12:41 pm Revision 0c1441eb: Merge branch 'stable-2.5' into devel-2.5
* stable-2.5:
htools: rework message display construction
hbal: handle empty node groups
Document OpNodeMigrate...
Michael Hanselmann
12:05 pm Revision 05c2e624: Merge branch 'devel-2.4' into devel-2.5
* devel-2.4:
Ensure unused ports return to the free port pool
Re-wrap a paragraph to eliminate a sphinx warning
...
Michael Hanselmann

11/17/2011

05:24 pm Revision bafb5067: Man page update: online/offline state of instance
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Agata Murawska
05:24 pm Revision 754cc530: Backwards compatibity - added admin_up to query
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Agata Murawska
05:24 pm Revision 555d5304: NEWS update - offline instance state
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Agata Murawska
05:24 pm Revision edc282ad: admin.rst update regarding offline state of the instance
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Agata Murawska
03:49 pm Revision cd8b0072: Add toggle for enabling/disabling confd
Doesn't do anything yet.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@googl...
Iustin Pop
03:49 pm Revision b99d1638: Fix unittest bug related to offline instances
Currently, the code in Node.hs is overly strict: once a node's free
memory reaches 0, it will refuse to add any insta...
Iustin Pop
03:49 pm Revision db3780f9: Prevent runnning of confd tests in burnin
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
03:49 pm Revision aa224134: Adapt watcher for ENABLE_CONFD
If confd is disabled, do not automatically restart it. Furthermore, we
can't run maintenance actions if it is disable...
Iustin Pop
03:49 pm Revision c4e5d11e: Adapt daemon-util to ENABLE_CONFD
We still allow explicit shutdown of confd, but we prevent manual
or automatic start-up.
Signed-off-by: Iustin Pop <i...
Iustin Pop
03:49 pm Revision 10d3f678: Add small node in admin.rst about confd disabling
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
03:49 pm Revision d29036c1: Warn if we enable maintain-node-health without confd
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
03:49 pm Revision 9fc18384: htools: finish re-indenting Cluster.hs
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
03:49 pm Revision ebf38064: htools: reindent the rest of the files
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
03:49 pm Revision d5dfae0a: htools: re-indent QC.hs
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
03:49 pm Revision cd08cfa4: htools: reindent CLI.hs
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
03:49 pm Revision 2ba17362: htools: reindent hbal
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
03:49 pm Revision 3c3690aa: htools: reindent hspace
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
03:49 pm Revision 00dd69a2: htools: re-indent IAlloc.hs
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
03:49 pm Revision fd7a7c73: htools: re-indent Node.hs
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
03:39 pm Revision e8a701f6: masterd: Don't pass mainloop to server class
It is not used.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
03:39 pm Revision 27caa993: workerpool: Allow processing of new tasks to be stopped
This is different from “Quiesce” in the sense that this function just
changes an internal flag and doesn't wait for t...
Michael Hanselmann
03:39 pm Revision 2db05c94: workerpool: Use loop to ignore spurious notifications
This saves us from returning to the worker code when there is no
task to be processed.
Signed-off-by: Michael Hansel...
Michael Hanselmann
03:39 pm Revision c8d0be94: jqueue: Factorize code checking for drained queue
This is in preparation for a clean(er) shutdown of masterd.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Re...
Michael Hanselmann
03:31 pm Revision ac2c8bc0: LUInstanceCreate: Release unused node locks
After iallocator ran we can release any unused node locks. Since they
must be in exclusive mode this should improve p...
Michael Hanselmann
01:04 pm Revision 69f0340a: cmdlib.TLReplaceDisks: Use itertools.count
… instead of a variable which needs to be incremented for every step.
Signed-off-by: Michael Hanselmann <hansmi@goog...
Michael Hanselmann

11/16/2011

04:01 pm Revision bdd8c739: htools: rework message display construction
While diagnosing some (unrelated) memory usage in htools, I've
stumbled upon some very bad behaviour in checkData: ma...
Iustin Pop
04:01 pm Revision 2072221f: hbal: handle empty node groups
This patch changes an internal assert (which can only be triggered
when a node group is empty) into properly handling...
Iustin Pop
03:59 pm Revision f23f21c3: Start converting the indentation to 2-chars
… also do some other small style cleanups.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter ...
Iustin Pop
03:16 pm Revision e1bf27bb: htools: Nicer arbitrary instantiation
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Agata Murawska
03:16 pm Revision 61bbbed7: htools: change behaviour for offline instances
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Agata Murawska
03:16 pm Revision 8a8ed513: htools: remove 'running' from instance options
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Agata Murawska
03:15 pm Revision 7dd14211: htools: change runSt type to InstanceStatus
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Agata Murawska
03:15 pm Revision 3771d104: htools: create InstanceStatus ADT
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Agata Murawska
03:15 pm Revision 57de31c0: Transition into and out of offline instance state
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Agata Murawska
03:15 pm Revision 2e04d454: Introduce admin_state as 3-values data type
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Agata Murawska
03:15 pm Revision 9ca8a7c5: Rename admin_up to admin_state
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Agata Murawska
03:15 pm Revision 34598551: Fixed typo in _VerifyResultRow
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Agata Murawska
10:41 am Revision 9c709b31: algo: Make a dict from an flat list
This is in preparation to take deeper dict constructs from the command
line. You can feed the optionslist directly co...
René Nussbaumer

11/15/2011

03:50 pm Revision ee2b99e3: locking: Make some aliased methods public
Some methods, such as “_is_owned” and “list_owned”, have been aliased to
make them public for a while now. This patch...
Michael Hanselmann
03:00 pm Revision 63e6a7f6: cmdlib._ReleaseLock: Do nothing if no locks are owned
The locking library doesn't like it when “release()” is called on
a lockset or lock which isn't held by the current t...
Michael Hanselmann
11:52 am Revision 4d4eae2a: Use resource lock when setting node parameters
Also acquire instance and resource locks in shared mode (see comment).
Signed-off-by: Michael Hanselmann <hansmi@goo...
Michael Hanselmann
11:52 am Revision 42828156: Use node resource lock for replacing instance disks
If early-release is not used, the resource lock is kept while waiting
for disks to sync.
Signed-off-by: Michael Hans...
Michael Hanselmann
11:52 am Revision 63742d78: Hold node resource locks while setting instance parameters
Important for when disks are converted. Release locks once they're not
needed anymore. Make liberal use of assertions...
Michael Hanselmann
11:52 am Revision c57add7e: Hold node resource lock while moving instance
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
11:51 am Revision d3986702: Acquire node resource lock when removing instance
Removing an instance affects available disk space and memory.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
...
Michael Hanselmann
11:51 am Revision 6a752efc: Use node resource lock when recreating instance disks
Recreating disks conflicts with other disk operations, therefore the
node resource lock must be acquired.
Signed-off...
Michael Hanselmann
11:51 am Revision a4e588b7: LUClusterRepairDiskSizes: Use node resource locks
Since this doesn't really touch the node, but it conflicts with e.g.
growing a disk, the resource lock must be acquir...
Michael Hanselmann
11:51 am Revision 0c3c965a: LUInstanceGrowDisk: Use node resource lock
Also add one more feedback line. Downgrade instance lock to shared mode
while we're only waiting for disks to sync. T...
Michael Hanselmann
11:51 am Revision eaee9e3b: LUInstanceCreate: Hold node resource lock
The node resource lock is released once the disks are in sync (that is,
after wiping).
Signed-off-by: Michael Hansel...
Michael Hanselmann
11:19 am Revision d9d9e0d9: LUNodeQueryvols: Acquire all locks in shared mode
Nothing is being written to.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@g...
Michael Hanselmann
11:19 am Revision efcb184e: LUNodeQueryStorage: Acquire all locks in shared mode
Nothing is written to.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google....
Michael Hanselmann
11:19 am Revision aefb66c0: cmdlib: Share lock in LUInstanceConsole
No writes are being done.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@goog...
Michael Hanselmann
08:13 am Revision 65c9591c: Document OpNodeMigrate's result for RAPI
- Commit b7a1c8161 changed the LU to generate jobs
- Mention documented results in NEWS
Signed-off-by: Michael Hanse...
Michael Hanselmann
08:13 am Revision d1ad741e: LUNodeQuery: Call implementation's DeclareLocks function
Just in case we ever add locks for querying nodes. Currently
_NodeQuery's DeclareLocks is a no-op function.
Signed-o...
Michael Hanselmann

11/14/2011

05:18 pm Revision 702eff21: Use master IP address setup script in backend
Replace the code in backend.ActivateMasterIp and
backend.DeactivateMasterIp with the master IP address setup script,
...
Andrea Spadaccini
05:18 pm Revision 57c7bc57: Change master IP address RPCs for external script
Change the master IP address RPC call chain to accept the
use_external_master_ip_script parameter. Introduces an unus...
Andrea Spadaccini
05:18 pm Revision 17b0b812: Update cluster verify to check IP address scripts
Update cluster-verify to check the integrity of the default master IP
address setup script and the presence and execu...
Andrea Spadaccini
05:18 pm Revision bf689b7a: Add --use-external-mip-script flag
- add a command line flag to gnt-cluster init and modify to change the
value of the cluster parameter use_external_...
Andrea Spadaccini
05:17 pm Revision 33be7576: Add use_external_mip_script cluster parameter
Add the use_external_mip_script cluster parameter, that represents
whether the master IP address turnup/turndown proc...
Andrea Spadaccini
05:17 pm Revision d9eefcfa: Add the default master-ip-setup script
Add a shell script that will be the default replacement for the body of
backend.ActivateMasterIp and backend.Deactiva...
Andrea Spadaccini
11:03 am Revision f396ad8c: Ensure unused ports return to the free port pool
Ensure ports previously allocated by calling ConfigWriter's AllocatePort() are
returned to the pool of free ports whe...
Vangelis Koukis
11:03 am Revision ca8f5622: Re-wrap a paragraph to eliminate a sphinx warning
This just makes sure that the paragraph doesn't contains lines that
start with :, which make Sphinx (1.0.7) complain....
Iustin Pop
08:23 am Revision db859c7d: check-python-code: Detect old-style pylint disable-msg lines
Commit b459a848d was supposed to replace all, but one was missed. Add a
check to autotools/check-python-code.
Signed...
Michael Hanselmann

11/10/2011

03:50 pm Revision 1dd64393: Fix newer pylint's E0611 error in compat.py
These are triggered by our "stay-compatible" approach.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-...
Guido Trotter
12:23 pm Revision 5b49ed09: Adding basic elements for the new node params
This patch adds the new fields to the objects.py as well as defines the
constants used in the dicts and their type.
...
René Nussbaumer

11/08/2011

07:31 pm Revision 82cce526: rpc: Fix another result processor
I forgot to change this in commit d9da5065c0.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Ius...
Michael Hanselmann
05:44 pm Revision f68cc544: rpc: Fix issue with “test_delay”'s timeout
I passed the timeout calculation function in the wrong field of the
definition. A small change is also needed in “bui...
Michael Hanselmann
05:44 pm Revision d9da5065: rpc: Call result processor once for each node result
… instead of calling it with the whole results dictionary. This
fixes an issue when replacing disks (and all other ca...
Michael Hanselmann
04:06 pm Revision d755483c: Fail if node/group evacuation can't evacuate instances
If an instance can't be evacuated, only a message would be printed. With
this change the operation always aborts. New...
Michael Hanselmann

11/07/2011

07:32 pm Revision cc19798f: LUNodeSetParams: Lock affected instances only
Until now LUNodeSetParams would lock all instances if a node's
secondary IP address was to be changed and would then ...
Michael Hanselmann
07:32 pm Revision 212a7fcd: Check BGL when adding/removing node
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Michael Hanselmann
07:15 pm Revision f7d9b3aa: RPC/test_delay: Use callable for timeout calculation
This avoids having to override the function in the RPC runner.
Signed-off-by: Michael Hanselmann <hansmi@google.com>...
Michael Hanselmann
07:15 pm Revision 26d502d0: rpc: Move post-processor functions into definitions file
This way the generated code no longer contains arbitrary code.
Post-processing functions are used by reference.
Sign...
Michael Hanselmann
07:14 pm Revision 702abcf9: rpc: Use definitions directly instead of via generated code
Until now “autotools/build-rpc” would read the definition of all RPCs
and write them to a new file, “lib/_generated_r...
Michael Hanselmann
07:01 pm Revision a09f9847: Convert RPC definitions to dictionaries
This is in preparation to reducing the amount of generated code.
Signed-off-by: Michael Hanselmann <hansmi@google.co...
Michael Hanselmann
07:01 pm Revision 320e34df: query: Use new SequenceToDict utility
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Michael Hanselmann
04:32 pm Revision 9e6014b9: Improve error handling in netmask change
- check if the master IP with the old netmask is up before attempting to
change the netmask (to avoid a failed chan...
Andrea Spadaccini

11/04/2011

06:07 pm Revision 0007f3ab: Add master_netmask to Cluster.UpgradeConfig
And also suppress pylint R0902 error about an object instance having
more than 20 attributes.
Signed-off-by: Andrea ...
Andrea Spadaccini
05:06 pm Revision 45e22998: Update init script description
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Andrea Spadaccini <spadaccio@google.com>
Guido Trotter
04:22 pm Revision 186c03b3: Fix cluster start failure due to missing netmask
If the cluster version is upgraded from a version before commit
5a8648eb609f7e3a8d7ad7f82e93cfdd467a8fb5 to a version...
Andrea Spadaccini
02:21 pm Revision d24303b3: ganeti(7): Adding documentation about env variables
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
René Nussbaumer
11:19 am Revision fb2865ae: LUInstanceRename: Compare name with name
… instead of object with name.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <r...
Michael Hanselmann
08:09 am Revision 6d0accae: utils.algo: Add utility to convert sequence to dictionary
Useful for converting list of query fields to a dictionary and to
convert RPC definitions. Includes duplicate detecti...
Michael Hanselmann
08:09 am Revision 5a85b99e: Add QA test for “gnt-debug delay”
This would have caught a bug introduced with the recent RPC changes.
Signed-off-by: Michael Hanselmann <hansmi@googl...
Michael Hanselmann
08:09 am Revision 52808305: rpc: Make “test_delay” RPC actually work
Until now it would just call itself, eventually failing.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Revie...
Michael Hanselmann
08:08 am Revision cdde200a: LUClusterRepairDiskSizes: Acquire instance locks in exclusive mode
Instances are modified if their disk size doesn't match.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Revie...
Michael Hanselmann

11/03/2011

06:47 pm Revision 620fb907: QA: Add test for setting node's secondary IP address
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Andrea Spadaccini <spadaccio@google.com>
Michael Hanselmann
06:39 pm Revision 1986b21f: cmdlib: Allow specifying lock level when calculating node locks
This is needed to lock node resources.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trot...
Michael Hanselmann
06:30 pm Revision b2acdbdc: Show RPC calls from config in lock monitor
With this patch all RPC calls at runtime of masterd will show up in the
lock monitor. There is a chicken-and-egg issu...
Michael Hanselmann
06:23 pm Revision eb5ac108: Update synopsis for “gnt-cluster repair-disk-sizes”
Mention that instances can be passed on the CLI when “--help” is used.
Signed-off-by: Michael Hanselmann <hansmi@goo...
Michael Hanselmann
04:39 pm Revision 3ccd3243: Derive IP hooks env variables from RPC parameter
Let the environment variables of the master IP turnup/turndown be
derived from the parameter of the RPC itself (that ...
Andrea Spadaccini
04:39 pm Revision c79198a0: Pass MasterNetworkParameters instances in RPCs
Pass instances of objects.MasterNetworkParameters when calling RPCs for
activation and deactivation of master IP.
Si...
Andrea Spadaccini
04:39 pm Revision f9d20654: Use MasterNetworkParameters attributes for RPC
Instead of manually unpacking the return values of
cfg.GetMasterNetworkParameters, let it return an instance of
objec...
Andrea Spadaccini
04:39 pm Revision 061af273: Add object representing the master network params
Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
Andrea Spadaccini
04:39 pm Revision 91ae95fd: Uniform master IP activation and deactivation
Add the master IP family parameter to the master IP deactivation RPCs,
so that the activation and deactivation interf...
Andrea Spadaccini

11/02/2011

05:28 pm Revision ef9fa5b9: Make it possible to pass in flags using ENV variables
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
René Nussbaumer
05:28 pm Revision d60946d9: utils.algo: Add a function to insert a list into a list
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
René Nussbaumer
04:36 pm Revision 3f006be3: Fix pylint deprecated directive in check-header
Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Andrea Spadaccini
03:36 pm Revision 95a39a77: Fix overriding of ActivateMasterIp params
In the process of reworking the patches for master, I forgot to remove a
call to GetMasterInfo() that overrides the p...
Andrea Spadaccini
03:18 pm Revision 3a3e4f1e: Add netmask and IP version to master IP hooks env
Add the master netmask and master IP version parameters to the hooks and
document them. In this way, the hook environ...
Andrea Spadaccini
03:03 pm Revision 8da2bd43: Explicitly pass params to activate_master_ip
To remove the usage of ssconf in the backend, the master needs to push
the parameters of activate_master_ip to the ba...
Andrea Spadaccini
03:03 pm Revision 41e079ce: Explicitly pass params to change_master_netmask
Make the master explicitly pass the parameters to the
change_master_netmask RPC, and change all the call flow to use ...
Andrea Spadaccini
03:03 pm Revision 96e0d5cc: Explicitly pass params to deactivate_master_ip
Make the master explicitly pass the parameters to the
deactivate_master_ip RPC, and change all the call flow to use t...
Andrea Spadaccini
03:03 pm Revision 7c74bbe0: Change the semantics of stop_master RPC
To avoid polluting the stop_master RPC interface with network
parameters, this patch removes the deactivation of the ...
Andrea Spadaccini
02:54 pm Revision 5d7a899e: locking: Make level names consistent, add check
- Change all lock level names to their singular form
- Add assertion checking consistency between level names and loc...
Michael Hanselmann
02:54 pm Revision 4e070776: Add new lock level for node resource modifications
This is in preparation for implementing a new resource model.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
...
Michael Hanselmann
02:22 pm Revision 5d3c30df: Add tool to check Python file headers
Ensures licence and copyright headers are correct.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by...
Michael Hanselmann
12:46 pm Revision fe5ca2bb: Move hooks PATH environment variable to constants
Move the contents of the PATH environment variable for hooks to
constants, and use its value in the code and in the h...
Andrea Spadaccini

11/01/2011

09:21 pm Revision 2a6de57a: Check the results of master IP RPCs
A failed gnt-cluster (de)activate-master-ip would not produce any output
to the user. This patch adds code that check...
Andrea Spadaccini
09:09 pm Revision 3738b8d6: Add documentation for the master IP hooks
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Andrea Spadaccini
09:09 pm Revision 28aedbc1: Add master IP turnup and turndown hooks
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Andrea Spadaccini
09:09 pm Revision 20d38e8a: Add RunLocalHooks decorator
Add the RunLocalHooks decorator, that allows the execution of hooks
locally. Also, add a RunLocalHooks method to Hook...
Andrea Spadaccini
09:07 pm Revision da124e89: Generalize HooksMaster
- remove any dependence on Logical Units from the HooksMaster;
- add a new function parameter to the constructor, a f...
Andrea Spadaccini
08:37 pm Revision 769582be: Add documentation for the master IP hooks
Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Andrea Spadaccini
08:37 pm Revision 2d88fdd3: Add master IP turnup and turndown hooks
Signed-off-by: Andrea Spadaccini <spadaccio@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Andrea Spadaccini
08:37 pm Revision 0fa481f5: Add RunLocalHooks decorator
Add the RunLocalHooks decorator, that allows the execution of hooks
locally. Also, add a RunLocalHooks method to Hook...
Andrea Spadaccini
08:37 pm Revision 949dcb1d: Generalize HooksMaster
- remove any dependence on Logical Units from the HooksMaster;
- add a new function parameter to the constructor, a f...
Andrea Spadaccini
06:01 pm Revision 8e709b21: RAPI: Fix issue when replacing disks
This is another fallout from a suboptimal merge.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: ...
Michael Hanselmann
05:17 pm Revision cd40dc53: rpc: Improve argument definitions
Instead of in-place code now each argument has an (optional) kind
assigned. The RPC client will then take care of enc...
Michael Hanselmann
05:17 pm Revision b8c160c1: rpc: Change {import,export}_start to take source/dest in single argument
This simplifies the RPC argument encoding code.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: R...
Michael Hanselmann
05:17 pm Revision 6648cb36: Rename lib/build/rpc_definitions.py to lib/rpc_defs.py
It will also be used at runtime, not just for building.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Review...
Michael Hanselmann
03:19 pm Revision 0f03d8d4: Clean up incorrect merge 7dcf333d
The unittests weren't corrected for the master branch.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewe...
Michael Hanselmann
« Previous
Next »
 

Also available in: Atom