Activity
From 01/16/2012 to 02/14/2012
02/14/2012
- 02:44 pm Revision e6a8d799: cmdlib: Fix “unpack non-sequence” error
- The callback is expected to return a two-valued tuple.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewe...
02/13/2012
- 08:04 pm Revision d505bc48: Fix doc bug introduced in 12637df
- Commit 12637df changed/generalised how we build fields in the sphinx
extension, however it resulted in this uncaught-... - 07:17 pm Revision bdd6931c: htools: allow rbd disk template
- Notes:
- it'd be nice if there was a way to automatically generate the
DiskTemplate list instead of manually sp... - 07:16 pm Revision efcfa99d: ApplyContainerMods: Return changes from callbacks
- … instead of passing the list of changes as a parameter.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Revie... - 05:44 pm Revision cd79cd83: Use the ipolicy constants for key names
- Sorry, I missed this when I wrote the code originally.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Gu... - 05:20 pm Revision c0f1033f: LUInstanceSetParams: Convert to generic algorithm for NIC/disk changes
- Unfortunately this got a bit messier than I intended, but then again it
cleans up a lot of messy code with heaps of l... - 05:20 pm Revision 8301885b: cmdlib: Add generic algorithm for modifying NICs/disks
- While preparing this patch series I identified at least three different
implementations of the algorithm for adding/r... - 04:02 pm Revision 0813170b: Fix unittest breakage after commit a2aadb34b
- Thou shalt run “make check” before sending patches.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-b... - 03:25 pm Revision b8925b86: LUInstanceSetParams: Assertion on disk template/disk changes
- Disk changes aren't allowed at the same time as a disk template change.
Signed-off-by: Michael Hanselmann <hansmi@go... - 03:23 pm Revision a2aadb34: OpInstanceSetParams: Make two type checks public
- They'll be used for tests in cmdlib.py.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Po... - 03:23 pm Revision e9c3d864: OpInstanceSetParams: Accept more flexible NIC/disk modifications
- Start accepting a new form of NIC/disk modifications for adding/removing
arbitrary NICs/disks. Unlike before the inde... - 03:23 pm Revision bf629e45: constants: Add constant for modifying existing NIC/disk
- Until now it would not be possible to add/remove a NIC/disk in an
arbitrary position. This constant will be used in t... - 03:23 pm Revision 20a32e74: opcodes: Add comments to two parameter tests
- These comments appear in the RAPI documentation.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: ...
02/10/2012
- 05:10 pm Revision 7ed400f0: rbd disk template documentation and manpages
- Add documentation and modify manpages for the RBD disk template.
Signed-off-by: Constantinos Venetsanopoulos <cven@g...
02/07/2012
- 01:52 pm Revision 5d0566de: Accept both PUT and POST in noded
- This is a partial cherry-pick from
7530364ddbe949bc34fc26f25ba3f5d921beb021 on master:
Currently, noded requires PUT...
02/01/2012
- 10:25 am Revision dd9b9d7b: Merge branch 'stable-2.5' into devel-2.5
- * stable-2.5:
Fix type check for OpQuery.filter
Fix explanation of gnt-node evacuate --primaries-only
Makefile.... - 10:24 am Revision 631aedf9: Re-added constant mistakenly removed in 58f0ce16873
- “INSTANCE_DOWN” is still being used.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbau... - 10:11 am Revision f0fd35b1: rapi.client: Removing constants not needed anymore
- They were not referenced through the whole code and were marked internal
only.
Signed-off-by: René Nussbaumer <rn@go... - 08:24 am Revision ddc1de7c: Add stricter checks for OpInstanceSetParams.{nics,disks}
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 08:24 am Revision ff8067cf: Add ht.TMaybeListOf type check
- Replaces some uses of TOr(TNone, TListOf(…)).
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Ren... - 08:24 am Revision 8f227489: Stricter check for OS modifications passed to OpClusterSetParams
- Don't just check the first element of each item, but also make sure the
OS name is a string and not empty.
Signed-of... - 08:19 am Revision 58f0ce16: LUInstanceSetParams: Allow no-op change of instance offline status
- With this patch marking an instance already marked offline (or online)
as offline/online again becomes a no-op. Also ...
01/31/2012
- 02:32 pm Revision 545d0362: Fix type check for OpQuery.filter
- Just using ht.TListOf as a type check doesn't work correctly. The
function must be called with the expected item type... - 07:44 am Revision 3016bc1f: OpInstanceSetParams: Merge {off,on}line_inst parameters
- Instead of having two separate parameters, a single boolean parameter is
used. Unfortunately we need a third state to...
01/27/2012
- 05:44 pm Revision 784b6603: ipolicy: Make the keys of the dict consistent
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin ... - 04:56 pm Revision d4fcd298: admin.rst: add information about maxmem/minmem
- - Specify how maxmem and minmem are used at startup, failover and
migrate
- Add a paragraph about how to manually c... - 04:56 pm Revision 827ac163: N+1: verify using minimum memory
- Since instances can be started, failed over and migrated with less than
their maximum memory N+1 will use the minimum... - 04:56 pm Revision 2a50e2e8: walkthrough.rst: updates for maxmem/minmem
- - Fix two example outputs
- Improve N+1 resolution section specifying how different memories
affect N+1 calculation...
01/26/2012
- 08:45 pm Revision 3c1e4af0: Fix integer overflow in Node unittest
- When using a really random "extra cpus" variable, this can overflow
(especially on 32 bit) and thus the final value c... - 08:31 pm Revision f1dff7ec: Fix explanation of gnt-node evacuate --primaries-only
- Furthermore, correct the --help display on evacuate.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Mich... - 06:33 pm Revision e14ddb6e: Use allow_runtime_chgs in cmdlib
- - Report the attribute value in the hooks runtime variable.
- Use it to abort migration if not enough memory is avail... - 06:33 pm Revision 8c0b16f6: cli/opcodes: add a --no-runtime-changes migrate opt
- This will be used for now to avoid ballooning memory at live migration time.
Signed-off-by: Guido Trotter <ultrotter... - 06:33 pm Revision e57602c2: Migrate/Failover: allow less-than-max-mem op
- Failover works magically after we relax the check: the start operation
will just use less memory, if less memory is a... - 06:33 pm Revision c113a9ab: Failover and Migrate: acquire node resource locks
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 06:33 pm Revision 081d8528: cmdlib._CheckNodeFreeMemory: return free memory
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 04:30 pm Revision 1b01390b: doc/rapi.rst: Document ipolicy parameter
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 03:34 pm Revision e8fa4ff6: Add vcpu_ratio definition to the IPolicy type
- This will be "naturally" read in the JSON-based backends (Luxi/Rapi),
and we add explicit code for handling it in the... - 03:34 pm Revision 487e1962: Remove Node.mCpu, replaced with the ipol vcpu_ratio
- Since the iPolicy contains the vcpu_ratio now, we can remove the
per-node mCpu value (which was the initial way to se... - 03:34 pm Revision 5f3b040a: Temporary fix for hspace's NPU calculation
- hspace computes the NPU (normalised CPU units) via the
(used|pool|avail) VCPU divided by the (currently cluster-wide)... - 03:34 pm Revision 284e9822: Change meaning of the --max-cpu option
- Instead of always overriding, we should update the nodes's maxcpu
setting only when the option is specified. Otherwis... - 03:34 pm Revision e54d6628: Remove obsolete constant for vcpu_ratio
- This is superseded now.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 03:34 pm Revision 37483aa5: Expand the tiered alloc unittest to check allocation stats
- This was missing before, so with the new metric (NCpus), it's a good
time to test this.
Signed-off-by: Iustin Pop <i... - 03:34 pm Revision 90c2f1e8: Track 'normalised' used CPUs in Cluster.CStats
- This will be used in hspace for proper tracking of used/pool/unavail
npus.
Signed-off-by: Iustin Pop <iustin@google.... - 03:34 pm Revision 76a20994: Add a new type for holding allocation statistics
- The current RSpec type doesn't cut it anymore (and it's used in other
places), so let's introduce a separate type for... - 03:34 pm Revision 80d7d8a1: Switch over some hspace stats from RSpec to AllocInfo
- This patch changes the allocation delta stats from RSpec to
AllocInfo. There's nothing interesting about it, but it s... - 03:34 pm Revision 33e17565: Re-indent code for readability
- Otherwise the docstrings for members take too many lines.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by:... - 03:34 pm Revision 1e7acc3b: Fix gnt-cluster modify check of passed options
- … and add the disk_templates/vcpu_ratio new entries. Since the default
ispecs_* are dicts, we can't compare them to n... - 03:34 pm Revision e6244d00: Export the cluster ipolicy in iallocator
- And remove a strange comment (the commit which introduced it,
d61df03e, doesn't explain it). Also document these new ... - 03:34 pm Revision 976b78ba: Add ipolicy_vcpu_ratio to command line
- This allows changing this value from the command line.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Mi... - 01:53 pm Revision ff6c5e55: Add new ipolicy parameter vcpu_ratio
- This adds the new parameter and changes the validation routines to
handle IPOLICY_PARAMETER value as floats. Very ver... - 01:47 pm Revision ffa339ca: Clarification on what objects.InstancePolicy is
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 01:47 pm Revision 12378fe3: Rename IPOLICY_PARAMETERS to IPOLICY_ISPECS
- As opposed to the initial situation, the PARAMETERS will be more than
just the min/std/max ispecs. Let's rename it, b... - 01:46 pm Revision ad0e078e: Remove two extraneous imports
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 12:23 pm Revision c22341e6: Makefile.am: fix permissions for Python scripts on install
- Some Python scripts in /usr/lib/ganeti/ were getting the wrong permissions
(their 'x' bit was cleared). This patch f... - 12:22 pm Revision 40476293: devel/upload: Fix permissions for installed directories
- Permissions for the directories created during install depended on the
umask of the user running the script. Now uma...
01/25/2012
- 08:23 pm Revision 2c2f257d: Fix cluster verification issues on multi-group clusters
- This patch attempts to fix a number of issues with “gnt-cluster verify”
in presence of multiple node groups and DRBD8... - 03:36 pm Revision 735e1318: gnt-instance recreate-disks: Allow specifying new size
- With this change a new disk size can be specified when recreating disks.
Signed-off-by: Michael Hanselmann <hansmi@g... - 03:24 pm Revision cf572b13: LUClusterSetParams: When ipolicy is updated warn for new violations
- We need to loop over all node groups to apply their modification to make
sure that the new ipolicy actually affects t... - 03:24 pm Revision 68ab64cf: LUGroupSetParams: Warn if the new ipolicy will violate some ipolicies
- If we modify the ipolicy we need to verify if any instance would now
violate the new ipolicy and warn about it. Any i... - 03:24 pm Revision 92ff96e8: cmdlib: Add a helper function for a set of violating instances
- This helper will be used with the Op*SetParams and ipolicy verifications
Signed-off-by: René Nussbaumer <rn@google.c...
01/24/2012
- 06:39 pm Revision d04c9d45: Rename ispecs-disk-templates to ipolicy-disk-templates
- The ispecs (min/std/max) are different from the other ipolicy
variables (disk templates for now, more in the future).... - 03:57 pm Revision d62cbd3a: fmtjson: A tool to format JSON data
- While debugging an issue recently I had the pleasure of looking at a
long, single-line string of JSON data. This simp...
01/23/2012
- 07:53 pm Revision 7181fba0: Implement rbd disk template
- Introduce the rbd disk template, which handles provisioning and
management of instance disks as block devices mapped ... - 03:39 pm Revision 447af814: Open VDI Port when spice_use_vdagent is enabled
- To use the features spice agent provides, a dedicated virtio-serial
channel must be created in qemu-kvm. The communic... - 03:17 pm Revision c90d8e61: Fix iallocator group objects
- … this is yet another manual serialisation of objects :(
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: ... - 03:02 pm Revision 38a6e2e1: Fix upgrading the cluster ipolicy
- When running from git HEAD, just initialising the ipolicy when
non-existing is not good enough; we need to upgrade al... - 01:37 pm Revision f626cef4: LUInstanceRecreateDisks: Actually acquire node resource locks
- Before this change an assertion would fail as the resource locks weren't
actually acquired.
Signed-off-by: Michael H... - 01:21 pm Revision a81075bf: cmdlib._CheckInstanceState: Use instance name in error message
- The variable “instance” is an instance object, so to not get a
serialized version of the instance, the “name” attribu... - 01:21 pm Revision e53ea88d: Unbreak build after merge 2ea64524ce
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 01:21 pm Revision a24aed2a: gnt-cluster command: Add option to prepend node name to output
- With this patch a new option (“-M”, like dsh) is added to “gnt-cluster
command” to prepend the node name to all outpu...
01/20/2012
- 07:55 pm Revision e9ed4f2e: cmdlib: Drop use of “len(…) != 0”
- Found by Constantinos Venetsanopoulos.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trot... - 07:48 pm Revision 2ea64524: Merge branch 'devel-2.5'
- * devel-2.5:
Migrate: don't check for free memory on cleanup
Revert "cli: Disable abbreviation matching for optio... - 07:34 pm Revision 72dc3fb3: Merge branch 'stable-2.5' into devel-2.5
- * stable-2.5:
Migrate: don't check for free memory on cleanup
Signed-off-by: Guido Trotter <ultrotter@google.com>
... - 07:12 pm Revision c1f19851: cli: Log fully quoted command line
- Instead of logging the concatenated arguments, with this patch every
command will properly quote its full command lin... - 06:24 pm Revision 6b826dfa: Migrate: don't check for free memory on cleanup
- Cleanup just updates the config with the correct location of the
instance, or informs of its down status, but never s... - 11:44 am Revision 5b3f5fc8: LUInstanceStartup: check for minimum memory
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 11:44 am Revision 61eb1a46: hypervisors: start instances with max available mem
- If we have available more than MINMEM but less than MAXMEM, start a new
instance with that value, rather than MAXMEM.... - 11:44 am Revision 5d1ab3a6: Instance startup: lock primary node
- This will be used to balloon other instances on the node if needed.
Signed-off-by: Guido Trotter <ultrotter@google.c... - 11:44 am Revision 945a7e67: kvm: always start in paused state
- Currently kvm starts in a frozen state if cpu pinning is set.
This is useful for other purposes as well (eg. ballooni...
01/19/2012
- 06:43 pm Revision bf5338b3: Revert "cli: Disable abbreviation matching for options"
- This reverts commit 232aab3f4f602a19f1226e85c3a3ecb245d60af4. We
shouldn't change the parsing of command line options... - 03:14 pm Revision 59d81cb3: Merge branch 'devel-2.5'
- * devel-2.5:
Fix wrong option names in QA and cluster-merge
Bump version to 2.5.0~rc5, update NEWS
Add Unescape... - 02:48 pm Revision 431f2a80: Merge branch 'stable-2.5' into devel-2.5
- * stable-2.5:
Bump version to 2.5.0~rc5, update NEWS
Add UnescapeAndSplit unittest for multi-escapes
Fix a bug ... - 02:42 pm Revision 58ea8d17: Fix wrong option names in QA and cluster-merge
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:42 pm Revision ecabe27e: Fix a bug in command line option parsing code
- Fix bug affecting command line options of "keyval" type. Although
escaping commands with \ is supported, it is is not... - 02:42 pm Revision e7f7212b: Add UnescapeAndSplit unittest for multi-escapes
- This would have caught the bug in the first place. Argh,
hand-generated test cases!
Signed-off-by: Iustin Pop <iusti... - 02:42 pm Revision 7cbdc2a2: Bump version to 2.5.0~rc5, update NEWS
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
01/18/2012
- 08:42 pm Revision 232aab3f: cli: Disable abbreviation matching for options
- Python's “optparse” module does option name prefix matching by default.
Since this can lead to confusing behaviour, e... - 06:51 pm Revision f356202a: qa: perform burnin with max/min mem from config
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 06:03 pm Revision 6b5f0dd8: Burnin: test set-mem
- Add new --maxmem-size and --minmem-size options.
The old --mem-size option allows setting both at the same time.
If -... - 06:03 pm Revision 2c0af7da: gnt-instance modify -m|--runtime-memory
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
01/17/2012
- 03:01 pm Revision 2c7a0373: Implement memory ballooning in xen
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 03:01 pm Revision 3d836750: Implement memory ballooning in kvm
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 03:01 pm Revision 80121c83: xen: add the "maxmem" parameter in instances config
- This is set to the same amount as the memory for now, but will allow
starting instances with less memory than their m... - 03:01 pm Revision cfb5f9da: Implement memory ballooning in the fake hv
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 03:01 pm Revision ebe466d8: Add instance_balloon_memory rpc
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 03:01 pm Revision 2e2fb795: No-op memory ballooning in chroot and lxc
- Currently they have no memory limits set.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: René Nuss... - 03:01 pm Revision b990eedd: Hypervisor: allow ballooning of instance memory
- This new hypervisor call sets the memory of an instance to a new value,
through ballooning.
Signed-off-by: Guido Tro... - 12:08 pm Revision 7530364d: Accept both PUT and POST in noded
- Currently, noded requires PUT, even though the semantics of the RPC
calls do not match a PUT. We change the code acce... - 12:08 pm Revision 4c1a464b: Rework instance rename QA tests
- After looking again at the QA speeds, it turned out that instance
rename was run 12 times via the command line and 12...
01/16/2012
- 02:50 pm Revision 468b828e: Another small optimisation in test data generation
- It seems that QuickCheck will happily generate huge data structures,
if that's what one requests. For this test, wher... - 02:50 pm Revision 15e3d31c: Generate tags using the helper in Node tests
- Otherwise we test very big lists (slow) without any advantage in doing
so.
Signed-off-by: Iustin Pop <iustin@google.... - 02:50 pm Revision 45c4d54d: Combine two Node unittests
- These two tests are very similar, so let's run them together instead
of generating the data twice. Also improve the t... - 02:49 pm Revision a292b4e0: Add unit-tests for --help/--version as common options
- After reorganizing the way we process options, we can finally add a
test that all program personalities accept --help... - 02:49 pm Revision 9f13be88: Split the list of program personalities into a module
- … a mini-module, actually. This is only done for unit-testing, as we
don't want to duplicate the personalities list i... - 02:49 pm Revision 21839f47: Parse options in htools.hs, not in each program
- This patch moves the call to getArgs/parseOpts into htools.hs, as
opposed to the current situation where htools.hs on... - 02:49 pm Revision 89298c04: Add some very basic options test
- Just tests that passing a string argument returns it correctly. We're
not interested in the flags themselves that muc... - 02:49 pm Revision 51c3d88f: Split CLI.parseOpts into IO/non-IO parts
- This will allow unittesting the CLI options much more easily. The
patch also fixes an inconsistency: usage help was d... - 02:49 pm Revision a7ea861a: Add test for CLI.parseYesNo
- Also fix a tiny typo in the docstring.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René Nussbaumer <r... - 02:49 pm Revision 8b5a517a: Fix bug in CLI.parseISpecString and add test
- 'zip' finishes on the shortest list, so parseISpecString accepted any
string of 3 values or more, which is not good. ... - 02:49 pm Revision e1dde6ad: Add a unittest for the 'Simu' backend
- This only test successful parsing, but for this case it tests
reasonably well the resulting cluster properties, I thi... - 02:49 pm Revision 59ed268d: Further optimise instance test data generation
- Following on the lessons from this week (commit 7806125e), this patch
replaces generation of instances `suchThat` the... - 02:49 pm Revision c7ec3025: Add a Makefile target for profiling targets
- This simplifies the building of profiling-enabled htools binaries;
there are two targets, one used for the initial tw... - 10:36 am Revision 893e8f49: gnt-instance: Adapt replace-disks to the new opcode
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 10:36 am Revision d2fe2bfb: TLReplaceDisk: Add ipolicy checks
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Also available in: Atom