Activity
From 01/25/2012 to 02/23/2012
02/23/2012
- 06:00 pm Revision b02c6bdf: opcodes: Remove dependency on query module
- There's no need to verify the field definitions on every query. They are
static for all intents and purposes anyway a... - 05:59 pm Revision a0a63e76: Merge branch 'stable-2.5' into devel-2.5
- * stable-2.5:
Fix Makefile.am compatibility with automake 1.11.2
Signed-off-by: Michael Hanselmann <hansmi@google....
02/22/2012
- 03:13 pm Revision d859a2cf: http.server: Factorize request handling even more
- This splits even more parts of the request handling code into a separate
class. Doing so allows us to reuse this part... - 03:12 pm Revision 377ae13e: http.server: Move error message formatting to handler class
- Like before this patch moves more functionality from the actual server
class into a separate handler class. At the sa... - 03:12 pm Revision cca5b3fc: noded: Shorter docstring for mlockall(2) executor
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 03:12 pm Revision e0003509: Split handling HTTP requests into separate class
- Until now HTTP requests were handled in the same class as incoming
connections (http.server.HttpServer). With this ch... - 03:12 pm Revision c81f452f: http.server: Factorize request handling
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 02:03 pm Revision 09037780: Remove deprecated “QueryLocks” LUXI request
- This has been deprecated since Ganeti 2.4 and hasn't been used by
Ganeti's code since. I'm not aware of any external ...
02/21/2012
- 09:18 pm Revision 48796673: Add result checks for OpTags*
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 05:34 pm Revision 415feb2e: opcodes: Annotate the OP_RESULT of query operations
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iusti... - 05:23 pm Revision 3ccb3a64: Replace single- with double-quotes
- In at least two cases "%s" is replaced with str(), too.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Review... - 04:34 pm Revision 0f85ebd9: Fix asyncnotifier unit tests
- On my workstation, if I run the following two tests in this exact
order:
- TestSingleFileEventHandler.testError
- Te... - 04:32 pm Revision 3bd0f3d8: Small fixup to rapi docstrings
- The fast that most classes don't override the @cvars means that direct
references to FillOpcode can fail (they do on ... - 04:32 pm Revision 09cbac87: Small update to LogicalUnit.ExpandNames docstring
- … to make even more obvious what's the difference between a declared
lock level with an empty list of locks and no lo... - 02:35 pm Revision 37e61a77: Export ndparams in RAPI node query
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 02:33 pm Revision 8930b0f0: Add ndp/* fields to group/node query
- Also change the meaning of group ndparams to mean the actual (not
custom) nd params, and add custom_ndparams for the ... - 02:33 pm Revision f25b8f58: Export ndparams in iallocator
- Strangely, these were not exported at all before.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael... - 02:32 pm Revision a194dc28: Add ipolicy parameter spindle_ratio
- This will represent the instance (count) per spindle_count of their
node(s). Debatable whether we need to add a per-i... - 02:32 pm Revision 432e8e2f: Add new spindle_count node parameter
- Currently this is not handled by Ganeti, just recorded.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: M... - 02:30 pm Revision 2a27dac3: Fix upgrading of ndparams
- Currently, we only upgrade the ndparams if they are missing
completely, which creates problems if we add any new para... - 02:28 pm Revision 765ada2b: Small fixes to objects.UpgradeDiskParams
- Fix a typo, and cleanup the code a bit.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselman...
02/20/2012
- 06:57 pm Revision 202fb4e0: opcodes: Add result checks for OpBackup*
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:57 pm Revision 5fa3d337: Improve opcode result check test to have a whitelist
- Only whitelisted opcodes may not have a result check.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed... - 01:27 pm Revision 82c54b5b: config: Add check for disk's “iv_name”
- This check verifies “iv_name” of all instance disks. If one is wrong
(which shouldn't happen in the first place), clu... - 12:50 pm Revision aa12a891: opcodes: Fix OP_RESULT for OobCommand
- The result is a list of a list with elements with size of 2.
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed... - 11:10 am Revision b8fe7ca6: Fix Makefile.am compatibility with automake 1.11.2
- Automake 1.11.2 made the following change:
* Long-standing bugs:
- Automake now warns about more primary/directory...
02/17/2012
- 06:54 pm Revision 956631b6: cli: Handle negative numbers when parsing key-value assignments
- To remove the last disk, or to add a NIC to the end, one can use the
index -1. This wouldn't work as intended as “-” ... - 05:39 pm Revision 5401c39d: utils.text: Add function to truncate string
- The function adds an ellipse if the string was actually truncated. Also
start using it in mcpu for result checks (whe... - 03:16 pm Revision 8c2d770c: Fix breakage introduced by fa6dd6bb56
- Forgot “enumerate”.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 03:16 pm Revision 0356a13d: LUInstanceSetParams: Update disk's “iv_name”
- When modifications are made, disks may not have the same index anymore.
Updating all disks fixes this.
Signed-off-by... - 01:34 pm Revision 35554b4f: ApplyContainerMods: Fix issues with indices
- When adding an item the index given to the callback function would be
incorrect under certain conditions. This patch ... - 12:52 pm Revision fa6dd6bb: cmdlib: Remove some users of “iv_name”
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 12:52 pm Revision e2569c1d: ConfigWriter: Stop using “iv_name”
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 12:52 pm Revision ea642319: ConfigWriter.RenameInstance: Stop using iv_name, safer operation
- Stop using the disk index encoded in “iv_name” when renaming an instance.
This patch also changes the code to operat... - 12:52 pm Revision a71f835e: gnt-instance modify: Support new-style NIC/disk modifications
- This patch adds support for adding/removing NICs/disks at arbitrary
indices on the command line. To add a disk at a s... - 10:59 am Revision c363310d: opcodes: Adding missing OP_RESULTs
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 10:59 am Revision ee938820: mcpu: Make the op result exception more verbose
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
02/15/2012
- 06:35 pm Revision 1a1e7ab3: Reconcile Makefile.am and test data files
- Sorry, forgot this in previous commit.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann... - 05:43 pm Revision 048eeb2b: Workaround changed LVM behaviour
- The vgreduce command has changed behaviour from when we initially
wrote the code (2.02.02 versus 2.02.66, 4 years del... - 05:16 pm Revision 002f91c5: cmdlib: De-duplicate code in _GenerateDiskTemplate
- There has been a lot of duplicated code in _GenerateDiskTemplate,
and some cases of very similar, but not quite same ... - 05:16 pm Revision a8e3e009: Add unittest for cmdlib._GenerateDiskTemplate
- This is in preparation to de-duplicating significant chunks of code in
cmdlib._GenerateDiskTemplate.
Signed-off-by: ... - 12:20 pm Revision a85f23fa: rapi.testutils: Add exported functions to verify opcode input/result
- These can be used by third-party code to verify mock code. Further work
on mocks is forthcoming, so this is only a st...
02/14/2012
- 02:44 pm Revision e6a8d799: cmdlib: Fix “unpack non-sequence” error
- The callback is expected to return a two-valued tuple.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewe...
02/13/2012
- 08:04 pm Revision d505bc48: Fix doc bug introduced in 12637df
- Commit 12637df changed/generalised how we build fields in the sphinx
extension, however it resulted in this uncaught-... - 07:17 pm Revision bdd6931c: htools: allow rbd disk template
- Notes:
- it'd be nice if there was a way to automatically generate the
DiskTemplate list instead of manually sp... - 07:16 pm Revision efcfa99d: ApplyContainerMods: Return changes from callbacks
- … instead of passing the list of changes as a parameter.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Revie... - 05:44 pm Revision cd79cd83: Use the ipolicy constants for key names
- Sorry, I missed this when I wrote the code originally.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Gu... - 05:20 pm Revision c0f1033f: LUInstanceSetParams: Convert to generic algorithm for NIC/disk changes
- Unfortunately this got a bit messier than I intended, but then again it
cleans up a lot of messy code with heaps of l... - 05:20 pm Revision 8301885b: cmdlib: Add generic algorithm for modifying NICs/disks
- While preparing this patch series I identified at least three different
implementations of the algorithm for adding/r... - 04:02 pm Revision 0813170b: Fix unittest breakage after commit a2aadb34b
- Thou shalt run “make check” before sending patches.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-b... - 03:25 pm Revision b8925b86: LUInstanceSetParams: Assertion on disk template/disk changes
- Disk changes aren't allowed at the same time as a disk template change.
Signed-off-by: Michael Hanselmann <hansmi@go... - 03:23 pm Revision a2aadb34: OpInstanceSetParams: Make two type checks public
- They'll be used for tests in cmdlib.py.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Po... - 03:23 pm Revision e9c3d864: OpInstanceSetParams: Accept more flexible NIC/disk modifications
- Start accepting a new form of NIC/disk modifications for adding/removing
arbitrary NICs/disks. Unlike before the inde... - 03:23 pm Revision bf629e45: constants: Add constant for modifying existing NIC/disk
- Until now it would not be possible to add/remove a NIC/disk in an
arbitrary position. This constant will be used in t... - 03:23 pm Revision 20a32e74: opcodes: Add comments to two parameter tests
- These comments appear in the RAPI documentation.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: ...
02/10/2012
- 05:10 pm Revision 7ed400f0: rbd disk template documentation and manpages
- Add documentation and modify manpages for the RBD disk template.
Signed-off-by: Constantinos Venetsanopoulos <cven@g...
02/07/2012
- 01:52 pm Revision 5d0566de: Accept both PUT and POST in noded
- This is a partial cherry-pick from
7530364ddbe949bc34fc26f25ba3f5d921beb021 on master:
Currently, noded requires PUT...
02/01/2012
- 10:25 am Revision dd9b9d7b: Merge branch 'stable-2.5' into devel-2.5
- * stable-2.5:
Fix type check for OpQuery.filter
Fix explanation of gnt-node evacuate --primaries-only
Makefile.... - 10:24 am Revision 631aedf9: Re-added constant mistakenly removed in 58f0ce16873
- “INSTANCE_DOWN” is still being used.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbau... - 10:11 am Revision f0fd35b1: rapi.client: Removing constants not needed anymore
- They were not referenced through the whole code and were marked internal
only.
Signed-off-by: René Nussbaumer <rn@go... - 08:24 am Revision ddc1de7c: Add stricter checks for OpInstanceSetParams.{nics,disks}
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 08:24 am Revision ff8067cf: Add ht.TMaybeListOf type check
- Replaces some uses of TOr(TNone, TListOf(…)).
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Ren... - 08:24 am Revision 8f227489: Stricter check for OS modifications passed to OpClusterSetParams
- Don't just check the first element of each item, but also make sure the
OS name is a string and not empty.
Signed-of... - 08:19 am Revision 58f0ce16: LUInstanceSetParams: Allow no-op change of instance offline status
- With this patch marking an instance already marked offline (or online)
as offline/online again becomes a no-op. Also ...
01/31/2012
- 02:32 pm Revision 545d0362: Fix type check for OpQuery.filter
- Just using ht.TListOf as a type check doesn't work correctly. The
function must be called with the expected item type... - 07:44 am Revision 3016bc1f: OpInstanceSetParams: Merge {off,on}line_inst parameters
- Instead of having two separate parameters, a single boolean parameter is
used. Unfortunately we need a third state to...
01/27/2012
- 05:44 pm Revision 784b6603: ipolicy: Make the keys of the dict consistent
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin ... - 04:56 pm Revision d4fcd298: admin.rst: add information about maxmem/minmem
- - Specify how maxmem and minmem are used at startup, failover and
migrate
- Add a paragraph about how to manually c... - 04:56 pm Revision 827ac163: N+1: verify using minimum memory
- Since instances can be started, failed over and migrated with less than
their maximum memory N+1 will use the minimum... - 04:56 pm Revision 2a50e2e8: walkthrough.rst: updates for maxmem/minmem
- - Fix two example outputs
- Improve N+1 resolution section specifying how different memories
affect N+1 calculation...
01/26/2012
- 08:45 pm Revision 3c1e4af0: Fix integer overflow in Node unittest
- When using a really random "extra cpus" variable, this can overflow
(especially on 32 bit) and thus the final value c... - 08:31 pm Revision f1dff7ec: Fix explanation of gnt-node evacuate --primaries-only
- Furthermore, correct the --help display on evacuate.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Mich... - 06:33 pm Revision e14ddb6e: Use allow_runtime_chgs in cmdlib
- - Report the attribute value in the hooks runtime variable.
- Use it to abort migration if not enough memory is avail... - 06:33 pm Revision 8c0b16f6: cli/opcodes: add a --no-runtime-changes migrate opt
- This will be used for now to avoid ballooning memory at live migration time.
Signed-off-by: Guido Trotter <ultrotter... - 06:33 pm Revision e57602c2: Migrate/Failover: allow less-than-max-mem op
- Failover works magically after we relax the check: the start operation
will just use less memory, if less memory is a... - 06:33 pm Revision c113a9ab: Failover and Migrate: acquire node resource locks
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 06:33 pm Revision 081d8528: cmdlib._CheckNodeFreeMemory: return free memory
- Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 04:30 pm Revision 1b01390b: doc/rapi.rst: Document ipolicy parameter
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 03:34 pm Revision e8fa4ff6: Add vcpu_ratio definition to the IPolicy type
- This will be "naturally" read in the JSON-based backends (Luxi/Rapi),
and we add explicit code for handling it in the... - 03:34 pm Revision 487e1962: Remove Node.mCpu, replaced with the ipol vcpu_ratio
- Since the iPolicy contains the vcpu_ratio now, we can remove the
per-node mCpu value (which was the initial way to se... - 03:34 pm Revision 5f3b040a: Temporary fix for hspace's NPU calculation
- hspace computes the NPU (normalised CPU units) via the
(used|pool|avail) VCPU divided by the (currently cluster-wide)... - 03:34 pm Revision 284e9822: Change meaning of the --max-cpu option
- Instead of always overriding, we should update the nodes's maxcpu
setting only when the option is specified. Otherwis... - 03:34 pm Revision e54d6628: Remove obsolete constant for vcpu_ratio
- This is superseded now.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 03:34 pm Revision 37483aa5: Expand the tiered alloc unittest to check allocation stats
- This was missing before, so with the new metric (NCpus), it's a good
time to test this.
Signed-off-by: Iustin Pop <i... - 03:34 pm Revision 90c2f1e8: Track 'normalised' used CPUs in Cluster.CStats
- This will be used in hspace for proper tracking of used/pool/unavail
npus.
Signed-off-by: Iustin Pop <iustin@google.... - 03:34 pm Revision 76a20994: Add a new type for holding allocation statistics
- The current RSpec type doesn't cut it anymore (and it's used in other
places), so let's introduce a separate type for... - 03:34 pm Revision 80d7d8a1: Switch over some hspace stats from RSpec to AllocInfo
- This patch changes the allocation delta stats from RSpec to
AllocInfo. There's nothing interesting about it, but it s... - 03:34 pm Revision 33e17565: Re-indent code for readability
- Otherwise the docstrings for members take too many lines.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by:... - 03:34 pm Revision 1e7acc3b: Fix gnt-cluster modify check of passed options
- … and add the disk_templates/vcpu_ratio new entries. Since the default
ispecs_* are dicts, we can't compare them to n... - 03:34 pm Revision e6244d00: Export the cluster ipolicy in iallocator
- And remove a strange comment (the commit which introduced it,
d61df03e, doesn't explain it). Also document these new ... - 03:34 pm Revision 976b78ba: Add ipolicy_vcpu_ratio to command line
- This allows changing this value from the command line.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Mi... - 01:53 pm Revision ff6c5e55: Add new ipolicy parameter vcpu_ratio
- This adds the new parameter and changes the validation routines to
handle IPOLICY_PARAMETER value as floats. Very ver... - 01:47 pm Revision ffa339ca: Clarification on what objects.InstancePolicy is
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 01:47 pm Revision 12378fe3: Rename IPOLICY_PARAMETERS to IPOLICY_ISPECS
- As opposed to the initial situation, the PARAMETERS will be more than
just the min/std/max ispecs. Let's rename it, b... - 01:46 pm Revision ad0e078e: Remove two extraneous imports
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 12:23 pm Revision c22341e6: Makefile.am: fix permissions for Python scripts on install
- Some Python scripts in /usr/lib/ganeti/ were getting the wrong permissions
(their 'x' bit was cleared). This patch f... - 12:22 pm Revision 40476293: devel/upload: Fix permissions for installed directories
- Permissions for the directories created during install depended on the
umask of the user running the script. Now uma...
01/25/2012
- 08:23 pm Revision 2c2f257d: Fix cluster verification issues on multi-group clusters
- This patch attempts to fix a number of issues with “gnt-cluster verify”
in presence of multiple node groups and DRBD8... - 03:36 pm Revision 735e1318: gnt-instance recreate-disks: Allow specifying new size
- With this change a new disk size can be specified when recreating disks.
Signed-off-by: Michael Hanselmann <hansmi@g... - 03:24 pm Revision cf572b13: LUClusterSetParams: When ipolicy is updated warn for new violations
- We need to loop over all node groups to apply their modification to make
sure that the new ipolicy actually affects t... - 03:24 pm Revision 68ab64cf: LUGroupSetParams: Warn if the new ipolicy will violate some ipolicies
- If we modify the ipolicy we need to verify if any instance would now
violate the new ipolicy and warn about it. Any i... - 03:24 pm Revision 92ff96e8: cmdlib: Add a helper function for a set of violating instances
- This helper will be used with the Op*SetParams and ipolicy verifications
Signed-off-by: René Nussbaumer <rn@google.c...
Also available in: Atom