Activity

From 02/09/2012 to 03/09/2012

03/09/2012

04:46 pm Revision 81f7ea25: Fix lint error in commit 035b33e2
Commit 035b33e2 forgot one blank space, and current pylint in Debian
Sid doesn't run on our code… so I didn't realise...
Iustin Pop

03/07/2012

11:35 pm Revision 7018af9c: Fix relocation test ClusterAllocRelocate
As for the evacuate tests, we require a mirrored disk template, but
otherwise the test should work for both mirror ty...
Iustin Pop
11:34 pm Revision 3d7d3a1f: Fix IAlloc.processRelocate to support shared storage
Currently, this function expects (but doesn't really check! only via
secondary node being defined) a DRBD8 template t...
Iustin Pop
11:31 pm Revision ac1c0a07: Fix up Cluster nodeEvac unittests for shared storage
Currently, these presume that the instance being generated always is
DRBD/relocatable (but won't be in the future), a...
Iustin Pop
11:25 pm Revision a593113c: Small improvement for nicer unit-testing
In case you just run "make htools/test" to recompile the unittests,
the old .tix file should be removed, otherwise yo...
Iustin Pop
11:24 pm Revision bebe7a73: Add a simple type alias for nicer type signatures
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
Iustin Pop
11:24 pm Revision 80b27509: Rework evacDrbdSecondaryInner to take the imove
Instead of hard-coding the instance move operation, let's accept is as
a parameter from the caller. This is the singl...
Iustin Pop
11:24 pm Revision c6e8fb9c: Fix a few tests that hard-coded the number of nodes
Instead of randomly generating the number of required nodes or
hard-coding it, compute it from the disk template of t...
Iustin Pop
11:18 pm Revision 90669369: Fix test Node_addSec_idempotent
Another test that only works for DRBD8 instances.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido T...
Iustin Pop
11:17 pm Revision e7b4d0e1: Fix the Node_rMem test to specify DRBD8 templates
… since memory reservation only is used for this template.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by...
Iustin Pop
11:17 pm Revision c6b7e804: Split the Node_addOffline test into pri/sec
Currently, this (single) test checks whether we can add an instance as
primary and secondary to a given node. This wo...
Iustin Pop
11:05 pm Revision 5f4464db: Use the mirror type in Cluster.possibleMoves
Currently the function possibleMoves always presumes DtDrbd, which is
wrong for shared storage. To make it work with ...
Iustin Pop
11:05 pm Revision 810d051f: iPolicy: enable by default all storage templates
… otherwise we can't run tests or simulations using non-default
templates. Tests still pass.
Signed-off-by: Iustin P...
Iustin Pop
11:05 pm Revision 255d140d: Fix printSolutionLine to handle big scores
Currently we don't set a boundary on the length of the score field,
which breaks all our nicely-aligned output effort...
Iustin Pop
11:05 pm Revision e85444d0: Fix printSolutionLine to handle non-DRBD steps
Currently Cluster.printSolutionLine function always wants to print the
old and new secondary, and as such it fails (u...
Iustin Pop
11:05 pm Revision b906d7c1: Add a helper type and function for the mirror type
Currently we track the mirroring type as simply yes/no, with "yes"
meaning DRBD. This is not enough for handling shar...
Iustin Pop
11:04 pm Revision 73d12eab: Small simplification in tryBalance
Instead of computing the bad/good node lists separately (in effect
iterating twice over the all_nodes list and also c...
Iustin Pop
11:04 pm Revision 2c7b328c: Mark Rbd as a movable disk template
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
Iustin Pop
11:04 pm Revision a7667ba6: Do not rely on no-secondary for movable tests
Currently, the code in Loader.hs marks as un-movable any instances
which don't have a secondary. This is not valid fo...
Iustin Pop
11:04 pm Revision b7743258: Handle nodes without local storage
Our current cluster model is based on per-node storage, and as such we
don't handle shared disk templates. Until we c...
Iustin Pop
10:59 pm Revision 035b33e2: Fix tempfile reset code & test on newer Python
Python 2.7.3 (rc status) and 3.2.3/3.3 (rc, respectively alpha status)
have fixed http://bugs.python.org/issue12856 w...
Iustin Pop

03/06/2012

08:58 pm Revision 7bfb3367: Merge remote-tracking branch 'origin/devel-2.5'
Conflicts:
Makefile.am (trivial, test data files added on both branches)
lib/opcodes.py (trivial, ...
Iustin Pop

03/05/2012

11:17 pm Revision c55cc346: Split check-man-warnings into two
This moves the dashes check to a new check-man-dashes script.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed...
Iustin Pop
11:17 pm Revision 73d0e218: Rename check-man to check-man-warnings
Currently the check-man test is dependent on the MAN_HAS_WARNINGS
test, which made sense as long as the script only d...
Iustin Pop
11:17 pm Revision 9c45babb: Makefile: improve the fix for .DELETE_ON_ERROR
I've investigated more and it seems that .DELETE_ON_ERROR not working
is a bug/regression in some versions of make; t...
Iustin Pop

03/03/2012

09:46 pm Revision 4892d955: htools/ExtLoader: Bring the pieces together
This make it possible to load from an Ialloc file
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin...
René Nussbaumer
09:46 pm Revision 9899796b: htools/CLI: Adding new options to use ialloc as source
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
09:46 pm Revision 786c514c: htools/IAlloc: Adding loadData method for use as backend
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
09:46 pm Revision c3f8cb12: htools: Refactor some of IAlloc.readRequest to Hail
This makes it possible to reuse that function when we want to use IAlloc
as a data source backend
Signed-off-by: Ren...
René Nussbaumer
09:46 pm Revision 14fbd75b: hinfo: Adjust the verbosity
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer

03/01/2012

08:48 pm Revision d0a14556: hinfo: Gather and print group statistics
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer

02/29/2012

06:17 pm Revision f35ea63a: Explicitly remove the .x.in man pages on failure
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
06:17 pm Revision e8f936b0: More -- fixes
Because .DELETE_ON_ERROR doesn't work consistently (works when the
target we're talking about is a final target, but ...
Iustin Pop
04:22 pm Revision c3024b7e: htools: Adding printTable helper
This helper abstract away all the unlines and unwords call you've to do
after you got a formatTable back.
Signed-off...
René Nussbaumer
04:19 pm Revision 5c52dae6: Fixup a Node unittest
This fixes the prop_Node_rMem test, which cares about memory only;
otherwise we could fail due to other problems (e.g...
Iustin Pop
04:18 pm Revision ee4ffc8a: Allow overriding the target test count
This is not perfect, as the override applies identical target test
values to both the 'fast' and 'slow' tests (making...
Iustin Pop
04:18 pm Revision eae69eee: Add two more unittests for Node add/remove
These just test that add/remove are idempotent. This is not perfect,
as we use unsorted lists for some values (instea...
Iustin Pop
04:18 pm Revision 084565ac: Use the spindles metric in cluster scores
This makes balancing use the new metric.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René Nussbaumer ...
Iustin Pop
04:17 pm Revision 82f19570: Track instance-used spindles in node set/add/remove
This simply tracks the instance-used spindles (using hard-coded '1'
per instance), and additionally prevents addition...
Iustin Pop
04:17 pm Revision 7959cbb9: Shorten some function names
Since we use the functions always module-qualified, let's drop the
`instance` prefix and use a shorter one.
Signed-o...
Iustin Pop
04:17 pm Revision f87c9f5d: Simplify logic in Node operations
This patch adds two helper functions and uses them for a somewhat
simplified logic in the add/remove pri/sec node fun...
Iustin Pop
04:16 pm Revision 0c7d4422: htools: support spindles in simu backend
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Iustin Pop
04:16 pm Revision f951bd09: htools: support spindles in text load/save
If missing, we'll default to 1 spindle.
This also updates the text file format with the ipolicy, which was
forgotten...
Iustin Pop
04:16 pm Revision 34ace266: htools: add support for listing spindles for nodes
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Iustin Pop
04:16 pm Revision 8bc34c7b: htools: add spindle-related attribute to nodes
This adds the spindleCount, hiSpindles and instSpindles attributes.
The spindleCount is equivalent to spindle_count ...
Iustin Pop
04:15 pm Revision c22d4dd4: Add spindle ratio to htool's IPolicy
Just the usual data/type declarations, read/save in the text backend,
etc. Also does a bit of unit-test cleanup (the ...
Iustin Pop
03:33 pm Revision e2bdaf25: hinfo: Adding man page
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer

02/28/2012

05:02 pm Revision 19e310cc: hinfo: Reorganize the code to separate functions
Also rename some functions as they don't reflect their actions anymore
Signed-off-by: René Nussbaumer <rn@google.com...
René Nussbaumer
03:01 pm Revision 1fdfa87a: Two tiny fixed related to runtime functionality
Adds an assert and fixes a typo.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hans...
Iustin Pop
02:26 pm Revision 2922d2c5: hinfo: Adding basic skeleton based on hbal
It prints the information which hbal prints in a nice formatted manner and of
course without doing any actions. An ex...
René Nussbaumer

02/27/2012

06:37 pm Revision f624fa95: Fix man pages to not use unescaped --
I've seen that man pages, as generated by the version of pandoc we
use, show single dashes in option names instead of...
Iustin Pop
06:37 pm Revision 4f511a13: Add automated checking for non-escaped --
This checks to see if any man output has [em] in it, as that will not
be correctly show in ASCII. Unfortunately the c...
Iustin Pop
06:35 pm Revision cc67d8eb: Add job result descriptions to RAPI documentation
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
03:52 pm Revision fe8d2553: Remove a superfluous warning in LUNodeRemove
Since we run the post-hooks explicitly in the Exec() function (via
_RunPostHook) after we removed the target node fro...
Iustin Pop

02/23/2012

06:00 pm Revision b02c6bdf: opcodes: Remove dependency on query module
There's no need to verify the field definitions on every query. They are
static for all intents and purposes anyway a...
Michael Hanselmann
05:59 pm Revision a0a63e76: Merge branch 'stable-2.5' into devel-2.5
* stable-2.5:
Fix Makefile.am compatibility with automake 1.11.2
Signed-off-by: Michael Hanselmann <hansmi@google....
Michael Hanselmann

02/22/2012

03:13 pm Revision d859a2cf: http.server: Factorize request handling even more
This splits even more parts of the request handling code into a separate
class. Doing so allows us to reuse this part...
Michael Hanselmann
03:12 pm Revision 377ae13e: http.server: Move error message formatting to handler class
Like before this patch moves more functionality from the actual server
class into a separate handler class. At the sa...
Michael Hanselmann
03:12 pm Revision cca5b3fc: noded: Shorter docstring for mlockall(2) executor
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Michael Hanselmann
03:12 pm Revision e0003509: Split handling HTTP requests into separate class
Until now HTTP requests were handled in the same class as incoming
connections (http.server.HttpServer). With this ch...
Michael Hanselmann
03:12 pm Revision c81f452f: http.server: Factorize request handling
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Michael Hanselmann
02:03 pm Revision 09037780: Remove deprecated “QueryLocks” LUXI request
This has been deprecated since Ganeti 2.4 and hasn't been used by
Ganeti's code since. I'm not aware of any external ...
Michael Hanselmann

02/21/2012

09:18 pm Revision 48796673: Add result checks for OpTags*
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Michael Hanselmann
05:34 pm Revision 415feb2e: opcodes: Annotate the OP_RESULT of query operations
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iusti...
René Nussbaumer
05:23 pm Revision 3ccb3a64: Replace single- with double-quotes
In at least two cases "%s" is replaced with str(), too.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Review...
Michael Hanselmann
04:34 pm Revision 0f85ebd9: Fix asyncnotifier unit tests
On my workstation, if I run the following two tests in this exact
order:
- TestSingleFileEventHandler.testError
- Te...
Iustin Pop
04:32 pm Revision 3bd0f3d8: Small fixup to rapi docstrings
The fast that most classes don't override the @cvars means that direct
references to FillOpcode can fail (they do on ...
Iustin Pop
04:32 pm Revision 09cbac87: Small update to LogicalUnit.ExpandNames docstring
… to make even more obvious what's the difference between a declared
lock level with an empty list of locks and no lo...
Iustin Pop
02:35 pm Revision 37e61a77: Export ndparams in RAPI node query
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
02:33 pm Revision 8930b0f0: Add ndp/* fields to group/node query
Also change the meaning of group ndparams to mean the actual (not
custom) nd params, and add custom_ndparams for the ...
Iustin Pop
02:33 pm Revision f25b8f58: Export ndparams in iallocator
Strangely, these were not exported at all before.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael...
Iustin Pop
02:32 pm Revision a194dc28: Add ipolicy parameter spindle_ratio
This will represent the instance (count) per spindle_count of their
node(s). Debatable whether we need to add a per-i...
Iustin Pop
02:32 pm Revision 432e8e2f: Add new spindle_count node parameter
Currently this is not handled by Ganeti, just recorded.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: M...
Iustin Pop
02:30 pm Revision 2a27dac3: Fix upgrading of ndparams
Currently, we only upgrade the ndparams if they are missing
completely, which creates problems if we add any new para...
Iustin Pop
02:28 pm Revision 765ada2b: Small fixes to objects.UpgradeDiskParams
Fix a typo, and cleanup the code a bit.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselman...
Iustin Pop

02/20/2012

06:57 pm Revision 202fb4e0: opcodes: Add result checks for OpBackup*
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
02:57 pm Revision 5fa3d337: Improve opcode result check test to have a whitelist
Only whitelisted opcodes may not have a result check.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed...
Michael Hanselmann
01:27 pm Revision 82c54b5b: config: Add check for disk's “iv_name”
This check verifies “iv_name” of all instance disks. If one is wrong
(which shouldn't happen in the first place), clu...
Michael Hanselmann
12:50 pm Revision aa12a891: opcodes: Fix OP_RESULT for OobCommand
The result is a list of a list with elements with size of 2.
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed...
René Nussbaumer
11:10 am Revision b8fe7ca6: Fix Makefile.am compatibility with automake 1.11.2
Automake 1.11.2 made the following change:
* Long-standing bugs:
- Automake now warns about more primary/directory...
Iustin Pop

02/17/2012

06:54 pm Revision 956631b6: cli: Handle negative numbers when parsing key-value assignments
To remove the last disk, or to add a NIC to the end, one can use the
index -1. This wouldn't work as intended as “-” ...
Michael Hanselmann
05:39 pm Revision 5401c39d: utils.text: Add function to truncate string
The function adds an ellipse if the string was actually truncated. Also
start using it in mcpu for result checks (whe...
Michael Hanselmann
03:16 pm Revision 8c2d770c: Fix breakage introduced by fa6dd6bb56
Forgot “enumerate”.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
03:16 pm Revision 0356a13d: LUInstanceSetParams: Update disk's “iv_name”
When modifications are made, disks may not have the same index anymore.
Updating all disks fixes this.
Signed-off-by...
Michael Hanselmann
01:34 pm Revision 35554b4f: ApplyContainerMods: Fix issues with indices
When adding an item the index given to the callback function would be
incorrect under certain conditions. This patch ...
Michael Hanselmann
12:52 pm Revision fa6dd6bb: cmdlib: Remove some users of “iv_name”
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Michael Hanselmann
12:52 pm Revision e2569c1d: ConfigWriter: Stop using “iv_name”
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Michael Hanselmann
12:52 pm Revision ea642319: ConfigWriter.RenameInstance: Stop using iv_name, safer operation
Stop using the disk index encoded in “iv_name” when renaming an instance.
This patch also changes the code to operat...
Michael Hanselmann
12:52 pm Revision a71f835e: gnt-instance modify: Support new-style NIC/disk modifications
This patch adds support for adding/removing NICs/disks at arbitrary
indices on the command line. To add a disk at a s...
Michael Hanselmann
10:59 am Revision c363310d: opcodes: Adding missing OP_RESULTs
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
10:59 am Revision ee938820: mcpu: Make the op result exception more verbose
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer

02/15/2012

06:35 pm Revision 1a1e7ab3: Reconcile Makefile.am and test data files
Sorry, forgot this in previous commit.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann...
Iustin Pop
05:43 pm Revision 048eeb2b: Workaround changed LVM behaviour
The vgreduce command has changed behaviour from when we initially
wrote the code (2.02.02 versus 2.02.66, 4 years del...
Iustin Pop
05:16 pm Revision 002f91c5: cmdlib: De-duplicate code in _GenerateDiskTemplate
There has been a lot of duplicated code in _GenerateDiskTemplate,
and some cases of very similar, but not quite same ...
Michael Hanselmann
05:16 pm Revision a8e3e009: Add unittest for cmdlib._GenerateDiskTemplate
This is in preparation to de-duplicating significant chunks of code in
cmdlib._GenerateDiskTemplate.
Signed-off-by: ...
Michael Hanselmann
12:20 pm Revision a85f23fa: rapi.testutils: Add exported functions to verify opcode input/result
These can be used by third-party code to verify mock code. Further work
on mocks is forthcoming, so this is only a st...
Michael Hanselmann

02/14/2012

02:44 pm Revision e6a8d799: cmdlib: Fix “unpack non-sequence” error
The callback is expected to return a two-valued tuple.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewe...
Michael Hanselmann

02/13/2012

08:04 pm Revision d505bc48: Fix doc bug introduced in 12637df
Commit 12637df changed/generalised how we build fields in the sphinx
extension, however it resulted in this uncaught-...
Iustin Pop
07:17 pm Revision bdd6931c: htools: allow rbd disk template
Notes:
- it'd be nice if there was a way to automatically generate the
DiskTemplate list instead of manually sp...
Guido Trotter
07:16 pm Revision efcfa99d: ApplyContainerMods: Return changes from callbacks
… instead of passing the list of changes as a parameter.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Revie...
Michael Hanselmann
05:44 pm Revision cd79cd83: Use the ipolicy constants for key names
Sorry, I missed this when I wrote the code originally.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Gu...
Iustin Pop
05:20 pm Revision c0f1033f: LUInstanceSetParams: Convert to generic algorithm for NIC/disk changes
Unfortunately this got a bit messier than I intended, but then again it
cleans up a lot of messy code with heaps of l...
Michael Hanselmann
05:20 pm Revision 8301885b: cmdlib: Add generic algorithm for modifying NICs/disks
While preparing this patch series I identified at least three different
implementations of the algorithm for adding/r...
Michael Hanselmann
04:02 pm Revision 0813170b: Fix unittest breakage after commit a2aadb34b
Thou shalt run “make check” before sending patches.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-b...
Michael Hanselmann
03:25 pm Revision b8925b86: LUInstanceSetParams: Assertion on disk template/disk changes
Disk changes aren't allowed at the same time as a disk template change.
Signed-off-by: Michael Hanselmann <hansmi@go...
Michael Hanselmann
03:23 pm Revision a2aadb34: OpInstanceSetParams: Make two type checks public
They'll be used for tests in cmdlib.py.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Po...
Michael Hanselmann
03:23 pm Revision e9c3d864: OpInstanceSetParams: Accept more flexible NIC/disk modifications
Start accepting a new form of NIC/disk modifications for adding/removing
arbitrary NICs/disks. Unlike before the inde...
Michael Hanselmann
03:23 pm Revision bf629e45: constants: Add constant for modifying existing NIC/disk
Until now it would not be possible to add/remove a NIC/disk in an
arbitrary position. This constant will be used in t...
Michael Hanselmann
03:23 pm Revision 20a32e74: opcodes: Add comments to two parameter tests
These comments appear in the RAPI documentation.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: ...
Michael Hanselmann

02/10/2012

05:10 pm Revision 7ed400f0: rbd disk template documentation and manpages
Add documentation and modify manpages for the RBD disk template.
Signed-off-by: Constantinos Venetsanopoulos <cven@g...
Stratos Psomadakis
« Previous
Next »
 

Also available in: Atom