Activity
From 04/21/2012 to 05/20/2012
05/16/2012
- 02:52 pm Revision 15b5f9a4: Fix a tiny typo
- Was showing in the man page as --diskN, without a space.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: ...
05/15/2012
- 06:48 pm Revision 38ef0c2c: constants: Add FIXME regarding CPU pinning bitfield
- Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:38 pm Revision 0c2e59ac: Beautify disk ipolicy violations in cluster-verify
- Currently, we only get:
instance3: ['disk-size value 512 is not in range [1024, 1048576]'
which doesn't explain w... - 02:38 pm Revision 0fd5547a: Fix _ComputeNewInstanceViolations logic
- This function did the opposite: was computing which old instance
violated the specs but no longer do it now. new - ol... - 02:38 pm Revision ea0f78c8: Beautify a couple of error messages
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 02:38 pm Revision d67e0a94: Allow units in ipolicy disk/mem CLI changes
- This makes "gnt-cluster modify --specs-mem-size max=16g" work. The
downside (due to how we iterate) is that error mes... - 02:38 pm Revision 703fa9ab: Move some ipolicy functions from objects to cli
- These are only used in CLI programs to parse command line options and
such they do not belong in object.py (I will ch... - 02:19 pm Revision 889bed16: qa_utils: Factorize code for getting entity name
- This reduces code duplication and provides better error messages if
something is incorrect while getting a node or in... - 02:19 pm Revision 1a4e4b17: NEWS: Style fixes
- - Quote where appropriate
- Small wording changes
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by:...
05/14/2012
- 08:32 pm Revision 2ac35588: qa_utils: Accept string as instance for check
- Some tests don't have access to an instance dictionary.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Review... - 06:38 pm Revision 51131cad: QA: Cleanup after commit 5fa0375e4a
- Some tests had wrong assumptions on the instance status and some
needed explicit start or stop commands.
Signed-off-... - 06:34 pm Revision e78a6817: LUInstanceCreate: Run rename script on instance import
- If an instance is imported with a different name, network settings may have to
be changed. Since import scripts may n... - 04:49 pm Revision d3b51156: ganeti.query_unittest: Adding testcase for diskparams
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 02:51 pm Revision 7228ca91: gnt-group add: Fix diskparam fill
- This was a pretty non-obvious bug. A cluster looks sane after
gnt-cluster init, however on a daemon restart the diskp... - 02:51 pm Revision b3230b32: gnt-group modify: Fix an update issue with diskparams
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:37 pm Revision 302424e7: Make x509 unittest testClockSkew a bit less flaky
- Since the tested function actually uses time.time(), it cannot be make
fully stable, but 1 second is very dangerous; ...
05/11/2012
- 05:20 pm Revision 216d23c0: gnt-group: Add info command
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:20 pm Revision 64da5a53: cli: Make FormatParameterDict recursive
- This is useful if you have nested parameter dicts like in diskparams.
Signed-off-by: René Nussbaumer <rn@google.com>... - 05:20 pm Revision 2c758845: query: Expose diskparamters through query
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:20 pm Revision f9bbf32b: gnt-cluster info: Print and format disk parameters
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 05:01 pm Revision 615b7a0f: Merge branch 'devel-2.5'
- * devel-2.5:
Update NEWS and bump version for 2.5.1 release
Fix gnt-group --help display
Fix hardcoded Xen kern... - 04:40 pm Revision 5fa90892: Merge commit 'v2.5.1' into devel-2.5
- * commit 'v2.5.1':
Update NEWS and bump version for 2.5.1 release
Fix gnt-group --help display
Fix hardcoded Xe... - 03:38 pm Revision 1a63f285: Remove some duplicate code in the Xen config writing
- Should be straightforward; the only difference from before is that we
will remove the 'auto' file even during migrati... - 01:01 pm Revision ef2d1c57: Update NEWS and bump version for 2.5.1 release
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 12:03 pm Revision 3ad56046: Fix gnt-group --help display
- Copy-paste mismatch :)
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Bernardo Dal Seno <bdalseno@google... - 12:03 pm Revision 3ac3de7a: Fix hardcoded Xen kernel path
- We already have a ./configure-time variable for this, but it seems to
be actually unused.
Signed-off-by: Iustin Pop ... - 12:03 pm Revision b53874cb: Fix grow-disk handling of invalid units
- The reason why grow-disk was doing:
$ gnt-instance grow-disk instance3 0 -64
Unhandled Ganeti error: Invalid format
... - 12:03 pm Revision 37c4d509: Accept both PUT and POST in noded
- This is a partial cherry-pick from
7530364ddbe949bc34fc26f25ba3f5d921beb021 on master:
Currently, noded requires PUT... - 12:02 pm Revision 3bdca55d: Preserve bridge MTU in KVM ifup script
- Closes: #201 - KVM_IFUP does not set bridge-MTU on tap devices
Signed-off-by: Andrea Spadaccini <spadaccio@google.com... - 12:02 pm Revision 0fc1764f: Update synopsis for “gnt-cluster repair-disk-sizes”
- Mention that instances can be passed on the CLI when “--help” is used.
Signed-off-by: Michael Hanselmann <hansmi@goo... - 12:02 pm Revision b3222537: Reconcile Makefile.am and test data files
- Sorry, forgot this in previous commit.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann... - 12:02 pm Revision 4c5dd3ff: Workaround changed LVM behaviour
- The vgreduce command has changed behaviour from when we initially
wrote the code (2.02.02 versus 2.02.66, 4 years del... - 12:02 pm Revision 078cd57d: Enable lvmstrap to run under Linux 3.x
- Extend the kernel version check to also accept Linux 3.x as valid.
Signed-off-by: Alexander Schreiber <als@google.co...
05/10/2012
- 02:56 pm Revision af9fb4cc: apidoc: Fix some typos and errors introduced by my previous patches
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:30 pm Revision 5ff82cc9: bdev: Add a guard to verify disk parameters are set
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:30 pm Revision b3f0d718: LUGroup*: Fix inheritance of disk parameters
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:30 pm Revision c7c6606d: bdev: Take the params directly from disk without refill
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:30 pm Revision 769b0bde: Special case blockdev_find
- Similiar to blockdev_create we sometimes do find on children. This fixes
those cases. However, this is not very nice.... - 02:30 pm Revision fc5bb0fe: Special case blockdev_create
- This is due to the nature of bdev. We spread some logic into cmdlib and
deal for example with it's children recursive... - 02:30 pm Revision 887b52e8: cmdlib: Adding annotation helper for special cases
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:30 pm Revision 99ccf8b9: cmdlib: Remove all diskparams calculations not required anymore
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:30 pm Revision 62bfbc7d: cmdlib: Adapt the rpc calls
- The following (blockdev) RPC calls are not converted yet (as they are
not straight forward or need more research):
*... - 02:30 pm Revision c7ea9827: rpc: Adapt the callbacks to the new encoder type
- We change the cmdlib side on the next patch.
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop ... - 02:30 pm Revision aedf5fd7: rpc: Adding new encoders for annotating disk parameters
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:30 pm Revision cd46491f: rpc: Adding helper to annotate disk params
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:30 pm Revision 8a147bba: config: Adding convenience method for disk parameters
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:30 pm Revision 57987785: objects: Add helper function to fill disk parameters
- Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 02:02 pm Revision 5fa0375e: QA: Decorate tests with instance checks
- Start using “InstanceCheck” decorator where appropriate. Use direct call
for check in places where the instance statu... - 02:02 pm Revision c9e05005: QA: Infrastructure for hook script to check instance status
- This script can be used to check if an instance is running or stopped at
various points during a QA run. Environment ... - 02:02 pm Revision 741c6d91: QA: Support passing keyword arguments to test functions
- Until now this wasn't possible.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iusti...
05/09/2012
- 12:31 pm Revision 9a6ade06: Add a default PATH variable to OS scripts env
- In commit 896a03f6 I cleaned up the environment for OS scripts,
however I think that was a bit too extreme - it break... - 12:31 pm Revision aa7b59ac: Move hooks PATH environment variable to constants
- Move the contents of the PATH environment variable for hooks to
constants, and use its value in the code and in the h... - 12:17 pm Revision 12f9d75e: Add note to the install doc about bridge MAC issues
- Thanks to Faidon Liambotis for explaining this on the external IRC
channel.
Signed-off-by: Iustin Pop <iustin@google... - 12:17 pm Revision 98dfcaff: Fix exception re-raising in Python Luxi clients
- Commit e687ec01 (present in 2.5 since the 2.5 beta 3) did consistency
fixes across the code-base. Unfortunately this ... - 12:12 pm Revision f97a7ada: Allow clock skews in certificate verification
- Currently we allow for up to NODE_MAX_CLOCK_SKEW time difference
between nodes in some operations, but not everywhere... - 12:10 pm Revision ff779c32: Improve formatting in the hooks documentation
- The pyeval role generates literal (e.g. ``OP_CLUSTER…``) formatting,
which differs from the other headers. This is co...
05/08/2012
- 01:37 pm Revision cdd495ae: Add decoding of Luxi calls and unittests for LuxiOp
- This patch adds a hand-coded decoder for LuxiCall arguments, as the
data-structure is not uniform enough for automate... - 01:37 pm Revision 5cefb2b2: Some unit tests improvements
- In preparation for unit-testing the Luxi definitions, this improves
the auto-generation of OpCodes: currently this us... - 01:37 pm Revision 95d0d502: Auto-define a LuxiReq data type
- We currently auto-generate a LuxiOp data type, which holds the entire
operation (including parameters). However, havi... - 01:37 pm Revision fae980e5: Replace hardcoded constants with Constants.hs names
- Now that luxi.py constants are exported, we can use them for more
consistency.
Signed-off-by: Iustin Pop <iustin@goo... - 01:37 pm Revision f11e524b: Fix Makefile dependencies for building Constants.hs
- I was wondering why my changes to luxi.py did not trigger the rebuild…
Signed-off-by: Iustin Pop <iustin@google.com>... - 01:37 pm Revision 83c046a2: Correct capitalisation of two Luxi calls
- Two Luxi calls have inconsistent an name/value mapping (in the Python
code):
- REQ_AUTOARCHIVE_JOBS versus AutoArchi... - 01:37 pm Revision 3ad57194: Add a new JSON function
- And its associated unittests.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René Nussbaumer <rn@google....
05/07/2012
- 03:16 pm Revision c6d992c5: Add design document for query path splitting
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René Nussbaumer <rn@google.com> - 11:33 am Revision a1f38213: Fix LVM volume listing with newer LVM
- Per commit 0304f0e, newer LVM has extended the lv_attr field. However,
that commit was incomplete as we examine this ... - 11:19 am Revision 09dc9a02: Implement support for multi-module export
- This add support for exporting constants from multiple modules (as
opposed to hard-coding constants), and also makes ... - 11:19 am Revision 79a04823: Implement reverse mapping of values to names
- This adds a bit of dumb mapping of values to names, while trying to be
safe. This is the best we can do without resor...
05/04/2012
- 03:37 pm Revision 3d371913: Add missing qa/__init__.py file
- The file was there and listed in Makefile.am, but I forgot to add it to
commit a0c3e7264a.
Signed-off-by: Michael Ha... - 03:27 pm Revision 1be35bef: QA: Fix shutdown for reinstall/rename tests
- The “RunTestIf” uses an AND association between the passed test names,
so the instance would be be shut down if both ... - 03:27 pm Revision a0c3e726: QA: Enable use of OR conditions in test checks
- Until now “TestRunIf” and “TestEnabled” could only handle AND. With this
patch a new class named “Either” is added to...
05/01/2012
- 08:11 pm Revision 79ac58fa: Further fixes for new-style exception handling
- Commit 30d25dd8 moved the htools code to new-style exception handling,
but the hconfd code hasn't been, which fails w... - 01:11 am Revision 4023aa72: Add NEWS entry for paramiko/pycrypto warnings
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Bernardo Dal Seno <bdalseno@google.com>
04/27/2012
- 05:41 pm Revision c8bde61e: Fix grow-disk handling of invalid units
- The reason why grow-disk was doing:
$ gnt-instance grow-disk instance3 0 -64
Unhandled Ganeti error: Invalid format
... - 12:46 pm Revision 59e67682: Fix rapi.testutils unittest
- Since we use a testutils.InputTestClient(), then the actual error
expected is VerificationError, and not GanetiApiErr... - 11:00 am Revision f1bebf4c: Make setup-ssh behave more friendly
- So while testing my previous patch I run setup-ssh manually without
any arguments, and it did nothing (no complains, ... - 11:00 am Revision 3ec10f0d: Silence Paramiko deprecation warnings
- This works around a problem in Paramiko, but which looks like it's a
Ganeti problem:
[cluster] root@node4:~# gnt-nod...
04/26/2012
- 10:42 pm Revision 1afa108c: Add more RAPI test utilities
- This patch adds a mock RAPI client to test input values to methods. All
methods either raise an exception if there wa... - 10:42 pm Revision 3ade0e0e: Add example script for using RAPI test utilities
- This script shows a few examples on how to use the RAPI input test
client. It is also run at “make check” time to ens... - 10:33 pm Revision d9492490: rapi.testutils.FakeCurl: Add header support
- With this patch headers are constructed from the PycURL options
and passed to the mock implementation.
Signed-off-by... - 10:33 pm Revision f90a1ab5: Move _FakeCurl from tests/ganeti.rapi.client to ganeti.rapi.testutils
- This is preparation for the mock system, where we need the same cURL
mock.
Signed-off-by: René Nussbaumer <rn@google... - 10:33 pm Revision 352e1a26: errors: Add exception for RAPI testing utilities
- This exception is raised to abort before actually sending a LUXI call
(there is no LUXI server involved in the test).... - 09:11 pm Revision abe318b3: server.rapi: Factorize RAPI user loading
- By moving the code loading RAPI users from a file into a standalone
function it becomes easier to use the RAPI reques... - 09:11 pm Revision e3a25810: luxi: Add list of all requests
- This will be used in a unittest for RAPI testing utilities.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Re... - 09:11 pm Revision da04c447: RemoteApiHandler: Add support for mocked LUXI client
- This will be used for providing a type-checking RAPI client for tests.
Signed-off-by: Michael Hanselmann <hansmi@goo... - 06:41 pm Revision ef8270dc: Add absolute grow-disk mode at CLI level
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 06:41 pm Revision 26a5056d: Add grow-disk tests in QA
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 06:41 pm Revision f5e6a62c: Man page update for grow-disk
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com> - 06:41 pm Revision e7f99087: Add 'absolute' grow-disk mode at OpCode/LU level
- This also improves the log messages for the (default) relative mode
("by %s to %s").
Signed-off-by: Iustin Pop <iust... - 06:40 pm Revision fa47242b: Ensure that the grow disk amount is positive
- The CLI currently doesn't permit this, but a direct job submission
would allow it.
Signed-off-by: Iustin Pop <iustin... - 05:17 pm Revision 21864565: Log all external commands execution
- This logs all external commands in normal (non-debug) mode. This will
leak the DRBD secrets, but in any case we do lo...
04/23/2012
- 05:52 pm Revision 59a8fe48: QA: Add default setting for tests
- Commit 1010ec70b1 enabled all tests by default. In some scenarios where
the configuration is static one may not want ...
Also available in: Atom