Activity

From 05/07/2012 to 06/05/2012

06/05/2012

08:02 pm Revision 69a15dd7: QA: Add default setting for tests
Commit 1010ec70b1 enabled all tests by default. In some scenarios where
the configuration is static one may not want ...
Michael Hanselmann
06:58 pm Revision b498540e: QA: add toggle for fewer common instance tests
Currently, the "common" instance tests (shutdown, rapi stopped
console, stopped modify, startup, rapi shutdown, rapi ...
Iustin Pop
06:58 pm Revision 710bc88c: QA: stop logging SSH arguments for each invocation
Currently, this is how the QA log looks like:
Command: ssh -oEscapeChar=none -oBatchMode=yes -l root -t -oStrictHost...
Iustin Pop
04:42 pm Revision f14a8b15: Switch QA to tty-less mode
This makes ssh generate much less noise when QA is run itself without
a tty, as otherwise we get thousands of lines o...
Iustin Pop

06/01/2012

06:12 pm Revision e375fb61: Fix a type issue and bad logic in cluster verification
Commit 2e04d454 introduced the new offline state for the instance
state, but being a big monolithic patch it sneaked ...
Iustin Pop
12:52 pm Revision 4b5a9365: Make the xen-cmd test more readable and portable
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
René Nussbaumer

05/31/2012

06:05 pm Revision db620e95: doc/hooks: Clarify hook directory structure
I was not able to find where the “.d” suffix is documented, so this
clarification should make it more obvious.
Signe...
Michael Hanselmann
12:09 pm Revision 0625d08f: Support xl as a xen interface command
xm and xl are mostly compatible, there is just a change in migrate,
which for now we simple bridge by comparing the c...
René Nussbaumer
12:08 pm Revision 1eb37421: Add XEN_CMD to _autoconf.py
This is needed so we can specify the xen command upon configure time
Signed-off-by: René Nussbaumer <rn@google.com>
...
René Nussbaumer

05/30/2012

02:08 pm Revision 592eb0df: Fix GenericCurlConfig when pycurl is linked against nss
Redhat links its pycurl against NSS/ so this check fails and therefore
makes ganeti-watcher unusable.
Even though th...
René Nussbaumer
12:41 pm Revision fcad6377: Fix a tiny typo in a design doc
Reported by user ewoud, thanks!
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René Nussbaumer <rn@googl...
Iustin Pop
11:31 am Revision 4a78c361: Merge branch 'stable-2.6'
* stable-2.6:
Document that the disk/hypervisor state is not used
Correct the watcher state files in the man page...
Iustin Pop

05/29/2012

03:48 pm Revision a1cef552: Document that the disk/hypervisor state is not used
This didn't get completed in time for 2.6, so we document that it's
not working as is. Well, it's not broken, just no...
Iustin Pop
12:13 pm Revision 4e3c9f2d: Correct the watcher state files in the man page
The move to per-group state files forgot to update the man page of
ganeti-watcher; let's fix this and add some more d...
Iustin Pop
12:12 pm Revision 40b068e5: Re-wrap some lines in watcher code
These were using exactly 80 chars, and I like them smaller.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-b...
Iustin Pop
12:09 pm Revision 36691f08: Add support for SIGHUP handling in Haskell daemons
This patch adds support for handling SIGHUP and reopening the
stdout/stderr logfile in daemon mode (but not in foregr...
Iustin Pop
12:09 pm Revision 0c28bee1: Rework logging setup for Haskell daemons
This fixes a missing functionality: closing of stdout/stderr when
forking daemons. Without this, starting the daemons...
Iustin Pop

05/24/2012

05:27 pm Revision aa9f166a: Update the INSTALL doc for Fedora users
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
05:27 pm Revision 47834a4f: Adapt example init.d script to work on Fedora
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
05:08 pm Revision 2803b47d: Merge branch 'stable-2.5' into stable-2.6
* stable-2.5:
kvm-ifup: Use /bin/bash
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Po...
Michael Hanselmann
11:44 am Revision 1817dca9: kvm-ifup: Use /bin/bash
As reported by Ben Beuchler, kvm-ifup uses bash-specific constructs and
doesn't work with Ubuntu's default shell. We ...
Michael Hanselmann

05/23/2012

03:24 pm Revision 43c16a8a: Merge branch 'stable-2.6'
* stable-2.6:
Version bump for 2.6.0~beta1
Adjust cfgupgrade for new minor version
Add support to daemon-util f...
Iustin Pop
03:03 pm Revision 106ee697: Merge branch 'devel-2.6' into stable-2.6
It seems Michael submitted the daemon-util patch on devel-2.6, and I
didn't realise it. It's way too early in the rel...
Iustin Pop
01:20 pm Revision aff49a15: Version bump for 2.6.0~beta1
Finally!
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
01:20 pm Revision 93fd9bb1: Adjust cfgupgrade for new minor version
Also does some abstracting of the versions.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanse...
Iustin Pop
11:49 am Revision 07c7c94a: Add support to daemon-util for distributions without start-stop-daemon
This adds support to daemon-util for Red Hat based distributions that
do not have a start-stop-daemon. If /sbin/start...
Jun Futagawa

05/22/2012

05:02 pm Revision 3f84531d: Fix NEWS file
Too many empty lines…
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Iustin Pop
05:02 pm Revision f0fa05ac: Improve the check-news script
Allow all errors to be displayed, instead of aborting at the first
one, and don't show stacktraces anymore.
Signed-o...
Iustin Pop
02:01 pm Revision ef40c537: _MaybeParseUnit: The elements are dicts not arrays
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
11:25 am Revision cd415612: Make it possible to reset vcpu/spindle ratio to default
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
11:17 am Revision a6c79f3a: Fix hardcoded paths in gnt-cluster.rst man page
Also reworks a bit the sentence and fixes a typo.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael...
Iustin Pop
11:17 am Revision ff39194f: Add man page documentation for cpu_mask hv parameter
This is adapted from the design doc.
Also fixes a typo in cmdlib.py.
Signed-off-by: Iustin Pop <iustin@google.com>
...
Iustin Pop
11:17 am Revision 387863a5: Add checks from wrong hard-coded paths in manpages
This is trivial, but should prevent such things in the future.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewe...
Iustin Pop
11:17 am Revision f67cca80: First round of NEWS file updates for 2.6
More will come, this is just what I took from the existing NEWS
entries.
Signed-off-by: Iustin Pop <iustin@google.co...
Iustin Pop
10:56 am Revision eb70f6cf: gnt-group: Adding vcpu/spindle ratio to ipolicy flags
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
10:56 am Revision 31d827d1: gnt-cluster modify: Add ipolicy for spindle ratio opt
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
10:56 am Revision ad5cc6bd: cli: Add ipolicy_spindle_ratio to CreateIPolicyFromOpts
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer

05/21/2012

01:43 pm Revision 4b42c3d6: Add support to daemon-util for distributions without start-stop-daemon
This adds support to daemon-util for Red Hat based distributions that
do not have a start-stop-daemon. If /sbin/start...
Jun Futagawa
12:21 pm Revision 83d4ba5e: gnt-instance info: Rework beparams listings
This patch reworks the beparams listing to the new style. However, due
to this process the naming of the fields with ...
René Nussbaumer

05/16/2012

02:52 pm Revision 15b5f9a4: Fix a tiny typo
Was showing in the man page as --diskN, without a space.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: ...
Iustin Pop

05/15/2012

06:48 pm Revision 38ef0c2c: constants: Add FIXME regarding CPU pinning bitfield
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
02:38 pm Revision 0c2e59ac: Beautify disk ipolicy violations in cluster-verify
Currently, we only get:
instance3: ['disk-size value 512 is not in range [1024, 1048576]'
which doesn't explain w...
Iustin Pop
02:38 pm Revision 0fd5547a: Fix _ComputeNewInstanceViolations logic
This function did the opposite: was computing which old instance
violated the specs but no longer do it now. new - ol...
Iustin Pop
02:38 pm Revision ea0f78c8: Beautify a couple of error messages
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
02:38 pm Revision d67e0a94: Allow units in ipolicy disk/mem CLI changes
This makes "gnt-cluster modify --specs-mem-size max=16g" work. The
downside (due to how we iterate) is that error mes...
Iustin Pop
02:38 pm Revision 703fa9ab: Move some ipolicy functions from objects to cli
These are only used in CLI programs to parse command line options and
such they do not belong in object.py (I will ch...
Iustin Pop
02:19 pm Revision 889bed16: qa_utils: Factorize code for getting entity name
This reduces code duplication and provides better error messages if
something is incorrect while getting a node or in...
Michael Hanselmann
02:19 pm Revision 1a4e4b17: NEWS: Style fixes
- Quote where appropriate
- Small wording changes
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by:...
Michael Hanselmann

05/14/2012

08:32 pm Revision 2ac35588: qa_utils: Accept string as instance for check
Some tests don't have access to an instance dictionary.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Review...
Michael Hanselmann
06:38 pm Revision 51131cad: QA: Cleanup after commit 5fa0375e4a
Some tests had wrong assumptions on the instance status and some
needed explicit start or stop commands.
Signed-off-...
Michael Hanselmann
06:34 pm Revision e78a6817: LUInstanceCreate: Run rename script on instance import
If an instance is imported with a different name, network settings may have to
be changed. Since import scripts may n...
Michael Hanselmann
04:49 pm Revision d3b51156: ganeti.query_unittest: Adding testcase for diskparams
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
René Nussbaumer
02:51 pm Revision 7228ca91: gnt-group add: Fix diskparam fill
This was a pretty non-obvious bug. A cluster looks sane after
gnt-cluster init, however on a daemon restart the diskp...
René Nussbaumer
02:51 pm Revision b3230b32: gnt-group modify: Fix an update issue with diskparams
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
12:37 pm Revision 302424e7: Make x509 unittest testClockSkew a bit less flaky
Since the tested function actually uses time.time(), it cannot be make
fully stable, but 1 second is very dangerous; ...
Iustin Pop

05/11/2012

05:20 pm Revision 216d23c0: gnt-group: Add info command
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
05:20 pm Revision 64da5a53: cli: Make FormatParameterDict recursive
This is useful if you have nested parameter dicts like in diskparams.
Signed-off-by: René Nussbaumer <rn@google.com>...
René Nussbaumer
05:20 pm Revision 2c758845: query: Expose diskparamters through query
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
05:20 pm Revision f9bbf32b: gnt-cluster info: Print and format disk parameters
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
05:01 pm Revision 615b7a0f: Merge branch 'devel-2.5'
* devel-2.5:
Update NEWS and bump version for 2.5.1 release
Fix gnt-group --help display
Fix hardcoded Xen kern...
Iustin Pop
04:40 pm Revision 5fa90892: Merge commit 'v2.5.1' into devel-2.5
* commit 'v2.5.1':
Update NEWS and bump version for 2.5.1 release
Fix gnt-group --help display
Fix hardcoded Xe...
Iustin Pop
03:38 pm Revision 1a63f285: Remove some duplicate code in the Xen config writing
Should be straightforward; the only difference from before is that we
will remove the 'auto' file even during migrati...
Iustin Pop
01:01 pm Revision ef2d1c57: Update NEWS and bump version for 2.5.1 release
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Iustin Pop
12:03 pm Revision 3ad56046: Fix gnt-group --help display
Copy-paste mismatch :)
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Bernardo Dal Seno <bdalseno@google...
Iustin Pop
12:03 pm Revision 3ac3de7a: Fix hardcoded Xen kernel path
We already have a ./configure-time variable for this, but it seems to
be actually unused.
Signed-off-by: Iustin Pop ...
Iustin Pop
12:03 pm Revision b53874cb: Fix grow-disk handling of invalid units
The reason why grow-disk was doing:
$ gnt-instance grow-disk instance3 0 -64
Unhandled Ganeti error: Invalid format
...
Iustin Pop
12:03 pm Revision 37c4d509: Accept both PUT and POST in noded
This is a partial cherry-pick from
7530364ddbe949bc34fc26f25ba3f5d921beb021 on master:
Currently, noded requires PUT...
Iustin Pop
12:02 pm Revision 3bdca55d: Preserve bridge MTU in KVM ifup script
Closes: #201 - KVM_IFUP does not set bridge-MTU on tap devices
Signed-off-by: Andrea Spadaccini <spadaccio@google.com...
Andrea Spadaccini
12:02 pm Revision 0fc1764f: Update synopsis for “gnt-cluster repair-disk-sizes”
Mention that instances can be passed on the CLI when “--help” is used.
Signed-off-by: Michael Hanselmann <hansmi@goo...
Michael Hanselmann
12:02 pm Revision b3222537: Reconcile Makefile.am and test data files
Sorry, forgot this in previous commit.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael Hanselmann...
Iustin Pop
12:02 pm Revision 4c5dd3ff: Workaround changed LVM behaviour
The vgreduce command has changed behaviour from when we initially
wrote the code (2.02.02 versus 2.02.66, 4 years del...
Iustin Pop
12:02 pm Revision 078cd57d: Enable lvmstrap to run under Linux 3.x
Extend the kernel version check to also accept Linux 3.x as valid.
Signed-off-by: Alexander Schreiber <als@google.co...
Alexander Schreiber

05/10/2012

02:56 pm Revision af9fb4cc: apidoc: Fix some typos and errors introduced by my previous patches
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
02:30 pm Revision 5ff82cc9: bdev: Add a guard to verify disk parameters are set
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
02:30 pm Revision b3f0d718: LUGroup*: Fix inheritance of disk parameters
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
02:30 pm Revision c7c6606d: bdev: Take the params directly from disk without refill
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
02:30 pm Revision 769b0bde: Special case blockdev_find
Similiar to blockdev_create we sometimes do find on children. This fixes
those cases. However, this is not very nice....
René Nussbaumer
02:30 pm Revision fc5bb0fe: Special case blockdev_create
This is due to the nature of bdev. We spread some logic into cmdlib and
deal for example with it's children recursive...
René Nussbaumer
02:30 pm Revision 887b52e8: cmdlib: Adding annotation helper for special cases
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
02:30 pm Revision 99ccf8b9: cmdlib: Remove all diskparams calculations not required anymore
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
02:30 pm Revision 62bfbc7d: cmdlib: Adapt the rpc calls
The following (blockdev) RPC calls are not converted yet (as they are
not straight forward or need more research):
*...
René Nussbaumer
02:30 pm Revision c7ea9827: rpc: Adapt the callbacks to the new encoder type
We change the cmdlib side on the next patch.
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop ...
René Nussbaumer
02:30 pm Revision aedf5fd7: rpc: Adding new encoders for annotating disk parameters
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
02:30 pm Revision cd46491f: rpc: Adding helper to annotate disk params
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
02:30 pm Revision 8a147bba: config: Adding convenience method for disk parameters
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
02:30 pm Revision 57987785: objects: Add helper function to fill disk parameters
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
02:02 pm Revision 5fa0375e: QA: Decorate tests with instance checks
Start using “InstanceCheck” decorator where appropriate. Use direct call
for check in places where the instance statu...
Michael Hanselmann
02:02 pm Revision c9e05005: QA: Infrastructure for hook script to check instance status
This script can be used to check if an instance is running or stopped at
various points during a QA run. Environment ...
Michael Hanselmann
02:02 pm Revision 741c6d91: QA: Support passing keyword arguments to test functions
Until now this wasn't possible.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iusti...
Michael Hanselmann

05/09/2012

12:31 pm Revision 9a6ade06: Add a default PATH variable to OS scripts env
In commit 896a03f6 I cleaned up the environment for OS scripts,
however I think that was a bit too extreme - it break...
Iustin Pop
12:31 pm Revision aa7b59ac: Move hooks PATH environment variable to constants
Move the contents of the PATH environment variable for hooks to
constants, and use its value in the code and in the h...
Andrea Spadaccini
12:17 pm Revision 12f9d75e: Add note to the install doc about bridge MAC issues
Thanks to Faidon Liambotis for explaining this on the external IRC
channel.
Signed-off-by: Iustin Pop <iustin@google...
Iustin Pop
12:17 pm Revision 98dfcaff: Fix exception re-raising in Python Luxi clients
Commit e687ec01 (present in 2.5 since the 2.5 beta 3) did consistency
fixes across the code-base. Unfortunately this ...
Iustin Pop
12:12 pm Revision f97a7ada: Allow clock skews in certificate verification
Currently we allow for up to NODE_MAX_CLOCK_SKEW time difference
between nodes in some operations, but not everywhere...
Iustin Pop
12:10 pm Revision ff779c32: Improve formatting in the hooks documentation
The pyeval role generates literal (e.g. ``OP_CLUSTER…``) formatting,
which differs from the other headers. This is co...
Iustin Pop

05/08/2012

01:37 pm Revision cdd495ae: Add decoding of Luxi calls and unittests for LuxiOp
This patch adds a hand-coded decoder for LuxiCall arguments, as the
data-structure is not uniform enough for automate...
Iustin Pop
01:37 pm Revision 5cefb2b2: Some unit tests improvements
In preparation for unit-testing the Luxi definitions, this improves
the auto-generation of OpCodes: currently this us...
Iustin Pop
01:37 pm Revision 95d0d502: Auto-define a LuxiReq data type
We currently auto-generate a LuxiOp data type, which holds the entire
operation (including parameters). However, havi...
Iustin Pop
01:37 pm Revision fae980e5: Replace hardcoded constants with Constants.hs names
Now that luxi.py constants are exported, we can use them for more
consistency.
Signed-off-by: Iustin Pop <iustin@goo...
Iustin Pop
01:37 pm Revision f11e524b: Fix Makefile dependencies for building Constants.hs
I was wondering why my changes to luxi.py did not trigger the rebuild…
Signed-off-by: Iustin Pop <iustin@google.com>...
Iustin Pop
01:37 pm Revision 83c046a2: Correct capitalisation of two Luxi calls
Two Luxi calls have inconsistent an name/value mapping (in the Python
code):
- REQ_AUTOARCHIVE_JOBS versus AutoArchi...
Iustin Pop
01:37 pm Revision 3ad57194: Add a new JSON function
And its associated unittests.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René Nussbaumer <rn@google....
Iustin Pop

05/07/2012

03:16 pm Revision c6d992c5: Add design document for query path splitting
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Iustin Pop
11:33 am Revision a1f38213: Fix LVM volume listing with newer LVM
Per commit 0304f0e, newer LVM has extended the lv_attr field. However,
that commit was incomplete as we examine this ...
Iustin Pop
11:19 am Revision 09dc9a02: Implement support for multi-module export
This add support for exporting constants from multiple modules (as
opposed to hard-coding constants), and also makes ...
Iustin Pop
11:19 am Revision 79a04823: Implement reverse mapping of values to names
This adds a bit of dumb mapping of values to names, while trying to be
safe. This is the best we can do without resor...
Iustin Pop
« Previous
Next »
 

Also available in: Atom