Activity

From 06/19/2012 to 07/18/2012

07/18/2012

03:47 pm Revision 5dbee5ea: Ensure that disk.params is always defined (and a dict)
Commit cce46164 fixed upgrading from other 2.6 versions, but
accidentally broke upgrading from 2.5 (disk.params was l...
Iustin Pop
02:42 pm Revision 1b5b1c49: Another small consistency fix with if branches
While looking at the testability of this piece of code, I found another
consistency problem. We have two if branches ...
René Nussbaumer
02:01 pm Revision 734a2a7c: Fix inconsistency in the LUXI protocol w.r.t. args
This inconsistency was found during rebalancing. Hbal failed because,
Ganeti couldn't load the opcode. After digging ...
René Nussbaumer

07/17/2012

03:56 pm Revision cce46164: Fix UpgradeConfig of Disk object regards disk params
This bug was found during disk parameter debugging. While looking at the
config some values seem present on the disk ...
René Nussbaumer

07/13/2012

06:00 pm Revision 112aee5f: Merge branch 'stable-2.6'
* stable-2.6: (72 commits)
Make Ganeti 2.6.0 rc3 release
Allow reinstall even when secondaries are offline
Prep...
Iustin Pop
02:55 pm Revision 88e14195: Make Ganeti 2.6.0 rc3 release
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
René Nussbaumer
02:41 pm Revision 96c3d5d4: Allow reinstall even when secondaries are offline
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Agata Murawska <agatamurawska@google.com>
René Nussbaumer
02:40 pm Revision 3dbb3348: Prepare NEWS file for Ganeti 2.6.0 rc3
Update NEWS regarding rc3 fixes and document changes in behaviour.
Signed-off-by: René Nussbaumer <rn@google.com>
Re...
René Nussbaumer

07/11/2012

03:22 pm Revision c7e54e1d: QA updated to test instance removing when sec. is offline
Added test checking that it is possible to remove an instance with drbd
disk when non-primary node is offline.
Signe...
Agata Murawska
03:21 pm Revision 03e5cdd5: Ignore offline node errors when removing disks
When we delete DRBD disks from some instance, we do not want to get
errors due to nodes other than that instance's pr...
Agata Murawska

07/07/2012

11:16 am Revision d908ba61: Allow instance disc activation with offline secondaries
Currently, this is not allowed, so one can't run a replace-disks; this
breaks any non-invasive method of recovering t...
Iustin Pop

07/06/2012

04:53 pm Revision 76ae2e5b: Replace a few explicit case expressions
Since we're just talking about converting Maybe into another monad, we
can do that via the maybe function, instead of...
Iustin Pop
04:16 pm Revision 2db53645: Also compute Haskell tags in "make tags"
Note however that this won't work correctly with older compilers, due
to ghc issue #4256; however, it's a handy way t...
Iustin Pop
04:16 pm Revision 96eccc1f: Fix Haskell coverage results
There are two current issues with the coverage values:
- we don't import all modules, thus leading to incomplete
c...
Iustin Pop
04:16 pm Revision fce98abd: Cleanup the QC.hs file w.r.t. compiler options
Currently, we build the Haskell unittests with custom GHC flags,
because we (I) were quite lazy when initially writin...
Iustin Pop
03:29 pm Revision 28a45bfc: RAPI regression beparams/memory fix
For compatibility with the old Ganeti version, we want to keep the
beparams/memory field around for another release. ...
René Nussbaumer
01:37 pm Revision fc6075dd: Installation instructions update
This patch aims at improving documentation for installing ganeti - both for users and developers.
Signed-off-by: Aga...
Agata Murawska
12:11 pm Revision b647b6d7: Fix Query2.hs to compile without warnings
Since this is not yet used by any targets, we didn't detect yet the
compilation warnings. Just trivial exports/import...
Iustin Pop

07/05/2012

07:11 pm Revision 32da72f3: Ensure that --wait-for-sync is used in QA
We don't have a specific test for activate disks, so let's add it in
the cases where we run (incidentally) activate-d...
Iustin Pop
07:11 pm Revision f30d8165: Add --wait-for-sync in gnt-instance
Note that this needs (like for the opcode) a new option, with the
default reverted (False instead of True).
Signed-o...
Iustin Pop
07:11 pm Revision b69437c5: 9Add wait_for_sync flag to OpInstanceActivateDisks
This can be used to ensure that after activate-disks has returned, the
instance's storage is consistent; currently th...
Iustin Pop
04:09 pm Revision 2a2e2610: hbal: return exit status 0 in case of early exit
This derives from an internal bug, but the story is consistent across
both internal and external usage of hbal.
Basi...
Iustin Pop
03:20 pm Revision cad0723b: Fix DRBD resize code
There are two bugs in the current resize code, affecting mostly DRBD.
First, due to bugs in old DRBD versions (pre 8...
Iustin Pop
11:41 am Revision cc706abc: Fix redistribution of files w.r.t. offline nodes
Currently, _RedistributeAncillaryFiles computes two lists: the list of
online nodes (for all files redistribution), a...
Iustin Pop
11:35 am Revision 770461fe: Fix cluster verify error on master-ip-setup script
This error does not show up until we exceed the pool of master
candidates and have nodes which are not master candida...
René Nussbaumer

07/04/2012

05:05 pm Revision 3228c07a: Add test helpers to .gitignore
Commit 3096524e enabled building of test helpers, but forgot to add
them to .gitignore, resulting in "unclean" git st...
Iustin Pop
05:05 pm Revision 6438e259: Add a Makefile rule to test unclean git status
This is trivial, but can be used easily from automated builds to check
that the git tree is clean: files are not modi...
Iustin Pop

07/03/2012

04:05 pm Revision 4cc60473: Fix a typo in NEWS
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Bernardo Dal Seno <bdalseno@google.com>
René Nussbaumer
12:36 pm Revision 3ee4fd54: Release Ganeti 2.6.0rc2
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Agata Murawska <agatamurawska@google.com>
René Nussbaumer
11:19 am Revision 02902172: Prepare NEWS file for 2.6.0 rc2
We are about to release another version of Ganeti 2.6, so we prepare the
NEWS file with the changes from rc1 to rc2.
...
René Nussbaumer

06/29/2012

08:34 pm Revision 1279c691: Fix tiny typo in htools.rst
Backtracking through git blame, it turns out than commit 49148d15
changed "\fB20,102400,16384,4\fR" into "**B20,10240...
Iustin Pop
08:34 pm Revision f18e4168: Fix building of hcheck man page
The code used a space, not a tab, in Makefile.am, which means it
actually broke the variable declaring the man pages....
Iustin Pop
08:34 pm Revision b1a9d630: Remove can_rebalance functionality from hcheck
Since hbal can now run rebalances even in the presence of split
instances, we can remove this check and always run th...
Iustin Pop
08:34 pm Revision 0c76f280: Add hlint warning for wrong use of 'length'
While removing split instances check from hcheck, I saw a wrong use of
'length': this should only be used when one ne...
Iustin Pop
08:34 pm Revision 85890a9d: hcheck: reword and fix typo in instance/offline msg
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Agata Murawska <agatamurawska@google.com>
Iustin Pop
08:34 pm Revision 70b6c284: Update time on Haskell binaries after build
This patch works around an issue in our build system. Since we don't
use cabal or 'ghc -M', we don't track actual dep...
Iustin Pop
08:34 pm Revision 7f119c27: hcheck: add two simple type aliases for readability
The same types are reused a couple of times, so let's add a couple of
type aliases for easier change later and readab...
Iustin Pop
08:34 pm Revision 4b77c2a2: hcheck: rework output mode
Looking at the output of hcheck, in human readable mode, it looks like
it always starts with a blank line. This is no...
Iustin Pop
05:29 pm Revision 3891c95e: Fixed spaces/indentation according to guide lines
Problem introduced by commit 87f0aa4896ac4dfacc9d20bc55b0855282b4d1d4.
Signed-off-by: Bernardo Dal Seno <bdalseno@go...
Bernardo Dal Seno
04:35 pm Revision f55f0037: Fix small bug with a space in the hv_xen module's line
Remove a useless space at the end of the line in a config file.
Signed-off-by: Jack Sitnikov <sitnikove@gmail.com>
S...
Jack
11:38 am Revision f0d22861: Allow param `modify' during gnt-instance modify
With the new gnt-instance modify syntax for addition and removal of
disks/NICs on arbitrary indexes, we hit an assert...
Constantinos Venetsanopoulos

06/28/2012

11:38 pm Revision 87f0aa48: Add PCI passthrough for hvm xen
This hv parameter allows passing PCI devices to virtual machines.
Signed-off-by: Guido Trotter <ultrotter@google.com...
Jack
06:52 pm Revision cf279f03: Correct a wrong --help option for --simulate
This was not update when the alloc policy was added to the parameter.
Signed-off-by: Iustin Pop <iustin@google.com>
...
Iustin Pop
06:52 pm Revision a95aa74c: Add a shell test for hbal and split instances
This is not perfect, as we only test that hbal completes successfully
and that it show a score improvement, but it's ...
Iustin Pop
06:51 pm Revision a7e1fd89: hbal: relax restrictions on split instances
The recent patch series on hcheck made me realise how much pain we
have due to hbal not being able to work (at all) w...
Iustin Pop
12:39 pm Revision 5b93f2ec: Add newline at the end of shelltest files
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Agata Murawska
11:55 am Revision 19fe9138: Add forgotten unittest changes for instance_os_add
The previous patch which fixed disk parameters didn't adapt the
unittests so it lead to failing QA.
Signed-off-by: R...
René Nussbaumer
11:04 am Revision b8291e00: Annotate disk params on instance_os_add
We call _OpenRealBD during the process and this needs disk parameters to
work. This was reported by Constantinos.
Th...
René Nussbaumer
03:24 am Revision 81bcbbd3: Fix a few style issue in hcheck
This fixes a couple of issue I've seen while fixing the List import:
- removes over-use of printf with putStr/show
-...
Iustin Pop
03:24 am Revision 7568b296: Fix old-style import
Commit 1213f9d6 (re)added an old-style import, which fails with recent
compilers.
Signed-off-by: Iustin Pop <iustin@...
Iustin Pop

06/27/2012

05:19 pm Revision d64acbb5: Style fix in hcheck
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Agata Murawska
05:19 pm Revision 47ed1d79: Style fixes in shelltests
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Agata Murawska
05:19 pm Revision 3c0687b5: Simplify stats printing
PrintGroupStats and printClusterStats had very similar code
structure. This patch abstracts those two into printStats...
Agata Murawska
05:19 pm Revision 5cc97485: Cleaner simulation of rebalance
This replaces the 'if .. then .. else ..' with a large block of code in
'else' branch by separating this code into a ...
Agata Murawska
05:17 pm Revision b5b19d5e: Small reordering and renaming in hcheck
Reordered functions and shortened one function name.
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Review...
Agata Murawska
05:17 pm Revision caa97388: Move 'need rebalance' check from cluster check
As suggested by Rene, we should keep the check separate from printing.
Signed-off-by: Agata Murawska <agatamurawska@...
Agata Murawska
05:17 pm Revision ecc39665: Always print all variables in machine readable version
As discussed in cover letter of patch series introducing hcheck, in
machine readable version we should always print v...
Agata Murawska
05:17 pm Revision 592601b3: Print idx <-> uuid mappings in machine readable mode
As per Iustin Pop's suggestion, we are printing group mappings
from group idx (known only to htools) to group uuid, w...
Agata Murawska
05:17 pm Revision 5cdbde9a: Human readable group name improved
Instead of printing group id in human readable version of hcheck,
we now print group name.
Signed-off-by: Agata Mura...
Agata Murawska
05:17 pm Revision 92eacdd8: Print info about ability to rebalance
As suggested during offline discussion, this patch adds a new bash
variable and description field in hcheck, which in...
Agata Murawska
05:17 pm Revision e60fa4af: Improve readability for hcheck-related changes
As suggested by Rene, I added comments to types for printKeys
and printFinal. Also, realigned some lines in Hspace.
...
Agata Murawska
12:10 pm Revision a1cd2ecf: Fixed doclint warning
Two blank lines are needed between functions.
Signed-off-by: Bernardo Dal Seno <bdalseno@google.com>
Reviewed-by: Re...
Bernardo Dal Seno
11:03 am Revision 55de1d68: Annotate disks upon blockdev_shutdown
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Agata Murawska <agatamurawska@google.com>
René Nussbaumer
11:03 am Revision 4504bfcb: Annotate disks on blockdev_remove
This annotates the disks for the blockdev_remove where it is
appropriate. It leaves out 2 cases were we can't reliabl...
René Nussbaumer
11:02 am Revision b5cbddd9: Annotate disk params on blockdev_getmirrorstatus_multi
This is also related to the bug reported by Constantinos,
as we've only one getmirrorstatus_multi call in whole cmdli...
René Nussbaumer
11:02 am Revision 70817cee: Annotate disk parameters on blockdev_getmirrorstatus
Not annotating them works for DRBD but not for RBD as reported by
Constantinos.
Signed-off-by: René Nussbaumer <rn@g...
René Nussbaumer

06/26/2012

07:17 pm Revision 83180411: QA: Added test for gnt-instance recreate-disks
The test is disabled by default, as it takes a long time.
Signed-off-by: Bernardo Dal Seno <bdalseno@google.com>
Rev...
Bernardo Dal Seno
07:16 pm Revision 82d2f3df: QA function do destroy disks
This is useful to simulate HW problems during QA.
Signed-off-by: Bernardo Dal Seno <bdalseno@google.com>
Reviewed-by...
Bernardo Dal Seno

06/25/2012

05:58 pm Revision 80143203: Fix for man entry for htools - added hinfo
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Agata Murawska
05:58 pm Revision bad64bf4: Fixes in man page for hinfo
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Agata Murawska
05:58 pm Revision e0e3586a: Update to the install file - hinotify dependency
Hinotify was not marked as a dependency for hconfd.
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewe...
Agata Murawska
04:43 pm Revision 7ddd0118: Release Ganeti 2.6.0rc1
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by: Agata Murawska <agatamurawska@google.com>
René Nussbaumer
04:09 pm Revision 32708d0a: Add summary field to OpNodeModifyStorage
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: René Nussbaumer <rn@google.com>
Iustin Pop
11:55 am Revision 165b385b: Shelltestrunner tests for hcheck
Simple tests for hcheck using shelltestrunner. Among other, we check
that we can run hcheck on multi-group cluster.
...
Agata Murawska
11:55 am Revision 1213f9d6: Human readable hcheck functionality
Full hcheck functionality is implemented in this patch. Hcheck runs
per-group checks, provides summary for the entire...
Agata Murawska
11:55 am Revision 22b16dd0: Machine readable hcheck functionality
Machine readable output for hcheck.
Signed-off-by: Agata Murawska <agatamurawska@google.com>
Reviewed-by: René Nussb...
Agata Murawska
11:55 am Revision e6685c53: Allowing rebalance to run silently
Part of hcheck's simulation required us to silently run hbal. For that
purpose we expose iterateDepth and allow it to...
Agata Murawska
11:55 am Revision 79eef90b: Generalize functions used by both hspace and hcheck
As hspace and hcheck both use machine readable options, they require
similar functions - which are now generalized an...
Agata Murawska
11:50 am Revision 22e513e7: Initial commit for introducting hcheck tool
Introduce infrastructure required to add Hcheck and build it
successfuly.
Signed-off-by: Agata Murawska <agatamuraws...
Agata Murawska

06/22/2012

06:05 pm Revision 720ec33e: NEWS: Improve formatting, wording
Clarify some things, use ```` where appropriate.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: ...
Michael Hanselmann
02:15 pm Revision 9208230e: Prepare the update of the NEWS file
This updates the NEWS file for the upcoming rc1 release.
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-by:...
René Nussbaumer

06/20/2012

11:03 am Revision 0ccbf925: Extend burnin to do NIC changes
This would have caught our previous issue, since QA otherwise doesn't
do add, remove or changes of NICs.
Signed-off-...
Iustin Pop
11:03 am Revision 80b898f9: Fix bug in instance net changes
_PrepareNicModification returns the invalid type, which triggers an
assert resulting in a mysterious error:
Failure:...
Iustin Pop
10:51 am Revision 2fd213a6: Update the hooks documentation
Also provide some extended unittests to catch those cases.
Signed-off-by: René Nussbaumer <rn@google.com>
Reviewed-b...
René Nussbaumer

06/19/2012

06:03 pm Revision a8dbf746: QA: Fix modification of HV parameters via RAPI
This is basically another case of commit d488adb.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by:...
Michael Hanselmann
03:09 pm Revision 79829d23: Allow single-homed <-> multi-homed transitions
To change the cluster from single homed to multi homed or vice versa one
must target the master node first, and pass ...
Guido Trotter
02:02 pm Revision e0b57a5c: bdev: Fix DRBD error reporting for syncer rate
The function is supposed to return a list, not a string. Without this
patch the error message ends up as “C, a, n, ',...
Michael Hanselmann
11:39 am Revision 232fc505: Fix corner case in quick-check generated tests
Thanks to Agata Murawska, a random seed that generates bad test cases
was found ("seed was 1768143307 2118231514, tes...
Iustin Pop
11:35 am Revision 15618b63: Change default for DRBD barriers
Commit 8a69b3a8 changed the DRBD barriers disabled by default if
“--disable-drbd-barriers” is used to “bfd”, where “d...
Michael Hanselmann
« Previous
Next »
 

Also available in: Atom