From 06/26/2012 to 07/25/2012


09:56 pm Revision a085d96d: QA for allocator in recreate-disks
QA for recreate-disks called it twice with a list of node; the first call
now uses an allocator.
Signed-off-by: Adam...
Bernardo Dal Seno
09:52 pm Revision 38db4e7c: Front-end and doc to use allocator in recreate-disks
The recreate-disks command no longer requires an explicit list of nodes.
Signed-off-by: Adam Ingrassia <api@google.c...
Adam Ingrassia
09:38 pm Revision 3d091af0: Allocator support in recreate-disks LU
This affects only the backend.
Signed-off-by: Adam Ingrassia <>
Signed-off-by: Bernardo Dal Seno <bdal...
Bernardo Dal Seno
09:37 pm Revision 01eb03bd: Added method to call an allocator for recreate-disks
Ideally this should have used relocation mode, but to due lacking of
support in current allocators, allocation mode h...
Adam Ingrassia
02:24 pm Revision bb0d8ddc: Support for checking the group of only the primary node
_CheckInstanceNodeGroups behaves in the old way with the default value
of the new parameter.
Signed-off-by: Adam Ing...
Adam Ingrassia
12:42 pm Revision 7d5ceafd: Merge commit 'v2.5.2' into stable-2.6
* commit 'v2.5.2':
Fix RST formatting in NEWS file
Update NEWS and bump version for release 2.5.2
Fix boot=on f...
Iustin Pop


07:19 pm Revision 9906d514: Fix RST formatting in NEWS file
*FileID is interpreted as a start-of-bold, without corresponding end
marker. Sorry for not catching it in the first p...
Iustin Pop
06:57 pm Revision 390a2970: Update NEWS and bump version for release 2.5.2
This is a trivial release, with just bug fixes, so a small change log.
Signed-off-by: Iustin Pop <>...
Iustin Pop
06:10 pm Revision 24be50e0: Fix boot=on flag for CDROMs
This generalises commit 4304964a to cdroms too, since they have
somewhat the same logic. We just abstract the needs_b...
Iustin Pop
06:10 pm Revision 2b846304: KVM: only pass boot flag once
This addresses issue 230: passing two methods of booting to KVM can,
depending on the KVM version, confuse it.
Note ...
Iustin Pop


10:27 am Revision fc1282b8: Build epydoc.conf using standard replace_vars_sed
This is just begging to be converted to a standard replace_vars_sed
rule, instead of custom sed calls.
Iustin Pop
10:27 am Revision 55398706: Simplify some make rules
A rule of type "a/%: a/" will also match "a/b/%: a/b/", so no
need for the explicit examples/hooks rule. As f...
Iustin Pop
10:26 am Revision 490bec02: Explicitly terminate some make rules
Generic rules like:
have the downside that the source ( itself matches the target
Iustin Pop
10:26 am Revision 1d45f7a0: Remove ancient implicit make rules
GNU Make contains some (ancient) implicit rules, that try to
_automatically_ extract source files from RCS/SCCS versi...
Iustin Pop
10:25 am Revision 4c3d5fb6: Stop using BUILT_SOURCES
Commit dc7d2c49 introduced the use of BUILT_SOURCES to work around
missing dependencies. However, on closer reading o...
Iustin Pop
10:25 am Revision 924ecd85: Change how we create the 'ganeti' symlink
Currently, if one runs 'make' in an already fully-built tree, this is
the result:
cd . && test -h "ganeti" || { rm...
Iustin Pop
10:23 am Revision 3735787e: Partial undo of "Makefile: Streamline directory creation"
Commit c964d962 changed the way we create directories, by two things:
- unifying all dependencies and ad-hoc directo...
Iustin Pop
10:23 am Revision 5098afd1: A few style fixes in
Seen while debugging make rules.
Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <ultrotter...
Iustin Pop
10:20 am Revision f5ce7613: Ensure a stable content of the bash completion file
Currently, the order of commands in the bash completion file is
random, because the sub-commands are not sorted. This...
Iustin Pop


05:56 pm Revision b0b8458a: Correctly do sub-$(MAKE) invocations
Reading the automake documentation, it seems that explicit calls to
$(MAKE) need $(AM_MAKEFLAGS) passed, so let's do ...
Iustin Pop
03:14 pm Revision 7fe73c6f: Make error classes more consistent
This removes "pass" from a few definitions, making all errors
Signed-off-by: Iustin Pop <iustin@google.c...
Iustin Pop
12:29 pm Revision 7cb42171: Add support for -cpu option in KVM
This adds supports for the (non-validated) cpu parameter to KVM.
Signed-off-by: Iustin Pop <>
Nikita Staroverov


06:51 pm Revision 24ccfd74: Add note in admin guide about drbd stacked devices
Signed-off-by: Iustin Pop <>
Johan Euphrosine
03:51 pm Revision 7803e37c: Merge branch 'stable-2.6'
* stable-2.6: (21 commits)
Release Ganeti 2.6.0 rc4
Prepare NEWS for Ganeti 2.6.0rc4
Add some rudimentary node ...
Iustin Pop
03:36 pm Revision 1e00889c: Re-indent
By a strange accident, this file seems to be tabified, instead of our
own 2-space rule. Re-indent it and also break o...
Iustin Pop
03:26 pm Revision 95e7e676: Release Ganeti 2.6.0 rc4
Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>
René Nussbaumer
03:19 pm Revision d49f209f: Prepare NEWS for Ganeti 2.6.0rc4
Another release candidate is coming.
Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <iustin@...
René Nussbaumer
03:16 pm Revision 93ddfce2: Add some rudimentary node group ipolicy checks
Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>
René Nussbaumer
03:15 pm Revision 8b057218: Fix setting ipolicy on node groups
On node groups we don't have the std field. However, the InstancePolicy
object always verifies that the std value is ...
René Nussbaumer
02:56 pm Revision be3f52f3: Force tap's MAC prefix to "fe"
Setting a high prefix discourages the bridge from adopting the tap's
MAC. Xen is not affected by this since the MAC i...
Simon Deziel
12:22 pm Revision 2da31181: Fix --no-headers for the new list-drbd command
Sorry, I forgot that with GenerateTable this needs to be handled
manually. Fixed now and tested in both ways.
(But t...
Iustin Pop
11:11 am Revision 286b7335: Add a simple QA test for gnt-node list-drbd
This will be run only if 'haskell-confd' QA configuration has been
Signed-off-by: Iustin Pop <iustin@google...
Iustin Pop
11:11 am Revision 7acbda7b: Add a new gnt-node command list-drbd
This uses confd to query the DRBD minors, which is very special; no
other command currently does so.
Since the backe...
Iustin Pop
11:02 am Revision d81ec8b7: Implement a node to drbd minors query function
This can be queried remotely since it's a pure configuration query.
Signed-off-by: Iustin Pop <>
Iustin Pop
11:02 am Revision 792f8e55: Add a new unused confd query
This is not implemented currently.
Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <rn@go...
Iustin Pop
11:01 am Revision 7b2ead5a: Add support for computing instance all/secondary nodes
This fixes an old FIXME. Since we now how actual DRBD configuration
data, we can finally compute the instance's secon...
Iustin Pop
11:01 am Revision 2e12944a: Add disk logical ID support in Objects.hs
This is a complex field, so we have to do a lot of manual work for now.
The complexity arises from the fact that the...
Iustin Pop
11:01 am Revision 5c755a4d: Fix a docstring in bdev's DRBD8 class
It seems this was not updated since the move to static minors…
Signed-off-by: Iustin Pop <>
Iustin Pop
11:01 am Revision 1c7bda0a: Extend the Template Haskell loadFn model
Currently, we only allow field-by-field de-serialisation. Since we
have cases where information about how to un-seria...
Iustin Pop
11:01 am Revision c2e60027: Change how customFields are built
Instead of passing an expression (which cannot come from the current
module), we pass a name, which is allowed to ref...
Iustin Pop
11:01 am Revision 0fc8e521: Implement lookup of partial names in Config.hs
This uses the recently-moved functions to implement partial lookup of
names on getNode and getInstance, similar to th...
Iustin Pop
11:00 am Revision 2fc5653f: Reorganise the lookup functions
Currently, the LookupResult, MatchPriority and related functions are
locate in Loader.hs, since (so far) only hbal ne...
Iustin Pop
11:00 am Revision ab0edd8b: Remove an unused function
This is not used, as we need a more complex serialisation, which is
done in the saveObjectField function.
Iustin Pop


03:47 pm Revision 5dbee5ea: Ensure that disk.params is always defined (and a dict)
Commit cce46164 fixed upgrading from other 2.6 versions, but
accidentally broke upgrading from 2.5 (disk.params was l...
Iustin Pop
02:42 pm Revision 1b5b1c49: Another small consistency fix with if branches
While looking at the testability of this piece of code, I found another
consistency problem. We have two if branches ...
René Nussbaumer
02:01 pm Revision 734a2a7c: Fix inconsistency in the LUXI protocol w.r.t. args
This inconsistency was found during rebalancing. Hbal failed because,
Ganeti couldn't load the opcode. After digging ...
René Nussbaumer


03:56 pm Revision cce46164: Fix UpgradeConfig of Disk object regards disk params
This bug was found during disk parameter debugging. While looking at the
config some values seem present on the disk ...
René Nussbaumer


06:00 pm Revision 112aee5f: Merge branch 'stable-2.6'
* stable-2.6: (72 commits)
Make Ganeti 2.6.0 rc3 release
Allow reinstall even when secondaries are offline
Iustin Pop
02:55 pm Revision 88e14195: Make Ganeti 2.6.0 rc3 release
Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>
René Nussbaumer
02:41 pm Revision 96c3d5d4: Allow reinstall even when secondaries are offline
Signed-off-by: René Nussbaumer <>
Reviewed-by: Agata Murawska <>
René Nussbaumer
02:40 pm Revision 3dbb3348: Prepare NEWS file for Ganeti 2.6.0 rc3
Update NEWS regarding rc3 fixes and document changes in behaviour.
Signed-off-by: René Nussbaumer <>
René Nussbaumer


03:22 pm Revision c7e54e1d: QA updated to test instance removing when sec. is offline
Added test checking that it is possible to remove an instance with drbd
disk when non-primary node is offline.
Agata Murawska
03:21 pm Revision 03e5cdd5: Ignore offline node errors when removing disks
When we delete DRBD disks from some instance, we do not want to get
errors due to nodes other than that instance's pr...
Agata Murawska


11:16 am Revision d908ba61: Allow instance disc activation with offline secondaries
Currently, this is not allowed, so one can't run a replace-disks; this
breaks any non-invasive method of recovering t...
Iustin Pop


04:53 pm Revision 76ae2e5b: Replace a few explicit case expressions
Since we're just talking about converting Maybe into another monad, we
can do that via the maybe function, instead of...
Iustin Pop
04:16 pm Revision 2db53645: Also compute Haskell tags in "make tags"
Note however that this won't work correctly with older compilers, due
to ghc issue #4256; however, it's a handy way t...
Iustin Pop
04:16 pm Revision 96eccc1f: Fix Haskell coverage results
There are two current issues with the coverage values:
- we don't import all modules, thus leading to incomplete
Iustin Pop
04:16 pm Revision fce98abd: Cleanup the QC.hs file w.r.t. compiler options
Currently, we build the Haskell unittests with custom GHC flags,
because we (I) were quite lazy when initially writin...
Iustin Pop
03:29 pm Revision 28a45bfc: RAPI regression beparams/memory fix
For compatibility with the old Ganeti version, we want to keep the
beparams/memory field around for another release. ...
René Nussbaumer
01:37 pm Revision fc6075dd: Installation instructions update
This patch aims at improving documentation for installing ganeti - both for users and developers.
Signed-off-by: Aga...
Agata Murawska
12:11 pm Revision b647b6d7: Fix Query2.hs to compile without warnings
Since this is not yet used by any targets, we didn't detect yet the
compilation warnings. Just trivial exports/import...
Iustin Pop


07:11 pm Revision 32da72f3: Ensure that --wait-for-sync is used in QA
We don't have a specific test for activate disks, so let's add it in
the cases where we run (incidentally) activate-d...
Iustin Pop
07:11 pm Revision f30d8165: Add --wait-for-sync in gnt-instance
Note that this needs (like for the opcode) a new option, with the
default reverted (False instead of True).
Iustin Pop
07:11 pm Revision b69437c5: 9Add wait_for_sync flag to OpInstanceActivateDisks
This can be used to ensure that after activate-disks has returned, the
instance's storage is consistent; currently th...
Iustin Pop
04:09 pm Revision 2a2e2610: hbal: return exit status 0 in case of early exit
This derives from an internal bug, but the story is consistent across
both internal and external usage of hbal.
Iustin Pop
03:20 pm Revision cad0723b: Fix DRBD resize code
There are two bugs in the current resize code, affecting mostly DRBD.
First, due to bugs in old DRBD versions (pre 8...
Iustin Pop
11:41 am Revision cc706abc: Fix redistribution of files w.r.t. offline nodes
Currently, _RedistributeAncillaryFiles computes two lists: the list of
online nodes (for all files redistribution), a...
Iustin Pop
11:35 am Revision 770461fe: Fix cluster verify error on master-ip-setup script
This error does not show up until we exceed the pool of master
candidates and have nodes which are not master candida...
René Nussbaumer


05:05 pm Revision 3228c07a: Add test helpers to .gitignore
Commit 3096524e enabled building of test helpers, but forgot to add
them to .gitignore, resulting in "unclean" git st...
Iustin Pop
05:05 pm Revision 6438e259: Add a Makefile rule to test unclean git status
This is trivial, but can be used easily from automated builds to check
that the git tree is clean: files are not modi...
Iustin Pop


04:05 pm Revision 4cc60473: Fix a typo in NEWS
Signed-off-by: René Nussbaumer <>
Reviewed-by: Bernardo Dal Seno <>
René Nussbaumer
12:36 pm Revision 3ee4fd54: Release Ganeti 2.6.0rc2
Signed-off-by: René Nussbaumer <>
Reviewed-by: Agata Murawska <>
René Nussbaumer
11:19 am Revision 02902172: Prepare NEWS file for 2.6.0 rc2
We are about to release another version of Ganeti 2.6, so we prepare the
NEWS file with the changes from rc1 to rc2.
René Nussbaumer


08:34 pm Revision 1279c691: Fix tiny typo in htools.rst
Backtracking through git blame, it turns out than commit 49148d15
changed "\fB20,102400,16384,4\fR" into "**B20,10240...
Iustin Pop
08:34 pm Revision f18e4168: Fix building of hcheck man page
The code used a space, not a tab, in, which means it
actually broke the variable declaring the man pages....
Iustin Pop
08:34 pm Revision b1a9d630: Remove can_rebalance functionality from hcheck
Since hbal can now run rebalances even in the presence of split
instances, we can remove this check and always run th...
Iustin Pop
08:34 pm Revision 0c76f280: Add hlint warning for wrong use of 'length'
While removing split instances check from hcheck, I saw a wrong use of
'length': this should only be used when one ne...
Iustin Pop
08:34 pm Revision 85890a9d: hcheck: reword and fix typo in instance/offline msg
Signed-off-by: Iustin Pop <>
Reviewed-by: Agata Murawska <>
Iustin Pop
08:34 pm Revision 70b6c284: Update time on Haskell binaries after build
This patch works around an issue in our build system. Since we don't
use cabal or 'ghc -M', we don't track actual dep...
Iustin Pop
08:34 pm Revision 7f119c27: hcheck: add two simple type aliases for readability
The same types are reused a couple of times, so let's add a couple of
type aliases for easier change later and readab...
Iustin Pop
08:34 pm Revision 4b77c2a2: hcheck: rework output mode
Looking at the output of hcheck, in human readable mode, it looks like
it always starts with a blank line. This is no...
Iustin Pop
05:29 pm Revision 3891c95e: Fixed spaces/indentation according to guide lines
Problem introduced by commit 87f0aa4896ac4dfacc9d20bc55b0855282b4d1d4.
Signed-off-by: Bernardo Dal Seno <bdalseno@go...
Bernardo Dal Seno
04:35 pm Revision f55f0037: Fix small bug with a space in the hv_xen module's line
Remove a useless space at the end of the line in a config file.
Signed-off-by: Jack Sitnikov <>
11:38 am Revision f0d22861: Allow param `modify' during gnt-instance modify
With the new gnt-instance modify syntax for addition and removal of
disks/NICs on arbitrary indexes, we hit an assert...
Constantinos Venetsanopoulos


11:38 pm Revision 87f0aa48: Add PCI passthrough for hvm xen
This hv parameter allows passing PCI devices to virtual machines.
Signed-off-by: Guido Trotter <
06:52 pm Revision cf279f03: Correct a wrong --help option for --simulate
This was not update when the alloc policy was added to the parameter.
Signed-off-by: Iustin Pop <>
Iustin Pop
06:52 pm Revision a95aa74c: Add a shell test for hbal and split instances
This is not perfect, as we only test that hbal completes successfully
and that it show a score improvement, but it's ...
Iustin Pop
06:51 pm Revision a7e1fd89: hbal: relax restrictions on split instances
The recent patch series on hcheck made me realise how much pain we
have due to hbal not being able to work (at all) w...
Iustin Pop
12:39 pm Revision 5b93f2ec: Add newline at the end of shelltest files
Signed-off-by: Agata Murawska <>
Reviewed-by: René Nussbaumer <>
Agata Murawska
11:55 am Revision 19fe9138: Add forgotten unittest changes for instance_os_add
The previous patch which fixed disk parameters didn't adapt the
unittests so it lead to failing QA.
Signed-off-by: R...
René Nussbaumer
11:04 am Revision b8291e00: Annotate disk params on instance_os_add
We call _OpenRealBD during the process and this needs disk parameters to
work. This was reported by Constantinos.
René Nussbaumer
03:24 am Revision 81bcbbd3: Fix a few style issue in hcheck
This fixes a couple of issue I've seen while fixing the List import:
- removes over-use of printf with putStr/show
Iustin Pop
03:24 am Revision 7568b296: Fix old-style import
Commit 1213f9d6 (re)added an old-style import, which fails with recent
Signed-off-by: Iustin Pop <iustin@...
Iustin Pop


05:19 pm Revision d64acbb5: Style fix in hcheck
Signed-off-by: Agata Murawska <>
Reviewed-by: René Nussbaumer <>
Agata Murawska
05:19 pm Revision 47ed1d79: Style fixes in shelltests
Signed-off-by: Agata Murawska <>
Reviewed-by: René Nussbaumer <>
Agata Murawska
05:19 pm Revision 3c0687b5: Simplify stats printing
PrintGroupStats and printClusterStats had very similar code
structure. This patch abstracts those two into printStats...
Agata Murawska
05:19 pm Revision 5cc97485: Cleaner simulation of rebalance
This replaces the 'if .. then .. else ..' with a large block of code in
'else' branch by separating this code into a ...
Agata Murawska
05:17 pm Revision b5b19d5e: Small reordering and renaming in hcheck
Reordered functions and shortened one function name.
Signed-off-by: Agata Murawska <>
Agata Murawska
05:17 pm Revision caa97388: Move 'need rebalance' check from cluster check
As suggested by Rene, we should keep the check separate from printing.
Signed-off-by: Agata Murawska <agatamurawska@...
Agata Murawska
05:17 pm Revision ecc39665: Always print all variables in machine readable version
As discussed in cover letter of patch series introducing hcheck, in
machine readable version we should always print v...
Agata Murawska
05:17 pm Revision 592601b3: Print idx <-> uuid mappings in machine readable mode
As per Iustin Pop's suggestion, we are printing group mappings
from group idx (known only to htools) to group uuid, w...
Agata Murawska
05:17 pm Revision 5cdbde9a: Human readable group name improved
Instead of printing group id in human readable version of hcheck,
we now print group name.
Signed-off-by: Agata Mura...
Agata Murawska
05:17 pm Revision 92eacdd8: Print info about ability to rebalance
As suggested during offline discussion, this patch adds a new bash
variable and description field in hcheck, which in...
Agata Murawska
05:17 pm Revision e60fa4af: Improve readability for hcheck-related changes
As suggested by Rene, I added comments to types for printKeys
and printFinal. Also, realigned some lines in Hspace.
Agata Murawska
12:10 pm Revision a1cd2ecf: Fixed doclint warning
Two blank lines are needed between functions.
Signed-off-by: Bernardo Dal Seno <>
Reviewed-by: Re...
Bernardo Dal Seno
11:03 am Revision 55de1d68: Annotate disks upon blockdev_shutdown
Signed-off-by: René Nussbaumer <>
Reviewed-by: Agata Murawska <>
René Nussbaumer
11:03 am Revision 4504bfcb: Annotate disks on blockdev_remove
This annotates the disks for the blockdev_remove where it is
appropriate. It leaves out 2 cases were we can't reliabl...
René Nussbaumer
11:02 am Revision b5cbddd9: Annotate disk params on blockdev_getmirrorstatus_multi
This is also related to the bug reported by Constantinos,
as we've only one getmirrorstatus_multi call in whole cmdli...
René Nussbaumer
11:02 am Revision 70817cee: Annotate disk parameters on blockdev_getmirrorstatus
Not annotating them works for DRBD but not for RBD as reported by
Signed-off-by: René Nussbaumer <rn@g...
René Nussbaumer


07:17 pm Revision 83180411: QA: Added test for gnt-instance recreate-disks
The test is disabled by default, as it takes a long time.
Signed-off-by: Bernardo Dal Seno <>
Bernardo Dal Seno
07:16 pm Revision 82d2f3df: QA function do destroy disks
This is useful to simulate HW problems during QA.
Signed-off-by: Bernardo Dal Seno <>
Bernardo Dal Seno
« Previous
Next »

Also available in: Atom