Activity

From 11/21/2012 to 12/20/2012

12/20/2012

06:34 pm Revision 37dfcacb: Replace custom strip newlines in UUID generation
Since now rStripSpace lives in Utils.hs, we can use it directly (as
UUIDs shouldn't contain spaces anyway).
Signed-o...
Iustin Pop
06:17 pm Revision 04063ba7: Add Confd client to the Haskell code base
The client queries all the master candidates in parallel, until the minimum
number of replies, defined in the constan...
Michele Tartara
06:17 pm Revision d8e9131b: Add function to fetch the list of master candidates
This commits adds to the Haskell codebase a function to fetch the list of
IPs of the master candidates from the SSCon...
Michele Tartara
06:17 pm Revision 1a0defea: Add the parseReply function to the Confd utils
This function will be used by the Haskell Confd client to parse the replies
it receives from the server.
Unit test i...
Michele Tartara
06:16 pm Revision 497f5cbf: Rename the Confd utils parseMessage function to parseRequest
With the upcoming implementation of the Haskell Confd client, requests will
no longer be the only kind of message to ...
Michele Tartara
06:16 pm Revision 5bfcd75f: Make the parseRequest function more general
The parseRequest function of the Confd utils can be used to parse both request
(in the server) and reply (in the clie...
Michele Tartara
06:16 pm Revision 80a0546b: Add function for generating UUIDs in the Haskell codebase
Its first use will be to generate the salt for ConfD requests of the Haskell
client, as in the Python client.
Unit t...
Michele Tartara
06:15 pm Revision 46300ac2: Move Confd getCurrentTime to Utils
The Confd server implementation has a getCurrentTime function.
This commit moves it to the Utils.hs file of Confd, so...
Michele Tartara
05:53 pm Revision 9f6f74b4: Fixup too-long-line in Objects.hs
Sorry, didn't see this before pushing the previous commit (277a2ec9).
Signed-off-by: Iustin Pop <iustin@google.com>
...
Iustin Pop
05:29 pm Revision 277a2ec9: ExtStorage support in htools
This just adds new constructors for the disk template and related
types, enabling the Ext storage.
Signed-off-by: Co...
Constantinos Venetsanopoulos
05:12 pm Revision ea626b33: confd: strip newlines before logging the request
The Python confd client sends newlines in messages (due to use of
DumpSignedJson/DumpJson), so that results in ugly d...
Iustin Pop
05:12 pm Revision 256e28c4: Move rstripSpace from Ssconf to Utils
Also renames it in the process and adds a few tests for it.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-b...
Iustin Pop
05:08 pm Revision 53258324: objects.NIC: Look up mode only once, capitalize acronym
Look up “NIC_MODE” only once, capitalize “NIC” in error messages.
Signed-off-by: Michael Hanselmann <hansmi@google.c...
Michael Hanselmann
05:08 pm Revision 42653ebd: gnt-cluster(8): Quoting, small fixes
Quote fixed strings where appropriate and replace “nic” (an acronym)
with “network interface”.
Signed-off-by: Michae...
Michael Hanselmann
05:08 pm Revision eac9b7b8: Add utility to format dictionary as key=value strings
This will be used in QA to format network interface parameters.
Signed-off-by: Michael Hanselmann <hansmi@google.com...
Michael Hanselmann
05:06 pm Revision 938adc87: Multiple ExtStorage Providers and ext-params
Add support for passing parameters to the ext template (ext-params).
Take advantage of disk-params, that don't seem t...
Constantinos Venetsanopoulos
05:06 pm Revision aa6c1bb1: Adjust LUInstanceSetParams wrt the `ext' template
Initial support for the `ext' template in gnt-instance modify.
Take care of all needed checks in CheckArguments and C...
Constantinos Venetsanopoulos
05:06 pm Revision 376631d1: Implement the External Storage Interface
With this commit we introduce the External Storage Interface
to Ganeti, abbreviated: ExtStorage Interface.
The ExtSt...
Constantinos Venetsanopoulos
03:37 pm Revision 32ba31be: Stop all daemons on cluster initialization
Addresses issue 145. When daemons are still running from a previous
cluster instance, starting the daemons again will...
Michael Hanselmann
03:37 pm Revision da1dcce1: Make node groups' networks field a dict of nicparams
The networks field of the node groups class is a dictionary
of nic params and not a list of networks. This should fix...
Helga Velroyen
03:36 pm Revision e7e2552e: Update the shared storage design document
Update the shared storage design document to reflect the current
changes, after the implementation of the ExtStorage ...
Constantinos Venetsanopoulos
02:16 pm Revision efe2137a: Final update of NEWS file for 2.6.2 and version bump
I'm already setting this to a release date of tomorrow, since QA on
the 2.6 branch has been clean.
Signed-off-by: Iu...
Iustin Pop
12:37 pm Revision 5f30ea3f: netutils: Normalize all FQDNs
Addresses issue 147. Only the hostnames resolved using
“netutils.Hostname($name)” were normalized, but those returned...
Michael Hanselmann
12:01 pm Revision 814e1e23: Display command description in htools usage message
By abstracting the command/personality formatting, we can easily
switch htools to the same output as the rest of the ...
Iustin Pop
11:57 am Revision 044fff06: More style updates for network-related code
Error message formatting, else/if merging to elif, docstrings.
Signed-off-by: Michael Hanselmann <hansmi@google.com>...
Michael Hanselmann
11:57 am Revision aa279109: NEWS: Opportunistic locking, clarifications
Some rewording, some clarifications, and a new item on opportunistic
locking.
Signed-off-by: Michael Hanselmann <han...
Michael Hanselmann
11:57 am Revision cfa79a23: cmdlib: Additional opportunistic locking check
If opportunistic locking is requested in the opcode, but no iallocator
is used (not specified or no default), an erro...
Michael Hanselmann

12/19/2012

07:44 pm Revision 4a6fce31: Detect wrong Python module structure
If, for one reason or another, a module named "ganeti.ganeti" can be
succesfully imported (e.g. through a symlink in ...
Michael Hanselmann
07:28 pm Revision 3504d6c8: Add hroller htools personality
This is a new personality that for the moment doesn't do anything.
Signed-off-by: Guido Trotter <ultrotter@google.co...
Guido Trotter
07:28 pm Revision 1a9eb17e: Use hroller to print nodes to reboot by groups
This is highly incomplete, as per the manpage BUGS section.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Revi...
Guido Trotter
07:26 pm Revision 1ba25bad: Fix QA for --offline semantics modification
The previous patch series made it simpler to deal with ERROR_up offline
instances, but didn't fix qa, that had the ol...
Guido Trotter
07:26 pm Revision ff0c9604: One more offline+shutdown fix
Currently gnt-instance shutdown --force of an offline instance
resets the offline status. Which of course is bad and ...
Guido Trotter
07:15 pm Revision 13659147: Fix network LUs use of error code in OpPrereqError
Currently, most network LUs simply use EINVAL instead of correct error
codes; this patch tries to adjust the obvious ...
Iustin Pop
06:55 pm Revision 572a277b: _NetworkQuery: Simplify statistics computation
The code can loop directly over “self.wanted”, saving a lookup. An
explicit loop is also replaced with a generator.
...
Michael Hanselmann
06:55 pm Revision 892b5258: cmdlib: Factorize network conflict detection
LUNetworkConnect and LUNetworkDisconnect had very similar code to detect
conflicts between instance's network interfa...
Michael Hanselmann
06:55 pm Revision 84e110aa: gnt-network: Fix import for textwrap
The style guide says to use “import foo”-style imports, not “from foo
import bar” unless it's a Ganeti module. There ...
Michael Hanselmann
06:55 pm Revision b34864e8: gnt-network add: "--network" is required
Also do some minor code re-formatting.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop...
Michael Hanselmann
06:54 pm Revision 0f5c7770: cmdlib: Replace period with colon in error message
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
06:54 pm Revision b4600d4f: query: Factorize code for getting statistics value
This was not only copied for the networking fields in commit 306bed0e,
but commit cfcea7ef fixed wrongly ordered para...
Michael Hanselmann
06:54 pm Revision d6f3a69d: gnt-network(8): s/ipv6/IPv6/
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
06:54 pm Revision e896ad3d: gnt-network add: Network mode bash completion
This makes entering the command easier.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Po...
Michael Hanselmann
06:54 pm Revision 6ef37395: OpNetworkConnect: Check for network mode
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
06:54 pm Revision e1195cd4: Use generated field list in gnt-network.8
The list of query fields can be automatically generated.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Revie...
Michael Hanselmann
06:54 pm Revision 0b3f2215: Improve descriptions of network query fields
They should be in the same style as other descriptions.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Review...
Michael Hanselmann
06:29 pm Revision b8028dcf: Replace frozenset with compat.UniqueFrozenset
This is not a trivial s/frozenset/compat.UniqueFrozenset/, but rather
only replaces “frozenset” where appropriate. Mo...
Michael Hanselmann
05:41 pm Revision a30a6178: Renaming fam -> net_family on test network generation
Small renaming to make the test more readable.
Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Michel...
Helga Velroyen
04:55 pm Revision 5b48df93: Serialization compatibility test for node groups
This creates a number of node groups with up to 3 networks,
serializes them and compares them with their python equva...
Helga Velroyen
04:55 pm Revision 0f0d7aba: Add a network fields to NIC params and node group type
This adds a network field to the NIC params and a list of networks
to the node group type. It adjusts the nodegroup's...
Helga Velroyen
04:54 pm Revision 6f732ae0: Move Network definition ahead of depending definitions
Networks will be properties of NicParams and NodeGroups. Therefore
they need to be defined before those.
Signed-off-...
Helga Velroyen
03:52 pm Revision e0f470ac: Fix job completion with big job queues
Accidentally stumbled upon this while testing unrelated code on a
machine with ~3K active jobs - the bash completion ...
Iustin Pop
03:45 pm Revision d45a824b: Enable job queries via confd in gnt-node and RAPI
This patch is enabling split queries for jobs for gnt-node and rapi
access (only for job listing, not job waiting).
...
Iustin Pop
03:45 pm Revision 45317e3a: Remove some unused Python code
This patch removes code which is no longer used due to refactoring:
- http.InitSsl, last usage removed in commit 332...
Iustin Pop
03:45 pm Revision 1ba01ff7: Move a node-specific function to Query.Node
This shouldn't live in the main Query module, since it's too node
specific.
Signed-off-by: Iustin Pop <iustin@google...
Iustin Pop
03:37 pm Revision a7e484c4: Add support for job queries in hconfd
This adds support for job queries, including (basic) unit-tests.
I've tested this for memory and cpu usage as follow...
Iustin Pop
03:37 pm Revision 037762a9: Change makeSimpleFilter accept NumericValues as well
This is required for QueryJobs implementation; we change
makeSimpleFilter to support both string and integers as name...
Iustin Pop
03:37 pm Revision aa79e62e: Add a read-only job queue module
This patch adds implementation for a read-only job queue module,
together with "full" test (as full as can be in a la...
Iustin Pop
03:37 pm Revision f94a9680: Implement support for QFF_SPLIT_TIMESTAMP
I am very very unhappy with this patch. We have to do this, in order
to be compatible with the Python code and behavi...
Iustin Pop
03:14 pm Revision 0ea11dcb: Add exclusive_storage node parameter
Unit tests updated and expanded with an inheritance check.
The flag has no effect yet.
Signed-off-by: Bernardo Dal ...
Bernardo Dal Seno
03:14 pm Revision d3b06210: Update design doc for partitioned Ganeti
PVs don't need to be marked as unallocatable, as the code will ignore
partially used PVs. exclusive_storage made a no...
Bernardo Dal Seno
03:11 pm Revision 712da82f: Remove superfluous typing to Int
Forgot to fix that after the review of patch
"Haskell/python compatibility test for networks".
Signed-off-by: Helga ...
Helga Velroyen
01:11 pm Revision 90634d95: Extend job ID parsing tests
Since this is a type that behaves non-standard, let's add some more
test for "wrong" input values.
Signed-off-by: Iu...
Iustin Pop
01:11 pm Revision f56013fd: Add a few tests for OpParams types
As OpParams definitions are used at Template Haskell type, they don't
get any coverage (although the values defined b...
Iustin Pop
01:10 pm Revision 988dc5ca: Enable bash completion for mon-collector
This just ties in all the pieces so far and enables bash completion
for it.
Signed-off-by: Iustin Pop <iustin@google...
Iustin Pop
01:10 pm Revision 638e0a6f: Improve mon-collector drbd CLI handling
Currently, this doesn't abort if multiple arguments are passed, and
the error message for errors during file read has...
Iustin Pop
01:10 pm Revision 86aa9ba3: Remove two hlint overrides
"Use comparing" was not needed, and "Use on" can be solved by actually
using on in the single case we have (the patch...
Iustin Pop
01:10 pm Revision 570274e4: Add more mon-collector shell tests
These test the newly-changed behaviour, and fix an inconsistency in
the hs-check target (versus hs-coverage).
Signed...
Iustin Pop
01:10 pm Revision 55abd2c7: Add a custom CLI module for DataCollectors
Currently, the mon-collector binary uses the HTools/CLI module, which
is OK but mean it links in lots of htools code....
Iustin Pop
01:10 pm Revision 2e6ef129: Add a type alias for the personality lists
The signature of the personality definitions is so ugly that, at
least, we should hide it a bit behind a type alias.
...
Iustin Pop
01:10 pm Revision 630c73e5: Introduce generic multi-command binary handling
Currently, the mon-collector binary is the only multi-command binary
we have in Haskell. Not surprisingly therefore, ...
Iustin Pop
01:10 pm Revision 559c4a98: Add description to personality definitions
This allows usage information to display nicer help (like in Python).
Signed-off-by: Iustin Pop <iustin@google.com>
...
Iustin Pop
01:10 pm Revision e892cdfa: Simplify htools.hs personality selection
No need to do a boolean-based lookup, we can use the regular
association list lookup.
Signed-off-by: Iustin Pop <ius...
Iustin Pop
01:10 pm Revision 24476fa0: bash-completion: add support for multi-cmd Haskell binaries
This patch adds support for parsing the command list out of a binary
(very strict format), and then iterating over th...
Iustin Pop
01:10 pm Revision daf0de68: Implement fake completion support for multi-cmd binaries
This will allow build-bash-completion to understand what is the list
of commands that each binary supports, and then ...
Iustin Pop
01:10 pm Revision 675f65b7: Fix profiling targets
As noted by Guido, there are problems when using the hs-prof and
hs-prof-quick targets in the default configuration (...
Iustin Pop
01:02 pm Revision 0d57ce24: Allow shutting down offline instance
If an instance is offline we definitely shouldn't start it up.
But shutting it down, should it be up by mistake is no...
Guido Trotter
01:01 pm Revision eec7840a: Allow running instances to be put online
If an instance is running (eg. ERROR_up) and at the same time offline,
there's no way to either shut it down or reonl...
Guido Trotter

12/18/2012

04:09 pm Revision 05325a35: Fixes and improvements to comments
Some fixes, added more information in a few points, removed a stale (5+
year old) TODO comment.
Signed-off-by: Berna...
Bernardo Dal Seno
03:22 pm Revision c96887cf: Explain how to use GHCI to see spliced TH code
This can be more useful than the "make" version.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michael ...
Iustin Pop
03:06 pm Revision daa49d6f: Fix error during cluster initialization due to hv_kvm
Commit 141d148 was a bit too enthusiastic. The three parameters added to
the list of parameters to be checked default...
Michael Hanselmann
02:07 pm Revision 114e8500: Make LUNetworkAdd pass _VerifyLocks()
LEVEL_NODE_ALLOC should be aquired too if LEVEL_NODE is ALL_SET.
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr...
Dimitris Aragiorgis
11:24 am Revision 0b288282: Haskell/python compatibility test for networks
This patch contains the HUnit test that checks the compatibility
of Haskell-generated networks with the python code. ...
Helga Velroyen

12/17/2012

06:24 pm Revision 141d1489: Add test for SPICE parameter list, add missing ones
“_SPICE_ADDITIONAL_PARAMS” is supposed to be the full list of
SPICE-related KVM hypervisor parameters with the except...
Michael Hanselmann
06:24 pm Revision 07788a0b: hv_kvm: List of SPICE parameters should be module-global
This list is static at runtime and doesn't need to be recreated every
time.
Signed-off-by: Michael Hanselmann <hansm...
Michael Hanselmann
06:16 pm Revision af797be5: _DeclareLocksForMigration: Fix non-DRBD locking issue
When non-DRBD disks are used for an instance,
“lu.needed_locks[locking.LEVEL_NODE]” is set to “locking.ALL_SET” (whic...
Michael Hanselmann
05:44 pm Revision d4e4b2fd: LUOobCommand: Always declare NAL in shared mode
Doing so avoids triggering an assertion in mcpu which cross-checks the
node lock and node allocation lock acquisition...
Michael Hanselmann
01:38 pm Revision 1d645825: Fix two logging messages in TLReplaceDisks
Commit f0f8d060 (“Show old primary/secondary node on disk
replacement”) added two wrong uses of feedback_fn, which re...
Iustin Pop
01:38 pm Revision fef919b7: Split and extend Confd types tests
Some confd types were not tested for serialisation, so let's move
these (type-related) tests to their own module and ...
Iustin Pop
01:38 pm Revision 62d5242b: Switch Luxi sendMsg from strict to lazy ByteStrings
Commit e821050d (“Switch the Luxi interface from Strings to
ByteStrings”) was designed to optimise the receive interf...
Iustin Pop
01:38 pm Revision 13b17073: Add NFData instances for query results
This allows us to ensure that query results are strict as we build
them, instead of being lazy and only evaluated whe...
Iustin Pop
01:38 pm Revision daa79414: Introduce NFData instances for JSON types
The JSValue/JSObject types don't come with a NFData instance, so let's
add one ourselves, so that we can force evalua...
Iustin Pop
01:38 pm Revision 77d43564: Fix parsing of absolute job dependencies
It seems that Python code generates (sometimes) absolute job
dependencies which are strings, instead of integers, so ...
Iustin Pop
01:38 pm Revision 1496f5f3: Make two common opcode parameters always serialised
This changes deps and comment fields to always be shown, to match the
Python behaviour for (at least) job listing/ops...
Iustin Pop
01:38 pm Revision 88127c47: Fix disk_template OpInstSetParams parameter
This is not a required field, but rather an optional one; we add a new
parameter and use it instead.
Signed-off-by: ...
Iustin Pop
01:38 pm Revision d2970809: Support 'null' in Luxi QueryJobs names field
Python code sometimes sends this, so let's support it even though it's
non-standard.
Signed-off-by: Iustin Pop <iust...
Iustin Pop
01:38 pm Revision fd958a3d: Abstract code related to job ID creation
Having makeJobIdS as a separate function will allow us to use it
outside of json encoding.
The patch also exports on...
Iustin Pop
01:37 pm Revision 4355b2de: Add new Haskell library dependency for tests
The 'temporary' library add support for create temporary
directories/files beyond what is offered in the base library...
Iustin Pop
01:37 pm Revision a664325e: Reduce logging level in tests
This allows tests to execute IO actions which have logging as a side
effect, without polluting the stderr too much.
...
Iustin Pop
01:37 pm Revision 55438c07: Export jstore constants as well to Constants.hs
This single constant could be as well moved to constants.py. For now I
choose to just export the module as well.
Sig...
Iustin Pop
01:37 pm Revision df8578fb: Generalise the test helper 'genUniquesList'
Instead of always using "arbitrary", make it require a generator (that
can then use more complex rules for building t...
Iustin Pop
01:37 pm Revision 1db32048: Export more paths from Path.hs
Also adds a small helper for building the paths.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michele ...
Iustin Pop
01:29 pm Revision a1d137f6: Simplify a bit the FilterRegex JSON instance
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Helga Velroyen <helgav@google.com>
Iustin Pop
01:29 pm Revision ad1c1e41: Implement opcode summary support
This implements in the Haskell codebase the opcode summary. As opposed
to Python, we always use custom code for forma...
Iustin Pop
01:29 pm Revision 8bc17ebb: Add optional formatting for OP_DSC_FIELD
For some opcodes, the output is not "stable", and depends on the exact
input values; this makes it harder to check co...
Iustin Pop
01:29 pm Revision 5cd95d46: Add a type for the log type in job/opcode logs
Also fixes indentation for OP_STATUS.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultr...
Iustin Pop
01:29 pm Revision 60f20a41: Fix small typo in OpTestDelay/duration definition
The extra space results in inaccessible names; currently GHC doesn't
flag this as an error, but I've filled an upstre...
Iustin Pop

12/14/2012

04:55 pm Revision 9d3867b1: Add constants for two values which we re-evaluate
Two constants which we use as Integer are defined as Int in
Constants.hs (coming from constants.py), so we do the con...
Iustin Pop
04:55 pm Revision 5448799c: Fix an small but quite nasty typo
Introduced in commit d4752785.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Guido Trotter <ultrotter@g...
Iustin Pop
04:52 pm Revision abee3636: confd: reduce noise during normal config reload
During a normal configuration update, done via write to temp file and
rename, this is what confd logs (slightly edite...
Iustin Pop
04:44 pm Revision d0054203: update gnt-instance manpage about self-rename
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Guido Trotter
04:43 pm Revision a3d1dc0a: Change hbal handling of !auto_balance instances
Note: I'll add tests for this on the master branch, but not here.
Signed-off-by: Iustin Pop <iustin@google.com>
Revi...
Iustin Pop
04:43 pm Revision 9fdc92fa: burnin: rename instances to same name
this (a) allows us to test renaming in burnin even if we don't have an
extra instance name and (b) is a valid operati...
Guido Trotter
04:28 pm Revision 57fb6fcb: Very very very basic openvswitch support
This is a "better than nothing" support, just for kvm and just joining
the machine to the opevswitch bridge with the ...
Guido Trotter
03:11 pm Revision d6b5da24: Add profiling dependencies note
As discussed on the list, these are needed to do a make hs-prof.
Signed-off-by: Guido Trotter <ultrotter@google.com>...
Guido Trotter
03:11 pm Revision cce30754: Improve a few Graph test properties
Return type is changed from Property to Bool, and the ==? True at the
end is dropped.
Signed-off-by: Guido Trotter <...
Guido Trotter
03:11 pm Revision f127e585: remove duplicate code in Graph.hs
Also update the docstring of a function.
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin Pop...
Guido Trotter
12:14 pm Revision 75c7a686: Small corrections in man pages
The only semantic change is the fix of the spelling of the option
--ipolicy-disk-templates.
Signed-off-by: Bernardo ...
Bernardo Dal Seno

12/13/2012

07:47 pm Revision f74b88fa: Log only partial response in Luxi when in debug mode
Currently, we log the entire response (at debug level) in the Luxi
replies. This is not a good idea; the logging libr...
Iustin Pop
07:46 pm Revision 6c282c89: Fix gnt-instance(8) w.r.t. growable disk templates
This fixes Issue 257.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Helga Velroyen <helgav@google.com>
Iustin Pop
07:16 pm Revision e21c2eec: Pass check_ip and not hostname.ip to _ComputeNics
This should be done because in the case of --no-name-check there
is no 'hostname.ip' attribute, causing an execution ...
Constantinos Venetsanopoulos
05:36 pm Revision 80b207df: Stop verifying opcode results in dry_run mode
Commit 1ce03fb1 (“Add ht-based result checks to opcodes”) introduced
infrastructure for checking opcode results, and ...
Iustin Pop
05:35 pm Revision 924d9134: Add version check for doc/design-draft.rst
This is similar to README or “doc/security.rst”. Having a comment that
needs updating for a new version is more likel...
Michael Hanselmann
05:35 pm Revision a5b0694f: Makefile/check-local: List all errors before failing
Use the “error” variable in multiple places and fail only once all tests
have been completed.
Signed-off-by: Michael...
Michael Hanselmann
04:55 pm Revision 98a83f17: Move four designs from draft to 2.7
These are the ones I implemented and for which I'm certain they're
complete.
Signed-off-by: Michael Hanselmann <hans...
Michael Hanselmann
04:52 pm Revision f1d243bd: RAPI documentation fix and update
- Mention user capabilities in security.rst
- Replace “query” with “read” in RAPI documentation
Signed-off-by: Micha...
Michael Hanselmann
02:30 pm Revision 542e3dea: Add hpc-mon-collector to .gitignore
It is a binary file and it should never be added to the git repository.
Signed-off-by: Michele Tartara <mtartara@goo...
Michele Tartara
01:29 pm Revision ec5af888: Read watcher pause using RPC, not directly
The master daemon should not directly read files written by the node
daemon. This patch adds a new RPC to read the wa...
Michael Hanselmann
01:29 pm Revision 7c4bd156: Set watcher pause on all nodes
Instead of just setting the watcher pause file, which isn't replicated,
RPC is used to set it on all nodes (where pos...
Michael Hanselmann
01:29 pm Revision 99e222b1: Add RPC for setting watcher pause
The watcher pause file should be set/unset on all nodes at once, not
only the master node. For that a new RPC is need...
Michael Hanselmann
01:28 pm Revision f2bca93e: Generated RPC code: Don't write whitespace after paren
There is no obvious need for this space--the line would wrap at the next
space, which comes soon after.
Signed-off-b...
Michael Hanselmann
01:28 pm Revision 6ec28bc6: Rename test for backend._CommonRestrictedCmdCheck
“TestWriteFile” was not renamed when adding the file based on
“ganeti.utils.io_unittest-runasroot.py”.
Signed-off-by...
Michael Hanselmann
01:27 pm Revision 383477e9: jqueue: Improve inotify error reporting
This addresses issue 218. When the number of inotify watches is
exhausted, for example by being set too low from the ...
Michael Hanselmann
01:27 pm Revision e37f47d3: Improve test for tools.ensure_dirs
- Add more checks, some of them are deliberately redundant
- Descriptive error messages
- Add comment describing orde...
Michael Hanselmann

12/12/2012

05:54 pm Revision 164947cc: Jobs.hs: make L.Client the last argument for all functions
Having the Luxi client be the last argument of the functions allows for
easier use with `Exception.bracket L.getClien...
Dato Simó
05:06 pm Revision 5f2cdb2a: Fix a bug in the hs-coverage rule of Makefile.am
The coverage information for mon-collector was not merged correctly.
Signed-off-by: Michele Tartara <mtartara@google...
Michele Tartara
03:33 pm Revision 80df2895: Update NEWS for 2.6.2
This is in preparation for a 2.6.2 release.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iusti...
Michael Hanselmann
03:25 pm Revision 23f1bf29: uidpool: Remove roman number support
Doing so simplifies to code a bit and never had a practical use.
Signed-off-by: Michael Hanselmann <hansmi@google.co...
Michael Hanselmann
03:21 pm Revision 8e8092cc: Fix TypeError when unsetting OS parameters
When all OS parameters should be unset (“gnt-os modify -H -xen-pvm
foo”), a TypeError was raised. This fixes issue 31...
Michael Hanselmann
03:18 pm Revision 3e3ddbf0: Remove checks wrt IDISK_PARAMS from OpCode level
Change the "--disks" option validation, to just check the format
of the dict and do not check whether the keys are in...
Constantinos Venetsanopoulos
02:09 pm Revision cefd4a4a: Add shelltests for the mon-collector
This commit adds shelltests for the mon-collector binary and for the DRBD
data collector.
Also, it fixes a small bug...
Michele Tartara
02:09 pm Revision 332b1340: Add the stand-alone data collector for DRBD
It is implemented as a single binary receiving, as its first parameter,
the name of the actual data collector to be r...
Michele Tartara
02:08 pm Revision 61e062dd: Move the path of the DRBD status file to the Constants file
It will be needed by the DRBD data collector, that will be added shortly.
Signed-off-by: Michele Tartara <mtartara@g...
Michele Tartara
01:43 pm Revision 432d62a8: Make configure check for haskell vector library
Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Michele Tartara <mtartara@google.com>
Helga Velroyen
11:20 am Revision 405656b7: Remove usage of reserved key word 'family'
An old hlint version (1.8.28) was complaining about the
word 'family' being used in the network tests. Thanks to
an e...
Helga Velroyen
10:43 am Revision fcc1977b: Add documentation about new dependency to vector lib
Updates the INSTALL file to add the haskell library
libghc-vector-dev.
Signed-off-by: Helga Velroyen <helgav@google....
Helga Velroyen

12/11/2012

05:18 pm Revision 76a0266e: Network and address pool (again)
Implementation of the network objects and address pool. Functionality
as in the reverted commit b9a616e132af9bba718d2...
Helga Velroyen
04:53 pm Revision 9eac61f8: Fix ordering of entries in tools.ensure_dirs
Commit ebd437a added two new entries to tools.ensure_dirs, but did so in
the wrong order. Patch forthcoming to improv...
Michael Hanselmann
04:31 pm Revision ebd437a4: Set owner on watcher pause and queue drain files
If the files were created by a user different, e.g. due to a switch from
running masterd as root to running it as a d...
Michael Hanselmann
04:31 pm Revision af8f2fbf: lib/tools/ensure_dirs.py: Code formatting
Wrap lines in a consistent manner (uid/gid on the second line) if
wrapping is necessary at all. “git diff --color-wor...
Michael Hanselmann
03:37 pm Revision be6c403e: Replicate queue drain flag across all master candidates
Until now, the flag was unset on a master failover unless the
“$localstatedir/lib/ganeti/queue/drain” file existed.
...
Michael Hanselmann
01:01 pm Revision 4a3dd52d: Add utility function to create frozenset with unique values
When used instead of a plain call to “frozenset”, this would have
avoided the issue fixed in commit e2dd6ec. The new ...
Michael Hanselmann
01:01 pm Revision af54b7d7: constants: Remove duplicate DRBD barrier option
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann

12/10/2012

07:02 pm Revision d4e297b8: doc/rapi.rst: Add ECODE_TEMP_NORES
The assertion was failing as ECODE_TEMP_NORES was not documented.
Signed-off-by: Michael Hanselmann <hansmi@google.c...
Michael Hanselmann
06:03 pm Revision e2dd6ece: Change value for ECODE_TEMP_NORES
Unfortunately there was a bug in commit 518a45e whereby ECODE_TEMP_NORES
had the same value as ECODE_NORES, leading t...
Michael Hanselmann
05:53 pm Revision 94811696: Make htools/Ganeti/Constants.hs depend on errors.py
It also uses values from “lib/errors.py”.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin ...
Michael Hanselmann
05:48 pm Revision 13b8415b: Update changelog to latest version
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr> Dimitris Aragiorgis
04:47 pm Revision 78fcfd43: masterd: Remove duplicate code
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Helga Velroyen <helgav@google.com>
Michael Hanselmann
04:23 pm Revision 7fb5ac7c: Improve error message for when adding inotify watcher fails
Explicitely mention the fs.inotify.max_user_watches sysctl value.
Signed-off-by: Michael Hanselmann <hansmi@google.c...
Michael Hanselmann
04:23 pm Revision 6bee863c: htools/Ganeti/Errors: Add ECodeTempNoRes
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
Michael Hanselmann
03:34 pm Revision be505f2c: Update pyinotify website
It has moved to github.com.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Helga Velroyen <helga...
Michael Hanselmann

12/07/2012

05:43 pm Revision bccb8d20: htest/Types.hs: check ordering of some ADTs
In some ADT, ordering of constructors is important because a certain
meaning is attached to ordinality (e.g., "cluste...
Dato Simó
03:24 pm Revision c298ed02: htools: Add missing parameter to OpInstanceMultiAlloc
Somehow this went missing in commit 1f1188c.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Mich...
Michael Hanselmann
02:47 pm Revision 518a45e5: Add error code for temporary lack of resources
When an instance creation uses opportunistic locks, the iallocator might
not be able to find an allocation solution i...
Michael Hanselmann
02:47 pm Revision bc826292: Export error codes from RAPI client module
Until now the error codes were not available from the RAPI client
module. A newly added unit test ensures all error c...
Michael Hanselmann
02:45 pm Revision 78bfb560: cmdlib: Use locked nodes as node whitelist
Also actually start using opportunistic locks (if requested).
Signed-off-by: Michael Hanselmann <hansmi@google.com>
...
Michael Hanselmann
02:36 pm Revision 1f1188c3: cmdlib: Opportunistic locking on instance creation
Adds a new parameter to “OpInstanceCreate” and “OpInstanceMultiAlloc” to
use opportunistic locks.
Signed-off-by: Mic...
Michael Hanselmann
02:36 pm Revision b3c728dc: cmdlib: Node whitelist support for allocation request
Forward the node whitelist to the iallocator plugin.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-...
Michael Hanselmann
02:35 pm Revision e9a81214: mcpu: Verify node allocation lock mode
Add verification code to mcpu to check an LU's locks. Two whitelists are
provided to exclude LUs from the two tests.
...
Michael Hanselmann
02:35 pm Revision ba6eda59: _ExportQuery: Use node allocation lock
Block instance allocations when all node locks will be acquired.
Signed-off-by: Michael Hanselmann <hansmi@google.co...
Michael Hanselmann
02:35 pm Revision 38446261: LUBackupExport: Use node allocation lock
Block instance allocations when all node locks will be acquired.
Signed-off-by: Michael Hanselmann <hansmi@google.co...
Michael Hanselmann
02:35 pm Revision dc7d923e: LUBackupRemove: Use node allocation lock
Block instance allocations when all node locks will be acquired.
Signed-off-by: Michael Hanselmann <hansmi@google.co...
Michael Hanselmann
02:32 pm Revision 5df1c9aa: LUInstanceMultiAlloc: Use node allocation lock
Avoid conflicts between instance allocations.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Gui...
Michael Hanselmann
02:32 pm Revision 32bea623: LUInstanceRecreateDisks: Use node allocation lock
Block instance allocations when all node locks will be acquired.
Signed-off-by: Michael Hanselmann <hansmi@google.co...
Michael Hanselmann
02:32 pm Revision 48126102: LUNodeSetParams: Use node allocation lock
Block instance allocations when all node locks will be acquired.
Signed-off-by: Michael Hanselmann <hansmi@google.co...
Michael Hanselmann
02:32 pm Revision 7254c0a9: LUNodeQueryvols: Use node allocation lock
Block instance allocations when all node locks will be acquired.
Signed-off-by: Michael Hanselmann <hansmi@google.co...
Michael Hanselmann
02:32 pm Revision cfae7671: LUOobCommand: Use node allocation lock
If no node names are given, all node locks are acquired.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Revie...
Michael Hanselmann
12:40 pm Revision 63e166a5: Fix typo in comment
There was a typo in the docstring of the parseMessage function of the
confd server.
Signed-off-by: Michele Tartara <...
Michele Tartara
11:45 am Revision fa23de0b: Revert "Network and address pool"
This reverts commit b9a616e132af9bba718d2da8c94eeec7af886814, which
depends on the "bitvec" library. We need to inves...
Helga Velroyen

12/06/2012

07:13 pm Revision b9a616e1: Network and address pool
Implementation of the network and address pool class in
Haskell. Not complete yet. Includes unit tests that cover
all...
Helga Velroyen
06:19 pm Revision e712e5b8: Fix node-daemon-setup test with older pyOpenSSL
Older versions use “-----BEGIN RSA PRIVATE KEY-----” instead of
“-----BEGIN PRIVATE KEY-----”.
Signed-off-by: Michae...
Michael Hanselmann
05:07 pm Revision d5fe5fa9: Add tool to clean up node
Sometimes a node is not removed properly from a cluster (especially
during development). This new tool stops all daem...
Michael Hanselmann
04:07 pm Revision 69e5fefc: Add tool to configure node daemon
The design for this is in “doc/design-node-add.rst”. The tool receives a
JSON data structure on stdin and configures ...
Michael Hanselmann
04:07 pm Revision 7b8ba235: Switch from scp/ssh to node daemon setup utility
This patch does away with many calls to scp and by means of using
“tools/node-daemon-setup”, verifies most of the val...
Michael Hanselmann
02:29 pm Revision 4c49b965: make genMaybe more Just
There is a common conception that Just something is more worth than
Nothing. So we're biasing our tests towards that....
Guido Trotter
01:37 pm Revision f22433c0: Locking related fixes for networks
Use GetNetwork() only when having already aquired the lock,
i.e. in CheckPrereq().
In LUNetworkConnect/Disconnect do...
Dimitris Aragiorgis
11:15 am Revision 3516b09a: Fix build breakage in Jobs.hs test code
Commit 3bdbe4b3 (“Jobs.hs: move OpStatus and JobStatus ADTs to
Types.hs”) removed the TemplateHaskell language pragma...
Iustin Pop

12/05/2012

09:04 pm Revision 7b22f99c: configure.ac: fix reading of HLINT environment variable
configure.ac advertised that the HLINT environment variable could be set to
specify the path to the 'hlint' tool. How...
Dato Simó
09:04 pm Revision 369671f4: Hbal.hs: move job execution functions to Jobs.hs
Ganeti.Jobs now holds functions that can be used to submit and monitor the
status of jobs. In particular, execJobsWai...
Dato Simó
09:04 pm Revision 42afc235: Hbal.hs: use Result (), not Bool, as return value for exec*
Previously, functions in Hbal.hs related to execution of jobsets were
returning only IO Bool, and printing any errors...
Dato Simó
09:04 pm Revision 3b23f238: Hbal.hs: rename functions that deal with early termination
In Hbal.hs, it's easy to get lost in the flow of exec* functions
because their names are similar and don't convey the...
Dato Simó
09:03 pm Revision 9cd4288e: Hbal.hs: fix typo in signal handler names (hangle -> handle)
'hangleSigInt' and 'hangleSigTerm' are renamed to 'handleSigInt' and
'handleSigTerm', respectively.
Signed-off-by: D...
Dato Simó
09:03 pm Revision 3bdbe4b3: Jobs.hs: move OpStatus and JobStatus ADTs to Types.hs
This leaves Ganeti/Jobs.hs and Test/Ganeti/Jobs.hs empty, but they're the
target of a future move of some functions, ...
Dato Simó
07:05 pm Revision de645b5b: Makefile: Reset environment for epydoc
epydoc allows overriding configuration values via environment variables.
While this might be useful in certain use ca...
Michael Hanselmann
05:35 pm Revision 3c631ea2: jqueue: Don't modify input opcode when changing priority
Commit 4679547 implemented the ability to change job's priority after it
was submitted. The code contained a bug wher...
Michael Hanselmann
05:04 pm Revision ca519248: Use new util function for mac_prefix validation
Use new NormalizeAndValidateThreeOctetMacPrefix() util function in
LUNetworkAdd/LUNetworkSetParams to validate networ...
Dimitris Aragiorgis
01:00 pm Revision 26e88cde: LUClusterRedistConf: Use node allocation lock
All node locks are acquired.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Helga Velroyen <helg...
Michael Hanselmann
01:00 pm Revision 9cbfc69a: LUClusterRepairDiskSizes: Use node allocation lock
This opcode acquires all node resource locks, which conflicts with
instance allocations.
Signed-off-by: Michael Hans...
Michael Hanselmann
01:00 pm Revision 51305499: LUGroupVerifyDisks: Use node allocation lock
See comment in code.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Helga Velroyen <helgav@googl...
Michael Hanselmann
01:00 pm Revision 9fa08c84: LUClusterVerifyGroup: Use node allocation lock
See comment in code.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Helga Velroyen <helgav@googl...
Michael Hanselmann
01:00 pm Revision ec272bab: LUInstanceReplaceDisks: Acquire node allocation lock
If the lock was acquired in the first place (only when an iallocator is
used), it is released as soon as possible.
S...
Michael Hanselmann
12:46 pm Revision de5967da: LUInstanceChangeGroup: Acquire node allocation lock
Changing instances' groups shouldn't conflict with instance allocations.
Signed-off-by: Michael Hanselmann <hansmi@g...
Michael Hanselmann
12:44 pm Revision a0150c51: Acquire node allocation lock during node query
If locking is used (usually by ganeti-watcher), node allocations must be
temporarily blocked.
Signed-off-by: Michael...
Michael Hanselmann
12:44 pm Revision 0ab31d67: Mention dsh/cssh in man page for "gnt-cluster command"
Until now they are only mentioned in “doc/admin.rst” and the man page
for “ganeti-listrunner”.
Signed-off-by: Michae...
Michael Hanselmann

12/04/2012

07:54 pm Revision fb60bc6a: iallocator: Add node whitelist
In the future instance creations might have a lock on all nodes as was
the case until the implementation of opportuni...
Michael Hanselmann
07:32 pm Revision d5b031dc: Allow ignoring successful commands in "gnt-cluster command"
In some cases it is useful to ignore the output of and avoid mentioning
successful commands. One would be when lookin...
Michael Hanselmann
06:46 pm Revision faef859e: Ganeti/HTools/Graph Add isColorable
Check whether coloring on a given graph makes sense. This is the case
only if there are no loops and the graph is und...
Guido Trotter
06:46 pm Revision 742bd043: Add Dsatur implementation
Implement the Dsatur algorithm for Graph coloring. This also abstracts
the neighColors function into two subfunctions...
Guido Trotter
06:46 pm Revision 8e6623c8: Add Ganeti.HTools.Graph
This module implements some algorithms on Data.Graph data structures.
At the moment its main functionality is an LF-c...
Guido Trotter
06:46 pm Revision c94f9990: Add "proper coloring" unittest check
We have to check that for each edge its vertices have different colors.
This is very easy to do with a vertex-to-col...
Guido Trotter
06:46 pm Revision dae1f9cb: HTools/Node: add mkNodeGraph function
This function helps treating node node problems as graph problems.
It can transform a list of nodes plus a list of in...
Guido Trotter
06:46 pm Revision 8b50de5c: Fix Dsatur and add Dcolor
Our Dsatur implementation was incorrect: while the paper defined the
degree of saturation of a vertex as the number o...
Guido Trotter
06:46 pm Revision 34a21cc4: Add tests for verticesByDegree{Asc,Desc}
This brings our coverage of Graph.hs to 100%
Signed-off-by: Guido Trotter <ultrotter@google.com>
Reviewed-by: Iustin...
Guido Trotter
05:24 pm Revision 402ff455: errors: Show error descriptions in API documentation
Comments with a colon after the hash sign (“#:”) show up in the
epydoc output.
Signed-off-by: Michael Hanselmann <ha...
Michael Hanselmann
04:39 pm Revision 4d829f55: Small improvement to rpc-test
This will show smaller/better error messages: full node dumps are no
longer included.
Signed-off-by: Iustin Pop <ius...
Iustin Pop
04:26 pm Revision ef66500f: Fix locking mistake introduced in commit 5cc1f88
The node resource locks were not set correctly on instance import.
Signed-off-by: Michael Hanselmann <hansmi@google....
Michael Hanselmann
04:11 pm Revision 7e723913: Switch luxi submit job calls to use MetaOpCode
This patch changes the luxi submit job calls to use wrapped opcodes,
and therefore it changes Hbal to submit actual m...
Iustin Pop
01:53 pm Revision 2746a72c: hbal: restore nice job ID display
This fixes:
Got job IDs JobId {fromJobId = 1052613}
And restores to:
Got job IDs 1052624
Other improvements c...
Iustin Pop
01:44 pm Revision b46ba79c: Add types and parameters for common opcode implementation
This will go into a separate type; this patch adds the needed
underlying types and parameters.
Signed-off-by: Iustin...
Iustin Pop
01:44 pm Revision c67b908a: Add a negative type
This mirrors the positive one, and will be needed for relative job
IDs.
Signed-off-by: Iustin Pop <iustin@google.com...
Iustin Pop
01:44 pm Revision e45be9d4: Add a type alias for simpler THH signatures
This is reused in more than just a few places, so adding it makes the
signatures much nicer.
Signed-off-by: Iustin P...
Iustin Pop
01:44 pm Revision 84c2e6ca: Change opcode/luxi showJSON generation in THH
Currently, the opcode and luxi "showJSON" functions generate directly
a JSValue; in contrast, the object (single-cons...
Iustin Pop
01:44 pm Revision d5af1f95: Remove unused THH function 'saveLuxiField'
This was deprecated via commit 88609f00, “Switch Luxi TH code from
simple to custom fields”.
Signed-off-by: Iustin P...
Iustin Pop
01:44 pm Revision dd076c21: Add safety check on job dependency/TIsLength
If TIsLength is applied to a non-container item, it will fail (type
error) due to invalid application of len(). Since...
Iustin Pop
01:44 pm Revision 4a826364: Add CommonOpParams and MetaOpCode types
This patch adds the "meta" opcode type and the common op
params. Compatibility tests with Python are changed to pass ...
Iustin Pop
01:44 pm Revision a2d7ea09: Small Makefile.am cleanups
Indentation within rules is fixed to always be 2 spaces (as opposed to
mixed tabs/2 spaces/4 spaces). Additionally, t...
Iustin Pop
01:44 pm Revision 9cda4d6a: Fix long lines in Ganeti.HTools.Types and add Make check
Since hlint doesn't check style issues but rather code only issues,
let's add a simple Makefile check for too-long li...
Iustin Pop
01:44 pm Revision af42ffb6: Two small haskell-related Makefile improvements
Just some cleanup:
- don't run hlint over hpc-htools, since it's just a symlink to
htools.hs (so we'd get duplicat...
Iustin Pop
01:44 pm Revision fa10983e: Rework custom fields handling
This patch changes a bit the handling of custom fields. Since in
general we use custom fields to aggregate multiple e...
Iustin Pop
01:44 pm Revision 3929e782: Add a function for all fields of a given OP_ID
This patch changes THH to export a new function which defines all
fields of a given OP_ID. Not very clean, since for ...
Iustin Pop
01:44 pm Revision 3d7e87b8: Rework/enhance original htools opcodes
The original htools opcodes were minimalistic and not 1:1 equivalent
with the Python ones. Let's add all missing fiel...
Iustin Pop
01:44 pm Revision 67fc4de7: Add a few missing fields from opcodes
Due to manual conversion, a few fields were missing from the
conversion, but as they were optional our type equivalen...
Iustin Pop
01:44 pm Revision 1dbceab9: Fix Haskell OpNetworkAdd
Commit 213076f (“Fix locking in networks”) changed Python OpNetworkAdd
without corresponding Haskell definition chang...
Iustin Pop
01:44 pm Revision c48711d5: Add a 'real' type for JobIds
Currently, the job ID is a simple type alias. This is suboptimal, as
it means we can't use a custom JSON (or Arbitrar...
Iustin Pop
01:44 pm Revision 6903fea0: Add type for finalised job statuses
For now, we don't need a pending job status type as well, so we'll
delay adding that until later.
Signed-off-by: Ius...
Iustin Pop
01:44 pm Revision d1ac695f: Add test for opcode fields equivalence
As opposed to the existing test, which tests the type/serialisation of
fields, this one simply tests the equivalence ...
Iustin Pop
01:44 pm Revision 5f4fdf93: Fix generation of clusters via 'genEmptyCluster'
The current uniqueness algorithm (generate random node names, suffix
them with node index) is actually wrong: a node ...
Iustin Pop
12:57 pm Revision dbd1264a: LUClusterSetParams: Use node allocation lock
All resources are acquired and opportunistic instance creations would
fail. Also add a TODO.
Signed-off-by: Michael ...
Michael Hanselmann
12:56 pm Revision 5cc1f887: LUInstanceCreate: Acquire node allocation lock
Opportunistic locks are not yet used. This patch changes
LUInstanceCreate to acquire the node allocation lock to avoi...
Michael Hanselmann
12:56 pm Revision 2cb3181a: Acquire node allocation lock for failover/migration
See code for an explanatory comment. The lock is released as soon as
possible.
Signed-off-by: Michael Hanselmann <ha...
Michael Hanselmann
12:47 pm Revision 1dacbb06: Use GetMultiInstanceInfo in LUNetwork* opcodes
LUNetworkConnect/Disconnect looks up a nodegroup's instances for
conflicting IPs. To do so, use GetNodeGroupInstances...
Dimitris Aragiorgis
11:22 am Revision d242923c: utils.text: Function to verify MAC address prefix
The network management code needs to verify a MAC address prefix.
Instead of (ab)using NormalizeAndValidateMac, clean...
Michael Hanselmann

12/03/2012

07:38 pm Revision cbcd9144: Improve the Haskell api doc directory creation system
Instead of having two different lists of directories, now there is only one.
Signed-off-by: Michele Tartara <mtartar...
Michele Tartara
04:33 pm Revision 0602cef3: Factorize code for checking node daemon certificate
This code is going to be used by a new utility for setting up the node
daemon. Unit tests are updated/added.
Additio...
Michael Hanselmann
03:56 pm Revision 686d24f0: Support opportunistic locks in mcpu/LUs
Similar to “share_locks”, a new dictionary containing booleans for each
locking level is added to “cmdlib.LogicalUnit...
Michael Hanselmann
03:56 pm Revision 07db7ed2: Add opportunistic locking to GanetiLockManager
Just forwarding the parameter, nothing more.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guid...
Michael Hanselmann
03:56 pm Revision a95c53ea: locking: Implement opportunistic locking in LockSet
This patch adds a new parameter to “LockSet.acquire” named
“opportunistic”. When enabled the lockset will try to acqu...
Michael Hanselmann
03:04 pm Revision 9b4329e9: Add ssconf function to read all files
Configuring a node daemon on a newly added node will need all ssconf
values.
Signed-off-by: Michael Hanselmann <hans...
Michael Hanselmann
03:04 pm Revision e1874aa7: bootstrap.RunNodeSetupCmd: Add IPv6 support
Commit 224ff0f modified the node SSH setup to use the system's SSH
client. Before that Paramiko was used. It's not en...
Michael Hanselmann
03:04 pm Revision a698cdbb: Factorize running node setup command
Part of the code used for running “prepare-node-join” can be re-used for
running a tool to configure the node daemon....
Michael Hanselmann
03:03 pm Revision cc7f5bfc: ssconf: Add dry-run support for writing files
A new utility for configuring the node daemon will support a dry-run
mode. This patch adds the necessary functionalit...
Michael Hanselmann
03:03 pm Revision 29a32ce5: ssconf: Add function to verify keys
The new utility for configuring the node daemon will have to check
whether it received valid ssconf names.
Signed-of...
Michael Hanselmann
01:56 pm Revision 0cc3f0d7: Design for opportunistic locking
Add the design document for opportunistic locking.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by...
Michael Hanselmann
01:35 pm Revision 07ac4aaf: Fix variable names in Loader.assignIndices
This function can be applied to any type of class "Element" but its
internal variables used to refer to a list of tup...
Guido Trotter
01:21 pm Revision 00457f03: LUNetworkAdd: Log warning when needed
In case conflicts are checked, log warnings if nodes' IPs cannot
be reserved.
Signed-off-by: Dimitris Aragiorgis <di...
Dimitris Aragiorgis
01:17 pm Revision efb8848f: Use constants.IP4_VERSION in LUNetworkAdd
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr>
Reviewed-by: Michael Hanselmann <hansmi@google.com>
Dimitris Aragiorgis
01:04 pm Revision 213076fe: Fix locking in networks
Ensure that locks are held only if needed.
Add conflicts_check in OpNetworkAdd. This is needed if we want to
check w...
Dimitris Aragiorgis
12:45 pm Revision 9de303af: Add unit tests for the JSON serialization of DRBD status
The serialization itself is done by Text.JSON, so the tests deal with checking
that Text.JSON objects are created cor...
Michele Tartara
12:45 pm Revision 2188740e: Add JSON serialization capabilities for DRBD status
The serialized JSON is not a 1:1 dump of the data structures
populated by the parser. This is done intentionally, wit...
Michele Tartara
12:45 pm Revision 3c8e6d09: Add two support functions for building JSON objects
The new support functions in module Ganeti.JSON will be used by the next
commits to build JSON objects with optional ...
Michele Tartara
12:31 pm Revision 086ad4cf: Reduce hostname length in tests and opcode py_compat count
This improves Issue 325 - new runtime and memory consumption is about
1/10 compared to before.
Signed-off-by: Iustin...
Iustin Pop
11:41 am Revision 9f80119c: Add generator for an instance on a node list
Given a node list in input, we get an instance that had nodes in it.
Signed-off-by: Guido Trotter <ultrotter@google....
Guido Trotter
11:18 am Revision bdb7dbbb: Add generator for list of arbitrary instances
This takes an instance generator and produces a possibly empty list of
instances.
Signed-off-by: Guido Trotter <ultr...
Guido Trotter
11:18 am Revision 736ba160: Add generator for list of arbitrary nodes
This generates a minimum of one node, because legal clusters never have
zero nodes.
Signed-off-by: Guido Trotter <ul...
Guido Trotter
10:54 am Revision 5a736782: Fix options in hbal manpage
hbal doesn't have any "-o" option, but on the other hand supports -S
(described below, but not present in the short s...
Guido Trotter

11/30/2012

10:46 pm Revision 9da445a9: Merge branch 'stable-2.6-ippool-hotplug-esi' into debian-2.6
Dimitris Aragiorgis
10:39 pm Revision 95a74ef3: Support newstyple rbd commangd output
This patch is taken from ganeti mailing list: http://goo.gl/LgukY
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr>
Dimitris Aragiorgis
10:12 pm Revision d9039658: Fix a bug introduced by resolving a conflict
In _GenerateDiskTemplate() we make use of params variable in case
of ExtStorage. Hotplug code conflicts here.
Signed...
Dimitris Aragiorgis
07:24 pm Revision 2ccfc35a: Merge branch 'stable-2.6-hotplug' into stable-2.6-ippool-hotplug-esi
Dimitris Aragiorgis
07:24 pm Revision 7ed9f1ba: Fix a minor bug in hypervisor
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr> Dimitris Aragiorgis
06:33 pm Revision 50c302ca: Create a genInstanceMaybeBiggerThan function
This is used only once when testing Cluster.hs, but having it abstracted
clarifies there what that call is about, mak...
Guido Trotter
06:33 pm Revision 0ff01075: Change -G option description
The new one is more consistent with the rest of the nodegroup
terminology and more generic for use in different htool...
Guido Trotter
04:17 pm Revision c3231353: Fix Haskell profiling targets
It turns out that in newer GHC versions, the suffix shouldn't be
prefixed with a dot; otherwise name mangling is brok...
Iustin Pop
04:17 pm Revision d277b075: Optimise recursive Query filters
Currently, the And and Or filters use very nice code, e.g. in case of
OrFilter:
any id <$> mapM evaluateFilter fl...
Iustin Pop
04:17 pm Revision 228ef0f2: Make Query operators enforce strictness
Currently, the query operators (binop, etc.) create thunks, instead of
forcing the evaluation of the simple boolean r...
Iustin Pop
03:57 pm Revision 08fd383d: Fix htools/rpc-test after recent changes
Since this program is not built normally, a few recent commits broke
it:
- 707cd3d (“Use exitErr instead of explicit...
Iustin Pop
03:54 pm Revision 7d421386: Remove remaining in-line parameters
… except one, and replace them with separately-defined ones in
OpParams.
Signed-off-by: Iustin Pop <iustin@google.co...
Iustin Pop
03:54 pm Revision 139c0683: Remove read instances from our Haskell code
It turns out that optimising 'read' derived instances (via -O) for
complex data types (like OpCode, or the various ob...
Iustin Pop
03:54 pm Revision f9556d33: Replace hand-coded 'live' field of OpInstanceMigrate
This is the last inline-written field; I've done it separately from
the last patch due to changes being needed in HTo...
Iustin Pop
03:54 pm Revision dc4b5c42: Add explicit test for wrong OpCode arbitrary instances
I've been bitten a couple of times with arbitrary opcodes working on
UTF-8 locale, but failing on buildbot (ASCII). S...
Iustin Pop
03:54 pm Revision 3131adc7: Abstract query common opcode definitions
It would be even better if the opcodes would actually have all the
same definitions, until then we have two sets of d...
Iustin Pop
03:54 pm Revision 5006418e: Make QuickCheck generator names more uniform
Due to lack of attention, we have two styles for generators of
arbitrary values: get* and gen* (e.g. getFQDN and genD...
Iustin Pop
03:54 pm Revision 1cd563e2: Add two last missing opcodes
OpInstanceQuery was missing accidentally, whereas OpRestrictedCommand
was just recently added without Haskell definit...
Iustin Pop
03:54 pm Revision 9b773665: Enable equivalence checks of opcode list
This patch enhances the opcode list checks - instead of spawning a
Python interpreter to display the opcode list, we ...
Iustin Pop
03:54 pm Revision 8d239fa4: Add types, parameters and the opcodes for networks
This completes the last missing opcode group. The only difficulty was
with the ip addresses, where we used simple str...
Iustin Pop
03:54 pm Revision 497beee2: Move NICMode from Objects.hs to Types.hs
Also add some unittests for this type.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Helga Velroyen <he...
Iustin Pop
03:54 pm Revision a3f02317: Complete the Test opcodes
This adds the OpTestAllocator, OpTestJqueue and OpTestDummy
opcodes. The OpTestAllocator seems to need some cleanup (...
Iustin Pop
03:54 pm Revision 55b7e783: Rename OpTestAllocator.allocator to iallocator
This makes the OpCode more consistent with the other opcodes. The
downside is incompatibility when upgrading from 2.6...
Iustin Pop
03:54 pm Revision 89514061: Add a helper for the "iallocator" opcode field
This field is used with just changed description in about 10 opcodes,
so unifying it makes things simpler for future ...
Iustin Pop
03:54 pm Revision a451dae2: Complete the Tag opcodes and fix OpTestDelay missing param
The regexp in OpTagsSearch is loaded as is, without testing for
validity; the rest of the patch is trivial.
Signed-o...
Iustin Pop
03:54 pm Revision 398e9066: Add Group, OS and Backup opcodes
This also corrects a docstring in OpBackupExport on the Python side.
Signed-off-by: Iustin Pop <iustin@google.com>
R...
Iustin Pop
03:54 pm Revision c2d3219b: Complete the instance OpCodes and parameters
Only the original instance opcodes (used in htools) are left
non-converted to only parameter style; they'll be cleane...
Iustin Pop
03:54 pm Revision 08f31176: Add test for mutable default values in opcode parameters
This is not comprehensive, since in Python one can't determine what is
and what is not mutable; but I've added a few ...
Iustin Pop
03:54 pm Revision 4c405df7: Fix empty list as default value in OpInstanceMultiAlloc
Commit 12e62af5 (“Adding the new opcode for multi-allocation”)
introduced a "bad" default value; while porting this t...
Iustin Pop
03:48 pm Revision 6d558717: Add types and parameters for OpInstanceCreate
This is a "big" opcode, so sending it separately.
A few types needed changing, and a few parameters were renamed to ...
Iustin Pop
03:48 pm Revision c65621d7: Move FileDriver from Objects to Types
Another base type that we need in opcodes as well.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Helga ...
Iustin Pop
11:44 am Revision 86b9a385: Fix breakage introduced in commit a8b3b09
The order of the calls to “ctx.use_privatekey” and “ctx.use_certificate”
was wrong, leading to an exception being thr...
Michael Hanselmann
10:51 am Revision a8b3b09d: Factorize SSL context setup for certificate check
This code will also be used by the node daemon setup utility.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
...
Michael Hanselmann
10:14 am Revision e055a2ab: Introduce ht.TMaybeValueNone and ht.TValueNone
TValueNone checks if a value is "none" and TMaybeValueNone is a wrapper
of TOr(TValueNone, x). This is used by OpNetw...
Dimitris Aragiorgis
07:10 am Revision 5dff65da: opcodes: Replace manual loop with map
Also remove a superfluous empty line in test file.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by...
Michael Hanselmann

11/29/2012

01:33 pm Revision 16091a6e: Fix type descriptions in RAPI documentation
This patch adds descriptors to the “_CheckCIDR*” functions in opcodes
and improves the descriptions generated by “ht....
Michael Hanselmann
01:26 pm Revision 853c570b: Fixing crash when removing disks
This bug was introduced by my commit "Check ispecs against ipolicy on
instance modify", because I did not filter for ...
Helga Velroyen
12:46 pm Revision 48aaca91: locking: Change locking order, move NAL after instances
Some opcodes, for example LUInstanceFailover and LUInstanceMigrate,
can't know whether they need to acquire all nodes...
Michael Hanselmann
12:24 pm Revision 4349c24d: Fix Attoparsec test coverage check compatibility
The hpc tool, on squeeze, does not handle utf8 encoded files correctly.
The Attoparsec test is just needed to verify ...
Michele Tartara
10:01 am Revision c9f79949: Add constant for node certificate mode
A new utility for configuring the node daemon will have to write the
node certificate as well. To not split informati...
Michael Hanselmann

11/28/2012

01:48 pm Revision dffa96d6: Move cluster verification out of prepare-node-join
A new tool for configuring the node daemon will also have to verify the
cluster name, so it's better to have this fun...
Michael Hanselmann
01:48 pm Revision 911dfc49: ssconf: Verify file size when reading, add some tests
Until now ssconf would limit the amount read from files to 128 KiB and
silently ignored files larger than that. With ...
Michael Hanselmann
10:30 am Revision 965a542a: Fix pylint error introduced in commit 9675661
Missing spaces around operator.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Michele Tartara <...
Michael Hanselmann
09:45 am Revision fb486969: ssconf: Move class-level constants to module
There is no good reason why these two constants should be inside the
class. This patch moves them to the module so th...
Michael Hanselmann
09:45 am Revision f35111c0: Remove ssconf.SimpleConfigReader
Commit b0dcdc1 removed the last user of this class.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-b...
Michael Hanselmann
09:45 am Revision c5ac51bb: ssconf: Small error message fixes
- Include filename in error message
- s/ip/IP/
- Stop using superfluous variable
Signed-off-by: Michael Hanselmann <...
Michael Hanselmann

11/27/2012

08:36 pm Revision 88e9b27f: Merge branch 'stable-2.6-hotplug' into stable-2.6-ippool-hotplug-esi
Conflicts:
lib/cmdlib.py
tools/cfgupgrade
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr>
Dimitris Aragiorgis
07:57 pm Revision 83a14695: Fix network query for extra stats fields
Extend _GetNetworkStatsField() to accept 4 arguments.
This fixes Issue 323.
Signed-off-by: Dimitris Aragiorgis <dima...
Helga Velroyen
03:03 pm Revision 9675661c: Export UUID and serial no in network queries
Add uuid and serial_no to _NETWORK_SIMPLE_FIELDS in order to export
them in network queries. Modify gnt-network to li...
Dimitris Aragiorgis
02:12 pm Revision 1ea0e8a8: ssconf: Remove unused regular expression
RE_VALID_SSCONF_NAME is not used anywhere.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Michel...
Michael Hanselmann
01:27 pm Revision 0ee383bf: Fix build after commit 9b7e05a
Commit 9b7e05a didn't quite work as expected: glm.is_owned expects a
locking level, not a lock name.
Signed-off-by: ...
Michael Hanselmann
12:54 pm Revision 5d630c22: Factorize code to load and verify JSON
A new tool to configure the node daemon will also have to load and
verify JSON data.
Signed-off-by: Michael Hanselma...
Michael Hanselmann
12:54 pm Revision 796b5152: Factorize logging setup in tools
Most tools had their own “SetupLogging” function, but they were all
essentially the same. This patch adds a generic v...
Michael Hanselmann
12:06 pm Revision fd80be11: Small improvements to the DRBD parser and tests
* Now the parser completely consumes the input, up to the end of the text.
* Name of the test suite module changed to...
Michele Tartara
11:44 am Revision 81cfd8e5: LUNodeQueryStorage: Use node allocation lock
Block instance allocations when all node locks will be acquired.
Signed-off-by: Michael Hanselmann <hansmi@google.co...
Michael Hanselmann
10:26 am Revision e58009da: cmdlib: Don't pass processor to _ComputeNics
The execution context ID can be passed right away.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by...
Michael Hanselmann
10:26 am Revision 9b7e05a6: cmdlib.LUInstanceRename: Another assertion for BGL
Check whether the BGL is actually held instead of just testing
“REQ_BGL”.
Signed-off-by: Michael Hanselmann <hansmi@...
Michael Hanselmann
10:26 am Revision 4a4c0092: cmdlib: Stop using proc.Log*
The Log* functions are re-exported through the LU. Inline use of string
formatting (“%”) was converted to additional ...
Michael Hanselmann
10:22 am Revision b1ad19c5: cmdlib: Use CommaJoin where appropriate
Don't use inline versions of CommaJoin.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Helga Vel...
Michael Hanselmann
10:14 am Revision 21faa3ad: LUNetwork*: Build dictionaries right away
… instead of constructing an object, only to fill it separately.
Signed-off-by: Michael Hanselmann <hansmi@google.co...
Michael Hanselmann

11/26/2012

01:26 pm Revision 8c811986: locking: Method to check if LockSet is fully acquired
A new method is added to check whether the LockSet-internal lock is
held. This is the case after LockSet.acquire was ...
Michael Hanselmann
01:00 pm Revision 2fe8188a: Refactor hotplug implementation
Remove pci_pool from hotplug_info. Hypervisor decides the pci slot
based on current occupations.
Signed-off-by: Dimi...
Dimitris Aragiorgis
12:51 pm Revision 5d9653f1: Hotplug: do not allow disk/0 to be hotplug-able
BIOS boots from first disk. If we enable hotplug in disk/0
it will added at the end of PCI address space (slot 31). I...
Dimitris Aragiorgis
12:51 pm Revision e926e474: Hotplug: rpc only if instance is running
Intruduce new function _InstanceRunning().
Fix *PCIInfo config methods to hold exclusively _config_lock and
take inst...
Dimitris Aragiorgis
12:51 pm Revision 29d525f7: Fixes to pass unittests (make check)
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr> Dimitris Aragiorgis
12:51 pm Revision 5b588458: Fixes to pass pylint (make lint)
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr> Dimitris Aragiorgis
12:51 pm Revision 7074fb68: Add logging in case of hotplug
Signed-off-by: Dimitris Aragriorgs <dimara@grnet.gr> Dimitris Aragriorgs
12:51 pm Revision e4dd9f94: Refactor _GetPCIInfo() in cmdlib
Signed-off-by: Dimitris Aragriorgs <dimara@grnet.gr> Dimitris Aragriorgs
12:51 pm Revision b97fd21f: Add hotplug option in gnt-backup client
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr> Dimitris Aragiorgis
12:51 pm Revision 155b34f8: Maintain backwards compatibility in kvm runtime
Introduce _GenerateKVMBlockDevicesOptions()
In case hotplug is enabled per instance then the runtime file
contains o...
Dimitris Aragriorgs
12:51 pm Revision 0ad4022a: Dummy commit for compatibility
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr> Dimitris Aragiorgis
12:51 pm Revision 40c18c9e: Hotplug: client support
Add --hotplug option.
Only used by OpInstanceCreate()/OpInstanceSetParams.
Signed-off-by: Dimitris Aragiorgis <dimar...
Dimitris Aragiorgis
12:51 pm Revision f80ad2ae: Hotplug: KVM support
KVM >= 1.0 is needed.
Introduce new methods: HotAddNic/HotDelNic
Both qemu monitor interface for hotplugging. If a ...
Dimitris Aragiorgis
12:51 pm Revision 8b8b6ef7: Hoplug: rpc support
Introduce new RPCs that eventually invoke hypervisor specific
hotplug functions.
Signed-off-by: Dimitris Aragiorgis ...
Dimitris Aragiorgis
12:51 pm Revision cb6fb356: Hotplug: cmdlib support
Hotplugging is done by functions invoked by ApplyContainerMods(). In
order hotplugging to take place a --hotplug opt...
Dimitris Aragiorgis
12:51 pm Revision fe9965a4: Hoplug: objects modifications/additions
Introduce new HotplugInfo object as part of Instance object.
hotplug_info { 'nics': 0, 'disks': 0, 'pci_pool': [16, ...
Dimitris Aragiorgis
12:49 pm Revision 2435f63b: Refactor hotplug implementation
Remove pci_pool from hotplug_info. Hypervisor decides the pci slot
based on current occupations.
Signed-off-by: Dimi...
Dimitris Aragiorgis
12:00 pm Revision 46cde471: mcpu: Start locking at correct level
Commit 8716b1d added a new lock level, LEVEL_NODE_ALLOC. It is ahead of
LEVEL_INSTANCE. The latter was hardcoded in m...
Michael Hanselmann

11/23/2012

06:47 pm Revision 51f2650e: Fix wrong edge case in a QuickChek Drbd property
The bug was in the test itself, not in the tested code.
Also, fixed a line longer than 80 characters in the same fil...
Michele Tartara
06:19 pm Revision 8716b1db: Add new lock level for node allocations
The new lock is similar to the BGL in the sense that it has its own
level and there is only one. It is called “node a...
Michael Hanselmann
06:11 pm Revision 18837cd8: QuickCheck Tests for the commaIntParser, part of DRBD Parser
These new tests substitute the HTests, as by the suggestion
received after submitting the previous patch.
Signed-off...
Michele Tartara
05:07 pm Revision dadf0bfe: Add gnt-network to .gitignore
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
Michael Hanselmann
04:56 pm Revision 4bb02813: Corrected network design doc regarding user interface
This patch fixes some inconsistencies betwen the network
design doc and the actual user interface. Adding reserved
ip...
Helga Velroyen
04:24 pm Revision e1494c96: Fix network opcode parameters
Commit 32e3d8b1 (“opcodes: Network parameter improvements and fixes”)
changed a few parameters in the network add, co...
Iustin Pop
04:24 pm Revision fd9f58fd: Introduce a TMaybe combinator
We have many cases in the code where we write TOr(TNone, a), so let's
introduce a combinator that simplifies this cas...
Iustin Pop
04:24 pm Revision 2b5b0fe9: Replace dict() with {}
The network patches and an existing test added function-call based
dict construction as opposed to literal sintax.
S...
Iustin Pop
04:23 pm Revision 7a476bb5: Export network in FinalizeExport()
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr>
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Iusti...
Dimitris Aragiorgis
04:23 pm Revision 829cfbc5: Fix bug in OpNetworkQuery result check
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr>
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Iusti...
Dimitris Aragiorgis
04:22 pm Revision 55f70aef: Fix bug in network module
Signed-off-by: Dimitris Aragiorgis <dimara@grnet.gr>
Signed-off-by: Iustin Pop <iustin@google.com>
[iustin@google.com...
Dimitris Aragiorgis

11/22/2012

05:48 pm Revision 425f3ffe: Add design for simplified node-add process
Instead of initiating many SSH connections to copy files using “scp”, a
JSON structure is passed to a program running...
Michael Hanselmann
03:13 pm Revision 12f647fb: cmdlib.py: don't use GetHypervisor
In cmdlib we must only use the hypervisor class, and never instantiate
it. As such we have to call GetHypervisorClass...
Guido Trotter
01:56 pm Revision b22b93dc: Implement the correct handling of numbers without commas
commaInt now recognizes only the first 3 digits for numbers without commas.
It was erroneously recognizing numbers o...
Michele Tartara
01:40 pm Revision 2abb9ea8: Make ipolicy violations a warning
So far, when running 'gnt-cluster verify' on a cluster which
has instances that violate the instance policy, those
vi...
Helga Velroyen

11/21/2012

05:54 pm Revision 2556424d: Small style fixes (' vs ") in network code
This is just trivial fixes; I think I caught all of them.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by:...
Iustin Pop
04:58 pm Revision 6a28e02c: Add two more basic types
These are needed for completing the node opcode parameters.
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-b...
Iustin Pop
04:58 pm Revision d6979f35: Add many more opcode parameters
This is a bulk add of all node parameters needed for node and cluster
opcodes. The parameters are defined with a few ...
Iustin Pop
04:58 pm Revision c7d249d0: Convert a few existing opcode parameters to safer types
This does a partial conversion of existing opcodes to the new
non-empty string type, which is needed so that we don't...
Iustin Pop
04:58 pm Revision c66f09f5: Bulk add of remaining cluster/node opcodes
These are tested for equivalence with the Python code using existing
tests. These tests are not perfect - for many "T...
Iustin Pop
04:58 pm Revision 5ef4fbb1: Fix OpCode arbitrary generation w.r.t. non-ASCII chars
Since we generate arbitrary strings and then we send them over a pipe
to Python, we can (and will) generate non-ascii...
Iustin Pop
04:58 pm Revision 417ab39c: A few more hlint fixes
I'm ignoring the use of Control.Arrow.*** since it's a non-obvious
function, and we're not widely using Arrows in the...
Iustin Pop
04:58 pm Revision 2a8efa13: Add an arbitrary set generator helper
This makes it easy to generate sets of "things" that don't even need
to have arbitrary instances, but which have boun...
Iustin Pop
03:51 pm Revision edc1acde: Generalise the JSON "Container" type
Currently, we have some types that we kept as dictionaries in the
objects representation (due to inconsistent behavio...
Iustin Pop
03:51 pm Revision 48755fac: Move StorageType from RPC.hs to Types.hs
This fixes a FIXME actually recommending this move :)
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Gui...
Iustin Pop
03:51 pm Revision 22381768: Move the 'Hypervisor' type from Objects to Types
This is a very basic type and 'Objects' is a heavy-weight module. By
moving it to 'types' we simplify (in the future)...
Iustin Pop
03:51 pm Revision 1283cc38: Split 'Query.Language.ItemType' in two sub-types
The QR_VIA_OP/QR_VIA_LUXI types in Python are using yet another
validation mode: QR_VIA_OP is the base type, and QR_V...
Iustin Pop
03:51 pm Revision d696bbef: Add more basic Ganeti types
These are needed both in opcodes and (potentially) outside, so we add
them in the main Types module.
Signed-off-by: ...
Iustin Pop
03:43 pm Revision 405bffe2: Rename leftovers from remote to restricted commands
As per Iustin Pop's suggestion in <20121115131730.GX824@google.com> on
<ganeti-devel@googlegroups.com>.
Signed-off-b...
Michael Hanselmann
03:43 pm Revision 42bd26e8: backend: Rename RunRemoteCommand to RunRestrictedCmd
As per Iustin Pop's suggestion in <20121115131730.GX824@google.com> on
<ganeti-devel@googlegroups.com>.
Signed-off-b...
Michael Hanselmann
03:43 pm Revision 878c42ae: Rename constants and directory for restricted commands
As per Iustin Pop's suggestion in <20121115131730.GX824@google.com> on
<ganeti-devel@googlegroups.com>.
Signed-off-b...
Michael Hanselmann
03:43 pm Revision 1fdeb284: Rename configure option for restricted commands
It is no longer “--enable-remote-commands”, but rather
“--enable-restricted-commands”.
Signed-off-by: Michael Hansel...
Michael Hanselmann
03:43 pm Revision 6d846d0e: Add command line interface for running commands remotely
This patch adds a new command, “gnt-node restricted-command”. Since the
semantics are different from “gnt-cluster com...
Michael Hanselmann
03:40 pm Revision 74434d27: Remove delayed iallocator call in TLReplaceDisks
By setting the “delay_iallocator” parameter one could delay the call to
the instance allocator. This was not used for...
Michael Hanselmann
03:40 pm Revision de0417fa: cmdlib: Merge duplicated code for TLMigrateInstance
LUInstanceFailover and LUInstanceMigrate use TLMigrateInstance and had
the essentially same code for expanding names ...
Michael Hanselmann
12:53 pm Revision f3196d68: Fix lint error about too many variables
Lint complains about too many variables in the CheckPrereq
method. While I think that this method/class would need
so...
Helga Velroyen
11:21 am Revision 7309e7b6: Check ispecs against ipolicy on instance modify
When modifying an instance, so far the specs were not checked against
the ipolicy. This patch fixes this issue.
Note...
Helga Velroyen
08:37 am Revision 621b43ed: locking.LockSet: Replace boolean parameter with constants
Upcoming changes will add opportunistic locking to “locking.LockSet”.
Doing so will require additional code in “LockS...
Michael Hanselmann
08:23 am Revision bfbe8c51: RAPI: Clarify non-exhaustive nature of examples
The examples given in the RAPI documentation are not exhaustive. This
patch tries to clarify this by adding ellipses ...
Michael Hanselmann
08:23 am Revision 6252c0bd: Add tests for __repr__ in locking classes
“locking.PipeCondition” and “locking.SharedLock” define “__repr__”,
which until now was not tested at all.
Signed-of...
Michael Hanselmann
08:23 am Revision 8c114acd: test/*.py: s/'/"/
Now that 2.6 is essentially finished and 2.7 going to be branched
soon-ish, I thought it would be a good moment to re...
Michael Hanselmann
08:21 am Revision 5b34cc22: network: Style updates
- Quote characters
- Docstrings
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ul...
Michael Hanselmann
08:21 am Revision 0a09b080: Document requirement for ipaddr and bitarray modules
Also update configure.ac.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Guido Trotter <ultrotte...
Michael Hanselmann
08:21 am Revision a138ead7: ht: Complain if TNone isn't listed first for TOr/TAnd
Some type descriptions are rather long. If "None" is listed at the end
or somewhere in between it is easily missed. T...
Michael Hanselmann
08:21 am Revision 6ae72286: Add unit test for default parameter default values
Fails if the default value of an opcode parameter doesn't verify.
Signed-off-by: Michael Hanselmann <hansmi@google.c...
Michael Hanselmann
08:20 am Revision 32e3d8b1: opcodes: Network parameter improvements and fixes
- Use variables for checks for IP addresses (makes them more consistent,
too)
- Fix checks to accept default values...
Michael Hanselmann
08:18 am Revision 1f84cca8: Merge branch 'devel-2.6'
* devel-2.6:
Fix opcode validation for OpOobCommand.command
Fix typo in manpage for gnt-os
gnt-instance.8: Add ...
Michael Hanselmann
07:51 am Revision 6cbf6d9a: Merge branch 'stable-2.6' into devel-2.6
* stable-2.6:
Fix opcode validation for OpOobCommand.command
Fix typo in manpage for gnt-os
gnt-instance.8: Add...
Michael Hanselmann
03:44 am Revision a13d34a6: locking: Use frozenset instead of utils.UniqueSequence
In this case “frozenset” is good enough as the result's order doesn't
matter--it is the input to “sorted” (“utils.Uni...
Michael Hanselmann
03:44 am Revision 0ef4d576: locking: Add test for downgrade without names
Until now there was no test for calling “LockSet.downgrade” without
specifying any names.
Signed-off-by: Michael Han...
Michael Hanselmann
« Previous
Next »
 

Also available in: Atom