Activity
From 03/01/2013 to 03/30/2013
03/28/2013
- 03:13 pm Revision 9572482e: Correct typos in comments
- Correct four typos in the comments of the Drbd types file.
Signed-off-by: Michele Tartara <mtartara@google.com>
Revi... - 03:13 pm Revision 2d1c753d: Add status information to the DRBD data collector report
- Add status information as required by the design document.
Signed-off-by: Michele Tartara <mtartara@google.com>
Revi... - 03:13 pm Revision 8c5419ee: Export the data collected by DRBD in JSON format
- Write an intermediate function computing the JSON data before adding them
to the DCReport.
Directly export the data ... - 03:13 pm Revision 82437b28: Add DCStatus data type for the data collectors
- Also adds the DCStatusCode, part of DCStatus, and the addStatus
utility function for adding the "status" field to an ... - 03:13 pm Revision 54c7dff7: Add Kind data type for data collectors
- Also, add it to the DRBD data collector, and export it from there.
Signed-off-by: Michele Tartara <mtartara@google.c... - 03:13 pm Revision f0e4b2a4: Add data type for data collector category
- Also, update the DRBD data collector to use and export it.
Signed-off-by: Michele Tartara <mtartara@google.com>
Revi... - 03:13 pm Revision 834dc290: Export the dcVersionInformation for the Drbd collector
- Also, update the JSON output (and the design document) so that it is not
in camelcase anymore. This is part of a bigg... - 03:12 pm Revision a895fa19: Add data collector version data type
- Define the new data type and update the DRBD data collector to use it.
Signed-off-by: Michele Tartara <mtartara@goog... - 03:12 pm Revision 7a171e3f: Fix comment line position in DRBD data collector
- Signed-off-by: Michele Tartara <mtartara@google.com>
Reviewed-by: Bernardo Dal Seno <bdalseno@google.com> - 03:12 pm Revision ddceb4c5: Export dcName information of Drbd data collector
- Signed-off-by: Michele Tartara <mtartara@google.com>
Reviewed-by: Bernardo Dal Seno <bdalseno@google.com> - 03:11 pm Revision debfca88: Change format of the empty status message
- Having 'null' instead of an empty string for an empty status message
increases the complexity of the code with no rea... - 03:01 pm Revision 44b7a8a8: Improve INSTALL documentation
- Additional clarification note added.
Signed-off-by: Michele Tartara <mtartara@google.com>
Reviewed-by: Helga Velroye... - 02:03 pm Revision 958a800a: Document more installation dependencies
- A couple of them were missing and are added by this patch.
Signed-off-by: Michele Tartara <mtartara@google.com>
Revi...
03/27/2013
- 12:47 pm Revision 64760879: Unit tests for config.ConfigWriter.VerifyConfig()
- The test is aimed mostly at instance policies, which changed recently.
Signed-off-by: Bernardo Dal Seno <bdalseno@go... - 12:46 pm Revision 0b94cda8: cfgupgrade: Add support for newly refactored ipolicies
- Instance policies in the configuration are upgraded and downgraded. Both
operations are idempotent.
Signed-off-by: B... - 12:46 pm Revision da5f09ef: Refactor ispecs in ipolicy structures
- Minimum and maximum instance specs are put together into a single element
of the instance policy. This is in preparat... - 12:46 pm Revision 1709435e: cfgupgrade: Add --downgrade option
- It's now possible to go back to the previous stable version. Unit tests
provided.
This is mostly useful during devel... - 12:46 pm Revision bb553e5a: cfgupgrade: Refactor code
- All the upgrading code is now in one function. No functionality has been
changed.
Signed-off-by: Bernardo Dal Seno <... - 12:46 pm Revision 04db1880: Configuration is verified on load
- If there are errors in the configuration when master daemon is started,
they are now logged and reported. Previously ... - 12:45 pm Revision d948c101: Refactor cli.CreateIPolicyFromOpts()
- The code relative to instance specs has been moved into a different
function. This in preparation for further patches... - 12:45 pm Revision eeaa5f6c: Remove duplicate filling of instance policy
- Instance policy fields were manually filled in CreateIPolicyFromOpts() and
then filled again by the caller. Now they ... - 12:45 pm Revision a6fdce9e: Unit test for cli.CreateIPolicyFromOpts()
- Useful for subsequent patches.
Signed-off-by: Bernardo Dal Seno <bdalseno@google.com>
Reviewed-by: Helga Velroyen <h... - 12:45 pm Revision a6321765: Amend partitioned design doc for multiple ispecs
- There will be only one standard specification in instance policies.
Signed-off-by: Bernardo Dal Seno <bdalseno@googl... - 12:44 pm Revision e118deb1: QA: Fix assertion
- The assertion was always true because "all" was missing.
Signed-off-by: Bernardo Dal Seno <bdalseno@google.com>
Revi...
03/26/2013
- 07:10 pm Revision 681f4f7b: More info on using the RAPI
- Add some additional information about how to use/test the RAPI,
including how to specify authentication credentials.
... - 01:57 pm Revision 2cbcf95d: gnt-instance info uses a revised format
- The code is more modular and the output is YAML-compliant. QA updated to
take advantage of it.
Signed-off-by: Bernar... - 01:57 pm Revision 0e79564a: gnt-cluster info uses a revised format
- The code is more modular and the output is YAML-compliant.
Added function in QA that uses PyYAML to parse the comman... - 01:57 pm Revision 4d99964c: Generic function to print data for gnt-xxx info
- The function produces a human-readable output, which is also a valid YAML
file, from an intermediate data structure. ...
03/22/2013
- 05:06 pm Revision 61f8fda4: Fix bug in rlib2 unit tests
- The "queryargs" parameter of the __init__ function of rlib2 classes should
be a dictionary, as defined in the Resourc... - 05:01 pm Revision fb409531: Remove use of deprecated function
- cgi.parse_qs() is deprecated in python 2.6 and substituted by
urlparse.parse_qs().
This patch modifies the code to u... - 01:00 pm Revision 27263c47: gnt-cluster modify: limit storage type consistency check
- This fixes the currently broken Q&A. The consistency check
for storage types is now only run when the 'enabled_storag... - 09:46 am Revision 9c6f0b51: Check if instances use disk templates that get disabled
- When disk templates get disabled via 'gnt-cluster modify', so far
we did not check if any instances still use a disk ...
03/21/2013
- 06:13 pm Revision 6414296b: Fixing some mistakes in design doc for space reporting
- - Use entities as examples for storage types that are actually storage
types.
- Fix mixing up 'external_storage' and ... - 05:41 pm Revision 94309823: Use 'storage type' consistently in design doc
- To minimize the confusion between whether or not a storage type
is the same as a storage method, I updated the design... - 05:41 pm Revision c66d8987: Upgrade configuration wrt enabled storage types
- This implements an online update of the configuration for when a configuration
is loaded that does not yet contain th... - 05:41 pm Revision dacd8ba4: QA: Extend cluster QA wrt enabled storage types
- This extends the QA scripts to test the changes in 'gnt-cluster init',
'gnt-cluster info', and 'gnt-cluster modify' w... - 05:41 pm Revision c074a9e8: gnt-cluster init: add enabled_storage_types parameter
- This patch extends the 'gnt-cluster init' command to set the list
of enabled storage types on cluster creation.
Sign... - 05:41 pm Revision c270ee07: gnt-cluster modify: dis/enabling storage types
- This patch extends the 'gnt-cluster modify' command to manipulate the list
of enabled storage types. Note that this c... - 05:41 pm Revision 7b9ceea7: gnt-cluster info: show enabled storage types
- This extends the 'gnt-cluster info' command to list the storage types
that are enabled on the cluster. It also fixes ... - 05:40 pm Revision d0de443e: Add 'enabled_storage_types' to the cluster config
- This patch adds the cluster's new field 'enabled_storage_types'
to the configuration objects in python and haskell.
... - 05:40 pm Revision 33c730a2: Add constants for storage types to constants.py
- This patch adds the currently known and used storage methods to the
constants.py file. Note that storage types are di... - 01:26 pm Revision 011a19bf: Fix Mond man page
- Remove some erroneous formatting from the Mond man page.
Signed-off-by: Michele Tartara <mtartara@google.com>
Review... - 12:30 pm Revision 423b2dd5: Add monitoring HTTP API structure
- Add all the supported commands to the API.
The actual response is still to be implemented.
Signed-off-by: Michele Ta... - 12:29 pm Revision eb65c915: Add basic HTTP server functionalities to Mond
- Add a stub implementation of the Mond HTTP server to Mond using the Haskell
snap-server library.
Signed-off-by: Mich... - 12:29 pm Revision 2fa8f963: Update documentation for monitoring daemon
- This commit updates the installation instructions and the user guide.
Signed-off-by: Michele Tartara <mtartara@googl... - 12:13 pm Revision 05b6f4d8: Merge branch 'devel-2.7'
- * devel-2.7
cfgupgrade: Fix error messages
Update "FIXME" string in RAPI
rapi client: add target_node to migrat... - 10:49 am Revision 13cc7b84: Add the core of the monitoring daemon
- This commit adds the core infrastructure of the monitoring daemon,
and integrates it in the build and test systems.
...
03/20/2013
- 06:48 pm Revision fdb85e3d: cfgupgrade: Fix error messages
- Messages were inconsistent. You could get both an error and a message
saying that everything was fine.
Signed-off-by... - 01:49 pm Revision 09b7b6f2: Update "FIXME" string in RAPI
- We are not ready for this change yet. Let's push it to 2.8.
Signed-off-by: Michele Tartara <mtartara@google.com>
Rev... - 01:25 pm Revision cb44e3db: Typo 'repot' in Server.hs
- Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Iustin Pop <iustin@google.com> - 12:34 pm Revision 511e00b8: Fix typo 'VolumeN' in bdev.py
- Signed-off-by: Helga Velroyen <helgav@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
03/15/2013
- 03:41 pm Revision 6d2e1c12: Add design document for the "reason trail"
- This commit adds the design document for introducing "reason trails",
tracing the reason why opcodes are executed, st...
03/13/2013
- 02:23 pm Revision f511082f: Add Mond to the list of possible daemons
- Also, add its logfiles and extra log files.
Signed-off-by: Michele Tartara <mtartara@google.com>
Reviewed-by: Iustin... - 02:23 pm Revision a8828704: Add infrastructure for allowing additional logfiles
- Some daemons will need more than the single logfile that is currently
allowed. This patch introduces the infrastructu... - 12:49 pm Revision 14013e5d: Add user and group for the monitoring agent
- This commit adds the user and group variables for the monitoring agent in all
the configuration files where they are ...
03/12/2013
- 07:19 pm Revision dc700f75: rapi client: add target_node to migrate instance
- This allows migrating to any node, as it is already possible for
failover, when instances are externally mirrored.
S... - 06:52 pm Revision d8f0b7c1: Make diskless instances externally mirrored
- This addresses Issue 237.
Mirroring no disk is a no-op. As such we can treat them like mirrored
instances, since the... - 06:29 pm Revision 7b3d70d4: Fix migrate/failover -n for ext mirror storage
- This fixes issue 396.
- Fix a wrong comment that mentions drbd8 when actually the code acts
only on externally mir... - 06:16 pm Revision ab9e48d1: Enable split queries for the network
- Now that all fields are implemented, and (I think) behave equivalent
to the Python implementation, we can switch on t... - 06:16 pm Revision 63fb3de0: Add a simple tool for checking split-query equivalence
- This is not run automatically (although it could/should), but is very
useful during development.
Signed-off-by: Iust... - 06:16 pm Revision 7c17db26: Fix gnt-backup list -o node via confd
- Currently, the 'node' field is declared as a simple config field, so
when only selecting this fields, the runtime gat... - 06:16 pm Revision 40b118d3: Introduce better item getter helper in query.py
- And also use it for simple network fields. Currently the Python
library returns jsnull, which is formatted as 'None' ... - 06:16 pm Revision 60a67263: Fix network query field types/names in the Haskell code
- The headers/type/descriptions had some differences from the Python
code, when checked for exact equivalence.
Signed-... - 06:16 pm Revision c81b97f2: Make gnt-node list -o(p|s)inst_list output stable
- Currently, both the Python and Haskell code return the internal
instance list unsorted, which means the output can va... - 06:16 pm Revision ce906289: Sort instance list in gnt-group list -opinst_list
- The Python code currently sorts this, but the Haskell code not.
This should maybe have a test, but I'm not sure how ... - 06:16 pm Revision bac48afe: Add missing external_reservations query field in confd
- Based on the implemented Ip4Network/Address types, we can now compute
the (external) reservations.
Signed-off-by: Iu... - 06:16 pm Revision 87f1a454: A few style fixes in Ganeti.Network
- Side-effects of working on some other network-related stuff…
Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-... - 06:16 pm Revision 147fd319: Expand TestHelper to allow non-underscore prefixes
- HLint 1.8.28 requires us to always add "ignore CamelCase", which can
be problematic sometimes (e.g. when using Overlo... - 06:16 pm Revision b1b4a26b: Change to CamelCase format in Test/Ganeti/Objects.hs
- This is in preparation for using OverloadedString extensions in this
file, which conflicts with hlint 1.8.28's handli... - 06:16 pm Revision 3a991f2d: Add simple Ip4Address/Ip4Network types
- This patch adds some very simple IPv4 address/network types, and uses
them in the 'Network' config object.
We need t... - 06:16 pm Revision 82953e9a: Change node disk/hv_state query in confd
- Currently, the Python code returns either FS_UNAVAIL (if these
attributes are None) or the proper dicts. As we don't ... - 05:21 pm Revision 74df4a99: Update design doc about free space reporting
- This patch updates the design doc "Design correct reporting of storage
free space". The modifications were chosen to ... - 03:52 pm Revision ad658827: Fix QA: skip reinstall for diskless instances
- Diskless instances cannot really be reinstalled, not even through RAPI.
Signed-off-by: Bernardo Dal Seno <bdalseno@g... - 03:43 pm Revision 0e8d8384: Fix typo in the monitoring agent design doc
- Signed-off-by: Michele Tartara <mtartara@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com> - 01:32 pm Revision 46d21495: Merge branch 'devel-2.7'
- * devel-2.7
Add QA for instance creation with policy violation
Add QA for policy-instance interactions
Add QA f... - 12:44 pm Revision 2eef8750: Fix style error in hconfd
- The first line of a function should be blank, unless it is able to contain the
whole function.
Signed-off-by: Michel...
03/11/2013
- 08:57 pm Revision fa84c8a4: Add QA for instance creation with policy violation
- When instance policy is violated, creation fails.
Signed-off-by: Bernardo Dal Seno <bdalseno@google.com>
Reviewed-by... - 08:57 pm Revision ab4832d1: Add QA for policy-instance interactions
- Violations on policy changes are checked.
Signed-off-by: Bernardo Dal Seno <bdalseno@google.com>
Reviewed-by: Guido ... - 08:57 pm Revision b3f3aa3d: Add QA for cluster policies
- qa_cluster.TestClusterSetISpecs() is exported as it will be used in future
tests.
Signed-off-by: Bernardo Dal Seno <... - 08:57 pm Revision ba5c6c6b: Unit tests for objects.InstancePolicy + a fix
- Tests for:
objects.InstancePolicy.CheckParameterSyntax()
objects.InstancePolicy.CheckDiskTemplates()
objects.In... - 08:57 pm Revision e38bc4eb: Unit tests for objects.FillIPolicy() + small fix
- IPOLICY_DEFAULTS is now a legal policy (the disk-templates entry was a set
instead of a list, before).
Signed-off-by... - 08:57 pm Revision 4f7e5a1d: Fix upgrade of policy in objects.Cluster
- Unknown elements were silently removed on startup. This means that a
software upgrade could result in lost configurat... - 08:56 pm Revision 2477c1c5: Fix instance policy checks for default back-end parameters
- Policy violations of back-end parameters that used the cluster default
value were not reported in cluster-verify.
Si... - 08:56 pm Revision 6ea2bb8c: Fix restoring default instance specs in group policies
- "default" was not accepted as a valid input value for instance specs in
group policies, due to a bug introduced in 2c... - 08:56 pm Revision 5dd7d15b: Unit tests for cmdlib._GetUpdatedIPolicy()
- Not 100% coverage, though.
Signed-off-by: Bernardo Dal Seno <bdalseno@google.com>
Reviewed-by: Guido Trotter <ultrot... - 08:56 pm Revision cc4b2676: Fix policy check for disk templates
- Instance disk template is checked against the policy, and diskless
instances aren't checked for the number of disks.
... - 08:56 pm Revision 6a327093: Fix merge 8e09e801 that resulted in duplicated code
- A fragment in LUInstanceCreate.CheckPrereq() removed in commit ba147ff8 was
reintroduced in merge 8e09e801 due to a c... - 03:06 pm Revision 7db266bb: GanetiRapiClient: fix the no_remember option
- There was a typo which prevented the correct option from being passed to
RAPI
Signed-off-by: Daniel Krambrock <danie...
03/08/2013
- 05:46 pm Revision 4f73cfc9: Merge branch 'devel-2.7'
- * devel-2.7:
Change hbal behaviour in case of early exit
Fix build/sphinx_ext.py with tuple defaults for op param... - 02:50 pm Revision 2d6bdcc5: Change hbal behaviour in case of early exit
- Currently, hbal exits with status 1 if early exit is requested, even
when all jobs are successful. This is counter-in...
03/06/2013
- 05:31 pm Revision 777e8b6f: Fix "reason" opcode parameter description
- The "reason" opcode parameter can now apply to multiple opcodes, not just the
one for rebooting instances.
Signed-of... - 04:37 pm Revision c83c0410: Fix build/sphinx_ext.py with tuple defaults for op params
- When an OpCode's parameter has a tuple as default value, this code
will break:
buf.write("defaults to ``%s``" % de... - 04:37 pm Revision 67c15d8b: Fix bug in man build rule
- Currently the man page build rule is run without ‘-e’, so the actual
checks in there are just warnings (check-man-war... - 11:36 am Revision e61db4b2: Fix hscolour style sheet building
- Currently we only symlink this into two hard-coded directories, which
breaks the source code viewing for all the othe... - 11:16 am Revision 69c88fb1: Make "reason" a common opcode attribute
- The "reason" attribute will be common to many opcodes.
This patch factors it out so that it will be possible for the ...
03/05/2013
- 06:15 pm Revision 9b154e2b: Merge branch 'devel-2.7'
- * devel-2.7:
Update required pylint version
Constants.hs.in: improve Haddock markup in the template
convert-con... - 05:53 pm Revision 099e9213: Update required pylint version
- This should help a lot of users, since pylint 0.21.1 was quite an old
version…
The tree is "clean" w.r.t. the new py... - 05:53 pm Revision 1498270e: Constants.hs.in: improve Haddock markup in the template
- Signed-off-by: Iustin Pop <iustin@google.com>
Reviewed-by: Michele Tartara <mtartara@google.com> - 05:53 pm Revision 25d7b289: convert-constants: generate better Haddock markup
- Currently the Python source constants are used as-is, which is not
nice on the eyes (especially for unqualified names... - 05:53 pm Revision 7ddd8e4c: Expand Haddock to run over test files as well
- This patch does multiple enhancements to the way we build the Haddock
docs, motivated by the fact that if we don't ru... - 01:56 pm Revision 491d02ca: Merge branch 'devel-2.7'
- * devel-2.7: (23 commits)
Add export lists for files which didn't have them
Fix Haskell compatibility tests with ... - 11:03 am Revision c56dd17b: Switch LispConfig double comparison to relative error
- This further improves the comparison for "non-trivial"
numbers. Without this patch, there are still cases where the a...
03/04/2013
- 06:39 pm Revision 1fe0e999: Make the XmParser config test runtime more consistent
- Currently, the test uses a frequency of 5 string/5 double/1 list for
generating Arbitrary instances of ListConfig. Ho... - 06:39 pm Revision d58d44f3: Switch Attoparsec parser from double to rational
- According to the documentation, “This function is almost ten times
faster than rational, but is slightly less accurat... - 06:39 pm Revision a7e76dc3: Improve output of the XmParser config test
- Currently, this tests and its helper function 'isAlmostEqual' uses
plain booleans to signify failures, which means yo... - 06:10 pm Revision 91c1a265: Fix node partial name matching in Haskell code
- This implements QffHostname and fixes the node listing (as well as
export listing when filtering on node name).
This... - 06:09 pm Revision e7124835: Fix bug in group queries related to node/instance fields
- Since we use the primitive string type for group UUIDs, the group
fields have a bug where we pass the group name as f... - 06:09 pm Revision d5b2753a: Abstract the individual query functions
- After implementing a few of the query executor functions, it turns out
that we have the same general pattern:
- comp... - 06:08 pm Revision dce08ad3: Allow confd to serve network list-fields queries
- The fields are not yet complete, but at least we can enable the
list-field query to see what is there already.
Signe... - 06:08 pm Revision 36162faf: Rename/make uniform the other query entities
- Following the new naming style introduced in Exports.hs, this patch
renames the other resources to export non-qualifi... - 05:59 pm Revision dde85e1e: Add export lists for files which didn't have them
- Two test helper files didn't have export lists (lost during the split
of tests). This patch finally reintroduces them... - 05:18 pm Revision 3cbd5808: Fix Haskell compatibility tests with disabled file storage
- When file storage is disabled at ./configure time, we shouldn't pass
opcodes containing DTFile/DTSharedFile/StorageFi... - 05:18 pm Revision 3c87d614: Fix QA with disabled file storage
- Currently QA tries to use “gnt-node list-storage” with all storage
types, but when file storage is disabled this will... - 05:18 pm Revision 7b3cbe02: Fix convert-constants handling of booleans
- It turns out that, in Python, booleans are also integers. So they fall
under the “isinstance(value, int)” case, resul... - 05:18 pm Revision 1fbb19fa: Fix handling of disabled (shared) file storage
- The vcluster changes broke the disabling of file storage; we can
workaround by (manually) skipping the virtualisation... - 12:35 pm Revision b6322b3e: Fix LUTestAllocator with instance alloc
- This is similar to commit 8775e62a; the addition of node_whitelist
broke this LU as well.
Signed-off-by: Iustin Pop ... - 12:35 pm Revision bfa99f7a: Fix low verbosity levels in htools
- In a few cases, we tested the verbosity level for (== 0), instead of
higher/lower than a certain value. If the user p... - 12:35 pm Revision 36a566e8: Allow iallocator to work without LVM storage
- Currently, the iallocator interface requires LVM storage, due to the
way it computes the node storage information.
B... - 12:35 pm Revision 0e42ef67: Fix improperly formatted docstring
- Change the docstring of chompPrefix to prevent the error
"doc comment parse failed" that was raised by some version o... - 12:35 pm Revision 91c17910: Allow rpc.MakeLegacyNodeInfo to parse non-LVM results
- 'MakeLegacyNodeInfo' is not the best place for this, but we'd have to
duplicate it if we wanted a LVM-less version, s... - 12:35 pm Revision 64b0309a: Fix confd issue regarding --no-lvm-storage
- If cluster is initialized with --no-lvm-storage then volume_group_name
does not exist in config.data. Thus we must de...
03/01/2013
- 06:54 pm Revision ac84befd: Fix networks in _PrepareNicModifications()
- Passing --net 0:add,ip=5.5.5.5 failed due to a reference
of a non initialized variable (new_net_obj). Reorder the che...
Also available in: Atom