| Branch: | Tag: | Revision:

root @ 4331f6cd

# Date Author Comment
4331f6cd 11/21/2008 12:45 pm Michael Hanselmann

Reuse HTTP client pool for RPC

ganeti-masterd: Add initialization and shutdown of RPC pool. It needs
to be shutdown before forking.

ganeti.cli: Add decorator function to initialize and shutdown RPC pool.

ganeti.rpc: Add functions to initialize and shutdown RPC pool. Throw...

54d1a06e 11/21/2008 12:42 pm Michael Hanselmann

Write ssconf files when updating configuration

Reviewed-by: ultrotter

6ddc95ec 11/21/2008 12:42 pm Michael Hanselmann

Add RPC call to update ssconf files

Reviewed-by: iustinp

d418ebfb 11/21/2008 08:22 am Iustin Pop

Change replace secondary to work with multi-disk

Also fix an error in the CheckPrereq.

Reviewed-by: imsnah

0c223ea9 11/20/2008 02:50 pm Michael Hanselmann

ganeti.ssconf: Add function to write ssconf files

This function will be used to write ssconf files from the node daemon.
By creating a lock file, we synchronize different child processes of
ganeti-noded to not overwrite each other's changes. Also, external...

54155f52 11/20/2008 08:22 am Iustin Pop

Convert replace-disks (same nodes) to multi-disk

This patch changes the drbd8 replace disk only (no secondary change) to
work in with multi-disk. This mode of replaces works correctly with
replacing only a subset of disks.

Reviewed-by: imsnah

08db7c5c 11/20/2008 08:22 am Iustin Pop

Initial multi-disk/multi-nic support

This patch adds support for mult-disk/multi-nic in:
- instance add
- burnin

The start/stop/failover/cluster verify work as expected. Replace disk
and grow disk are TODO.

There's also a change gnt-job to allow dictionaries to be listed in...

41a776da 11/20/2008 08:19 am Iustin Pop

Add more disk/nic listing options in gnt-instance

This adds some more listing cases (useful for scripting/rapi):
- disk.sizes for a list of all sizes
- nic.(ips|macs|bridges)

Reviewed-by: imsnah

2864f2d9 11/20/2008 08:18 am Iustin Pop

Change Xen hypervisor to not use iv_name

Currently the iv_name is very linux-specific, and will break with the
multi-disk changes.

The patch changes this to generate sdX names based on the disk index in
the disks structure, instead of relying on the iv_name....

9a525d83 11/19/2008 03:18 pm Michael Hanselmann

ganeti.rpc: Use central functions for actual RPC calls

Before we had lots, lots and lots of code duplication. This patch
changes the code to use four central functions.

Reviewed-by: iustinp

33bbdbec 11/19/2008 03:18 pm Michael Hanselmann

Make HttpClientManager threadsafe

This allows a single HttpClientManager to be used from more than one
thread at the same time. We discussed having one HttpClientManager
per job queue thread. Assuming there should be one HTTP thread per
node, this would mean quadratic growth with the number of nodes. By...

7c46aafd 11/19/2008 02:59 pm Oleksiy Mishchenko

HTTP server: Do not decode empty entity body

Reviewed-by: imsnah

d50b3059 11/19/2008 01:09 pm Oleksiy Mishchenko

RAPI: Instance modify.

Split parameters filter to the separate function and reuse it in instance creation.

a143be68 11/18/2008 01:30 pm Iustin Pop

Skip another testWaitingXblocksY

The waiting sharer blocks exclusive is another not-possible to test
right now.

Sorry for missing it the first time; there are no other testWaiting...

Reviewed-by: ultrotter

71c1af58 11/18/2008 12:06 pm Iustin Pop

Allow querying of variable number of parameters

This patch adds support for querying in gnt-instance list of:
- disk.count
- nic.count
- disk.size/$N
- nic.(ip|mac|bridge)/$N

The patch also disables the exception raised when the header description...

31bf511f 11/18/2008 12:04 pm Iustin Pop

Convert to _FieldSet

This patch converts the current usage of _CheckOutputFields to the
FieldSet class, but it doesn't start to use its variable matching

Reviewed-by: ultrotter

6de7c41d 11/18/2008 12:00 pm Iustin Pop

Add a FieldSet class for variable parameter sets

This patch adds a _FieldSet class that can be used for the new variable
parameter sets: e.g. the sda_size will change to disk/0.size (or
similar) and we need to both check validity and extract the index of the...

e6416152 11/18/2008 11:58 am Iustin Pop

Skip the waitingExclusiveBlockSharer test

Until we have a way to properly test this, we'll skip the test.

Reviewed-by: imsnah

6c2d0b44 11/17/2008 01:30 pm Iustin Pop

More updates to the documentation

This patch removes the client-api.txt document (since it's obsoleted by
the documentation inside the design-2.0.rst document) and adds many
updates to the latter.

Reviewed-by: imsnah

b8195800 11/17/2008 01:30 pm Iustin Pop

Fix distcheck with the new dot/png rules

Adding a new filetype/make rule requires more work than the previous
patch. Sorry! Now pases distcheck.

Reviewed-by: imsnah

f86e82ef 11/16/2008 08:24 am Iustin Pop

Add a cluster architecture diagram

This adds a simple diagram for the cluster architecture and also adds a
dependency on graphviz (both doc and in configure).

Reviewed-by: imsnah

5c0c1eeb 11/16/2008 08:24 am Iustin Pop

Combine the 2.0 design documents into one

This patch combines all the design documents for 2.0 except the
security one into a single document, in order to ease reading and reduce
duplication of information.

Future patches will start removing wrong pointers to old document names...

0c55c24b 11/14/2008 06:59 pm Oleksiy Mishchenko

RAPI: Instance startup/shutdown resources

Reviewed-by: imsnah

2276aa29 11/14/2008 12:34 pm Oleksiy Mishchenko

RAPI: Implement an instance reboot

Reviewed-by: imsnah

8049a1d7 11/12/2008 02:52 pm Michael Hanselmann

Use utils.ReadFile to read SSL certificate

Reviewed-by: iustinp

4c7c81d7 11/12/2008 02:52 pm Michael Hanselmann

ganeti.rpc: Use utils.ReadFile instead of reading file directly

Reviewed-by: iustinp

6346a9e5 11/12/2008 02:51 pm Michael Hanselmann

utils.SetupLogging: Remove previously setup handlers

If a logging function is called before the logging module is setup
using utils.SetupLogging, it calls logging.basicConfig, which adds
a StreamHandler, on its own. If we leave it in, all log output will...

a3811745 11/12/2008 02:51 pm Michael Hanselmann

jqueue: Always use rpc.RpcRunner

"from ganeti.rpc import RpcRunner" does not conform to the style guide.

Reviewed-by: iustinp

fda5f19f 11/12/2008 02:51 pm Michael Hanselmann

bootstrap: Always use rpc.RpcRunner

"from ganeti.rpc import RpcRunner" does not conform to the style guide.

Reviewed-by: iustinp

7c28c575 11/12/2008 02:50 pm Michael Hanselmann

ganeti.rpc: Convert to ganeti.serializer

This is one of the last places where the simplejson module is
used directly.

Reviewed-by: iustinp

ecfe9491 11/12/2008 02:50 pm Michael Hanselmann

Convert RPC module to new HTTP client

Currently, HttpClientManager is instantiated for every RPC call. This
will be changed with another patch, as will the use of SSL. The “Run”
method is no longer needed.

Reviewed-by: iustinp

4607c978 11/12/2008 08:25 am Iustin Pop

Convert the locking unittests to repetition-test

Currently the locking tests are using timeouts to ensure an event will
'never happen'. However, this is suboptimal.

The patch converts all of these to instead: not wait, but sequence the
operations logically and expect that they execute as such. In case of...

e1bd0072 11/12/2008 05:43 am Iustin Pop

Fix utils.KillProcess

Rev 1978 introduced a breakage on the SIGKILL finall signal to the
process, due to mistyped variable.

Reviewed-by: francis.perron

438a366a 11/11/2008 06:16 pm Michael Hanselmann

ganeti.http: Implement SSL for HTTP client

Implementing SSL for the HTTP client required more work than I expected.
For correct error handling, quite a lot of code is needed. To avoid
code duplication, I moved a lot of the socket handling code into a
single function named _SocketOperation. It takes care of the polling...

b11c9e5c 11/11/2008 01:02 pm Michael Hanselmann

ganeti.daemon: Add timers to Mainloop

This is a fallout from my work on the HTTP client class. Repeating
timers are prepared, but not yet implemented.

Reviewed-by: iustinp

d868edb4 11/11/2008 12:58 pm Iustin Pop

Convert trunk to posix-compatibility

We change two functions to use RunCmd without shell, and the other
(which needs a ssh command line) is changed to the '>... 2>&1' syntax.

Reviewed-by: imsnah

8adbffaa 11/11/2008 12:58 pm Iustin Pop

Abstract runtime creation of dirs into a function

Currently the dir creation in ganeti-noded is in the main function. This
is not nice: we move it into a separate function and also add creation
of the OS_LOG_DIR (with different permissions, but in the same way)....

44bf25ff 11/11/2008 12:58 pm Iustin Pop

Remove zombie special case from IsProcessAlive

Based on the discussion on the mailing list, we remove the special
casing of zombie processes.

Note we don't use kill -0 since that has a different meaning than "check
process is alive", so this function is still linux-specific....

ff5251bc 11/11/2008 12:58 pm Iustin Pop

Add cleanup of processes to utils.KillProcess

In case the process we want to signal is our own process, and the signal
we send is a deadly one, we should also cleanup after the process.

This patch adds a new parameter waitpid to this function that does this,...

cb4e8387 11/11/2008 12:58 pm Iustin Pop

Fix instance rename

As can be seen from the patch, we remove from the locking manager However, we do this right after cfg.RenameInstance, which
changes to the new name. So we need to remove old_name not
the new name.

The real question is why does the glm allow me to remove a not-existing...

01f3e7b1 11/11/2008 12:57 pm Iustin Pop

Make the makefile not recreate ganeti every time

Currently the makefile always recreates the ganeti symlink. Make it so
that it does only when it doesn't exist or it's not a symlink.

Reviewed-by: imsnah

bb2ee932 11/11/2008 05:12 am Iustin Pop

Fix gnt-instance reinstall

Commit 1881 changed a rpc call but didn't fix all its users. This should
fix it (but I can't test as HTTP is broken).

Reviewed-by: imsnah

8797df43 11/11/2008 05:12 am Iustin Pop

Implement working directory for utils.RunCmd

In order to replace usage of the shell just for 'cd %s; ...' we need to
be able to specify the working directory for childs.

The patch also changes the default working directory (when not
specified) to "/", as opposed to the current dir; since the daemos run...

b14f759e 11/10/2008 02:38 pm Michael Hanselmann

ganeti.http: Move SSL socket creation into base class

The same code will be used by the HTTP client.

Reviewed-by: iustinp

b14b975f 11/10/2008 02:37 pm Michael Hanselmann

ganeti.daemon: Make Mainloop more flexible

While working on the HTTP client class, I wanted to use Mainloop
before deciding to use threads instead.

- Add docstrings
- Rename "quit" to "running", move it to a local variable
- Support adding and removing I/O listeners while running...

d7bace1b 11/10/2008 12:14 pm Michael Hanselmann

ganeti.http: Add constant for "Unexpected EOF"

This is an expected error message and will be used in two places.

Reviewed-by: iustinp

00dd8326 11/07/2008 01:32 pm Alexander Schreiber

Fix gnt-cluster init without cluster parameters

Reviewed-by: imsnah

8a0b06d2 11/06/2008 01:25 pm Michael Hanselmann

Add new HTTP client class

It is based on the WorkerPool class which is already used for the job
queue and master daemon. Each request must be encapsulated in an
instance of HttpClientRequest, which will then be passed to
HttpClientManager for processing. Upon completion, the request object...

64357ed8 11/06/2008 01:24 pm Michael Hanselmann

ganeti.http: Use 411 Length Required in server code

Reviewed-by: iustinp

cd4d138f 11/05/2008 06:37 pm Guido Trotter

Update LUGrowDisk _WaitForSync call

The _WaitForSync call changed in r1794 but the GrowDisk call wasn't updated
then. This makes GrowDisk work in trunk.

Reviewed-by: iustinp

8a9f9060 11/05/2008 04:04 pm Michael Hanselmann

ganeti.http: Add more constants

As a preparation for the new HTTP client class, add more constants
to ganeti.http.

Reviewed-by: iustinp

116db7c7 10/28/2008 01:21 am Iustin Pop

Small documentation updates for

Reviewed-by: imsnah

ea03467c 10/28/2008 01:21 am Iustin Pop

Documentation updates for

Reviewed-by: imsnah

63712a09 10/28/2008 01:20 am Iustin Pop

Yet another bug found while reviewing docs

The newer_than variable can be either None or an int, and we normalize
it to an integer previously and save it in the 'serial' variable, which
should be used instead.

Reviewed-by: imsnah

58885d79 10/28/2008 01:20 am Iustin Pop

Documentation updates for

Reviewed-by: imsnah

6099bfcf 10/28/2008 01:20 am Iustin Pop

Documentation updates for gnt-debug and gnt-os

Reviewed-by: imsnah

917b4e56 10/28/2008 01:19 am Iustin Pop

Documentation updates for gnt-job

Reviewed-by: imsnah

48de3413 10/28/2008 01:19 am Iustin Pop

Documentation updates for gnt-backup

Reviewed-by: imsnah

d70b3058 10/28/2008 01:19 am Iustin Pop

Change exit code of gnt-backup list

Currently gnt-backup list exits with the same error code even if can't
contact som nodes for backup information.

The patch changes it to return 1 instead in this case.

Reviewed-by: imsnah

ebf366ee 10/28/2008 01:18 am Iustin Pop

Documentation updates for gnt-node

The patch also adds a 'return 0' to a function that was missing it.

Reviewed-by: imsnah

469ee405 10/28/2008 01:18 am Iustin Pop

Documentation updates for gnt-cluster

Reviewed-by: imsnah

7232c04c 10/28/2008 01:18 am Iustin Pop

Documentation updates for gnt-instance

Reviewed-by: imsnah

10c2650b 10/25/2008 03:37 am Iustin Pop

Update docstrings

This patch converts all of to epydoc formatting.

Reviewed-by: imsnah

3f5bd234 10/25/2008 03:37 am Iustin Pop

Fix another error handling case

The return from this error path is a dict, but the actual return value
(on the non-error handling) is a list of dicts. Change accordingly.

Reviewed-by: imsnah

0a70a72a 10/24/2008 07:14 pm Iustin Pop

Fix an error handling case

Found while reviewing documentation.

Reviewed-by: ultrotter

2e3d1946 10/24/2008 06:23 pm Guido Trotter

OSFromDisk remove superfluous empty line

Reviewed-by: iustinp

ef79eb82 10/24/2008 06:23 pm Guido Trotter

design-2.0-os-interface: update import/export

In the end we ended up taking a slightly different approach for
import/export than the one discussed in the design doc, after
trying/talking about a few more alternatives. Document this in the

Reviewed-by: iustinp

b1206984 10/24/2008 05:44 pm Iustin Pop

Some documentation updates

This fixes a few doc issues and converts a few docstrings to epydoc.

Reviewed-by: imsnah

36117c2b 10/24/2008 05:43 pm Iustin Pop

Modify utils.RunCmd to write output to file

Currently we launch processes via the shell in a few places only to
redirect standard output and error to a log file ("&> $file"). It is
better to do such redirection from within RunCmd itself.

This patch splits RunCmd in two parts, the setup and the execution part,...

f2a6fc9e 10/24/2008 02:49 pm Michael Hanselmann

ganeti.http: Implement SSL certificates

Reviewed-by: killerfoxi

23e46494 10/24/2008 02:31 pm Michael Hanselmann

Document HttpServer.__init__

At the same time, simplify the interface a bit by not using a tuple.

Reviewed-by: killerfoxi, ultrotter

18fb5e1d 10/23/2008 07:41 pm Alexander Schreiber

Update gnt-cluster man page, sections modify and queue.

Document the new options for gnt-cluster modify and the new queue

Reviewed-by: imsnah

19ae0895 10/23/2008 06:13 pm Alexander Schreiber

Update gnt-cluster man page with current options.

This patch updates the gnt-cluster man page to reflect the current
changes to gnt-cluster.

Reviewed-by: imsnah

1f9611b1 10/23/2008 06:01 pm Alexander Schreiber

Fix use of ToStderr in gnt-cluster

Reviewed-by: imsnah

d8353c3a 10/23/2008 05:19 pm Iustin Pop

Fix gnt-* command with --submit

Currently we don't catch the JobSubmittedException (although the code to
format it nicely is there). The patch adds the exception name to the
catch list and makes --submit work.

Reviewed-by: imsnah

74c47259 10/23/2008 05:19 pm Iustin Pop

Export the disk index in the import/export scripts

We want to export the disk index as some OSes will only want to export
the first disk (or the second one, etc.), even if we have multiple

The patch also updates the backend.ExportSnapshot docstring....

64272529 10/23/2008 05:18 pm Iustin Pop

Fix leftover of hypervisor attribute rename

Reviewed-by: imsnah

66348f29 10/23/2008 02:58 pm Alexander Schreiber

convert remaining print statements to ToStderr in gnt-cluster

Reviewed-by: imsnah

6526ddcd 10/23/2008 02:58 pm Michael Hanselmann

http library: Always fork before reading request

It turned out that clients not sending a full request will stop
us from responding to further requests. This patch leverages the
situation a bit by always forking before handling the request,
but we still have DoS situations....

54cf6599 10/23/2008 02:58 pm Michael Hanselmann Don't wake up every second

We don't have timers yet, hence waking up is not needed at all.

Reviewed-by: ultrotter

1a05d855 10/23/2008 01:41 am Oleksiy Mishchenko

RAPI: Export beparams as dict. The patch also enables LUQueryInstances to accept beparams as valid field.

Reviewed-by: iustinp

212fa3a7 10/22/2008 11:54 pm Oleksiy Mishchenko

RAPI: Forgoten in r1923 instance add change.

Reviewed-by: iustinp

09acf207 10/22/2008 05:09 pm Guido Trotter

LUCreateInstance: import multiple disks

Previously we used to handle only one disk. Now we'll import all the
ones present in the export, in order, on the instance's disks. Any disk
which was present on the original instance but wasn't exported is just
skipped in the target instance....

6c0af70e 10/22/2008 05:09 pm Guido Trotter

Convert ImportOSIntoInstance to OS API 10

- Change ImportOSIntoInstance not to get any "os_disk" and "swap_disk"
arguments but to accept multiple target images to import, and to
return a list of booleans with the result of each import
- Change the relevant rpc call and the only caller to conform...

0607699d 10/22/2008 05:09 pm Guido Trotter

Convert ExportSnapshot to OS API 10

We pass the data via the environment rather than on the command line, as
API 10 says. All the rest remains the same, and we export just one disk,
as the master calls this function for every snapshotted disk.

Reviewed-by: iustinp

19d7f90a 10/22/2008 05:08 pm Guido Trotter

LUExportInstance: snapshot all disks

Rather than just snapshotting the "sda" disk, we'll snapshot all of the
instance disks. If we can't snapshot a disk for any reason we'll log an
error and proceed anyway: in this case the resulting export will miss a
disk. This also changes all the warning messages to self.LogWarning()....

e9e9263d 10/22/2008 05:08 pm Guido Trotter

Convert SnapshotBlockDevice's docstring to epydoc

Reviewed-by: iustinp

7a8f64da 10/21/2008 11:32 pm Oleksiy Mishchenko

Pass request headers in to RAPI handlers.

Reviewed-by: iustinp

86d9d3bb 10/21/2008 08:54 pm Iustin Pop

Move some LU logging to use proc.Log*

We change some messages which are obviously intended for the user to use
the proc.Log* functions instead of (only) the logging ones.

We also fix some wrong uses of feedback_fn.

Reviewed-by: imsnah

c0088fb9 10/21/2008 06:45 pm Iustin Pop

Improve the mcpu.Processor logging routines

As discussed previously, many of the routinges in are using
logging functions as a carry-over from 1.2 (when these also showed the
message on stderr/to the user), instead of actually warning the user....

16653425 10/21/2008 04:02 pm Iustin Pop

Fix whitespace-at-EOL

Please configure your editors to strip it, or enable your git hooks...

Reviewed-by: ultrotter

149a5439 10/20/2008 09:01 pm Iustin Pop

Generalize the reading of test file data

Currently we have two methods in of computing
the test data file name - and, of course, they don't give the same

The patch moves the functions to compute the test file name and reading...

02691904 10/20/2008 07:38 pm Alexander Schreiber

Set default hypervisor at cluster init

During cluster init, set the default hypervisor to be used for instances.
Ensure that the default hypervisor belongs to the set enabled hypervisors
for this cluster. Also fix a small bug with setting the default enabled...

99aabbed 10/20/2008 05:47 pm Iustin Pop

Convert the job queue rpcs to address-based

The two main multi-node job queue RPC calls (jobqueue_update,
jobqueue_rename) are converted to address-based calls, in order to speed
up queue changes. For this, we need to change the _nodes attribute on
the jobqueue to be a dict {name: ip}, instead of a set....

6b294c53 10/20/2008 05:47 pm Iustin Pop

Convert rpc.call_upload_file to use addresses

This patch allows rpc.call_upload_file to use addresses (if passed), and
also converts the ConfigWriter._DistributeConfig to pass them, since
this is an often-done operation.

Reviewed-by: imsnah

25348212 10/20/2008 05:47 pm Iustin Pop

Convert non-static rpc calls to use addresses

This patch converts all non-staticmethods rpc calls to pass addresses to
the Client calls.

This is done via two new small helpers. These functions also deal with
nodes that are not (yet) in the configuration file, and pass None for...

bdf7d8c0 10/20/2008 05:46 pm Iustin Pop

Add infrastructure for using addresses in

The patch adds support for passing node addresses to NodeController
objects, which should speed up the connect sequence.

The patch also adds another very small optimization of computing the
content-length header value in the parent Client class instead of each...

3ef3c771 10/20/2008 05:46 pm Iustin Pop

Improve conformance with the style guide for

This patch renames some internal function to camel case, for compliance
with the style guide.

It also fixes the module docstring (how old was that?).

Reviewed-by: imsnah

6fde8221 10/20/2008 04:44 pm Guido Trotter

Use constants.VALUE_AUTO for ip comparison too

Forward-port-of: r1889, Reviewed-by: imsnah

Reviewed-by: imsnah

8cd7cb4c 10/20/2008 04:44 pm Guido Trotter

Document mac option for gnt-backup import

Forward-port-of: (r1888, r1891), Reviewed-by: (iustinp, imsnah)

Reviewed-by: imsnah