Statistics
| Branch: | Tag: | Revision:

root / test / ganeti.locking_unittest.py @ 8d7d8b57

History | View | Annotate | Download (78.8 kB)

1
#!/usr/bin/python
2
#
3

    
4
# Copyright (C) 2006, 2007, 2010 Google Inc.
5
#
6
# This program is free software; you can redistribute it and/or modify
7
# it under the terms of the GNU General Public License as published by
8
# the Free Software Foundation; either version 2 of the License, or
9
# (at your option) any later version.
10
#
11
# This program is distributed in the hope that it will be useful, but
12
# WITHOUT ANY WARRANTY; without even the implied warranty of
13
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
14
# General Public License for more details.
15
#
16
# You should have received a copy of the GNU General Public License
17
# along with this program; if not, write to the Free Software
18
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
19
# 02110-1301, USA.
20

    
21

    
22
"""Script for unittesting the locking module"""
23

    
24

    
25
import os
26
import unittest
27
import time
28
import Queue
29
import threading
30
import random
31
import gc
32
import itertools
33

    
34
from ganeti import constants
35
from ganeti import locking
36
from ganeti import errors
37
from ganeti import utils
38
from ganeti import compat
39
from ganeti import objects
40
from ganeti import query
41

    
42
import testutils
43

    
44

    
45
# This is used to test the ssynchronize decorator.
46
# Since it's passed as input to a decorator it must be declared as a global.
47
_decoratorlock = locking.SharedLock("decorator lock")
48

    
49
#: List for looping tests
50
ITERATIONS = range(8)
51

    
52

    
53
def _Repeat(fn):
54
  """Decorator for executing a function many times"""
55
  def wrapper(*args, **kwargs):
56
    for i in ITERATIONS:
57
      fn(*args, **kwargs)
58
  return wrapper
59

    
60

    
61
def SafeSleep(duration):
62
  start = time.time()
63
  while True:
64
    delay = start + duration - time.time()
65
    if delay <= 0.0:
66
      break
67
    time.sleep(delay)
68

    
69

    
70
class _ThreadedTestCase(unittest.TestCase):
71
  """Test class that supports adding/waiting on threads"""
72
  def setUp(self):
73
    unittest.TestCase.setUp(self)
74
    self.done = Queue.Queue(0)
75
    self.threads = []
76

    
77
  def _addThread(self, *args, **kwargs):
78
    """Create and remember a new thread"""
79
    t = threading.Thread(*args, **kwargs)
80
    self.threads.append(t)
81
    t.start()
82
    return t
83

    
84
  def _waitThreads(self):
85
    """Wait for all our threads to finish"""
86
    for t in self.threads:
87
      t.join(60)
88
      self.failIf(t.isAlive())
89
    self.threads = []
90

    
91

    
92
class _ConditionTestCase(_ThreadedTestCase):
93
  """Common test case for conditions"""
94

    
95
  def setUp(self, cls):
96
    _ThreadedTestCase.setUp(self)
97
    self.lock = threading.Lock()
98
    self.cond = cls(self.lock)
99

    
100
  def _testAcquireRelease(self):
101
    self.assertFalse(self.cond._is_owned())
102
    self.assertRaises(RuntimeError, self.cond.wait, None)
103
    self.assertRaises(RuntimeError, self.cond.notifyAll)
104

    
105
    self.cond.acquire()
106
    self.assert_(self.cond._is_owned())
107
    self.cond.notifyAll()
108
    self.assert_(self.cond._is_owned())
109
    self.cond.release()
110

    
111
    self.assertFalse(self.cond._is_owned())
112
    self.assertRaises(RuntimeError, self.cond.wait, None)
113
    self.assertRaises(RuntimeError, self.cond.notifyAll)
114

    
115
  def _testNotification(self):
116
    def _NotifyAll():
117
      self.done.put("NE")
118
      self.cond.acquire()
119
      self.done.put("NA")
120
      self.cond.notifyAll()
121
      self.done.put("NN")
122
      self.cond.release()
123

    
124
    self.cond.acquire()
125
    self._addThread(target=_NotifyAll)
126
    self.assertEqual(self.done.get(True, 1), "NE")
127
    self.assertRaises(Queue.Empty, self.done.get_nowait)
128
    self.cond.wait(None)
129
    self.assertEqual(self.done.get(True, 1), "NA")
130
    self.assertEqual(self.done.get(True, 1), "NN")
131
    self.assert_(self.cond._is_owned())
132
    self.cond.release()
133
    self.assertFalse(self.cond._is_owned())
134

    
135

    
136
class TestSingleNotifyPipeCondition(_ConditionTestCase):
137
  """SingleNotifyPipeCondition tests"""
138

    
139
  def setUp(self):
140
    _ConditionTestCase.setUp(self, locking.SingleNotifyPipeCondition)
141

    
142
  def testAcquireRelease(self):
143
    self._testAcquireRelease()
144

    
145
  def testNotification(self):
146
    self._testNotification()
147

    
148
  def testWaitReuse(self):
149
    self.cond.acquire()
150
    self.cond.wait(0)
151
    self.cond.wait(0.1)
152
    self.cond.release()
153

    
154
  def testNoNotifyReuse(self):
155
    self.cond.acquire()
156
    self.cond.notifyAll()
157
    self.assertRaises(RuntimeError, self.cond.wait, None)
158
    self.assertRaises(RuntimeError, self.cond.notifyAll)
159
    self.cond.release()
160

    
161

    
162
class TestPipeCondition(_ConditionTestCase):
163
  """PipeCondition tests"""
164

    
165
  def setUp(self):
166
    _ConditionTestCase.setUp(self, locking.PipeCondition)
167

    
168
  def testAcquireRelease(self):
169
    self._testAcquireRelease()
170

    
171
  def testNotification(self):
172
    self._testNotification()
173

    
174
  def _TestWait(self, fn):
175
    threads = [
176
      self._addThread(target=fn),
177
      self._addThread(target=fn),
178
      self._addThread(target=fn),
179
      ]
180

    
181
    # Wait for threads to be waiting
182
    for _ in threads:
183
      self.assertEqual(self.done.get(True, 1), "A")
184

    
185
    self.assertRaises(Queue.Empty, self.done.get_nowait)
186

    
187
    self.cond.acquire()
188
    self.assertEqual(len(self.cond._waiters), 3)
189
    self.assertEqual(self.cond._waiters, set(threads))
190
    # This new thread can't acquire the lock, and thus call wait, before we
191
    # release it
192
    self._addThread(target=fn)
193
    self.cond.notifyAll()
194
    self.assertRaises(Queue.Empty, self.done.get_nowait)
195
    self.cond.release()
196

    
197
    # We should now get 3 W and 1 A (for the new thread) in whatever order
198
    w = 0
199
    a = 0
200
    for i in range(4):
201
      got = self.done.get(True, 1)
202
      if got == "W":
203
        w += 1
204
      elif got == "A":
205
        a += 1
206
      else:
207
        self.fail("Got %s on the done queue" % got)
208

    
209
    self.assertEqual(w, 3)
210
    self.assertEqual(a, 1)
211

    
212
    self.cond.acquire()
213
    self.cond.notifyAll()
214
    self.cond.release()
215
    self._waitThreads()
216
    self.assertEqual(self.done.get_nowait(), "W")
217
    self.assertRaises(Queue.Empty, self.done.get_nowait)
218

    
219
  def testBlockingWait(self):
220
    def _BlockingWait():
221
      self.cond.acquire()
222
      self.done.put("A")
223
      self.cond.wait(None)
224
      self.cond.release()
225
      self.done.put("W")
226

    
227
    self._TestWait(_BlockingWait)
228

    
229
  def testLongTimeoutWait(self):
230
    def _Helper():
231
      self.cond.acquire()
232
      self.done.put("A")
233
      self.cond.wait(15.0)
234
      self.cond.release()
235
      self.done.put("W")
236

    
237
    self._TestWait(_Helper)
238

    
239
  def _TimeoutWait(self, timeout, check):
240
    self.cond.acquire()
241
    self.cond.wait(timeout)
242
    self.cond.release()
243
    self.done.put(check)
244

    
245
  def testShortTimeoutWait(self):
246
    self._addThread(target=self._TimeoutWait, args=(0.1, "T1"))
247
    self._addThread(target=self._TimeoutWait, args=(0.1, "T1"))
248
    self._waitThreads()
249
    self.assertEqual(self.done.get_nowait(), "T1")
250
    self.assertEqual(self.done.get_nowait(), "T1")
251
    self.assertRaises(Queue.Empty, self.done.get_nowait)
252

    
253
  def testZeroTimeoutWait(self):
254
    self._addThread(target=self._TimeoutWait, args=(0, "T0"))
255
    self._addThread(target=self._TimeoutWait, args=(0, "T0"))
256
    self._addThread(target=self._TimeoutWait, args=(0, "T0"))
257
    self._waitThreads()
258
    self.assertEqual(self.done.get_nowait(), "T0")
259
    self.assertEqual(self.done.get_nowait(), "T0")
260
    self.assertEqual(self.done.get_nowait(), "T0")
261
    self.assertRaises(Queue.Empty, self.done.get_nowait)
262

    
263

    
264
class TestSharedLock(_ThreadedTestCase):
265
  """SharedLock tests"""
266

    
267
  def setUp(self):
268
    _ThreadedTestCase.setUp(self)
269
    self.sl = locking.SharedLock("TestSharedLock")
270

    
271
  def testSequenceAndOwnership(self):
272
    self.assertFalse(self.sl._is_owned())
273
    self.sl.acquire(shared=1)
274
    self.assert_(self.sl._is_owned())
275
    self.assert_(self.sl._is_owned(shared=1))
276
    self.assertFalse(self.sl._is_owned(shared=0))
277
    self.sl.release()
278
    self.assertFalse(self.sl._is_owned())
279
    self.sl.acquire()
280
    self.assert_(self.sl._is_owned())
281
    self.assertFalse(self.sl._is_owned(shared=1))
282
    self.assert_(self.sl._is_owned(shared=0))
283
    self.sl.release()
284
    self.assertFalse(self.sl._is_owned())
285
    self.sl.acquire(shared=1)
286
    self.assert_(self.sl._is_owned())
287
    self.assert_(self.sl._is_owned(shared=1))
288
    self.assertFalse(self.sl._is_owned(shared=0))
289
    self.sl.release()
290
    self.assertFalse(self.sl._is_owned())
291

    
292
  def testBooleanValue(self):
293
    # semaphores are supposed to return a true value on a successful acquire
294
    self.assert_(self.sl.acquire(shared=1))
295
    self.sl.release()
296
    self.assert_(self.sl.acquire())
297
    self.sl.release()
298

    
299
  def testDoubleLockingStoE(self):
300
    self.sl.acquire(shared=1)
301
    self.assertRaises(AssertionError, self.sl.acquire)
302

    
303
  def testDoubleLockingEtoS(self):
304
    self.sl.acquire()
305
    self.assertRaises(AssertionError, self.sl.acquire, shared=1)
306

    
307
  def testDoubleLockingStoS(self):
308
    self.sl.acquire(shared=1)
309
    self.assertRaises(AssertionError, self.sl.acquire, shared=1)
310

    
311
  def testDoubleLockingEtoE(self):
312
    self.sl.acquire()
313
    self.assertRaises(AssertionError, self.sl.acquire)
314

    
315
  # helper functions: called in a separate thread they acquire the lock, send
316
  # their identifier on the done queue, then release it.
317
  def _doItSharer(self):
318
    try:
319
      self.sl.acquire(shared=1)
320
      self.done.put('SHR')
321
      self.sl.release()
322
    except errors.LockError:
323
      self.done.put('ERR')
324

    
325
  def _doItExclusive(self):
326
    try:
327
      self.sl.acquire()
328
      self.done.put('EXC')
329
      self.sl.release()
330
    except errors.LockError:
331
      self.done.put('ERR')
332

    
333
  def _doItDelete(self):
334
    try:
335
      self.sl.delete()
336
      self.done.put('DEL')
337
    except errors.LockError:
338
      self.done.put('ERR')
339

    
340
  def testSharersCanCoexist(self):
341
    self.sl.acquire(shared=1)
342
    threading.Thread(target=self._doItSharer).start()
343
    self.assert_(self.done.get(True, 1))
344
    self.sl.release()
345

    
346
  @_Repeat
347
  def testExclusiveBlocksExclusive(self):
348
    self.sl.acquire()
349
    self._addThread(target=self._doItExclusive)
350
    self.assertRaises(Queue.Empty, self.done.get_nowait)
351
    self.sl.release()
352
    self._waitThreads()
353
    self.failUnlessEqual(self.done.get_nowait(), 'EXC')
354

    
355
  @_Repeat
356
  def testExclusiveBlocksDelete(self):
357
    self.sl.acquire()
358
    self._addThread(target=self._doItDelete)
359
    self.assertRaises(Queue.Empty, self.done.get_nowait)
360
    self.sl.release()
361
    self._waitThreads()
362
    self.failUnlessEqual(self.done.get_nowait(), 'DEL')
363
    self.sl = locking.SharedLock(self.sl.name)
364

    
365
  @_Repeat
366
  def testExclusiveBlocksSharer(self):
367
    self.sl.acquire()
368
    self._addThread(target=self._doItSharer)
369
    self.assertRaises(Queue.Empty, self.done.get_nowait)
370
    self.sl.release()
371
    self._waitThreads()
372
    self.failUnlessEqual(self.done.get_nowait(), 'SHR')
373

    
374
  @_Repeat
375
  def testSharerBlocksExclusive(self):
376
    self.sl.acquire(shared=1)
377
    self._addThread(target=self._doItExclusive)
378
    self.assertRaises(Queue.Empty, self.done.get_nowait)
379
    self.sl.release()
380
    self._waitThreads()
381
    self.failUnlessEqual(self.done.get_nowait(), 'EXC')
382

    
383
  @_Repeat
384
  def testSharerBlocksDelete(self):
385
    self.sl.acquire(shared=1)
386
    self._addThread(target=self._doItDelete)
387
    self.assertRaises(Queue.Empty, self.done.get_nowait)
388
    self.sl.release()
389
    self._waitThreads()
390
    self.failUnlessEqual(self.done.get_nowait(), 'DEL')
391
    self.sl = locking.SharedLock(self.sl.name)
392

    
393
  @_Repeat
394
  def testWaitingExclusiveBlocksSharer(self):
395
    """SKIPPED testWaitingExclusiveBlockSharer"""
396
    return
397

    
398
    self.sl.acquire(shared=1)
399
    # the lock is acquired in shared mode...
400
    self._addThread(target=self._doItExclusive)
401
    # ...but now an exclusive is waiting...
402
    self._addThread(target=self._doItSharer)
403
    # ...so the sharer should be blocked as well
404
    self.assertRaises(Queue.Empty, self.done.get_nowait)
405
    self.sl.release()
406
    self._waitThreads()
407
    # The exclusive passed before
408
    self.failUnlessEqual(self.done.get_nowait(), 'EXC')
409
    self.failUnlessEqual(self.done.get_nowait(), 'SHR')
410

    
411
  @_Repeat
412
  def testWaitingSharerBlocksExclusive(self):
413
    """SKIPPED testWaitingSharerBlocksExclusive"""
414
    return
415

    
416
    self.sl.acquire()
417
    # the lock is acquired in exclusive mode...
418
    self._addThread(target=self._doItSharer)
419
    # ...but now a sharer is waiting...
420
    self._addThread(target=self._doItExclusive)
421
    # ...the exclusive is waiting too...
422
    self.assertRaises(Queue.Empty, self.done.get_nowait)
423
    self.sl.release()
424
    self._waitThreads()
425
    # The sharer passed before
426
    self.assertEqual(self.done.get_nowait(), 'SHR')
427
    self.assertEqual(self.done.get_nowait(), 'EXC')
428

    
429
  def testDelete(self):
430
    self.sl.delete()
431
    self.assertRaises(errors.LockError, self.sl.acquire)
432
    self.assertRaises(errors.LockError, self.sl.acquire, shared=1)
433
    self.assertRaises(errors.LockError, self.sl.delete)
434

    
435
  def testDeleteTimeout(self):
436
    self.assertTrue(self.sl.delete(timeout=60))
437

    
438
  def testDeleteTimeoutFail(self):
439
    ready = threading.Event()
440
    finish = threading.Event()
441

    
442
    def fn():
443
      self.sl.acquire(shared=0)
444
      ready.set()
445

    
446
      finish.wait()
447
      self.sl.release()
448

    
449
    self._addThread(target=fn)
450
    ready.wait()
451

    
452
    # Test if deleting a lock owned in exclusive mode by another thread fails
453
    # to delete when a timeout is used
454
    self.assertFalse(self.sl.delete(timeout=0.02))
455

    
456
    finish.set()
457
    self._waitThreads()
458

    
459
    self.assertTrue(self.sl.delete())
460
    self.assertRaises(errors.LockError, self.sl.acquire)
461

    
462
  def testNoDeleteIfSharer(self):
463
    self.sl.acquire(shared=1)
464
    self.assertRaises(AssertionError, self.sl.delete)
465

    
466
  @_Repeat
467
  def testDeletePendingSharersExclusiveDelete(self):
468
    self.sl.acquire()
469
    self._addThread(target=self._doItSharer)
470
    self._addThread(target=self._doItSharer)
471
    self._addThread(target=self._doItExclusive)
472
    self._addThread(target=self._doItDelete)
473
    self.sl.delete()
474
    self._waitThreads()
475
    # The threads who were pending return ERR
476
    for _ in range(4):
477
      self.assertEqual(self.done.get_nowait(), 'ERR')
478
    self.sl = locking.SharedLock(self.sl.name)
479

    
480
  @_Repeat
481
  def testDeletePendingDeleteExclusiveSharers(self):
482
    self.sl.acquire()
483
    self._addThread(target=self._doItDelete)
484
    self._addThread(target=self._doItExclusive)
485
    self._addThread(target=self._doItSharer)
486
    self._addThread(target=self._doItSharer)
487
    self.sl.delete()
488
    self._waitThreads()
489
    # The two threads who were pending return both ERR
490
    self.assertEqual(self.done.get_nowait(), 'ERR')
491
    self.assertEqual(self.done.get_nowait(), 'ERR')
492
    self.assertEqual(self.done.get_nowait(), 'ERR')
493
    self.assertEqual(self.done.get_nowait(), 'ERR')
494
    self.sl = locking.SharedLock(self.sl.name)
495

    
496
  @_Repeat
497
  def testExclusiveAcquireTimeout(self):
498
    for shared in [0, 1]:
499
      on_queue = threading.Event()
500
      release_exclusive = threading.Event()
501

    
502
      def _LockExclusive():
503
        self.sl.acquire(shared=0, test_notify=on_queue.set)
504
        self.done.put("A: start wait")
505
        release_exclusive.wait()
506
        self.done.put("A: end wait")
507
        self.sl.release()
508

    
509
      # Start thread to hold lock in exclusive mode
510
      self._addThread(target=_LockExclusive)
511

    
512
      # Wait for wait to begin
513
      self.assertEqual(self.done.get(timeout=60), "A: start wait")
514

    
515
      # Wait up to 60s to get lock, but release exclusive lock as soon as we're
516
      # on the queue
517
      self.failUnless(self.sl.acquire(shared=shared, timeout=60,
518
                                      test_notify=release_exclusive.set))
519

    
520
      self.done.put("got 2nd")
521
      self.sl.release()
522

    
523
      self._waitThreads()
524

    
525
      self.assertEqual(self.done.get_nowait(), "A: end wait")
526
      self.assertEqual(self.done.get_nowait(), "got 2nd")
527
      self.assertRaises(Queue.Empty, self.done.get_nowait)
528

    
529
  @_Repeat
530
  def testAcquireExpiringTimeout(self):
531
    def _AcquireWithTimeout(shared, timeout):
532
      if not self.sl.acquire(shared=shared, timeout=timeout):
533
        self.done.put("timeout")
534

    
535
    for shared in [0, 1]:
536
      # Lock exclusively
537
      self.sl.acquire()
538

    
539
      # Start shared acquires with timeout between 0 and 20 ms
540
      for i in range(11):
541
        self._addThread(target=_AcquireWithTimeout,
542
                        args=(shared, i * 2.0 / 1000.0))
543

    
544
      # Wait for threads to finish (makes sure the acquire timeout expires
545
      # before releasing the lock)
546
      self._waitThreads()
547

    
548
      # Release lock
549
      self.sl.release()
550

    
551
      for _ in range(11):
552
        self.assertEqual(self.done.get_nowait(), "timeout")
553

    
554
      self.assertRaises(Queue.Empty, self.done.get_nowait)
555

    
556
  @_Repeat
557
  def testSharedSkipExclusiveAcquires(self):
558
    # Tests whether shared acquires jump in front of exclusive acquires in the
559
    # queue.
560

    
561
    def _Acquire(shared, name, notify_ev, wait_ev):
562
      if notify_ev:
563
        notify_fn = notify_ev.set
564
      else:
565
        notify_fn = None
566

    
567
      if wait_ev:
568
        wait_ev.wait()
569

    
570
      if not self.sl.acquire(shared=shared, test_notify=notify_fn):
571
        return
572

    
573
      self.done.put(name)
574
      self.sl.release()
575

    
576
    # Get exclusive lock while we fill the queue
577
    self.sl.acquire()
578

    
579
    shrcnt1 = 5
580
    shrcnt2 = 7
581
    shrcnt3 = 9
582
    shrcnt4 = 2
583

    
584
    # Add acquires using threading.Event for synchronization. They'll be
585
    # acquired exactly in the order defined in this list.
586
    acquires = (shrcnt1 * [(1, "shared 1")] +
587
                3 * [(0, "exclusive 1")] +
588
                shrcnt2 * [(1, "shared 2")] +
589
                shrcnt3 * [(1, "shared 3")] +
590
                shrcnt4 * [(1, "shared 4")] +
591
                3 * [(0, "exclusive 2")])
592

    
593
    ev_cur = None
594
    ev_prev = None
595

    
596
    for args in acquires:
597
      ev_cur = threading.Event()
598
      self._addThread(target=_Acquire, args=args + (ev_cur, ev_prev))
599
      ev_prev = ev_cur
600

    
601
    # Wait for last acquire to start
602
    ev_prev.wait()
603

    
604
    # Expect 6 pending exclusive acquires and 1 for all shared acquires
605
    # together
606
    self.assertEqual(self.sl._count_pending(), 7)
607

    
608
    # Release exclusive lock and wait
609
    self.sl.release()
610

    
611
    self._waitThreads()
612

    
613
    # Check sequence
614
    for _ in range(shrcnt1 + shrcnt2 + shrcnt3 + shrcnt4):
615
      # Shared locks aren't guaranteed to be notified in order, but they'll be
616
      # first
617
      tmp = self.done.get_nowait()
618
      if tmp == "shared 1":
619
        shrcnt1 -= 1
620
      elif tmp == "shared 2":
621
        shrcnt2 -= 1
622
      elif tmp == "shared 3":
623
        shrcnt3 -= 1
624
      elif tmp == "shared 4":
625
        shrcnt4 -= 1
626
    self.assertEqual(shrcnt1, 0)
627
    self.assertEqual(shrcnt2, 0)
628
    self.assertEqual(shrcnt3, 0)
629
    self.assertEqual(shrcnt3, 0)
630

    
631
    for _ in range(3):
632
      self.assertEqual(self.done.get_nowait(), "exclusive 1")
633

    
634
    for _ in range(3):
635
      self.assertEqual(self.done.get_nowait(), "exclusive 2")
636

    
637
    self.assertRaises(Queue.Empty, self.done.get_nowait)
638

    
639
  def testIllegalDowngrade(self):
640
    # Not yet acquired
641
    self.assertRaises(AssertionError, self.sl.downgrade)
642

    
643
    # Acquire in shared mode, downgrade should be no-op
644
    self.assertTrue(self.sl.acquire(shared=1))
645
    self.assertTrue(self.sl._is_owned(shared=1))
646
    self.assertTrue(self.sl.downgrade())
647
    self.assertTrue(self.sl._is_owned(shared=1))
648
    self.sl.release()
649

    
650
  def testDowngrade(self):
651
    self.assertTrue(self.sl.acquire())
652
    self.assertTrue(self.sl._is_owned(shared=0))
653
    self.assertTrue(self.sl.downgrade())
654
    self.assertTrue(self.sl._is_owned(shared=1))
655
    self.sl.release()
656

    
657
  @_Repeat
658
  def testDowngradeJumpsAheadOfExclusive(self):
659
    def _KeepExclusive(ev_got, ev_downgrade, ev_release):
660
      self.assertTrue(self.sl.acquire())
661
      self.assertTrue(self.sl._is_owned(shared=0))
662
      ev_got.set()
663
      ev_downgrade.wait()
664
      self.assertTrue(self.sl._is_owned(shared=0))
665
      self.assertTrue(self.sl.downgrade())
666
      self.assertTrue(self.sl._is_owned(shared=1))
667
      ev_release.wait()
668
      self.assertTrue(self.sl._is_owned(shared=1))
669
      self.sl.release()
670

    
671
    def _KeepExclusive2(ev_started, ev_release):
672
      self.assertTrue(self.sl.acquire(test_notify=ev_started.set))
673
      self.assertTrue(self.sl._is_owned(shared=0))
674
      ev_release.wait()
675
      self.assertTrue(self.sl._is_owned(shared=0))
676
      self.sl.release()
677

    
678
    def _KeepShared(ev_started, ev_got, ev_release):
679
      self.assertTrue(self.sl.acquire(shared=1, test_notify=ev_started.set))
680
      self.assertTrue(self.sl._is_owned(shared=1))
681
      ev_got.set()
682
      ev_release.wait()
683
      self.assertTrue(self.sl._is_owned(shared=1))
684
      self.sl.release()
685

    
686
    # Acquire lock in exclusive mode
687
    ev_got_excl1 = threading.Event()
688
    ev_downgrade_excl1 = threading.Event()
689
    ev_release_excl1 = threading.Event()
690
    th_excl1 = self._addThread(target=_KeepExclusive,
691
                               args=(ev_got_excl1, ev_downgrade_excl1,
692
                                     ev_release_excl1))
693
    ev_got_excl1.wait()
694

    
695
    # Start a second exclusive acquire
696
    ev_started_excl2 = threading.Event()
697
    ev_release_excl2 = threading.Event()
698
    th_excl2 = self._addThread(target=_KeepExclusive2,
699
                               args=(ev_started_excl2, ev_release_excl2))
700
    ev_started_excl2.wait()
701

    
702
    # Start shared acquires, will jump ahead of second exclusive acquire when
703
    # first exclusive acquire downgrades
704
    ev_shared = [(threading.Event(), threading.Event()) for _ in range(5)]
705
    ev_release_shared = threading.Event()
706

    
707
    th_shared = [self._addThread(target=_KeepShared,
708
                                 args=(ev_started, ev_got, ev_release_shared))
709
                 for (ev_started, ev_got) in ev_shared]
710

    
711
    # Wait for all shared acquires to start
712
    for (ev, _) in ev_shared:
713
      ev.wait()
714

    
715
    # Check lock information
716
    self.assertEqual(self.sl.GetLockInfo(set([query.LQ_MODE, query.LQ_OWNER])),
717
                     [(self.sl.name, "exclusive", [th_excl1.getName()], None)])
718
    [(_, _, _, pending), ] = self.sl.GetLockInfo(set([query.LQ_PENDING]))
719
    self.assertEqual([(pendmode, sorted(waiting))
720
                      for (pendmode, waiting) in pending],
721
                     [("exclusive", [th_excl2.getName()]),
722
                      ("shared", sorted(th.getName() for th in th_shared))])
723

    
724
    # Shared acquires won't start until the exclusive lock is downgraded
725
    ev_downgrade_excl1.set()
726

    
727
    # Wait for all shared acquires to be successful
728
    for (_, ev) in ev_shared:
729
      ev.wait()
730

    
731
    # Check lock information again
732
    self.assertEqual(self.sl.GetLockInfo(set([query.LQ_MODE,
733
                                              query.LQ_PENDING])),
734
                     [(self.sl.name, "shared", None,
735
                       [("exclusive", [th_excl2.getName()])])])
736
    [(_, _, owner, _), ] = self.sl.GetLockInfo(set([query.LQ_OWNER]))
737
    self.assertEqual(set(owner), set([th_excl1.getName()] +
738
                                     [th.getName() for th in th_shared]))
739

    
740
    ev_release_excl1.set()
741
    ev_release_excl2.set()
742
    ev_release_shared.set()
743

    
744
    self._waitThreads()
745

    
746
    self.assertEqual(self.sl.GetLockInfo(set([query.LQ_MODE, query.LQ_OWNER,
747
                                              query.LQ_PENDING])),
748
                     [(self.sl.name, None, None, [])])
749

    
750
  @_Repeat
751
  def testMixedAcquireTimeout(self):
752
    sync = threading.Event()
753

    
754
    def _AcquireShared(ev):
755
      if not self.sl.acquire(shared=1, timeout=None):
756
        return
757

    
758
      self.done.put("shared")
759

    
760
      # Notify main thread
761
      ev.set()
762

    
763
      # Wait for notification from main thread
764
      sync.wait()
765

    
766
      # Release lock
767
      self.sl.release()
768

    
769
    acquires = []
770
    for _ in range(3):
771
      ev = threading.Event()
772
      self._addThread(target=_AcquireShared, args=(ev, ))
773
      acquires.append(ev)
774

    
775
    # Wait for all acquires to finish
776
    for i in acquires:
777
      i.wait()
778

    
779
    self.assertEqual(self.sl._count_pending(), 0)
780

    
781
    # Try to get exclusive lock
782
    self.failIf(self.sl.acquire(shared=0, timeout=0.02))
783

    
784
    # Acquire exclusive without timeout
785
    exclsync = threading.Event()
786
    exclev = threading.Event()
787

    
788
    def _AcquireExclusive():
789
      if not self.sl.acquire(shared=0):
790
        return
791

    
792
      self.done.put("exclusive")
793

    
794
      # Notify main thread
795
      exclev.set()
796

    
797
      # Wait for notification from main thread
798
      exclsync.wait()
799

    
800
      self.sl.release()
801

    
802
    self._addThread(target=_AcquireExclusive)
803

    
804
    # Try to get exclusive lock
805
    self.failIf(self.sl.acquire(shared=0, timeout=0.02))
806

    
807
    # Make all shared holders release their locks
808
    sync.set()
809

    
810
    # Wait for exclusive acquire to succeed
811
    exclev.wait()
812

    
813
    self.assertEqual(self.sl._count_pending(), 0)
814

    
815
    # Try to get exclusive lock
816
    self.failIf(self.sl.acquire(shared=0, timeout=0.02))
817

    
818
    def _AcquireSharedSimple():
819
      if self.sl.acquire(shared=1, timeout=None):
820
        self.done.put("shared2")
821
        self.sl.release()
822

    
823
    for _ in range(10):
824
      self._addThread(target=_AcquireSharedSimple)
825

    
826
    # Tell exclusive lock to release
827
    exclsync.set()
828

    
829
    # Wait for everything to finish
830
    self._waitThreads()
831

    
832
    self.assertEqual(self.sl._count_pending(), 0)
833

    
834
    # Check sequence
835
    for _ in range(3):
836
      self.assertEqual(self.done.get_nowait(), "shared")
837

    
838
    self.assertEqual(self.done.get_nowait(), "exclusive")
839

    
840
    for _ in range(10):
841
      self.assertEqual(self.done.get_nowait(), "shared2")
842

    
843
    self.assertRaises(Queue.Empty, self.done.get_nowait)
844

    
845
  def testPriority(self):
846
    # Acquire in exclusive mode
847
    self.assert_(self.sl.acquire(shared=0))
848

    
849
    # Queue acquires
850
    def _Acquire(prev, next, shared, priority, result):
851
      prev.wait()
852
      self.sl.acquire(shared=shared, priority=priority, test_notify=next.set)
853
      try:
854
        self.done.put(result)
855
      finally:
856
        self.sl.release()
857

    
858
    counter = itertools.count(0)
859
    priorities = range(-20, 30)
860
    first = threading.Event()
861
    prev = first
862

    
863
    # Data structure:
864
    # {
865
    #   priority:
866
    #     [(shared/exclusive, set(acquire names), set(pending threads)),
867
    #      (shared/exclusive, ...),
868
    #      ...,
869
    #     ],
870
    # }
871
    perprio = {}
872

    
873
    # References shared acquire per priority in L{perprio}. Data structure:
874
    # {
875
    #   priority: (shared=1, set(acquire names), set(pending threads)),
876
    # }
877
    prioshared = {}
878

    
879
    for seed in [4979, 9523, 14902, 32440]:
880
      # Use a deterministic random generator
881
      rnd = random.Random(seed)
882
      for priority in [rnd.choice(priorities) for _ in range(30)]:
883
        modes = [0, 1]
884
        rnd.shuffle(modes)
885
        for shared in modes:
886
          # Unique name
887
          acqname = "%s/shr=%s/prio=%s" % (counter.next(), shared, priority)
888

    
889
          ev = threading.Event()
890
          thread = self._addThread(target=_Acquire,
891
                                   args=(prev, ev, shared, priority, acqname))
892
          prev = ev
893

    
894
          # Record expected aqcuire, see above for structure
895
          data = (shared, set([acqname]), set([thread]))
896
          priolist = perprio.setdefault(priority, [])
897
          if shared:
898
            priosh = prioshared.get(priority, None)
899
            if priosh:
900
              # Shared acquires are merged
901
              for i, j in zip(priosh[1:], data[1:]):
902
                i.update(j)
903
              assert data[0] == priosh[0]
904
            else:
905
              prioshared[priority] = data
906
              priolist.append(data)
907
          else:
908
            priolist.append(data)
909

    
910
    # Start all acquires and wait for them
911
    first.set()
912
    prev.wait()
913

    
914
    # Check lock information
915
    self.assertEqual(self.sl.GetLockInfo(set()),
916
                     [(self.sl.name, None, None, None)])
917
    self.assertEqual(self.sl.GetLockInfo(set([query.LQ_MODE, query.LQ_OWNER])),
918
                     [(self.sl.name, "exclusive",
919
                       [threading.currentThread().getName()], None)])
920

    
921
    self._VerifyPrioPending(self.sl.GetLockInfo(set([query.LQ_PENDING])),
922
                            perprio)
923

    
924
    # Let threads acquire the lock
925
    self.sl.release()
926

    
927
    # Wait for everything to finish
928
    self._waitThreads()
929

    
930
    self.assert_(self.sl._check_empty())
931

    
932
    # Check acquires by priority
933
    for acquires in [perprio[i] for i in sorted(perprio.keys())]:
934
      for (_, names, _) in acquires:
935
        # For shared acquires, the set will contain 1..n entries. For exclusive
936
        # acquires only one.
937
        while names:
938
          names.remove(self.done.get_nowait())
939
      self.assertFalse(compat.any(names for (_, names, _) in acquires))
940

    
941
    self.assertRaises(Queue.Empty, self.done.get_nowait)
942

    
943
  def _VerifyPrioPending(self, ((name, mode, owner, pending), ), perprio):
944
    self.assertEqual(name, self.sl.name)
945
    self.assert_(mode is None)
946
    self.assert_(owner is None)
947

    
948
    self.assertEqual([(pendmode, sorted(waiting))
949
                      for (pendmode, waiting) in pending],
950
                     [(["exclusive", "shared"][int(bool(shared))],
951
                       sorted(t.getName() for t in threads))
952
                      for acquires in [perprio[i]
953
                                       for i in sorted(perprio.keys())]
954
                      for (shared, _, threads) in acquires])
955

    
956
  class _FakeTimeForSpuriousNotifications:
957
    def __init__(self, now, check_end):
958
      self.now = now
959
      self.check_end = check_end
960

    
961
      # Deterministic random number generator
962
      self.rnd = random.Random(15086)
963

    
964
    def time(self):
965
      # Advance time if the random number generator thinks so (this is to test
966
      # multiple notifications without advancing the time)
967
      if self.rnd.random() < 0.3:
968
        self.now += self.rnd.random()
969

    
970
      self.check_end(self.now)
971

    
972
      return self.now
973

    
974
  @_Repeat
975
  def testAcquireTimeoutWithSpuriousNotifications(self):
976
    ready = threading.Event()
977
    locked = threading.Event()
978
    req = Queue.Queue(0)
979

    
980
    epoch = 4000.0
981
    timeout = 60.0
982

    
983
    def check_end(now):
984
      self.assertFalse(locked.isSet())
985

    
986
      # If we waited long enough (in virtual time), tell main thread to release
987
      # lock, otherwise tell it to notify once more
988
      req.put(now < (epoch + (timeout * 0.8)))
989

    
990
    time_fn = self._FakeTimeForSpuriousNotifications(epoch, check_end).time
991

    
992
    sl = locking.SharedLock("test", _time_fn=time_fn)
993

    
994
    # Acquire in exclusive mode
995
    sl.acquire(shared=0)
996

    
997
    def fn():
998
      self.assertTrue(sl.acquire(shared=0, timeout=timeout,
999
                                 test_notify=ready.set))
1000
      locked.set()
1001
      sl.release()
1002
      self.done.put("success")
1003

    
1004
    # Start acquire with timeout and wait for it to be ready
1005
    self._addThread(target=fn)
1006
    ready.wait()
1007

    
1008
    # The separate thread is now waiting to acquire the lock, so start sending
1009
    # spurious notifications.
1010

    
1011
    # Wait for separate thread to ask for another notification
1012
    count = 0
1013
    while req.get():
1014
      # After sending the notification, the lock will take a short amount of
1015
      # time to notice and to retrieve the current time
1016
      sl._notify_topmost()
1017
      count += 1
1018

    
1019
    self.assertTrue(count > 100, "Not enough notifications were sent")
1020

    
1021
    self.assertFalse(locked.isSet())
1022

    
1023
    # Some notifications have been sent, now actually release the lock
1024
    sl.release()
1025

    
1026
    # Wait for lock to be acquired
1027
    locked.wait()
1028

    
1029
    self._waitThreads()
1030

    
1031
    self.assertEqual(self.done.get_nowait(), "success")
1032
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1033

    
1034

    
1035
class TestSharedLockInCondition(_ThreadedTestCase):
1036
  """SharedLock as a condition lock tests"""
1037

    
1038
  def setUp(self):
1039
    _ThreadedTestCase.setUp(self)
1040
    self.sl = locking.SharedLock("TestSharedLockInCondition")
1041
    self.setCondition()
1042

    
1043
  def setCondition(self):
1044
    self.cond = threading.Condition(self.sl)
1045

    
1046
  def testKeepMode(self):
1047
    self.cond.acquire(shared=1)
1048
    self.assert_(self.sl._is_owned(shared=1))
1049
    self.cond.wait(0)
1050
    self.assert_(self.sl._is_owned(shared=1))
1051
    self.cond.release()
1052
    self.cond.acquire(shared=0)
1053
    self.assert_(self.sl._is_owned(shared=0))
1054
    self.cond.wait(0)
1055
    self.assert_(self.sl._is_owned(shared=0))
1056
    self.cond.release()
1057

    
1058

    
1059
class TestSharedLockInPipeCondition(TestSharedLockInCondition):
1060
  """SharedLock as a pipe condition lock tests"""
1061

    
1062
  def setCondition(self):
1063
    self.cond = locking.PipeCondition(self.sl)
1064

    
1065

    
1066
class TestSSynchronizedDecorator(_ThreadedTestCase):
1067
  """Shared Lock Synchronized decorator test"""
1068

    
1069
  def setUp(self):
1070
    _ThreadedTestCase.setUp(self)
1071

    
1072
  @locking.ssynchronized(_decoratorlock)
1073
  def _doItExclusive(self):
1074
    self.assert_(_decoratorlock._is_owned())
1075
    self.done.put('EXC')
1076

    
1077
  @locking.ssynchronized(_decoratorlock, shared=1)
1078
  def _doItSharer(self):
1079
    self.assert_(_decoratorlock._is_owned(shared=1))
1080
    self.done.put('SHR')
1081

    
1082
  def testDecoratedFunctions(self):
1083
    self._doItExclusive()
1084
    self.assertFalse(_decoratorlock._is_owned())
1085
    self._doItSharer()
1086
    self.assertFalse(_decoratorlock._is_owned())
1087

    
1088
  def testSharersCanCoexist(self):
1089
    _decoratorlock.acquire(shared=1)
1090
    threading.Thread(target=self._doItSharer).start()
1091
    self.assert_(self.done.get(True, 1))
1092
    _decoratorlock.release()
1093

    
1094
  @_Repeat
1095
  def testExclusiveBlocksExclusive(self):
1096
    _decoratorlock.acquire()
1097
    self._addThread(target=self._doItExclusive)
1098
    # give it a bit of time to check that it's not actually doing anything
1099
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1100
    _decoratorlock.release()
1101
    self._waitThreads()
1102
    self.failUnlessEqual(self.done.get_nowait(), 'EXC')
1103

    
1104
  @_Repeat
1105
  def testExclusiveBlocksSharer(self):
1106
    _decoratorlock.acquire()
1107
    self._addThread(target=self._doItSharer)
1108
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1109
    _decoratorlock.release()
1110
    self._waitThreads()
1111
    self.failUnlessEqual(self.done.get_nowait(), 'SHR')
1112

    
1113
  @_Repeat
1114
  def testSharerBlocksExclusive(self):
1115
    _decoratorlock.acquire(shared=1)
1116
    self._addThread(target=self._doItExclusive)
1117
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1118
    _decoratorlock.release()
1119
    self._waitThreads()
1120
    self.failUnlessEqual(self.done.get_nowait(), 'EXC')
1121

    
1122

    
1123
class TestLockSet(_ThreadedTestCase):
1124
  """LockSet tests"""
1125

    
1126
  def setUp(self):
1127
    _ThreadedTestCase.setUp(self)
1128
    self._setUpLS()
1129

    
1130
  def _setUpLS(self):
1131
    """Helper to (re)initialize the lock set"""
1132
    self.resources = ['one', 'two', 'three']
1133
    self.ls = locking.LockSet(self.resources, "TestLockSet")
1134

    
1135
  def testResources(self):
1136
    self.assertEquals(self.ls._names(), set(self.resources))
1137
    newls = locking.LockSet([], "TestLockSet.testResources")
1138
    self.assertEquals(newls._names(), set())
1139

    
1140
  def testAcquireRelease(self):
1141
    self.assert_(self.ls.acquire('one'))
1142
    self.assertEquals(self.ls._list_owned(), set(['one']))
1143
    self.ls.release()
1144
    self.assertEquals(self.ls._list_owned(), set())
1145
    self.assertEquals(self.ls.acquire(['one']), set(['one']))
1146
    self.assertEquals(self.ls._list_owned(), set(['one']))
1147
    self.ls.release()
1148
    self.assertEquals(self.ls._list_owned(), set())
1149
    self.ls.acquire(['one', 'two', 'three'])
1150
    self.assertEquals(self.ls._list_owned(), set(['one', 'two', 'three']))
1151
    self.ls.release('one')
1152
    self.assertEquals(self.ls._list_owned(), set(['two', 'three']))
1153
    self.ls.release(['three'])
1154
    self.assertEquals(self.ls._list_owned(), set(['two']))
1155
    self.ls.release()
1156
    self.assertEquals(self.ls._list_owned(), set())
1157
    self.assertEquals(self.ls.acquire(['one', 'three']), set(['one', 'three']))
1158
    self.assertEquals(self.ls._list_owned(), set(['one', 'three']))
1159
    self.ls.release()
1160
    self.assertEquals(self.ls._list_owned(), set())
1161

    
1162
  def testNoDoubleAcquire(self):
1163
    self.ls.acquire('one')
1164
    self.assertRaises(AssertionError, self.ls.acquire, 'one')
1165
    self.assertRaises(AssertionError, self.ls.acquire, ['two'])
1166
    self.assertRaises(AssertionError, self.ls.acquire, ['two', 'three'])
1167
    self.ls.release()
1168
    self.ls.acquire(['one', 'three'])
1169
    self.ls.release('one')
1170
    self.assertRaises(AssertionError, self.ls.acquire, ['two'])
1171
    self.ls.release('three')
1172

    
1173
  def testNoWrongRelease(self):
1174
    self.assertRaises(AssertionError, self.ls.release)
1175
    self.ls.acquire('one')
1176
    self.assertRaises(AssertionError, self.ls.release, 'two')
1177

    
1178
  def testAddRemove(self):
1179
    self.ls.add('four')
1180
    self.assertEquals(self.ls._list_owned(), set())
1181
    self.assert_('four' in self.ls._names())
1182
    self.ls.add(['five', 'six', 'seven'], acquired=1)
1183
    self.assert_('five' in self.ls._names())
1184
    self.assert_('six' in self.ls._names())
1185
    self.assert_('seven' in self.ls._names())
1186
    self.assertEquals(self.ls._list_owned(), set(['five', 'six', 'seven']))
1187
    self.assertEquals(self.ls.remove(['five', 'six']), ['five', 'six'])
1188
    self.assert_('five' not in self.ls._names())
1189
    self.assert_('six' not in self.ls._names())
1190
    self.assertEquals(self.ls._list_owned(), set(['seven']))
1191
    self.assertRaises(AssertionError, self.ls.add, 'eight', acquired=1)
1192
    self.ls.remove('seven')
1193
    self.assert_('seven' not in self.ls._names())
1194
    self.assertEquals(self.ls._list_owned(), set([]))
1195
    self.ls.acquire(None, shared=1)
1196
    self.assertRaises(AssertionError, self.ls.add, 'eight')
1197
    self.ls.release()
1198
    self.ls.acquire(None)
1199
    self.ls.add('eight', acquired=1)
1200
    self.assert_('eight' in self.ls._names())
1201
    self.assert_('eight' in self.ls._list_owned())
1202
    self.ls.add('nine')
1203
    self.assert_('nine' in self.ls._names())
1204
    self.assert_('nine' not in self.ls._list_owned())
1205
    self.ls.release()
1206
    self.ls.remove(['two'])
1207
    self.assert_('two' not in self.ls._names())
1208
    self.ls.acquire('three')
1209
    self.assertEquals(self.ls.remove(['three']), ['three'])
1210
    self.assert_('three' not in self.ls._names())
1211
    self.assertEquals(self.ls.remove('three'), [])
1212
    self.assertEquals(self.ls.remove(['one', 'three', 'six']), ['one'])
1213
    self.assert_('one' not in self.ls._names())
1214

    
1215
  def testRemoveNonBlocking(self):
1216
    self.ls.acquire('one')
1217
    self.assertEquals(self.ls.remove('one'), ['one'])
1218
    self.ls.acquire(['two', 'three'])
1219
    self.assertEquals(self.ls.remove(['two', 'three']),
1220
                      ['two', 'three'])
1221

    
1222
  def testNoDoubleAdd(self):
1223
    self.assertRaises(errors.LockError, self.ls.add, 'two')
1224
    self.ls.add('four')
1225
    self.assertRaises(errors.LockError, self.ls.add, 'four')
1226

    
1227
  def testNoWrongRemoves(self):
1228
    self.ls.acquire(['one', 'three'], shared=1)
1229
    # Cannot remove 'two' while holding something which is not a superset
1230
    self.assertRaises(AssertionError, self.ls.remove, 'two')
1231
    # Cannot remove 'three' as we are sharing it
1232
    self.assertRaises(AssertionError, self.ls.remove, 'three')
1233

    
1234
  def testAcquireSetLock(self):
1235
    # acquire the set-lock exclusively
1236
    self.assertEquals(self.ls.acquire(None), set(['one', 'two', 'three']))
1237
    self.assertEquals(self.ls._list_owned(), set(['one', 'two', 'three']))
1238
    self.assertEquals(self.ls._is_owned(), True)
1239
    self.assertEquals(self.ls._names(), set(['one', 'two', 'three']))
1240
    # I can still add/remove elements...
1241
    self.assertEquals(self.ls.remove(['two', 'three']), ['two', 'three'])
1242
    self.assert_(self.ls.add('six'))
1243
    self.ls.release()
1244
    # share the set-lock
1245
    self.assertEquals(self.ls.acquire(None, shared=1), set(['one', 'six']))
1246
    # adding new elements is not possible
1247
    self.assertRaises(AssertionError, self.ls.add, 'five')
1248
    self.ls.release()
1249

    
1250
  def testAcquireWithRepetitions(self):
1251
    self.assertEquals(self.ls.acquire(['two', 'two', 'three'], shared=1),
1252
                      set(['two', 'two', 'three']))
1253
    self.ls.release(['two', 'two'])
1254
    self.assertEquals(self.ls._list_owned(), set(['three']))
1255

    
1256
  def testEmptyAcquire(self):
1257
    # Acquire an empty list of locks...
1258
    self.assertEquals(self.ls.acquire([]), set())
1259
    self.assertEquals(self.ls._list_owned(), set())
1260
    # New locks can still be addded
1261
    self.assert_(self.ls.add('six'))
1262
    # "re-acquiring" is not an issue, since we had really acquired nothing
1263
    self.assertEquals(self.ls.acquire([], shared=1), set())
1264
    self.assertEquals(self.ls._list_owned(), set())
1265
    # We haven't really acquired anything, so we cannot release
1266
    self.assertRaises(AssertionError, self.ls.release)
1267

    
1268
  def _doLockSet(self, names, shared):
1269
    try:
1270
      self.ls.acquire(names, shared=shared)
1271
      self.done.put('DONE')
1272
      self.ls.release()
1273
    except errors.LockError:
1274
      self.done.put('ERR')
1275

    
1276
  def _doAddSet(self, names):
1277
    try:
1278
      self.ls.add(names, acquired=1)
1279
      self.done.put('DONE')
1280
      self.ls.release()
1281
    except errors.LockError:
1282
      self.done.put('ERR')
1283

    
1284
  def _doRemoveSet(self, names):
1285
    self.done.put(self.ls.remove(names))
1286

    
1287
  @_Repeat
1288
  def testConcurrentSharedAcquire(self):
1289
    self.ls.acquire(['one', 'two'], shared=1)
1290
    self._addThread(target=self._doLockSet, args=(['one', 'two'], 1))
1291
    self._waitThreads()
1292
    self.assertEqual(self.done.get_nowait(), 'DONE')
1293
    self._addThread(target=self._doLockSet, args=(['one', 'two', 'three'], 1))
1294
    self._waitThreads()
1295
    self.assertEqual(self.done.get_nowait(), 'DONE')
1296
    self._addThread(target=self._doLockSet, args=('three', 1))
1297
    self._waitThreads()
1298
    self.assertEqual(self.done.get_nowait(), 'DONE')
1299
    self._addThread(target=self._doLockSet, args=(['one', 'two'], 0))
1300
    self._addThread(target=self._doLockSet, args=(['two', 'three'], 0))
1301
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1302
    self.ls.release()
1303
    self._waitThreads()
1304
    self.assertEqual(self.done.get_nowait(), 'DONE')
1305
    self.assertEqual(self.done.get_nowait(), 'DONE')
1306

    
1307
  @_Repeat
1308
  def testConcurrentExclusiveAcquire(self):
1309
    self.ls.acquire(['one', 'two'])
1310
    self._addThread(target=self._doLockSet, args=('three', 1))
1311
    self._waitThreads()
1312
    self.assertEqual(self.done.get_nowait(), 'DONE')
1313
    self._addThread(target=self._doLockSet, args=('three', 0))
1314
    self._waitThreads()
1315
    self.assertEqual(self.done.get_nowait(), 'DONE')
1316
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1317
    self._addThread(target=self._doLockSet, args=(['one', 'two'], 0))
1318
    self._addThread(target=self._doLockSet, args=(['one', 'two'], 1))
1319
    self._addThread(target=self._doLockSet, args=('one', 0))
1320
    self._addThread(target=self._doLockSet, args=('one', 1))
1321
    self._addThread(target=self._doLockSet, args=(['two', 'three'], 0))
1322
    self._addThread(target=self._doLockSet, args=(['two', 'three'], 1))
1323
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1324
    self.ls.release()
1325
    self._waitThreads()
1326
    for _ in range(6):
1327
      self.failUnlessEqual(self.done.get_nowait(), 'DONE')
1328

    
1329
  @_Repeat
1330
  def testSimpleAcquireTimeoutExpiring(self):
1331
    names = sorted(self.ls._names())
1332
    self.assert_(len(names) >= 3)
1333

    
1334
    # Get name of first lock
1335
    first = names[0]
1336

    
1337
    # Get name of last lock
1338
    last = names.pop()
1339

    
1340
    checks = [
1341
      # Block first and try to lock it again
1342
      (first, first),
1343

    
1344
      # Block last and try to lock all locks
1345
      (None, first),
1346

    
1347
      # Block last and try to lock it again
1348
      (last, last),
1349
      ]
1350

    
1351
    for (wanted, block) in checks:
1352
      # Lock in exclusive mode
1353
      self.assert_(self.ls.acquire(block, shared=0))
1354

    
1355
      def _AcquireOne():
1356
        # Try to get the same lock again with a timeout (should never succeed)
1357
        acquired = self.ls.acquire(wanted, timeout=0.1, shared=0)
1358
        if acquired:
1359
          self.done.put("acquired")
1360
          self.ls.release()
1361
        else:
1362
          self.assert_(acquired is None)
1363
          self.assertFalse(self.ls._list_owned())
1364
          self.assertFalse(self.ls._is_owned())
1365
          self.done.put("not acquired")
1366

    
1367
      self._addThread(target=_AcquireOne)
1368

    
1369
      # Wait for timeout in thread to expire
1370
      self._waitThreads()
1371

    
1372
      # Release exclusive lock again
1373
      self.ls.release()
1374

    
1375
      self.assertEqual(self.done.get_nowait(), "not acquired")
1376
      self.assertRaises(Queue.Empty, self.done.get_nowait)
1377

    
1378
  @_Repeat
1379
  def testDelayedAndExpiringLockAcquire(self):
1380
    self._setUpLS()
1381
    self.ls.add(['five', 'six', 'seven', 'eight', 'nine'])
1382

    
1383
    for expire in (False, True):
1384
      names = sorted(self.ls._names())
1385
      self.assertEqual(len(names), 8)
1386

    
1387
      lock_ev = dict([(i, threading.Event()) for i in names])
1388

    
1389
      # Lock all in exclusive mode
1390
      self.assert_(self.ls.acquire(names, shared=0))
1391

    
1392
      if expire:
1393
        # We'll wait at least 300ms per lock
1394
        lockwait = len(names) * [0.3]
1395

    
1396
        # Fail if we can't acquire all locks in 400ms. There are 8 locks, so
1397
        # this gives us up to 2.4s to fail.
1398
        lockall_timeout = 0.4
1399
      else:
1400
        # This should finish rather quickly
1401
        lockwait = None
1402
        lockall_timeout = len(names) * 5.0
1403

    
1404
      def _LockAll():
1405
        def acquire_notification(name):
1406
          if not expire:
1407
            self.done.put("getting %s" % name)
1408

    
1409
          # Kick next lock
1410
          lock_ev[name].set()
1411

    
1412
        if self.ls.acquire(names, shared=0, timeout=lockall_timeout,
1413
                           test_notify=acquire_notification):
1414
          self.done.put("got all")
1415
          self.ls.release()
1416
        else:
1417
          self.done.put("timeout on all")
1418

    
1419
        # Notify all locks
1420
        for ev in lock_ev.values():
1421
          ev.set()
1422

    
1423
      t = self._addThread(target=_LockAll)
1424

    
1425
      for idx, name in enumerate(names):
1426
        # Wait for actual acquire on this lock to start
1427
        lock_ev[name].wait(10.0)
1428

    
1429
        if expire and t.isAlive():
1430
          # Wait some time after getting the notification to make sure the lock
1431
          # acquire will expire
1432
          SafeSleep(lockwait[idx])
1433

    
1434
        self.ls.release(names=name)
1435

    
1436
      self.assertFalse(self.ls._list_owned())
1437

    
1438
      self._waitThreads()
1439

    
1440
      if expire:
1441
        # Not checking which locks were actually acquired. Doing so would be
1442
        # too timing-dependant.
1443
        self.assertEqual(self.done.get_nowait(), "timeout on all")
1444
      else:
1445
        for i in names:
1446
          self.assertEqual(self.done.get_nowait(), "getting %s" % i)
1447
        self.assertEqual(self.done.get_nowait(), "got all")
1448
      self.assertRaises(Queue.Empty, self.done.get_nowait)
1449

    
1450
  @_Repeat
1451
  def testConcurrentRemove(self):
1452
    self.ls.add('four')
1453
    self.ls.acquire(['one', 'two', 'four'])
1454
    self._addThread(target=self._doLockSet, args=(['one', 'four'], 0))
1455
    self._addThread(target=self._doLockSet, args=(['one', 'four'], 1))
1456
    self._addThread(target=self._doLockSet, args=(['one', 'two'], 0))
1457
    self._addThread(target=self._doLockSet, args=(['one', 'two'], 1))
1458
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1459
    self.ls.remove('one')
1460
    self.ls.release()
1461
    self._waitThreads()
1462
    for i in range(4):
1463
      self.failUnlessEqual(self.done.get_nowait(), 'ERR')
1464
    self.ls.add(['five', 'six'], acquired=1)
1465
    self._addThread(target=self._doLockSet, args=(['three', 'six'], 1))
1466
    self._addThread(target=self._doLockSet, args=(['three', 'six'], 0))
1467
    self._addThread(target=self._doLockSet, args=(['four', 'six'], 1))
1468
    self._addThread(target=self._doLockSet, args=(['four', 'six'], 0))
1469
    self.ls.remove('five')
1470
    self.ls.release()
1471
    self._waitThreads()
1472
    for i in range(4):
1473
      self.failUnlessEqual(self.done.get_nowait(), 'DONE')
1474
    self.ls.acquire(['three', 'four'])
1475
    self._addThread(target=self._doRemoveSet, args=(['four', 'six'], ))
1476
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1477
    self.ls.remove('four')
1478
    self._waitThreads()
1479
    self.assertEqual(self.done.get_nowait(), ['six'])
1480
    self._addThread(target=self._doRemoveSet, args=(['two']))
1481
    self._waitThreads()
1482
    self.assertEqual(self.done.get_nowait(), ['two'])
1483
    self.ls.release()
1484
    # reset lockset
1485
    self._setUpLS()
1486

    
1487
  @_Repeat
1488
  def testConcurrentSharedSetLock(self):
1489
    # share the set-lock...
1490
    self.ls.acquire(None, shared=1)
1491
    # ...another thread can share it too
1492
    self._addThread(target=self._doLockSet, args=(None, 1))
1493
    self._waitThreads()
1494
    self.assertEqual(self.done.get_nowait(), 'DONE')
1495
    # ...or just share some elements
1496
    self._addThread(target=self._doLockSet, args=(['one', 'three'], 1))
1497
    self._waitThreads()
1498
    self.assertEqual(self.done.get_nowait(), 'DONE')
1499
    # ...but not add new ones or remove any
1500
    t = self._addThread(target=self._doAddSet, args=(['nine']))
1501
    self._addThread(target=self._doRemoveSet, args=(['two'], ))
1502
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1503
    # this just releases the set-lock
1504
    self.ls.release([])
1505
    t.join(60)
1506
    self.assertEqual(self.done.get_nowait(), 'DONE')
1507
    # release the lock on the actual elements so remove() can proceed too
1508
    self.ls.release()
1509
    self._waitThreads()
1510
    self.failUnlessEqual(self.done.get_nowait(), ['two'])
1511
    # reset lockset
1512
    self._setUpLS()
1513

    
1514
  @_Repeat
1515
  def testConcurrentExclusiveSetLock(self):
1516
    # acquire the set-lock...
1517
    self.ls.acquire(None, shared=0)
1518
    # ...no one can do anything else
1519
    self._addThread(target=self._doLockSet, args=(None, 1))
1520
    self._addThread(target=self._doLockSet, args=(None, 0))
1521
    self._addThread(target=self._doLockSet, args=(['three'], 0))
1522
    self._addThread(target=self._doLockSet, args=(['two'], 1))
1523
    self._addThread(target=self._doAddSet, args=(['nine']))
1524
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1525
    self.ls.release()
1526
    self._waitThreads()
1527
    for _ in range(5):
1528
      self.assertEqual(self.done.get(True, 1), 'DONE')
1529
    # cleanup
1530
    self._setUpLS()
1531

    
1532
  @_Repeat
1533
  def testConcurrentSetLockAdd(self):
1534
    self.ls.acquire('one')
1535
    # Another thread wants the whole SetLock
1536
    self._addThread(target=self._doLockSet, args=(None, 0))
1537
    self._addThread(target=self._doLockSet, args=(None, 1))
1538
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1539
    self.assertRaises(AssertionError, self.ls.add, 'four')
1540
    self.ls.release()
1541
    self._waitThreads()
1542
    self.assertEqual(self.done.get_nowait(), 'DONE')
1543
    self.assertEqual(self.done.get_nowait(), 'DONE')
1544
    self.ls.acquire(None)
1545
    self._addThread(target=self._doLockSet, args=(None, 0))
1546
    self._addThread(target=self._doLockSet, args=(None, 1))
1547
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1548
    self.ls.add('four')
1549
    self.ls.add('five', acquired=1)
1550
    self.ls.add('six', acquired=1, shared=1)
1551
    self.assertEquals(self.ls._list_owned(),
1552
      set(['one', 'two', 'three', 'five', 'six']))
1553
    self.assertEquals(self.ls._is_owned(), True)
1554
    self.assertEquals(self.ls._names(),
1555
      set(['one', 'two', 'three', 'four', 'five', 'six']))
1556
    self.ls.release()
1557
    self._waitThreads()
1558
    self.assertEqual(self.done.get_nowait(), 'DONE')
1559
    self.assertEqual(self.done.get_nowait(), 'DONE')
1560
    self._setUpLS()
1561

    
1562
  @_Repeat
1563
  def testEmptyLockSet(self):
1564
    # get the set-lock
1565
    self.assertEqual(self.ls.acquire(None), set(['one', 'two', 'three']))
1566
    # now empty it...
1567
    self.ls.remove(['one', 'two', 'three'])
1568
    # and adds/locks by another thread still wait
1569
    self._addThread(target=self._doAddSet, args=(['nine']))
1570
    self._addThread(target=self._doLockSet, args=(None, 1))
1571
    self._addThread(target=self._doLockSet, args=(None, 0))
1572
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1573
    self.ls.release()
1574
    self._waitThreads()
1575
    for _ in range(3):
1576
      self.assertEqual(self.done.get_nowait(), 'DONE')
1577
    # empty it again...
1578
    self.assertEqual(self.ls.remove(['nine']), ['nine'])
1579
    # now share it...
1580
    self.assertEqual(self.ls.acquire(None, shared=1), set())
1581
    # other sharers can go, adds still wait
1582
    self._addThread(target=self._doLockSet, args=(None, 1))
1583
    self._waitThreads()
1584
    self.assertEqual(self.done.get_nowait(), 'DONE')
1585
    self._addThread(target=self._doAddSet, args=(['nine']))
1586
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1587
    self.ls.release()
1588
    self._waitThreads()
1589
    self.assertEqual(self.done.get_nowait(), 'DONE')
1590
    self._setUpLS()
1591

    
1592
  def testAcquireWithNamesDowngrade(self):
1593
    self.assertEquals(self.ls.acquire("two", shared=0), set(["two"]))
1594
    self.assertTrue(self.ls._is_owned())
1595
    self.assertFalse(self.ls._get_lock()._is_owned())
1596
    self.ls.release()
1597
    self.assertFalse(self.ls._is_owned())
1598
    self.assertFalse(self.ls._get_lock()._is_owned())
1599
    # Can't downgrade after releasing
1600
    self.assertRaises(AssertionError, self.ls.downgrade, "two")
1601

    
1602
  def testDowngrade(self):
1603
    # Not owning anything, must raise an exception
1604
    self.assertFalse(self.ls._is_owned())
1605
    self.assertRaises(AssertionError, self.ls.downgrade)
1606

    
1607
    self.assertFalse(compat.any(i._is_owned()
1608
                                for i in self.ls._get_lockdict().values()))
1609

    
1610
    self.assertEquals(self.ls.acquire(None, shared=0),
1611
                      set(["one", "two", "three"]))
1612
    self.assertRaises(AssertionError, self.ls.downgrade, "unknown lock")
1613

    
1614
    self.assertTrue(self.ls._get_lock()._is_owned(shared=0))
1615
    self.assertTrue(compat.all(i._is_owned(shared=0)
1616
                               for i in self.ls._get_lockdict().values()))
1617

    
1618
    # Start downgrading locks
1619
    self.assertTrue(self.ls.downgrade(names=["one"]))
1620
    self.assertTrue(self.ls._get_lock()._is_owned(shared=0))
1621
    self.assertTrue(compat.all(lock._is_owned(shared=[0, 1][int(name == "one")])
1622
                               for name, lock in
1623
                                 self.ls._get_lockdict().items()))
1624

    
1625
    self.assertTrue(self.ls.downgrade(names="two"))
1626
    self.assertTrue(self.ls._get_lock()._is_owned(shared=0))
1627
    should_share = lambda name: [0, 1][int(name in ("one", "two"))]
1628
    self.assertTrue(compat.all(lock._is_owned(shared=should_share(name))
1629
                               for name, lock in
1630
                                 self.ls._get_lockdict().items()))
1631

    
1632
    # Downgrading the last exclusive lock to shared must downgrade the
1633
    # lockset-internal lock too
1634
    self.assertTrue(self.ls.downgrade(names="three"))
1635
    self.assertTrue(self.ls._get_lock()._is_owned(shared=1))
1636
    self.assertTrue(compat.all(i._is_owned(shared=1)
1637
                               for i in self.ls._get_lockdict().values()))
1638

    
1639
    # Downgrading a shared lock must be a no-op
1640
    self.assertTrue(self.ls.downgrade(names=["one", "three"]))
1641
    self.assertTrue(self.ls._get_lock()._is_owned(shared=1))
1642
    self.assertTrue(compat.all(i._is_owned(shared=1)
1643
                               for i in self.ls._get_lockdict().values()))
1644

    
1645
    self.ls.release()
1646

    
1647
  def testPriority(self):
1648
    def _Acquire(prev, next, name, priority, success_fn):
1649
      prev.wait()
1650
      self.assert_(self.ls.acquire(name, shared=0,
1651
                                   priority=priority,
1652
                                   test_notify=lambda _: next.set()))
1653
      try:
1654
        success_fn()
1655
      finally:
1656
        self.ls.release()
1657

    
1658
    # Get all in exclusive mode
1659
    self.assert_(self.ls.acquire(locking.ALL_SET, shared=0))
1660

    
1661
    done_two = Queue.Queue(0)
1662

    
1663
    first = threading.Event()
1664
    prev = first
1665

    
1666
    acquires = [("one", prio, self.done) for prio in range(1, 33)]
1667
    acquires.extend([("two", prio, done_two) for prio in range(1, 33)])
1668

    
1669
    # Use a deterministic random generator
1670
    random.Random(741).shuffle(acquires)
1671

    
1672
    for (name, prio, done) in acquires:
1673
      ev = threading.Event()
1674
      self._addThread(target=_Acquire,
1675
                      args=(prev, ev, name, prio,
1676
                            compat.partial(done.put, "Prio%s" % prio)))
1677
      prev = ev
1678

    
1679
    # Start acquires
1680
    first.set()
1681

    
1682
    # Wait for last acquire to start
1683
    prev.wait()
1684

    
1685
    # Let threads acquire locks
1686
    self.ls.release()
1687

    
1688
    # Wait for threads to finish
1689
    self._waitThreads()
1690

    
1691
    for i in range(1, 33):
1692
      self.assertEqual(self.done.get_nowait(), "Prio%s" % i)
1693
      self.assertEqual(done_two.get_nowait(), "Prio%s" % i)
1694

    
1695
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1696
    self.assertRaises(Queue.Empty, done_two.get_nowait)
1697

    
1698

    
1699
class TestGanetiLockManager(_ThreadedTestCase):
1700

    
1701
  def setUp(self):
1702
    _ThreadedTestCase.setUp(self)
1703
    self.nodes=['n1', 'n2']
1704
    self.nodegroups=['g1', 'g2']
1705
    self.instances=['i1', 'i2', 'i3']
1706
    self.GL = locking.GanetiLockManager(self.nodes, self.nodegroups,
1707
                                        self.instances)
1708

    
1709
  def tearDown(self):
1710
    # Don't try this at home...
1711
    locking.GanetiLockManager._instance = None
1712

    
1713
  def testLockingConstants(self):
1714
    # The locking library internally cheats by assuming its constants have some
1715
    # relationships with each other. Check those hold true.
1716
    # This relationship is also used in the Processor to recursively acquire
1717
    # the right locks. Again, please don't break it.
1718
    for i in range(len(locking.LEVELS)):
1719
      self.assertEqual(i, locking.LEVELS[i])
1720

    
1721
  def testDoubleGLFails(self):
1722
    self.assertRaises(AssertionError, locking.GanetiLockManager, [], [], [])
1723

    
1724
  def testLockNames(self):
1725
    self.assertEqual(self.GL._names(locking.LEVEL_CLUSTER), set(['BGL']))
1726
    self.assertEqual(self.GL._names(locking.LEVEL_NODE), set(self.nodes))
1727
    self.assertEqual(self.GL._names(locking.LEVEL_NODEGROUP),
1728
                     set(self.nodegroups))
1729
    self.assertEqual(self.GL._names(locking.LEVEL_INSTANCE),
1730
                     set(self.instances))
1731

    
1732
  def testInitAndResources(self):
1733
    locking.GanetiLockManager._instance = None
1734
    self.GL = locking.GanetiLockManager([], [], [])
1735
    self.assertEqual(self.GL._names(locking.LEVEL_CLUSTER), set(['BGL']))
1736
    self.assertEqual(self.GL._names(locking.LEVEL_NODE), set())
1737
    self.assertEqual(self.GL._names(locking.LEVEL_NODEGROUP), set())
1738
    self.assertEqual(self.GL._names(locking.LEVEL_INSTANCE), set())
1739

    
1740
    locking.GanetiLockManager._instance = None
1741
    self.GL = locking.GanetiLockManager(self.nodes, self.nodegroups, [])
1742
    self.assertEqual(self.GL._names(locking.LEVEL_CLUSTER), set(['BGL']))
1743
    self.assertEqual(self.GL._names(locking.LEVEL_NODE), set(self.nodes))
1744
    self.assertEqual(self.GL._names(locking.LEVEL_NODEGROUP),
1745
                                    set(self.nodegroups))
1746
    self.assertEqual(self.GL._names(locking.LEVEL_INSTANCE), set())
1747

    
1748
    locking.GanetiLockManager._instance = None
1749
    self.GL = locking.GanetiLockManager([], [], self.instances)
1750
    self.assertEqual(self.GL._names(locking.LEVEL_CLUSTER), set(['BGL']))
1751
    self.assertEqual(self.GL._names(locking.LEVEL_NODE), set())
1752
    self.assertEqual(self.GL._names(locking.LEVEL_NODEGROUP), set())
1753
    self.assertEqual(self.GL._names(locking.LEVEL_INSTANCE),
1754
                     set(self.instances))
1755

    
1756
  def testAcquireRelease(self):
1757
    self.GL.acquire(locking.LEVEL_CLUSTER, ['BGL'], shared=1)
1758
    self.assertEquals(self.GL._list_owned(locking.LEVEL_CLUSTER), set(['BGL']))
1759
    self.GL.acquire(locking.LEVEL_INSTANCE, ['i1'])
1760
    self.GL.acquire(locking.LEVEL_NODEGROUP, ['g2'])
1761
    self.GL.acquire(locking.LEVEL_NODE, ['n1', 'n2'], shared=1)
1762
    self.GL.release(locking.LEVEL_NODE, ['n2'])
1763
    self.assertEquals(self.GL._list_owned(locking.LEVEL_NODE), set(['n1']))
1764
    self.assertEquals(self.GL._list_owned(locking.LEVEL_NODEGROUP), set(['g2']))
1765
    self.assertEquals(self.GL._list_owned(locking.LEVEL_INSTANCE), set(['i1']))
1766
    self.GL.release(locking.LEVEL_NODE)
1767
    self.assertEquals(self.GL._list_owned(locking.LEVEL_NODE), set())
1768
    self.assertEquals(self.GL._list_owned(locking.LEVEL_NODEGROUP), set(['g2']))
1769
    self.assertEquals(self.GL._list_owned(locking.LEVEL_INSTANCE), set(['i1']))
1770
    self.GL.release(locking.LEVEL_NODEGROUP)
1771
    self.GL.release(locking.LEVEL_INSTANCE)
1772
    self.assertRaises(errors.LockError, self.GL.acquire,
1773
                      locking.LEVEL_INSTANCE, ['i5'])
1774
    self.GL.acquire(locking.LEVEL_INSTANCE, ['i3'], shared=1)
1775
    self.assertEquals(self.GL._list_owned(locking.LEVEL_INSTANCE), set(['i3']))
1776

    
1777
  def testAcquireWholeSets(self):
1778
    self.GL.acquire(locking.LEVEL_CLUSTER, ['BGL'], shared=1)
1779
    self.assertEquals(self.GL.acquire(locking.LEVEL_INSTANCE, None),
1780
                      set(self.instances))
1781
    self.assertEquals(self.GL._list_owned(locking.LEVEL_INSTANCE),
1782
                      set(self.instances))
1783
    self.assertEquals(self.GL.acquire(locking.LEVEL_NODEGROUP, None),
1784
                      set(self.nodegroups))
1785
    self.assertEquals(self.GL._list_owned(locking.LEVEL_NODEGROUP),
1786
                      set(self.nodegroups))
1787
    self.assertEquals(self.GL.acquire(locking.LEVEL_NODE, None, shared=1),
1788
                      set(self.nodes))
1789
    self.assertEquals(self.GL._list_owned(locking.LEVEL_NODE),
1790
                      set(self.nodes))
1791
    self.GL.release(locking.LEVEL_NODE)
1792
    self.GL.release(locking.LEVEL_NODEGROUP)
1793
    self.GL.release(locking.LEVEL_INSTANCE)
1794
    self.GL.release(locking.LEVEL_CLUSTER)
1795

    
1796
  def testAcquireWholeAndPartial(self):
1797
    self.GL.acquire(locking.LEVEL_CLUSTER, ['BGL'], shared=1)
1798
    self.assertEquals(self.GL.acquire(locking.LEVEL_INSTANCE, None),
1799
                      set(self.instances))
1800
    self.assertEquals(self.GL._list_owned(locking.LEVEL_INSTANCE),
1801
                      set(self.instances))
1802
    self.assertEquals(self.GL.acquire(locking.LEVEL_NODE, ['n2'], shared=1),
1803
                      set(['n2']))
1804
    self.assertEquals(self.GL._list_owned(locking.LEVEL_NODE),
1805
                      set(['n2']))
1806
    self.GL.release(locking.LEVEL_NODE)
1807
    self.GL.release(locking.LEVEL_INSTANCE)
1808
    self.GL.release(locking.LEVEL_CLUSTER)
1809

    
1810
  def testBGLDependency(self):
1811
    self.assertRaises(AssertionError, self.GL.acquire,
1812
                      locking.LEVEL_NODE, ['n1', 'n2'])
1813
    self.assertRaises(AssertionError, self.GL.acquire,
1814
                      locking.LEVEL_INSTANCE, ['i3'])
1815
    self.assertRaises(AssertionError, self.GL.acquire,
1816
                      locking.LEVEL_NODEGROUP, ['g1'])
1817
    self.GL.acquire(locking.LEVEL_CLUSTER, ['BGL'], shared=1)
1818
    self.GL.acquire(locking.LEVEL_NODE, ['n1'])
1819
    self.assertRaises(AssertionError, self.GL.release,
1820
                      locking.LEVEL_CLUSTER, ['BGL'])
1821
    self.assertRaises(AssertionError, self.GL.release,
1822
                      locking.LEVEL_CLUSTER)
1823
    self.GL.release(locking.LEVEL_NODE)
1824
    self.GL.acquire(locking.LEVEL_INSTANCE, ['i1', 'i2'])
1825
    self.assertRaises(AssertionError, self.GL.release,
1826
                      locking.LEVEL_CLUSTER, ['BGL'])
1827
    self.assertRaises(AssertionError, self.GL.release,
1828
                      locking.LEVEL_CLUSTER)
1829
    self.GL.release(locking.LEVEL_INSTANCE)
1830
    self.GL.acquire(locking.LEVEL_NODEGROUP, None)
1831
    self.GL.release(locking.LEVEL_NODEGROUP, ['g1'])
1832
    self.assertRaises(AssertionError, self.GL.release,
1833
                      locking.LEVEL_CLUSTER, ['BGL'])
1834
    self.assertRaises(AssertionError, self.GL.release,
1835
                      locking.LEVEL_CLUSTER)
1836
    self.GL.release(locking.LEVEL_NODEGROUP)
1837
    self.GL.release(locking.LEVEL_CLUSTER)
1838

    
1839
  def testWrongOrder(self):
1840
    self.GL.acquire(locking.LEVEL_CLUSTER, ['BGL'], shared=1)
1841
    self.GL.acquire(locking.LEVEL_NODE, ['n2'])
1842
    self.assertRaises(AssertionError, self.GL.acquire,
1843
                      locking.LEVEL_NODE, ['n1'])
1844
    self.assertRaises(AssertionError, self.GL.acquire,
1845
                      locking.LEVEL_NODEGROUP, ['g1'])
1846
    self.assertRaises(AssertionError, self.GL.acquire,
1847
                      locking.LEVEL_INSTANCE, ['i2'])
1848

    
1849
  def testModifiableLevels(self):
1850
    self.assertRaises(AssertionError, self.GL.add, locking.LEVEL_CLUSTER,
1851
                      ['BGL2'])
1852
    self.GL.acquire(locking.LEVEL_CLUSTER, ['BGL'])
1853
    self.GL.add(locking.LEVEL_INSTANCE, ['i4'])
1854
    self.GL.remove(locking.LEVEL_INSTANCE, ['i3'])
1855
    self.GL.remove(locking.LEVEL_INSTANCE, ['i1'])
1856
    self.assertEqual(self.GL._names(locking.LEVEL_INSTANCE), set(['i2', 'i4']))
1857
    self.GL.add(locking.LEVEL_NODE, ['n3'])
1858
    self.GL.remove(locking.LEVEL_NODE, ['n1'])
1859
    self.assertEqual(self.GL._names(locking.LEVEL_NODE), set(['n2', 'n3']))
1860
    self.GL.add(locking.LEVEL_NODEGROUP, ['g3'])
1861
    self.GL.remove(locking.LEVEL_NODEGROUP, ['g2'])
1862
    self.GL.remove(locking.LEVEL_NODEGROUP, ['g1'])
1863
    self.assertEqual(self.GL._names(locking.LEVEL_NODEGROUP), set(['g3']))
1864
    self.assertRaises(AssertionError, self.GL.remove, locking.LEVEL_CLUSTER,
1865
                      ['BGL2'])
1866

    
1867
  # Helper function to run as a thread that shared the BGL and then acquires
1868
  # some locks at another level.
1869
  def _doLock(self, level, names, shared):
1870
    try:
1871
      self.GL.acquire(locking.LEVEL_CLUSTER, ['BGL'], shared=1)
1872
      self.GL.acquire(level, names, shared=shared)
1873
      self.done.put('DONE')
1874
      self.GL.release(level)
1875
      self.GL.release(locking.LEVEL_CLUSTER)
1876
    except errors.LockError:
1877
      self.done.put('ERR')
1878

    
1879
  @_Repeat
1880
  def testConcurrency(self):
1881
    self.GL.acquire(locking.LEVEL_CLUSTER, ['BGL'], shared=1)
1882
    self._addThread(target=self._doLock,
1883
                    args=(locking.LEVEL_INSTANCE, 'i1', 1))
1884
    self._waitThreads()
1885
    self.assertEqual(self.done.get_nowait(), 'DONE')
1886
    self.GL.acquire(locking.LEVEL_INSTANCE, ['i3'])
1887
    self._addThread(target=self._doLock,
1888
                    args=(locking.LEVEL_INSTANCE, 'i1', 1))
1889
    self._waitThreads()
1890
    self.assertEqual(self.done.get_nowait(), 'DONE')
1891
    self._addThread(target=self._doLock,
1892
                    args=(locking.LEVEL_INSTANCE, 'i3', 1))
1893
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1894
    self.GL.release(locking.LEVEL_INSTANCE)
1895
    self._waitThreads()
1896
    self.assertEqual(self.done.get_nowait(), 'DONE')
1897
    self.GL.acquire(locking.LEVEL_INSTANCE, ['i2'], shared=1)
1898
    self._addThread(target=self._doLock,
1899
                    args=(locking.LEVEL_INSTANCE, 'i2', 1))
1900
    self._waitThreads()
1901
    self.assertEqual(self.done.get_nowait(), 'DONE')
1902
    self._addThread(target=self._doLock,
1903
                    args=(locking.LEVEL_INSTANCE, 'i2', 0))
1904
    self.assertRaises(Queue.Empty, self.done.get_nowait)
1905
    self.GL.release(locking.LEVEL_INSTANCE)
1906
    self._waitThreads()
1907
    self.assertEqual(self.done.get(True, 1), 'DONE')
1908
    self.GL.release(locking.LEVEL_CLUSTER, ['BGL'])
1909

    
1910

    
1911
class TestLockMonitor(_ThreadedTestCase):
1912
  def setUp(self):
1913
    _ThreadedTestCase.setUp(self)
1914
    self.lm = locking.LockMonitor()
1915

    
1916
  def testSingleThread(self):
1917
    locks = []
1918

    
1919
    for i in range(100):
1920
      name = "TestLock%s" % i
1921
      locks.append(locking.SharedLock(name, monitor=self.lm))
1922

    
1923
    self.assertEqual(len(self.lm._locks), len(locks))
1924
    result = objects.QueryResponse.FromDict(self.lm.QueryLocks(["name"]))
1925
    self.assertEqual(len(result.fields), 1)
1926
    self.assertEqual(len(result.data), 100)
1927

    
1928
    # Delete all locks
1929
    del locks[:]
1930

    
1931
    # The garbage collector might needs some time
1932
    def _CheckLocks():
1933
      if self.lm._locks:
1934
        raise utils.RetryAgain()
1935

    
1936
    utils.Retry(_CheckLocks, 0.1, 30.0)
1937

    
1938
    self.assertFalse(self.lm._locks)
1939

    
1940
  def testMultiThread(self):
1941
    locks = []
1942

    
1943
    def _CreateLock(prev, next, name):
1944
      prev.wait()
1945
      locks.append(locking.SharedLock(name, monitor=self.lm))
1946
      if next:
1947
        next.set()
1948

    
1949
    expnames = []
1950

    
1951
    first = threading.Event()
1952
    prev = first
1953

    
1954
    # Use a deterministic random generator
1955
    for i in random.Random(4263).sample(range(100), 33):
1956
      name = "MtTestLock%s" % i
1957
      expnames.append(name)
1958

    
1959
      ev = threading.Event()
1960
      self._addThread(target=_CreateLock, args=(prev, ev, name))
1961
      prev = ev
1962

    
1963
    # Add locks
1964
    first.set()
1965
    self._waitThreads()
1966

    
1967
    # Check order in which locks were added
1968
    self.assertEqual([i.name for i in locks], expnames)
1969

    
1970
    # Check query result
1971
    result = self.lm.QueryLocks(["name", "mode", "owner", "pending"])
1972
    self.assert_(isinstance(result, dict))
1973
    response = objects.QueryResponse.FromDict(result)
1974
    self.assertEqual(response.data,
1975
                     [[(constants.RS_NORMAL, name),
1976
                       (constants.RS_NORMAL, None),
1977
                       (constants.RS_NORMAL, None),
1978
                       (constants.RS_NORMAL, [])]
1979
                      for name in utils.NiceSort(expnames)])
1980
    self.assertEqual(len(response.fields), 4)
1981
    self.assertEqual(["name", "mode", "owner", "pending"],
1982
                     [fdef.name for fdef in response.fields])
1983

    
1984
    # Test exclusive acquire
1985
    for tlock in locks[::4]:
1986
      tlock.acquire(shared=0)
1987
      try:
1988
        def _GetExpResult(name):
1989
          if tlock.name == name:
1990
            return [(constants.RS_NORMAL, name),
1991
                    (constants.RS_NORMAL, "exclusive"),
1992
                    (constants.RS_NORMAL,
1993
                     [threading.currentThread().getName()]),
1994
                    (constants.RS_NORMAL, [])]
1995
          return [(constants.RS_NORMAL, name),
1996
                  (constants.RS_NORMAL, None),
1997
                  (constants.RS_NORMAL, None),
1998
                  (constants.RS_NORMAL, [])]
1999

    
2000
        result = self.lm.QueryLocks(["name", "mode", "owner", "pending"])
2001
        self.assertEqual(objects.QueryResponse.FromDict(result).data,
2002
                         [_GetExpResult(name)
2003
                          for name in utils.NiceSort(expnames)])
2004
      finally:
2005
        tlock.release()
2006

    
2007
    # Test shared acquire
2008
    def _Acquire(lock, shared, ev, notify):
2009
      lock.acquire(shared=shared)
2010
      try:
2011
        notify.set()
2012
        ev.wait()
2013
      finally:
2014
        lock.release()
2015

    
2016
    for tlock1 in locks[::11]:
2017
      for tlock2 in locks[::-15]:
2018
        if tlock2 == tlock1:
2019
          # Avoid deadlocks
2020
          continue
2021

    
2022
        for tlock3 in locks[::10]:
2023
          if tlock3 in (tlock2, tlock1):
2024
            # Avoid deadlocks
2025
            continue
2026

    
2027
          releaseev = threading.Event()
2028

    
2029
          # Acquire locks
2030
          acquireev = []
2031
          tthreads1 = []
2032
          for i in range(3):
2033
            ev = threading.Event()
2034
            tthreads1.append(self._addThread(target=_Acquire,
2035
                                             args=(tlock1, 1, releaseev, ev)))
2036
            acquireev.append(ev)
2037

    
2038
          ev = threading.Event()
2039
          tthread2 = self._addThread(target=_Acquire,
2040
                                     args=(tlock2, 1, releaseev, ev))
2041
          acquireev.append(ev)
2042

    
2043
          ev = threading.Event()
2044
          tthread3 = self._addThread(target=_Acquire,
2045
                                     args=(tlock3, 0, releaseev, ev))
2046
          acquireev.append(ev)
2047

    
2048
          # Wait for all locks to be acquired
2049
          for i in acquireev:
2050
            i.wait()
2051

    
2052
          # Check query result
2053
          result = self.lm.QueryLocks(["name", "mode", "owner"])
2054
          response = objects.QueryResponse.FromDict(result)
2055
          for (name, mode, owner) in response.data:
2056
            (name_status, name_value) = name
2057
            (owner_status, owner_value) = owner
2058

    
2059
            self.assertEqual(name_status, constants.RS_NORMAL)
2060
            self.assertEqual(owner_status, constants.RS_NORMAL)
2061

    
2062
            if name_value == tlock1.name:
2063
              self.assertEqual(mode, (constants.RS_NORMAL, "shared"))
2064
              self.assertEqual(set(owner_value),
2065
                               set(i.getName() for i in tthreads1))
2066
              continue
2067

    
2068
            if name_value == tlock2.name:
2069
              self.assertEqual(mode, (constants.RS_NORMAL, "shared"))
2070
              self.assertEqual(owner_value, [tthread2.getName()])
2071
              continue
2072

    
2073
            if name_value == tlock3.name:
2074
              self.assertEqual(mode, (constants.RS_NORMAL, "exclusive"))
2075
              self.assertEqual(owner_value, [tthread3.getName()])
2076
              continue
2077

    
2078
            self.assert_(name_value in expnames)
2079
            self.assertEqual(mode, (constants.RS_NORMAL, None))
2080
            self.assert_(owner_value is None)
2081

    
2082
          # Release locks again
2083
          releaseev.set()
2084

    
2085
          self._waitThreads()
2086

    
2087
          result = self.lm.QueryLocks(["name", "mode", "owner"])
2088
          self.assertEqual(objects.QueryResponse.FromDict(result).data,
2089
                           [[(constants.RS_NORMAL, name),
2090
                             (constants.RS_NORMAL, None),
2091
                             (constants.RS_NORMAL, None)]
2092
                            for name in utils.NiceSort(expnames)])
2093

    
2094
  def testDelete(self):
2095
    lock = locking.SharedLock("TestLock", monitor=self.lm)
2096

    
2097
    self.assertEqual(len(self.lm._locks), 1)
2098
    result = self.lm.QueryLocks(["name", "mode", "owner"])
2099
    self.assertEqual(objects.QueryResponse.FromDict(result).data,
2100
                     [[(constants.RS_NORMAL, lock.name),
2101
                       (constants.RS_NORMAL, None),
2102
                       (constants.RS_NORMAL, None)]])
2103

    
2104
    lock.delete()
2105

    
2106
    result = self.lm.QueryLocks(["name", "mode", "owner"])
2107
    self.assertEqual(objects.QueryResponse.FromDict(result).data,
2108
                     [[(constants.RS_NORMAL, lock.name),
2109
                       (constants.RS_NORMAL, "deleted"),
2110
                       (constants.RS_NORMAL, None)]])
2111
    self.assertEqual(len(self.lm._locks), 1)
2112

    
2113
  def testPending(self):
2114
    def _Acquire(lock, shared, prev, next):
2115
      prev.wait()
2116

    
2117
      lock.acquire(shared=shared, test_notify=next.set)
2118
      try:
2119
        pass
2120
      finally:
2121
        lock.release()
2122

    
2123
    lock = locking.SharedLock("ExcLock", monitor=self.lm)
2124

    
2125
    for shared in [0, 1]:
2126
      lock.acquire()
2127
      try:
2128
        self.assertEqual(len(self.lm._locks), 1)
2129
        result = self.lm.QueryLocks(["name", "mode", "owner"])
2130
        self.assertEqual(objects.QueryResponse.FromDict(result).data,
2131
                         [[(constants.RS_NORMAL, lock.name),
2132
                           (constants.RS_NORMAL, "exclusive"),
2133
                           (constants.RS_NORMAL,
2134
                            [threading.currentThread().getName()])]])
2135

    
2136
        threads = []
2137

    
2138
        first = threading.Event()
2139
        prev = first
2140

    
2141
        for i in range(5):
2142
          ev = threading.Event()
2143
          threads.append(self._addThread(target=_Acquire,
2144
                                          args=(lock, shared, prev, ev)))
2145
          prev = ev
2146

    
2147
        # Start acquires
2148
        first.set()
2149

    
2150
        # Wait for last acquire to start waiting
2151
        prev.wait()
2152

    
2153
        # NOTE: This works only because QueryLocks will acquire the
2154
        # lock-internal lock again and won't be able to get the information
2155
        # until it has the lock. By then the acquire should be registered in
2156
        # SharedLock.__pending (otherwise it's a bug).
2157

    
2158
        # All acquires are waiting now
2159
        if shared:
2160
          pending = [("shared", utils.NiceSort(t.getName() for t in threads))]
2161
        else:
2162
          pending = [("exclusive", [t.getName()]) for t in threads]
2163

    
2164
        result = self.lm.QueryLocks(["name", "mode", "owner", "pending"])
2165
        self.assertEqual(objects.QueryResponse.FromDict(result).data,
2166
                         [[(constants.RS_NORMAL, lock.name),
2167
                           (constants.RS_NORMAL, "exclusive"),
2168
                           (constants.RS_NORMAL,
2169
                            [threading.currentThread().getName()]),
2170
                           (constants.RS_NORMAL, pending)]])
2171

    
2172
        self.assertEqual(len(self.lm._locks), 1)
2173
      finally:
2174
        lock.release()
2175

    
2176
      self._waitThreads()
2177

    
2178
      # No pending acquires
2179
      result = self.lm.QueryLocks(["name", "mode", "owner", "pending"])
2180
      self.assertEqual(objects.QueryResponse.FromDict(result).data,
2181
                       [[(constants.RS_NORMAL, lock.name),
2182
                         (constants.RS_NORMAL, None),
2183
                         (constants.RS_NORMAL, None),
2184
                         (constants.RS_NORMAL, [])]])
2185

    
2186
      self.assertEqual(len(self.lm._locks), 1)
2187

    
2188
  def testDeleteAndRecreate(self):
2189
    lname = "TestLock101923193"
2190

    
2191
    # Create some locks with the same name and keep all references
2192
    locks = [locking.SharedLock(lname, monitor=self.lm)
2193
             for _ in range(5)]
2194

    
2195
    self.assertEqual(len(self.lm._locks), len(locks))
2196

    
2197
    result = self.lm.QueryLocks(["name", "mode", "owner"])
2198
    self.assertEqual(objects.QueryResponse.FromDict(result).data,
2199
                     [[(constants.RS_NORMAL, lname),
2200
                       (constants.RS_NORMAL, None),
2201
                       (constants.RS_NORMAL, None)]] * 5)
2202

    
2203
    locks[2].delete()
2204

    
2205
    # Check information order
2206
    result = self.lm.QueryLocks(["name", "mode", "owner"])
2207
    self.assertEqual(objects.QueryResponse.FromDict(result).data,
2208
                     [[(constants.RS_NORMAL, lname),
2209
                       (constants.RS_NORMAL, None),
2210
                       (constants.RS_NORMAL, None)]] * 2 +
2211
                     [[(constants.RS_NORMAL, lname),
2212
                       (constants.RS_NORMAL, "deleted"),
2213
                       (constants.RS_NORMAL, None)]] +
2214
                     [[(constants.RS_NORMAL, lname),
2215
                       (constants.RS_NORMAL, None),
2216
                       (constants.RS_NORMAL, None)]] * 2)
2217

    
2218
    locks[1].acquire(shared=0)
2219

    
2220
    last_status = [
2221
      [(constants.RS_NORMAL, lname),
2222
       (constants.RS_NORMAL, None),
2223
       (constants.RS_NORMAL, None)],
2224
      [(constants.RS_NORMAL, lname),
2225
       (constants.RS_NORMAL, "exclusive"),
2226
       (constants.RS_NORMAL, [threading.currentThread().getName()])],
2227
      [(constants.RS_NORMAL, lname),
2228
       (constants.RS_NORMAL, "deleted"),
2229
       (constants.RS_NORMAL, None)],
2230
      [(constants.RS_NORMAL, lname),
2231
       (constants.RS_NORMAL, None),
2232
       (constants.RS_NORMAL, None)],
2233
      [(constants.RS_NORMAL, lname),
2234
       (constants.RS_NORMAL, None),
2235
       (constants.RS_NORMAL, None)],
2236
      ]
2237

    
2238
    # Check information order
2239
    result = self.lm.QueryLocks(["name", "mode", "owner"])
2240
    self.assertEqual(objects.QueryResponse.FromDict(result).data, last_status)
2241

    
2242
    self.assertEqual(len(set(self.lm._locks.values())), len(locks))
2243
    self.assertEqual(len(self.lm._locks), len(locks))
2244

    
2245
    # Check lock deletion
2246
    for idx in range(len(locks)):
2247
      del locks[0]
2248
      assert gc.isenabled()
2249
      gc.collect()
2250
      self.assertEqual(len(self.lm._locks), len(locks))
2251
      result = self.lm.QueryLocks(["name", "mode", "owner"])
2252
      self.assertEqual(objects.QueryResponse.FromDict(result).data,
2253
                       last_status[idx + 1:])
2254

    
2255
    # All locks should have been deleted
2256
    assert not locks
2257
    self.assertFalse(self.lm._locks)
2258

    
2259
    result = self.lm.QueryLocks(["name", "mode", "owner"])
2260
    self.assertEqual(objects.QueryResponse.FromDict(result).data, [])
2261

    
2262
  class _FakeLock:
2263
    def __init__(self):
2264
      self._info = []
2265

    
2266
    def AddResult(self, *args):
2267
      self._info.append(args)
2268

    
2269
    def CountPending(self):
2270
      return len(self._info)
2271

    
2272
    def GetLockInfo(self, requested):
2273
      (exp_requested, result) = self._info.pop(0)
2274

    
2275
      if exp_requested != requested:
2276
        raise Exception("Requested information (%s) does not match"
2277
                        " expectations (%s)" % (requested, exp_requested))
2278

    
2279
      return result
2280

    
2281
  def testMultipleResults(self):
2282
    fl1 = self._FakeLock()
2283
    fl2 = self._FakeLock()
2284

    
2285
    self.lm.RegisterLock(fl1)
2286
    self.lm.RegisterLock(fl2)
2287

    
2288
    # Empty information
2289
    for i in [fl1, fl2]:
2290
      i.AddResult(set([query.LQ_MODE, query.LQ_OWNER]), [])
2291
    result = self.lm.QueryLocks(["name", "mode", "owner"])
2292
    self.assertEqual(objects.QueryResponse.FromDict(result).data, [])
2293
    for i in [fl1, fl2]:
2294
      self.assertEqual(i.CountPending(), 0)
2295

    
2296
    # Check ordering
2297
    for fn in [lambda x: x, reversed, sorted]:
2298
      fl1.AddResult(set(), list(fn([
2299
        ("aaa", None, None, None),
2300
        ("bbb", None, None, None),
2301
        ])))
2302
      fl2.AddResult(set(), [])
2303
      result = self.lm.QueryLocks(["name"])
2304
      self.assertEqual(objects.QueryResponse.FromDict(result).data, [
2305
        [(constants.RS_NORMAL, "aaa")],
2306
        [(constants.RS_NORMAL, "bbb")],
2307
        ])
2308
      for i in [fl1, fl2]:
2309
        self.assertEqual(i.CountPending(), 0)
2310

    
2311
      for fn2 in [lambda x: x, reversed, sorted]:
2312
        fl1.AddResult(set([query.LQ_MODE]), list(fn([
2313
          # Same name, but different information
2314
          ("aaa", "mode0", None, None),
2315
          ("aaa", "mode1", None, None),
2316
          ("aaa", "mode2", None, None),
2317
          ("aaa", "mode3", None, None),
2318
          ])))
2319
        fl2.AddResult(set([query.LQ_MODE]), [
2320
          ("zzz", "end", None, None),
2321
          ("000", "start", None, None),
2322
          ] + list(fn2([
2323
          ("aaa", "b200", None, None),
2324
          ("aaa", "b300", None, None),
2325
          ])))
2326
        result = self.lm.QueryLocks(["name", "mode"])
2327
        self.assertEqual(objects.QueryResponse.FromDict(result).data, [
2328
          [(constants.RS_NORMAL, "000"), (constants.RS_NORMAL, "start")],
2329
          ] + list(fn([
2330
          # Name is the same, so order must be equal to incoming order
2331
          [(constants.RS_NORMAL, "aaa"), (constants.RS_NORMAL, "mode0")],
2332
          [(constants.RS_NORMAL, "aaa"), (constants.RS_NORMAL, "mode1")],
2333
          [(constants.RS_NORMAL, "aaa"), (constants.RS_NORMAL, "mode2")],
2334
          [(constants.RS_NORMAL, "aaa"), (constants.RS_NORMAL, "mode3")],
2335
          ])) + list(fn2([
2336
          [(constants.RS_NORMAL, "aaa"), (constants.RS_NORMAL, "b200")],
2337
          [(constants.RS_NORMAL, "aaa"), (constants.RS_NORMAL, "b300")],
2338
          ])) + [
2339
          [(constants.RS_NORMAL, "zzz"), (constants.RS_NORMAL, "end")],
2340
          ])
2341
        for i in [fl1, fl2]:
2342
          self.assertEqual(i.CountPending(), 0)
2343

    
2344

    
2345
if __name__ == '__main__':
2346
  testutils.GanetiTestProgram()