| Branch: | Tag: | Revision:

root / lib @ ac84befd

Name Size
  watcher 1.2 kB 6.1 kB 123.8 kB 109.1 kB 34.5 kB 121.6 kB 602 kB 4.3 kB 85.3 kB 59.8 kB 26.7 kB 10.8 kB 10.7 kB 79.2 kB 5.9 kB 61.1 kB 16.4 kB 26.1 kB 18.6 kB 6.1 kB 60.5 kB 66.1 kB 2.5 kB 66 kB 5.4 kB 9.6 kB 79.6 kB 25.9 kB 24 kB 6.3 kB 4.5 kB 11.5 kB 10.2 kB 13.2 kB 11.7 kB 7.4 kB 18.3 kB

Latest revisions

# Date Author Comment
ac84befd 03/01/2013 06:54 pm Dimitris Aragiorgis

Fix networks in _PrepareNicModifications()

Passing --net 0:add,ip= failed due to a reference
of a non initialized variable (new_net_obj). Reorder the checks
and add some comments to be readable.

Signed-off-by: Dimitris Aragiorgis <>...

ce35bdeb 02/28/2013 04:16 pm Dimitris Aragiorgis

Remove early returns in network LUs

Remove any early returns in LUNetworkDisconnect/LUNetworkConnect
and replace them with if-else statements.

Signed-off-by: Dimitris Aragiorgis <>
Reviewed-by: Michael Hanselmann <>

e0519c34 02/26/2013 03:53 am Dimitris Aragiorgis

Add networks to _AllIDs()

networks config objects have UUIDs and thus should be included
in _AllUUIDObjects().

Signed-off-by: Dimitris Aragiorgis <>
Reviewed-by: Guido Trotter <>

5a76adf7 02/26/2013 03:53 am Dimitris Aragiorgis

Fix HooksDict() in case of no tags

In this method self.tags might be None and cannot be used
in join(). Use GetTags instead.

Signed-off-by: Dimitris Aragiorgis <>
Reviewed-by: Guido Trotter <>

6d96f116 02/26/2013 03:53 am Dimitris Aragiorgis

Fix locking in LUNetworkConnect()

Locks for group instances are aquired only if conflicts are checked.
To this end we must _CheckNodeGroupInstances() only then otherwise
this check will always fail (owned_instances will be []).

Signed-off-by: Dimitris Aragiorgis <>...

076a2938 02/26/2013 03:49 am Dimitris Aragiorgis

Fix networks in LUInstanceSetParams()

Params passed in _CreateNewNic() are not yet evaluated and include
the value passed by user for the network. A lookup must be done first
in order to find the corresponding network UUID which should be stored
in the newly created NIC object....

76eeabc7 02/20/2013 06:13 pm Dimitris Aragiorgis

Locking fixes regarding Issue 324

LUNetworkConnect/LUNetworkDisconnect, in case locking is used, might
lock instances that exist in the requested node group. The acquired
locks should be checked if they are correct at the beginning of
CheckPrereq() via _CheckNodeGroupInstances()....

5454737c 02/20/2013 05:26 pm Iustin Pop

Fix small typo in a docstring

Signed-off-by: Iustin Pop <>
Reviewed-by: Michele Tartara <>

9394f4d1 02/19/2013 07:21 pm Dimitris Aragiorgis

Minor fixes regarding change

Make LookupNetwork() return None in case target is None. This fixes
Issue 380. Rapi passes network=None and the lookup should not fail.

Make network client aware of new info shows
the IPs of each instance inside the network. It parses nic.networks...

c8f4e425 02/19/2013 06:07 pm Dimitris Aragiorgis

Fix issue 378

In case a NIC is not inside a network then netinfo None. Thus
netinfo["name"] fails.

Signed-off-by: Dimitris Aragiorgis <>
Reviewed-by: Helga Velroyen <>

View revisions

Also available in: Atom