Statistics
| Branch: | Tag: | Revision:

root / tools @ b1e81520

# Date Author Comment
3ccb3a64 02/21/2012 05:23 pm Michael Hanselmann

Replace single- with double-quotes

In at least two cases "%s" is replaced with str(), too.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

d62cbd3a 01/24/2012 03:57 pm Michael Hanselmann

fmtjson: A tool to format JSON data

While debugging an issue recently I had the pleasure of looking at a
long, single-line string of JSON data. This simple utility makes it
possible to format such data into a readable format.

Signed-off-by: Michael Hanselmann <>...

7181fba0 01/23/2012 07:53 pm Constantinos Venetsanopoulos

Implement rbd disk template

Introduce the rbd disk template, which handles provisioning and
management of instance disks as block devices mapped to rbd volumes
on a RADOS cluster.

The rbd template is of type DTS_EXT_MIRROR, meaning rbd-based
instances can failover or migrate to any node, without...

59d81cb3 01/19/2012 03:14 pm Michael Hanselmann

Merge branch 'devel-2.5'

  • devel-2.5:
    Fix wrong option names in QA and cluster-merge
    Bump version to 2.5.0~rc5, update NEWS
    Add UnescapeAndSplit unittest for multi-escapes
    Fix a bug in command line option parsing code
    cli: Disable abbreviation matching for options...
58ea8d17 01/19/2012 02:42 pm Michael Hanselmann

Fix wrong option names in QA and cluster-merge

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

6b5f0dd8 01/18/2012 06:03 pm Guido Trotter

Burnin: test set-mem

Add new --maxmem-size and --minmem-size options.
The old --mem-size option allows setting both at the same time.
If --minmem-size is lower than --maxmem-size execute a runtime memory
change on all instances, bringing them to their minimum memory size....

8bec868e 12/06/2011 02:12 pm Iustin Pop

Style fixes on confd-client

Oops, forgot to check this before initial commit, sorry!

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>

4ef0399b 12/06/2011 10:48 am Iustin Pop

Add a small confd client

This can be used to test live servers; currently there's not direct
way to interact with a confd server, except for burnin's builtin tests
(which were the source of this file).

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

37036867 11/22/2011 07:55 pm Guido Trotter

burnin: use mem_size as max and min

Signed-off-by: Guido Trotter <>
Reviewed-by: Iustin Pop <>

db3780f9 11/17/2011 03:49 pm Iustin Pop

Prevent runnning of confd tests in burnin

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

d9eefcfa 11/14/2011 05:17 pm Andrea Spadaccini

Add the default master-ip-setup script

Add a shell script that will be the default replacement for the body of
backend.ActivateMasterIp and backend.DeactivateMasterIp.

Signed-off-by: Andrea Spadaccini <>
Reviewed-by: Michael Hanselmann <>

0aee8ee9 10/18/2011 05:21 pm Guido Trotter

Revert "Implementation of TLS-protected SPICE connections"

This reverts commit b6267745ede04b3c943bc02e004bdb9347e0f564.
This commit will be readded on master.

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

00976304 10/12/2011 02:51 pm Michael Hanselmann

Merge branch 'devel-2.5'

  • devel-2.5:
    rpc: Disable HTTP client pool and reduce memory consumption
    Preserve bridge MTU in KVM ifup script
    hail: Fix result for node evacuation
    Fix assertion error on unclean master shutdown

Signed-off-by: Michael Hanselmann <>...

a1ec8695 10/11/2011 05:38 pm Andrea Spadaccini

Preserve bridge MTU in KVM ifup script

Closes: #201 - KVM_IFUP does not set bridge-MTU on tap devices
Signed-off-by: Andrea Spadaccini <>
Reviewed-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

ea9c753d 10/04/2011 09:34 pm Andrea Spadaccini

Merge branch 'devel-2.5'

  • devel-2.5:
    cluster-merge: log an info message at node readd
    Bump version to 2.5.0~rc1
    Fix issue when verifying cluster files
    Revert "utils.log: Write error messages to stderr"
    Fix adding nodes after commit 64c7b3831dc...
419bb2ef 10/04/2011 09:12 pm Guido Trotter

cluster-merge: log an info message at node readd

node readd can take a long time, it's good to have info messages to see
progress.

Signed-off-by: Guido Trotter <>
Reviewed-by: Andrea Spadaccini <>

3398bff1 09/30/2011 06:23 pm Andrea Spadaccini

Merge branch 'devel-2.5'

  • devel-2.5:
    Use --yes to deactivate master ip in cluster merge
    Use deactivate-master-ip in cluster-merge
    Add gnt-cluster commands to toggle the master IP
    Split starting and stopping master IP and daemons
    listrunner: Don't pass arguments if there are none...
cea3abbd 09/30/2011 05:45 pm Andrea Spadaccini

Merge branch 'stable-2.5' into devel-2.5

  • stable-2.5:
    listrunner: Don't pass arguments if there are none
    ssh: Quote strings in error message
    utils.log: Write error messages to stderr
    Add signal handling doc to hbal man page
    Fix handling of cluster verify hooks...
aeb24d97 09/30/2011 04:37 pm Guido Trotter

Use --yes to deactivate master ip in cluster merge

Signed-off-by: Guido Trotter <>
Reviewed-by: Andrea Spadaccini <>

a3fad332 09/30/2011 03:43 pm Andrea Spadaccini

Use deactivate-master-ip in cluster-merge

Use the gnt-cluster deactivate-master-ip command in cluster-merge to
disable the master IP.

Signed-off-by: Andrea Spadaccini <>
Reviewed-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>...

e87e5afb 09/30/2011 02:06 pm Andrea Spadaccini

Use deactivate-master-ip in cluster-merge

Use the gnt-cluster deactivate-master-ip command in cluster-merge to
disable the master IP.

Signed-off-by: Andrea Spadaccini <>
Reviewed-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

0c009cc5 09/30/2011 01:10 pm Michael Hanselmann

listrunner: Don't pass arguments if there are none

If no arguments were specified the “exec_args” variable was “None”,
leading to the command being run as “… ./… None”.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>...

ced78a66 09/26/2011 05:09 pm Agata Murawska

Initial commit for ovfconverter tool

Signed-off-by: Agata Murawska <>
Reviewed-by: Michael Hanselmann <>

b6267745 09/20/2011 05:04 pm Andrea Spadaccini

Implementation of TLS-protected SPICE connections

Added support for TLS-protected SPICE connections:

client/gnt_cluster.py, cli.py:
  • added three new parameters to renew-crypto (--new-spice-certificate,
    --spice-certificate, --spice-ca-certificate) and their validation....
6eedd356 08/30/2011 12:34 pm Michael Hanselmann

listrunner: Allow passing of arguments to executable

This wasn't possible until now.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

b459a848 08/30/2011 11:24 am Andrea Spadaccini

DeprecationWarning fixes for pylint

In version 0.21, pylint unified all the disable-* (and enable-*)
directives to disable (resp. enable). This leads to a lot of
DeprecationWarning being emitted even if one uses the recommended
version of pylint (0.21.1, as stated in devnotes.rst)....

2c094917 08/29/2011 06:37 pm Michael Hanselmann

listrunner: Replace str.split with library functions

- str.split("/").pop() should be os.path.basename
- str.split("\n") should be str.splitlines()

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

b972c223 08/26/2011 03:03 pm Andrea Spadaccini

Delete master IPs from mergee master nodes

Added a step in cluster-merge that removes the cluster IP from the
master node of the mergee clusters.

Signed-off-by: Andrea Spadaccini <>
Reviewed-by: Michael Hanselmann <>

e687ec01 08/25/2011 01:53 pm Michael Hanselmann

PEP8 style fixes

Identified using the “pep8” utility.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

b7bf8b58 08/24/2011 05:34 pm Guido Trotter

Wrap a few long lines

Had to break it as well, today! ;)

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

6bc1c168 08/24/2011 12:16 pm Michael Hanselmann

listrunner: Avoid exception if machine is rebooted

Handle exceptions gracefully when trying to read the command's output.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

7f4d4cf0 08/23/2011 02:39 pm Guido Trotter

Remove wrong type declaration from option

Signed-off-by: Guido Trotter <>
Reviewed-by: Andrea Spadaccini <>

006a51b3 08/23/2011 02:22 pm Andrea Spadaccini

Fix wrong method name in cluster-merge

Fixed a wrong method name in the last patch.

Signed-off-by: Andrea Spadaccini <>
Reviewed-by: Michael Hanselmann <>

b3f287c8 08/23/2011 12:51 pm Guido Trotter

Fix --skip-stop-instances help message

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

1fb5f905 08/23/2011 12:46 pm Andrea Spadaccini

cluster-merge: Add the --skip-stop-instances opt

This option allows to do a check for running instances on the mergee
clusters instead of stopping them.

Signed-off-by: Andrea Spadaccini <>
Signed-off-by: Guido Trotter <>...

3e22caed 08/21/2011 04:47 pm Guido Trotter

Offline node when adding it to a merged cluster

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

d47319e2 08/21/2011 04:47 pm Guido Trotter

Transform node readd exceptions into just errors

We are after the point of no return, no point in failing everything
because a node failed to readd. Better to just report it and move on.

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

cc2cccfc 08/21/2011 04:47 pm Guido Trotter

Add a TODO on the VerifyCluster option

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

07ff0a78 08/21/2011 04:47 pm Andrea Spadaccini

Allow retrying commands in cluster-merge

Signed-off-by: Andrea Spadaccini <>
Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

503cc75f 08/21/2011 04:47 pm Guido Trotter

Try 3 times before giving up on per-node commands

When contacting lots of nodes some may fail. Give it a couple more
chances before giving up on them.

Possible future TODO: continue, but just mark them as offline.

Signed-off-by: Guido Trotter <>...

f299ca21 08/19/2011 05:51 pm Michael Hanselmann

Unify some file headers

Remove unnecessary commas, add empty lines where necessary to make them
consistent.

I'm working on a script to check this, but it's not yet ready.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: René Nussbaumer <>

66a66fa7 08/17/2011 05:57 pm Michael Hanselmann

cfgupgrade: Add confirmation message

A message will be given instead of just dropping the user back to the
prompt in case of a successful upgrade.

[…]
documentation formats). Continue with upgrading configuration?
y/[n]/?: y
Configuration successfully upgraded for version 2.5.0~beta1....

bb074298 08/08/2011 03:22 pm Guido Trotter

cluster-merge: consider file storage enable state

There's no point in checking whether the file storage dir in the two
clusters is the same if file storage is not even enabled

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

1fcd3b81 08/08/2011 03:22 pm Guido Trotter

cluster-merge: implement params delta mercifulness

Sometimes it's good to tell the user about parameter differences but
then proceed anyway. Strictness is still enforced for those parameters
that would break the cluster (volume group name, storage dir if file...

9f604ab8 08/05/2011 02:11 pm Michael Hanselmann

Bump version to 2.5.0~beta1

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

2f1fe558 08/05/2011 12:48 pm René Nussbaumer

Merge branch 'stable-2.4'

Signed-off-by: René Nussbaumer <>
Reviewed-by: Iustin Pop <>

a292020f 08/04/2011 01:28 pm Michael Hanselmann

cfgupgrade: Remove old watcher state file

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

d0ffa390 08/03/2011 11:50 am Pedro Macedo

Add a flag to burnin to allow specifying VCPU count.

Signed-off-by: Pedro Macedo <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

2be7c4cc 07/26/2011 11:55 am Guido Trotter

cluster-merge: remove a hardcoded constant

Signed-off-by: Guido Trotter <>
Reviewed-by: Iustin Pop <>

620a9c62 07/26/2011 11:38 am Guido Trotter

cluster-merge: add instance restart strategy opt

Right now we always restart all instances, which is not right if some
instances were already down for other reasons. Thus we add an option to
decide how to handle this. The right default should be "up" which is:...

d2b17e37 07/26/2011 11:38 am Guido Trotter

cluster-merge: remove option list from usage

It doesn't make sense to have to keep them up to date twice, and --help
already lists all of them with help strings.

Signed-off-by: Guido Trotter <>
Reviewed-by: Iustin Pop <>

42143c5b 07/20/2011 02:41 pm Pedro Macedo

Add support for GPT by using parted for disks bigger than 2TB.

Signed-off-by: Pedro Macedo <>
Reviewed-by: Michael Hanselmann <>

61631293 07/15/2011 12:27 pm Stephen Shirley

Adding a wrapper around "xm console"

The wrapper will connect to the console, and check in the background if
the instance is paused, unpausing it as necessary.

Signed-off-by: Stephen Shirley <>
Reviewed-by: Michael Hanselmann <>

2f4c951e 07/15/2011 12:27 pm Stephen Shirley

Adding a wrapper around connecting to kvm console

The wrapper will connect to the console, and check in the background if
the instance is paused, unpausing it as necessary.

Signed-off-by: Stephen Shirley <>
Reviewed-by: Michael Hanselmann <>

7238edb5 07/11/2011 05:16 pm Iustin Pop

Reverts the patch series about console wrappers

This reverts commits 030a9cb8022b83bf43ec14dfbafd943299bc01c4 and
ae082df0000a785b693b2f4aa434650a81a94bdf.

There are two problems:

- Makefile.am breakage, which is trivial to revert
- unittest breakage, which honestly I'm not sure how to fix and how...

ae082df0 07/08/2011 03:15 pm Stephen Shirley

Adding a wrapper around connecting to kvm console

The wrapper will connect to the console, and check in the background if
the instance is paused, unpausing it as necessary.

Signed-off-by: Stephen Shirley <>
Reviewed-by: Michael Hanselmann <>

030a9cb8 07/08/2011 03:15 pm Stephen Shirley

Adding a wrapper around "xm console"

The wrapper will connect to the console, and check in the background if
the instance is paused, unpausing it as necessary.

Signed-off-by: Stephen Shirley <>
Reviewed-by: Michael Hanselmann <>

af7b6689 04/07/2011 01:24 pm Michael Hanselmann

Merge branch 'devel-2.4'

  • devel-2.4:
    LUInstanceQueryData: Don't acquire locks unless requested
    Increase the lock timeouts before we block-acquire
    daemon.py: move startup log message before prep_fn
    Display the actual memory values in N+1 failures...
76ae1d65 04/07/2011 12:46 pm Michael Hanselmann

Merge branch 'stable-2.4' into devel-2.4

  • stable-2.4:
    Add error checking and merging for cluster params
    Clarify --force-join parameter message
    Treat empty oob_program param as default
    Fix bug in instance listing with orphan instances
    Fix bug related to log opening failures...
a6c8fd10 03/28/2011 12:54 pm Stephen Shirley

Add error checking and merging for cluster params

Set the default stderr logging level to WARNING so the relevant output
can be seen.

Signed-off-by: Stephen Shirley <>
Reviewed-by: René Nussbaumer <>

959b6fe5 03/18/2011 04:42 pm Apollon Oikonomopoulos

cfgupgrade: really ignore hostname when told so

cfgupgrade provides a --ignore-hostname option, however consequently it
spawns config.ConfigWriter, which refuses to handle a foreign
configuration file by default.

config.ConfigWriter provides a relative keyword argument,...

8864d152 03/11/2011 07:06 pm Guido Trotter

Revert "Only merge nodes that are known to not be offline"

This reverts commit 288f240f62dafa8bd8ba7482c8367adbdf6d96c2.

That commit was buggy at various levels:
- broke ssh access to the second cluster, making cluster-merge
unusable (unless ssh key were previously setup?)...

8697f0fa 03/11/2011 07:06 pm Guido Trotter

cluster-merge: only operate on online nodes

The node list in MergerData is used only to:
- stop ganeti on the nodes
- readd the nodes to the cluster
As such offline nodes should be skipped from it.

Signed-off-by: Guido Trotter <>...

288f240f 03/10/2011 06:36 pm Stephen Shirley

Only merge nodes that are known to not be offline

Otherwise the readd will fail, breaking the merge.

Signed-off-by: Stephen Shirley <>
Reviewed-by: Iustin Pop <>

87c80992 03/08/2011 07:26 pm Michael Hanselmann

cfgupgrade: Fix critical bug overwriting RAPI users file

The cfgupgrade tool was designed to be idempotent, that means it could
be run several times and still give produce the correct result. Ganeti
2.4 moved the file containing the RAPI users to a separate directory...

9869360c 03/08/2011 02:01 pm Apollon Oikonomopoulos

Shared file support for tools/burnin

Make burnin work with -t sharedfile and update burnin's help.

Shared block storage support is not included, as currently there is no way to
provision shared block storage from within Ganeti.

Signed-off-by: Apollon Oikonomopoulos <>...

3429a076 03/08/2011 02:01 pm Apollon Oikonomopoulos

Rename DTS_NET_MIRROR to DTS_INT_MIRROR

DTS_INT_MIRROR better contrasts DTS_EXT_MIRROR.

Signed-off-by: Apollon Oikonomopoulos <>
[: updated patch for changed context]
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

99e92fa0 03/02/2011 11:59 am Michael Hanselmann

Fix typo in kvm-ifup script

Reported-by: Bas Tichelaar <>
Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

9b945588 02/18/2011 06:09 pm Stephen Shirley

Fix pylint warnings

- 1 80-char line infraction
- 4 changes in how arguments are passed to logging functions
- 3 pylint disable-msg's because cluster-merge needs to access ganeti
config internals

Signed-off-by: Stephen Shirley <>
Signed-off-by: Guido Trotter <>...

3a969900 02/18/2011 04:46 pm Stephen Shirley

Add support for merging node groups

Signed-off-by: Stephen Shirley <>
Reviewed-by: Michael Hanselmann <>

1a615be0 02/18/2011 04:46 pm Stephen Shirley

Add option to rename groups on conflict

Signed-off-by: Stephen Shirley <>
Reviewed-by: Michael Hanselmann <>

98632c4f 02/17/2011 12:09 pm Stephen Shirley

Don't remove master_candidate flag from merged nodes

Prevents lots of spurious warnings like:
2011-02-10 17:00:22,776: CRITICAL Configuration data is not consistent:
Not enough master candidates: actual 3, target 4

Signed-off-by: Stephen Shirley <>...

a536aaac 02/17/2011 12:09 pm Stephen Shirley

Use a consistent ECID base

ECID was being calculated completely differently in
__MergeNodeGroups() and _MergeConfig()

Signed-off-by: Stephen Shirley <>
Reviewed-by: Michael Hanselmann <>

b74c0684 02/16/2011 06:35 pm Iustin Pop

listrunner: convert from getopt to optparse

The “-A” (use agent) was not documented, and instead of adding manual
listing, I converted it to optparse like the other CLI tools.

Note that I cleaned up a bit the usage and help texts.

Signed-off-by: Iustin Pop <>...

99a11adc 02/16/2011 06:35 pm Iustin Pop

listrunner: fix agent usage

By delaying the agent key query until after the fork, we prevent the
problem of simultaneous access to the agent.

Tested that it works against 80 hosts in parallel without error; the
current version breaks already at 20 hosts....

3d8f154f 02/14/2011 01:19 pm Stephen Shirley

Revert "Disable the cluster-merge tool for the moment"

This reverts commit c0711f2cb989facd60430ab18c5b0e59a1f279ac.

Signed-off-by: Stephen Shirley <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

9c03a67a 02/14/2011 01:18 pm Stephen Shirley

Fix cluster-merging by not stopping noded

cli.RunWhileClusterStopped() stops noded on all of the nodes in the
original cluster. This prevents /etc/hosts updates on the master, and
config redistribution doesn't reach the other nodes in the original
cluster. As all we want to do is merge while the master is stopped,...

3d2e7a27 02/09/2011 10:56 am Stephen Shirley

Minor reordering to match param order

Signed-off-by: Stephen Shirley <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

53991408 02/04/2011 04:23 pm Stephen Shirley

Use gnt-node add --force-join to add foreign nodes

Signed-off-by: Stephen Shirley <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

6323e232 02/04/2011 04:20 pm Stephen Shirley

Fix iterating over node groups

Current line tries to unpack dict incorrectly

Signed-off-by: Stephen Shirley <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

c0711f2c 02/04/2011 12:12 pm Iustin Pop

Disable the cluster-merge tool for the moment

Hopefully this can be fixed before the final 2.4 release…

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>
Reviewed-by: Stephen Shirley <>

cfcc79c6 02/02/2011 06:02 pm Michael Hanselmann

utils.SetupLogging: Make program a mandatory argument

It's passed in by most users (daemons, CLI scripts) and for the others
(burnin, watcher) it certainly doesn't hurt, especially when using
syslog.

Signed-off-by: Michael Hanselmann <>...

3f17ef02 02/02/2011 05:57 pm Michael Hanselmann

burner: Trivial code cleanup

- Use constant for exit value
- Configure logging from main function, not from class' “__init__”

Signed-off-by: Michael Hanselmann <>
Reviewed-by: René Nussbaumer <>

ddfde77e 02/02/2011 05:57 pm Michael Hanselmann

burnin: Reuse existing function for debug value

Instead of using its own, burnin can use cli.SetGenericOpcodeOpts.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: René Nussbaumer <>

8f44674f 02/01/2011 02:15 pm Stephen Shirley

Merge node groups from other cluster

Signed-off-by: Stephen Shirley <>
Reviewed-by: René Nussbaumer <>

71bbe910 01/31/2011 05:38 pm Stephen Shirley

Fix grammar of var naming

flatten is the verb, flattened is the adjective.

Signed-off-by: Stephen Shirley <>
Reviewed-by: Michael Hanselmann <>

be8aecab 01/31/2011 05:38 pm Stephen Shirley

cluster-merge should refuse to merge own cluster

Also fix type of Merger.cluster_name from list to string. This would
have triggered an error in sshRunner if cluster keys were in use.

Signed-off-by: Stephen Shirley <>
Reviewed-by: Guido Trotter <>

e1ab08db 01/27/2011 05:38 pm Stephen Shirley

Open other clusters' config in foreign mode

Signed-off-by: Stephen Shirley <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

caedacde 01/27/2011 05:36 pm Stephen Shirley

Add (unused) arg to _OfflineClusterMerge

cli._RunWhileClusterStoppedHelper.Call passes (self, *args) to functions
called via cli.RunWhileClusterStoppedHelper(). The code in cluster-merge
was broken by commit d8aab233.

Signed-off-by: Stephen Shirley <>...

996f742d 01/26/2011 12:38 pm Iustin Pop

lvmstrap: fix logic bug for partition reread

The if structure in CheckReread is broken, and makes partitions reread
be full of race issues (esp. after updating them).

Also fix a small message bug.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

1ca54b6e 01/20/2011 02:05 pm Iustin Pop

lvmstrap: fix very old contact information

A memory from the past: this was left over from before the 1.2 release
or so…

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

6714256c 01/20/2011 02:05 pm Iustin Pop

lvmstrap: add more excluded FS types

Also moves the list of excluded types to the top level and make it a
frozenset.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

5e861051 01/20/2011 02:05 pm Iustin Pop

lvmstrap: add an explicit test for mounted devices

Recent kernels/userland report a mounted filesystem as follows:

root@node4:~# fuser -avm /dev/sda5
USER PID ACCESS COMMAND
/dev/sda5: root kernel mount /srv/ganeti...
705ee6df 01/20/2011 02:05 pm Iustin Pop

lvmstrap: add explicit test for swap backends

Similar to mounted filesystems, recent kernel/userland report swap
backends:

root@node4:~# fuser -avm /dev/sda6
USER PID ACCESS COMMAND
/dev/sda6: root kernel swap /dev/sda6...
add478b5 01/20/2011 02:05 pm Iustin Pop

lvmstrap: ignore small-sized partitions

This patch changes lvmstrap to ignore “small” partitions. Currently
extended partitions are reported as unused as with a size of 1024
(bytes), and this confuses lvmstrap. Since a very small partition
won't help anyway (below hundred of PE size is not helpful), let's...

7706fdd4 01/20/2011 02:05 pm Iustin Pop

lvmstrap: abstract a little the sysfs paths

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

0ae0663d 01/20/2011 02:05 pm Iustin Pop

lvmstrap: add PV-on-partition support

This is a not-so-nice change, adding support for partitions to be used
as PVs.

The not-nice part is that partitions live in a separate place in
sysfs, whereas in dev they live at the same level as disks. We
workaround this via a new SysfsName function that computes the correct...

26916aad 01/18/2011 02:55 pm Apollon Oikonomopoulos

Ship default kvm-ifup script

In order to retain backwards compatibility, we ship the shell script previously
generated by _WriteNetScript as a stand-alone script under PKGLIBDIR.

Signed-off-by: Apollon Oikonomopoulos <>
Signed-off-by: Guido Trotter <>...

2237687b 01/18/2011 01:47 pm Iustin Pop

Rename OpQueryNodes and LUQueryNodes

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>
Reviewed-by: Michael Hanselmann <>

da2d02e7 01/18/2011 01:47 pm Iustin Pop

Rename OpDiagnoseOS and LUDiagnoseOS

Signed-off-by: Iustin Pop <>
Reviewed-by: René Nussbaumer <>
Reviewed-by: Michael Hanselmann <>