Statistics
| Branch: | Tag: | Revision:

root @ d46c9fd6

# Date Author Comment
d46c9fd6 01/15/2013 05:17 pm Dato Simó

test/Types.hs: add an HLint ANN for ignoring camelCase

Signed-off-by: Dato Simó <>
Reviewed-by: Iustin Pop <>

5ce58234 01/15/2013 04:43 pm Michael Hanselmann

Link man pages in documentation

This patch depends on “Option to include man pages in documentation”. In
the documentation build including man pages, all “:manpage:`…`”
references are converted to links. For man pages not provided by Ganeti,
Sphinx' standard formatting is used....

a7f0953a 01/15/2013 04:27 pm Iustin Pop

Make niceSort a wrapper over niceSortKey id

Currently, niceSort behaves differently than niceSortKey in cases
where the parsed groups are equal but the original not, as it uses
both members of the tuple as opposed to just the first one. Both
niceSortKey and the Python code use only the first one, so in corner...

96b28307 01/15/2013 04:26 pm Michael Hanselmann

Add version check for Sphinx

Sphinx 1.0 and above can check version by setting “needs_sphinx” in the
configuration.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

41806ef4 01/15/2013 04:24 pm Michael Hanselmann

Option to include man pages in documentation

Before this patch, HTML versions of man pages (man/*.rst) were already
built. However, since they are separate from the normal documentation,
their content is not indexed for Sphinx' search functionality.
Additionally it would simply be nice to have everything in one place....

6d675203 01/15/2013 03:16 pm Dato Simó

design-autorepair.rst: separate list of jobs with plus sign

Commas are not valid characters in tags, hence they can't be use to
separate the different job IDs; plus signs (+) are available, and not too
bad.

Signed-off-by: Dato Simó <>
Reviewed-by: Iustin Pop <>

42959a7f 01/15/2013 01:18 pm Michael Hanselmann

burnin: Disk template option cleanup

Burnin doesn't support all disk templates (specifically it doesn't
support “blockdev”). The code, however, used manually composed lists in
some places, constants.DISK_TEMPLATES in others, and an internal list of
supported templates in some....

d8378091 01/15/2013 01:18 pm Michael Hanselmann

burnin: Factorize disk template lists

Keep the lists at the top instead of having them embedded in the code.
Use frozenset, too.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

2f3a3365 01/15/2013 11:42 am Helga Velroyen

Replace nodegroups' PartialNic by PartialNicParams

This fixes a bug that corrups the config when one adds a
network to a node group. I wil soon extend QA by some commands
that would have detected this.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Guido Trotter <>

ef947a42 01/14/2013 05:54 pm Dato Simó

Loader.hs: ignore expired ArSuspended policies

At the moment, because 'mergeData' is pure, it may set instance auto-repair
policies that are of the form `ArSuspended $ Until timestamp_in_the_past`.
If later on the auto-repair tool notices this, it has lost access to what...

e79f576c 01/14/2013 05:54 pm Dato Simó

Loader.hs: rewrite extractExTags to use chompPrefix

Signed-off-by: Dato Simó <>
Reviewed-by: Iustin Pop <>

b1eb71c7 01/14/2013 05:54 pm Dato Simó

design-autorepair.rst: clarify tag precedence and conflict

This commit clarifies one particular point of the auto-repair workflow:
what to do when multiple, conflicting administrator-set tags exist in an
object; and how tags at different levels (cluster, node group and instance)...

55416810 01/14/2013 05:54 pm Dato Simó

Loader.hs: set instance auto-repair policy in mergeData

'getArPolicy' and 'setArPolicy' follow the precedence rules introduced in
b1eb71c: within an object, the most restrictive tag wins; across object,
the nearest tag wins.

Signed-off-by: Dato Simó <>...

23594127 01/14/2013 05:54 pm Dato Simó

Instance.hs: add an 'arPolicy' field for auto-repair policy

Signed-off-by: Dato Simó <>
Reviewed-by: Iustin Pop <>

b6aeda4a 01/14/2013 05:54 pm Dato Simó

Utils.hs: add a clockTimeToString function

This function allows to easily convert a ClockTime object to a string
representation of its timestamp (seconds-only).

Signed-off-by: Dato Simó <>
Reviewed-by: Iustin Pop <>

b009f682 01/14/2013 05:54 pm Dato Simó

Utils.hs: function to chomp prefix + separator from a string

Some auto-repair tags are composed of a prefix and then an optional
argument; the new "chompPrefix" function in Utils.hs allows to strip a
prefix, allowing the last character (the separator) to be absent if there...

819358e1 01/14/2013 05:54 pm Dato Simó

design-autorepair.rst: add a graph with state transitions

The graph added here follows the data types introduced in 7ec2f76, by which
"Suspended" is not a state, but a possible value of the auto-repair policy.

Signed-off-by: Dato Simó <>
Reviewed-by: Iustin Pop <>

3e77a36c 01/14/2013 05:52 pm Dato Simó

Add initial constants and Haskell ADTs for auto repair

In this commit, the AutoRepairType and AutoRepairResult types are defined,
with the possible values specified in doc/design-autorepair.rst.

Signed-off-by: Dato Simó <>
Reviewed-by: Iustin Pop <>

7ec2f76b 01/14/2013 05:52 pm Dato Simó

HTools/Types.hs: more auto-repair types

AutoRepairPolicy, AutoRepairStatus, and other auxiliary types are added.
These are used only internally by the auto-repair tool, and parsed from the
various object tags as defined in the design doc.

Signed-off-by: Dato Simó <>...

e47e51a8 01/14/2013 05:52 pm Dato Simó

design-autorepair.rst: use the same prefix everywhere

This commit changes the "ganeti:watcher:repair:pending" and
"ganeti:watcher:repair:result" tag prefixes to use
"ganeti:watcher:autorepair:{pending,result}", so that the same prefix is
used in all cases....

b3a6a525 01/14/2013 05:31 pm Michael Hanselmann

NEWS: Fix referenced man page's section number

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

eb7a6965 01/14/2013 05:27 pm Guido Trotter

kvm: add two help dump files

One is the --help output for kvm 1.1.2 and the second one is the same as
0.9.1 but with a fake option added between -drive and its boot=on|off
option: this tests that if boot=on|off appears in another option after
-drive it is not accepted by our regexp....

909948f1 01/14/2013 05:19 pm Michael Hanselmann

Update copyright in documentation

Use range() instead of building the list manually. Keeps the code
shorter starting next year.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>
Reviewed-and-lolled-by: Iustin Pop <>

7f83345f 01/14/2013 04:36 pm Guido Trotter

kvm: simplify _GetMachineVersion

Use a multiline regexp rather than a single line one, and then split
lines in the code.

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

2fddb144 01/14/2013 04:36 pm Guido Trotter

Allow -soundhw option to kvm

For all of us that love to listen to music on our kvm virtual machines,
the -soundhw option is paramount.

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

156681c1 01/14/2013 04:36 pm Guido Trotter

kvm: support usb devices

All in one go, comma separated usb devices of all types.

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

e6f24d89 01/14/2013 04:36 pm Guido Trotter

kvm: Add kvm_extra parameter

As requested in Issue 261 and many other times.

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

7589346f 01/14/2013 04:36 pm Guido Trotter

kvm: Add -vga option

As requested in Issue 69.

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

0ad7f5d8 01/14/2013 04:23 pm Guido Trotter

kvm: use help based feature detection

As discussed on the list some people backport features to different kvm
versions, making the version based detection system unreliable. We
change wherever we can to detection on the help output.

This also fixes Issue 250...

2c368f28 01/14/2013 04:03 pm Guido Trotter

Add a non negative int hypervisor parameter check

...and use it for a few parameters for which it makes sense.

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

a900a30c 01/14/2013 04:03 pm Guido Trotter

kvm: always pass -usb

This will be the default anyway and it was a mistake to pass it only if
the mouse was specified.

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

e3b89628 01/14/2013 04:03 pm Guido Trotter

kvm: abstract getting --help output

This will be used later, for now nothing changes.

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

4888a609 01/14/2013 04:03 pm Guido Trotter

kvm: allow setting smp cores, threads, sockets

This was requested in Issue 322.
Note that maxcpus is not implemented yet, as it should be considered in
a cpu-hotplug global context.

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

14fd6c81 01/14/2013 12:54 pm Guido Trotter

kvm: add serial console speed

The serial port speed changed between versions of qemu (what didn't?), so
the old hardcoded default doesn't do anymore. Upgrade it to a parameter.

Signed-off-by: Guido Trotter <>
Reviewed-by: Michael Hanselmann <>

83951b04 01/14/2013 11:35 am Michael Hanselmann

Merge branch 'devel-2.6'

  • devel-2.6:
    QA: Use instance name for rename test

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

223b7cf4 01/14/2013 10:26 am Michael Hanselmann

Merge branch 'stable-2.6' into devel-2.6

  • stable-2.6:
    QA: Use instance name for rename test

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

69bc7a38 01/11/2013 06:17 pm Michael Hanselmann

QA: Use instance name for rename test

Reported in issue 341. In some setups the instance live in a different
netblock from the cluster. Therefore a the configuration-global “rename”
name shouldn't be used for them. Instead another instance name is used.
...

60a7335b 01/11/2013 06:16 pm Dimitris Aragiorgis

Add locking to _NetworkQuery

Make use of _GetNames() to get the final network UUIDs.
Get networks info after having aquired the locks. Refactor
the code to use new local variables:

- "network_uuids" returned from _GetNames()
- "all_networks" that are the latest network info...
b4d2d2cb 01/11/2013 05:37 pm Michael Hanselmann

QA: Factorize retrieving non-existent groups from config

Also add a check to make sure there are enough groups defined.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

7cf58cad 01/10/2013 03:21 pm Michael Hanselmann

Generate documentation from build directory

When man pages should be included they need to be copied from man/*.rst.
This means documentation can no longer be built from the static reST
files alone (which are referenced using “abs_top_srcdir”). Similar to...

e6ba3320 01/10/2013 03:11 pm Dimitris Aragiorgis

Add machine version in kvm runtime file

kvm -M ? returns the supported machines (e.g. pc-1.1).
Add _GetDefaultMachineVersion() function to get the default value.

Upon kvm runtime file creation (this is in _GenerateKVMRuntime() invoked
only in StartInstance()) append this info in kvm_cmd. During...

c816a371 01/10/2013 02:44 pm Michele Tartara

Fix typo in the DRBD parser types file

A missing letter has been added to a docstring.

Signed-off-by: Michele Tartara <>
Reviewed-by: Michael Hanselmann <>

58997abb 01/10/2013 01:36 pm Michael Hanselmann

Add script to check man page references

This script checks for some of the most obvious mistakes when formatting
man page references (which should have the form “**ganeti**\(7)”). While
this works now, it is very hard to avoid ambiguities (e.g. references...

354c4f62 01/10/2013 01:34 pm Michael Hanselmann

man: Man page reference cleanup

Sphinx is stricter than pandoc when parsing reST and does not allow an
opening parenthesis to directly follow inline markup. [1] describes the
rules. A backslash, as described in [2], can be used to separate the
two.

Additionally, there were different forms for referring to man pages....

f1f6f117 01/09/2013 07:17 pm Dato Simó

test/Utils.hs: fix capitalization in docstring comment

Signed-off-by: Dato Simó <>
Reviewed-by: Iustin Pop <>

0df54fd2 01/09/2013 06:39 pm Guido Trotter

Merge branch 'devel-2.6'

  • devel-2.6:
    Add utility to format dictionary as key=value strings
    Remove fixed FIXME
    QA: Support master-netdev and default NIC parameters
    QA: Do not pass "--bridge" to "gnt-cluster init"

Signed-off-by: Guido Trotter <>...

30fa4476 01/09/2013 06:30 pm Guido Trotter

Merge branch 'stable-2.6' into devel-2.6

  • stable-2.6:
    Add utility to format dictionary as key=value strings
    Remove fixed FIXME
    QA: Support master-netdev and default NIC parameters
    QA: Do not pass "--bridge" to "gnt-cluster init"

Signed-off-by: Guido Trotter <>...

63b883de 01/09/2013 05:57 pm Michael Hanselmann

Add utility to format dictionary as key=value strings

This will be used in QA to format network interface parameters.

This is a cherry-pick of master commit eac9b7b8

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

22ac4136 01/09/2013 05:38 pm Michael Hanselmann

More documentation and man page fixes

- Include numbers in man page references
- Use “:manpage:” where appropriate
- Don't escape underscore in verbatim text (e.g. “``always_failover``)
as it would show up in the generated man page
- Quote whole paths, not just build-time part...

dbb4f850 01/09/2013 05:23 pm Guido Trotter

Remove fixed FIXME

This was fixed in stable-2.6, commit 053c356

Signed-off-by: Guido Trotter <>
Reviewed-by: Iustin Pop <>

c12e30ca 01/09/2013 05:21 pm Guido Trotter

Remove fixed FIXME

This was fixed in stable-2.6, commit 053c356

Signed-off-by: Guido Trotter <>
Reviewed-by: Iustin Pop <>

558e2e8a 01/09/2013 05:20 pm Michael Hanselmann

QA: Support master-netdev and default NIC parameters

Requested in issue 337.

The parameter “bridge” was not documented and is therefore silently
replaced with “master-netdev”. A note is added to “qa-sample.json”
describing how comments work.

This is a cherry-pick of master commit...

cbf5114e 01/09/2013 05:20 pm Michael Hanselmann

QA: Do not pass "--bridge" to "gnt-cluster init"

Commit ec0652a (June 2009) removed the option.

This is a cherry-pick of master commit
784537390cd5b1c4f5f8fb9401a62eb23acce39b

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

596f913e 01/09/2013 03:19 pm Michael Hanselmann

Makefile: Fix list of directories

Commit dbee5c9 had a wrong path.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Helga Velroyen <>

dbee5c92 01/09/2013 01:42 pm Michael Hanselmann

Highlight external links in HTML documentation

Based on MediaWiki's monobook skin.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

23d95cff 01/09/2013 12:48 pm Bernardo Dal Seno

Unit tests for bdev and utils.lvm

Also amended a comment of a tested method.
The tests are for methods introduced in commit 63c73073 (LVM disk creation
uses dedicated PVs).

Signed-off-by: Bernardo Dal Seno <>
Reviewed-by: Michael Hanselmann <>

9ef3e121 01/09/2013 11:05 am Michele Tartara

Update the monitoring agent design document

This commit updates the design document of the monitoring agent according
to what has already been discussed in various meetings and email threads.

Signed-off-by: Michele Tartara <>
Reviewed-by: Iustin Pop <>

d78970ba 01/08/2013 06:16 pm Michele Tartara

Support instance-minor pairing in the DRBD collector

This commits enables the DRBD data collector to use the Confd client to
gather information about the pairing between DRBD minors and instances.

For testing purposes, the DRBD data collector now requires either zero...

eb62691c 01/08/2013 06:16 pm Michele Tartara

Support integrating instance information in the DRBD parser

This commit modifies the DRBD parser and its data structures to include
information about the instance a DRBD minor belongs to.

Test files have been updated as well, to support the new field in the data...

d4d94eee 01/08/2013 05:21 pm Michael Hanselmann

NEWS: Add missing parenthesis

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Michele Tartara <>

37cfb91f 01/08/2013 01:23 pm Michael Hanselmann

Add footer.rst as a dependency for all man pages

Commit 6aff051 removed an intermediate step, but forgot to add
“footer.rst” as a direct dependency.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

3784c431 01/08/2013 11:28 am Yiannis Tsiouris

Update name of test/htest in doc/devnotes.rst

Update the docs after the rename of 'test/hs/test' to
'test/hs/htest'. This must have been forgotten in 3e16567e.

Signed-off-by: Yiannis Tsiouris <>
Signed-off-by: Iustin Pop <>...

29fc0e4e 01/08/2013 11:28 am Iustin Pop

Fix a couple of bugs in the gnt-instance man page

The "list-fields" and "change-group" commands were mistakenly listed
as sections; we also rename the "Recovery" section to match better its
content.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

fa5121f0 01/08/2013 11:28 am Iustin Pop

Fix "Tags" section capitalisation in the man pages

"Tags" is a section, not a command, so let's title-case it (as opposed
to all upper-case). Furthermore, the RST markup was wrong for the
gnt-network man page.

Signed-off-by: Iustin Pop <>...

93e09cb7 01/08/2013 11:28 am Iustin Pop

Convert gnt-os man page to sections

As Constantinos observed, the gnt-os man page is not consistent with the
others. This patch adds the missing sections.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

fe7ad9c8 01/08/2013 11:28 am Iustin Pop

Improve a bit Haskell library recommended versions

The hinotify library was missing any versions, and finding one that
works with ghc 6.12 (base 4.2.x) was not obvious. The
test-framework-quickcheck2 recommended version didn't actually work
with the test-framework version, so fix that as well....

6aff0514 01/08/2013 11:28 am Iustin Pop

Remove intermediate footer.man/footer.html files

I don't remember why I introduced these when switching to pandoc, but
they are not absolutely needed. Instead of pre-generating them (which
might save some trivial cpu time), we can simply pass footer.rst as an...

74412d69 01/08/2013 11:28 am Iustin Pop

Enable a table of contents for the html version of man pages

This makes the (very dull) html version of the man pages a bit more
readable, until such a time that we can switch over to sphinx fully.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

7322bf7b 01/08/2013 11:28 am Iustin Pop

Rearrange tags in gnt-cluster/gnt-node

This patch makes the gnt-cluster and gnt-node man page more consistent
with the other man pages, where the tag commands are listed in a
separate section at the end.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

f8e233a3 01/08/2013 11:28 am Iustin Pop

Stop manually building images out of dot files

The first dot files we added way back in the 2.0 release are managed
manually: we build the .pngs ourselves, track them in .gitingore,
etc. Since then, we have switched to allow sphinx to build/manage them
itself, so it makes sense to cleanup the build system and covert...

8fa74099 01/08/2013 11:28 am Iustin Pop

Inline the standalone dot files

This removes entirely the standalone dot files by inlining them in the
RST documents - as they weren't referenced from more than one document
either way.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

6210c812 01/08/2013 11:28 am Iustin Pop

Remove some obsolete entries from .gitignore

Found while doing the previous .dot file changes and wondering what's
this "doc/*.in" stuff… it looks like these were obsoleted over the
years by not paying attention on cleanup patches:

- doc/build: obsoleted by commit 13de7d59...

7ce2f8ee 01/08/2013 11:26 am Michele Tartara

Fix a bug in the generation of completion information

Completion information for multi-command binaries were not generated in
the correct way, so the build-bash-complation script failed when such a
binary was actually found.

This commit fixes this issue, and a related docstring typo as well....

c46a9ffb 01/07/2013 08:56 pm Michael Hanselmann

Add small webserver for development

When working on documentation it can be helpful to use a browser. In
some environments it's not possible to access the files directly from a
graphical browser. This trivial webserver exports all files in the
current directory and unlike alternatives such as thttpd, doesn't check...

3a817255 01/07/2013 08:56 pm Michael Hanselmann

man pages: Lowercase name for syntax highlighting

When the man pages' reST is built using Sphinx, “bash” must be used
instead of “Bash”. Pandoc works with both.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

8d459129 01/07/2013 07:00 pm Michael Hanselmann

Add "use_locking" parameter to network query opcode

This was extracted from a patch by Dimitris Aragiorgis with the subject
“Add locking to _NetworkQuery”. The rest of the patch did no longer
apply and will require more work.

Signed-off-by: Michael Hanselmann <>...

27a19bf6 01/07/2013 04:21 pm Michael Hanselmann

Makefile.am: Add missing space

Commit acaf3ca missed this space before a backslash.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

6249f1c2 01/04/2013 04:42 pm Michele Tartara

Fix the installation location of mon-collector

The mon-collector binary was erroneously installed twice: once in
/usr/bin/ and once in /usr/lib/ganeti/.
With this modification, it is now installed in /usr/lib/ganeti/ only,
as intended.

In order to do this in a proper way, some parts of the Makefile.am where...

2663321c 01/04/2013 10:47 am Michele Tartara

Improve the reception of replies in the confd client

If a received reply is valid and there is still no valid reply,
keep it, no matter how new it is.

Signed-off-by: Michele Tartara <>
Reviewed-by: Guido Trotter <>

855f9bad 12/28/2012 05:53 pm Constantinos Venetsanopoulos

Document the ExtStorage `SetInfo' functionality

Small updates to the extstorage design document and interface.

Signed-off-by: Constantinos Venetsanopoulos <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

ef13148c 12/28/2012 05:51 pm Constantinos Venetsanopoulos

gnt-storage man page: make commands sub-sections

This makes the man page more consistent with the others (except
gnt-os, that is).

Signed-off-by: Constantinos Venetsanopoulos <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

f6b9c6e5 12/28/2012 05:50 pm Iustin Pop

Fix a bad data type in Hcheck.hs

While trying to understand why some code was not being tested, I
realised that we have a bad data type in Hcheck.hs.

We have "data Level = GroupLvl | ClusterLvl", but then we need to pass
the group name/index as well, so we have functions that look like the...

2fd5a116 12/28/2012 05:50 pm Iustin Pop

Move src/Ganeti/HTools/Program.hs to Program/Main.hs

This removes one more tab conflict; this is the last module in our
code where we have both x.hs and x/.

Furthermore, we collapse all actual code into the new Main.hs module,
leaving the htools.hs basically empty (will allow better testing in...

208b02e3 12/27/2012 03:35 pm Iustin Pop

A bit more name cleanup

- gen-coverage → gen-py-coverage
- coverage-htools.tix → coverage-hs.tix

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

784e77f0 12/27/2012 03:34 pm Iustin Pop

Split the hs-check test rule

Currently, both the unit test and the shell tests are run (manually)
from this rule. This has two downsides: you can't (compile and) run
just one of them easily, and make can't run them in parallel.

By splitting the rules, we can both of the above easily....

1c0f9d12 12/27/2012 03:34 pm Iustin Pop

Remove duplicate test file functions

This patch unifies the functions that generated the tree
reorganisation discussion in the first place :)

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

3e16567e 12/27/2012 03:34 pm Iustin Pop

Rename test/hs/test to htest

The current base name of 'test' means that this binary will generate
profiling, coverage, etc. files with the name 'test.*', result in
tab-completion conflicts with the test directory. Let's slightly
change its base name for typing easiness....

83846468 12/27/2012 03:34 pm Iustin Pop

Move htest/ files under the test/ tree

htest/data becomes test/data/htools (basically reverting commit
8feabc89), and htest/* becomes test/hs/*.

Most changes beside the rename are trivial s/…/…, with the exception
of autotools/run-in-tempdir, which needed some more changes now that...

90066780 12/27/2012 03:34 pm Iustin Pop

Move python test files to test/py

This is the first step of the test files reorganisation: moving test/*
(except test/data) to new directory test/py/.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

19e1b715 12/27/2012 03:33 pm Iustin Pop

Return master ip script output in case of failure

Currently only the exit code is returned, which is somewhat pointless:
for failures, we already know it's ≠ 0, so we don't have enough
information (reported on the mailing list). By logging the output as
well (if any), the user will have more information available for...

d9a900dc 12/27/2012 03:33 pm Iustin Pop

Replace htools→hs in configure/makefile rules

This continues the cleanup of the 'htools' name, by replacing 'htools'
with 'hs' in configure and makefile rules.

There is still 'WANT_HTOOLS' left as it is correct, but some of the
conditionals in Makefile.am will need some cleanup (in a different...

8775e62a 12/27/2012 03:33 pm Iustin Pop

Fix LUInstanceRecreateDisks with iallocator

Recent iallocator changes (commit fb60bc6a, “iallocator: Add node
whitelist”) broke the parameter validation for LUInstanceRecreateDisks
(the other LUs were manually fixed already):

$ gnt-instance recreate-disks -I hail --dry-run instance3...
8775b5b2 12/27/2012 03:32 pm Iustin Pop

Fix dependency on built python sources for hs-check

Since we call into Python for opcodes and other type compatibility
checks, we need to ensure that the python sources are
built. Otherwise, full parallel make might or might not break,
depending on timing....

3add7574 12/24/2012 11:38 pm Iustin Pop

Rename htools/ to src/

Per offline discussions, this is the first patch of the
renames. Tested with "make distcheck", seems to work fine.

The only change outside of the renaming is a bit of simplification in
the .gitignore rules; otherwise, simply s/htools/src/....

75b32fff 12/22/2012 08:11 pm Iustin Pop

Optimise autotools/run-in-tempdir

I made a mistake when adding support for htools to run-in-tempdir, by
needlessly copying the htools binaries, when it's enough to link
them. The copying is only really needed for python code, so we change
the Haskell binaries to linking and also a few other directories....

acaf3ca7 12/22/2012 08:11 pm Iustin Pop

Fix building of Constants.hs w.r.t .pyc files

Unless this is run under run-in-tempdir, it will create as usual the
.pyc files.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

b954f097 12/22/2012 11:47 am Constantinos Venetsanopoulos

Add the gnt-storage client

Add a new client called 'gnt-storage'.
The client interacts with the ExtStorage interface, similarly to
the way gnt-os interacts with the OS interface.

For now, only two commands are supported: 'info' and 'diagnose'.

'diagnose' calculates the node status of each provider on each node,...

95b92c34 12/22/2012 11:47 am Constantinos Venetsanopoulos

Add ExtStorage related man pages

  • ganeti-extstorage-interface man page
  • gnt-storage man page

Signed-off-by: Constantinos Venetsanopoulos <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

c64c3854 12/22/2012 09:40 am Iustin Pop

Extend the hcheck shell tests

This adds a few new hcheck tests, to extend the coverage.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

591fa888 12/22/2012 09:40 am Iustin Pop

Extend the hbal shell tests

After this patch, almost all of hbal except the actual Luxi execution
is being covered by unit- or shelltests.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>