Statistics
| Branch: | Tag: | Revision:

root @ dbb4f850

# Date Author Comment
dbb4f850 01/09/2013 05:23 pm Guido Trotter

Remove fixed FIXME

This was fixed in stable-2.6, commit 053c356

Signed-off-by: Guido Trotter <>
Reviewed-by: Iustin Pop <>

596f913e 01/09/2013 03:19 pm Michael Hanselmann

Makefile: Fix list of directories

Commit dbee5c9 had a wrong path.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Helga Velroyen <>

dbee5c92 01/09/2013 01:42 pm Michael Hanselmann

Highlight external links in HTML documentation

Based on MediaWiki's monobook skin.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

23d95cff 01/09/2013 12:48 pm Bernardo Dal Seno

Unit tests for bdev and utils.lvm

Also amended a comment of a tested method.
The tests are for methods introduced in commit 63c73073 (LVM disk creation
uses dedicated PVs).

Signed-off-by: Bernardo Dal Seno <>
Reviewed-by: Michael Hanselmann <>

9ef3e121 01/09/2013 11:05 am Michele Tartara

Update the monitoring agent design document

This commit updates the design document of the monitoring agent according
to what has already been discussed in various meetings and email threads.

Signed-off-by: Michele Tartara <>
Reviewed-by: Iustin Pop <>

d78970ba 01/08/2013 06:16 pm Michele Tartara

Support instance-minor pairing in the DRBD collector

This commits enables the DRBD data collector to use the Confd client to
gather information about the pairing between DRBD minors and instances.

For testing purposes, the DRBD data collector now requires either zero...

eb62691c 01/08/2013 06:16 pm Michele Tartara

Support integrating instance information in the DRBD parser

This commit modifies the DRBD parser and its data structures to include
information about the instance a DRBD minor belongs to.

Test files have been updated as well, to support the new field in the data...

d4d94eee 01/08/2013 05:21 pm Michael Hanselmann

NEWS: Add missing parenthesis

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Michele Tartara <>

37cfb91f 01/08/2013 01:23 pm Michael Hanselmann

Add footer.rst as a dependency for all man pages

Commit 6aff051 removed an intermediate step, but forgot to add
“footer.rst” as a direct dependency.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

3784c431 01/08/2013 11:28 am Yiannis Tsiouris

Update name of test/htest in doc/devnotes.rst

Update the docs after the rename of 'test/hs/test' to
'test/hs/htest'. This must have been forgotten in 3e16567e.

Signed-off-by: Yiannis Tsiouris <>
Signed-off-by: Iustin Pop <>...

29fc0e4e 01/08/2013 11:28 am Iustin Pop

Fix a couple of bugs in the gnt-instance man page

The "list-fields" and "change-group" commands were mistakenly listed
as sections; we also rename the "Recovery" section to match better its
content.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

fa5121f0 01/08/2013 11:28 am Iustin Pop

Fix "Tags" section capitalisation in the man pages

"Tags" is a section, not a command, so let's title-case it (as opposed
to all upper-case). Furthermore, the RST markup was wrong for the
gnt-network man page.

Signed-off-by: Iustin Pop <>...

93e09cb7 01/08/2013 11:28 am Iustin Pop

Convert gnt-os man page to sections

As Constantinos observed, the gnt-os man page is not consistent with the
others. This patch adds the missing sections.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

fe7ad9c8 01/08/2013 11:28 am Iustin Pop

Improve a bit Haskell library recommended versions

The hinotify library was missing any versions, and finding one that
works with ghc 6.12 (base 4.2.x) was not obvious. The
test-framework-quickcheck2 recommended version didn't actually work
with the test-framework version, so fix that as well....

6aff0514 01/08/2013 11:28 am Iustin Pop

Remove intermediate footer.man/footer.html files

I don't remember why I introduced these when switching to pandoc, but
they are not absolutely needed. Instead of pre-generating them (which
might save some trivial cpu time), we can simply pass footer.rst as an...

74412d69 01/08/2013 11:28 am Iustin Pop

Enable a table of contents for the html version of man pages

This makes the (very dull) html version of the man pages a bit more
readable, until such a time that we can switch over to sphinx fully.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

7322bf7b 01/08/2013 11:28 am Iustin Pop

Rearrange tags in gnt-cluster/gnt-node

This patch makes the gnt-cluster and gnt-node man page more consistent
with the other man pages, where the tag commands are listed in a
separate section at the end.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

f8e233a3 01/08/2013 11:28 am Iustin Pop

Stop manually building images out of dot files

The first dot files we added way back in the 2.0 release are managed
manually: we build the .pngs ourselves, track them in .gitingore,
etc. Since then, we have switched to allow sphinx to build/manage them
itself, so it makes sense to cleanup the build system and covert...

8fa74099 01/08/2013 11:28 am Iustin Pop

Inline the standalone dot files

This removes entirely the standalone dot files by inlining them in the
RST documents - as they weren't referenced from more than one document
either way.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

6210c812 01/08/2013 11:28 am Iustin Pop

Remove some obsolete entries from .gitignore

Found while doing the previous .dot file changes and wondering what's
this "doc/*.in" stuff… it looks like these were obsoleted over the
years by not paying attention on cleanup patches:

- doc/build: obsoleted by commit 13de7d59...

7ce2f8ee 01/08/2013 11:26 am Michele Tartara

Fix a bug in the generation of completion information

Completion information for multi-command binaries were not generated in
the correct way, so the build-bash-complation script failed when such a
binary was actually found.

This commit fixes this issue, and a related docstring typo as well....

c46a9ffb 01/07/2013 08:56 pm Michael Hanselmann

Add small webserver for development

When working on documentation it can be helpful to use a browser. In
some environments it's not possible to access the files directly from a
graphical browser. This trivial webserver exports all files in the
current directory and unlike alternatives such as thttpd, doesn't check...

3a817255 01/07/2013 08:56 pm Michael Hanselmann

man pages: Lowercase name for syntax highlighting

When the man pages' reST is built using Sphinx, “bash” must be used
instead of “Bash”. Pandoc works with both.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

8d459129 01/07/2013 07:00 pm Michael Hanselmann

Add "use_locking" parameter to network query opcode

This was extracted from a patch by Dimitris Aragiorgis with the subject
“Add locking to _NetworkQuery”. The rest of the patch did no longer
apply and will require more work.

Signed-off-by: Michael Hanselmann <>...

27a19bf6 01/07/2013 04:21 pm Michael Hanselmann

Makefile.am: Add missing space

Commit acaf3ca missed this space before a backslash.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

6249f1c2 01/04/2013 04:42 pm Michele Tartara

Fix the installation location of mon-collector

The mon-collector binary was erroneously installed twice: once in
/usr/bin/ and once in /usr/lib/ganeti/.
With this modification, it is now installed in /usr/lib/ganeti/ only,
as intended.

In order to do this in a proper way, some parts of the Makefile.am where...

2663321c 01/04/2013 10:47 am Michele Tartara

Improve the reception of replies in the confd client

If a received reply is valid and there is still no valid reply,
keep it, no matter how new it is.

Signed-off-by: Michele Tartara <>
Reviewed-by: Guido Trotter <>

855f9bad 12/28/2012 05:53 pm Constantinos Venetsanopoulos

Document the ExtStorage `SetInfo' functionality

Small updates to the extstorage design document and interface.

Signed-off-by: Constantinos Venetsanopoulos <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

ef13148c 12/28/2012 05:51 pm Constantinos Venetsanopoulos

gnt-storage man page: make commands sub-sections

This makes the man page more consistent with the others (except
gnt-os, that is).

Signed-off-by: Constantinos Venetsanopoulos <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

f6b9c6e5 12/28/2012 05:50 pm Iustin Pop

Fix a bad data type in Hcheck.hs

While trying to understand why some code was not being tested, I
realised that we have a bad data type in Hcheck.hs.

We have "data Level = GroupLvl | ClusterLvl", but then we need to pass
the group name/index as well, so we have functions that look like the...

2fd5a116 12/28/2012 05:50 pm Iustin Pop

Move src/Ganeti/HTools/Program.hs to Program/Main.hs

This removes one more tab conflict; this is the last module in our
code where we have both x.hs and x/.

Furthermore, we collapse all actual code into the new Main.hs module,
leaving the htools.hs basically empty (will allow better testing in...

208b02e3 12/27/2012 03:35 pm Iustin Pop

A bit more name cleanup

- gen-coverage → gen-py-coverage
- coverage-htools.tix → coverage-hs.tix

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

784e77f0 12/27/2012 03:34 pm Iustin Pop

Split the hs-check test rule

Currently, both the unit test and the shell tests are run (manually)
from this rule. This has two downsides: you can't (compile and) run
just one of them easily, and make can't run them in parallel.

By splitting the rules, we can both of the above easily....

1c0f9d12 12/27/2012 03:34 pm Iustin Pop

Remove duplicate test file functions

This patch unifies the functions that generated the tree
reorganisation discussion in the first place :)

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

3e16567e 12/27/2012 03:34 pm Iustin Pop

Rename test/hs/test to htest

The current base name of 'test' means that this binary will generate
profiling, coverage, etc. files with the name 'test.*', result in
tab-completion conflicts with the test directory. Let's slightly
change its base name for typing easiness....

83846468 12/27/2012 03:34 pm Iustin Pop

Move htest/ files under the test/ tree

htest/data becomes test/data/htools (basically reverting commit
8feabc89), and htest/* becomes test/hs/*.

Most changes beside the rename are trivial s/…/…, with the exception
of autotools/run-in-tempdir, which needed some more changes now that...

90066780 12/27/2012 03:34 pm Iustin Pop

Move python test files to test/py

This is the first step of the test files reorganisation: moving test/*
(except test/data) to new directory test/py/.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

19e1b715 12/27/2012 03:33 pm Iustin Pop

Return master ip script output in case of failure

Currently only the exit code is returned, which is somewhat pointless:
for failures, we already know it's ≠ 0, so we don't have enough
information (reported on the mailing list). By logging the output as
well (if any), the user will have more information available for...

d9a900dc 12/27/2012 03:33 pm Iustin Pop

Replace htools→hs in configure/makefile rules

This continues the cleanup of the 'htools' name, by replacing 'htools'
with 'hs' in configure and makefile rules.

There is still 'WANT_HTOOLS' left as it is correct, but some of the
conditionals in Makefile.am will need some cleanup (in a different...

8775e62a 12/27/2012 03:33 pm Iustin Pop

Fix LUInstanceRecreateDisks with iallocator

Recent iallocator changes (commit fb60bc6a, “iallocator: Add node
whitelist”) broke the parameter validation for LUInstanceRecreateDisks
(the other LUs were manually fixed already):

$ gnt-instance recreate-disks -I hail --dry-run instance3...
8775b5b2 12/27/2012 03:32 pm Iustin Pop

Fix dependency on built python sources for hs-check

Since we call into Python for opcodes and other type compatibility
checks, we need to ensure that the python sources are
built. Otherwise, full parallel make might or might not break,
depending on timing....

3add7574 12/24/2012 11:38 pm Iustin Pop

Rename htools/ to src/

Per offline discussions, this is the first patch of the
renames. Tested with "make distcheck", seems to work fine.

The only change outside of the renaming is a bit of simplification in
the .gitignore rules; otherwise, simply s/htools/src/....

75b32fff 12/22/2012 08:11 pm Iustin Pop

Optimise autotools/run-in-tempdir

I made a mistake when adding support for htools to run-in-tempdir, by
needlessly copying the htools binaries, when it's enough to link
them. The copying is only really needed for python code, so we change
the Haskell binaries to linking and also a few other directories....

acaf3ca7 12/22/2012 08:11 pm Iustin Pop

Fix building of Constants.hs w.r.t .pyc files

Unless this is run under run-in-tempdir, it will create as usual the
.pyc files.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

b954f097 12/22/2012 11:47 am Constantinos Venetsanopoulos

Add the gnt-storage client

Add a new client called 'gnt-storage'.
The client interacts with the ExtStorage interface, similarly to
the way gnt-os interacts with the OS interface.

For now, only two commands are supported: 'info' and 'diagnose'.

'diagnose' calculates the node status of each provider on each node,...

95b92c34 12/22/2012 11:47 am Constantinos Venetsanopoulos

Add ExtStorage related man pages

  • ganeti-extstorage-interface man page
  • gnt-storage man page

Signed-off-by: Constantinos Venetsanopoulos <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

c64c3854 12/22/2012 09:40 am Iustin Pop

Extend the hcheck shell tests

This adds a few new hcheck tests, to extend the coverage.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

591fa888 12/22/2012 09:40 am Iustin Pop

Extend the hbal shell tests

After this patch, almost all of hbal except the actual Luxi execution
is being covered by unit- or shelltests.

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

108c0a3e 12/21/2012 10:26 pm Iustin Pop

Merge branch 'devel-2.6'

  • devel-2.6:
    Final update of NEWS file for 2.6.2 and version bump
    Fix job completion with big job queues
    confd: reduce noise during normal config reload
    Change hbal handling of !auto_balance instances
    Small corrections in man pages...
ce003543 12/21/2012 08:50 pm Iustin Pop

Fix build breakage after exclusive storage commits

This fixes:

htest/Test/Ganeti/Rpc.hs:50:14:
Couldn't match expected type `Rpc.RpcCallNodeInfo'
against inferred type `Data.Map.Map String Bool
-> Rpc.RpcCallNodeInfo'...

478a3308 12/21/2012 08:42 pm Iustin Pop

Merge branch 'stable-2.6' into devel-2.6

No conflicts, really trivial.

  • stable-2.6:
    Final update of NEWS file for 2.6.2 and version bump
    Fix job completion with big job queues
    confd: reduce noise during normal config reload
    Change hbal handling of !auto_balance instances...
2a196443 12/21/2012 07:06 pm Bernardo Dal Seno

Refactor checks for a new template in LUInstanceSetParams

All the checks have been moved to a private method, so as to make
CheckPrereq() smaller and more readable (pylint was complaining about it).

Signed-off-by: Bernardo Dal Seno <>...

6ebfef42 12/21/2012 07:06 pm Bernardo Dal Seno

LUs raise an error if they cannot handle exclusive_storage

This happens when the exclusive_storage flag is set, and the requested
operation is incompatible with the flag or not yet supported.

Signed-off-by: Bernardo Dal Seno <>
Reviewed-by: Iustin Pop <>

61481c52 12/21/2012 06:52 pm Bernardo Dal Seno

Free disk space reporting follows exclusive storage rules

When exclusive_storage is set, nodes report only the space that could be
used to create new disk according to the rules set in the
design-partitioned doc (i.e., non-empty disks are ignored and the space...

319322a7 12/21/2012 06:45 pm Bernardo Dal Seno

Call node_info RPCs with the exclusive_storage flag

The flag is read from the configuration and passed to the RPC.

Signed-off-by: Bernardo Dal Seno <>
Reviewed-by: Iustin Pop <>

1a3c5d4e 12/21/2012 06:45 pm Bernardo Dal Seno

Add exclusive_storage parameter to node_info RPC

The flag is passed to the low-level functions that need it, but it's not
yet used. Also, RPCs get just a default value for now.

Signed-off-by: Bernardo Dal Seno <>
Reviewed-by: Iustin Pop <>

c1912a48 12/21/2012 05:47 pm Michael Hanselmann

gnt-* list-fields: Show friendly field type

For people writing query filters (documented in ganeti(7)) knowing a field's
type can be useful.

$ gnt-instance list-fields name be/memory
Name Type Title Description
name Text Instance Instance name...

78453739 12/21/2012 05:47 pm Michael Hanselmann

QA: Do not pass "--bridge" to "gnt-cluster init"

Commit ec0652a (June 2009) removed the option.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

3601d488 12/21/2012 05:47 pm Michael Hanselmann

QA: Support master-netdev and default NIC parameters

Requested in issue 337.

The parameter “bridge” was not documented and is therefore silently
replaced with “master-netdev”. A note is added to “qa-sample.json”
describing how comments work.

Signed-off-by: Michael Hanselmann <>...

5ff543c3 12/21/2012 04:09 pm Iustin Pop

Fix build after addition of 'empty-cluster.data'

Of course I forgot to add this to TEST_FILES… and only distcheck
catches it.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michele Tartara <>

5e2e45b7 12/21/2012 04:06 pm Michael Hanselmann

Improve assertion message in LUClusterVerifyGroup

In issue 240 this assertion fails. While reproducing was not possible
with the master branch, having a more verbose message can't hurt.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Iustin Pop <>

e23cb7ca 12/21/2012 03:55 pm Michael Hanselmann

gnt-network(8): Re-add editor settings and re-wrap

Commit a04cc7a added “gnt-network.rst”, but didn't copy the editor
settings from another reST file.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

be862db9 12/21/2012 03:55 pm Michael Hanselmann

gnt-network(8): Reorder commands

Hiding the “connect” and “disconnect” commands below the tag operations
isn't good. The same is done in “gnt-instance.rst”.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

d4724b14 12/21/2012 01:40 pm Bernardo Dal Seno

Call blockdev_create RPCs with the exclusive_storage flag

The flag is read from the configuration and passed to the RPC.

Signed-off-by: Bernardo Dal Seno <>
Reviewed-by: Iustin Pop <>

63c73073 12/21/2012 01:40 pm Bernardo Dal Seno

LVM disk creation uses dedicated PVs

When exclusive_storage is set, PVs are allocated according to the
design-partitioned design doc.

Signed-off-by: Bernardo Dal Seno <>
Reviewed-by: Iustin Pop <>

59726e15 12/21/2012 01:40 pm Bernardo Dal Seno

Added class to contain information about a PV

This makes the code more readable and easier to upgrade.
bdev.LogicalVolume.GetPVInfo and the code that depends on it have been
refactored to use the new class.

utils.CheckVolumeGroupSize() has been moved to lib/utils/lvm.py, where more...

ee1478e5 12/21/2012 01:40 pm Bernardo Dal Seno

Add exclusive_storage parameter to blockdev_create RPC

The flag is passed to the low-level functions that need it, but it's not
yet used.

Signed-off-by: Bernardo Dal Seno <>
Reviewed-by: Iustin Pop <>

053976f3 12/21/2012 01:19 pm Iustin Pop

Add htest/hroller to .gitignore

Signed-off-by: Iustin Pop <>
Reviewed-by: Guido Trotter <>

04cc7d3f 12/21/2012 01:19 pm Iustin Pop

Extend hroller shell tests

Currently only --help and --version are tested; the patch extends this
with testing parsing of an empty cluster, of a cluster with one group,
and other command line behaviours.

It also adds testing for --help-completion for all htools binaries....

dccf6eaf 12/21/2012 12:16 pm Michele Tartara

Silence erroneous hlint warning

This patch adds an ignore for an hlint warning that wants camelcase to be used
in the name of a "case" test.
But if camelcase is used, it is not a valid test name anymore.

Signed-off-by: Michele Tartara <>...

911ee606 12/21/2012 11:32 am Michael Hanselmann

opcodes: Common parameter for target groups

Also add a missing parenthesis at the end.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

ee93aa8a 12/21/2012 11:32 am Michael Hanselmann

gnt-network: Fix CLI issues with node groups

The original implementation reserved the name “all” to specify all node
groups. That would prevent the use of a node group actually named “all”.

This patch changes the order and definition of the command line...

3fe5484a 12/21/2012 11:30 am Michael Hanselmann

gnt-network(8): Remove "rename"

It is not implemented after all.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

3924c9e0 12/21/2012 11:29 am Michael Hanselmann

gnt-network CLI improvements

- Use unpacking instead of addressing indivdual list items
- Add “--submit” and “--priority” support where possible
- Re-use LUXI client where possible
- Fixed some typos

There is still an issue that a node group named “all” can not be...

f2212a5d 12/21/2012 11:29 am Michael Hanselmann

Improve network query algorithm

Similar to commit 572a277. Directly iterate over “self.wanted” instead
of iterating through all networks and checking if they're wanted.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

070b780d 12/21/2012 11:29 am Michael Hanselmann

Change network error text

This error is thrown if a network name already exists, not if the
network itself (e.g. “1.2.3.0/24”) is defined.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

503574ec 12/21/2012 11:27 am Michael Hanselmann

Format network field "group_list" in client

The field is now a list of tuples containing the group name, mode and
link.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

f1222089 12/21/2012 11:24 am Dimitris Aragiorgis

Fix iallocator for nodegroups with no tags

_ComputeNodeGroupData() raises error if a group has no tags
when list(gdata.tags) is invoked. Use “gdata.GetTags()” instead.

Signed-off-by: Dimitris Aragiorgis <>
Signed-off-by: Michael Hanselmann <>...

37dfcacb 12/20/2012 06:34 pm Iustin Pop

Replace custom strip newlines in UUID generation

Since now rStripSpace lives in Utils.hs, we can use it directly (as
UUIDs shouldn't contain spaces anyway).

Signed-off-by: Iustin Pop <>
Reviewed-by: Michele Tartara <>

04063ba7 12/20/2012 06:17 pm Michele Tartara

Add Confd client to the Haskell code base

The client queries all the master candidates in parallel, until the minimum
number of replies, defined in the constant file, is received.
A timeout prevents the waiting from being of indefinite length.

The reply to be returned to the function that made the query is decided...

d8e9131b 12/20/2012 06:17 pm Michele Tartara

Add function to fetch the list of master candidates

This commits adds to the Haskell codebase a function to fetch the list of
IPs of the master candidates from the SSConf database.

Signed-off-by: Michele Tartara <>
Reviewed-by: Iustin Pop <>

1a0defea 12/20/2012 06:17 pm Michele Tartara

Add the parseReply function to the Confd utils

This function will be used by the Haskell Confd client to parse the replies
it receives from the server.

Unit test is included as well.

Signed-off-by: Michele Tartara <>
Reviewed-by: Iustin Pop <>

497f5cbf 12/20/2012 06:16 pm Michele Tartara

Rename the Confd utils parseMessage function to parseRequest

With the upcoming implementation of the Haskell Confd client, requests will
no longer be the only kind of message to be parsed, therefore the parsing
function for requests is being renamed to be more specific, and to better fit...

5bfcd75f 12/20/2012 06:16 pm Michele Tartara

Make the parseRequest function more general

The parseRequest function of the Confd utils can be used to parse both request
(in the server) and reply (in the client, soon to be implemented) signed
messages.
This patch changes the signature of the function to allow this, and its name...

80a0546b 12/20/2012 06:16 pm Michele Tartara

Add function for generating UUIDs in the Haskell codebase

Its first use will be to generate the salt for ConfD requests of the Haskell
client, as in the Python client.

Unit test added as well.

Signed-off-by: Michele Tartara <>
Reviewed-by: Iustin Pop <>

46300ac2 12/20/2012 06:15 pm Michele Tartara

Move Confd getCurrentTime to Utils

The Confd server implementation has a getCurrentTime function.
This commit moves it to the Utils.hs file of Confd, so that it will be
available to be used by the future Confd client as well.

Signed-off-by: Michele Tartara <>...

9f6f74b4 12/20/2012 05:53 pm Iustin Pop

Fixup too-long-line in Objects.hs

Sorry, didn't see this before pushing the previous commit (277a2ec9).

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

277a2ec9 12/20/2012 05:29 pm Constantinos Venetsanopoulos

ExtStorage support in htools

This just adds new constructors for the disk template and related
types, enabling the Ext storage.

Signed-off-by: Constantinos Venetsanopoulos <>
Signed-off-by: Iustin Pop <>
Reviewed-by: Iustin Pop <>

256e28c4 12/20/2012 05:12 pm Iustin Pop

Move rstripSpace from Ssconf to Utils

Also renames it in the process and adds a few tests for it.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

ea626b33 12/20/2012 05:12 pm Iustin Pop

confd: strip newlines before logging the request

The Python confd client sends newlines in messages (due to use of
DumpSignedJson/DumpJson), so that results in ugly debug output.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>

53258324 12/20/2012 05:08 pm Michael Hanselmann

objects.NIC: Look up mode only once, capitalize acronym

Look up “NIC_MODE” only once, capitalize “NIC” in error messages.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

42653ebd 12/20/2012 05:08 pm Michael Hanselmann

gnt-cluster(8): Quoting, small fixes

Quote fixed strings where appropriate and replace “nic” (an acronym)
with “network interface”.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

eac9b7b8 12/20/2012 05:08 pm Michael Hanselmann

Add utility to format dictionary as key=value strings

This will be used in QA to format network interface parameters.

Signed-off-by: Michael Hanselmann <>
Reviewed-by: Guido Trotter <>

938adc87 12/20/2012 05:06 pm Constantinos Venetsanopoulos

Multiple ExtStorage Providers and ext-params

Add support for passing parameters to the ext template (ext-params).
Take advantage of disk-params, that don't seem to make much sense in
this template (ExtStorage Providers are not predefined and we don't
know their needs) and use them to pass the ext-params dynamically to...

aa6c1bb1 12/20/2012 05:06 pm Constantinos Venetsanopoulos

Adjust LUInstanceSetParams wrt the `ext' template

Initial support for the `ext' template in gnt-instance modify.
Take care of all needed checks in CheckArguments and CheckPrereqs
wrt ExtStorage Providers and ext-params.

ExtStorage disk addition and specification of arbitrary ext-params...

376631d1 12/20/2012 05:06 pm Constantinos Venetsanopoulos

Implement the External Storage Interface

With this commit we introduce the External Storage Interface
to Ganeti, abbreviated: ExtStorage Interface.

The ExtStorage Interface provides Ganeti with the ability to interact
with externally connected shared storage pools, visible by all...

32ba31be 12/20/2012 03:37 pm Michael Hanselmann

Stop all daemons on cluster initialization

Addresses issue 145. When daemons are still running from a previous
cluster instance, starting the daemons again will fail.
“ConfigWriter.IsCluster” only looks at the configuration file, which
could already have been deleted....

da1dcce1 12/20/2012 03:37 pm Helga Velroyen

Make node groups' networks field a dict of nicparams

The networks field of the node groups class is a dictionary
of nic params and not a list of networks. This should fix
the broken QA.

Signed-off-by: Helga Velroyen <>
Reviewed-by: Iustin Pop <>

e7e2552e 12/20/2012 03:36 pm Constantinos Venetsanopoulos

Update the shared storage design document

Update the shared storage design document to reflect the current
changes, after the implementation of the ExtStorage interface.

Signed-off-by: Constantinos Venetsanopoulos <>
Signed-off-by: Iustin Pop <>...

efe2137a 12/20/2012 02:16 pm Iustin Pop

Final update of NEWS file for 2.6.2 and version bump

I'm already setting this to a release date of tomorrow, since QA on
the 2.6 branch has been clean.

Signed-off-by: Iustin Pop <>
Reviewed-by: Michael Hanselmann <>