Statistics
| Branch: | Revision:

root / hw @ 0f921197

# Date Author Comment
d86f0e32 02/14/2010 04:10 pm Alexander Graf

PPC: Uninorth config space accessor

The Uninorth PCI bridge requires different layouts in its PCI config space
accessors.

This patch introduces a conversion function that makes it compatible with
the way Linux accesses it.

I also kept an OpenBIOS compatibility hack in. I think it'd be better to...

0f921197 02/14/2010 04:10 pm Alexander Graf

PPC: Use Mac99_U3 type on ppc64

The "Mac99" type so far defines a "U2" based configuration. Unfortunately,
there have never been any U2 based PPC64 machines. That's what the U3 was
developed for.

So let's split the Mac99 machine in a PPC64 and a PPC32 machine. The PPC32...

186993ee 02/14/2010 04:10 pm Michael S. Tsirkin

pci: move pcibus_t to qemu-common

move pcibus_t to qemu-common.h to simplify header dependencies.

Signed-off-by: Michael S. Tsirkin <>

9f6f0423 02/14/2010 04:10 pm Michael S. Tsirkin

pci_host: rewrite using rwhandler

Save a ton of code by switching pcihost to use rwhandler.

Signed-off-by: Michael S. Tsirkin <>

bc798c77 02/14/2010 09:24 am Blue Swirl

Remove conditional rom loading support

Commit c2039bd0ffce8807e0eaac55254fde790825fa92 made rom loading
automatic for non-PC architectures. Remove now mostly unused
conditional rom loading support.

Signed-off-by: Blue Swirl <>

b5937f29 02/13/2010 09:37 am Isaku Yamahata

pci: fix info pci with host bridge.

This patch fixes 525e05147d5a3bdc08caa422d108c1ef71b584b5.
pci host bridge doesn't have header type of bridge.
The check should be by header type, instead of pci class device.

Cc: Blue Swirl <>
Cc: "Michael S. Tsirkin" <>...

c730256b 02/13/2010 09:00 am Blue Swirl

Merge branch 'for_anthony' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu

  • 'for_anthony' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu:
    pci: fix pci_find_bus()
9752c371 02/11/2010 12:53 am Christoph Hellwig

virtio-blk: add topology support

Export all topology information in the block config structure,
guarded by a new VIRTIO_BLK_F_TOPOLOGY feature flag.

Signed-off-by: Christoph Hellwig <>
Signed-off-by: Anthony Liguori <>

ee3659e3 02/11/2010 12:53 am Christoph Hellwig

scsi: add topology support

Export the physical block size in the READ CAPACITY (16) command,
and add the new block limits VPD page to export the minimum and
optiomal I/O sizes.

Note that we also need to bump the scsi revision level to SPC-2
as that is the minimum requirement by at least the Linux kernel...

0009baf1 02/11/2010 12:53 am Christoph Hellwig

ide: add topology support

Export the physical block size in the ATA IDENTIFY command. The
other topology values are not supported in ATA so skip them.

Signed-off-by: Christoph Hellwig <>
Signed-off-by: Anthony Liguori <>

428c149b 02/11/2010 12:53 am Christoph Hellwig

block: add topology qdev properties

Add three new qdev properties to export block topology information to
the guest. This is needed to get optimal I/O alignment for RAID arrays
or SSDs.

The options are:

- physical_block_size to specify the physical block size of the device,...
37d5ddd6 02/11/2010 12:51 am hch@lst.de

virtio-blk: revert serial number support

The addition of the whole ATA IDENTIY page caused the config space to
go above the allowed size in the PCI spec, and thus the feature was
already reverted in the Linux guest driver and disabled by default in
qemu....

ba144141 02/10/2010 09:46 pm Luiz Capitulino

Monitor: remove unneeded checks

It's not needed to check the return of qobject_from_jsonf()
anymore, as an assert() has been added there.

Signed-off-by: Luiz Capitulino <>
Signed-off-by: Anthony Liguori <>

06b12970 02/10/2010 08:48 pm Tom Lendacky

virtio-net: fix network stall under load

Fix a race condition where qemu finds that there are not enough virtio
ring buffers available and the guest make more buffers available before
qemu can enable notifications.

Signed-off-by: Tom Lendacky <>...

8e65b7c0 02/10/2010 08:45 pm David S. Ahern

audio streaming from usb devices

I have streaming audio devices working within qemu-kvm. This is a port
of the changes to qemu.

Streaming audio generates a series of isochronous requests that are
repetitive and time sensitive. The URBs need to be submitted in...

4ab4183d 02/10/2010 08:45 pm David S. Ahern

segfault due to buffer overrun in usb-serial

This fixes a segfault due to buffer overrun in the usb-serial device.
The memcpy was incrementing the start location by recv_used yet, the
computation of first_size (how much to write at the end of the buffer
before wrapping to the front) was not accounting for it. This causes the...

7ad7e3c3 02/10/2010 07:57 pm Luiz Capitulino

ide: Generate BLOCK_IO_ERROR QMP event

Just call bdrv_mon_event() in the right place.

Signed-off-by: Luiz Capitulino <>
Signed-off-by: Anthony Liguori <>

380f640f 02/10/2010 07:57 pm Luiz Capitulino

scsi: Generate BLOCK_IO_ERROR QMP event

Just call bdrv_mon_event() in the right place.

Signed-off-by: Luiz Capitulino <>
Signed-off-by: Anthony Liguori <>

eaa6c85f 02/10/2010 07:57 pm Luiz Capitulino

virtio-blk: Generate BLOCK_IO_ERROR QMP event

Just call bdrv_mon_event() in the right place.

Signed-off-by: Luiz Capitulino <>
Signed-off-by: Anthony Liguori <>

e0bcb9ca 02/09/2010 10:07 pm Aurelien Jarno

sh7750: handle MMUCR TI bit

When the MMUCR TI bit is set, all the UTLB and ITLB entries should be
flushed.

Signed-off-by: Aurelien Jarno <>

8217d945 02/08/2010 06:06 pm Anthony Liguori

Merge remote branch 'qemu-kvm/uq/master' into staging-tmp

37cc0b44 02/08/2010 01:21 pm Aurelien Jarno

SH4/R2D: fix poweroff

The write the the PA_POWOFF register is currently ignored. Fix that by
calling qemu_system_shutdown_request() when a poweroff is requested.

Signed-off-by: Aurelien Jarno <>

8fd5cf4b 02/08/2010 12:14 pm Isaku Yamahata

pci: fix pci_find_bus()

typo in c021f8e65f5009a5ab5711d9d5326fcab553ef1c.
comparison fix.

Cc: Blue Swirl <>
Cc: "Michael S. Tsirkin" <>
Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael S. Tsirkin <>

d55380bb 02/07/2010 09:28 pm Blue Swirl

dec: actually implement PCI bridging

Signed-off-by: Blue Swirl <>

ff9868ec 02/07/2010 11:17 am Blue Swirl

esp: use CamelCaseFunc for function types

Signed-off-by: Blue Swirl <>

b96ae2da 02/07/2010 11:15 am Blue Swirl

fw_cfg: don't use reserved _ prefix

Signed-off-by: Blue Swirl <>

7859cb98 02/07/2010 11:13 am Blue Swirl

fdc: don't use reserved _ prefix

Signed-off-by: Blue Swirl <>

5c02c033 02/07/2010 11:01 am Blue Swirl

fdc: don't use reserved _t suffix

Signed-off-by: Blue Swirl <>

8e39a033 02/07/2010 10:05 am Blue Swirl

escc: don't use reserved _t suffix

Signed-off-by: Blue Swirl <>

43a34704 02/07/2010 10:05 am Blue Swirl

m48t59: don't use reserved _t suffix

Signed-off-by: Blue Swirl <>

d0f2c4c6 02/07/2010 01:03 am malc

Do not use dprintf

dprintf is already claimed by POSIX1, and on at least one system
is implemented as a macro

[1] http://www.opengroup.org/onlinepubs/9699919799/functions/dprintf.html

Signed-off-by: malc <>

5c43485f 02/06/2010 06:14 pm Aurelien Jarno

mips/malta: fix typo

Signed-off-by: Aurelien Jarno <>

525e0514 02/06/2010 04:57 pm Blue Swirl

PCI: show also host bridge data in "info pci" output

Signed-off-by: Blue Swirl <>

c021f8e6 02/06/2010 11:20 am Blue Swirl

PCI: fix multiple bridge problems

When several PCI bridges were in use, monitor command "info pci" would
enter into infinite loop. Buses behind the bridge were not discoverable
because secondary and subordinate bus numbers were not used properly.
Other buses were not found because bus search terminated on first miss....

e1c6bbab 02/05/2010 08:48 pm Blue Swirl

Refactor DEC 21154 PCI bridge

It's currently not used by PPC machines. Refactor so that also Sparc64
machines can use it.

Signed-off-by: Blue Swirl <>

03c63b94 02/03/2010 11:47 pm Jan Kiszka

KVM: Make vmport KVM-compatible

The vmport "device" accesses the VCPU registers, so it requires proper
cpu_synchronize_state. Add it to vmport_ioport_read, which also
synchronizes vmport_ioport_write.

Signed-off-by: Jan Kiszka <>

ff952ba2 02/03/2010 08:39 pm Markus Armbruster

qdev: Fix exit code for -device ?

Help was shoehorned into device creation, qdev_device_add(). Since
help doesn't create a device, it returns NULL, which looks to callers
just like failed device creation. Monitor handler do_device_add()
doesn't care, but main() exits unsuccessfully....

eecbb9fe 02/03/2010 08:39 pm Markus Armbruster

Revert "qdev: Add help for property value"

This reverts commit 922910ce42d15bdb7c2347436b1b5798b5401de4.

The commit has four issues:

  • When it runs from the monitor, e.g. "device_add e1000,mac=?", it
    prints to stderr instead of the monitor.
  • Help looks to callers just like failed device creation. This makes...
5137b6ac 02/03/2010 08:39 pm Markus Armbruster

Revert "qdev: Add help for device properties"

This reverts commit 2ba6edf0dd740166632df80caa85992b20791a68.

The commit has two issues:

  • When it runs from the monitor, e.g. "device_add e1000,?", it prints
    to stderr instead of the monitor.
  • Help looks to callers just like failed device creation. This makes...
08350cf0 02/03/2010 08:39 pm Markus Armbruster

qdev: Add help for device properties

Option "-device DRIVER,?" and monitor command "device_add DRIVER,?"
print the supported properties instead of creating a device. The
former also terminates the program.

This is commit 2ba6edf0 (just reverted) done right....

117f8eb8 02/03/2010 08:39 pm Markus Armbruster

qdev: Add rudimentary help for property value

This provides the same information as reverted commit 2ba6edf0. Not
much, just better than nothing.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Anthony Liguori <>

95819af0 01/30/2010 09:48 pm Blue Swirl

sparc64: implement basic IOMMU/interrupt handling

Also add reset control.

Signed-off-by: Blue Swirl <>

a4d5f62c 01/29/2010 08:15 pm Blue Swirl

Sparc64: byte swap IO port access

This requires an updated OpenBIOS image.

Signed-off-by: Blue Swirl <>

f1b52868 01/29/2010 05:53 pm Kevin Wolf

virtio-blk: Fix restart after read error

Current code assumes that only write requests are ever going to be restarted.
This is wrong since rerror=stop exists. Instead of directly starting writes,
use the same request processing as used for new requests.
...

6c510fbf 01/29/2010 05:53 pm Kevin Wolf

virtio-blk: Fix error cases which ignored rerror/werror

If an I/O request fails right away instead of getting an error only in the
callback, we still need to consider rerror/werror.

Signed-off-by: Kevin Wolf <>
Signed-off-by: Anthony Liguori <>

9ae84f0a 01/29/2010 05:53 pm Amit Shah

virtio-serial-bus: Fix bus initialisation and allow for bus identification

This commit enables one to use multiple virtio-serial devices and to
assign ports to arbitrary devices like this:

-device virtio-serial,id=foo -device virtio-serial,id=bar \
-device virtserialport,bus=foo.0,name=foo \...
4516e45f 01/29/2010 05:53 pm Jan Kiszka

cirrus: Properly re-register cirrus_linear_io_addr on vram unmap

This fixes CONFIG_FB_CIRRUS for Linux guests and probably much more:

When switching away from linearly mapped vram, we also have to restore
the I/O handlers for the LFB.

This regression was once introduced by commit 2bec46dc97....

bc6694d4 01/29/2010 05:53 pm Kevin Wolf

virtio_blk: Factor virtio_blk_handle_request out

We need a function that handles a single request. Create one by splitting out
code from virtio_blk_handle_output.

Signed-off-by: Kevin Wolf <>
Signed-off-by: Anthony Liguori <>

8f4efc55 01/27/2010 11:21 pm Igor V. Kovalenko

sparc64: reimplement tick timers v4

sparc64 timer has tick counter which can be set and read,
and tick compare value used as deadline to fire timer interrupt.
The timer is not used as periodic timer, instead deadline
is set each time new timer interrupt is needed....

b4bf0a9a 01/27/2010 02:01 pm Edgar E. Iglesias

pflash: Buffer block writes

Buffer block writes to avoid flushing every word access onto backing
storage device. This significantly speeds up flash emulation for flashes
connected through an 8 or 16-bit bus combined with backing storage (-pflash).

Signed-off-by: Edgar E. Iglesias <>

625a5bef 01/27/2010 01:08 am Adam Litke

virtio: Add memory statistics reporting to the balloon driver

When using ballooning to manage overcommitted memory on a host, a system for
guests to communicate their memory usage to the host can provide information
that will minimize the impact of ballooning on the guests. The current method...

f8a83245 01/27/2010 12:41 am Herve Poussineau

win32: pair qemu_memalign() with qemu_vfree()

Win32 suffers from a very big memory leak when dealing with SCSI devices.
Each read/write request allocates memory with qemu_memalign (ie
VirtualAlloc) but frees it with qemu_free (ie free).
Pair all qemu_memalign() calls with qemu_vfree() to prevent such leaks....

776e1bbb 01/26/2010 11:59 pm Blue Swirl

PCI: fix bridge configuration

PCI bridges' qdev info structures must indicate bridge header type,
otherwise critical bridge registers (esp. PCI_PRIMARY_BUS,
PCI_SECONDARY_BUS, PCI_SUBORDINATE_BUS) will not be writable.

Signed-off-by: Blue Swirl <>

163c8a59 01/26/2010 11:42 pm Luiz Capitulino

PCI: Convert pci_info() to QObject

The returned QObject is a QList of all buses. Each bus is
represented by a QDict, which has a key with a QList of all
PCI devices attached to it. Each device is represented by
a QDict.

As has happended to other complex conversions, it's hard to...

d5e4acf7 01/26/2010 11:42 pm Luiz Capitulino

PCI: do_pci_info(): PCI bridge devices support

This commit completes the do_pci_info() conversion to
QObject by adding support to PCI bridge devices.

This is done by recursively adding devices in the
"pci_bridge" key.

IMPORTANT: This code is being added separately because I could...

42ee76fe 01/26/2010 11:42 pm Marcelo Tosatti

ide save/restore current transfer fields

If migration takes place between write of the bmdma address register and
write of the command register (to initiate DMA), the destination will
not properly start the DMA op, hanging the guest:

ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen...

4c36a2ff 01/26/2010 11:42 pm Amit Shah

virtio-console: Rename virtio-serial.c back to virtio-console.c

This file was renamed to ease the reviews of the recent changes
that went in.

Now that the changes are done, rename the file back to its original
name.

Signed-off-by: Amit Shah <>...

2ba6edf0 01/26/2010 11:42 pm Stefan Weil

qdev: Add help for device properties

When called with property "?", a list of supported
properties will be printed (instead of an error message).

This is useful for command lines like
qemu -device e1000,?
and was already standard for other options like model=?...

922910ce 01/26/2010 11:42 pm Stefan Weil

qdev: Add help for property value

When called with property value "?",
a help text will be printed (instead of an error message).

This is useful for command lines like
qemu -device e1000,mac=?
and is already standard for other command line options....

acdc3f0c 01/26/2010 10:59 pm Juan Quintela

check pipe() return value

Signed-off-by: Juan Quintela <>
Signed-off-by: Anthony Liguori <>

6908d9ce 01/24/2010 11:18 pm Blue Swirl

Sparc64: fix initrd

Fix HdrS offsets for Sparc64. The initrd address must be offset by
KERNBASE.

Use rom_ptr mechanism to actually write to the kernel image.

Signed-off-by: Blue Swirl <>

e9cbbcac 01/24/2010 08:28 pm Edgar E. Iglesias

pflash: Dont open memarea for full IO if already done.

When wcycle is non zero the area is already opened for readable IO.
Avoiding the re-registration of the memarea significantly speeds up
the flash emulation. In particular for flashes connected through 8 or...

4737fa26 01/24/2010 07:39 pm Edgar E. Iglesias

pflash: Reduce writebuf len for 8-bit flashes.

Flashes connected through an 8 bit bus cannot handle write buffers
larger than 256 bytes.

Signed-off-by: Edgar E. Iglesias <>

a66e360f 01/24/2010 06:19 pm Edgar E. Iglesias

pflash: Remove dead code, no functional changes.

Signed-off-by: Edgar E. Iglesias <>

2548de3a 01/24/2010 06:15 pm Edgar E. Iglesias

microblaze: The petalogix s3adsp board uses intel flashes

Signed-off-by: Edgar E. Iglesias <>

452efba6 01/24/2010 04:28 pm Blue Swirl

Sparc32: fix free-run timer

According to Sun4M System Architecture Manual chapter 5.3.2, a limit
of 0 will not generate interrupts.

Signed-off-by: Blue Swirl <>

07b064e9 01/24/2010 03:55 pm Jan Kiszka

Musicpal: Fix descriptor walk in eth_send

Commit 930c86820e introduced a regression to eth_send: eth_tx_desc_put
manipulates the host's tx descriptor copy before writing it back, but
two lines down the descriptor is evaluated again, leaving us with an
invalid next address if host and guest endianness differ. So this was...

64258229 01/23/2010 08:18 pm Jan Kiszka

Musicpal: Fix wm8750 I2C address

Commit b3a219883e uncovered that we attached the Wolfson with an I2C
address shifted left by one. Fixing this makes sound work again for
the Musicpal.

Signed-off-by: Jan Kiszka <>
Signed-off-by: malc <>

204c7a39 01/22/2010 08:39 pm Blue Swirl

Sparc64: fix PCI probe problems

Byte swap PCI config values.

Remove old bogus PCI config mechanism so that device 0:0.0 can be probed.
This requires OpenBIOS r667.

Signed-off-by: Blue Swirl <>

dd17765b 01/20/2010 04:51 pm Gleb Natapov

reduce number of reinjects on ACK

Windows 7 BSODs under load with HAL_RTC_IRQF_WILL_NOT_CLEAR error.

It happens here:
hal!HalpRtcUnmaskClock:
8281b93a 8bff mov edi,edi
8281b93c 56 push esi
8281b93d 33f6 xor esi,esi...

bb61564c 01/20/2010 04:25 pm Amit Shah

virtio: Remove duplicate macro definition for max. virtqueues, bump up the max

VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in
hw/virtio.h.

Also, bump up the value of the maximum allowed virtqueues to 64. This is
in preparation to allow multiple ports per virtio-console device....

98b19252 01/20/2010 04:25 pm Amit Shah

virtio-console: qdev conversion, new virtio-serial-bus

This commit converts the virtio-console device to create a new
virtio-serial bus that can host console and generic serial ports. The
file hosting this code is now called virtio-serial-bus.c.

The virtio console is now a very simple qdev device that sits on the...

6663a195 01/20/2010 04:25 pm Amit Shah

virtio-serial-bus: Maintain guest and host port open/close state

Via control channel messages, the guest can tell us whether a port got
opened or closed. Similarly, we can also indicate to the guest of host
port open/close events.

Signed-off-by: Amit Shah <>...

160600fd 01/20/2010 04:25 pm Amit Shah

virtio-serial-bus: Add a port 'name' property for port discovery in guests

The port 'id' or number is internal state between the guest kernel and
our bus implementation. This is invocation-dependent and isn't part of
the guest-host ABI.

To correcly enumerate and map ports between the host and the guest, the...

f146ec9a 01/20/2010 04:25 pm Amit Shah

virtio-serial-bus: Add ability to hot-unplug ports

Signed-off-by: Amit Shah <>
Signed-off-by: Anthony Liguori <>

b60c470b 01/20/2010 04:25 pm Amit Shah

virtio-serial: Add a 'virtserialport' device for generic serial port support

This commit adds a simple chardev-based serial port. Any data the guest
sends is forwarded to the chardev and vice-versa.

Sample uses for such a device can be obtaining info from the guest like...

a1829205 01/20/2010 04:25 pm Amit Shah

virtio-serial: Use MSI vectors for port virtqueues

This commit enables the use of MSI interrupts for virtqueue
notifications for ports. We use nr_ports + 1 (for control channel) msi
entries for the ports, as only the in_vq operations need an interrupt on...

f5edb014 01/20/2010 04:25 pm Naphtali Sprei

Clean-up a little bit the RW related bits of BDRV_O_FLAGS. BDRV_O_RDONLY gone (and so is BDRV_O_ACCESS). Default value for bdrv_flags (0/zero) is READ-ONLY. Need to explicitly request READ-WRITE.

Instead of using the field 'readonly' of the BlockDriverState struct for passing the request,...

beb6f0de 01/20/2010 12:31 am Kevin Wolf

Fix QEMU_WARN_UNUSED_RESULT

Since commit 747bbdf7 QEMU_WARN_UNUSED_RESULT is never defined as it is
conditional on a define from config-host.h which is included only later.
Include that file earlier to get the warnings back.

Reactivating it unfortunately leads to some warnings about unused qdev_init...

47c06340 01/20/2010 12:31 am Gerd Hoffmann

ide: device version property

This patch adds a new property named 'ver' to ide-drive which allows to
specify the version which the virtual disk/cdrom should report to the
guest. By default this is the qemu version (i.e. 0.12). usage:

-drive if=none,id=disk,file=......
383b4d9b 01/20/2010 12:31 am Gerd Hoffmann

scsi: device version property

This patch adds a new property named 'ver' to scsi-disk which allows to
specify the version which the virtual disk/cdrom should report to the
guest. By default this is the qemu version (i.e. 0.12). usage:

-drive if=none,id=disk,file=......
374ef704 01/20/2010 12:31 am Gerd Hoffmann

pc: add driver version compat properties

This patch adds compat property entries for ide-disk.ver and
scsi-disk.ver to pc-0.10 and pc-0.11. With this patch applied
the scsi and ide disks report "0.10" and "0.11" as version when
you start qemu with "-M pc-0.10" or "-M pc-0.11"....

7b8737de 01/20/2010 12:31 am Stefan Weil

eepro100: Fix multicast support

  • Handling of multicast list was missing.
  • Multicast all was missing.
  • Promiscuous mode for multicast frames was wrong.

This patch is a step to synchronize my maintainer version
of eepro100.c (git://repo.or.cz/qemu/ar7.git) with the...

4ef1a3d3 01/20/2010 12:31 am Igor V. Kovalenko

rtl8139: fix clang reporting unused assignment of VLAN tagging data

Currently we do not implement VLAN tagging for rtl8139(C+),
still data is read from ring buffer headers.

- augment unused assignment with TODO item
- cast txdw1 to void for now

Signed-off-by: Igor V. Kovalenko <>...

f3a52e50 01/20/2010 12:31 am Stefan Weil

eepro100: Restructure code (new function tx_command)

Handling of transmit commands is rather complex,
so about 80 lines of code were moved from function
action_command to the new function tx_command.

The two new values "tx" and "cb_address" in the
eepro100 status structure made this possible without...

787cfbc4 01/16/2010 11:06 am Blue Swirl

Sparc32: improve DMA controller IRQ debugging

Signed-off-by: Blue Swirl <>

dca47edd 01/16/2010 11:06 am Blue Swirl

ESP: improve IRQ debugging

Signed-off-by: Blue Swirl <>

10760f0f 01/16/2010 11:06 am Artyom Tarasenko

sparc32 do not clear interrupts when masking

Don't clear interrupts on disabling, because
  • Sun4M_SystemArchitecture_edited2.pdf doesn't describe
    that masking or un-masking IRQ shall clear pending ones.
  • Field tests also show that SPARCstation-20 doesn't...
fccd2613 01/15/2010 01:06 am Edgar E. Iglesias

nand: Correct random data reads.

Random reading depends on having the last row/page latched and not beeing
clobbered between read and any following random reads.

Also, s->iolen must be updated when loading the io/data register with
randomly accessed flash data....

0a4e7cd2 01/14/2010 05:15 pm Shin-ichiro KAWASAKI

sh: sm501: Add hardware cursor feature

This patch adds hardware cursor feature to SM501 graphics chip emulation,
to make the graphic console more useful for QEMU SH4 users.

Signed-off-by: Shin-ichiro KAWASAKI <>
Signed-off-by: Aurelien Jarno <>

22c253d9 01/14/2010 01:14 am Amit Shah

virtio: net: remove dead assignment

clang-analyzer points out value assigned to 'len' is not used.

Signed-off-by: Amit Shah <>
Signed-off-by: Anthony Liguori <>

c4af120f 01/14/2010 01:14 am Amit Shah

hw/vga.c: remove dead assignment

clang-analyzer points out a redundant assignment.

Signed-off-by: Amit Shah <>
Signed-off-by: Anthony Liguori <>

4277906d 01/14/2010 01:14 am Christoph Hellwig

virtio-blk: remove dead variable in virtio_blk_handle_scsi

As pointed out by clang size is only ever written to, but never actually
used.

Signed-off-by: Christoph Hellwig <>
Signed-off-by: Anthony Liguori <>

884a0c76 01/13/2010 08:59 pm Blue Swirl

pcnet: remove dead nested assignment, spotted by clang

Although the value stored to 'addr' is used in the enclosing expression,
the value is never actually read from 'addr'.

Probably a typo.

Signed-off-by: Blue Swirl <>

f7e683b8 01/13/2010 08:58 pm Blue Swirl

Sparc32: remove dead increment, spotted by clang

Signed-off-by: Blue Swirl <>

f368a3ce 01/13/2010 08:55 pm Blue Swirl

Sparc32: remove a variable used only for debugging to avoid a clang warning

Signed-off-by: Blue Swirl <>

89835363 01/13/2010 08:52 pm Blue Swirl

Sparc32: remove unused env/envs variables, spotted by clang

Signed-off-by: Blue Swirl <>

cb95c2e4 01/13/2010 02:50 pm Stefan Weil

pci: Add missing 'const' in argument to pci_get_xxx

pci_get_byte, pci_get_word, pci_get_long and pci_get_quad
all take a const uint8_t pointer, because they only read
the configuration data.

Their prototypes should reflect this fact.

Signed-off-by: Stefan Weil <>...

938a6324 01/13/2010 02:50 pm Stefan Weil

eepro100: Update ROM file support

Use new way to associate ROM files to devices.

Currently, there is only a ROM file for i82559er
included in QEMU, so the patch does not add
.romfile for the other devices.

When flexible mode is fixed in eepro100, adding...

61702408 01/13/2010 02:28 pm Stefan Weil

eepro100: Fix initial value for PCI_STATUS

The numerical value was wrong (0x2800 instead of 0x0280)
which indeed did not make sense.

Signed-off-by: Stefan Weil <>
Signed-off-by: Michael S. Tsirkin <>