« Previous | Next » 

Revision 1c1b40c1

ID1c1b40c162a6964e1898e84304230a308f4d16c3

Added by Cédric VINCENT over 9 years ago

arm-semi: Provide access to CLI arguments passed through the "-append" option

This patch basically adapts the new semi-hosting command-line support
-- introduced by Wolfgang Schildbach in the commit 2e8785ac -- for use
in system-mode.

Note that the "arm_cmdline_len" and "host_cmdline_len" variables were
renamed respectively "input_size" and "output_size" because:

  • in C, the term "length" is generally used to count the number of
    character in a string, not to count the number of bytes in a
    buffer (as it is the case here).
  • in QEMU, the term "host" is used to name variables that are in
    the host address space, not to name variables in the target
    address space (as it is the case here).
  • in the case of this system-call, the terms "input" and "output"
    fit the semantic of the official ARM semi-hosting specification
    quite well.

I know renaming can be considered harmful but I do think in this case
the semantic really matters to keep this code more understandable.

Signed-off-by: Cédric VINCENT <>
Reviewed-by: Christophe Lyon <>
Cc: Peter Maydell <>
Cc: Paul Brook <>
Cc: Wolfgang Schildbach <>
Cc: Riku Voipio <>
Signed-off-by: Riku Voipio <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences