Statistics
| Branch: | Revision:

root / ui @ 23bfe28f

Latest revisions

# Date Author Comment
23bfe28f 03/11/2011 12:12 am Stefan Weil

vnc: Fix stack corruption and other bitmap related bugs

Commit bc2429b9174ac2d3c56b7fd35884b0d89ec7fb02 introduced
a severe bug (stack corruption).

bitmap_clear was called with a wrong argument
which caused out-of-bound writes to the local variable width_mask....

c53af37f 02/26/2011 12:04 am Corentin Chary

vnc: fix a memory leak in threaded vnc server

VncJobQueue's buffer is intended to be used for
as the output buffer for all operations in this queue,
but unfortunatly.

vnc_async_encoding_start() is in charge of setting this
buffer as the current output buffer, but...

cf76a1ce 02/24/2011 07:25 pm Peter Maydell

ui/vnc-enc-tight.c: Fix compile failure if CONFIG_VNC_JPEG not defined

Add some missing #ifdefs to fix compilation failures in the !CONFIG_VNC_JPEG
case introduced by commit ce702e93.

Signed-off-by: Peter Maydell <>
Signed-off-by: Anthony Liguori <>

207f328a 02/24/2011 12:28 am Corentin Chary

vnc: fix lossy rect refreshing

The for loop in send_lossy_rect was totally wrong, and we can't
call vnc_set_bits() because it does not really do what it should.
Use vnc_set_bit() directly instead.

Signed-off-by: Corentin Chary <>
Signed-off-by: Anthony Liguori <>

bc2429b9 02/24/2011 12:28 am Corentin Chary

vnc: use the new generic bitmap functions

Switch to bitmap.h and bitops.h instead of redefining our own bitmap
helpers.

Signed-off-by: Corentin Chary <>
Signed-off-by: Anthony Liguori <>

6c71a539 02/24/2011 12:28 am Corentin Chary

vnc: don't try to send bigger updates that client height

Respect client size if it doesn't not support desktop resizing.

Signed-off-by: Corentin Chary <>
Signed-off-by: Anthony Liguori <>

8cb4a6b7 02/24/2011 12:28 am Corentin Chary

vnc: tight: tweak adaptive tight settings

The force_jpeg threshold was too low.

Signed-off-by: Corentin Chary <>
Signed-off-by: Anthony Liguori <>

80e0c8c3 02/24/2011 12:28 am Corentin Chary

vnc: add a non-adaptive option

This option allow to disable adaptive behaviors in some encodings.

Signed-off-by: Corentin Chary <>
Signed-off-by: Anthony Liguori <>

5db8378a 02/24/2011 12:28 am Stefan Weil

vnc: Fix fatal crash with vnc reverse mode

Reverse mode is unusable:

qemu -vnc localhost:5500,reverse

crashes in vnc_refresh_server_surface because some pointers are NULL.

Fix this by calling vnc_dpy_resize (which initializes these pointers)
before calling vnc_refresh....

368d2588 02/24/2011 12:28 am Corentin Chary

vnc: fix uint8_t comparisons with negative values

Signed-off-by: Corentin Chary <>
Signed-off-by: Anthony Liguori <>

View revisions

Also available in: Atom