Statistics
| Branch: | Revision:

root / hw @ 2860e3eb

# Date Author Comment
086cf4d3 05/18/2011 03:38 pm Andrea Arcangeli

ide: cleanup warnings

Add \n.

Signed-off-by: Andrea Arcangeli <>
Signed-off-by: Kevin Wolf <>

1e71db30 05/18/2011 03:38 pm Stefan Weil

hw/xen_disk: Remove unused local variable

cppcheck report:
hw/xen_disk.c:309: style:
Variable 'len' is assigned a value that is never used

Cc: Kevin Wolf <>
Signed-off-by: Stefan Weil <>
Signed-off-by: Kevin Wolf <>

2860e3eb 05/18/2011 03:38 pm Kevin Wolf

ide: Turn debug messages into assertions

These printfs aren't really debug messages, but clearly indicate a bug if they
ever become effective. Noone uses DEBUG_IDE, let's re-enable the check
unconditionally and make it an assertion instead of printfs in the device...

96d19bcb 05/16/2011 06:15 pm Jan Kiszka

ahci: Unbreak bar registration

Fix regression of 667bb59: ahci_init initializes ahci.mem, so we have to
move bar registration after it.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Anthony Liguori <>

091959de 05/14/2011 05:54 pm Aurelien Jarno

Merge branch 'ppc-next' of git://repo.or.cz/qemu/agraf

  • 'ppc-next' of git://repo.or.cz/qemu/agraf:
    PPC: Qdev'ify e500 pci
    PPC MPC7544DS: Use new TLB helper function
    PPC: Implement e500 (FSL) MMU
    PPC: Add another 64 bits to instruction feature mask...
711c2128 05/12/2011 04:08 pm Anthony Liguori

Merge remote-tracking branch 'stefanha/trivial-patches' into staging

Conflicts:
cpu-all.h

89bb563f 05/12/2011 04:06 pm Anthony Liguori

Merge remote-tracking branch 'agraf/xen-next' into staging

be13cc7a 05/12/2011 01:24 am Alexander Graf

PPC: Qdev'ify e500 pci

The e500 PCI controller isn't qdev'ified yet. This leads to severe issues
when running with -drive.

To be able to use a virtio disk with an e500 VM, let's convert the PCI
controller over to qdev.

Reviewed-by: Paul Brook <>...

ef250db6 05/12/2011 01:24 am Alexander Graf

PPC: Make MPC8544DS obey -cpu switch

The MPC8544DS board emulation code ignored the user defined -cpu switch.
This patch enables it to only provide a sane default, not force an e500v2
CPU inside.

Signed-off-by: Alexander Graf <>

3b989d49 05/12/2011 01:24 am Alexander Graf

PPC: Make MPC8544DS emulation work w/o KVM

The MPC8544DS board emulation was only used with KVM so far, so some
parts of the code didn't provide proper values for non-KVM execution.

This patch makes the machine work without KVM enabled. To actually use
this, you also need proper e500v2 MMU emulation....

5389055a 05/12/2011 01:24 am Alexander Graf

PPC MPC7544DS: Use new TLB helper function

Now that we have some nice helpers that can find us a TLB entry, let's
use that on the machine initialization code, so we don't need to know
about the internals of the TLB array.

Signed-off-by: Alexander Graf <>

7d7ba3fe 05/10/2011 09:10 am David Gibson

Fix off-by-one error in sizing pSeries hcall table

The pSeries machine uses two tables to look up guest hcalls for emulation.
One of these is exactly one entry too small to hold all the hcalls it needs
to, leading to memory corruption.

This patch fixes the bug, and while we're at it, make both tables 'static'...

41019fec 05/09/2011 11:31 pm Anton Blanchard

pseries: Increase maximum CPUs to 256

The original pSeries machine was limited to 32 CPUs, more or less
arbitrarily. Particularly when we get SMT KVM guests it will be
pretty easy to exceed this. Therefore, raise the max number of CPUs
in a pseries machine guest to 256....

5d73dd66 05/09/2011 11:31 pm David Gibson

Make pSeries 'model' property more closely resemble real hardware

Currently, the qemu emulated pseries machine puts
"qemu,emulated-pSeries-LPAR" in the device tree's root level 'model'
property. Unfortunately this confuses some installers and ybin, which...

b4a78527 05/09/2011 11:31 pm David Gibson

Place pseries vty devices at addresses more similar to existing machines

Currently the qemu pseries machine numbers its virtual serial devices
from 0. However, existing pSeries machines running pHyp number them from
0x30000000.

In theory these indices are arbitrary, since everything necessary for the...

90dc8812 05/09/2011 11:31 pm Scott Wood

monitor: add PPC BookE SPRs

Read them via KVM_GET_SREGS in kvm_arch_get_registers(),
and display them in "info registers".

Also get CR and PID from the existing KVM_GET_REGS.

Signed-off-by: Scott Wood <>
Signed-off-by: Alexander Graf <>

b3e5759e 05/09/2011 11:02 am Gerd Hoffmann

usb-musb: uninline functions

Prototype without "inline" keyword breaks the build with some gcc
versions. Noticed by Alexander Graf.

Fix this by removing the inline keywork everywhere. Some functions
can't be inlined anyway as the are referenced using function pointers....

2f172849 05/08/2011 01:59 pm Hannes Reinecke

lsi53c895a: Rename 'sense' to 'status'

The 'sense' field in the HBA status structure is misnamed, as it
actually carries the SCSI status. Rename it.

Signed-off-by: Hannes Reinecke <>
Reviewed-by: Stefan Hajnoczi <>...

7ba4cbbf 05/08/2011 12:59 pm Stefan Weil

ac97: Remove unused local variables

cppcheck report:
hw/ac97.c:1004: style:
Variable 'written' is assigned a value that is never used
hw/ac97.c:1072: style:
Variable 'written' is assigned a value that is never used

Signed-off-by: Stefan Weil <>...

60b14d95 05/08/2011 12:02 pm Stefan Weil

Fix typos in comments (instanciation -> instantiation)

Signed-off-by: Stefan Weil <>
Signed-off-by: Stefan Hajnoczi <>

a1c7273b 05/08/2011 12:02 pm Stefan Weil

Fix typos in comments and code (occured -> occurred and related)

The code changed here is an unused data type name (evt_flush_occurred).

Signed-off-by: Stefan Weil <>
Signed-off-by: Stefan Hajnoczi <>

e8e3bb2f 05/08/2011 12:02 pm Stefan Weil

Fix typo in comment (responsiblity -> responsibility)

Signed-off-by: Stefan Weil <>
Signed-off-by: Stefan Hajnoczi <>

0d50d616 05/08/2011 12:02 pm Stefan Weil

Fix typos in comment (threshhold -> threshold, mapp -> map)

Signed-off-by: Stefan Weil <>
Signed-off-by: Stefan Hajnoczi <>

4b71051e 05/08/2011 12:02 pm Stefan Weil

Fix typos in comments (imediately -> immediately)

Signed-off-by: Stefan Weil <>
Signed-off-by: Stefan Hajnoczi <>

ff2712ba 05/08/2011 12:02 pm Stefan Weil

Fix typos in comments (interupt -> interrupt)

Signed-off-by: Stefan Weil <>
Signed-off-by: Stefan Hajnoczi <>

64c7b9d8 05/08/2011 12:02 pm Stefan Weil

Fix typos in comments (accessable -> accessible, priveleged -> privileged)

Signed-off-by: Stefan Weil <>
Signed-off-by: Stefan Hajnoczi <>

4e9a0b5b 05/08/2011 12:02 pm Stefan Weil

Fix typo in comment (colum -> column)

Signed-off-by: Stefan Weil <>
Signed-off-by: Stefan Hajnoczi <>

a7f22f06 05/08/2011 12:02 pm Stefan Weil

Fix typo in comment (auxilliary -> auxiliary)

Signed-off-by: Stefan Weil <>
Signed-off-by: Stefan Hajnoczi <>

c9622478 05/08/2011 11:10 am Anthony PERARD

xen: Add Xen hypercall for sleep state in the cmos_s3 callback.

Signed-off-by: Anthony PERARD <>
Signed-off-by: Alexander Graf <>

9c11a8ac 05/08/2011 11:10 am Anthony PERARD

xen: Introduce Xen Interrupt Controller

Every set_irq call makes a Xen hypercall.

Signed-off-by: Anthony PERARD <>
Signed-off-by: Stefano Stabellini <>
Signed-off-by: Alexander Graf <>

432d268c 05/08/2011 11:10 am Jun Nakajima

xen: Introduce the Xen mapcache

On IA32 host or IA32 PAE host, at present, generally, we can't create
an HVM guest with more than 2G memory, because generally it's almost
impossible for Qemu to find a large enough and consecutive virtual
address space to map an HVM guest's whole physical address space....

8c12f191 05/08/2011 11:10 am John Baboval

pci: Use of qemu_put_ram_ptr in pci_add_option_rom.

Prevent a deadlock caused by leaving a map cache bucket locked by the
preceding qemu_get_ram_ptr() call.

Signed-off-By: John Baboval <>
Signed-off-by: Anthony PERARD <>...

9ce94e7c 05/08/2011 11:10 am Arun Sharma

xen: Initialize event channels and io rings

Open and bind event channels; map ioreq and buffered ioreq rings.

Signed-off-by: Arun Sharma <>
Signed-off-by: Anthony PERARD <>
Signed-off-by: Stefano Stabellini <>...

3285cf4f 05/08/2011 11:10 am Anthony PERARD

xen: Add initialisation of Xen

The xenpv machine use the common init function.

Signed-off-by: Anthony PERARD <>
Acked-by: Alexander Graf <>
Signed-off-by: Alexander Graf <>

e0e7e67b 05/08/2011 11:10 am Anthony PERARD

pc_memory_init: Move memory calculation to the caller.

This patch moves above_4g_mem_size and below_4g_mem_size calculation in
the caller of pc_memory_init (pc_init1). And the prototype of
pc_memory_init is changed because there is no need anymore to have...

29d3ccde 05/08/2011 11:10 am Anthony PERARD

xen: Add xenfv machine

Introduce the Xen FV (Fully Virtualized) machine to Qemu, some more Xen
specific call will be added in further patches.

Signed-off-by: Anthony PERARD <>
Signed-off-by: Alexander Graf <>

1611977c 05/08/2011 11:10 am Anthony PERARD

pc, Disable vmport initialisation with Xen.

This is because there is not synchronisation of the vcpu register
between Xen and QEMU, so vmport can't work properly.

This patch introduces no_vmport parameter to pc_basic_device_init.

Signed-off-by: Anthony PERARD <>...

41445300 05/08/2011 11:10 am Anthony PERARD

piix_pci: Introduces Xen specific call for irq.

This patch introduces Xen specific call in piix_pci.

The specific part for Xen is in write_config, set_irq and get_pirq.

Signed-off-by: Anthony PERARD <>
Signed-off-by: Stefano Stabellini <>...

67b724e6 05/08/2011 11:09 am Anthony PERARD

machine, Add default_machine_opts to QEMUMachine.

With this new field, we can specified which accelerator use to run the
machine, if the accelerator is not already specified by either a
configuration file or the command line options.

Currently, the only use will be made in the xenfv machine....

209cd7ab 05/08/2011 11:09 am Anthony PERARD

xen: Replace some tab-indents with spaces (clean-up).

And put braces for blocks with a single statement.

Signed-off-by: Anthony PERARD <>
Acked-by: Alexander Graf <>
Signed-off-by: Alexander Graf <>

d5b93ddf 05/08/2011 11:09 am Anthony PERARD

xen: Support new libxc calls from xen unstable.

This patch updates the libxenctrl calls in Qemu to use the new interface,
otherwise Qemu wouldn't be able to build against new versions of the
library.

We check libxenctrl version in configure, from Xen 3.3.0 to Xen...

ebabb67a 05/06/2011 10:19 am Stefan Weil

Fix typo in code and comments

Replace writeable -> writable

Signed-off-by: Stefan Weil <>
Signed-off-by: Stefan Hajnoczi <>

3964f535 05/05/2011 09:05 pm Anthony Liguori

Merge remote-tracking branch 'mst/for_anthony' into staging

a69fb350 05/05/2011 09:04 pm Anthony Liguori

Merge remote-tracking branch 'kraxel/usb.7.pull' into staging

5300f1a5 05/05/2011 04:39 pm Michael S. Tsirkin

Merge remote branch 'origin/master' into pci

Conflicts:
exec.c

602ef4d9 05/05/2011 04:11 pm Jan Kiszka

pci: Add class 0x403 as 'audio controller'

Used by HD audio controllers like our intel-hda.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Michael S. Tsirkin <>

45fe15c2 05/05/2011 04:10 pm Jan Kiszka

MSI: Robust resource release

msi_init may fail, so we need to check on uninit if the cap was
actually installed. This also avoids that the users need to check.

Signed-off-by: Jan Kiszka <>
Signed-off-by: Michael S. Tsirkin <>

27a05006 05/05/2011 04:05 pm Stefan Weil

eepro100: Support byte/word writes to pointer register

pointer is a 32 bit register, but may be written using 8 or 16 bit writes.
Add support for byte/word writes.

Signed-off-by: Stefan Weil <>
Signed-off-by: Michael S. Tsirkin <>

0113f48d 05/05/2011 04:05 pm Stefan Weil

eepro100: Support byte/word read/write access to MDI control register

MDI control is a 32 bit register, but may be read or written using
8 or 16 bit access. Data is latched when the MSB is written.

Add support for byte/word read/write access.

Signed-off-by: Stefan Weil <>...

a39bd017 05/05/2011 04:05 pm Stefan Weil

eepro100: Support byte read access to general control register

The general control register is a byte register.
Add support for byte reads.

Signed-off-by: Stefan Weil <>
Signed-off-by: Michael S. Tsirkin <>

072476ea 05/05/2011 04:05 pm Stefan Weil

eepro100: Support 32 bit read/write access to flash register

Signed-off-by: Stefan Weil <>
Signed-off-by: Michael S. Tsirkin <>

e5e23ab8 05/05/2011 04:05 pm Stefan Weil

eepro100: Fix endianness issues

Like other Intel devices, e100 (eepro100) uses little endian byte order.

This patch was tested with these combinations:

i386 host, i386 + mipsel guests (le-le)
mipsel host, i386 guest (le-le)
i386 host, mips + ppc guests (le-be)...

3fd3d0b4 05/05/2011 04:05 pm Stefan Weil

eepro100: Support byte/word writes to port address

port is a 32 bit register, but may be written using 8 or 16 bit writes.
Add support for byte/word writes.

Signed-off-by: Stefan Weil <>
Signed-off-by: Michael S. Tsirkin <>

792f1d63 05/05/2011 04:04 pm Stefan Weil

eepro100: Pad received short frames

QEMU sends frames smaller than 60 bytes to ethernet nics.
Such frames are rejected by real NICs and their emulations.
To avoid this behaviour, other NIC emulations pad received
frames. This patch enables this workaround for eepro100, too....

27112f18 05/05/2011 03:50 pm Stefan Weil

eepro100: Remove unused structure element

cppcheck reports that 'packet' is unused.

It was only used to calculate the size of the preceding data.
Removing it saves a lot of stack space (local variable rx).

Signed-off-by: Stefan Weil <>...

77bee84e 05/05/2011 03:50 pm Stefan Weil

eepro100: Remove type casts which are no longer needed

Signed-off-by: Stefan Weil <>
Signed-off-by: Michael S. Tsirkin <>

1b4f97d6 05/05/2011 03:49 pm Stefan Weil

eepro100: Avoid duplicate debug messages

When DEBUG_EEPRO100 was enabled, unsupported writes were logged twice.
Now logging in eepro100_write1 and eepro100_write2 is similar to the
logging in eepro100_write4 (which already was correct).

Signed-off-by: Stefan Weil <>...

ef0bdf77 05/04/2011 05:55 pm Gerd Hoffmann

usb: mass storage fix

Initialize scsi_len with zero when starting a new request, so any
stuff leftover from the previous request is cleared out. This may
happen in case the data returned by the scsi command doesn't fit
into the buffer provided by the guest....

ddf6583f 05/04/2011 03:11 pm Gerd Hoffmann

uhci: switch to QTAILQ

7b5a44c5 05/04/2011 03:11 pm Gerd Hoffmann

uhci: keep uhci state pointer in async packet struct.

Signed-off-by: Gerd Hoffmann <>

9066df13 05/04/2011 03:11 pm Gerd Hoffmann

ohci: get ohci state via container_of()

Signed-off-by: Gerd Hoffmann <>

5dc1672b 05/04/2011 03:11 pm Gerd Hoffmann

musb: get musb state via container_of()

13a9a0d3 05/04/2011 03:11 pm Gerd Hoffmann

usb: move complete callback to port ops

19f33223 05/04/2011 01:25 pm Hans de Goede

usb: control buffer fixes

Windows allows control transfers to pass up to 4k of data, so raise our
control buffer size to 4k. For control out transfers the usb core code copies
the control request data to a buffer before calling the device's handle_control...

e0c64d08 05/03/2011 04:35 pm Gerd Hoffmann

spice: don't create updates in spice server context.

This patch moves the creation of spice screen updates from the spice
server context to qemu iothread context (display refresh timer to be
exact). This way we avoid accessing qemu internals (display surface)...

07536094 05/03/2011 04:35 pm Gerd Hoffmann

spice: don't call displaystate callbacks from spice server context.

This patch moves the displaystate callback calls for setting the cursor
and the mouse pointer from spice server to qemu (iothread) context.
This allows us to simplify locking.

Signed-off-by: Gerd Hoffmann <>

196a7784 05/03/2011 04:35 pm Gerd Hoffmann

spice: drop obsolete iothread locking

We don't use qemu internals from spice server context any more.
Thus we don't also need to grab the iothread mutex from spice
server context. And we don't have to temporarely release the
lock to avoid deadlocks. Drop all the calls....

a7acf552 05/03/2011 12:29 pm Amit Shah

atapi: Move comment to proper place

Move misplaced comment for media_is_dvd()

Signed-off-by: Amit Shah <>
Signed-off-by: Kevin Wolf <>

4a737d14 05/03/2011 12:29 pm Amit Shah

atapi: Explain why we need a 'media not present' state

After the re-org of the atapi code, it might not be intuitive for a
reader of the code to understand why we're inserting a 'media not
present' state between cd changes.

Signed-off-by: Amit Shah <>...

ab719827 05/03/2011 12:29 pm Alon Levy

ide/atapi: fix set but unused

Signed-off-by: Alon Levy <>
Acked-by: Stefan Weil <>
Signed-off-by: Kevin Wolf <>

c07050dd 05/03/2011 11:48 am Michael Walle

milkymist-vgafb: fix console resizing

After enabling the framebuffer, ensure that the console is resized.

Signed-off-by: Michael Walle <>
Signed-off-by: Edgar E. Iglesias <>

f3172a0e 05/03/2011 11:48 am Michael Walle

milkymist-sysctl: fix timers

Prevent timers from firing right after starting.

Signed-off-by: Michael Walle <>
Signed-off-by: Edgar E. Iglesias <>

57aa265d 05/03/2011 11:48 am Michael Walle

lm32: add Milkymist Minimac2 support

This patch adds support for Milkymist's minimal Ethernet MAC v2. It
superseds minimac1.

Signed-off-by: Michael Walle <>
Signed-off-by: Edgar E. Iglesias <>

450fb75c 05/02/2011 03:38 pm Glauber Costa

kvm: create kvmclock when one of the flags are present

kvmclock presence can be signalled by two different flags. So for
device creation, we have to test for both.

Signed-off-by: Glauber Costa <>
Signed-off-by: Avi Kivity <>

71ef18e1 04/28/2011 04:37 pm Anthony Liguori

Merge remote-tracking branch 'amitshah/for-anthony' into staging

e77976a2 04/28/2011 04:25 pm Anthony Liguori

Merge remote-tracking branch 'jvrao/for-anthony' into staging

5c1c9bb2 04/28/2011 10:05 am Alexey Kardashevskiy

virtio-serial: Fix endianness bug in the config space

The virtio serial specification requres that the values in the config
space are encoded in native endian of the guest.

The qemu virtio-serial code did not do conversion to the guest endian
format what caused problems when host and guest use different format....

d5b27167 04/28/2011 08:33 am Kusanagi Kouichi

char: Allow devices to use a single multiplexed chardev.

This fixes regression caused by commit
2d6c1ef40f3678ab47a4d14fb5dadaa486bfcda6
("char: Prevent multiple devices opening same chardev"):

-nodefaults -nographic -chardev stdio,id=stdio,mux=on,signal=off \...

0b6d2266 04/28/2011 08:32 am Hans de Goede

virtio-console: notify backend of guest open / close

Signed-off-by: Hans de Goede <>
Reviewed-by: Alon Levy <>
Signed-off-by: Amit Shah <>

47f7be39 04/27/2011 09:04 pm Jan Kiszka

ioapic: Do not set irr for masked edge IRQs

So far we set IRR for edge IRQs even if the pin is masked. If the guest
later on unmasks and switches the pin to level-triggered mode, irr will
remain set, causing an IRQ storm. The point is that setting IRR is not...

4f8dee2d 04/27/2011 06:27 pm Harsh Prateek Bora

v9fs_walk: As per 9p2000 RFC, MAXWELEM >= nwnames >= 0.

The nwnames field in TWALK message is assumed to be >=0 and <= MAXWELEM
which is defined as macro P9_MAXWELEM (16) in virtio-9p.h as per 9p2000
RFC. Appropriate changes are required in V9fsWalkState and v9fs_walk....

f35bde2f 04/27/2011 06:27 pm Harsh Prateek Bora

hw/virtio-9p-local.c: Remove unnecessary null char in symlink file

This patch removes the addition of null char in symlink file
which is being appended to file in case of mapped security model.
Without this patch, the extra null char causes LTP testcase lstat03...

1d810aeb 04/27/2011 06:26 pm M. Mohan Kumar

virtio-9p: Bugfix to send correct iounit

LCREATE function packs address of iounit in the pdu, fix that to send
actual iounit itself.

Signed-off-by: M. Mohan Kumar <>
Acked-by: Aneesh Kumar K.V <>
Signed-off-by: Venkateswararao Jujjuri <>

a0994761 04/27/2011 06:26 pm Aneesh Kumar K.V

virtio-9p: removexattr on default acl should return 0

If we don't have default acl, removexattr on default acl
should return 0

Signed-off-by: Aneesh Kumar K.V <>
Signed-off-by: Venkateswararao Jujjuri <>

39792515 04/27/2011 06:25 pm Aneesh Kumar K.V

virtio-9p: Print the pdu details on return

Signed-off-by: Aneesh Kumar K.V <>
Signed-off-by: Venkateswararao Jujjuri <>

353ac78d 04/27/2011 06:24 pm Aneesh Kumar K.V

virtio-9p: move 9p files around

Now that we start adding more files related to 9pfs
it make sense to move them to a separate directory

Signed-off-by: Aneesh Kumar K.V <>
Signed-off-by: Venkateswararao Jujjuri <>

661bfc80 04/27/2011 05:31 pm Jan Kiszka

pflash: Restore & fix lazy ROMD switching

Commit 5145b3d1cc revealed a bug in the lazy ROMD switch-back logic, but
resolved it by breaking that feature. This approach addresses the issue
by switching back to ROMD after a certain amount of read accesses
without further unlock sequences....

aa348082 04/27/2011 05:26 pm Aurelien Jarno

Merge branch 'for-anthony' of git://repo.or.cz/qemu/kevin

  • 'for-anthony' of git://repo.or.cz/qemu/kevin:
    Remove obsolete 'enabled' variable from progress state
    Add dd-style SIGUSR1 progress reporting
    qed: Fix consistency check on 32-bit hosts
    ide/atapi: Introduce CHECK_READY flag for commands...
c6a0487b 04/27/2011 05:22 pm Stefan Weil

rtl8139: Fix compilation for w32/w64

Compilation for Windows needs a different declaration for the
printf format attribute, so use the macro which was defined for
this purpose.

Cc: Benjamin Poirier <>
Signed-off-by: Stefan Weil <>...

7a2c4b82 04/27/2011 05:21 pm Kevin Wolf

ide/atapi: Introduce CHECK_READY flag for commands

Some commands are supposed to report a Not Ready Condition (i.e. they require
a medium to be present in order to execute successfully). Instead of
duplicating the check in each command implementation, let's add a flag and...

a60cf7e7 04/27/2011 05:20 pm Kevin Wolf

ide/atapi: Factor commands out

In preparation for a table of function pointers, factor each command out from
ide_atapi_cmd() into its own function.

Signed-off-by: Kevin Wolf <>

e1a064f9 04/27/2011 05:20 pm Kevin Wolf

ide/atapi: Use table instead of switch for commands

Signed-off-by: Kevin Wolf <>

e119bcac 04/27/2011 05:20 pm Kevin Wolf

ide/atapi: Replace bdrv_get_geometry calls by s->nb_sectors

The disk size can only change when the medium is changed, and the change
callback takes care of updating s->nb_sectors in this case.

Signed-off-by: Kevin Wolf <>

33231e0e 04/27/2011 05:20 pm Kevin Wolf

ide: Split atapi.c out

Besides moving code, this patch only fixes some whitespace issues in the moved
code and makes all functions in atapi.c static which can be static.

Signed-off-by: Kevin Wolf <>

4b9b7092 04/27/2011 03:36 pm Amit Shah

atapi: Add 'medium ready' to 'medium not ready' transition on cd change

MMC-5 Table F.1 lists errors that can be thrown for the TEST_UNIT_READY
command. Going from medium not ready to medium ready states is
communicated by throwing an error.

This adds the missing 'tray opened' event that we fail to report to...

b4548fcc 04/26/2011 03:14 pm Stefan Hajnoczi

trace: Remove %s in grlib trace events

Trace events cannot use %s in their format strings because trace
backends vary in how they can deference pointers (if at all). Recording
const char * values is not meaningful if their contents are not recorded
too....

ec48c774 04/25/2011 11:17 pm Benjamin Poirier

rtl8139: add format attribute to DPRINTF

gcc can check the format string for correctness even when debugging output is
not enabled.
Have to make sure arguments are always available. They are optimized out if
unneeded.

Signed-off-by: Benjamin Poirier <>...

7cdeb319 04/25/2011 11:17 pm Benjamin Poirier

rtl8139: use variadic macro for debug statements

Removes double (( )) to make DEBUG_PRINT compatible with real function calls.
Change the name to DPRINTF to be consistent with other DPRINTF macros
throughout qemu.
Include the "RTL8139: " prefix in the macro. This changes some debug output...

afcd9c0d 04/25/2011 11:17 pm Benjamin Poirier

rtl8139: use TARGET_FMT_plx in debug messages

Prevents a compilation failure when DEBUG_RTL8139 is defined:

CC libhw32/rtl8139.o
cc1: warnings being treated as errors
hw/rtl8139.c: In function ‘rtl8139_cplus_transmit_one’:
hw/rtl8139.c:1960: error: format ‘%8lx’ expects type ‘long unsigned int’, but argument 5 has type ‘target_phys_addr_t’...

dbf352ad 04/25/2011 06:26 pm Anthony Liguori

Merge remote-tracking branch 'awilliam/ipxe' into staging