Statistics
| Branch: | Revision:

root / ui @ 2a2af967

Latest revisions

# Date Author Comment
cf5cfe04 02/16/2012 02:40 am Anthony Liguori

Merge remote-tracking branch 'kraxel/vnc.2' into staging

  • kraxel/vnc.2:
    vnc: lift modifier keys on client disconnect.
    vnc: implement shared flag handling.
    vnc: fix ctrl key in vnc terminal emulation
    Fix vnc memory corruption with width = 1400
83f7d43a 02/15/2012 05:39 pm Andreas Färber

qom: Unify type registration

Replace device_init() with generalized type_init().

While at it, unify naming convention: type_init([$prefix_]register_types)
Also, type_init() is a function, so add preceding blank line where
necessary and don't put a semicolon after the closing brace....

ce3e1417 02/10/2012 10:58 am Gerd Hoffmann

Fix vnc memory corruption with width = 1400

vnc assumes that the screen width is a multiple of 16 in several places.
If this is not the case vnc will overrun buffers, corrupt memory, make
qemu crash.

This is the minimum fix for this bug. It makes sure we don't overrun the...

e26437c2 02/10/2012 10:58 am Gerd Hoffmann

vnc: fix ctrl key in vnc terminal emulation

Make the control keys for terminals on the vnc display
(i.e. qemu -vnc :0 -serial vc) work. Makes the terminals
alot more usable as typing Ctrl-C in your serial console
actually has the desired effect ;)

Signed-off-by: Gerd Hoffmann <>

8cf36489 02/10/2012 10:58 am Gerd Hoffmann

vnc: implement shared flag handling.

VNC clients send a shared flag in the client init message. Up to now
qemu completely ignores this. This patch implements shared flag
handling. It comes with three policies: By default qemu behaves as one
would expect: Asking for a exclusive access grants exclusive access to...

7bc9318b 02/10/2012 10:58 am Gerd Hoffmann

vnc: lift modifier keys on client disconnect.

For any modifier key (shift, ctrl, alt) still pressed on disconnect
inject a key-up event into the guest. The vnc client is gone, it will
not do that, so qemu has to do it instead.

Without this keys will get stuck, making the guest act in weird ways...

85f94f86 02/01/2012 10:45 pm Jan Kiszka

sdl: Fix block prevention of SDL_WM_GrabInput

Consistently check for SDL_APPINPUTFOCUS before trying to grab the input
focus. Just checking for SDL_APPACTIVE doesn't work. Moving the check to
sdl_grab_start allows for some consolidation.

Signed-off-by: Jan Kiszka <>...

eaa2e027 02/01/2012 10:45 pm Jan Kiszka

Revert "Handle SDL grabs failing (Mark McLoughlin)"

This reverts commit 6bb816031f8bc0aafc3476e6dfa4293ee3a5f106.

SDL_WM_GrabInput does not reliably bail out if grabbing is impossible.
So if we get here, we already lost and will block. But this can no
longer happen due to the check in sdl_grab_start. So this patch became...

822f98d2 02/01/2012 10:45 pm Jan Kiszka

sdl: Grab input on end of non-absolute mouse click

By grabbing the input already on button down, we leave the button in
that state for the host GUI. Thus it takes another click after releasing
the input again to synchronize the mouse button state.

Avoid this by grabbing on button up....

02df4d6f 02/01/2012 10:45 pm Jan Kiszka

sdl: Limit sdl_grab_end in handle_activation to Windows hosts

There are scenarios on Linux with some SDL versions where
handle_activation is continuous invoked with state = SDL_APPINPUTFOCUS
and gain = 0 while we grabbed the input. This causes a ping-pong when we...

View revisions

Also available in: Atom