Statistics
| Branch: | Revision:

root / hw / pcie_aer.c @ 32059220

History | View | Annotate | Download (31.3 kB)

# Date Author Comment
47188700 03/03/2011 03:54 pm Dmitry Eremin-Solenikov

vmstate: move VMSTATE_PCIE_AER_ERRS to hw/hw.h

VMSTATE_PCIE_AER_ERRS is indeed useful for other emulation drivers.
Move it to hw/hw.h under the name of VMSTATE_STRUCT_VARRAY_POINTER_UINT16.
Also add VMSTATE_STRUCT_VARRAY_POINTER_INT32 which is more or less...
2ae63bda 12/24/2010 10:35 am Isaku Yamahata

pcie/aer: glue aer error injection into qemu monitor

introduce pcie_aer_inject_error command.

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael S. Tsirkin <>
513691b7 12/09/2010 12:48 pm Michael S. Tsirkin

pci/aer: factor out common code

Same logic is used to assert interrupts
and send msix messages, so add a static functin for this.

Signed-off-by: Michael S. Tsirkin <>
5f47c187 12/09/2010 12:48 pm Michael S. Tsirkin

pci/aer: remove dead code

Remove some unused variables and return values.

Signed-off-by: Michael S. Tsirkin <>
Signed-off-by: Isaku Yamahata <>
2b3cb353 12/09/2010 12:48 pm Michael S. Tsirkin

pci/aer: fix interrupt on config write

config write handling for aer seems broken:
For example, it won't clear a level interrupt
when command register is set to 0.

Make it match the spec: level should equal
the logical or of enabled bits, msi only
be sent when the logical or changes....
c3f33667 12/09/2010 12:48 pm Michael S. Tsirkin

pci/aer: fix error injection

Fix the injection logic upon aer message to follow 6.2.4.1.2 more
closely: specifically only send an msi interrupt when the logical or of
the enabled bits changed, not when a bit which was previously clear
becomes set.

Signed-off-by: Michael S. Tsirkin <>...
4a9dd665 12/09/2010 12:48 pm Michael S. Tsirkin

pci: untangle pci/msi dependency

msi depends on pci but pci should not depend on msi.
The only dependency we have is a recent addition
of pci_msi_ functions, IMO they add little enough to
open-code in the small number of users.

Follow-up patches add more cleanups....
e6e055c9 12/04/2010 08:36 pm Blue Swirl

Fix mingw32 and OpenBSD warnings

ffsl() is not universally available, so there are these warnings
on both mingw32 and OpenBSD:
/src/qemu/hw/pcie_aer.c: In function 'pcie_aer_update_log':
/src/qemu/hw/pcie_aer.c:399: warning: implicit declaration of function 'ffsl'...
34e65944 11/22/2010 10:00 am Isaku Yamahata

pcie/aer: helper functions for pcie aer capability

This patch implements helper functions for pcie aer capability
which will be used later.

Signed-off-by: Isaku Yamahata <>
Signed-off-by: Michael S. Tsirkin <>
247c97f3 11/22/2010 10:00 am Michael S. Tsirkin

pcie_aer: get rid of recursion

Added some TODOs: they are trivial but omitted here
to make the patch logic as transparent as possible.

Signed-off-by: Michael S. Tsirkin <>
d33d9156 11/22/2010 10:00 am Michael S. Tsirkin

pcie_aer: complete unwinding recursion

Open-code functions created in the previous patch,
to make code more compact and clear.
Detcted and documented what looks like a bug in code
that becomes apparent from this refactoring.

Signed-off-by: Michael S. Tsirkin <>