« Previous | Next » 

Revision 40f16dd1


Added by Paolo Bonzini almost 10 years ago

scsi-generic: Remove bogus double complete

scsi-generic scsi_read_complete() should not both call the client
complete callback with SCSI_REASON_DATA and call
scsi_command_complete(). The former will cause the client to queue a
new read or write request, while the later will free the request data
structure, thus causing the new read or write request to use a
freed/stale structure when it completes.

This patch fixes the bug, fixing a crash with scsi-generic & RHEL5.5

Cc: Benjamin Herrenschmidt <>
Cc: David Gibson <>
Signed-off-by: Paolo Bonzini <>
Reviewed-by: Christoph Hellwig <>


  • added
  • modified
  • copied
  • renamed
  • deleted

View differences