« Previous | Next » 

Revision 4dedc07f

ID4dedc07ffbbc66002e0fd2b97d5516fe6aca5eea

Added by Andrzej Zaborowski over 13 years ago

vmware_vga: Add checks to deal with non-atomic fifo writes.

Janne Huttunen noticed that the FIFO end pointer is updated by the
guest after writing each word to the FIFO, at least the X.org driver
which is open does this. This means that there's no way for the
host to know if the guest is in the middle a write operation. Qemu
thus needs to read the beginning of the command up to when it's able
to tell how many words are expected for the given command. It will
abort reading and rewind the FIFO if there aren't enough words yet,
this should be relatively rare but it is suspected to have been the
cause of the occasional FIFO overrun that killed the display.

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences