« Previous | Next » 

Revision 5c6c0e51


Added by Hannes Reinecke over 10 years ago

scsi: Use 'SCSIRequest' directly

Currently the SCSIRequest structure is abstracted away and cannot accessed
directly from the driver. This requires the handler to do a lookup on
an abstract 'tag' which identifies the SCSIRequest structure.

With this patch the SCSIRequest structure is exposed to the driver. This
allows use to use it directly as an argument to the SCSIDeviceInfo
callback functions and remove the lookup.

A new callback function 'alloc_req' is introduced matching 'free
req'; unref'ing to free up resources after use is moved into the
scsi_command_complete callbacks.

This temporarily introduces a leak of requests that are cancelled,
when they are removed from the queue and not from the driver. This
is fixed later by introducing scsi_req_cancel. That patch in turn
depends on this one, because the argument to scsi_req_cancel is a

Signed-off-by: Hannes Reinecke <>
Signed-off-by: Paolo Bonzini <>
Reviewed-by: Christoph Hellwig <>


  • added
  • modified
  • copied
  • renamed
  • deleted

View differences