« Previous | Next » 

Revision 61ed2684

ID61ed2684539f7f31304e193d7c0e68d57ce6be88

Added by Max Reitz over 10 years ago

block: Don't copy backing file name on error

bdrv_open_backing_file() tries to copy the backing file name using
pstrcpy directly after calling bdrv_open() to open the backing file
without checking whether that was actually successful. If it was not,
ps->backing_hd->file will probably be NULL and qemu will crash.

Fix this by moving pstrcpy after checking whether bdrv_open() succeeded.

Signed-off-by: Max Reitz <>
Reviewed-by: Benoit Canet <>
Reviewed-by: Amos Kong <>
Signed-off-by: Kevin Wolf <>

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences