« Previous | Next » 

Revision 76486736

ID7648673636bbd7dcb9abf3cc87a8ba7a65b85436

Added by Peter Maydell over 10 years ago

hw/dma/omap_dma: Fix bugs with DMA requests above 32

The drqbmp field of struct soc_dma_s is a uint64_t; however several
places in the code attempt to set bits in it using "(1 << drq)",
which will fail if drq is large enough that the 1 bit gets shifted
off the top of a 32 bit integer. Change these to "(1ULL << drq)" so
that the promotion to 64 bit happens before the shift rather than
afterwards.

Signed-off-by: Peter Maydell <>
Message-id:

Files

  • added
  • modified
  • copied
  • renamed
  • deleted

View differences