Statistics
| Branch: | Revision:

root / hw / ide @ 7aa9c811

Name Size
cmd646.c 9.1 kB
core.c 87.4 kB
internal.h 18.4 kB
isa.c 3.5 kB
macio.c 8.1 kB
microdrive.c 17.5 kB
mmio.c 4 kB
pci.c 5.3 kB
pci.h 788 Bytes
piix.c 6 kB
qdev.c 4 kB
via.c 6.2 kB

Latest revisions

# Date Author Comment
7aa9c811 07/06/2010 06:05 pm Markus Armbruster

ide: Reject readonly drives unless CD-ROM

drive_init() doesn't permit option readonly for if=ide, but that's
worthless: we get it via if=none and -device.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Kevin Wolf <>
f597627f 07/06/2010 06:05 pm Markus Armbruster

ide: Improve error messages

Use error_report(), because it points to the error location.

Reword "tried to assign twice" messages to make it clear that we're
complaining about the unit property.

Report invalid unit property instead of failing silently.
...
cd8722bb 07/06/2010 06:05 pm Markus Armbruster

ide: Replace IDEState members is_cdrom, is_cf by drive_kind

The two aren't independent variables. Make that obvious.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Kevin Wolf <>
c4d74df7 07/06/2010 06:05 pm Markus Armbruster

ide: Make ide_init_drive() return success

It still always succeeds. The next commits will add failures.

Signed-off-by: Markus Armbruster <>
Signed-off-by: Kevin Wolf <>
f8b6cc00 07/02/2010 02:18 pm Markus Armbruster

qdev: Decouple qdev_prop_drive from DriveInfo

Make the property point to BlockDriverState, cutting out the DriveInfo
middleman. This prepares the ground for block devices that don't have
a DriveInfo.

Currently all user-defined ones have a DriveInfo, because the only way...
18846dee 07/02/2010 02:18 pm Markus Armbruster

block: Catch attempt to attach multiple devices to a blockdev

For instance, -device scsi-disk,drive=foo -device scsi-disk,drive=foo
happily creates two SCSI disks connected to the same block device.
It's all downhill from there.

Device usb-storage deliberately attaches twice to the same blockdev,...
7d0d6950 07/02/2010 02:18 pm Markus Armbruster

block: Fix virtual media change for if=none

BlockDriverState member removable controls whether virtual media
change (monitor commands change, eject) is allowed. It is set when
the "type hint" is BDRV_TYPE_CDROM or BDRV_TYPE_FLOPPY.

The type hint is only set by drive_init(). It sets BDRV_TYPE_FLOPPY...
57c88866 07/02/2010 02:18 pm Markus Armbruster

ide: Make PIIX and ISA IDE init functions return the qdev

Signed-off-by: Markus Armbruster <>
Signed-off-by: Kevin Wolf <>
c0897e0c 07/02/2010 02:18 pm Markus Armbruster

pc: Fix CMOS info for drives defined with -device

Drives defined with drive if=ide get get created along with the IDE
controller, inside machine>init(). That's before cmos_init().
Drives defined with -device get created during generic device init.
That's after cmos_init(). Because of that, CMOS has no information on...
fa12fbbe 07/02/2010 02:18 pm Markus Armbruster

ide: Make it explicit that ide_create_drive() can't fail

All callers of ide_create_drive() ignore its value. Currently
harmless, because it fails only when qdev_init() fails, which fails
only when ide_drive_initfn() fails, which never fails.

Brittle. Change it to die instead of silently ignoring failure....

View revisions

Also available in: Atom